[Koha-bugs] [Bug 5877] Offline circulation improvements : upload all files, apply at once

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5877

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #47 from M. de Rooy <m.de.rooy at rijksmuseum.nl> 2012-02-20 12:34:47 UTC ---
QA Comment (first patch): Looks good in general, just a few points need
attention.

C4/Circulation.pm:
Please adjust or send a follow up for AddOfflineOperation:
The insert statement does not mention the field names. If the table structure
is changed some day, this kind of statement will fail.

offline_circ/list.pl, offline_circ/process.pl, offline_circ/service.pl: 
Address of Free Software Foundation is not correct. 
Please add use strict and use warnings.
Please confirm too if tests do not show any warnings in your logfile.

Second patch looks good. Marked as Passed QA in attachment name.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.