[Koha-bugs] [Bug 7420] Add max fines to circulation matrix
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Mon Feb 20 22:08:49 CET 2012
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7420
Paul Poulain <paul.poulain at biblibre.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|PATCH-Sent (DO NOT USE) |P3
Status|Signed Off |Failed QA
CC| |paul.poulain at biblibre.com
--- Comment #14 from Paul Poulain <paul.poulain at biblibre.com> 2012-02-20 21:08:49 UTC ---
QA comments:
* the logic behind UpdateFines is changed. Maybe/probably it's worth a few
comment lines in the script itself. I think it's OK, but a comment would help
me
* the indent of your patch is 2 spaces, should be 4 (PERL6 coding guideline)
marking failed QA, once the 2 comments are fixed (either by a follow-up or a
new patch), directly go to signed off, as it won't change anything to the
feature itself, thanks
--
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
More information about the Koha-bugs
mailing list