[Koha-bugs] [Bug 6968] Show items expired before today in check expiration of serials page

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6968

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #10 from Paul Poulain <paul.poulain at biblibre.com> 2012-02-21 14:29:18 UTC ---
(In reply to comment #9)
> Where is "showexpiredtoday" getting the string value "on"?  There is no
> explicit value passed by the template.  Is "on" the value passed by a checkbox
> by default on all browsers?  I think having an explicit value in the template
> here would be more solid and stable.
> 
> Not quite ready to mark this as "Failed QA", but I would like some explanation
> of the safety of this before I mark it passed.

Ian is right: you can't rely on the value "on", you should just test if there
is something. Chrome returns 0/1 afaik while FF returns empty/on

However, i mark failed QA for another reason:
i've 2 subscriptions in my database.
One that has expired in 2010, one that will expire in march 2012.

If I set the date to 2012-12-12 I should see 1 or 2 subscriptions in my list,
depending on the whether the checkbox has been checked or no.

If checked: I get 2, that's correct
If unchecked: I get none, that's not correct.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.