[Koha-bugs] [Bug 7577] Suggestion show page

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7577

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
            Version|unspecified                 |master

--- Comment #2 from Owen Leonard <oleonard at myacpl.org> 2012-02-22 15:30:17 UTC ---
There are some HTML markup issues with the template for suggestion.pl:

Because the validator doesn't like when you use a <label> without an input,
there is an alternative for displaying information which isn't in a form: <span
class="label">. Using that will give you the same visual style and keep the
validator happy.

I would probably make display of each of those lines conditional on the
existence of the data:

        [% IF ( total ) %]<li>
          <span class="label">Total</span>[% total %]
        </li>[% END %]

...but others might disagree. I'm not sure when the absence of data is
important data.

There's also a problem with the conditional display of the page's structural
markup. There is a superfluous section at the bottom of the page source:

<div id="doc3" class="yui-t2">
<div id="bd">
    <div id="yui-main">
    <div class="yui-b">

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.