[Koha-bugs] [Bug 5668] Star ratings in the opac

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #45 from Owen Leonard <oleonard at myacpl.org> 2012-02-22 16:02:43 UTC ---
A couple of markup issues: 

<input class="auto-submit-star" type="radio"  name="rating[% biblionumber %]" 
value="1" [% IF (rating_val_1) %]checked="1"[% END %] [% IF (rating_readonly)
%]disabled="disabled"[% END %]   />

'checked="1"' should be 'checked="checked"', and embedding [% IF %] inside a
tag goes against a coding guideline we have to prevent errors with the
translation script:

oleonard at oleonard-desktop:~/kohaclone$ prove xt
xt/permissions.t .. ok    
xt/tt_valid.t ..... 1/1 
#   Failed test 'TT syntax: not using TT directive within HTML tag'
#   at xt/tt_valid.t line 55.
# Files list: 
# opac-tmpl/prog/en/modules/opac-detail.tt: 501, 502, 503, 504, 505
# opac-tmpl/prog/en/modules/opac-results.tt: 539, 540, 541, 542, 543
# Looks like you failed 1 test of 1.

It also looks to me like several of the issues raised in comment 41 have not
been addressed.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.