[Koha-bugs] [Bug 7408] Expire holds that have been waiting too long

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7408

Kyle M Hall <kyle.m.hall at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kyle.m.hall at gmail.com

--- Comment #6 from Kyle M Hall <kyle.m.hall at gmail.com> 2012-02-23 17:13:09 UTC ---
(In reply to comment #4)

That does seem like a simpler solution, and the fewer cronjobs, the better.
Patch submitted.

> I've tested this successfully but have one question about how it works: After
> running the script, the holds get an expiration date of today. Running
> cronjobs/holds/cancel_expired_holds.pl immediately afterwards will cancel
> expired holds, but only those with an expiration date *less* than today. So
> none of the holds expired by this new script will be cancelled. If I then run
> the new script again with the --charge option the user will get double fines.
> 
> I know this isn't they way the script would typically be run, but it's
> worrisome to me.
> 
> On another note, testing this makes me wonder: Why don't we simply set an
> expiration date at the time the hold is marked waiting, based on the
> ReservesMaxPickupDelay setting?

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.