[Koha-bugs] [Bug 7553] automated checking that "need signoff" patch still applies

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Feb 24 09:54:25 CET 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7553

Julian Maurice <julian.maurice at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |julian.maurice at biblibre.com

--- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> 2012-02-24 08:54:25 UTC ---
2 remarks on this new script:

- Because of line 85 "$bugtotest =~ /(....)(.*)/;" and line 87 "if ($bugnumber
=~ /\d{4}/) {" it will only handle bug numbers with 4 digits. It's the most
common case, but if we make the change now, we will not have to do it when we
will reach bug 10000

- "$gitbz = `git bz apply $bugnumber <yyyy`;" Why are you using this file
filled with 'y' characters? Isn't 'yes' doing what you want (`yes | git bz
apply $bugnumber`) ?

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.


More information about the Koha-bugs mailing list