[Koha-bugs] [Bug 7144] Floating collection

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7144

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #22 from Paul Poulain <paul.poulain at biblibre.com> 2012-02-27 13:17:23 UTC ---
QA comment (continued)

* the [HTML4] coding guideline about upercase was not respected, attaching a
follow-up fixing that, please counter-signoff welcomed
* I think the smart-rules documentation need a little update:
In the last section, it's written:

Holds policy by item type for Branch 1

For this library, you can edit rules for given itemtypes, regardless of the
patron's category.

Currently, this means hold policies. The various policies have the following
effects:

    From any library: Patrons from any library may put this item on hold.
(default if none is defined)
    From home library: Only patrons from the item's home library may put this
book on hold.
    No holds allowed: No patron may put this book on hold.

Note that if the system preference AllowHoldPolicyOverride is enabled, these
policies can be overridden by your circulation staff. Also, these policies are
based on the patron's home library, not the library where the hold is being
placed.. 

There's not reference to return policy.

It's worth adding some documentation for it.
And, more specifically, how it interfere with the 
"Default checkout, checkin and hold policy for Branch 1"
which one is used first if both are specified ?

Note that in my follow-up, there's also a small addition to the documentation
of the default rules section (the 2nd one, just after the main rules)

-    <h3>Default checkout and hold policy for [% IF ( humanbranch ) %][%
humanbranch %][% ELSE %]all libraries[% END %]</h3>
-        <p>You can set a default maximum number of checkouts and hold policy
that will be used if none is defined below for a particular item type or
category.</p>
+    <h3>Default checkout, checkin and hold policy for [% IF ( humanbranch )
%][% humanbranch %][% ELSE %]all libraries[% END %]</h3>
+        <p>You can set a default maximum number of checkouts, hold policy and
checkin policy that will be used if none is defined below for a particular item
type or category.</p>


Please:
* signoff my follow-up
* add a small follow-up to document the default itemtype checkin policy & how
it interfere with the default one

(switch back to passed QA when it's done)

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.