[Koha-bugs] [Bug 7169] Change booksellers search results display

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7169

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #8 from Paul Poulain <paul.poulain at biblibre.com> 2012-02-27 15:58:59 UTC ---
QA comment:
 * remove some SQL code in .sql, that's good !
 * switch from tableSorter to datatable, that's good
 * cleanly add a sub in C4/Acquisition
 * perlcritic is OK

Marking failed QA because small/trivial follow-up suggested by katrin would be
cool:
(In reply to comment #5)
> make take up a bit more space though. I think it would be nice to get some more
> opinions on the display.
Usually the library enter at least a part of the supplier, so it's OK to have a
wider list. The gain for having non-nested <table> is worth it !

> Some notes:
> I am wondering a bit about the list of vendors on top, perhaps this could go
> into a filter box on the left side instead? 
Good idea. And another option would be to have a select instead of <a href>.
The librarian want to find just 1 vendor usually. What is interesting with the
idea is that all booksellers are on the top of the page. With dozens of
suppliers, the list will be long. With a select, it will solve this problem.
(select with auto-submit, no need to select THEN click OK)
julian a small follow-up possible ?

> Perhaps we could also make the columns on the result page match the
> descriptions on the order receive page (/acqui/parcels.pl?booksellerid=3).
> Item Count     Biblio count     Items expected
good catch, will also easy translatability ! Julian, follow-up required

> For functionality I only found one small thing: I noticed there is a warning in
> the logs when searching booksellers. Perhaps you could fix this in a follow-up?
I couldn't reproduce it. Where you testing with "mysql" user or any specific
thing ?

> There is also an error when checking for XHTML validity:
> Line 304, Column 151: cannot generate system identifier for general entity "op"

Katrin, how did you get this ?

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.