[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #38 from Paul Poulain <paul.poulain at biblibre.com> 2012-02-27 16:51:35 UTC ---
QA comment:
1- am I wrong if I say that the most important new features are not here yet
(share a list, temporary share via a temporary key)
2- Am I wrong if I say that the user can't (at least for instance) set
allow_add, allow_delete_own, allow_delete_other themselves
3- you have added many sub to opac-addbybiblionumber.pl, without any pod doc,
please add at least a few lines for each of them
4- please confirm those sub in opac-addbybiblionumber.pl are not worth being
moved to C4::
5- there are many tab, please change for 4 spaces (PERL6
http://wiki.koha-community.org/wiki/Coding_Guidelines)
6- the name "GetSomeShelfNames" sound strange and unusal. What does the "Some"
mean ? shouldn't it be GetShelfNamesBy... instead ?
7- borrower deletion: I agree that deletion of a borrower should not result
always in shelved deletion. BUT there should be fallback with FK, just in case
borrowers are deleted from mySQL, not through Koha. I mean: the
HandleDelBorrower should not prevent us from having a FK


* do you have a timeline for #1 and #2 ?
* marking failed QA for 3 and 5
* please answer to 4, 6 and 7, maybe with a follow-up, maybe with a comment

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.