[Koha-bugs] [Bug 7515] authorized value code showing in opac for public note

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Mon Feb 27 18:13:38 CET 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7515

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #11 from Paul Poulain <paul.poulain at biblibre.com> 2012-02-27 17:13:38 UTC ---
QA comment:
* my pre-apply hook complains:
"my" variable $authorised_valuecode masks earlier declaration in same scope at
/home/paul/koha.dev/koha-community//C4/Items.pm line 1264.


Looking at the code, you're adding
+        my ($authorised_valuecode) =
C4::Koha::GetAuthValCode('items.itemnotes', $data->{frameworkcode});

and $authorised_valuecode is declared a few line before.

Removing the my is probably enough, please fix, test & resubmit.

(the code is fine otherwise)

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.


More information about the Koha-bugs mailing list