[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #40 from M. de Rooy <m.de.rooy at rijksmuseum.nl> 2012-02-27 18:45:08 UTC ---
(In reply to comment #38)
> 5- there are many tab, please change for 4 spaces (PERL6
> http://wiki.koha-community.org/wiki/Coding_Guidelines)
Oops, this is not my greatest specialty. Can we run something generic on the
files where many lines were changed? Perhaps also in a specific commit that
only does that kind of thing? 

> 6- the name "GetSomeShelfNames" sound strange and unusal. What does the "Some"
> mean ? shouldn't it be GetShelfNamesBy... instead ?
I called it Some, because that is what the routine does (and what Koha already
did). The routine does not get all columns, but only returns names and numbers
for some shelves (10 to 20). But I would be happy to send a followup for a
better name, agreeing that it sounds unusual. Do you have a suggestion? 

> 7- borrower deletion: I agree that deletion of a borrower should not result
> always in shelved deletion. BUT there should be fallback with FK, just in case
> borrowers are deleted from mySQL, not through Koha. I mean: the
> HandleDelBorrower should not prevent us from having a FK
There are already some FKs here with a cascaded delete and that works fine. If
you delete e.g. a shelf, all biblios and all shares will be automatically
purged that way. (I discovered now that the lines deleting them in
HandleDelBorrower are not needed.) The advantage of not having the cascade on
owner in virtualshelves itself helps us to retain public and shared lists. The
routine purges unused shared lists. A followup in the form of an admin job
could purge public lists without owner, if a library really wants to do so.
In summary, I think that the situation improves compared to current Koha.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.