[Koha-bugs] [Bug 7307] OPACBaseURL not used in opac-search.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7307

--- Comment #14 from Adrien SAURAT <adrien.saurat at biblibre.com> 2012-01-06 11:36:46 UTC ---
1) Hm, not sure here, but will this change break the URL for installations
where
no full URL is entered? 
-> Yes.

2) Can we make the update take care about it? (preferred)
-> Not totally safe, we could assume that we can add "http://" at the beginning
of the existing value, this would solve most cases. But the point of this "full
URL" change is that some people may need "https" instead, and we have no way to
decide between http and https.

3) Or have a note in the update process that people have to change the
preference?
-> Would be good, but where could this appear ? I don't know very well this
part yet (I'm creating a new field for another patch so I'm discovering the
update process, but what if we don't create a field, as here ?).

4) Should staffClientBaseURL be changed to work like that as well?
-> Didn't know this one !
A grep on the whole koha code shows only one actual use of this preference, in
"/misc/load_testing/benchmark_circulation.pl", in the following line:
my $baseurl= C4::Context->preference("staffClientBaseURL")."/cgi-bin/koha/"
It's already working like this new version of OPACBaseURL, and the
"staffClientBaseURL" hint only says "Specify the base URL of the staff client",
so I guess we're fine on this one.

5) Sorry for so many questions :)
Kein Problem! :)

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.