[Koha-bugs] [Bug 929] See details of a budget

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=929

--- Comment #22 from Chris Cormack <chris at bigballofwax.co.nz> 2012-01-06 17:41:59 UTC ---
(In reply to comment #19)
> I'm OK to put this patch, but it introduce a new (internal) feature i'd like to
> advertise before pushing.
> 
> Chris, could you explain the consequences for dates fields ? Does it mean we
> don't need to format them in pl anymore but just throw them "as they are",
> like:
> [% order.entrydate | $KohaDates %] ?
> 

Not as they are, but as they come from the database. It will format them in the
style specified by the syspref. But you cant throw 20/2/2011 at it. Then need
to be iso style dates.

> (and :
> -        my $entrydate = C4::Dates->new( $data->{'entrydate'}, 'iso' );
> -        $data->{'entrydate'} = $entrydate->output("syspref");
> -        my $datereceived = C4::Dates->new( $data->{'datereceived'}, 'iso' );
> -        $data->{'datereceived'} = $datereceived->output("syspref");
> to remove lines that are now useless ?
> 
> I like it. But if we want to adopt this tool (and I think we should), it must
> be validated & a bug entry must be open to clean all dates formattings in Koha
> !
> 
I think cleaning as people find them is fine, Also not all should be changed,
only ones that are used for populating .tt files. 

But it does allow you to let the display be formatted in the template rather
than the .pl or .pm


> Chris, please give me details, i'll take care of the bugzilla & mail to
> koha-devel

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.