[Koha-bugs] [Bug 929] See details of a budget

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=929

--- Comment #24 from Chris Cormack <chris at bigballofwax.co.nz> 2012-01-10 02:50:28 UTC ---
(In reply to comment #23)
> (In reply to comment #22)
> > Not as they are, but as they come from the database.
> that's exactly what I was meaning by "as they are".
> 
> > > I like it. But if we want to adopt this tool (and I think we should), it must
> > > be validated & a bug entry must be open to clean all dates formattings in Koha
> > I think cleaning as people find them is fine, Also not all should be changed,
> > only ones that are used for populating .tt files. 
> I agree, i'll create the bug for it, it will be an omnibus for date display
> cleaning, nothing more, nothing less.
> 
> I forgot to add something about QA: there is no unit test. Even if it will be a
> trivial one, please follow-up with one & i'll push

It is a display only change that can only be called in TT template, so it will
indeed be a trivial one to test compilation which one of the 00 tests does
already. But if the rule is no patches pushed without a unit test, then thats
great and I hope it is applied for everybody. I look forward to seeing no
patches pushed without unit tests.

Once I am back from holiday I will create a simple unit test.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.