[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430

--- Comment #4 from Jared Camins-Esakov <jcamins at cpbibliography.com> 2012-01-19 14:04:26 UTC ---
(In reply to comment #3)
> This is a great first step to permit Koha to use different search engines.
> 
> I just want to add some remarks.
> 
> First, why a new Koha::Utils ? Isn't C4::AuthoritiesMarc the good place for
> GetAuthType ? If moving from C4 to Koha namespace, I would prefer something
> like Koha::Authority::Type or Koha::AuthorityType for such a function.
> I have no suggestion for GetMarcFromKohaField but I think it must be placed
> anywhere but here. I believe we all agree that we don't want a new C4::Koha.

We don't want any circular dependencies, and this helps reduce them. The
reasoning behind Koha::Utils is that it seemed like a reasonable name for a
module that provided utility functions to access Koha state information.
Counter-patches gratefully accepted.

> It seems that Koha::Search::Engine::Zebra::get_indexes returns a arrayref,
> Koha::Search::Engine::get_indexes and Koha::Search::GetIndexes return directly
> this arrayref, and it's assigned to a hash. I think there is a problem here.

I think you are right. ;) Good catch.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.