[Koha-bugs] [Bug 5668] Star ratings in the opac

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5668

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #41 from Jonathan Druart <jonathan.druart at biblibre.com> 2012-01-19 15:08:07 UTC ---
QA comment:

1/ Why did you comment some unit tests ? They are ok.

2/ You declare OpacStarRatings for template in C4::Auth, but it is only used in
2 tmpl (opac-results.tt and opac-detail.tt). Isn't it better to declare them in
their respective pl file ?

3/ Why have you set the POD in the end of the module and not before each
function like (nearly) everywhere in Koha ? (C4::Ratings)

4/ There is a TODO in opac/opac-ratings-ajax.pl :) Moreover, in this script,
why the "use warnings" line is commented ?
+ I think the use of C4::Dates can be deleted

5/ Why don't you create a foreign key for biblionumber and borrowernumber with
"on delete cascade" in the ratings table ?

6/ It appears that a more recent version of jquery.ratings.js exists (v3.13 vs
v3.10) it is certainly not important, but why don't have choose the lastest ? I
don't have checked the difference between both.

7/ Some useless comment lines are still present (#use Smart::Comments '####';)

8/ As said Katrin, javascript code is generated into a .pl file, isn't it
possible to open an alert into the javascript code ? After returns of ajax
response for example ?

Else, all works fine, great job :)

Marked as Failed QA.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.