[Koha-bugs] [Bug 5473] 952 fields should be filled in by Acquisitions

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5473

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|PATCH-Sent (DO NOT USE)     |P2
             Status|Signed Off                  |Passed QA
            Version|master                      |rel_3_6

--- Comment #22 from Paul Poulain <paul.poulain at biblibre.com> 2012-01-20 15:32:40 UTC ---
QA comment:
* a warn must be removed:
+    warn "AAA $itemnumber";
* the patch also updated some PODDOC and removed some commented code

I made a follow-up:
* removing the warn
* updating some indentation (s/tab/4 spaces/, that where not in the patch, but
where here since years)

I made tests with UNIMARC, everything is OK (as I suspected, as there is no
more hardcoded values, and using ModItem is the way to go)

Just about:
> Interface to ModItem() is just insane...

This is a little bit short man. What is insane, and which alternative do you
propose ? Just saying it's insane won't help fixing the insanity ;-)

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.