[Koha-bugs] [Bug 7178] Improve order item creation

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7178

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |katrin.fischer at bsz-bw.de
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=7175

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> 2012-01-22 19:26:58 UTC ---
Hi Julian, 

I did some tests and looked at the code. I found some things:

1) File name an function of check_unicity.pl
create mode 100755 acqui/check_unicity.pl
I think perhaps it should be check_uniqueness? 
How does this work? Can you add some notes about this feature?
I see it includes copynumber. Is it configurable which fields will be checked
for uniqueness? 
Barcode should always be unique. But for stocknumber and copynumber I think it
depends on the library.


2) Untranslatable strings
koha-tmpl/intranet-tmpl/prog/en/js/additem.js contains some strings. In order
to be translatable those must be moved into the template, some examples:
+            alert(_("You can't receive any more items."));
+    var show_link = "<a href='#items' onclick='showItem(\"" + index +
"\");'>Show</a>";
+    var del_link = "<a href='#' onclick='deleteItemBlock(this, \"" + index +
"\");'>Delete</a>";
+            var buttonClear = '<a name="buttonClear" style="cursor:pointer;
color:grey; font-size:180%" onclick="clearItemBlock(this)">Clear</a>';


3) Typo? koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
+    [% END %][%# IF (AcqCreateItemOrdering) %]


4) I have set a see also to bug 7175 - I think both features are related
affecting different settings of AcqCreateItem and item creation.


5) AcqCreateItem set to 'on order'
The item form does not show for me at all. I have an empty 'item' section under
'catalog details'. FireBug shows a javascript error:
var clone = original.cloneNode(true);    

Failing QA here.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.