[Koha-bugs] [Bug 6210] Choose framework on Merge

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Tue Jan 24 12:13:42 CET 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6210

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #16 from Paul Poulain <paul.poulain at biblibre.com> 2012-01-24 11:13:42 UTC ---
QA comments:
1- there is an unconditionnal warn: warn qq{No marc tags for framework
"$frameworkcode" field $kohafield};
2- strengthen/clean the code on some subs by:
   - testing input parameters (_koha_marc_update_bib_ids)
   - switching a if !cond {A} else {B} to a if cond {B} else {A}
(this was not announced, it's OK, but would have been better if announced
3- cataloguing/merge.pl add a 
+use C4::Koha;
=> where is this C4::Koha used ? (I can't see, as there are also a lot of
reindenting)
4- my tests show a look I think strange, was it intended ? (screenshot
attached)

Failed QA for 1, waiting for an answer to 3 and 4, (2 is OK)

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA Contact for the bug.
You are watching all bug changes.


More information about the Koha-bugs mailing list