[Koha-bugs] [Bug 7480] New: authorisedbyname filled twice in neworderempty.pl

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7480

             Bug #: 7480
           Summary: authorisedbyname filled twice in neworderempty.pl
    Classification: Unclassified
 Change sponsored?: ---
           Product: Koha
           Version: master
          Platform: All
        OS/Version: All
            Status: ASSIGNED
          Severity: trivial
          Priority: P5 - low
         Component: Acquisitions
        AssignedTo: adrien.saurat at biblibre.com
        ReportedBy: adrien.saurat at biblibre.com
         QAContact: koha.sekjal at gmail.com


In the "neworderempty.pl" file, as we are filling the template->param(*) info
beginning on line 346, we have a value appearing twice:

- in line 359,
authorisedbyname     => $basket->{'authorisedbyname'},

- in line 365,
authorisedbyname => $borrower->{'firstname'} . " " . $borrower->{'surname'},

Moreover, this line 365 generates log lines like the following:
[Tue Jan 31 14:39:41 2012] neworderempty.pl: Use of uninitialized value in
concatenation (.) or string at
/home/asaurat/workspace/versions/community/acqui/neworderempty.pl line 346.
[Tue Jan 31 14:39:41 2012] neworderempty.pl: Use of uninitialized value in
concatenation (.) or string at
/home/asaurat/workspace/versions/community/acqui/neworderempty.pl line 346.

These log entries are easy to correct if we keep the $borrower version, but
that's my question: which line should we keep? Or maybe both values can be ok
but one has priority over the other one?

This authorisedbyname variable is linked to a "Managed by:" label in the
template.

-- 
Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.