From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 02:26:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 00:26:10 +0000 Subject: [Koha-bugs] [Bug 8172] Missing dereference marker for buildQuery parameter in addbooks.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10564|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 10576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10576&action=edit Bug 8172 - Missing dereference marker for buildQuery parameter in addbooks.pl Added a dereference to an array parameter of buildQuery. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 02:27:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 00:27:02 +0000 Subject: [Koha-bugs] [Bug 8172] Missing dereference marker for buildQuery parameter in addbooks.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 02:30:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 00:30:19 +0000 Subject: [Koha-bugs] [Bug 7589] tinymce editor broken in .deb packages - in 'en' templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7589 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #8 from Chris Cormack --- Hmm is this still a problem? Robin can you check, and elevate the severity if so please -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 02:53:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 00:53:03 +0000 Subject: [Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P1 - high Version|rel_3_4 |master --- Comment #19 from Chris Cormack --- Liz, did you get a chance to look? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 02:55:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 00:55:14 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P2 --- Comment #40 from Chris Cormack --- If someone else could test this that would be good. Would be great to get it fixed, and it might well be that I was testing wrong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 02:56:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 00:56:53 +0000 Subject: [Koha-bugs] [Bug 8175] Missing defined check in catalogue/details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10566|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 10577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10577&action=edit Bug 8175 - Missing defined check in catalogue/details.pl Actually, just dropping the "ne ''" was better. In some cases $item->{'materials'} isn't defined. Any value is true, so no need for comparison. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 02:57:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 00:57:18 +0000 Subject: [Koha-bugs] [Bug 8175] Missing defined check in catalogue/details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 02:58:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 00:58:49 +0000 Subject: [Koha-bugs] [Bug 7299] ILSDI HoldItem service does't set the itemnumber in reserves table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7299 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 03:01:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 01:01:53 +0000 Subject: [Koha-bugs] [Bug 4226] bulkmarcimport.pl doesn't replace 001 when keepids is not specified In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4226 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6525|0 |1 is patch| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 03:02:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 01:02:35 +0000 Subject: [Koha-bugs] [Bug 4226] bulkmarcimport.pl doesn't replace 001 when keepids is not specified In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4226 --- Comment #6 from Chris Cormack --- Patch is not in git format, fixing now -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 03:07:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 01:07:01 +0000 Subject: [Koha-bugs] [Bug 4226] bulkmarcimport.pl doesn't replace 001 when keepids is not specified In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4226 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6525|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 10578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10578&action=edit Bug 4226 : New script to keep 001 numbers when importing -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 03:07:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 01:07:37 +0000 Subject: [Koha-bugs] [Bug 4226] bulkmarcimport.pl doesn't replace 001 when keepids is not specified In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4226 --- Comment #8 from Chris Cormack --- Git formatted patch with fixed copyright headers. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 03:11:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 01:11:02 +0000 Subject: [Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9122|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 10579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10579&action=edit Bug 3087 Fix Z39.50 server to return the correct record syntax Modify Makefile.PL and Zebra configuration files in order to parametrized biblio record type returned by Zebra Z39.50 server. How to test: - Test with a MARC21 and a UNIMARC DB - Do a new installation - Search from OPAC - Search from a Z39.50 client like yaz-client: syntax = MARC21/UNIMARC must be choosed - It was working for MARC21: it continues to work - It wasn't working for UNIMARC: it works now, both in OPAC and from a Z39.50 client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 03:11:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 01:11:43 +0000 Subject: [Koha-bugs] [Bug 3087] Z39.50 server returns usmarc format records for UNIMARC DB In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3087 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Rebased 1/7/2012, still needs testing and if it is accepted will need a patch to update the packages also -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 03:13:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 01:13:17 +0000 Subject: [Koha-bugs] [Bug 8235] Packaging scripts get upset with non-Debian perl modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8235 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10222|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 10580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10580&action=edit Bug 8235 - allow a whitelist of modules that aren't in Debian This allows modules that aren't in the main debian repos to be handled by the list-deps script when building a control file. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 03:13:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 01:13:31 +0000 Subject: [Koha-bugs] [Bug 8235] Packaging scripts get upset with non-Debian perl modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8235 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 03:14:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 01:14:21 +0000 Subject: [Koha-bugs] [Bug 8186] Form structure problem in serials claims filter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8186 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 03:16:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 01:16:57 +0000 Subject: [Koha-bugs] [Bug 7630] Warning on moremember.pl about param without key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7630 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10563|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 10581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10581&action=edit Bug 7630 - Warning on moremember.pl about param without key Move "$error => 1," to its own conditional $template->param() Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 03:17:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 01:17:21 +0000 Subject: [Koha-bugs] [Bug 7630] Warning on moremember.pl about param without key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7630 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 03:21:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 01:21:33 +0000 Subject: [Koha-bugs] [Bug 6698] Detail page for organisations should show only valid fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6698 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 03:25:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 01:25:38 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10435|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 10582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10582&action=edit Bug 8296: Add descriptive (text) published date field for serials Add a new field serial.publisheddatetext for displaying published date in another format that dateformat syspref permit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 03:27:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 01:27:12 +0000 Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #3 from Chris Cormack --- Patch reformatted so it applies, I haven't tested well enough to sign off though, but this should help someone else -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 03:48:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 01:48:06 +0000 Subject: [Koha-bugs] [Bug 8283] Replace usage of YUI Cookie utility with jQuery Cookie plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10439|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 10583 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10583&action=edit Bug 8283 - Replace usage of YUI Cookie utility with jQuery Cookie plugin Switching from YUI Cookie utility to jQuery Cookie plugin. The jQuery Cookie plugin is already used elsewhere in Koha, so no new dependencies are added. The YUI Cookie files are removed. To test, go to batch item deletion and/or batch item modification and submit a set of barcodes. On the confirmation screen select or deselect columns to show. Start over and submit your barcodes again. The confirmation screen should remember which columns you previously selected. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 03:49:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 01:49:22 +0000 Subject: [Koha-bugs] [Bug 8283] Replace usage of YUI Cookie utility with jQuery Cookie plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz --- Comment #3 from Chris Cormack --- Works fine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 03:58:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 01:58:46 +0000 Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris at bigballofwax.co.nz --- Comment #11 from Chris Cormack --- Follow up has an error if you call it without --ignore Unmatched ) in regex; marked by <-- HERE in m/) <-- HERE / at xt/find-undefined-subroutines.pl line 151. If you call it with a pattern like perl xt/find-undefined-subroutines.pl --ignore *.t Unknown verb pattern '.t' in regex; marked by <-- HERE in m/(*.t) <-- HERE / at xt/find-undefined-subroutines.pl line 151. It works if you call it with a pattern like C4 Id like to see the original patch pushed ASAP, so if this follow up could be fixed, or the original pushed and the new patch back to assigned to be fixed that would be excellent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 04:21:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 02:21:04 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack --- Patch applies ok, but uses format_date instead of using the KohaDates plugin. Signing off but adding a follow to fix the date formatting. Follow up still needs signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 04:36:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 02:36:45 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 --- Comment #3 from Chris Cormack --- Created attachment 10584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10584&action=edit Bug 8231 : Follow to fix date formatting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 04:37:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 02:37:54 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10206|0 |1 is obsolete| | Attachment #10584|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 10585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10585&action=edit Bug 8231: reminder when checking in for a restricted patron If a patron is restricted, a warning will appear on the return page when checking in. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 04:38:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 02:38:02 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 --- Comment #5 from Chris Cormack --- Created attachment 10586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10586&action=edit Bug 8231 : Follow to fix date formatting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 04:44:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 02:44:06 +0000 Subject: [Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10221|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 10587 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10587&action=edit Bug 8220 - Allow koc uploads to go to process queue instead of being applied directly. The primary advantage to the Firefox offline cirulation plugin when compared to the offline circulation desktop application, is the ability to add offline circulation actions to a queue so that multiple machines running offline circ can have their circ actions combined and ordered chronologically before being executed. This commit adds the ability to put actions from uploaded KOC files into this queue. In this way, both the FF plugina and the desktop application can be run side by side with no ill effects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 04:44:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 02:44:34 +0000 Subject: [Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Patch rebased and merge conflicts fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 05:28:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 03:28:47 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10039|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 10588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10588&action=edit Bug 8218 : Adding SanitizeEntity and entity_clean sub which replace & by & in a record Bug 8218 : adding script for maintenance to clean any & in strings Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 05:31:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 03:31:37 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz --- Comment #3 from Chris Cormack --- Follow up is textual changes on, so setting status to signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 05:31:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 03:31:43 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 --- Comment #4 from Chris Cormack --- Created attachment 10589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10589&action=edit Bug 8218 : Fixing copyright headers and license and description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 06:12:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 04:12:58 +0000 Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack --- Actually when I click on full heading and get to this page I get cgi-bin/koha/opac-authoritiesdetail.pl?authid=1 Template process failed: file error - /home/christopher/git/koha/koha-tmpl/opac-tmpl/prog/en/modules/opac-authoritiesdetail.tt: not found at /home/christopher/git/koha/C4/Templates.pm line 127. I suspect this is another bug. Will try getting to the authority record another way -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 06:27:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 04:27:33 +0000 Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 --- Comment #3 from Chris Cormack --- Hmm I have no idea how to get to an authority view in the opac that actually works. Someone will have to tell me how or test this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 12:07:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 10:07:23 +0000 Subject: [Koha-bugs] [Bug 8125] SIP should send Zipcode with address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8125 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9694|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 10590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10590&action=edit Bug 8125 Sip addess should include all address fields Expansion of Liz Rea's original patch Bug report specifically mentioned kack of the Zip/Postal code but all used address fields should be included. Moved the address generation to its own sub. Hopefully using an if else will read more clearly than the original ternary operator proved to be Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 12:07:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 10:07:58 +0000 Subject: [Koha-bugs] [Bug 8125] SIP should send Zipcode with address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8125 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 14:12:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 12:12:17 +0000 Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 --- Comment #4 from Jared Camins-Esakov --- Chris, (In reply to comment #2) > Actually when I click on full heading and get to this page I get > cgi-bin/koha/opac-authoritiesdetail.pl?authid=1 > > Template process failed: file error - > /home/christopher/git/koha/koha-tmpl/opac-tmpl/prog/en/modules/opac- > authoritiesdetail.tt: not found at > /home/christopher/git/koha/C4/Templates.pm line 127. > > I suspect this is another bug. Will try getting to the authority record > another way Did you update your repo before applying this? As far as I can see, the authorities detail template was changed to opac-auth-detail.tt by f5974e27 (bug 7943 follow-up). That patch is in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 15:03:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 13:03:53 +0000 Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10545|0 |1 is obsolete| | --- Comment #5 from Jared Camins-Esakov --- Created attachment 10591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10591&action=edit Bug 8204: Add user friendly authority view to OPAC Up until now, the only authority view in the OPAC was a rather-unfriendly expanded MARC view. This patch adds a user-friendly view similar to the biblio details view. Specific features to be aware of: * Right-to-left text in the MARC21 880 field will show up in the appropriate location with the appropriate alignment and wrapping * There is very little CSS styling. Any suggestions for how to make the display more attractive would be gratefully received. To test: 1) Do a search for an authority in the OPAC. 2) Choose an authority record to view. 3) Observe that the view is more user-friendly and polished. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 15:59:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 13:59:14 +0000 Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10591|0 |1 is obsolete| | --- Comment #6 from Jared Camins-Esakov --- Created attachment 10592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10592&action=edit Bug 8204: Add user friendly authority view to OPAC Up until now, the only authority view in the OPAC was a rather-unfriendly expanded MARC view. This patch adds a user-friendly view similar to the biblio details view. Specific features to be aware of: * Right-to-left text in the MARC21 880 field will show up in the appropriate location with the appropriate alignment and wrapping * There is very little CSS styling. Any suggestions for how to make the display more attractive would be gratefully received. To test: 1) Do a search for an authority in the OPAC. 2) Choose an authority record to view. 3) Observe that the view is more user-friendly and polished. Revised patch incorporating comments from testers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 16:08:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 14:08:28 +0000 Subject: [Koha-bugs] [Bug 8340] New: Can't modify system preferences Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8340 Priority: P5 - low Change sponsored?: --- Bug ID: 8340 CC: gmcharlt at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Can't modify system preferences Severity: enhancement Classification: Unclassified OS: Linux Reporter: hend.eleraky at bibalex.org Hardware: All Status: NEW Version: rel_3_6 Component: System Administration Product: Koha I have a problem when modifying system preferences , i tried to change a value for example "opaccredits" then i clicked "Save All OPAC preferences " button i got "Internal server error". I checked the error log and i have found this error "(2)No such file or directory: exec of '/usr/share/koha/intranet/cgi-bin/svc/config/systempreferences' failed, referer: http://10.202.2.180:8080/cgi-bin/koha/admin/preferences.pl?tab=opac ". I don't know why this file couldn't be executed although it has execute permission. Koha version usd : 3.6.5 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 16:18:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 14:18:18 +0000 Subject: [Koha-bugs] [Bug 8340] Can't modify system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8340 Hend changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high CC| |hend.eleraky at bibalex.org Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 22:19:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 20:19:38 +0000 Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 --- Comment #7 from Chris Cormack --- commit 0923e96cb4a9684db7c777866e9c822522f49a72 Author: Paul Poulain Date: Fri Jun 29 17:17:47 2012 +0200 Revert "Bug 7444: Update circ/circulation.pl to use KohaDates TT Plugin" This reverts commit 186cfa5cb00a1c0ee7f0e4512a5f319299bb6412. Yep definitely on master. and koha-tmpl/opac-tmpl/prog/en/modules/opac-authoritiessearchresultlist.tt links to And in there i can see the change, template_name => $show_marc ? "opac-auth-MARCdetail.tt" : "opac-auth-detail.tt", But I am still getting Template process failed: file error - /home/christopher/git/koha/koha-tmpl/opac-tmpl/prog/en/modules/opac-authoritiesdetail.tt: not found at /home/christopher/git/koha/C4/Templates.pm line 127. But I note ls koha-tmpl/opac-tmpl/prog/en/modules/opac-auth* koha-tmpl/opac-tmpl/prog/en/modules/opac-auth-MARCdetail.tt koha-tmpl/opac-tmpl/prog/en/modules/opac-authorities-home.tt koha-tmpl/opac-tmpl/prog/en/modules/opac-authoritiessearchresultlist.tt koha-tmpl/opac-tmpl/prog/en/modules/opac-auth.tt http://git.koha-community.org/gitweb/?p=koha.git;a=tree;f=koha-tmpl/opac-tmpl/prog/en/modules;h=5330fbfa93f85233cebf2b7ceed1cc495b0ff4b3;hb=0923e96cb4a9684db7c777866e9c822522f49a72 That file does not exist, perhaps thats why its falling back. Am I going blind or does opac-auth-detail.tt really not exist in master? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 22:29:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 20:29:17 +0000 Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 --- Comment #8 from Chris Cormack --- So yes, currently before this patch is applied it is not just ugly, but totally and utterly broken. Due to the fact bug 7943 was pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 22:32:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 20:32:37 +0000 Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 --- Comment #9 from Chris Cormack --- This is doing my head in. Someone else will have to test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jul 1 23:46:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 21:46:49 +0000 Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 --- Comment #10 from Jared Camins-Esakov --- (In reply to comment #8) > So yes, currently before this patch is applied it is not just ugly, but > totally and utterly broken. > > Due to the fact bug 7943 was pushed. This seems to be specific to your installation, as it's working for others on unmodified master, and works fine for me even on a completely new installation with unadulterated master. I have absolutely no idea what the problem could be, though. I guess the thing to do is get this signed off and into master as soon as possible, and then it will be a moot point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 01:22:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 01 Jul 2012 23:22:47 +0000 Subject: [Koha-bugs] [Bug 7839] Enhancement: Show routing lists attached to patron in Patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7839 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10558|0 |1 is obsolete| | --- Comment #16 from David Cook --- Created attachment 10593 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10593&action=edit Bug 7839 : Follow up, fixing company copyright -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 02:21:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 00:21:55 +0000 Subject: [Koha-bugs] [Bug 7839] Enhancement: Show routing lists attached to patron in Patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7839 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10554|0 |1 is obsolete| | Attachment #10593|0 |1 is obsolete| | --- Comment #17 from David Cook --- Created attachment 10594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10594&action=edit Bug 7839 ENH: Add tab in patron record to show patron's routing lists Fixed the copyright and an accidental double quote bug in the template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 05:19:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 03:19:03 +0000 Subject: [Koha-bugs] [Bug 8341] New: MARC 952 field isn't being created or edited Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8341 Priority: P5 - low Change sponsored?: --- Bug ID: 8341 Assignee: gmcharlt at gmail.com Summary: MARC 952 field isn't being created or edited Severity: critical Classification: Unclassified OS: All Reporter: dcook at prosentient.com.au Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha At first, we thought this might be an issue just with our install of 3.8, but BibLibre's sandbox #1 seems to have the same problem. When a new MARC record is created and items are added, no 952 field is created. Even when a MARC record has a 952 and items are changed, the 952 is unaffected. Any thoughts on this one? It doesn't readily show itself, but I imagine that it has quite wide-scale consequences... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 05:35:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 03:35:29 +0000 Subject: [Koha-bugs] [Bug 8341] MARC 952 field isn't being created or edited In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8341 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID Assignee|gmcharlt at gmail.com |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 08:39:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 06:39:46 +0000 Subject: [Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #18 from M. de Rooy --- (In reply to comment #14) > However, I won't push this patch yet, because I think Koha::Utils is a too > generic term, that will quickly result in a place where there is everything > and anything. > I'll propose quickly a naming convention and organisation (and a follow-up > patch). +1 for Koha::Utils being too generic.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 08:41:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 06:41:25 +0000 Subject: [Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #19 from Chris Cormack --- (In reply to comment #18) > (In reply to comment #14) > > However, I won't push this patch yet, because I think Koha::Utils is a too > > generic term, that will quickly result in a place where there is everything > > and anything. > > I'll propose quickly a naming convention and organisation (and a follow-up > > patch). > > +1 for Koha::Utils being too generic.. I'm going to play curmudgeon, criticism without a valid counter suggestion is not useful :) So if not Koha::Utils what would you call it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 09:01:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 07:01:33 +0000 Subject: [Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #20 from Julian Maurice --- I suggest something like Koha::MARC::Framework[::Biblio] for GetMarcFromKohaField and Koha::AuthorityTypes for GetAuthType. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 09:17:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 07:17:39 +0000 Subject: [Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #21 from M. de Rooy --- (In reply to comment #19) > I'm going to play curmudgeon, criticism without a valid counter suggestion > is not useful :) So if not Koha::Utils what would you call it? A crusty, ill-tempered, and usually old man? ;) I am not sure if that may not be useful [at times], btw.. But let me give it a try: High-level configuration functions like GetMarcFromKohaField and GetAuthType.. GetAuthType looks to me like a candidate for the originally called Koha::DataObject, since it just passes the fields for auth_types table. GetMarcFromKohaField should be moved somewhere within Koha::BusinessLogic or its shorter variant. There could be room there for MARC utilities? Let's say: Koha::BusinessLogic::MarcUtils::GetMarcTagForKohaField. If we do not like MarcUtils after all, another proposal: Koha::BusinessLogic::Administration::GetMarcTagForKohaField. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 09:18:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 07:18:33 +0000 Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 --- Comment #20 from Katrin Fischer --- Ok, rereading through the bug report there is a bit that worries me: - add field X-Orig-IP with IP of sender IP addresses in web server logs have been issue of data privacy here - I wonder if it's ok adding the IP to the mail? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 09:45:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 07:45:57 +0000 Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 --- Comment #21 from M. de Rooy --- (In reply to comment #20) > Ok, rereading through the bug report there is a bit that worries me: > - add field X-Orig-IP with IP of sender > > IP addresses in web server logs have been issue of data privacy here - I > wonder if it's ok adding the IP to the mail? Would not worry about that too much. Could be lots of ip addresses in the mail headers showing the route of this message from A to B. Moreover, measures against spammers here should not be considered as privacy intruding. You can find this ip address also in your access log; that is on your server not just in the mail header.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 09:47:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 07:47:43 +0000 Subject: [Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #22 from Chris Cormack --- (In reply to comment #21) > (In reply to comment #19) > > I'm going to play curmudgeon, criticism without a valid counter suggestion > > is not useful :) So if not Koha::Utils what would you call it? > > A crusty, ill-tempered, and usually old man? ;) > I am not sure if that may not be useful [at times], btw.. But let me give it > a try: > High-level configuration functions like GetMarcFromKohaField and > GetAuthType.. > GetAuthType looks to me like a candidate for the originally called > Koha::DataObject, since it just passes the fields for auth_types table. > GetMarcFromKohaField should be moved somewhere within Koha::BusinessLogic or > its shorter variant. There could be room there for MARC utilities? > Let's say: Koha::BusinessLogic::MarcUtils::GetMarcTagForKohaField. > If we do not like MarcUtils after all, another proposal: > Koha::BusinessLogic::Administration::GetMarcTagForKohaField. Positive criticism, IE with useful suggestions on how to fix the problem is always useful, Negative criticism almost never is. Lest we become the linux kernel mailing list :-) My criticism here is those names are quite long, and I don't think these routines are business logic at all. Are we going to build an inheritance structure such that those are objects under inheriting from the classes above them, or is it just an arbitrary naming scheme. If it's arbitrary and there is no inheritance, then I like Koha::MARCUtils better. That would be my preference, but, I am not going to die in a ditch about it, I would accept something like Koha::Service::MARCUtils (Service is what BusinessLogic has moved to it seems). What I would like is this patch progressed and the remnants of no zebra to go away and stop causing us issues. And yes I am a grumpy old man :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:01:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 08:01:37 +0000 Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 --- Comment #22 from Paul Poulain --- (In reply to comment #21) > (In reply to comment #20) > > Ok, rereading through the bug report there is a bit that worries me: > > - add field X-Orig-IP with IP of sender > > > > IP addresses in web server logs have been issue of data privacy here - I > > wonder if it's ok adding the IP to the mail? > > Would not worry about that too much. Could be lots of ip addresses in the > mail headers showing the route of this message from A to B. +1, ans I suspect that, in France, it's legally requested to track this kind of things = the mail is sent by someone, the server admin must be able to answer any legal/court request -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:12:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 08:12:14 +0000 Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 --- Comment #23 from M. de Rooy --- Created attachment 10595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10595&action=edit Followup for privacy issue Paul: Katrin raised the question on privacy issue on x-orig-ip. Since we did not have it for years, i would suggest to remove it now first. And come up with a solution for all parties later on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:13:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 08:13:27 +0000 Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:13:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 08:13:40 +0000 Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:13:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 08:13:47 +0000 Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:14:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 08:14:13 +0000 Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 --- Comment #24 from M. de Rooy --- Setting this to Signed off to get Paul's attention :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:36:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 08:36:27 +0000 Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #25 from M. de Rooy --- (In reply to comment #24) > Setting this to Signed off to get Paul's attention :-) Passed QA may even be a better idea.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 10:41:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 08:41:25 +0000 Subject: [Koha-bugs] [Bug 7630] Warning on moremember.pl about param without key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7630 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Assignee|kyle.m.hall at gmail.com |mtompset at hotmail.com QA Contact|koha.sekjal at gmail.com |m.de.rooy at rijksmuseum.nl --- Comment #6 from M. de Rooy --- Good catch. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:37:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 09:37:15 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 --- Comment #17 from Jonathan Druart --- Created attachment 10596 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10596&action=edit Bug 8217: Followup: move code to the document.ready function [patch for 3.8] Hi Chris, Here is the patch for 3.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:40:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 09:40:49 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10360|0 |1 is obsolete| | --- Comment #9 from claire.hernandez at biblibre.com --- Comment on attachment 10360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10360 liste de cb for test une sandbox one bad buzilla ticket -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:41:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 09:41:48 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #18 from Chris Cormack --- Thanks Jonathan. Pushed to stable, will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:43:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 09:43:51 +0000 Subject: [Koha-bugs] [Bug 7825] Change OPACItemHolds syspref to be of type Choice, choices being "no", "yes", "force" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7825 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 11:52:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 09:52:33 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10348|0 |1 is obsolete| | --- Comment #9 from Koha Team Lyon 3 --- Created attachment 10597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10597&action=edit Patrons get incorrectly debarred From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:05:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 10:05:46 +0000 Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #22 from Jonathan Druart --- Hi Nicole, It's not this patch. The issue exists in master. I switch back to signed off. I point out the problem to Paul. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:28:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 10:28:08 +0000 Subject: [Koha-bugs] [Bug 8342] New: the link renew and expiration date Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8342 Priority: P5 - low Change sponsored?: --- Bug ID: 8342 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: the link renew and expiration date Severity: enhancement Classification: Unclassified OS: All Reporter: stephane.delaye at biblibre.com Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 12:29:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 10:29:58 +0000 Subject: [Koha-bugs] [Bug 8342] the link renew and expiration date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8342 delaye changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:18:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 11:18:38 +0000 Subject: [Koha-bugs] [Bug 8343] New: Editable discount rate and miscellaneous charges during ordering Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8343 Priority: P5 - low Change sponsored?: --- Bug ID: 8343 CC: savitra.sirohi at osslabs.biz Assignee: koha-bugs at lists.koha-community.org Summary: Editable discount rate and miscellaneous charges during ordering Severity: enhancement Classification: Unclassified OS: All Reporter: shinoy.m at osslabs.biz Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha To make the discount to be editable and add miscellaneous charges per quantity while ordering. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 13:42:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 11:42:39 +0000 Subject: [Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #13 from Kyle M Hall --- Just looking at the diff, I'm wondering if this patch only fixes it if the library has only been closed for one day, and not for multiple days at a time. Nicole's description of her understanding of the feature is that "checking the dropbox mode option on the check in screen made the due date effectively the last day the library was open". What do you think? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:00:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 12:00:53 +0000 Subject: [Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #14 from Katrin Fischer --- Hi Kyle, can't say anything about the code, but you described it right I think. That's how the feature has been documented and how I would expect it to work. So if people give something back over the weekend and I check it in Monday, the date should probably be Friday? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:04:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 12:04:22 +0000 Subject: [Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #15 from Nicole C. Engard --- Yes, that's what should happen. Dropbox means that the patrons used the drop box for book/materials outside of the library. Many libraries don't penalize patrons who drop materials off while the library is closed so when the library opens again they take everything out of the box, and want to check the items in as if they were returned on a day the library was open. The intended side effect of this is that the patrons are not charged fines for the days the library was closed (if the library uses this feature). For libraries who don't have this policy they just don't use the drop box mode. Nicole -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:22:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 12:22:54 +0000 Subject: [Koha-bugs] [Bug 7286] Introduce rebuild_zebra_sliced.zsh to recursively rebuild zebra & be error proof In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7286 --- Comment #16 from Julian Maurice --- Created attachment 10598 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10598&action=edit Bug 7286: rebuild_zebra_sliced for biblios and authorities Complete rewrite of rebuild_zebra_sliced.zsh (renamed to .sh). Main improvements are: - both biblio and authority records are handled - records are exported only once It also add an option --skip-index to rebuild_zebra.pl that permit to use rebuild_zebra.pl as an 'export only' script. As the original patch is already signed-off, I do not obsolete it so that it could be pushed in master, but I think this new version could easily replace the old one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:23:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 12:23:35 +0000 Subject: [Koha-bugs] [Bug 7684] inventory : datatable fix actions etc. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |claire.hernandez at biblibre.c | |om --- Comment #8 from claire.hernandez at biblibre.com --- Fix needs enhancement to answer to Stephane comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:28:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 12:28:35 +0000 Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:35:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 12:35:46 +0000 Subject: [Koha-bugs] [Bug 7848] Issues data missing from circulation notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9863|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 10599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10599&action=edit Bug 7848 - Issues data missing from circulation notices For the CHECKIN and CHECKOUT notices, any data that is issue specific does not show. For example, date due. For CHECKOUT, this is caused not passing in the issues table as part of the 'table' hash used by C4::Letters::GetPreparedLetter. For CHECKIN notices, we need the old_issues table instead, as the item has already been returned. Signed-off-by: Liz Rea passes tests, correct information shows in notices. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:36:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 12:36:06 +0000 Subject: [Koha-bugs] [Bug 7848] Issues data missing from circulation notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:38:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 12:38:45 +0000 Subject: [Koha-bugs] [Bug 7420] Add max fines to circulation matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7420 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:50:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 12:50:27 +0000 Subject: [Koha-bugs] [Bug 8344] New: In Opac we have a "Software error" when clicking "tag cloud" Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8344 Priority: P1 - high Change sponsored?: --- Bug ID: 8344 Assignee: christophe.croullebois at biblibre.com Summary: In Opac we have a "Software error" when clicking "tag cloud" Severity: blocker Classification: Unclassified OS: All Reporter: christophe.croullebois at biblibre.com Hardware: All Status: ASSIGNED Version: master Component: OPAC Product: Koha In Opac we have a "Software error" message when clicking "tag cloud". C4::Output version 3.02 required--this is only version 3.08.01.002 at /home/koha/src/opac/opac-tags.pl line 41. BEGIN failed--compilation aborted at /home/koha/src/opac/opac-tags.pl line 41. Due to this line => use C4::Output 3.02 qw(:html :ajax pagination_bar); With this => use C4::Output qw(:html :ajax pagination_bar); it's ok, so I'll make a patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:51:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 12:51:54 +0000 Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 --- Comment #20 from Paul Poulain --- In bug 7955, http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955#c21, Nicole spotted that the "notices" tab appear twice. This was due to the fact that this patch add the "notices" tab without removing it. Probably a rebase mistake. Will push a patch removing the duplicate tab now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:53:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 12:53:20 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon's AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 --- Comment #7 from Kyle M Hall --- Created attachment 10600 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10600&action=edit Bug 4460 - Amazon's AssociateID tag not used in links so referred revenue lost - Followup -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:53:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 12:53:33 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon's AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:53:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 12:53:57 +0000 Subject: [Koha-bugs] [Bug 8087] Calendar not working in dropbox mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8087 Albert Oller changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #5 from Albert Oller --- Hi Chris, I agree with you that this should be marked a duplicate of 5644. Thanks, Albert *** This bug has been marked as a duplicate of bug 5644 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:53:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 12:53:57 +0000 Subject: [Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Albert Oller changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tdavis at uttyler.edu --- Comment #16 from Albert Oller --- *** Bug 8087 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 14:54:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 12:54:27 +0000 Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 --- Comment #23 from Paul Poulain --- (In reply to comment #21) > Actually I think this is adding another Notices tab to the patron record. I > see Notices, Statistics, Notices on the left hand side. Was a duplicate introduced by a mistake in rebase of bug 8130. I just pushed a follow-up to fix this problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:00:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 13:00:20 +0000 Subject: [Koha-bugs] [Bug 8343] Editable discount rate and miscellaneous charges during ordering In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8343 --- Comment #1 from shinoy m --- Created attachment 10601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10601&action=edit Editable discount rate and misc charges during ordering -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:04:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 13:04:06 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 --- Comment #7 from Kyle M Hall --- Created attachment 10602 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10602&action=edit Bugfix 4118 - Add Collection Code to Statistics Table - Fix DB Update -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:04:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 13:04:39 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10213|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 10603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10603&action=edit Bugfix 4118 - Add Collection Code to Statistics Table - Updated C4 Modules to add Collection Codes to stats table Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:04:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 13:04:47 +0000 Subject: [Koha-bugs] [Bug 8344] In Opac we have a "Software error" when clicking "tag cloud" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8344 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Christophe Croullebois --- sorry I have not seen the 8315. So it's ok, I close *** This bug has been marked as a duplicate of bug 8315 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:04:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 13:04:47 +0000 Subject: [Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christophe.croullebois at bibl | |ibre.com --- Comment #13 from Christophe Croullebois --- *** Bug 8344 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:05:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 13:05:10 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10214|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 10604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10604&action=edit Bugfix 4118 - Add Collection Code to Statistics Table - DB Update Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:05:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 13:05:22 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10602|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 10605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10605&action=edit Bugfix 4118 - Add Collection Code to Statistics Table - Fix DB Update -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:06:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 13:06:09 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 15:22:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 13:22:27 +0000 Subject: [Koha-bugs] [Bug 8175] Missing defined check in catalogue/details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.sekjal at gmail.com --- Comment #5 from Ian Walls --- what about the case where $items->materials = 0? Wouldn't that assess to false, and thus not display? Zero could be a valid entry, especially if the items.materials field is linked to an authorised value list in the framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 16:19:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 14:19:03 +0000 Subject: [Koha-bugs] [Bug 8172] Missing dereference marker for buildQuery parameter in addbooks.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 --- Comment #4 from Jonathan Druart --- Created attachment 10606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10606&action=edit Bug 8172: Followup: Removes useless empty params QA Comment, Your patch is good, but I think this one adds more readability (It removes empty params passed to buildQuery). On the way, I replace an undefined variable ($debug with $DEBUG) in C4/Search.pm (introduces by the same commit 59f31b98361046af37646485f652f70e16a2e206, Bug 4116). Switch back to need signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 16:19:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 14:19:10 +0000 Subject: [Koha-bugs] [Bug 8172] Missing dereference marker for buildQuery parameter in addbooks.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 16:29:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 14:29:42 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 16:33:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 14:33:18 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 16:33:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 14:33:48 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 16:43:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 14:43:43 +0000 Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10311|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 10607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10607&action=edit [SIGNED-OFF] Bug 8202: Add authority export to tools/export.pl Rebased patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 16:43:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 14:43:55 +0000 Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Jonathan Druart --- Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 16:53:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 14:53:25 +0000 Subject: [Koha-bugs] [Bug 8175] Missing defined check in catalogue/details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 --- Comment #6 from M. Tompsett --- I see the validity of your point, Ian. What is desired is: NULL produce false trim()='' produce false everything else true (0,"0", and everything non-zero in string or number nature). I'll do a patch up later, if someone else doesn't beat me to it first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 16:59:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 14:59:17 +0000 Subject: [Koha-bugs] [Bug 8235] Packaging scripts get upset with non-Debian perl modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8235 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- For discusion: Isn't it more clean to add a key in the C4::Installer::PerlDependencies::PERL_DEPS hash (like debian) ? Rather than have to modify 2 files (1 pl and 1 pm) ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:30:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 15:30:32 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 --- Comment #30 from Kyle M Hall --- Created attachment 10608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10608&action=edit Bug 8110 - Followup - Make days_between return a number of days, instead of an object. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:31:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 15:31:32 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #31 from Kyle M Hall --- Julian, is this new patch what you are looking for, or have I just moved code around without solving the problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:36:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 15:36:45 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC|kyle.m.hall at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:41:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 15:41:39 +0000 Subject: [Koha-bugs] [Bug 5727] Use of uninitialized value in concatenation (.) or string In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5727 --- Comment #3 from Paul Poulain --- Created attachment 10609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10609&action=edit Bug 5725 : Batch Modifications for Biblios commit 66282fed94564969f0368e27c7231116a2d1c0fe Author: Chris Cormack Date: Tue Feb 22 08:43:24 2011 +1300 Bug 5725 : Follow up fixing permissions thanks to Paul Poulain commit 4d0241aea5be13b00abbc6100dc98ec87f816081 Author: Paul Poulain Date: Mon Jan 10 17:22:31 2011 +0100 Bug 5725 follow up Owen noticed the batchedit was not working. This was because we made a patch months ago to change the GetBiblio API (the 1st returned arg is useless) This patch is not in main trunk, resulting in the error owen has noticed. This patch goes back to official API (even if it is clumsy : the patch we did does not apply anymore) commit 19b3e0ecc57af1c2151340328bf06e26882b7863 Author: Paul Poulain Date: Wed Dec 15 20:47:21 2010 +0100 Bug 5725 : MT #2991 (Feature) Batch biblio modifications This patch add a new feature of batch biblio modifications, it permit to select biblios from basket, and modify fields of them setting Rebased to fix whitespace issues. Bug 5725 follow-up Fixes adresses comments 28 and 29 (from Owen) * add a link to tools-home * display the biblios before defining rules * add some help/change some wording * fixes result "Status" column (was a H:T:P => T:T glitch) and put the message on the top I also removed an unused variable Bug 5725 follow-upd, deal with leader As Owen comment 33 notices, leader update was not working. This patch fixes the problem (and fix a few reindenting glitches as well) Additional fixes for Bug 5725 - Batch modifications for Biblios - Correcting page title - Adding breadcrums - Adding sidebar menu (matching other batch mod pages) - Showing "loading" graphic during AJAX operations - Adding empty option to list of MARC tags so that onchange event will fire when the user is choosing 000 - Other structural markup changes -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:42:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 15:42:17 +0000 Subject: [Koha-bugs] [Bug 5725] Batch modifications for Biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5981|0 |1 is obsolete| | --- Comment #58 from Paul Poulain --- Created attachment 10610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10610&action=edit Bug 5725 : Batch Modifications for Biblios commit 66282fed94564969f0368e27c7231116a2d1c0fe Author: Chris Cormack Date: Tue Feb 22 08:43:24 2011 +1300 Bug 5725 : Follow up fixing permissions thanks to Paul Poulain commit 4d0241aea5be13b00abbc6100dc98ec87f816081 Author: Paul Poulain Date: Mon Jan 10 17:22:31 2011 +0100 Bug 5725 follow up Owen noticed the batchedit was not working. This was because we made a patch months ago to change the GetBiblio API (the 1st returned arg is useless) This patch is not in main trunk, resulting in the error owen has noticed. This patch goes back to official API (even if it is clumsy : the patch we did does not apply anymore) commit 19b3e0ecc57af1c2151340328bf06e26882b7863 Author: Paul Poulain Date: Wed Dec 15 20:47:21 2010 +0100 Bug 5725 : MT #2991 (Feature) Batch biblio modifications This patch add a new feature of batch biblio modifications, it permit to select biblios from basket, and modify fields of them setting Rebased to fix whitespace issues. Bug 5725 follow-up Fixes adresses comments 28 and 29 (from Owen) * add a link to tools-home * display the biblios before defining rules * add some help/change some wording * fixes result "Status" column (was a H:T:P => T:T glitch) and put the message on the top I also removed an unused variable Bug 5725 follow-upd, deal with leader As Owen comment 33 notices, leader update was not working. This patch fixes the problem (and fix a few reindenting glitches as well) Additional fixes for Bug 5725 - Batch modifications for Biblios - Correcting page title - Adding breadcrums - Adding sidebar menu (matching other batch mod pages) - Showing "loading" graphic during AJAX operations - Adding empty option to list of MARC tags so that onchange event will fire when the user is choosing 000 - Other structural markup changes http://bugs.koha-community.org/show_bug.cgi?id=5727 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:42:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 15:42:34 +0000 Subject: [Koha-bugs] [Bug 5725] Batch modifications for Biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5982|0 |1 is obsolete| | --- Comment #59 from Paul Poulain --- Created attachment 10611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10611&action=edit BZ5725 follow-up for comment 48 This small follow up: * removes "whole field" in subfield list except when dealing with a field <010 (that has no subfield) * add a missing string resulting in an "undefined" when user choosed 'Create field and subfield' and hit Add button * synch the description after adding with the description in the list box of the 4 options available * fixes indentation a little -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:43:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 15:43:59 +0000 Subject: [Koha-bugs] [Bug 5725] Batch modifications for Biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5697|0 |1 is obsolete| | --- Comment #60 from Paul Poulain --- Created attachment 10612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10612&action=edit Suggested change to Bug 5725 - Batch modifications for Biblios This modification changes the "Batch edit" button to a link in the "Selected items: " set alongside "add to a list," "place hold," etc. Instead of always batch editing all items, the user can select individual ones to be passed to the batch edit page. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:44:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 15:44:43 +0000 Subject: [Koha-bugs] [Bug 5725] Batch modifications for Biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P1 - high Status|Patch doesn't apply |Needs Signoff --- Comment #61 from Paul Poulain --- Patch rebased (& tested, seems to work) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:48:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 15:48:33 +0000 Subject: [Koha-bugs] [Bug 8235] Packaging scripts get upset with non-Debian perl modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8235 --- Comment #5 from Robin Sheat --- Possibly, but these things are pretty rare, I'd hope to not have more than a handful floating around at any one time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 17:56:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 15:56:05 +0000 Subject: [Koha-bugs] [Bug 8345] New: UNIMARC author facets are borken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8345 Priority: P5 - low Change sponsored?: --- Bug ID: 8345 Assignee: oleonard at myacpl.org Summary: UNIMARC author facets are borken Severity: major Classification: Unclassified OS: All Reporter: gaetan.boisson at biblibre.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha With unimarc the links in the author facets are broken. Using limit=au,wrdl: in the link instead of limit=au does the trick. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 18:19:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 16:19:23 +0000 Subject: [Koha-bugs] [Bug 3383] Item due reminder digests - cannot display title information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3383 --- Comment #10 from Kyle M Hall --- Created attachment 10613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10613&action=edit Bug 3383 - Followup - Switch from GetMemberDetails to GetMember -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 18:19:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 16:19:41 +0000 Subject: [Koha-bugs] [Bug 3383] Item due reminder digests - cannot display title information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3383 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 18:19:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 16:19:50 +0000 Subject: [Koha-bugs] [Bug 3383] Item due reminder digests - cannot display title information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3383 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 18:41:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 16:41:35 +0000 Subject: [Koha-bugs] [Bug 7189] preference to control if returning lost items gives refund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7189 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9283|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 10614 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10614&action=edit Bug 7189 - preference to control if returning lost items gives refund Right now when you return an item that was lost the patron's card is credited with the lost fee, but not all libraries refund lost fees and sometimes the fee is refunded after the patron has paid for it, causing all kinds of financial issues. Adds the syspref RefundLostItemFeeOnReturn to control whether returning a lost item refunds the fee charged for losing that item. Enabled by default to maintain Koha's current functionality. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 18:42:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 16:42:00 +0000 Subject: [Koha-bugs] [Bug 7189] preference to control if returning lost items gives refund In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7189 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 19:14:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 17:14:36 +0000 Subject: [Koha-bugs] [Bug 8208] Add "create authority" button to auth_finder plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8208 --- Comment #1 from Jared Camins-Esakov --- Created attachment 10615 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10615&action=edit Bug 8208: Add fast-add link to auth finder plugin When performing subject analysis, it is not uncommon to find that an authority record you need does not exist. This commit adds a link in the search results to enable the cataloger to create an authority on the fly and have the heading populated by the new authority. To test: 1. Use the auth finder plugin the cataloguing module to search for a heading you do not have an authority record for. 2. Click the "Create new" link. 3. Fill in your authority and save it. 4. Note that the heading field was populated with the data you entered in the authority record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 19:14:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 17:14:53 +0000 Subject: [Koha-bugs] [Bug 8208] Add "create authority" button to auth_finder plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8208 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 19:30:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 17:30:32 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10234|0 |1 is obsolete| | --- Comment #175 from Jared Camins-Esakov --- Created attachment 10616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10616&action=edit bug 5327: added some tests for C4/Items.pm Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 19:32:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 17:32:56 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #176 from Jared Camins-Esakov --- Last patch was signed off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 19:33:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 17:33:45 +0000 Subject: [Koha-bugs] [Bug 8346] New: batch export marc using file of bib numbers Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8346 Priority: P5 - low Change sponsored?: --- Bug ID: 8346 Assignee: gmcharlt at gmail.com Summary: batch export marc using file of bib numbers Severity: enhancement Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Tools Product: Koha Right now the marc export tool is pretty limited - you have to export a batch in order. It would be great if you could export a batch based on a CSV of biblionumbers or some other identifier that we could grab in a report. For example, I want to export items I've added or deleted to report to OCLC or I want to send out a batch of files to another vendor or something .. anything. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 19:34:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 17:34:35 +0000 Subject: [Koha-bugs] [Bug 8346] batch export marc using file of bib numbers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8346 --- Comment #1 from Nicole C. Engard --- Also, a way to use barcode would be helpful so you could scan a bunch of barcodes in to get the marc you want to export. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 19:43:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 17:43:10 +0000 Subject: [Koha-bugs] [Bug 8281] Remove unused YUI files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8281 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Jared Camins-Esakov --- I went through most of the intranet, and didn't encounter any missing resources. Signed off patch available in branch bug_8281_qa at https://github.com/jcamins/koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 19:53:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 17:53:36 +0000 Subject: [Koha-bugs] [Bug 8339] div id="login" should be id="login_controls" in header.inc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Jared Camins-Esakov --- The name is fine, but the change in id breaks the header layout once you are logged in on Chrome under Mac. The alignment is off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 20:02:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 18:02:14 +0000 Subject: [Koha-bugs] [Bug 5332] Add batch reversion capability to bin/commit_biblios_file.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5332 --- Comment #12 from Jared Camins-Esakov --- This functionality is also added by bug 2060. I overlooked this patch, and wrote more-or-less identical code when I needed the ability to revert from the command line to test authority import. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 20:05:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 18:05:37 +0000 Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10560|0 |1 is obsolete| | --- Comment #42 from Jared Camins-Esakov --- Created attachment 10617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10617&action=edit Bug 7818 : Following, fixing so the packages build Still need to update koha-create to make use of the new file Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 20:05:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 18:05:52 +0000 Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 20:12:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 18:12:52 +0000 Subject: [Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 --- Comment #17 from Chris Cormack --- (In reply to comment #13) > Just looking at the diff, I'm wondering if this patch only fixes it if the > library has only been closed for one day, and not for multiple days at a > time. Nicole's description of her understanding of the feature is that > "checking the dropbox mode option on the check in screen made the due date > effectively the last day the library was open". What do you think? This is why just looking at a diff is an entirely ineffective way to test a patch. This bug now is to do with the dropbox not setting the correct date. Anything to do with fines is on another bug. So please talk about that issue there. Bug 8338 But if you look at the whole of the code, or better yet run it. You will see all the patch changes is setting the day_duration to be negative. It then, (depending on the mode the calendar is in, or if its hours does different things) EG my $days = abs $add_duration->in_units('days'); while ($days) { $base_date->add_duration($day_dur); if ( $self->is_holiday($base_date) ) { next; } else { --$days; } } If the library is closed, it will keep subtracting (in this case because $day_dur) is negative. This is how this had always worked, up until 3.8.0 and so that regression is now fixed. Please, looking at diffs is not really a valid test of anything. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 20:16:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 18:16:59 +0000 Subject: [Koha-bugs] [Bug 7993] saved report with hierarchies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10394|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov --- Created attachment 10618 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10618&action=edit Bug 7993: Save reports with Group/Subgroup hierarchy This should make saved reports more manageable. Group/Subgroup hierarchy is stored in authorised_values, categories REPORT_GROUP and REPORT_SUBGROUP, connected by REPORT_SUBGROUP.lib_opac -> REPORT_GROUP.authorised_value Database changes: * authorised_values: expanded category to 16 chars * created default set of REPORT_GROUP authorised values to match hardcoded report areas * reports_dictionary: replaced area int with report_area text, converted values * saved_sql: added report_area, report_group and report_subgroup; report_area is not currently used, saved for the record C4/Reports/Guided.pm: * Replaced Area numeric values with the mnemonic codes * get_report_areas(): returns hardcoded areas list * created get_report_areas(): returns full hierarchy (groups with belonging subgroups) * save_report(): changed iterface, accepts fields hashref as input * update_sql(): changed iterface, accepts id and fields hashref as input * get_saved_reports():] - join to authorised_values to pick group and subgroup name - accept group and subgroup filter params * get_saved_report(): - changed iterface, return record hashref - join to authorised_values to pick group and subgroup name * build_authorised_value_list(): new sub, moved code from reports/guided_reports.pl * Updated interfaces in: cronjobs/runreport.pl, svc/report, opac/svc/report: get_saved_report() reports/dictionary.pl: get_report_areas() reports/guided_reports.pl reports/guided_reports_start.tt: * Reports list: - added group/subgroup filter - display area/group/subgroup for the reports * Create report wizard: - carry area to the end - select group and subgroup when saving the report; group defaults to area, useful when report groups match areas * Update report and Create from SQL: added group/subgroup * Amended reports/guided_reports.pl accordingly Conflicts: C4/Reports/Guided.pm admin/authorised_values.pl installer/data/mysql/kohastructure.sql installer/data/mysql/updatedatabase.pl koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tmpl koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tmpl misc/cronjobs/runreport.pl reports/dictionary.pl reports/guided_reports.pl Rebased 2012/07/02 by Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jul 2 20:20:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 02 Jul 2012 18:20:48 +0000 Subject: [Koha-bugs] [Bug 7993] saved report with hierarchies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 07:31:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 05:31:31 +0000 Subject: [Koha-bugs] [Bug 8345] UNIMARC author facets are borken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8345 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #1 from Fr?d?ric Demians --- It works if you operate Zebra in ICU mode. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 07:46:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 05:46:30 +0000 Subject: [Koha-bugs] [Bug 8347] New: Koha forces UNIMARC 100 field code language to 'fre' Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Priority: P5 - low Change sponsored?: --- Bug ID: 8347 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: Koha forces UNIMARC 100 field code language to 'fre' Severity: enhancement Classification: Unclassified OS: All Reporter: frederic at tamil.fr Hardware: All Status: NEW Version: rel_3_10 Component: Cataloging Product: Koha Reported on Koha mailing list: I can not change the UNIMARC 100 FIELD Language of cataloging. I changed the default "fre" to "chi", I saved it . But I find all 100 FIELD Language of cataloging are "fre" again. Take a look at C4/Biblio.pm module, line 3547: substr( $string, 22, 6, "frey50" ); Check also rebuild_zebra.pl fix_unimarc_100() function. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 07:46:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 05:46:57 +0000 Subject: [Koha-bugs] [Bug 8347] Koha forces UNIMARC 100 field code language to 'fre' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8347 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |4368, 8136 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 07:46:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 05:46:57 +0000 Subject: [Koha-bugs] [Bug 4368] UNIMARC code 100 tag is reset when importing biblio records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4368 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8347 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 07:46:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 05:46:57 +0000 Subject: [Koha-bugs] [Bug 8136] Changes the expected lenght of 100$a in rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8136 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8347 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 09:23:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 07:23:35 +0000 Subject: [Koha-bugs] [Bug 1598] Allow unmoderated comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1598 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Summary|Make OPAC reviews a |Allow unmoderated comments |comments system (like | |Flickr, YouTube, etc) | --- Comment #1 from Chris Cormack --- For a lot of libraries (corporate, special etc) there should be a way for them to allow people to submit unmoderated comments. This will need a syspref, like tags, moderation on by default so existing behaviour stays the same but a library can choose to switch off moderation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 09:23:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 07:23:48 +0000 Subject: [Koha-bugs] [Bug 1598] Allow unmoderated comments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1598 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|frederic at tamil.fr |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 09:50:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 07:50:01 +0000 Subject: [Koha-bugs] [Bug 8345] UNIMARC author facets are broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8345 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|UNIMARC author facets are |UNIMARC author facets are |borken |broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 10:35:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 08:35:49 +0000 Subject: [Koha-bugs] [Bug 8348] New: useDaysMode syspref does not apply Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8348 Priority: P5 - low Change sponsored?: --- Bug ID: 8348 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: useDaysMode syspref does not apply Severity: critical Classification: Unclassified OS: All Reporter: koha at univ-lyon3.fr Hardware: All Status: NEW Version: master Component: Circulation Product: Koha Created attachment 10619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10619&action=edit useDaysMode syspref does not apply correct an incorrect sql parameter and an inverted key/value hash in Calendar.pm subroutines. Consider that the following line in _is holiday subroutine : $dt->truncate( to => 'day' ); is still corrected by the patch : Bug 8251 - Follow up, use 'day' instead of 'day' for Datetime::truncate http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10418 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 10:36:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 08:36:11 +0000 Subject: [Koha-bugs] [Bug 8348] useDaysMode syspref does not apply In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8348 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 10:47:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 08:47:26 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8348 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 10:47:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 08:47:26 +0000 Subject: [Koha-bugs] [Bug 8348] useDaysMode syspref does not apply In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8348 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8110 --- Comment #1 from Chris Cormack --- Hi Koha Team Lyon 3 You might like to take a look at bug 8110, this has a fix for the same issue, it might be that you could sign off on that, and help get that in and mark this a duplicate of that? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 10:56:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 08:56:33 +0000 Subject: [Koha-bugs] [Bug 8175] Check for something in materials field fails in catalogue/details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Missing defined check in |Check for something in |catalogue/details.pl |materials field fails in | |catalogue/details.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 11:30:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 09:30:07 +0000 Subject: [Koha-bugs] [Bug 8175] Check for something in materials field fails in catalogue/details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10577|0 |1 is obsolete| | --- Comment #7 from M. Tompsett --- Created attachment 10620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10620&action=edit Fixed the undefined issue and the intent of the ne '' Addressed Ian's concerns for the 0 or '0' case while correcting the NULL problem that triggered my looking at this code, and cleaning up the intent of the "ne ''" which is clearly only to generate a materials column in the output if there is something printable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 11:30:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 09:30:38 +0000 Subject: [Koha-bugs] [Bug 8175] Check for something in materials field fails in catalogue/details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 12:19:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 10:19:54 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha at univ-lyon3.fr --- Comment #32 from Koha Team Lyon 3 --- We had not yet took into account theese fines problems (the use of fines is very marginal at Scd Lyon3), but we cope the same question of duration calculation in in days_between routine from another bug Bug 8251 Patrons incorrectly debarred with another way to solve it. About the calculation of holidays, there's another error to get aware in _init routine of Calendar.pm : the boolean parameter has to be 1 in the second execution of $repeat_sth query (line 45) to get day_month_closed_days. I had just post a fix that include the correction : bug 8348 useDaysMode syspref does not apply. As theese problems are closely intricated, Chris Cormack counselled me to tie bug 8348 with this one but as a bugzilla beginner, I am not sure of the best way to do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 12:45:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 10:45:35 +0000 Subject: [Koha-bugs] [Bug 7286] Introduce rebuild_zebra_sliced.zsh to recursively rebuild zebra & be error proof In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7286 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10598|0 |1 is obsolete| | --- Comment #17 from Julian Maurice --- Created attachment 10621 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10621&action=edit Bug 7286: rebuild_zebra_sliced for biblios and authorities Fix some bugs: - add 'zebraidx commit' after each sucessful call to 'zebraidx update' - option -r is taken into account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:02:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 11:02:35 +0000 Subject: [Koha-bugs] [Bug 8349] New: Attempted string substitution in C4::Breeding fails on undefined Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8349 Priority: P5 - low Change sponsored?: --- Bug ID: 8349 Assignee: gmcharlt at gmail.com Summary: Attempted string substitution in C4::Breeding fails on undefined Severity: enhancement Classification: Unclassified OS: All Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: unspecified Component: MARC Bibliographic record staging/import Product: Koha Encountered the bug in 3.6.3 and confirmed it in my development environment. By moving the line, this can be compensated for. Patch to follow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:03:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 11:03:17 +0000 Subject: [Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10571|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall --- Created attachment 10622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10622&action=edit Bug 5644 : Fixing dropbox mode calculation Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:03:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 11:03:31 +0000 Subject: [Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:23:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 11:23:50 +0000 Subject: [Koha-bugs] [Bug 8349] Attempted string substitution in C4::Breeding fails on undefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8349 --- Comment #1 from M. Tompsett --- Created attachment 10623 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10623&action=edit Moved the substitution inside the if statement While generating this patch, I realized that the if statement needs fixing too. Bug report to follow for that problem. However, the if statement modification won't affect the NULL case, which is being handled by moving this. It does differ technically in the case of 0 or '0', however the result is the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:24:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 11:24:06 +0000 Subject: [Koha-bugs] [Bug 8349] Attempted string substitution in C4::Breeding fails on undefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8349 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 13:43:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 11:43:45 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |elliott at bywatersolutions.co | |m Assignee|savitra.sirohi at osslabs.biz |elliott at bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 14:18:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 12:18:11 +0000 Subject: [Koha-bugs] [Bug 8350] New: $search = '0' or 0 will fail to affect SQL statement correctly in C4::Breeding Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8350 Priority: P5 - low Change sponsored?: --- Bug ID: 8350 Assignee: gmcharlt at gmail.com Summary: $search = '0' or 0 will fail to affect SQL statement correctly in C4::Breeding Severity: normal Classification: Unclassified OS: All Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: unspecified Component: MARC Bibliographic record staging/import Product: Koha It is possible that a title or author could be '0', and thus the simple if ($search) will fail. By changing it to defined 0, '0', and '' are included. However, this would mess up the SQL include a pointless 'like %%'. So, add in a length check and all should be good. ($search) becomes (defined($search) && length($search)>0) Similar logic needs to apply to the isbn number too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 14:22:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 12:22:16 +0000 Subject: [Koha-bugs] [Bug 8349] Attempted string substitution in C4::Breeding fails on undefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8349 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from M. Tompsett --- Marking as duplicate, because my patch on 8350 will solve this problem and the poorly defined if issues. *** This bug has been marked as a duplicate of bug 8350 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 14:22:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 12:22:17 +0000 Subject: [Koha-bugs] [Bug 8350] $search = '0' or 0 will fail to affect SQL statement correctly in C4::Breeding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8350 --- Comment #1 from M. Tompsett --- *** Bug 8349 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 14:30:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 12:30:23 +0000 Subject: [Koha-bugs] [Bug 8350] $search = '0' or 0 will fail to affect SQL statement correctly in C4::Breeding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8350 --- Comment #2 from M. Tompsett --- Created attachment 10624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10624&action=edit Fixed string substitution bug (8349) and better SQL building Fixes bug 8349 and 8350 as the if statement does affect the cases encountered by the substitution which was moved into it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 14:30:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 12:30:42 +0000 Subject: [Koha-bugs] [Bug 8350] $search = '0' or 0 will fail to affect SQL statement correctly in C4::Breeding In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8350 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 14:43:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 12:43:02 +0000 Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #4 from Gaetan Boisson --- Michael, you can choose which fields are mandatory in the BorrowerMandatoryField syspref, cardnumber is mandatory by default. So with this patch if you activate autoMemberNum then you need to remove cardnumber form BorrowerMandatoryField. I would say either we just add it in the text that goes with the syspref : "Do / Don't default the card number field on the patron addition screen to the next available card number (for example, if the largest currently used card number is 26345000012941, then this field will default to 26345000012942). ++Remember to remove cardnumber from the BorrowerMandatoryField syspref if you switch this on++", or we remove it from BorrowerMandatoryField's default value (i think this would be a bad idea), or we find a way to bypass the mandatory behaviour on this field when autoMemberNum is on (This sounds like a complicated idea). I'll sign this off for now, and leave it to the QA team to decide wether we need to add something to make things clearer. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 14:45:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 12:45:21 +0000 Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 --- Comment #5 from Gaetan Boisson --- Created attachment 10625 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10625&action=edit [SIGNED-OFF] Bug 6782 - Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions). Currently the card number is generated when the user enters the patron creation form. This creates a problem of concurrency - when two or more simulataneous users are registering members, the error "card no. in use" can occur. This change moves the card number generation to occur after the "Save" button is pressed. Changes: -C4/Members.pm: Added code to fixup_cardnumber,If the cardnumber is blank and "autoMemberNum" ON. -koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: Added code to display "leave blank for auto calc during registration" in cardnumber label in patron registration form only if "autoMemberNum" ON. -members/memberentry.pl: Added code to get weather or not "autoMemberNum" is on or off and removed fixup_cardnumber generation. Test cases: -If "autoMemberNum" ON: ->In blank case, must generate auto card number in simulataneous users. ->If user entered, check for unique card number. -If "autoMemberNum" OFF: Must work normal. Signed-off-by: Gaetan Boisson -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 14:53:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 12:53:34 +0000 Subject: [Koha-bugs] [Bug 7068] autobarcode not working when duplicating patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7068 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson at biblibre.com Depends on| |6782 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 14:53:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 12:53:34 +0000 Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7068 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 15:11:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 13:11:47 +0000 Subject: [Koha-bugs] [Bug 8340] Can't modify system preferences In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8340 Hend changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Hend --- Finally i have found the problem .In /svc/config/systempreferences it was written #!/usr/bin/perl but i have perl installed in the following path /opt/ActivePerl-5.12/bin/perl so i have changed it to the correct perl path and it worked. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 16:41:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 14:41:30 +0000 Subject: [Koha-bugs] [Bug 8351] New: fix wording when undoing an import Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8351 Priority: P5 - low Change sponsored?: --- Bug ID: 8351 Assignee: nengard at gmail.com Summary: fix wording when undoing an import Severity: normal Classification: Unclassified OS: All Reporter: nengard at gmail.com URL: cgi-bin/koha/tools/manage-marc-import.pl Hardware: All Status: ASSIGNED Version: master Component: Templates Product: Koha After clicking undo on the imported marc record tool you see this confirmation "Undid import of records" I think the language should be changed to "Success: Import reversed" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 16:44:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 14:44:08 +0000 Subject: [Koha-bugs] [Bug 8351] fix wording when undoing an import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8351 --- Comment #1 from Nicole C. Engard --- Created attachment 10626 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10626&action=edit Bug 8351: Update wording on staged marc When undoing an import the 'success' message was poorly worded. This patch fixes that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 16:44:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 14:44:16 +0000 Subject: [Koha-bugs] [Bug 8351] fix wording when undoing an import In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8351 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 17:08:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 15:08:40 +0000 Subject: [Koha-bugs] [Bug 8352] New: Add automatic printing of 'hold to pull' notices Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Priority: P5 - low Change sponsored?: --- Bug ID: 8352 CC: gmcharlt at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Add automatic printing of 'hold to pull' notices Severity: enhancement Classification: Unclassified OS: All Reporter: kyle.m.hall at gmail.com Hardware: All Status: NEW Version: master Component: Hold requests Product: Koha Add the ability to have 'hold to pull' notices printed out automatically for librarians. These notices will be based on the data in the tmp_holdsqueue table. As each new row is added to tmp_holdsqueue, a notice for that given row is printed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 17:12:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 15:12:10 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 --- Comment #1 from Kyle M Hall --- Created attachment 10627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10627&action=edit Bug 8352 - Add automatic printing of 'hold to pull' notices Adds the ability to have 'hold to pull' notices printed out automatically for librarians. These notices will be based on the data in the tmp_holdsqueue table. As each new row is added to tmp_holdsqueue, a notice for that given row is printed. The system will have the ability to define a separate printer for each branchcode, so in theory each library could receive holds to pull notices printed automatically at holding library for that item, assuming they have set up the ability to print over the LAN, WAN, or Internet. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 17:12:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 15:12:21 +0000 Subject: [Koha-bugs] [Bug 8352] Add automatic printing of 'hold to pull' notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8352 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 18:17:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 16:17:55 +0000 Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #26 from Paul Poulain --- OK, patch pushed and discussion started on mailing lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 18:20:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 16:20:49 +0000 Subject: [Koha-bugs] [Bug 7630] Warning on moremember.pl about param without key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7630 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #7 from Paul Poulain --- Patch pushed, welcome Mark, you're number #186 ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 18:22:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 16:22:43 +0000 Subject: [Koha-bugs] [Bug 8353] New: Add test to compare sysprefs in db to syspref.sql Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8353 Priority: P5 - low Change sponsored?: --- Bug ID: 8353 Assignee: jcamins at cpbibliography.com Summary: Add test to compare sysprefs in db to syspref.sql Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: NEW Version: master Component: Test Suite Product: Koha To test: 1. Run prove xt/check_sysprefs.t 2. Note that the results warn you if any sysprefs are missing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 18:31:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 16:31:14 +0000 Subject: [Koha-bugs] [Bug 8353] Add test to compare sysprefs in db to syspref.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8353 --- Comment #1 from Jared Camins-Esakov --- Created attachment 10628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10628&action=edit Bug 8353: Adds a test to check for missing sysprefs in the database Adds a non-test mode (--showsql option) that displays the missing sysprefs as sql inserts. Some sysprefs were missed from the syspref file due to extra spaces in the insert : fixed. The test now checks if there are at least as many sysprefs in the database as in the syspref file (instead of checking for the exact number) Signed-off-by: Jared Camins-Esakov Cherrypicked from BibLibre master, rebased onto current master, and corrected typos, 2012-07-03 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 18:32:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 16:32:49 +0000 Subject: [Koha-bugs] [Bug 8353] Add test to compare sysprefs in db to syspref.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8353 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 18:33:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 16:33:01 +0000 Subject: [Koha-bugs] [Bug 8353] Add test to compare sysprefs in db to syspref.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8353 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 18:38:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 16:38:07 +0000 Subject: [Koha-bugs] [Bug 8353] Add test to compare sysprefs in db to syspref.sql In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8353 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jcamins at cpbibliography.com |henridamien.laurent at biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 18:42:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 16:42:25 +0000 Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #10 from Paul Poulain --- (In reply to comment #7) > I would be happy to submit a follow-up fixing indentation. I was very > tempted to reindent export.tt, actually, but section 1.3 in the coding > guidelines says don't refactor needlessly, and don't spend time changing > someone else's style to yours. :) We also have decided to use the default perltidy formatting, so, this rule "wins" against the "don't spend time..." Anyway, there's something wronger than this : you test the MARCflavour, and, if it's UNIMARC you send do ->as_xml('unimarc') When it's an authority, you must do ->as_xml('UNIMARCAUTH') The 100 -coded- field in UNIMARCAUTH has a different size than UNIMARC (biblio) So you get a nasty: Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a -> 20091001afrey50 ba0 at /usr/share/perl5/MARC/File/XML.pm line 505. (trying to decode a 100 "biblio", but it's an auth, so considered wrong size) yes, that's silly, but UNIMARC is silly ;-) Please signoff the follow-up and i'll push your patch with my (tiny) follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 18:42:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 16:42:37 +0000 Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 --- Comment #11 from Paul Poulain --- Created attachment 10629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10629&action=edit Bug 8202 follow-up UNIMARC authority support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 18:53:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 16:53:23 +0000 Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10629|0 |1 is obsolete| | --- Comment #12 from Jared Camins-Esakov --- Created attachment 10630 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10630&action=edit Bug 8202 follow-up UNIMARC authority support Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 18:54:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 16:54:51 +0000 Subject: [Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10154|0 |1 is obsolete| | --- Comment #19 from Paul Poulain --- Comment on attachment 10154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10154 Bug 7401 - Shelving Location facet instead of Branch facet when only 1 branch configured patch obsoleted, keeping the other signed-off one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 21:04:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 19:04:15 +0000 Subject: [Koha-bugs] [Bug 7997] can create a notice with the same code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 --- Comment #11 from Nicole C. Engard --- Just want to nudge this - this is still happening in 3.8.2 - the notices are silently being deleted/failing to be added. This is pretty annoying. Any ideas on how to fix this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 21:06:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 19:06:32 +0000 Subject: [Koha-bugs] [Bug 8354] New: tag cloud throwing error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8354 Priority: P5 - low Change sponsored?: --- Bug ID: 8354 Assignee: gmcharlt at gmail.com Summary: tag cloud throwing error Severity: critical Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Tools Product: Koha I have clicked on the tag cloud in a few 3.8.2 installs and get this: Software error: C4::Output version 3.02 required--this is only version 3.08.01.002 at /home/koha/kohaclone/opac/opac-tags.pl line 41. BEGIN failed--compilation aborted at /home/koha/kohaclone/opac/opac-tags.pl line 41. I tested it on Master and the problem isn't there (if that helps tracking down the issue). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 21:06:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 19:06:58 +0000 Subject: [Koha-bugs] [Bug 8354] tag cloud throwing error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8354 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Nicole C. Engard --- *** This bug has been marked as a duplicate of bug 8315 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 21:06:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 19:06:58 +0000 Subject: [Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #14 from Nicole C. Engard --- *** Bug 8354 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 21:55:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 19:55:58 +0000 Subject: [Koha-bugs] [Bug 8213] "Cancel All" button on holds over tab cancels both holds over and holds waiting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 --- Comment #4 from Melia Meggs --- They don't really need an "Are you sure you want to do this?" message if the button were working correctly. I can't think of any situation in which a library would want to cancel all of their holds waiting either. The button needs to cancel all of the holds over (which are past the ReserveMaxPickUpDelay anyway), and it should have no effect on the holds waiting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 23:25:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 21:25:48 +0000 Subject: [Koha-bugs] [Bug 6832] Validation of total > budget in neworderempty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6832 Maxime Pelletier changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6895|0 |1 is obsolete| | --- Comment #6 from Maxime Pelletier --- Created attachment 10631 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10631&action=edit new patch tested on 3.8.2 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jul 3 23:26:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 03 Jul 2012 21:26:47 +0000 Subject: [Koha-bugs] [Bug 6832] Validation of total > budget in neworderempty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6832 Maxime Pelletier changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P2 Status|Failed QA |Needs Signoff Version|rel_3_6 |rel_3_8 Change sponsored?|--- |Sponsored --- Comment #7 from Maxime Pelletier --- Problem is still in 3.8.2, so here's a new patch for that version. Sponsored by the Koha-CCSR community. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 10:52:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 08:52:12 +0000 Subject: [Koha-bugs] [Bug 8355] New: "save" button on the result list doesn't have a clear function Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8355 Priority: P5 - low Change sponsored?: --- Bug ID: 8355 Assignee: oleonard at myacpl.org Summary: "save" button on the result list doesn't have a clear function Severity: enhancement Classification: Unclassified OS: All Reporter: gaetan.boisson at biblibre.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha On a result list (both in OPAc and the staff client), there is a save button after the dropdown menu where you can choose to save you selection in the cart or in a list. The selection is saved as soon as something is chosen in the list however. Only one behaviour should be implemented : either we choose from the list then click save, or we choose from the list and it is automatically saved and then there is no button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 14:14:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 12:14:31 +0000 Subject: [Koha-bugs] [Bug 8242] Permission for "change password" button in members toolbar should be "borrowers" instead of "staffaccess" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 14:17:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 12:17:15 +0000 Subject: [Koha-bugs] [Bug 8242] Permission for "change password" button in members toolbar should be "borrowers" instead of "staffaccess" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC|kyle.m.hall at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 14:21:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 12:21:52 +0000 Subject: [Koha-bugs] [Bug 8242] Permission for "change password" button in members toolbar should be "borrowers" instead of "staffaccess" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 --- Comment #4 from Jonathan Druart --- QA comments: Changes permissions for member's password modification. It seems logical. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 14:22:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 12:22:02 +0000 Subject: [Koha-bugs] [Bug 8242] Permission for "change password" button in members toolbar should be "borrowers" instead of "staffaccess" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 14:29:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 12:29:56 +0000 Subject: [Koha-bugs] [Bug 5981] OPAC: Add limits to search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 14:50:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 12:50:50 +0000 Subject: [Koha-bugs] [Bug 5981] OPAC: Add limits to search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10316|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 10632 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10632&action=edit [SIGNED-OFF] Bug 5981 - OPAC: Add limits to search history Rebased patch + reindentation (replaces \t with 4 spaces) Works as expected. Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 14:50:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 12:50:58 +0000 Subject: [Koha-bugs] [Bug 5981] OPAC: Add limits to search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 15:01:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 13:01:19 +0000 Subject: [Koha-bugs] [Bug 6777] Display link to related acquisitions details from catalogue record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6777 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:12:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 14:12:36 +0000 Subject: [Koha-bugs] [Bug 8263] Make OPAC stylesheet preferences more consistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10396|0 |1 is obsolete| | --- Comment #6 from M. de Rooy --- Created attachment 10633 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10633&action=edit Rebased dbrev -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:15:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 14:15:02 +0000 Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 --- Comment #27 from M. de Rooy --- (In reply to comment #26) > OK, patch pushed and discussion started on mailing lists Paul: I do not see the followup appearing in master ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:21:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 14:21:23 +0000 Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:22:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 14:22:05 +0000 Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 --- Comment #28 from Paul Poulain --- (In reply to comment #27) > (In reply to comment #26) > > OK, patch pushed and discussion started on mailing lists > Paul: I do not see the followup appearing in master ? Sorry, it was commited on my local computer, forgot to push yesterday, before leaving office. It's pushed now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:29:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 14:29:39 +0000 Subject: [Koha-bugs] [Bug 6777] Display link to related acquisitions details from catalogue record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6777 --- Comment #7 from Jonathan Druart --- Like as Katrin said, I don't think we want to add these informations. On the detail.pl page, we display item's informations. A link to the order is too specific. Moreover, On the moredetail.pl page, we already have a link to the basket. Maybe we want change this link with another which points to the order page (neworderempty.pl). I don't failed QA because I need another QA point of view. Technically, with template toolkit, the following line [% IF ( A ) %] [% IF ( B ) %] text [% END %][% END %] can be replaced with [% IF ( A and B ) %] text [% END %] It is more readable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:30:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 14:30:58 +0000 Subject: [Koha-bugs] [Bug 5981] OPAC: Add limits to search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 16:33:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 14:33:11 +0000 Subject: [Koha-bugs] [Bug 8242] Permission for "change password" button in members toolbar should be "borrowers" instead of "staffaccess" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 Severity|enhancement |minor --- Comment #5 from Paul Poulain --- I think it's more a bugfix than an ENH, chris_c, your final decision -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 17:09:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 15:09:57 +0000 Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Paul Poulain --- QA comment (and some discussion with joubu) (In reply to comment #9) > construct_query: This routine is not very clear. Note also that you do not > check the contents of the pref: column whatever can be put into the pref and > will just be copied over. So it is somehwat error sensitive (not even > talking about security issues). Anyone who can set systempreferences can completely break Koha anyway. So I don't think it's a necessity to add some sanity check. The way the follow-up patch is made look quite ugly to me, it would be better to check if we've only letters, numbers, - and _ as column names. And, imo, we don't need any check at all in fact. Marcel, your opinion on that ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 17:20:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 15:20:13 +0000 Subject: [Koha-bugs] [Bug 8356] New: moveitem.tt and linkitem.tt have cataloging typo Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8356 Priority: P5 - low Change sponsored?: --- Bug ID: 8356 Assignee: oleonard at myacpl.org Summary: moveitem.tt and linkitem.tt have cataloging typo Severity: major Classification: Unclassified OS: All Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: unspecified Component: Templates Product: Koha There is no .../cataloging/addbooks.pl Need to fix a typographical error in these two files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 17:27:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 15:27:05 +0000 Subject: [Koha-bugs] [Bug 8356] moveitem.tt and linkitem.tt have cataloging typo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8356 --- Comment #1 from M. Tompsett --- Created attachment 10634 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10634&action=edit Fixed urls to addbooks.pl which had cataloging instead of cataloguing The bug was encountered in 3.6.3, but existed in master too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 17:27:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 15:27:34 +0000 Subject: [Koha-bugs] [Bug 8356] moveitem.tt and linkitem.tt have cataloging typo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8356 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 17:43:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 15:43:20 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #73 from Paul Poulain --- (In reply to comment #72) > > File structure: As mentioned above, make directories for a Koha release. > > Getting all updates means fetching the updates from a few directories. This > > makes the feature more future-proof. > > I create all of .sql and .pl until version 3.09.00.018 (current master) Jonathan, I think that what Marcel was suggesting was to have : mysql/versions/3.09.00/001.sql mysql/versions/3.09.00/002.sql mysql/versions/3.09.00/003.sql + if we do that shouldn't we remove those lines from data/mysql/updatedatabase.pl ? + that will cause some trouble to ppl running master (we can announce it, not a real problem, just warning) > > admin/updatedatabase.pl: Line 33 adds a fixme to new code: Add a new flag? > Finally I use the "parameters" flag. I don't know if we want a special > permission. sounds OK to me About: > 2) The distinction between numbered dbrevs and unnumbered ones should be > added. Note however that my suggestion to not show them in normal mode can > be discarded. you said nothing, so I checked : it works ! I created a bug 1.sql file, and it applies smoothly. So our workflow could become : "when you submit a patch that has a DB update, put it in a file named bug NNNN.sql or bug NNNN.pl, the RM will take care of the final number when pushing it" That would result in no more merge conflicts, sandboxes working well in any circumtances, I love this patch ;-) Tested a lot again, work well, switching to signed off again, Marcel, your opinion about data/mysql/updatedatabase.pl that should be cleaned from 3.09.* patches ? [Note that, in the meantime, we've reached 22 already ;-) ] If we want to do it that way, it means that all patches pending sign-off/QA will have to be updated to take care of this new behaviour. Not a big deal, just noticing it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 19:49:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 17:49:56 +0000 Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal at gmail.com |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 21:24:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 19:24:04 +0000 Subject: [Koha-bugs] [Bug 7630] Warning on moremember.pl about param without key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7630 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 21:31:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 19:31:27 +0000 Subject: [Koha-bugs] [Bug 5981] OPAC: Add limits to search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #26 from Chris Cormack --- Bugfix, pushed to 3.8.x will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jul 4 23:13:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 04 Jul 2012 21:13:22 +0000 Subject: [Koha-bugs] [Bug 8242] Permission for "change password" button in members toolbar should be "borrowers" instead of "staffaccess" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 08:57:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 06:57:22 +0000 Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 --- Comment #25 from M. de Rooy --- (In reply to comment #24) > QA comment (and some discussion with joubu) > > Anyone who can set systempreferences can completely break Koha anyway. So I > don't think it's a necessity to add some sanity check. > The way the follow-up patch is made look quite ugly to me, it would be > better to check if we've only letters, numbers, - and _ as column names. > > And, imo, we don't need any check at all in fact. Marcel, your opinion on > that ? We will not improve quality by skipping checks :-) Let's not make it worse (sounds like a commercial..). I agree that the followup does look somewhat "ugly". Adding quotes and removing them again.. A check on valid column names would be nice, but I understand that it could be a little over the top for this routine. In conclusion: If you still have a good idea, please submit. Or remove the current quote thing.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 09:00:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 07:00:38 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #74 from M. de Rooy --- Will be looking at it today. Comment in preparation.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 09:38:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 07:38:18 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 --- Comment #33 from Koha Team Lyon 3 --- Sorry for having added confusion : the error I meant to talk about is on second execution of "$special" query (not $repeat_sth), line 68 of _init routine and the parameter has to be 0 instead of 1 to get single_holidays dates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 10:06:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 08:06:03 +0000 Subject: [Koha-bugs] [Bug 8357] New: UNIMARCslim2OPACDetail.xsl, title without class and too links to views Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8357 Priority: P5 - low Change sponsored?: --- Bug ID: 8357 Assignee: oleonard at myacpl.org Summary: UNIMARCslim2OPACDetail.xsl, title without class and too links to views Severity: minor Classification: Unclassified OS: All Reporter: tajoli at cilea.it Hardware: All Status: NEW Version: rel_3_8 Component: OPAC Product: Koha There are problems the xslt file for Unimarc Opac detailed dysplay. 1) The title has '

...

' instead of ''

...

' (line 29). 2)There are lines (71-86) that create link to different views of the record. But those links are created also with template opac-detail.tt. So in the display you see two time the same links. Those problems are present also in master and in 3.6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 10:30:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 08:30:03 +0000 Subject: [Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #23 from Paul Poulain --- (In reply to comment #22) > My criticism here is those names are quite long, and I don't think these > routines are business logic at all. Are we going to build an inheritance > structure such that those are objects under inheriting from the classes > above them, or is it just an arbitrary naming scheme. agreed > If it's arbitrary and > there is no inheritance, then I like Koha::MARCUtils better. I suggested, for Logger.pm to have a Koha::Utils namespace. So Koha::Utils::Marc would easily take place here ! OTOH, it access the database, isn't it ? So will need access to Koha::DB::, and haven't we said something about business logic being the entry point for all db accesses ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 10:31:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 08:31:14 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #75 from M. de Rooy --- QA Comment: Jonathan: I am very sorry, but I fear that you missed my main point somehow from comment70 /comment71 about the distinction between numbered and unnumbered dbrevs. Please reread. Just in short: In user mode installer should run the numbered dbrevs; the update form only lists both dbrevs for reference. There is no need to run dbrevs from there in that mode. In dev mode installer still runs the numbered dbrevs, the update form allows you to run the other ones in any order. The current patch still allows me to run both groups. (And I still think that you can make this adjustment without changing too much..) Secondly, see my comment on Mainpage AND Authorization. Please move the extended version check back from mainpage to checkauth but later in time (only for new sessions). Note also that the double login problem still remains. After applying your patch, and installing the new cpan module, I had to login twice again. (See the cookie comment?) File structure: Paul is right. I meant subdirs per version. Note that I did not mean creating the files for 001 to 018. Since they are in updatedatabase already, I would suggest to remove them from this patch (*sorry*). Upgrading: You wrote: > I don't know how I can do this simply and properly. if someone feels motivated... This point is closely related to the first comment. Please look at install.pl around line 324. We need to record the exact dbrev when this patch is pushed, and compare against that. If we are lower, run first old updatedatabase. And after that, make a call to your new code to run the numbered dbrevs in the versions dir(s). I am convinced that you can do that very well and properly :-) See also my earlier comment on Stable version. This needs some additional precaution, since we will not implement it in master and 3.8.X at the same time. (The version compare in 3.8.X will be different from master.) When upgrading to 3.10, you cannot completely prevent running some dbrevs for a second time. (But some could be skipped when comparing your checksums between 3.8 and 3.9 folder.) This issue will reappear at every new version (e.g. comparing checksums again between 3.10 and 3.11 folder, etc.) New (minor) point: C4/Update/Database: New dependency introduced: Can't locate File/Find/Rule.pm in @INC. Do you really need this one? You only need to get some file names? Just use glob? Hope that this helps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 10:45:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 08:45:44 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #76 from Paul Poulain --- (In reply to comment #75) > QA Comment: > Jonathan: I am very sorry, but I fear that you missed my main point somehow > from comment70 /comment71 about the distinction between numbered and > unnumbered dbrevs. Please reread. Just in short: In user mode installer > should run the numbered dbrevs; the update form only lists both dbrevs for > reference. There is no need to run dbrevs from there in that mode. > In dev mode installer still runs the numbered dbrevs, the update form allows > you to run the other ones in any order. question : if you're in user mode, it means you're running a published version right ? So there should not be any unnumbered dbrev ? conclusion = isn't the current behaviour correct ? > Secondly, see my comment on Mainpage AND Authorization. Please move the > extended version check back from mainpage to checkauth but later in time > (only for new sessions). Note also that the double login problem still > remains. After applying your patch, and installing the new cpan module, I > had to login twice again. (See the cookie comment?) I won't object as long as it does not require checking on *every* page. > See also my earlier comment on Stable version. This needs some additional > precaution, since we will not implement it in master and 3.8.X at the same > time. (The version compare in 3.8.X will be different from master.) When > upgrading to 3.10, you cannot completely prevent running some dbrevs for a > second time. (But some could be skipped when comparing your checksums > between 3.8 and 3.9 folder.) This issue will reappear at every new version > (e.g. comparing checksums again between 3.10 and 3.11 folder, etc.) Couldn't we also decide that 3.8 DBrevs are made on the old updatedatabase.pl, DBrevs for 3.10 are in the new one ? So no need to backport this enhancement to 3.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 10:53:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 08:53:04 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #77 from M. de Rooy --- (In reply to comment #76) > question : if you're in user mode, it means you're running a published > version right ? So there should not be any unnumbered dbrev ? > conclusion = isn't the current behaviour correct ? Update should only list/execute the unnumbered ones. You could have a published version plus some custom work. You install that in dev mode and then put Koha back to user mode. I guess that means that you normally should not have unexecuted unnumbered dbrevs.. > Couldn't we also decide that 3.8 DBrevs are made on the old > updatedatabase.pl, DBrevs for 3.10 are in the new one ? > So no need to backport this enhancement to 3.8. Good for me. But this issue will come up again between 3.10 and 3.11. You will have dbrevs in 3.10 folder; they are a subset of the 3.11 folder. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 10:53:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 08:53:08 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 10:54:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 08:54:29 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #78 from M. de Rooy --- (In reply to comment #77) > Update should only list/execute the unnumbered ones. List all, of course.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 10:55:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 08:55:45 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9972|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart --- Created attachment 10635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10635&action=edit Bug 7986: Export issues for patron Rebased patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 10:55:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 08:55:52 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 11:14:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 09:14:23 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10463|0 |1 is obsolete| | --- Comment #21 from Julian Maurice --- Created attachment 10636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10636&action=edit Follow-up: run transferorder.pl in a popup Implement popup in basket.tt too. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 11:14:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 09:14:35 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 11:21:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 09:21:31 +0000 Subject: [Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #22 from M. de Rooy --- In the former comment of June 11 a question was raised. But it is still unanswered. Changing status to reflect need for clarification/adjustment.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 11:29:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 09:29:44 +0000 Subject: [Koha-bugs] [Bug 7065] reserves table needs a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 11:40:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 09:40:43 +0000 Subject: [Koha-bugs] [Bug 7065] reserves table needs a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #26 from M. de Rooy --- Looks good to me. Last QA comment has been incorporated. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 11:47:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 09:47:00 +0000 Subject: [Koha-bugs] [Bug 8358] New: Purchase Suggestion Link don't open Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8358 Priority: P5 - low Change sponsored?: --- Bug ID: 8358 Assignee: oleonard at myacpl.org Summary: Purchase Suggestion Link don't open Severity: major Classification: Unclassified OS: Linux Reporter: hend.eleraky at bibalex.org Hardware: All Status: NEW Version: rel_3_6 Component: OPAC Product: Koha Created attachment 10637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10637&action=edit Error on "Purchase Suggestion" link click Purchase suggestion link in OPAC directs to the following http://koha.example.org/cgi-bin/koha/opac-suggestions.pl which doesn't open. Attached screen shot for this error. Should "koha.example.org" in the above URL changed to my server IP because when i did that it opened for my the page for creating new purchase suggestion [My Purchase Suggestions ] If it should be changed how i could do it ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 11:48:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 09:48:01 +0000 Subject: [Koha-bugs] [Bug 8358] Purchase Suggestion Link don't open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8358 Hend changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high CC| |hend.eleraky at bibalex.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 11:51:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 09:51:24 +0000 Subject: [Koha-bugs] [Bug 8203] Should be possible to save individual authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8203 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 12:11:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 10:11:12 +0000 Subject: [Koha-bugs] [Bug 8358] Purchase Suggestion Link don't open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8358 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #1 from Chris Cormack --- What version of Koha are you using? And how did you install it, I have never ever seen that error before. And I have no idea where koha.example.org came from, no references to it exist in the Koha code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 12:12:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 10:12:32 +0000 Subject: [Koha-bugs] [Bug 8203] Should be possible to save individual authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8203 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from M. de Rooy --- QA Comment: I was about to mark this Passed QA, but I could not get it to work properly. I click on the Save menu and choose an option. But whatever I try, nothing happens.. Tested in Firefox 9 (oops). Note that running the export URL from the address bar did the job perfectly. Any idea? Secondly, authorities/export.pl uses tools/export.tt. This could raise some confusion some day. (No blocker) MARC21slim2MADS.xsl: Does this file need some kind of copyright statement/acknowledgement? It contains a version history; it is not clear where it came from. (Followup?) Marking as Failed QA for need of clarification/adjustment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 12:38:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 10:38:10 +0000 Subject: [Koha-bugs] [Bug 8358] Purchase Suggestion Link don't open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8358 --- Comment #2 from Hend --- koha version 3.6.5 i installed it as described in the Installation steps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 12:55:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 10:55:23 +0000 Subject: [Koha-bugs] [Bug 8203] Should be possible to save individual authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8203 --- Comment #4 from Katrin Fischer --- Hm, I tested in Firefox too - but not sure about the version. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 13:25:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 11:25:36 +0000 Subject: [Koha-bugs] [Bug 8358] Purchase Suggestion Link don't open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8358 --- Comment #3 from Chris Cormack --- The ones in INSTALL ? If not can you please let me know which instructions. Hmm where in the heck did that koha.example.org come from then. What do you have set for your servername in your apache virtual host for the opac? Did you by any chance do something like this http://wiki.koha-community.org/wiki/JQuery_Library#Append_text_to_the_OPAC_search_results If so, then thats your problem that hostname is just an example and you should use your real one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 13:39:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 11:39:17 +0000 Subject: [Koha-bugs] [Bug 8283] Replace usage of YUI Cookie utility with jQuery Cookie plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 13:50:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 11:50:49 +0000 Subject: [Koha-bugs] [Bug 8283] Replace usage of YUI Cookie utility with jQuery Cookie plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Jonathan Druart --- Qa comments: I love this kind of patch : 12 insertions(+), 998 deletions(-) for the same job ! :) Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 13:58:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 11:58:07 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 13:58:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 11:58:47 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10380|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart --- Comment on attachment 10380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10380 Bug 6720: Display the authority type in OPAC This one seems to be obsoleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 14:00:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 12:00:16 +0000 Subject: [Koha-bugs] [Bug 8359] New: enter submits acq order Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8359 Priority: P5 - low Change sponsored?: --- Bug ID: 8359 Assignee: koha-bugs at lists.koha-community.org Summary: enter submits acq order Severity: major Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Acquisitions Product: Koha In acquistions when ever the enter key is pressed or a cartridge return is sent the save button in the order record is triggered. I don't think this was the case before 3.8 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 14:09:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 12:09:53 +0000 Subject: [Koha-bugs] [Bug 8083] Granular parameters permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9686|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 10638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10638&action=edit Attachment to Bug 8083 - Granular parameters permissions [SIGNED-OFF] bug_8083: parameters subpermissions: manage_circ_rules and parameters_remaining_permissions Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 14:10:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 12:10:16 +0000 Subject: [Koha-bugs] [Bug 8083] Granular parameters permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10638|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 10639 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10639&action=edit [SIGNED-OFF] bug_8083: parameters subpermissions: manage_circ_rules and parameters_remaining_permissions Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 14:10:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 12:10:35 +0000 Subject: [Koha-bugs] [Bug 8083] Granular parameters permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8083 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 14:14:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 12:14:32 +0000 Subject: [Koha-bugs] [Bug 4198] deleting an authority refreshes the page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4198 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com Assignee|savitra.sirohi at osslabs.biz |kyle.m.hall at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 14:17:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 12:17:34 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Jonathan Druart --- QA Comments: my $thisauthtype = GetAuthType(GetAuthTypeCode($authid)); This line is very scabby. It does 2 selects on the auth_header table. But I don't find an other way to do that in our API. Considering the dirty code into the SearchAuthorities routine, I mark as passed QA this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 14:21:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 12:21:06 +0000 Subject: [Koha-bugs] [Bug 8360] New: Author facet not working Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8360 Priority: P5 - low Change sponsored?: --- Bug ID: 8360 Assignee: adrien.saurat at biblibre.com Summary: Author facet not working Severity: normal Classification: Unclassified OS: All Reporter: adrien.saurat at biblibre.com Hardware: All Status: ASSIGNED Version: master Component: OPAC Product: Koha After a search on the OPAC, clicking on the Author facet gives bad results, sometimes an empty screen when several biblios should appear. It is so in UNIMARC at least, and I'll propose a patch for this (correcting the facet construction by adding wordlist "wrdl" to the limit parameter), but if MARC21 biblios have the same problem I'll make a version with both codes modified. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 14:22:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 12:22:19 +0000 Subject: [Koha-bugs] [Bug 6777] Display link to related acquisitions details from catalogue record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6777 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|jonathan.druart at biblibre.co | |m | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 14:29:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 12:29:09 +0000 Subject: [Koha-bugs] [Bug 8360] Author facet not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8360 --- Comment #1 from Adrien SAURAT --- Created attachment 10640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10640&action=edit proposed patch #1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 14:29:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 12:29:19 +0000 Subject: [Koha-bugs] [Bug 8360] Author facet not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8360 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 14:33:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 12:33:46 +0000 Subject: [Koha-bugs] [Bug 8358] Purchase Suggestion Link don't open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8358 --- Comment #4 from Hend --- Yes i followed the steps in INSTALL . For the servername i have set to the machine name in koha-httpd.conf . ohhhh !!! That's why i have found two blocks for Purchase suggestion. I had removed it from opacuserjs . Thanks for your help . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 14:34:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 12:34:23 +0000 Subject: [Koha-bugs] [Bug 8303] Hide login box in OPAC with system preference. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8303 --- Comment #2 from Jared Camins-Esakov --- Created attachment 10641 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10641&action=edit Bug 8203 follow-up: QA fixes Fixes the Save button functionality when YUI is set to be pulled from Yahoo!'s servers, and adds a copyright statement to the MARC21slim2MADS.xsl file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 14:34:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 12:34:56 +0000 Subject: [Koha-bugs] [Bug 8203] Should be possible to save individual authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8203 --- Comment #5 from Jared Camins-Esakov --- Created attachment 10642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10642&action=edit Bug 8203 follow-up: QA fixes Fixes the Save button functionality when YUI is set to be pulled from Yahoo!'s servers, and adds a copyright statement to the MARC21slim2MADS.xsl file. http://bugs.koha-community.org/show_bug.cgi?id=8303 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 14:35:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 12:35:19 +0000 Subject: [Koha-bugs] [Bug 8303] Hide login box in OPAC with system preference. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8303 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10641|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 14:41:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 12:41:21 +0000 Subject: [Koha-bugs] [Bug 8203] Should be possible to save individual authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8203 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10642|0 |1 is obsolete| | --- Comment #6 from M. de Rooy --- Created attachment 10643 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10643&action=edit [SIGNED-OFF] Followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 14:42:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 12:42:35 +0000 Subject: [Koha-bugs] [Bug 8203] Should be possible to save individual authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8203 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #7 from M. de Rooy --- QA Comment: YUI problem fixed. Copyright included. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 14:47:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 12:47:07 +0000 Subject: [Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:02:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:02:08 +0000 Subject: [Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from M. de Rooy --- No results for 1=Match. Error 114 in zebra log. No match for Match :-) in bib1.att Needs some attention still -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:04:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:04:24 +0000 Subject: [Koha-bugs] [Bug 8256] Reports webservice should allow selection by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:12:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:12:03 +0000 Subject: [Koha-bugs] [Bug 8361] New: Issuing rule if no rule is defined Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8361 Priority: P5 - low Change sponsored?: --- Bug ID: 8361 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Issuing rule if no rule is defined Severity: major Classification: Unclassified OS: All Reporter: paul.poulain at biblibre.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha If we reach a case where no issuing rule is defined, Koha always grant issuing. Koha should refuse any check-out if no rule is found (validating the issuing is silent, while rejecting the check-out will clearly show that something is missing in your configuration) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:13:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:13:12 +0000 Subject: [Koha-bugs] [Bug 8362] New: Circulation fixes and improvements omnibus Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8362 Priority: P5 - low Change sponsored?: --- Bug ID: 8362 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Circulation fixes and improvements omnibus Severity: enhancement Classification: Unclassified OS: All Reporter: paul.poulain at biblibre.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha this is an omnibus for some circulation problems or improvements -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:13:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:13:29 +0000 Subject: [Koha-bugs] [Bug 8362] Circulation fixes and improvements omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8362 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8361 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:13:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:13:29 +0000 Subject: [Koha-bugs] [Bug 8361] Issuing rule if no rule is defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8361 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8362 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:15:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:15:01 +0000 Subject: [Koha-bugs] [Bug 5437] smart-rule improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5437 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Paul Poulain --- see bug 8361, that is a revival of this one -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:15:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:15:44 +0000 Subject: [Koha-bugs] [Bug 8363] New: Update an issuing rule Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8363 Priority: P1 - high Change sponsored?: --- Bug ID: 8363 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Blocks: 8362 Summary: Update an issuing rule Severity: enhancement Classification: Unclassified OS: All Reporter: paul.poulain at biblibre.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha atm, we can't update an issuing rule : it's hard to delete & rewrite all of a rule. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:15:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:15:44 +0000 Subject: [Koha-bugs] [Bug 8362] Circulation fixes and improvements omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8362 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8363 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:19:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:19:29 +0000 Subject: [Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 --- Comment #7 from Jared Camins-Esakov --- Created attachment 10644 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10644&action=edit Bug 8206 follow-up: Add Match index to MARC21 record.abs Although the Match index was correctly configured for UNIMARC authorities and MARC21 authorities indexed with DOM, the Match index was inadvertantly removed from the record.abs file for MARC21 authorities at some point. Since the Match index is required to make best use of the new search options, this patch adds it back in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:21:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:21:41 +0000 Subject: [Koha-bugs] [Bug 8364] New: Inconsistency in hold count Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8364 Priority: P5 - low Change sponsored?: --- Bug ID: 8364 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Inconsistency in hold count Severity: normal Classification: Unclassified OS: All Reporter: paul.poulain at biblibre.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha If a Koha is set with ReservesControlBranch syspref set to ItemHomeLibrary item-level-itype=yes, a patron placing a "first available" hold won't be counted in the total number of reserves placed. The SQL is SELECT count(*) as count FROM reserves LEFT JOIN items USING (itemnumber) LEFT JOIN biblioitems ON (reserves.biblionumber=biblioitems.biblionumber) LEFT JOIN borrowers USING (borrowernumber) WHERE ... AND items.homebranch = ? => items is not defined, the hold is not counted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:25:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:25:24 +0000 Subject: [Koha-bugs] [Bug 8364] Inconsistency in hold count In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8364 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8362 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:25:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:25:24 +0000 Subject: [Koha-bugs] [Bug 8362] Circulation fixes and improvements omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8362 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8364 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:27:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:27:00 +0000 Subject: [Koha-bugs] [Bug 8365] New: Renewal duration in issuingules Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Priority: P5 - low Change sponsored?: --- Bug ID: 8365 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Renewal duration in issuingules Severity: enhancement Classification: Unclassified OS: All Reporter: paul.poulain at biblibre.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha It could be interesting to have a renewal duration, to let a library say: "books checked-out for 3 weeks, with 1 renewal of 1 week" this renewal duration should be at issuing rule level -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:27:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:27:20 +0000 Subject: [Koha-bugs] [Bug 8362] Circulation fixes and improvements omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8362 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8365 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:27:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:27:20 +0000 Subject: [Koha-bugs] [Bug 8365] Renewal duration in issuingules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8362 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:29:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:29:42 +0000 Subject: [Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #8 from M. de Rooy --- Back to Signed Off Will be looking soon -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:31:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:31:01 +0000 Subject: [Koha-bugs] [Bug 8366] New: Meaning of "All" in issuing rules Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8366 Priority: P5 - low Change sponsored?: --- Bug ID: 8366 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com, nengard at gmail.com Assignee: koha-bugs at lists.koha-community.org Blocks: 8362 Summary: Meaning of "All" in issuing rules Severity: major Classification: Unclassified OS: All Reporter: paul.poulain at biblibre.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha In issuingrules, the library / patron category / item type all have a "all" option. The meaning of this "all" differ : * for library and patron category, what is entered here is used if no other rule is defined. * for item types, what is entered here is used for all check-out for itemtypes that don't have a specific rule. Let's suppose we have 4 itemtypes : book, comics, dvd, CD Rules are : BOOKS 2 COMICS 3 "All" 4 If you check out a DVD, Koha will check if the total number of NOT IN('BOOKS','COMICS') is less than 4 so the "All" is more an "otherwise" than a default value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:31:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:31:01 +0000 Subject: [Koha-bugs] [Bug 8362] Circulation fixes and improvements omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8362 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8366 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:35:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:35:33 +0000 Subject: [Koha-bugs] [Bug 8367] New: How long is a hold waiting for pickup at a more granular level Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Priority: P5 - low Change sponsored?: --- Bug ID: 8367 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: How long is a hold waiting for pickup at a more granular level Severity: enhancement Classification: Unclassified OS: All Reporter: paul.poulain at biblibre.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha The syspref reservemaxpickupdelay says how long a hold is waiting for patron pickup. This could be set at issuingrule level, to let a student of library A 4 days and a teacher of library B 10 days -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:35:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:35:41 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8362 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:35:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:35:41 +0000 Subject: [Koha-bugs] [Bug 8362] Circulation fixes and improvements omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8362 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8367 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:39:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:39:16 +0000 Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 --- Comment #29 from Katrin Fischer --- I have forwarded this to a coworker and hoping to find out what we have to do soon. Whatever we do, we should not forget about the lists as they are also sent out using a similar technique. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:42:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:42:42 +0000 Subject: [Koha-bugs] [Bug 8368] New: List email broken for non english templates Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Priority: P5 - low Change sponsored?: --- Bug ID: 8368 Assignee: oleonard at myacpl.org Summary: List email broken for non english templates Severity: major Classification: Unclassified OS: All Reporter: katrin.fischer at bsz-bw.de Hardware: All Status: NEW Version: master Component: OPAC Product: Koha This is the same problem as for bug 8062 only for sending out lists. Copying description with some changes: To reproduce: - Create a list that you can access - Open list in OPAC or staff - log in, if you didn't before - Send list to any email address - Check email text and attachements The mail sent from the translated templates has subject "no subject" and is empty. The marc files are attached. The mail sent from the english templates is all correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:45:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:45:33 +0000 Subject: [Koha-bugs] [Bug 8368] List email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8368 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8062 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:45:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:45:34 +0000 Subject: [Koha-bugs] [Bug 8062] Cart email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8368 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:51:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:51:31 +0000 Subject: [Koha-bugs] [Bug 8369] New: default_branch_circ_rule and default_circ_rules tables useless Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 Priority: P5 - low Change sponsored?: --- Bug ID: 8369 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Blocks: 8362 Summary: default_branch_circ_rule and default_circ_rules tables useless Severity: normal Classification: Unclassified OS: All Reporter: paul.poulain at biblibre.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha Issuingrules uses '*' as a wildcard to say "default". The branch_borrower_circ_rules and default_branch_circ_rules could use the same method to define the default behaviour. It means the tables default_branch_circ_rule and default_circ_rules would become useless and the behaviour more consistent -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:51:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:51:31 +0000 Subject: [Koha-bugs] [Bug 8362] Circulation fixes and improvements omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8362 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8369 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:54:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:54:46 +0000 Subject: [Koha-bugs] [Bug 8370] New: Default checkout, hold and return policy for all library => wrong term Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 Priority: P2 Change sponsored?: --- Bug ID: 8370 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com, nengard at gmail.com Assignee: koha-bugs at lists.koha-community.org Blocks: 8362 Summary: Default checkout, hold and return policy for all library => wrong term Severity: normal Classification: Unclassified OS: All Reporter: paul.poulain at biblibre.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha The string "Default checkout, hold and return policy for all library" that appear in issuingrules when you're on "All" library is wrong. It's related to the rule that is applied by default if there is no library-level rule. Same problem with "Checkout limit by patron category for all libraries" and "Holds policy by itemtype for all libraries" => they refer to the behaviour if no library-level rule is set -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:54:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:54:46 +0000 Subject: [Koha-bugs] [Bug 8362] Circulation fixes and improvements omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8362 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8370 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:58:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:58:17 +0000 Subject: [Koha-bugs] [Bug 8371] New: Add network level issuing rules Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8371 Priority: P5 - low Change sponsored?: --- Bug ID: 8371 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Blocks: 8362 Summary: Add network level issuing rules Severity: enhancement Classification: Unclassified OS: All Reporter: paul.poulain at biblibre.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha Some libraries want to say : "you can check-out 5 books at library A, 5 books at library B, and 7 books total" That could be achieved by adding a "Global" or "Total" level to issuingrules. In this "Total" level, only the number of check-out is relevant (durations, ... are not) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 15:58:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 13:58:17 +0000 Subject: [Koha-bugs] [Bug 8362] Circulation fixes and improvements omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8362 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8371 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:01:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:01:51 +0000 Subject: [Koha-bugs] [Bug 8372] New: Move AllowOnShelfHolds at granular level Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8372 Priority: P5 - low Change sponsored?: --- Bug ID: 8372 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Blocks: 8362 Summary: Move AllowOnShelfHolds at granular level Severity: enhancement Classification: Unclassified OS: All Reporter: paul.poulain at biblibre.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha In issuingrules, we could enable/disable on shelves hold, instead of having a global syspref -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:01:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:01:51 +0000 Subject: [Koha-bugs] [Bug 8362] Circulation fixes and improvements omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8362 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8372 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:06:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:06:56 +0000 Subject: [Koha-bugs] [Bug 8314] Missing MARCISBNS param in opac-detail.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8314 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:07:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:07:21 +0000 Subject: [Koha-bugs] [Bug 8314] Missing MARCISBNS param in opac-detail.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8314 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10556|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 10645 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10645&action=edit Bug 8314 Add MARCISBNs parameter to opac-detail.pl to show multiple isbns in OPAC replace \t with 4 spaces -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:08:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:08:49 +0000 Subject: [Koha-bugs] [Bug 8314] Missing MARCISBNS param in opac-detail.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8314 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Jonathan Druart --- MARCISBNs was never passed to the template. This patch fixes this issues. Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:09:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:09:02 +0000 Subject: [Koha-bugs] [Bug 7997] can create a notice with the same code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8259 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:09:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:09:02 +0000 Subject: [Koha-bugs] [Bug 8259] Library for notices not saving correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8259 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7997 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:10:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:10:54 +0000 Subject: [Koha-bugs] [Bug 7997] can create a notice with the same code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #12 from Nicole C. Engard --- The way I understand it, the way things are now you can't have different notices for different branches ... this is a critical issue. Either the ability to create notices for different branches needs to be removed or the code fixed to look at the code/branch combo as a key, or make each notice have a unique key. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:11:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:11:22 +0000 Subject: [Koha-bugs] [Bug 7997] can create a notice with the same code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7997 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8258 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:11:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:11:22 +0000 Subject: [Koha-bugs] [Bug 8258] Branch specific DUEDGST notice is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8258 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7997 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:11:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:11:57 +0000 Subject: [Koha-bugs] [Bug 8259] Library for notices not saving correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8259 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8258 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:11:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:11:57 +0000 Subject: [Koha-bugs] [Bug 8258] Branch specific DUEDGST notice is not used In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8258 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8259 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:15:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:15:13 +0000 Subject: [Koha-bugs] [Bug 8362] Circulation fixes and improvements omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8362 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:15:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:15:37 +0000 Subject: [Koha-bugs] [Bug 8372] Move AllowOnShelfHolds at granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8372 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer --- Hi Paul - this is a duplicate. There is already a patch for that from Srdjan that needs to be tested. Bug 5786. I started on it but got a bit lost thinking about all the options and possible combinations. *** This bug has been marked as a duplicate of bug 5786 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:15:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:15:37 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 --- Comment #38 from Katrin Fischer --- *** Bug 8372 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:15:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:15:38 +0000 Subject: [Koha-bugs] [Bug 8362] Circulation fixes and improvements omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8362 Bug 8362 depends on bug 8372, which changed state. Bug 8372 Summary: Move AllowOnShelfHolds at granular level http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8372 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:15:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:15:44 +0000 Subject: [Koha-bugs] [Bug 8361] Issuing rule if no rule is defined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8361 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:15:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:15:47 +0000 Subject: [Koha-bugs] [Bug 8363] Update an issuing rule In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8363 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:15:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:15:50 +0000 Subject: [Koha-bugs] [Bug 8364] Inconsistency in hold count In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8364 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:15:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:15:54 +0000 Subject: [Koha-bugs] [Bug 8365] Renewal duration in issuingules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8365 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:15:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:15:58 +0000 Subject: [Koha-bugs] [Bug 8366] Meaning of "All" in issuing rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8366 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:16:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:16:03 +0000 Subject: [Koha-bugs] [Bug 8367] How long is a hold waiting for pickup at a more granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8367 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:16:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:16:06 +0000 Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:16:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:16:10 +0000 Subject: [Koha-bugs] [Bug 8370] Default checkout, hold and return policy for all library => wrong term In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8370 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:16:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:16:13 +0000 Subject: [Koha-bugs] [Bug 8371] Add network level issuing rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8371 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:16:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:16:17 +0000 Subject: [Koha-bugs] [Bug 8372] Move AllowOnShelfHolds at granular level In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8372 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:17:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:17:48 +0000 Subject: [Koha-bugs] [Bug 8362] Circulation fixes and improvements omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8362 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Depends on| |5786 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:17:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:17:48 +0000 Subject: [Koha-bugs] [Bug 5786] Move AllowOnShelfHolds system preference to the Circulation Matrix In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5786 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8362 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:18:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:18:03 +0000 Subject: [Koha-bugs] [Bug 8366] Meaning of "All" in issuing rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8366 --- Comment #1 from Nicole C. Engard --- Paul, Sounds to me like they are saying the same thing: "All, unless another rule exists that can apply here." Is that not the case? Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:18:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:18:55 +0000 Subject: [Koha-bugs] [Bug 8362] Circulation fixes and improvements omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8362 --- Comment #1 from Katrin Fischer --- I think bug 5787 and bug 5788 are also candidates to go here? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:21:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:21:48 +0000 Subject: [Koha-bugs] [Bug 8373] New: opacheader schould not show in print layout Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8373 Priority: P5 - low Change sponsored?: --- Bug ID: 8373 Assignee: oleonard at myacpl.org Summary: opacheader schould not show in print layout Severity: enhancement Classification: Unclassified OS: All Reporter: katrin.fischer at bsz-bw.de Hardware: All Status: NEW Version: master Component: Templates Product: Koha Example: Options to print lists or carts from the OPAC. The contents of the opacheader system preference should not show up on the print layouts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:25:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:25:59 +0000 Subject: [Koha-bugs] [Bug 8374] New: Option to print all entries of a list/cart in a user friendly format Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8374 Priority: P5 - low Change sponsored?: --- Bug ID: 8374 Assignee: oleonard at myacpl.org Summary: Option to print all entries of a list/cart in a user friendly format Severity: enhancement Classification: Unclassified OS: All Reporter: katrin.fischer at bsz-bw.de Hardware: All Status: NEW Version: master Component: OPAC Product: Koha When a list has a lot of entries it is paginated. If you print use the print list feature provided, only the first page is printed. Our download options BibTex, Ris and MARC are not easy to read for a user. It would be nice to provide a way to download or print all entries on a list in an easy way from the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:31:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:31:52 +0000 Subject: [Koha-bugs] [Bug 8373] opacheader should not show in print layout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8373 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|opacheader schould not show |opacheader should not show |in print layout |in print layout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:35:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:35:33 +0000 Subject: [Koha-bugs] [Bug 4198] deleting an authority refreshes the page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4198 --- Comment #1 from Kyle M Hall --- Created attachment 10646 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10646&action=edit Bug 4198 - deleting an authority refreshes the page Makes clicking a Delete link refresh the search that was performed so that the results are still on the screen. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:36:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:36:54 +0000 Subject: [Koha-bugs] [Bug 4198] deleting an authority refreshes the page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4198 --- Comment #2 from Kyle M Hall --- Created attachment 10647 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10647&action=edit Bug 4198 - Followup - PerlTidy authorities-home.pl -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:38:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:38:23 +0000 Subject: [Koha-bugs] [Bug 4198] deleting an authority refreshes the page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4198 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 16:50:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 14:50:34 +0000 Subject: [Koha-bugs] [Bug 8366] Meaning of "All" in issuing rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8366 --- Comment #2 from Paul Poulain --- (In reply to comment #1) > Sounds to me like they are saying the same thing: "All, unless another rule > exists that can apply here." > > Is that not the case? Hi Nicole, That's just a term that can be confusing. For branches & patron category, it means "rule to apply if no other rule exists". In my example, if you have a "all" rule of 4 books, you can issue 4 books from library A AND 4 books from library B. For itemtype, it's a little bit different: one could think he can issue 4 DVD AND 4 CDs, but in fact he can just check-ou 4 "not (BOOKS or Comics)". So 3 DVD and 1 CD, or 2 and 2 or 4 and 0 (a *total* of 4, not 4 on each itemtype not defined) Do you see the difference ? I think it's worth a different term. Other option = if you consider it should be 4 DVDs and 4CD, it means it's a bug, because it's not the current behaviour and it must be fixed ! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 17:39:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 15:39:57 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tajoli at cilea.it --- Comment #10 from Zeno Tajoli --- I want to test this patch. But is not clear what I need to do. I need to use all two patches that are valid ? Do I need to implement as first the older (from Tom?s Cohen Arazi) and after the patch of Koha Team Lyon 3 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 17:41:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 15:41:06 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #79 from Paul Poulain --- (In reply to comment #77) > (In reply to comment #76) > > question : if you're in user mode, it means you're running a published > > version right ? So there should not be any unnumbered dbrev ? > > conclusion = isn't the current behaviour correct ? > Update should only list/execute the unnumbered ones. You could have a > published version plus some custom work. You install that in dev mode and > then put Koha back to user mode. I guess that means that you normally should > not have unexecuted unnumbered dbrevs.. I feel we're misunderstanding ourselves: * if you're on a production server, you've only numbered DBrevs + your own local revisions (that can be numbered -bad idea- or no) * if you're on a test/dev server, you've numbered DBrevs (pushed already), plus unnumbered DBrevs that comes from patches you want to test. It's not related to being in dev mode or no. The dev mode just let you choose DBrevs one by one, where the normal mode apply everything, and that's all. > > Couldn't we also decide that 3.8 DBrevs are made on the old > > updatedatabase.pl, DBrevs for 3.10 are in the new one ? > > So no need to backport this enhancement to 3.8. > Good for me. But this issue will come up again between 3.10 and 3.11. You > will have dbrevs in 3.10 folder; they are a subset of the 3.11 folder. that's not a problem = you'll have to apply all patches coming from any folder anyway, isn't it ? > New (minor) point: C4/Update/Database: New dependency introduced: Can't locate > File/Find/Rule.pm in @INC. Do you really need this one? You only need to get some file > names? Just use glob? jonathan says glob doesn't handle recursivity, so this package fit our needs better. Jonathan will submit a patch that : * check dbrev on check auth page * add the cookie to avoid duplicate login * delete 3.9 from old updatedatabase, to start from a clean situation = 3.9-10 => everything in a 3.9 directory. The workflow would then be = * if you submit a patch that update database and should be ported to 3.8 => use the "old" updatedatabase.pl script * if you submit a patch that update database and will be for 3.10 => use the new mechanism and provide a version/bug NNNN.sql file. The RM will take care of moving it to 3.9/dbrevnumber.sql when pushing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 19:48:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 17:48:56 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #1 from Elliott Davis --- Created attachment 10648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10648&action=edit Adds a print receipt to Self Checkout To Test: Log in to self checkout Enter a barcode and click submit You will be asked if you would like a receipt If you click ok you should be taken to the print receipt page and the item should check out if you click cancel the item should be checked out -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:11:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 18:11:35 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #2 from Elliott Davis --- Created attachment 10649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10649&action=edit This patch adds print slips to self checkout. To Test: Sign in to self checkout. Enter a barcode and click submit. You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and your item should check out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:16:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 18:16:49 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:19:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 18:19:11 +0000 Subject: [Koha-bugs] [Bug 8358] Purchase Suggestion Link don't open In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8358 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jul 5 20:25:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 18:25:52 +0000 Subject: [Koha-bugs] [Bug 8366] Meaning of "All" in issuing rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8366 Albert Oller changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ago at bywatersolutions.com --- Comment #3 from Albert Oller --- Hi Paul, I wasn't confused by this term, and I haven't come across any Koha partners who were confused. I can't think of a better term to use that would fit on a tab. Do you have any suggestions for a better term to use? Maybe we can just be more explicit in the manual about what is being done in each case, rather than creating a new term? Best regards, Albert -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 00:53:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 22:53:55 +0000 Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #43 from Mason James --- (In reply to comment #42) > Created attachment 10617 [details] > Bug 7818 : Following, fixing so the packages build Still need to update > koha-create to make use of the new file > > Signed-off-by: Jared Camins-Esakov Passing-QA on this patch applies clean to master 'ce138ac96f3a5a729568f6d7db2e50ce3653b7bb' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 01:34:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 05 Jul 2012 23:34:01 +0000 Subject: [Koha-bugs] [Bug 8375] New: Common diacritics not shown correctly when exporting batch label to PDF Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Priority: P5 - low Change sponsored?: --- Bug ID: 8375 Assignee: cnighswonger at foundations.edu Summary: Common diacritics not shown correctly when exporting batch label to PDF Severity: normal Classification: Unclassified OS: Linux Reporter: matted-34813 at mypacks.net Hardware: PC Status: NEW Version: unspecified Component: Label printing Product: Koha When exporting a PDF for labels, many common diacritics display as 2 unrelated characters. ----------------- Steps to reproduce bug: a) setup a koha test environment b) get a record with a diacritic in your system catalogue search -> Z3950 search -> Author: jurgen -> select the record matching the one i selectd above (jahre) -> save record -> add item -> wait for zebra to index (5min) -> catalog serach: jahre c) generate a label batch more -> tools -> label creator -> batch -> new -> add item -> title: jahre -> select and add checked (select library if not already set) d) export as PDF select record -> export batch -> export as PDF e) open and view PDF (zoom as necessary) (you can select text with PDF viewer and cut to cllipboard if needed) Actual Results: Example PDF output that I cut and pasted: 1150Jahre Mark??bel, 850 Jahre Baiersr??derhof 3886542378 Books 943/.416 Expected Results: The output should have the diacritic for ? correctly displayed. 1150 Jahre Mark?bel, 850 Jahre Baiersr?derhof Build Date & Platform: master 2012-07-05 on Debian Squeeze Linux 2.6.32 Additional Information: Refer to my detailed efforts in bug 2246. There were too many different target solutions, so I broke the specific behavior out in this new bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 02:26:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 00:26:30 +0000 Subject: [Koha-bugs] [Bug 2246] Label printing doesn't work with Unicode characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2246 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |WONTFIX --- Comment #18 from Chris Nighswonger --- I'm marking these label/diacritical related bugs as WONTFIX due to the well rehearsed issues of the pdf standard and diacriticals. If someone wants to put time into this, feel free to reopen and take ownership of these bugs. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 02:26:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 00:26:32 +0000 Subject: [Koha-bugs] [Bug 3400] Spine label program doesn't print diacritics In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3400 Bug 3400 depends on bug 2246, which changed state. Bug 2246 Summary: Label printing doesn't work with Unicode characters http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2246 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 02:26:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 00:26:43 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |2246 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 02:26:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 00:26:43 +0000 Subject: [Koha-bugs] [Bug 2246] Label printing doesn't work with Unicode characters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2246 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8375 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 02:27:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 00:27:04 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Chris Nighswonger --- I'm marking these label/diacritical related bugs as WONTFIX due to the well rehearsed issues of the pdf standard and diacriticals. If someone wants to put time into this, feel free to reopen and take ownership of these bugs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 02:34:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 00:34:29 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WONTFIX |--- --- Comment #2 from wajasu --- I'm adding a fix for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 02:35:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 00:35:01 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |matted-34813 at mypacks.net |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 02:57:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 00:57:24 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com QA Contact|koha.sekjal at gmail.com |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 03:32:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 01:32:25 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10550|0 |1 is obsolete| | --- Comment #38 from Mason James --- Created attachment 10650 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10650&action=edit [PATCH] BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Signed-off-by: Chris Cormack New version implementing Paul's advice. See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 03:38:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 01:38:36 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #39 from Mason James --- (In reply to comment #38) > Created attachment 10650 [details] > [PATCH] BUG 7621 [ENH] Circulation: Match age restriction of title with > borrower's age without using categories > > Signed-off-by: Chris Cormack > > New version implementing Paul's advice. > See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion Passing QA on this... - fixed SQL typo in updatedatabase.pl then rebased patch on commit 'ce138ac96f3a5a729568f6d7db2e50ce3653b7bb' - patch passes 'perlcritic' and 'prove xt' tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 03:47:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 01:47:13 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #3 from wajasu --- Created attachment 10651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10651&action=edit Patch enables some diacritics to show correctly when exporting labels to PDF The patch changes one line in labels/label-create-pdf.pl and calls utf8::decode($line); and it helps toggle the utf8 flag accordingly. This patch helps my diacritics to show correctly when exporting labels batches to PDF. Problem Label: 1150Jahre Mark??bel, 850 Jahre Baiersr??derhof 3886542378 Books 943/.416 Better Label: 1150Jahre Mark?bel, 850Jahre Baiersr?derhof 3886542378 Books 943/.416 The fix decodes the text we send to the PDF and turns off the utf8 flag as needed. Note: I suspect this is just a baby step for a certain subset of diacritics and someone with more extensive diacritics may not see a benefit. This patch does not fix larger unicode/embedded font issues, which require more extensive work, but it may buy time until that work is accomplished. I hope this works for others. wajasu [bug8375 0b0f8f5] Bug 8375 - Patch for Common diacritics not shown correctly when exporting batch label to PDF -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 03:50:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 01:50:13 +0000 Subject: [Koha-bugs] [Bug 7619] 3M self checkout don't work in France In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Mason James --- (In reply to comment #17) > Actually, the config object is not passed through to the write_msg sub, so > it would take quite a bit of a rewrite. > > So for now, people will need to change the variable in the C4/SIP/Sip.pm. > This works well enough, so I think it should move on to QA. The followup > would still be nice, but I don't think we should hold up pushing this fix > until then. Passing QA on this... - patch applies clean to master 'ce138ac96f3a5a729568f6d7db2e50ce3653b7bb' nice team-work everyone :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 03:55:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 01:55:23 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 03:55:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 01:55:38 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #4 from Mason James --- Created attachment 10652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10652&action=edit Bug 8375 - Patch for Common diacritics not shown correctly when exporting batch label to PDF -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 03:56:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 01:56:57 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10651|0 |1 is obsolete| | Attachment #10652|0 |1 is obsolete| | --- Comment #5 from Mason James --- Created attachment 10653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10653&action=edit Bug 8375 - Patch for Common diacritics not shown correctly when exporting batch label to PDF Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 03:58:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 01:58:56 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtj at kohaaloha.com --- Comment #6 from Mason James --- (In reply to comment #5) > Created attachment 10653 [details] > Bug 8375 - Patch for Common diacritics not shown correctly when exporting > batch label to PDF > > Signed-off-by: Mason James works for me, nice spotting! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 04:09:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 02:09:41 +0000 Subject: [Koha-bugs] [Bug 8375] Common diacritics not shown correctly when exporting batch label to PDF In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #7 from Mason James --- Created attachment 10654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10654&action=edit pic ... and a pic too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 04:29:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 02:29:14 +0000 Subject: [Koha-bugs] [Bug 7286] Introduce rebuild_zebra_sliced.zsh to recursively rebuild zebra & be error proof In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7286 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10095|0 |1 is obsolete| | Attachment #10621|0 |1 is obsolete| | --- Comment #18 from Mason James --- Created attachment 10655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10655&action=edit Bug 7286: rebuild_zebra_sliced for biblios and authorities Complete rewrite of rebuild_zebra_sliced.zsh (renamed to .sh). Main improvements are: - both biblio and authority records are handled - records are exported only once It also add an option --skip-index to rebuild_zebra.pl that permit to use rebuild_zebra.pl as an 'export only' script. Description: Index Koha records by chunks. It is useful when some record causes errors and stop the indexation process. With this script, if indexation of one chunk fails, chunk is splitted in 2 (or 3) chunks, and indexation continue on these chunks. rebuild_zebra.pl is called only once to export records. Splitting and indexing is handled by this script (using yaz-marcdump and zebraidx). Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 04:33:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 02:33:33 +0000 Subject: [Koha-bugs] [Bug 7286] Introduce rebuild_zebra_sliced.zsh to recursively rebuild zebra & be error proof In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7286 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com Version|rel_3_6 |master QA Contact|koha.sekjal at gmail.com |mtj at kohaaloha.com --- Comment #19 from Mason James --- Passing QA on this... looks good and works well for me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 04:42:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 02:42:14 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris at bigballofwax.co.nz --- Comment #3 from Chris Cormack --- Hi Elliott This looks good, but a few little things that need to be fixed in opac/sco/printslip.pl 1/ Copyright headers (it says biblibre and katipo at the moment) 2/ use warnings is commented out, we shouldn't be making new scripts with warnings commented out 3/ The pod is still referring to moremember.pl which is where the script was copied from I guess 4/ $template->param( is a HTML::Template thing, they still exist in old scripts and we have a shim in C4::Templates to fix it, but its best to make no ones like this $template->{VARS}->{'slip'} = $slip; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 04:45:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 02:45:17 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7206|0 |1 is obsolete| | --- Comment #177 from Mason James --- Created attachment 10656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10656&action=edit t/Koha.t http://bugs.koha-community.org/show_bug.cgi?id=5327 Signed-off-by: Mason James http://bugs.koha-community.org/show_bug.cgi?id=7592 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 05:01:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 03:01:43 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10650|0 |1 is obsolete| | --- Comment #40 from Mason James --- Created attachment 10657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10657&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Signed-off-by: Chris Cormack New version implementing Paul's advice. See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 05:15:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 03:15:42 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10657|0 |1 is obsolete| | --- Comment #41 from Mason James --- Created attachment 10658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10658&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Signed-off-by: Chris Cormack New version implementing Paul's advice. See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 05:20:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 03:20:04 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #42 from Mason James --- > Passing QA on this... > > - fixed SQL typo in updatedatabase.pl then rebased patch on > commit 'ce138ac96f3a5a729568f6d7db2e50ce3653b7bb' > > - patch passes 'perlcritic' and 'prove xt' tests QA comment... - i added 'agerestriction' columns in kohastructure.sql, for biblioitems and deletedbiblioitems tables - and added 'agerestriction' column for deletedbiblioitems in updatedatabase.pl some little gotchas for adding new columns to a table in Koha ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 05:46:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 03:46:34 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10656|0 |1 is obsolete| | --- Comment #178 from Mason James --- Created attachment 10659 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10659&action=edit Bug 5327 - Unit tests required for all C4 modules renamed: Koha.t -> db_dependent/Koha.t Signed-off-by: Mason James -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 05:48:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 03:48:24 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #179 from Mason James --- (In reply to comment #178) > Created attachment 10659 [details] > Bug 5327 - Unit tests required for all C4 modules > > renamed: Koha.t -> db_dependent/Koha.t > > Signed-off-by: Mason James test works well $ prove -v ./t/db_dependent/Koha.t ./t/db_dependent/Koha.t .. 1..8 ok 1 - use C4::Koha; ok 2 - slashifyDate ok 3 - xml_escape() returns empty string on undef input ok 4 - xml_escape() works as expected ok 5 - ... and does not change input in place ok 6 - _isbn_cleanup removes hyphens ok 7 - _isbn_cleanup removes parenthetical ok 8 - _isbn_cleanup converts ISBN-13 to ISBN-10 ok All tests successful. Files=1, Tests=8, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.22 cusr 0.02 csys = 0.27 CPU) Result: PASS -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 05:49:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 03:49:29 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Duncan changed: What |Removed |Added ---------------------------------------------------------------------------- CC|duncan at catalyst.net.nz | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 05:55:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 03:55:21 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7592|0 |1 is obsolete| | Attachment #7593|0 |1 is obsolete| | --- Comment #180 from Mason James --- Created attachment 10660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10660&action=edit Added coverage to unit test for TTParser http://bugs.koha-community.org/show_bug.cgi?id=5327 Signed-off-by: Katrin Fischer Test passes. Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 05:58:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 03:58:28 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #181 from Mason James --- (In reply to comment #180) > Created attachment 10660 [details] > Added coverage to unit test for TTParser > > http://bugs.koha-community.org/show_bug.cgi?id=5327 > Signed-off-by: Katrin Fischer > Test passes. > > Signed-off-by: Jared Camins-Esakov Passing QA on this, test passed OK $ prove -v xt/tt_valid.t xt/tt_valid.t .. 1..2 ok 1 - TT syntax: not using TT directive within HTML tag ok 2 - Token received same as original put on stack ok All tests successful. Files=1, Tests=2, 3 wallclock secs ( 0.02 usr 0.01 sys + 2.68 cusr 0.03 csys = 2.74 CPU) Result: PASS -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 06:01:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 04:01:10 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #182 from Mason James --- (In reply to comment #175) > Created attachment 10616 [details] > bug 5327: added some tests for C4/Items.pm > > Signed-off-by: Jared Camins-Esakov Passing QA on this patch, all test pass OK $ prove -v t/db_dependent/Items.t 1..7 ok 1 - use C4::Items; # Creating biblio instance for testing. ok 2 - New item is linked to correct biblionumber. ok 3 - New item is linked to correct biblioitemnumber. ok 4 - Retrieved item has correct itemnumber. ok 5 - Retrieved item has correct biblioitemnumber. ok 6 - Modified item barcode successfully to: 987654321. ok 7 - Item deleted as expected. # Deleting biblio testing instance. ok All tests successful. Files=1, Tests=7, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.48 cusr 0.05 csys = 0.56 CPU) Result: PASS -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 06:21:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 04:21:52 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10659|0 |1 is obsolete| | --- Comment #183 from Mason James --- Created attachment 10661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10661&action=edit added date and ISBN tests to Koha.t modified: Koha.t $ prove -v ./Koha.t 1..5 ok 1 - use C4::Koha; ok 2 - use C4::Members; 1..6 ok 1 - Insert data in database ok 2 - GetAuthorisedValueByCode ok 3 - GetKohaImageurlFromAuthorisedValues ok 4 - lost and paid works ok 5 - Child area works ok 6 - Withdrawn works ok 3 - Authorized Values Tests 1..4 ok 1 - C4::Koha->can('GetDailyQuote') ok 2 - Got a quote based on id. ok 3 - Got a random quote. ok 4 - Got a quote based on today's date. ok 4 - Daily Quotes Test 1..7 ok 1 - slashifyDate ok 2 - xml_escape() returns empty string on undef input ok 3 - xml_escape() works as expected ok 4 - ... and does not change input in place ok 5 - _isbn_cleanup removes hyphens ok 6 - _isbn_cleanup removes parenthetical ok 7 - _isbn_cleanup converts ISBN-13 to ISBN-10 ok 5 - Date and ISBN tests ok All tests successful. Files=1, Tests=5, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.48 cusr 0.06 csys = 0.57 CPU) Result: PASS -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 07:52:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 05:52:58 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Meenakshi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9436|0 |1 is obsolete| | --- Comment #12 from Meenakshi --- Created attachment 10662 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10662&action=edit Sending Improved Patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 07:56:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 05:56:14 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Meenakshi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 08:15:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 06:15:49 +0000 Subject: [Koha-bugs] [Bug 7639] system preference to forgive fines on lost items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639 Meenakshi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10662|0 |1 is obsolete| | --- Comment #13 from Meenakshi --- Created attachment 10663 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10663&action=edit Patch Set the default value as 1 for system preference 'ChargeReplFeeWhenLost'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 09:03:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 07:03:35 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #43 from Marc V?ron --- Mason, Thanks a lot for passing QA and fixing beginner's mistakes! Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 09:28:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 07:28:37 +0000 Subject: [Koha-bugs] [Bug 8366] Meaning of "All" in issuing rules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8366 --- Comment #4 from Paul Poulain --- (In reply to comment #3) > Hi Paul, > > I wasn't confused by this term, and I haven't come across any Koha partners > who were confused. The french version is quite confusing, none or BibLibre librarian project managers (4) had understood it works that way. > I can't think of a better term to use that would fit on > a tab. Do you have any suggestions for a better term to use? I propose: * Default => for branches and categorycode * Otherwise => for itemtype > Maybe we can just be more explicit in the manual about what is being done in > each case, rather than creating a new term? That's also needed, but differenciating the terms is also. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 10:34:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 08:34:44 +0000 Subject: [Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #20 from Julian Maurice --- Ok in master, marked as resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 10:34:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 08:34:45 +0000 Subject: [Koha-bugs] [Bug 7163] BibLibre acquisitions omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7163 Bug 7163 depends on bug 7304, which changed state. Bug 7304 Summary: Working on funds ergonomic display and funds management by multi librarians http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 10:39:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 08:39:24 +0000 Subject: [Koha-bugs] [Bug 6090] empty mails in message_queue are sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6090 --- Comment #16 from Julian Maurice --- Does this patch have to be pushed to stable? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 10:41:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 08:41:08 +0000 Subject: [Koha-bugs] [Bug 6097] overdue_notices: when no notice, debarred action not done In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6097 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED --- Comment #11 from Julian Maurice --- Closing this bug, it has been fixed by bug 7001 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 10:55:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 08:55:46 +0000 Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 --- Comment #3 from Julian Maurice --- I'm not sure what to do for 1.: In acqui/acqui-home.pl: Avail = allocated - (ordered + spent) (ordered and spent do not include child funds) In admin/aqbudgets.pl: Remaining = allocated - spent (here, spent include child funds, but column indicate "Base-level remaining") What should we have in these columns? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 11:01:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 09:01:41 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 --- Comment #11 from Koha Team Lyon 3 --- I suppose that if you test a checkin from a loan in days "Patrons get incorrectly debarred" patch should be enough (truncate function used in days_between routine is corrected into it) but if you do it on an hours loan, you should have both patches applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 11:03:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 09:03:35 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8468|0 |1 is obsolete| | --- Comment #27 from Julian Maurice --- Created attachment 10664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10664&action=edit File upload in MARC Rebased on master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 11:15:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 09:15:25 +0000 Subject: [Koha-bugs] [Bug 7619] 3M self checkout don't work in France In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 11:25:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 09:25:27 +0000 Subject: [Koha-bugs] [Bug 5888] opac-detail subject/author links improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 --- Comment #14 from Julian Maurice --- What do you suggest? Let the link behave like currently in master and add a new link after subjects and authors for displaying this menu? For sure, you can type what you want in the search box, but I think it's easier to check boxes than to type complete names of authorities in a search box. I do not understand your comment about normal view and xslt view. Do you want to enable this feature for xslt view too? If someone uses his own xslt and want this feature, he has to modify his xslt by himself. Anyway, opac users do not use both normal and xslt views, right? How can this be confusing for them? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 11:30:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 09:30:52 +0000 Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #44 from Paul Poulain --- Follow-up for packages pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 11:36:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 09:36:32 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10616|0 |1 is obsolete| | --- Comment #184 from Paul Poulain --- Comment on attachment 10616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10616 bug 5327: added some tests for C4/Items.pm This patch pushed -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 11:36:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 09:36:49 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10660|0 |1 is obsolete| | --- Comment #185 from Paul Poulain --- Comment on attachment 10660 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10660 Added coverage to unit test for TTParser This patch pushed -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 11:37:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 09:37:04 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10661|0 |1 is obsolete| | --- Comment #186 from Paul Poulain --- Comment on attachment 10661 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10661 added date and ISBN tests to Koha.t This patch pushed -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 11:38:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 09:38:00 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED --- Comment #187 from Paul Poulain --- May I suggest that we close this bug an open a new one = 186 comments, 96 attachments, it could become hard to follow -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 11:50:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 09:50:44 +0000 Subject: [Koha-bugs] [Bug 5725] Batch modifications for Biblios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #62 from Gaetan Boisson --- Just tried to test it. Patch doesn't apply. error: patch failed: C4/Biblio.pm:3876 error: C4/Biblio.pm: patch does not apply -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 11:51:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 09:51:00 +0000 Subject: [Koha-bugs] [Bug 4306] Label manage batch listing should show item-level itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4306 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply CC| |gaetan.boisson at biblibre.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 11:51:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 09:51:18 +0000 Subject: [Koha-bugs] [Bug 4306] Label manage batch listing should show item-level itemtype In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4306 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 11:56:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 09:56:30 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #19 from Paul Poulain --- mmm... the code says: + $newline{authtype} = defined ($thisauthtype) ? + $thisauthtype->{'summary'} : + GetAuthType($authtypecode)->{'summary'}; "summary" is not the authtype description, but how the authority display is built. I tried the patch anyway, and got a -suspected- wrong result: The "type of heading" column now show: [200a][, 200b][ 200d][ ; 200c][ (200f)] :\\\ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 11:58:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 09:58:43 +0000 Subject: [Koha-bugs] [Bug 8314] Missing MARCISBNS param in opac-detail.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8314 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com --- Comment #5 from Paul Poulain --- Patch pushed (untested, I don't think I have a biblio with more than 1 isbn in my database) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 11:58:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 09:58:52 +0000 Subject: [Koha-bugs] [Bug 8314] Missing MARCISBNS param in opac-detail.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8314 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:18:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 10:18:32 +0000 Subject: [Koha-bugs] [Bug 7725] Marking a subfield mandatory makes the entire field mandatory In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7725 Gaetan Boisson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gaetan.boisson at biblibre.com --- Comment #1 from Gaetan Boisson --- I agree with Jared. We should have the ability to define mandatory subfields in non mandatory fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:20:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 10:20:11 +0000 Subject: [Koha-bugs] [Bug 8283] Replace usage of YUI Cookie utility with jQuery Cookie plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #5 from Paul Poulain --- QA comment: There are still references to cookie-min.js in: koha-tmpl/intranet-tmpl/prog/en/lib/yui/utilities/utilities.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/yuiloader/yuiloader.js koha-tmpl/intranet-tmpl/prog/en/lib/yui/yuiloader/yuiloader-debug.js I think it's normal, as it's related to yui, but before pushing, owen could you confirm please ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:25:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 10:25:23 +0000 Subject: [Koha-bugs] [Bug 8203] Should be possible to save individual authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8203 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |paul.poulain at biblibre.com --- Comment #8 from Paul Poulain --- QA comment : UNIMARC epic fail when saving in MARCXML... The patch I made for bug 8202 is probably the way to investigate, I let you do this time: + if ($marcflavour eq 'UNIMARC' && $record_type eq 'auths') { + print $record->as_xml_record('UNIMARCAUTH'); + } else { + print $record->as_xml_record($marcflavour); + } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:30:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 10:30:21 +0000 Subject: [Koha-bugs] [Bug 8376] New: Command line utility for exporting borrowers Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8376 Priority: P5 - low Change sponsored?: --- Bug ID: 8376 Assignee: julian.maurice at biblibre.com Summary: Command line utility for exporting borrowers Severity: enhancement Classification: Unclassified OS: All Reporter: julian.maurice at biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Command-line Utilities Product: Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:37:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 10:37:43 +0000 Subject: [Koha-bugs] [Bug 8376] Command line utility for exporting borrowers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8376 --- Comment #1 from Julian Maurice --- Created attachment 10665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10665&action=edit Bug 8376: New script to export borrowers misc/export_borrowers.pl This script prints to standard output what is returned by GetMemberDetails in CSV format. Exported fields can be specified with option -f. If no -f option is specified, all fields are exported. Usage: misc/export_borrowers.pl [--field=FIELD [--field=FIELD [...]]] [--show-header] misc/export_borrowers.pl -h -f, --field=FIELD Field to export. It is repeatable and has to match keys returned by the GetMemberDetails function. If no field is specified, then all fields will be exported. -H, --show-header Print field names on first row -h, --help Show this help -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:37:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 10:37:51 +0000 Subject: [Koha-bugs] [Bug 8376] Command line utility for exporting borrowers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8376 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:38:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 10:38:38 +0000 Subject: [Koha-bugs] [Bug 7913] Automatically receive serial issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7913 --- Comment #6 from Koha Team Lyon 3 --- (In reply to comment #0) > Currently in Koha, each issues is marked "arrived" manually. This can be a > lot of work in libraries with a large number of serial subscriptions. > > Instead, automatically mark issues as received. Issues that are not received > will be marked "pending" manually. > > Create screens that display issues to be received across serials, set > default to "arrived", user can select the ones that have not arrived and > mark them as "pending". (In reply to comment #4) > the use of this function is limited to subscriptions without items > records.And the bulk reception start always from the last issue expected > then it would be better to choose which serial number you want to begin > receiving and not always from the last number expected. As for receiving from the last issue expected, I must add that this has been made thinking to the case when library is closed during some weeks (well, french university libraries close completly during 2 or 3 weeks in summer holidays). So when you come back from holidays, you can quickly and in a much easier way receive your waiting bunch of issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 12:54:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 10:54:27 +0000 Subject: [Koha-bugs] [Bug 8377] New: Show HTML5 video/ audio in OPAC for media files in 856 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 Priority: P5 - low Change sponsored?: --- Bug ID: 8377 Assignee: 5p4m at gmx.de Summary: Show HTML5 video/ audio in OPAC for media files in 856 Severity: enhancement Classification: Unclassified OS: All Reporter: 5p4m at gmx.de Hardware: All Status: ASSIGNED Version: master Component: OPAC Product: Koha With HTML5 it is possible to integrate audio and video content into websites easily. This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed the file(s) in a tab in the opac-detail view, including a fullscreen option. This enhancement introduces two sysprefs: one to enable the feature, one to specify file extensions to be recognizes as media files. This patch supports the HTML5 http://wiki.koha-community.org/wiki/HTML5_Media_RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 17:38:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 15:38:17 +0000 Subject: [Koha-bugs] [Bug 8380] New: Can not set indicators to required Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8380 Priority: P5 - low Change sponsored?: --- Bug ID: 8380 CC: m.de.rooy at rijksmuseum.nl Assignee: gmcharlt at gmail.com Summary: Can not set indicators to required Severity: enhancement Classification: Unclassified OS: All Reporter: steven_jeffery at fmi.com Hardware: All Status: NEW Version: rel_3_8 Component: Cataloging Product: Koha It is not currently possible to set the two indicators used throughout MARC to required. An example of where this could be extremely useful would be the two indicators for the 245 field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 17:58:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 15:58:07 +0000 Subject: [Koha-bugs] [Bug 6566] Checking if DB records are properly indexed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com Version|rel_3_6 |rel_3_8 --- Comment #11 from Paul Poulain --- QA comment: * new script, that can't break anything * passes perlcritic * Well documented, and various options to fit various needs (from highly silent if you run as cron to verbose if you run manually) Very usefull when run as cron every week, to check everything it OK. Here is how we use this script at BibLibre: every sunday, we run the script twice : 1st time, sending a flag for zebra to reindex unfound biblios, 2nd time without the flag, to find records that are really not indexable. Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 17:59:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 15:59:08 +0000 Subject: [Koha-bugs] [Bug 6566] Checking if DB records are properly indexed In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Assignee|gmcharlt at gmail.com |christophe.croullebois at bibl | |ibre.com --- Comment #12 from Paul Poulain --- Enhancement, but I think it's worth being ported to 3.8, and it's safe. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:10:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 16:10:16 +0000 Subject: [Koha-bugs] [Bug 7571] Maintain exchange rate history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain at biblibre.com --- Comment #6 from Paul Poulain --- QA comments: * 1st, a question = This page just keep track of exchange rates, and does nothing on acquisition, right ? Do you plan to add this feature soon or later ? * ex_rates => the name of the table is unclear (what does 'ex' mean ? it's unclear that it's exchange, and does not contain currency). currency_exchange_history or something like that would be much more clear * If I read your patch correctly, you save the history only on a modif, with the new value. That's OK if you keep track of current rate in updatedatabase: when upgrading, the current rate should be set in this table, with a timestamp of 2000-01-01, to show what was the rate before we change it for the 1st time. Failing QA for #2 and #3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:22:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 16:22:50 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Version|master |rel_3_10 --- Comment #25 from Paul Poulain --- QA comment, my concern has been answered in comment #18 > Paul and Jonathan, > > Thank you for your comments. When I introduced this feature, I was aware > that it could be used at other places as well. This version is just for the > use case where a lot of printing occurs, and it was made by advice of the > librarians in our group who often work at the front desk and who told me > that not having this feature could be a killer argument against Koha. > > I really would appreciate if you could push it, and I will be happy to > deliver follow ups for the other use cases as well. Passed QA then -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:24:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 16:24:35 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:24:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 16:24:49 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal at gmail.com |paul.poulain at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:25:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 16:25:56 +0000 Subject: [Koha-bugs] [Bug 8271] teach SIPServer to set its own lib path In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8271 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #4 from Paul Poulain --- QA comment: small change, passes QA without any problem -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:29:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 16:29:21 +0000 Subject: [Koha-bugs] [Bug 8271] teach SIPServer to set its own lib path In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8271 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #5 from Paul Poulain --- I haven't tested this patch, but I trust Colin enough to push it (chris_c, not sure it should be ported to 3.8, but maybe) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:30:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 16:30:28 +0000 Subject: [Koha-bugs] [Bug 8335] Missing Icon PR.png or typo in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8335 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #3 from Paul Poulain --- tiny bugfix, passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:30:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 16:30:40 +0000 Subject: [Koha-bugs] [Bug 8335] Missing Icon PR.png or typo in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8335 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:31:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 16:31:27 +0000 Subject: [Koha-bugs] [Bug 8335] Missing Icon PR.png or typo in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8335 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:34:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 16:34:14 +0000 Subject: [Koha-bugs] [Bug 7299] ILSDI HoldItem service does't set the itemnumber in reserves table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7299 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #6 from Paul Poulain --- QA comment: I think you could have removed the # $branch, $borrowernumber, $biblionumber, $constraint, $bibitems, $priority, $notes, $title, $checkitem, $found instead of fixing it, but that's not worth failing QA ;-) Small patch. Also add C4::Reserves:: probably needed because of nested packages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:34:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 16:34:27 +0000 Subject: [Koha-bugs] [Bug 7299] ILSDI HoldItem service does't set the itemnumber in reserves table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7299 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:39:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 16:39:24 +0000 Subject: [Koha-bugs] [Bug 8125] SIP should send Zipcode with address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8125 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #6 from Paul Poulain --- QA comment: small patch, does the job. The next if / if / else / ... of _get_address could have been written in a smaller number of lines, but that's not worth failing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 18:39:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 16:39:54 +0000 Subject: [Koha-bugs] [Bug 8125] SIP should send Zipcode with address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8125 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|unspecified |rel_3_10 --- Comment #7 from Paul Poulain --- Chris, your decision, but maybe worth porting to 3.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 19:48:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 17:48:27 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #4 from Elliott Davis --- Created attachment 10677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10677&action=edit This patch adds print slips to self checkout. To Test: Sign in to self checkout. Enter a barcode and click submit. You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and your item should check out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 19:49:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 17:49:21 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10648|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 19:49:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 17:49:29 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10649|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 19:51:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 17:51:12 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Elliott Davis --- Chris, I made the changes you requested. Let me know if it looks ok. The reason I left the copyright headers was because it was basically a direct copy and I didn't want to take credit for someone else's work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 19:57:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 17:57:25 +0000 Subject: [Koha-bugs] [Bug 8356] moveitem.tt and linkitem.tt have cataloging typo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8356 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #3 from Ian Walls --- Template only change to fix typo. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 22:10:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 20:10:01 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #6 from Chris Cormack --- (In reply to comment #5) > Chris, > > I made the changes you requested. Let me know if it looks ok. The reason I > left the copyright headers was because it was basically a direct copy and I > didn't want to take credit for someone else's work. Yep, you could add parts copyright Bywater Solutions in that case. Also now we have no copyright headers :( And no POD. A follow up fixing those would be great. But I'll sign off on it because functionality wise it works, but you will probably need that follow up to get passed QA. (The POD is handy for this http://perldoc.koha-community.org/members/patronimage.html) http://perldoc.koha-community.org/ is a great resource for developing and it gets better the better we document our code. But that will be up to QA not me :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 22:12:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 20:12:15 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10677|0 |1 is obsolete| | --- Comment #7 from Chris Cormack --- Created attachment 10678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10678&action=edit Bug 8033 : This patch adds print slips to self checkout. To Test: Sign in to self checkout. Enter a barcode and click submit. You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and your item should check out. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 22:12:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 20:12:35 +0000 Subject: [Koha-bugs] [Bug 8033] add print receipt option to Koha self-check In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 22:18:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 20:18:07 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #26 from Chris Cormack --- not ok 125 - use Koha::SearchEngine::Zebra; # Failed test 'use Koha::SearchEngine::Zebra;' # at t/00-load.t line 46. # Tried to use 'Koha::SearchEngine::Zebra'. # Error: Can't locate Data/SearchEngine/Zebra.pm in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at /usr/share/perl5/Module/Runtime.pm line 205. # at /usr/lib/perl5/Moose.pm line 63 # Compilation failed in require at (eval 1313) line 2. # BEGIN failed--compilation aborted at (eval 1313) line 2. Bail out! ***** PROBLEMS LOADING FILE 'Koha::SearchEngine::Zebra' # Tests were run but no plan was declared and done_testing() was not seen. Is what is causing jenkins to complain, I will fix it on jenkins but we probably need a patch to fix it properly pretty soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 22:47:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 20:47:36 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 --- Comment #27 from Chris Cormack --- Ok that's fixed (missing modules, easy fix) However now I am getting this not ok 129 - use Koha::SearchEngine::Solr; # Failed test 'use Koha::SearchEngine::Solr;' # at t/00-load.t line 46. # Tried to use 'Koha::SearchEngine::Solr'. # Error: Illegal inherited options => (is) at /usr/lib/perl5/Moose/Meta/Class.pm line 646. # Moose::Meta::Class::_process_inherited_attribute('Moose::Meta::Class=HASH(0x5a38b40)', 'url', 'required', 1, 'builder', '_build_url', 'isa', 'Str', 'definition_context', 'HASH(0x5e9bba8)', 'lazy', 1, 'is', 'ro') called at /usr/lib/perl5/Moose/Meta/Class.pm line 628 # Moose::Meta::Class::_process_attribute('Moose::Meta::Class=HASH(0x5a38b40)', '+url', 'required', 1, 'builder', '_build_url', 'isa', 'Str', 'definition_context', 'HASH(0x5e9bba8)', 'lazy', 1, 'is', 'ro') called at /usr/lib/perl5/Moose/Meta/Class.pm line 300 # Moose::Meta::Class::add_attribute('Moose::Meta::Class=HASH(0x5a38b40)', '+url', 'required', 1, 'builder', '_build_url', 'isa', 'Str', 'definition_context', 'HASH(0x5e9bba8)', 'lazy', 1, 'is', 'ro') called at /usr/lib/perl5/Moose.pm line 70 # Moose::has('Moose::Meta::Class=HASH(0x5a38b40)', '+url', 'is', 'ro', 'isa', 'Str', 'lazy', 1, 'builder', '_build_url', 'required', 1) called at /usr/lib/perl5/Moose/Exporter.pm line 294 # Moose::has('+url', 'is', 'ro', 'isa', 'Str', 'lazy', 1, 'builder', '_build_url', 'required', 1) called at Koha/SearchEngine/Solr.pm line 7 # require Koha/SearchEngine/Solr.pm called at (eval 1428) line 2 # main::BEGIN() called at Koha/SearchEngine/Solr.pm line 0 # eval {...} called at Koha/SearchEngine/Solr.pm line 0 # eval 'package main; # use Koha::SearchEngine::Solr @{$args[0]}; # 1; # # ;' called at /usr/local/share/perl/5.10.1/Test/More.pm line 885 # Test::More::_eval('package main;\x{a}use Koha::SearchEngine::Solr @{$args[0]};\x{a}1;\x{a}', 'ARRAY(0x3f55558)') called at /usr/local/share/perl/5.10.1/Test/More.pm line 860 # Test::More::use_ok('Koha::SearchEngine::Solr') called at t/00-load.t line 46 # main::__ANON__() called at /usr/share/perl/5.10/File/Find.pm line 958 # File::Find::_find_dir('HASH(0x8c2f60)', '/home/jenkins/jobs/Koha_master/workspace/Koha', 7) called at /usr/share/perl/5.10/File/Find.pm line 722 # File::Find::_find_opt('HASH(0x8c2f60)', '/home/jenkins/jobs/Koha_master/workspace/Koha') called at /usr/share/perl/5.10/File/Find.pm line 1297 # File::Find::find('HASH(0x8c2f60)', '/home/jenkins/jobs/Koha_master/workspace/Koha') called at t/00-load.t line 49 # Compilation failed in require at (eval 1428) line 2. # BEGIN failed--compilation aborted at (eval 1428) line 2. Bail out! ***** PROBLEMS LOADING FILE 'Koha::SearchEngine::Solr' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 23:19:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 21:19:25 +0000 Subject: [Koha-bugs] [Bug 7619] 3M self checkout don't work in France In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #19 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 23:26:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 21:26:24 +0000 Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #45 from Chris Cormack --- Follow up pushed to 3.8.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 23:36:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 21:36:17 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #42 from Chris Cormack --- Created attachment 10679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10679&action=edit Bug 7143 : Adding Stacey Walker to the history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 23:36:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 21:36:52 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jul 6 23:55:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 21:55:12 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #189 from Chris Cormack --- Im not pushing the patch for Koha.t to stable, it should be in db_dependent It will break installing otherwise. Please push a follow up so I can push them both -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 01:39:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 06 Jul 2012 23:39:38 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #190 from Chris Cormack --- Created attachment 10680 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10680&action=edit Bug 5327 : Follow up for TTParser test -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 02:00:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 00:00:57 +0000 Subject: [Koha-bugs] [Bug 8314] Missing MARCISBNS param in opac-detail.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8314 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 02:04:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 00:04:21 +0000 Subject: [Koha-bugs] [Bug 7286] Introduce rebuild_zebra_sliced.zsh to recursively rebuild zebra & be error proof In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7286 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #21 from Chris Cormack --- This patch changes rebuild_zebra.pl as well, so not just a new script. I will do some testing to make sure that still works fine (it looks like it should) And will push to 3.8.x if it is ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 02:52:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 00:52:55 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10679|0 |1 is obsolete| | --- Comment #43 from wajasu --- Created attachment 10681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10681&action=edit [SIGNOFF] Bug 7143 : Adding Stacey Walker to the history The patch added Stacey Walker to the koha development team "about"->koha team web page and the docs/history.txt Tested patch for signoff. OK wajasu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 02:53:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 00:53:31 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 wajasu changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |matted-34813 at mypacks.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 05:08:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 03:08:52 +0000 Subject: [Koha-bugs] [Bug 7286] Introduce rebuild_zebra_sliced.zsh to recursively rebuild zebra & be error proof In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7286 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #22 from Chris Cormack --- If you don't pass the new flag to rebuild_zebra.pl nothing changes, so it's a safe change. Pushed to 3.8.x, will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 05:11:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 03:11:41 +0000 Subject: [Koha-bugs] [Bug 8323] User created lists not sorting properly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 08:31:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 06:31:01 +0000 Subject: [Koha-bugs] [Bug 8360] Author facet not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8360 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr --- Comment #2 from Fr?d?ric Demians --- I confirm the bug. Why 'wrdl' and not 'phr'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 10:31:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 08:31:50 +0000 Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #44 from M. de Rooy --- Attachment 10681: Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 10:44:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 08:44:58 +0000 Subject: [Koha-bugs] [Bug 5888] opac-detail subject/author links improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 --- Comment #15 from M. de Rooy --- (In reply to comment #14) > What do you suggest? Let the link behave like currently in master and add a > new link after subjects and authors for displaying this menu? Well, that could be the best of both! If I click on a name, I directly get what I want. If I want to select multiple names/topics, I get your menu. I would be in favor of that; but I do not want to force a personal opinion. Your are welcome to raise this point on the mailing list (before just changing your code) ... > I do not understand your comment about normal view and xslt view. Do you > want to enable this feature for xslt view too? If someone uses his own xslt > and want this feature, he has to modify his xslt by himself. You are right about custom xslt, but if the default xslt could also support this feature somehow, that would be nice. (Note that this could be handled in a followup.) > Anyway, opac users do not use both normal and xslt views, right? How can > this be confusing for them? Correct. Maybe it is more confusing for developers :-) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 10:46:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 08:46:04 +0000 Subject: [Koha-bugs] [Bug 5888] opac-detail subject/author links improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 11:30:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 09:30:45 +0000 Subject: [Koha-bugs] [Bug 8335] Missing Icon PR.png or typo in MARC21slim2OPACDetail.xsl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8335 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 11:36:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 09:36:43 +0000 Subject: [Koha-bugs] [Bug 7299] ILSDI HoldItem service does't set the itemnumber in reserves table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7299 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 14:10:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 12:10:51 +0000 Subject: [Koha-bugs] [Bug 8268] Koha should offer way to backup entire db In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268 --- Comment #12 from Fr?re S?bastien Marie --- (En r?ponse au commentaire 11) > > Marking passed QA, I'll delay pushing, I'll wait for some feedback from > semarie, just in case The code seems globally ok: just 4 remarks. Some security remarks (in tools/export.pl): 1. a problem (common in koha): use of user-input in warn. An attacker can forge entries in log file (see CWE-93) (resume: if variable contains CRLF, the log file too... and the next line is forged: so who write in log ? koha or attacker ?) > warn "A suspicious attempt was made to download the db at '$filename' by ..." 2. about the regex for $filename verification > return unless ( ... && not $filename =~ m#(^\.\.|/)# ); The regex could be translated as: $filename should not: - start with '..' OR - contains '/' I don't understand the purpose of "^..", if '/' is forbidden; as you can't escape from directory without '/'. So I think m#/# is suffisent (please correct me if not). Some generals remarks: 3. the directory for backup is not consitent in differents files: in debian/templates/koha-conf-site.xml.in, the directory use for backupdir is: > /var/lib/koha/__KOHASITE__ in Makefile.PL, the directory seems to be in /var/spool : > './skel/var/spool/koha' => { target => 'BACKUP_DIR', trimdir => -1 }, in debian/scripts/koha-dump: > [ -z "$backupdir" ] && backupdir="/var/spool/koha/$name" 4. in misc/cronjobs/backup.sh The lasts lines are for mail admin if ok, or mail admin if not ok. > [ -f $KOHA_BACKUP] && echo "$KOHA_BACKUP was successfully created." | mail kohaadmin -s $KOHA_BACKUP || > echo "$KOHA_BACKUP was NOT successfully created." | mail kohaadmin -s $KOHA_BACKUP First, there are *two* lines. I haven't test it, but it should be an error as "cmd_a && cmd_b ||" is not a valid shell expression. Should be one-line "cmd_a && cmd_b || cmd_c" Secondly, I'm not sure that the behaviour is correct. "cmd_a && cmd_b || cmd_c" could be expanded as: if cmd_a ; then if ! cmd_b ; then cmd_c fi else cmd_c fi so if cmd_b failed (echo "backup ok" | mail admin), the cmd_c (echo "backup err" | mail admin) will be run (and expected to failed too, as the first try). Proposed correction: > if [ -f $KOHA_BACKUP] ; then > echo "$KOHA_BACKUP was successfully created." | mail kohaadmin -s $KOHA_BACKUP > else > echo "$KOHA_BACKUP was NOT successfully created." | mail kohaadmin -s $KOHA_BACKUP > fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 14:39:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 12:39:08 +0000 Subject: [Koha-bugs] [Bug 8268] Koha should offer way to backup entire db In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268 --- Comment #13 from Fr?re S?bastien Marie --- Just another error (and that I kept in my "proposed correction", so please correct also my correction :-) ), in 4. "misc/cronjobs/backup.sh" [ -f $KOHA_BACKUP] is not correct, but [ -f $KOHA_BACKUP ] is. -sh: [: missing `]' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 14:57:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 12:57:43 +0000 Subject: [Koha-bugs] [Bug 8268] Koha should offer way to backup entire db In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268 --- Comment #14 from Jared Camins-Esakov --- Created attachment 10682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10682&action=edit Bug 8268 follow-up: incorporate QA comments Fixes the following things: 1. Sanitizes log output to prevent an attacker from using a specially crafted POST to add extra lines to the log 2. Simplify a regular expression since "..file" cannot be used to escape the current directory 3. Makes sure directories are consistent 4. Correct logic issues in misc/cronjobs/backup.sh Thanks to Fr?re S?bastien Marie for catching these issues. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 15:01:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 13:01:20 +0000 Subject: [Koha-bugs] [Bug 8268] Koha should offer way to backup entire db In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268 --- Comment #15 from Jared Camins-Esakov --- (In reply to comment #12) > (En r?ponse au commentaire 11) > > > > Marking passed QA, I'll delay pushing, I'll wait for some feedback from > > semarie, just in case > > The code seems globally ok: just 4 remarks. > > Some security remarks (in tools/export.pl): > 1. a problem (common in koha): use of user-input in warn. An attacker can > forge entries in log file (see CWE-93) (resume: if variable contains CRLF, > the log file too... and the next line is forged: so who write in log ? koha > or attacker ?) > > > warn "A suspicious attempt was made to download the db at '$filename' by ..." > > > 2. about the regex for $filename verification > > return unless ( ... && not $filename =~ m#(^\.\.|/)# ); > > The regex could be translated as: $filename should not: > - start with '..' > OR > - contains '/' > > I don't understand the purpose of "^..", if '/' is forbidden; as you can't > escape from directory without '/'. > > So I think m#/# is suffisent (please correct me if not). > > > > Some generals remarks: > 3. the directory for backup is not consitent in differents files: > > in debian/templates/koha-conf-site.xml.in, the directory use for backupdir > is: > > /var/lib/koha/__KOHASITE__ > > in Makefile.PL, the directory seems to be in /var/spool : > > './skel/var/spool/koha' => { target => 'BACKUP_DIR', trimdir => -1 }, > > in debian/scripts/koha-dump: > > [ -z "$backupdir" ] && backupdir="/var/spool/koha/$name" > > > 4. in misc/cronjobs/backup.sh > > The lasts lines are for mail admin if ok, or mail admin if not ok. > > [ -f $KOHA_BACKUP] && echo "$KOHA_BACKUP was successfully created." | mail kohaadmin -s $KOHA_BACKUP || > > echo "$KOHA_BACKUP was NOT successfully created." | mail kohaadmin -s $KOHA_BACKUP > > First, there are *two* lines. I haven't test it, but it should be an error > as "cmd_a && cmd_b ||" is not a valid shell expression. Should be one-line > "cmd_a && cmd_b || cmd_c" > > Secondly, I'm not sure that the behaviour is correct. > "cmd_a && cmd_b || cmd_c" could be expanded as: > > if cmd_a ; then > if ! cmd_b ; then > cmd_c > fi > else > cmd_c > fi > > so if cmd_b failed (echo "backup ok" | mail admin), the cmd_c (echo "backup > err" | mail admin) will be run (and expected to failed too, as the first > try). > > Proposed correction: > > if [ -f $KOHA_BACKUP] ; then > > echo "$KOHA_BACKUP was successfully created." | mail kohaadmin -s $KOHA_BACKUP > > else > > echo "$KOHA_BACKUP was NOT successfully created." | mail kohaadmin -s $KOHA_BACKUP > > fi Thank you for catching those issues. I corrected them all with the follow-up. (In reply to comment #11) > QA comment: > > You add 2 subs: getbackupfilelist and download_backup => bad point, we > usually use capitals (GetBackupFileList and DownloadBackup). However, this > is not in a package, so I won't fail QA for that. Our standard is to use lowercase in .pl files and uppercase in packages, I think. I suppose that makes sense, since it ensures that there will be a visual distinction between local functions and core functions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 16:41:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 14:41:42 +0000 Subject: [Koha-bugs] [Bug 7500] Use CSS Sprites for faster page loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 --- Comment #23 from Jared Camins-Esakov --- I am a little confused by the status of this bug. Does anything here still need sign off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 17:11:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 15:11:52 +0000 Subject: [Koha-bugs] [Bug 8322] Removing space between end of marc data and fullstops In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8322 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10529|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov --- Created attachment 10683 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10683&action=edit bug 8322 removing additional spaces before fullstop on catalogue/detail and opac-detail pages. Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jul 7 17:12:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 07 Jul 2012 15:12:02 +0000 Subject: [Koha-bugs] [Bug 8377] Show HTML5 video/ audio in OPAC for media files in 856 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8377 --- Comment #2 from Mirko Tietgen <5p4m at gmx.de> --- Created attachment 10684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10684&action=edit Bug 8377 [ENH] Show HTML5 video/ audio in OPAC for media files in 856 This enhancement uses information from MARC field 856 to generate the appropriate HTML5 code to embed a media player for the file(s) in a tab in the opac-detail view. This patch supports the HTML5