[Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430

--- Comment #22 from Chris Cormack <chris at bigballofwax.co.nz> ---
(In reply to comment #21)
> (In reply to comment #19)
> > I'm going to play curmudgeon, criticism without a valid counter suggestion
> > is not useful :) So if not Koha::Utils what would you call it?
> 
> A crusty, ill-tempered, and usually old man? ;)
> I am not sure if that may not be useful [at times], btw.. But let me give it
> a try:
> High-level configuration functions like GetMarcFromKohaField and
> GetAuthType..
> GetAuthType looks to me like a candidate for the originally called
> Koha::DataObject, since it just passes the fields for auth_types table.
> GetMarcFromKohaField should be moved somewhere within Koha::BusinessLogic or
> its shorter variant. There could be room there for MARC utilities?
> Let's say: Koha::BusinessLogic::MarcUtils::GetMarcTagForKohaField.
> If we do not like MarcUtils after all, another proposal:
> Koha::BusinessLogic::Administration::GetMarcTagForKohaField.

Positive criticism, IE with useful suggestions on how to fix the problem is
always useful, Negative criticism almost never is. Lest we become the linux
kernel mailing list :-)

My criticism here is those names are quite long, and I don't think these
routines are business logic at all.  Are we going to build an inheritance
structure such that those are objects under inheriting from the classes above
them, or is it just an arbitrary naming scheme. If it's arbitrary and there is
no inheritance, then I like Koha::MARCUtils better.

That would be my preference, but, I am not going to die in a ditch about it, I
would accept something like Koha::Service::MARCUtils (Service is what
BusinessLogic has moved to it seems). What I would like is this patch
progressed and the remnants of no zebra to go away and stop causing us issues.

And yes I am a grumpy old man :)

-- 
You are receiving this mail because:
You are watching all bug changes.