[Koha-bugs] [Bug 8350] New: $search = '0' or 0 will fail to affect SQL statement correctly in C4::Breeding

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8350

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8350
          Assignee: gmcharlt at gmail.com
           Summary: $search = '0' or 0 will fail to affect SQL statement
                    correctly in C4::Breeding
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: mtompset at hotmail.com
          Hardware: All
            Status: NEW
           Version: unspecified
         Component: MARC Bibliographic record staging/import
           Product: Koha

It is possible that a title or author could be '0', and thus the simple if
($search) will fail. By changing it to defined 0, '0', and '' are included.
However, this would mess up the SQL include a pointless 'like %%'. So, add in a
length check and all should be good.

($search) becomes (defined($search) && length($search)>0)
Similar logic needs to apply to the isbn number too.

-- 
You are receiving this mail because:
You are watching all bug changes.