[Koha-bugs] [Bug 7167] updatedatabase improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #73 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to comment #72)
> > File structure: As mentioned above, make directories for a Koha release.
> > Getting all updates means fetching the updates from a few directories. This
> > makes the feature more future-proof.
> 
> I create all of .sql and .pl until version 3.09.00.018 (current master)
Jonathan, I think that what Marcel was suggesting was to have :
mysql/versions/3.09.00/001.sql
mysql/versions/3.09.00/002.sql
mysql/versions/3.09.00/003.sql

+ if we do that shouldn't we remove those lines from
data/mysql/updatedatabase.pl ?
+ that will cause some trouble to ppl running master (we can announce it, not a
real problem, just warning)

> > admin/updatedatabase.pl: Line 33 adds a fixme to new code: Add a new flag?
> Finally I use the "parameters" flag. I don't know if we want a special
> permission.
sounds OK to me

About:
> 2) The distinction between numbered dbrevs and unnumbered ones should be
> added. Note however that my suggestion to not show them in normal mode can
> be discarded.
you said nothing, so I checked : it works ! I created a bug 1.sql file, and it
applies smoothly.
So our workflow could become : "when you submit a patch that has a DB update,
put it in a file named bug NNNN.sql or bug NNNN.pl, the RM will take care of
the final number when pushing it"

That would result in no more merge conflicts, sandboxes working well in any
circumtances, I love this patch ;-)

Tested a lot again, work well, switching to signed off again, Marcel, your
opinion about data/mysql/updatedatabase.pl that should be cleaned from 3.09.*
patches ? [Note that, in the meantime, we've reached 22 already ;-) ]

If we want to do it that way, it means that all patches pending sign-off/QA
will have to be updated to take care of this new behaviour. Not a big deal,
just noticing it

-- 
You are receiving this mail because:
You are watching all bug changes.