[Koha-bugs] [Bug 8268] Koha should offer way to backup entire db

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |paul.poulain at biblibre.com,
                   |                            |semarie-koha at latrappe.fr
            Version|master                      |rel_3_10

--- Comment #11 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment:

You add 2 subs: getbackupfilelist and download_backup => bad point, we usually
use capitals (GetBackupFileList and DownloadBackup). However, this is not in a
package, so I won't fail QA for that.

Other than this, I can't find anything wrong in your code, the security triple
check (ENV and unix permission, and superlibrarian) is perfect.

I'm adding semarie, that is a boss at finding security holes. (Cher frère, si
tu trouves un problème, ne te prive pas !)

Marking passed QA, I'll delay pushing, I'll wait for some feedback from
semarie, just in case

-- 
You are receiving this mail because:
You are watching all bug changes.