[Koha-bugs] [Bug 7839] Enhancement: Show routing lists attached to patron in Patron record

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7839

--- Comment #20 from David Cook <dcook at prosentient.com.au> ---
Thanks for the typo fix! 

I see what you're saying about the "_blank" attribute. As I look over other
parts of Koha, I see that everything stays in the same browser tab. For the
sake of consistency, it's probably best to keep the same behaviour here as
well.

Plus, as you say, it's bad practice in general, especially as there is no
warning that it opens a new tab. I'd be willing to nix the "_blank" targets
from the search form and the links.



(In reply to comment #19)
> It doesn't work. You SQL statement has a typo. You have:
> 
>   JOIN subscriptionroutinglist ON USING(subscriptionid)
> 
> You need:
> 
>   JOIN subscriptionroutinglist USING(subscriptionid)
> 
> After this fix, the new Routing Lists tab displays properly patron
> routing lists. It's great.
> 
> When Routing Lists tab is selected, under the Edit-Change password
> buttons bar, there is a search form.  When running such a search on
> subcription, the search result is displayed in a new browser tab. The
> search form has a target="_blank" attribute. This is not something which
> is done elsewhere in Koha, and it's generally considered has a 'bad
> practice'. It means that you have to close the new browser tab in order
> to come back to the patron page, and then refresh by yourself the page,
> if you want to see what you've done in serial module. Same issue with
> the Edit Routing List link which open a new browser tab.
> 
> For me, this point is a matter of discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.