[Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions)

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #7 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment: some Perl comments:
+    if(C4::Context->preference("autoMemberNum")) {
+        if ($data{'cardnumber'} eq '') {
+               $data{'cardnumber'}=
fixup_cardnumber($data{'cardnumber'},C4::Context->userenv->{'branch'},
$data{'categorycode'});
+        }
+    }
=> you should write
+    if (C4::Context->preference("autoMemberNum") && $data{'cardnumber'} eq '')
{
+               $data{'cardnumber'}=
fixup_cardnumber($data{'cardnumber'},C4::Context->userenv->{'branch'},
$data{'categorycode'});
+    }

and
+if (C4::Context->preference("autoMemberNum")) {
+    $template->param( autoMemberNum => 1);
+} else {
+    $template->param( autoMemberNum => 0);
+}
could be set 
+ $template->param( autoMemberNum => C4::Context->preference("autoMemberNum"));

Marking failed QA for that reason, please fix & resubmit, i'll push quickly

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.