[Koha-bugs] [Bug 4460] Amazon's AssociateID tag not used in links so referred revenue lost

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |ASSIGNED
           Severity|normal                      |blocker

--- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> ---
This breaks the opac-user.tt template.

Resulting in an internal server error.
Software error:

Template process failed: file error - parse error -
/home/chrisc/git/catalyst-koha/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt
line 214: unexpected token (ELSE)
  [% ELSE %] at /home/chrisc/git/catalyst-koha/C4/Templates.pm line 127.


The tests of course pick this up

not ok 672 -
/home/chrisc/git/catalyst-koha/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt
#   Failed test
'/home/chrisc/git/catalyst-koha/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt'
#   at xt/author/valid-templates.t line 62.
# file error - parse error -
/home/chrisc/git/catalyst-koha/koha-tmpl/opac-tmpl/prog/en/modules/opac-user.tt
line 214: unexpected token (ELSE)
#   [% ELSE %]

Which is why we should always run the tests before we push!

This needs to be reverted or a follow up pushed ASAP. OPAC logins currently
broken

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.