[Koha-bugs] [Bug 7639] system preference to forgive fines on lost items

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7639

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #14 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comments:

* hardcoded MARC21 detected !!!! = +    my $newitemlost =
$itemtosave->subfield('952','1'); => this does not work at all for UNIMARC and
will break UNIMARC setups !!! To find the proper MARC field& subfield use my
($item_tag,$item_subfield) = &GetMarcFromKohaField("items.itemlost",'');

* your patch adds tabs instead of 4 spaces for indentation, plus I think it has
a wrong indentation
+    if ( my $borrowernumber = $issues->{borrowernumber} ){
should be at the same column as # if a borrower lost the item, add a
replacement cost to the their record, it's not the case when I apply the patch

* The patch does not apply cleanly anymore, there are some conflicts on:
CONFLICT (content): Merge conflict in C4/Circulation.pm
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl

Please fix #1 and #2, rebase for #3 and resubmit, thanks

-- 
You are receiving this mail because:
You are watching all bug changes.