[Koha-bugs] [Bug 7167] updatedatabase improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #93 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
I squashed the commits and removed the sql files from them.
I hoped to get this patch in Passed QA status, but found too many errors. (The
latest changes cannot have been tested extensively.)
I started with a few small amendments, but this kept growing.. (See commit
message)
After all, I spent the whole afternoon on testing and debugging. This went far
beyond regular QA..
My sugggestion is that Jonathan continues at this point.

Some points still to consider:
The turnover point is now hardcoded at 3.9.0.25 at two places. If I upgrade
from 3.9.0.24 to a fictitious 3.9.0.26 (in a separate dbrev), install somehow
does not run the 3.9.0.26. Although update on the command line does.
About shows a version 25 with rev applied 26. Should be 26 without.
While looking at the code so extensively, I have been wondering if the
get_queries and execute stuff is really needed. Why not run the file? Actually,
I did for perl dbrevs now. (But let us discuss that first.)

After fixing these issues, please tell what you actually tested. Run tests from
older versions to this version and include some new test versions on top of it.

-- 
You are receiving this mail because:
You are watching all bug changes.