[Koha-bugs] [Bug 8418] Koha::Calendar is_holiday ignores all user data

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8418

--- Comment #13 from Dobrica Pavlinusic <dpavlin at rot13.org> ---
Rest of the code doesn't use (In reply to comment #11)
> Hi Dobrica, 
> 
> So maybe he patches are breaking things in other places now? Is there a way
> to check/make sure?

I did that before I started modifing code.

git grep day_month_closed_days

is quite useful to get all places in code without need to write elaborate grep
statements. To be honest, I switched to git grep from my own hand-crafted greps
in this bug, so I'm sharing my excitement here :-)

According to our coding guidelines, other code shouldn't access values directly
in Koha namespace anyway, which is probably only reason why we are mocking test
data within module itself (which was strange to me at first, and is probably
reason why I broke it).

I cleaned up two patches which to include correct mocking of test data.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.