[Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #51 from Paul Poulain <paul.poulain at biblibre.com> ---
Ha ! I understang now why I couldn't make it work ! I needed almost 2 hours to
understand !!!

Try "Age" in the syspref, and enter Age 18 => epic fail
In the code, the comparison line says:
            if (grep {uc($_) eq $value} @marker) {
UC ! UC ! UC !
Try AGE, it works !
So, either fix the patch or fix the documentation

2 other reasons for failing QA:
  * You patch says:
+                my $td = Date_to_Days(Today);
+                my $ad = Date_to_Days(@alloweddate);
+
+                if ( Date_to_Days(Today) <  Date_to_Days(@alloweddate) -1  ) {

 => you make no use of $td and $ad

 * The patch also says: preference('AgeRestrictionOverride ')
 => the space at the end of the syspref is bad

-- 
You are receiving this mail because:
You are watching all bug changes.