[Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671

Mason James <mtj at kohaaloha.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #15 from Mason James <mtj at kohaaloha.com> ---
(In reply to comment #14)
> Created attachment 10343 [details]
> [SIGNED-OFF] Bug 7671 : add a real primary key accountlinesid in accountlines
> 
> Signed-off-by: Stéphane Delaune <stephane.delaune at biblibre.com>
> Signed-off-by: Marc Veron <veron at veron.ch>
> 
> NOTE: After applying the patch I got following errors in members/pay.pl:
> Global symbol "$writeoff_sth" requires explicit package name
> Global symbol "$add_writeoff_sth" requires explicit package name
> 
> Added to lines at the begin of members/pay.pl:
> our $writeoff_sth;
> our $add_writeoff_sth;
> 
> Now the patch worked as expected.
> 
> However I am not quite sure if signing off is OK in this situation.


QA comment...

Stephane, can you (or someone else) sign-off on Marc's syntax fixes to your
patch

-- 
You are receiving this mail because:
You are watching all bug changes.