[Koha-bugs] [Bug 8453] need spaces after radio buttons on inventory

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jul 18 01:31:34 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8453

--- Comment #10 from David Cook <dcook at prosentient.com.au> ---
(In reply to comment #8)
> (In reply to comment #7)
> > I agree with David, I think it is a good practice to use CSS to control
> > ajustment.
> 
> Yes, but reducing the level of granularity to that of a single space is
> taking this good practice too far.
>  
> > But in this case, it is possible to do more sexy radio buttons using labels.
> 
> Yes, your patch is a more thorough fix, giving us clickable labels. However,
> it still relies on whitespace to preserve spacing around the elements ;)

After a quick look around at subscriptions-add.pl and import_borrowers.pl, it
seems that clickable labels (rather than a single space) are already the
standard practice and inventory.pl was just missed.

There is already an existing "radio" class for the "li" element that adds the
whitespace between the radio button and the clickable label (which would also
need to be introduced). 

I know this is a trivial issue, but I'm still on the side of consistency.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list