[Koha-bugs] [Bug 8453] need spaces after radio buttons on inventory

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jul 18 02:10:52 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8453

--- Comment #12 from David Cook <dcook at prosentient.com.au> ---
(In reply to comment #9)
> And putting this in to discussion is just delaying an easy fix from making
> it in to Koha.  
> 
> I say leave my tini tiny itty bitty harmless patch as it is and if you want
> to follow up with a more thorough patch go for it.  
> 
> Some of us (like me) don't have a lot of things to contribute to the code
> and so when I make string and spacing fixes and they get trashed cause
> they're not complicated enough it's kind of discouraging and the reason why
> more people without lots of programming skills aren't submitting patches.

Nicole, I still maintain that an easy fix isn't always the right fix. The more
I work with Koha, the more I see a need for consistent practice. Paul failed my
Bug 7839 fix, because I didn't adhere to the spelling and naming guidelines.
While that might seem trivial, I see the logic in preserving consistency. I was
happy to re-write my patch. 

However, I do apologize for making it seem like I was trashing your fix. That
was not at all my intention. I think that a lot of the fixes you do, especially
in regards to documentation, are absolutely invaluable. In the future, I will
try to be more positive in my feedback. I don't think patches need to be
complex to be useful.

In any case, I've thrown in my two cents, so I'll bite my tongue now :p.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list