[Koha-bugs] [Bug 8422] Fix impossible warning in circulation.pl when OverduesBlockCirc set to Block

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8422

--- Comment #5 from David Cook <dcook at prosentient.com.au> ---
(In reply to comment #4)
> > Thoughts?
> 
> David, my thoughts are that the Circulation would not deserve a complete
> rewritte... Many things are crappy/ years of code piled, you've found one.
> 
> About your patch = it's pushed. Note that you could have kept the [%
> USERBLOCKEDOVERDUE %] information:
> Checkouts are BLOCKED because patron has [% USERBLOCKEDOVERDUE %] overdue
> items
> 
> Is there reason not to do it that way ?

Point well received, Paul. I'm not sure that the template would need a complete
re-write, but I figured it was worth flagging and maybe I will come back and
fix that up someday. I don't have the programming skill (yet) to work on some
of the deeper issues, but I figure that I can help iron out the interface.

As for my patch, I thought about keeping the [%
> USERBLOCKEDOVERDUE %] information, but I thought that it was potentially misleading. The patron isn't blocked because of the number of overdue items. They're blocked because they have overdue items. I figured that my patch used more precise language.

-- 
You are receiving this mail because:
You are watching all bug changes.