[Koha-bugs] [Bug 8453] need spaces after radio buttons on inventory

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Jul 18 10:12:45 CEST 2012


http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8453

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #13 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Hi Nicole and Owen,

I agree, It is a lot of discussion for a little patch.
But I think this kind of patch should have never exist :)

Let me explain you why.

When I arrived on this patch to make QA, I thought: it is an easy patch. I was
surprised to find an unique space for a patch. I didn't know we wanted to add
space after a input radio.

Apparently, I am not alone in this case.
My job as a part of QA team is to put in question each patch. I think this one
should not have exist, because the ajustement between input and label should
automatically be taken into account.
Otherwise, for each patch adding these lines, inevitably a patch will have to
be created to fix that. It's not very productive, I think.
Given that, we can fix that definitely and don't create a new patch for each
space to add.

You patch works well, but it fixes one problem rather than fixing all futur
problems

Marking as Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list