[Koha-bugs] [Bug 7628] Required format is not enforced for Patron Categories

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7628

--- Comment #7 from Marc Véron <veron at veron.ch> ---
Jonathan,

When our librarians tested Koha for the first time they wanted to have some
categories similar to "KIDS 4 +"

Then they wanted to delete the code and did not succeed. 

My patch would have prevented them to enter "illegal" characters (and to have a
user experience like 'It does not work'). 

And if we do not allow to enter illegal characters there is no need to delete
entries with illegal characters.

I think the main question is: What characters should be / are allowed with
category codes? 

I had a look at the manual for 3.8:
http://manual.koha-community.org/3.8/en/patscirc.html#patcats
-Snip---------------
The 'Category Code' is an identifier for your new code.
    Important
    The category code is limited to 10 characters (numbers and letters)
-End snip---------------

Your patch assumes that &, @, /, ;, :, =, +, ? and $ are legal characters. Are
they (without having side effects at other places in Koha)? Should all
characters be allowed? What was (historically) the reason for the restriction
in the manual? Why are the codes upper cased by the existing JavaScript?

If there are no side effects, your patch is the better solution, because it
gives the useres more flexiblity to choose a 'speaking' code. (Manual should
then be updated, though). If we have to expect side effects, I would prefer my
restricion on data entry.

Marc

-- 
You are receiving this mail because:
You are watching all bug changes.