[Koha-bugs] [Bug 4048] CSS and JS libs must be outside of translated paths

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4048

Owen Leonard <oleonard at myacpl.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #13 from Owen Leonard <oleonard at myacpl.org> ---
Revised again following major changes to jQuery and YUI assets. The correction
in Julian's first patch has been incorporated. Yet another updated branch here:
http://gitorious.org/koha-dev/koha-dev/commits/ip-bug-4048-css-js-libs-2012-04-24

        This patch is an attempt to tackle Bug 4048 in a more incremental
        way. As suggested by Paul, this patch leaves in place a copy of
        the CSS and JS files in their original location to allow
        full implementation to be gradual.

        1. Template.pm has been modified to pass an "interface" variable
           to the templates so that references to [% themelang %] can be
           replaced with [% interface %]/[% theme %] ("intranet-tmpl/prog")
           where appropriate.

        2. The staff client's css, js, and lib directories have been
           'git mv'ed to intanet-tmpl/prog where the img directory is.
           'git mv' was used to preserve the git history of the files
           which are in their correct location.

        3. The staff client's css, js, and lib directories have been
           copied back to their original location in order to provide
           a fallback as we make corrections to individual templates.
           These files have lost their git history, but will ultimately
           be deleted anyway.

        4. The staff client's primary document header include files have
           been updated with the new paths. These are the files that
           define the paths to all the core CSS and JS files.

        5. Relative image paths in the moved CSS files have been corrected to
           point to the right directory.

        TO TEST:

        After applying the patch, look at any page in the staff client.
        If the CSS paths are correct everything should look normal. View
        source to confirm that core assets are being pulled from the new
        location. If you use Firefox and have Firebug enabled it should
        report no "NetworkError: 404" errors.

-- 
You are receiving this mail because:
You are watching all bug changes.