[Koha-bugs] [Bug 7167] updatedatabase improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #100 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
> Suppose you've handled 3.05.00.017 upgrade. It does a different SQL request depending on your MARC flavour. With this patch, you will know, *6 months later*, which SQL requests you *had* executed. Whatever your parameters are *today*.
Sorry, I do not understand. I do not see any logic in the code that makes that
happen. I do not think that we actually need that either.

Additional observations: 
If a sql command in a .sql file spans two lines, the patch does disapprove it:
Errors : Error : 1113 => A table must have at least 1 column Error : 1064 =>
You have an error in your SQL syntax; check the manual that corresponds to your
MySQL server version for the right syntax to use near 'id int)' at line 1
Note: IMHO we should not write a sql parser. And if we accept .sql files, we
should be able to handle them all. I still strongly prefer to run .sql files
via mysql; this is something that you also expect to happen.
Side note: If a db rev fails, how do I get rid of the Failed-lines on the
update screen?
Side note: The About form lists db revs that failed as if they have been
applied correctly.

update.pl: When run from installer, I think that update.pl should only run the
numeric db revs. Note that the current code around line 52/53 does not handle
that correctly:
Argument "\x{74}\x{65}..." isn't numeric in numeric ge (>=) at
installer/data/mysql/update.pl line 52.
I just added a provisional test now to get further. Please correct.
Maybe you need an additional parameter here? 

chmod 755 was needed on update.pl; the system call in install.pl to update.pl
did not work for that reason.
And of course, if you run it that way include a shebang line. Did that now too.
Please add copyright as well.

Output from webinstaller now includes: 3.09.00.027 => ARRAY(0x1b1da88). Please
correct.
The webinstaller lists the wrong new version; it now lists 3.9.0.26 but it will
install 27 too.
The subsequent calls to IPC run and print_std do not work somehow. Only the
output from the second call is shown.

IMO The logic in C4/Auth.pm  around line 590 is not correct. It should redirect
to installer for all numeric db revs and redirect only to the new update for
the non-numerical ones. 

Before moving further: Do we continue with the squashed patch or restore the
old ones? Note that you have to correct quite some things there. Probably
comparing the latest squased patch with squashing the original ones could help.

-- 
You are receiving this mail because:
You are watching all bug changes.