[Koha-bugs] [Bug 7167] updatedatabase improvements

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

--- Comment #111 from Chris Nighswonger <cnighswonger at foundations.edu> ---
(In reply to comment #106)
> (In reply to comment #104)
> > This sql "parsing" is in the routine C4::Update::Database::get_queries (~20
> > lines). It's not darkness :
> >     If the line begin with '--' it's a comment.
> >     If we want to change the delimiter, we change the input record
> > separator. Indeed, by default it's the semicolon character. We want to use
> > this sql statement to know when the query is terminated.
> >     Else it's a query
> 
> Perhaps we are not understanding what is meant by "parsing" in this context.
> Does parsing (as used here) simply mean differentiating between a SQL
> comment and a SQL query? If so, we may be ok.
> 

Based on a further look at the code, I withdraw my objections to "parsing" SQL
in this context. If I understand correctly, all we are doing here is some basic
sanity checks on the SQL to see of stuff exists or not as well as some basic
"sorting out" of comments and possibly changing the delimiter.

Someone feel free to correct me if I'm wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.