From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 01:15:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 May 2012 23:15:28 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to potential malicious code execution In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #1 from Chris Cormack --- Hi William On line 228 term is the name of the column. It is not the variable. The variable is in $sth->execute($query, $type, $serverlist, $requestid); The query is escaped by use of placeholders ie the (?,?,?,?) Which means $query is escaped and replaces the first ? in that list. So that part is not the problem, I suspect the actual problem is that the "" are not escaped when doing the actual search. Ill leave this open because it is a valid but, bug I don't think your solution will work (or addresses the problem :)) If you want to read up about placeholders please look here http://search.cpan.org/dist/DBI/DBI.pm#Placeholders_and_Bind_Values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 03:26:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 01:26:44 +0000 Subject: [Koha-bugs] [Bug 8087] Calendar not working in dropbox mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8087 --- Comment #2 from Elliott Davis --- Hey Albert, Sorry for the slow reply. I have been instructed to not upgrade to master so I am still running 3.8.0. I will se if I can spin up a dev instance later and verify the other issues were seeing are there in my case as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 03:30:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 01:30:46 +0000 Subject: [Koha-bugs] [Bug 8087] Calendar not working in dropbox mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8087 --- Comment #3 from Albert Oller --- Hi Elliott, no problem. I just wanted to find out if we were talking about the same thing. I looked at a couple of 3.6 and one 3.5 versions of Koha, and I saw the same behavior. Best regards, Albert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 04:11:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 02:11:59 +0000 Subject: [Koha-bugs] [Bug 8174] New: OpacNavBottom appears between OpacNav and Patron Links when patron is logged in and browses to /koha/opac-main.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8174 Priority: P5 - low Change sponsored?: --- Bug ID: 8174 Assignee: oleonard at myacpl.org Summary: OpacNavBottom appears between OpacNav and Patron Links when patron is logged in and browses to /koha/opac-main.pl Severity: minor Classification: Unclassified OS: All Reporter: it at sdwk.wa.gov.au Hardware: All Status: NEW Version: rel_3_6 Component: OPAC Product: Koha When a Patron logs in and clicks the back button on their browser or clicks on a "Home" link that links back to /koha/opac-main.pl, the OpacNavBottom content shows between OpacNav and the Patron Links. ie: OpacNav OpacNavBottom Patron Links instead of: OpacNav Patron links OpacNavBottom -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 05:16:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 03:16:29 +0000 Subject: [Koha-bugs] [Bug 8175] New: Missing defined check in catalogue/details.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 Priority: P5 - low Change sponsored?: --- Bug ID: 8175 Assignee: gmcharlt at gmail.com Summary: Missing defined check in catalogue/details.pl Severity: enhancement Classification: Unclassified OS: All Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: rel_3_6 Component: Cataloging Product: Koha SchemaSpy says items.materials can be null C4::Items seems to just pull the value from items.* Error log was generating: [Fri Jun 01 07:14:16 2012] [error] [client 192.168.100.2] [Fri Jun 1 07:14:16 2 012] detail.pl: Use of uninitialized value in string ne at /usr/share/koha/intra net/cgi-bin/catalogue/detail.pl line 255. I believe 255 should read: if (defined($item->{'materials'}) && $item->{'materials'} ne ''){ It currently reads: if ($item->{'materials'} ne ''){ I was looking at 3.6.3 source I didn't check my 3.8.1 version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 05:17:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 03:17:20 +0000 Subject: [Koha-bugs] [Bug 8175] Missing defined check in catalogue/details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 06:12:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 04:12:36 +0000 Subject: [Koha-bugs] [Bug 8176] New: $sqlwhere is undefined in C4::Serials in GetSubscriptions Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8176 Priority: P5 - low Change sponsored?: --- Bug ID: 8176 Assignee: colin.campbell at ptfs-europe.com Summary: $sqlwhere is undefined in C4::Serials in GetSubscriptions Severity: normal Classification: Unclassified OS: All Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: rel_3_6 Component: Serials Product: Koha This is similar to 7105, but 7105 forgot to add one more line. Add this --> $sqlwhere = ( $sqlwhere ? $sqlwhere : "" ); Before this --> $sql .= "$sqlwhere ORDER BY title"; Around line 606 in C4::Serials. I'm looking at 3.6.3 This is what triggered my search: [Fri Jun 01 07:06:39 2012] [error] [client 192.168.100.2] [Fri Jun 1 07:06:39 2 012] serials-home.pl: Use of uninitialized value $sqlwhere in concatenation (.) or string at /usr/share/koha/lib/C4/Serials.pm line 606. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 06:13:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 04:13:21 +0000 Subject: [Koha-bugs] [Bug 8176] $sqlwhere is undefined in C4::Serials in GetSubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8176 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 09:24:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 07:24:43 +0000 Subject: [Koha-bugs] [Bug 8176] $sqlwhere is undefined in C4::Serials in GetSubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8176 --- Comment #1 from Colin Campbell --- Created attachment 9867 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9867&action=edit Proposed patch Checking the variable with the ternary will generate a warning about comparison with an undefined var. (test needs to be defined $sqlwhere) The underlying problem is that we havent given an initial value to the var before either overwriting or concatening with it so this initializes it to an empty string, that done it should not log warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 09:28:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 07:28:11 +0000 Subject: [Koha-bugs] [Bug 8176] $sqlwhere is undefined in C4::Serials in GetSubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8176 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Version|rel_3_6 |unspecified --- Comment #2 from Colin Campbell --- Changed version to unspecified patch should apply to 3.6 and current development HEAD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 09:51:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 07:51:36 +0000 Subject: [Koha-bugs] [Bug 7422] Prevent creation of vendors with the same name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 --- Comment #14 from Adrien SAURAT --- Where should we go then? I created this patch because one of our librarians asked for this but maybe it's not really useful. Do we keep the idea? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 10:48:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 08:48:45 +0000 Subject: [Koha-bugs] [Bug 7992] new plugin about Automatic Number incrementing inventory. Prefix management from a authorised values list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7992 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9402|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 9868 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9868&action=edit Bug 7992: Specific plugin stocknumberam123 improvements Bugzilla description (from delaye): 1 / Create a list of authorised values(INVENTORY_NUMBER). In which the code is the prefix and the description the last number assigned. 2/A space between the prefix and number. 3 / From a holding record, after indicate the prefix when you click on the plugin -> koha search the last number from authorised values assigned in the list and increment n +1 level meter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 10:49:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 08:49:02 +0000 Subject: [Koha-bugs] [Bug 7992] new plugin about Automatic Number incrementing inventory. Prefix management from a authorised values list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7992 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 11:06:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 09:06:02 +0000 Subject: [Koha-bugs] [Bug 7351] ability to edit a range of holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #30 from Christophe Croullebois --- Hum, Paul, I have tested again, on a branch up to date, I have applyed my patch and the pages are ok... I join a snapshot Could anyone test ? Thx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 11:07:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 09:07:16 +0000 Subject: [Koha-bugs] [Bug 7351] ability to edit a range of holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #31 from Christophe Croullebois --- Created attachment 9869 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9869&action=edit the page is ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 11:12:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 09:12:02 +0000 Subject: [Koha-bugs] [Bug 6932] Javascript errors in irregular pattern check update In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6932 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|colin.campbell at ptfs-europe. |pelletiermaxime at gmail.com |com | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 11:12:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 09:12:14 +0000 Subject: [Koha-bugs] [Bug 7844] plack scripts for developers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7844 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #11 from Paul Poulain --- Dobrika, hello, I'm reviewing your patches related to plack, and find this one. In the attachment 9113, is written: +1. install plack and dependencies, using ./cpanm-install.pl but I can't find cpanm-install.pl anywhere. Is it a mistake ? I can see cpanm-install.pl in the attachment the attachment 8893, but it's an obsolete one. Any explanation welcomed ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 11:18:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 09:18:51 +0000 Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7471|0 |1 is obsolete| | --- Comment #17 from Adrien SAURAT --- Created attachment 9870 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9870&action=edit proposed patch #2 New patch. A simple one, easy to test and related to the original CIRCULATION problem. I'll create another Bug for the cataloguing problem. I think it would be good to apply this asap. The sooner the logs become clean, the better. Even if some archive is bad. Of course if someone has an idea to clean the history too, I'll do it, but as we're trying to find Itemnumbers when only a Biblionumber is stored, I don't know how to do that because. Two main problems for that: a/ A Biblio can often have several Items b/ Even if we correct only the Biblios having only one Item, it's not possible to know if it was the case when the circulation action was made (maybe some Items have disappeared since). So, what should we do? 1/ Simply use the patch to have good logs from now on. 2/ Add to the patch a script to correct history (how?) 3/ Still another solution : update the history by adding a message simply explaining that these logs are incorrects? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 11:19:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 09:19:00 +0000 Subject: [Koha-bugs] [Bug 7241] circulation action logs record biblionumber instead of item number In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7241 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 11:21:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 09:21:58 +0000 Subject: [Koha-bugs] [Bug 7599] Cart JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7599 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9710|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 9871 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9871&action=edit Bug 7599 - [SIGNED-OFF] Cart JavaScript contains untranslatable English strings To simplify the sentence structure for better translation flexibility the message now reads: "Item in your cart: " + number Fixed in both OPAC and staff client, although I'm not sure the message is actually triggered in the staff client. Signed-off-by: Jonathan Druart Strings become translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 11:22:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 09:22:12 +0000 Subject: [Koha-bugs] [Bug 7599] Cart JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7599 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 11:32:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 09:32:57 +0000 Subject: [Koha-bugs] [Bug 8176] $sqlwhere is undefined in C4::Serials in GetSubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8176 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9867|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 9872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9872&action=edit Bug 8176 [SIGNED-OFF] Assign an intial value to $sqlwhere warnings in log because of undefined value in string concatenation variable should be initialized to empty string rather than left undefined Signed-off-by: Jonathan Druart Removes a warning in logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 11:33:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 09:33:08 +0000 Subject: [Koha-bugs] [Bug 8176] $sqlwhere is undefined in C4::Serials in GetSubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8176 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 11:39:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 09:39:13 +0000 Subject: [Koha-bugs] [Bug 8129] quick slips issuing does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8129 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Blocks| |6430 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 11:39:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 09:39:13 +0000 Subject: [Koha-bugs] [Bug 6430] DB changes needed for Hourly Circulation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6430 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8129 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 11:45:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 09:45:21 +0000 Subject: [Koha-bugs] [Bug 7351] ability to edit a range of holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #32 from Christophe Croullebois --- I have seen with Paul, maybe due to his hook git... Tested with two others PC. thx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 11:46:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 09:46:29 +0000 Subject: [Koha-bugs] [Bug 7307] OPACBaseURL not used in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7307 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 11:53:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 09:53:43 +0000 Subject: [Koha-bugs] [Bug 7161] Open Library - Larger image, Read, borrow and checked-out status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9865|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 9873 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9873&action=edit Bug-7161 Open Library - Larger image, Read, borrow and checked-out status To test: 1. go into system administration and search for "cover" 2. change "OpenLibraryCovers" to "add" and all other to "don't show" 3. verify that opac search results have small covers, while detail page has big ones Signed-off-by: Dobrica Pavlinusic Addressing M. de Rooy's concerns * remove console.log * removed some comments that looked like debug code? * remove ebook display - I couldn't get it to work properly, and we want the bigger images. So it's gone. * remove get_cover Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 11:53:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 09:53:56 +0000 Subject: [Koha-bugs] [Bug 7161] Open Library - Larger image, Read, borrow and checked-out status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 12:37:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 10:37:18 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 Meenakshi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Assignee|ebin.joseph at osslabs.biz |meenakshi.r at osslabs.biz --- Comment #1 from Meenakshi --- Created attachment 9874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9874&action=edit Attached Patch. Attached Patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 12:54:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 10:54:55 +0000 Subject: [Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Koha Team Lyon 3 --- The patch doesn't apply anymore.... git bz apply 7304 Bug 7304 - Working on funds ergonomic display and funds management by multi librarians More permissions for budgets Apply? [yn] y Applying: Bug 7304: More permissions for budgets error: patch failed: installer/data/mysql/updatedatabase.pl:5284 error: installer/data/mysql/updatedatabase.pl: patch does not apply Patch failed at 0001 Bug 7304: More permissions for budgets When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/More-permissions-for-budgets-wqIY11.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 13:46:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 11:46:56 +0000 Subject: [Koha-bugs] [Bug 7844] plack scripts for developers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7844 --- Comment #12 from Dobrica Pavlinusic --- I removed cpanm-install.pl since installation of dependencies is something that should be done by Debian package. I don't think that installing packages using cpanm on production is something we should recommend. Installing dependencies is documented at wiki page http://wiki.koha-community.org/wiki/Plack but it does depend on platform availability of perl packages. Currently squeeze miss quite a few packages, while wheezy does include most packages needed for Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 13:47:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 11:47:05 +0000 Subject: [Koha-bugs] [Bug 8062] Cart email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9551|0 |1 is obsolete| | Attachment #9572|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart --- Created attachment 9875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9875&action=edit Bug 8062 [SIGNED-OFF] Cart email broken for non english templates Fix basket email sent from OPAC. The email body is now generated HTML (to be translatable), and converted into TEXT before beeing sent by email. To test that it works in other language than English, you have to update your language .po file: perl translate update de-DE Then, translated strings coming from opac-sendbasket.tt, and install the translation: perl translate install de-DE New dependency: Template::Plugin::HtmlToText Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 13:48:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 11:48:30 +0000 Subject: [Koha-bugs] [Bug 8062] Cart email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at biblibre.co | |m --- Comment #11 from Jonathan Druart --- It works fine :) Perharps a followup is required to specified the new dependency (in C4/Installer/PerlDependencies.pm ?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 14:24:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 12:24:58 +0000 Subject: [Koha-bugs] [Bug 8177] New: Correct a double declaration of variable in Addreturn subroutine Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8177 Priority: P3 Change sponsored?: --- Bug ID: 8177 CC: gmcharlt at gmail.com Assignee: koha at univ-lyon3.fr Summary: Correct a double declaration of variable in Addreturn subroutine Severity: normal Classification: Unclassified OS: All Reporter: koha at univ-lyon3.fr Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha Created attachment 9876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9876&action=edit Correct double declaration of variable $type in Addreturn variable "$type" was declared twice in Addreturn (Circulation.pm module, line 1631) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 14:25:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 12:25:20 +0000 Subject: [Koha-bugs] [Bug 8177] Correct a double declaration of variable in Addreturn subroutine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8177 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 14:34:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 12:34:23 +0000 Subject: [Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 --- Comment #8 from Koha Team Lyon 3 --- Patch doesn't apply... git bz apply 7304 Bug 7304 - Working on funds ergonomic display and funds management by multi librarians More permissions for budgets Apply? [yn] y Applying: Bug 7304: More permissions for budgets error: patch failed: installer/data/mysql/updatedatabase.pl:5284 error: installer/data/mysql/updatedatabase.pl: patch does not apply Patch failed at 0001 Bug 7304: More permissions for budgets When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/More-permissions-for-budgets-zwG92l.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 14:59:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 12:59:08 +0000 Subject: [Koha-bugs] [Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613 D Ruth Bavousett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED CC| |ruth at bywatersolutions.com Assignee|srdjan at catalyst.net.nz |ruth at bywatersolutions.com --- Comment #33 from D Ruth Bavousett --- Reopening--the OCLC Connexion client for Windows can't use this daemon--something is happening in there, and the socket payload is not getting to the import_bib phase, at all. I'm working on it now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 15:13:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 13:13:36 +0000 Subject: [Koha-bugs] [Bug 8178] New: circ/circulation.pl under plack duplicates checkout rows Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8178 Priority: P5 - low Change sponsored?: --- Bug ID: 8178 CC: gmcharlt at gmail.com Assignee: kyle.m.hall at gmail.com Summary: circ/circulation.pl under plack duplicates checkout rows Severity: enhancement Classification: Unclassified OS: All Reporter: dpavlin at rot13.org Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 15:14:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 13:14:31 +0000 Subject: [Koha-bugs] [Bug 8178] circ/circulation.pl under plack duplicates checkout rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8178 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Blocks| |7172 Assignee|kyle.m.hall at gmail.com |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 15:14:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 13:14:31 +0000 Subject: [Koha-bugs] [Bug 7172] Data Persistency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8178 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 15:23:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 13:23:54 +0000 Subject: [Koha-bugs] [Bug 8150] Patron circulation history has a fossil navagation bar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8150 --- Comment #7 from Colin Campbell --- Could be that one is being added due to something in .gitconfig or in a git hook but that the mailer is setting it too.... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 15:27:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 13:27:18 +0000 Subject: [Koha-bugs] [Bug 8178] circ/circulation.pl under plack duplicates checkout rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8178 --- Comment #1 from Dobrica Pavlinusic --- Created attachment 9877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9877&action=edit Bug 8178 - circ/circulation.pl under plack duplicates checkout rows Bug 7851 introduced our scoping for vairables, unfortunatly it has side-effect that checkout rows accumulate on page reloads instead of being initialized to empty array (which this patch fixes) Test scenario: 1. start intranet under plack 2. open /cgi-bin/koha/circ/circulation.pl and reload page few time confirming that rows gets duplicated 3. apply patch and reload page to verify that it works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 15:28:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 13:28:10 +0000 Subject: [Koha-bugs] [Bug 8178] circ/circulation.pl under plack duplicates checkout rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8178 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 15:34:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 13:34:50 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 --- Comment #2 from Owen Leonard --- Created attachment 9878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9878&action=edit Screenshot showing inaccurate availability information The availability information shown now in the cart is inaccurate. As this screenshot shows, for a title with 4 items, 1 checked out, the cart says "Available" once. For this information to be accurate there needs to be a way to connect the availability/status information directly to each copy listed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 15:34:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 13:34:59 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 15:40:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 13:40:21 +0000 Subject: [Koha-bugs] [Bug 7844] plack scripts for developers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7844 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9113|0 |1 is obsolete| | --- Comment #13 from Dobrica Pavlinusic --- Created attachment 9879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9879&action=edit Bug 7844 - plack intranet tooling for developers koha.psgi example and plackup.sh script to run any Koha site intranet or opac interface under plack with optional multi-process Starman server plackup.sh site-name [intranet] site-name is used to find config /etc/koha/sites/site-name/koha-conf.xml All configuration is specified in koha.psgi, which you are welcomed to edit and tune according to your development needs. When you are happy with it, rename it to site name and save it for safe-keeping. Test scenario: 1. install plack and dependencies, as documented at http://wiki.koha-community.org/wiki/Plack 2. start ./plackup.sh sitename 3. open intranet page http://localhost:5001/cgi-bin/koha/mainpage.pl and verify that it works 4. start ./plackup.sh sitename i[ntranet] 5. open OPAC http://localhost:5000/cgi-bin/koha/opac-main.pl and verify that it works 6. next step is to take a look into koha.psgi and enable additional debug modules, save file and reload page (plackup will reload code automatically) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 15:55:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 13:55:55 +0000 Subject: [Koha-bugs] [Bug 8179] New: Receiving items requires repetitive clicking. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Priority: P5 - low Change sponsored?: --- Bug ID: 8179 Assignee: henridamien at koha-fr.org Summary: Receiving items requires repetitive clicking. Severity: enhancement Classification: Unclassified OS: All Reporter: fred.pierre at smfpl.org Hardware: All Status: NEW Version: rel_3_6 Component: Acquisitions Product: Koha Our Acquisitions workflow is currently hindered by a repetitive process of receiving individual items. The parcel.pl and orderreceive.pl scripts in Koha 3.5 do not provide us with a way to checkbox individual items for receipt, or alternatively, "Receive All." We have to click receive on each item, then save the individual item and return to the receive screen. On orders where we have a hundred items, you can imagine this process of receiving is very tiresome, when a "Receive All" function could be implemented. Because several Acquisitions team members may be receiving items in the same basket, a checkbox on each line and a "Receive checked" would allow each worker to receive their specific items - giving the option to check all and receive, or just receive the items on your specific physical cart. This would be a benefit when large orders are being processed. By combining orderreceive.pl and finishreceive.pl we expect to be able to automate the process for batch receiving of items on an order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 16:12:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 14:12:13 +0000 Subject: [Koha-bugs] [Bug 7747] Replace YUI autocomplete with jQueryUI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9784|0 |1 is obsolete| | Attachment #9835|0 |1 is obsolete| | --- Comment #9 from Owen Leonard --- Created attachment 9880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9880&action=edit Bug 7747 [FOLLOW-UP] Replace YUI autocomplete with jQueryUI This patch removes the template calls to the now-obsolete YUI JS dependencies and removes the relevant YUI files themselves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 16:12:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 14:12:50 +0000 Subject: [Koha-bugs] [Bug 7747] Replace YUI autocomplete with jQueryUI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED Version|rel_3_10 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 16:13:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 14:13:04 +0000 Subject: [Koha-bugs] [Bug 7747] Replace YUI autocomplete with jQueryUI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 16:14:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 14:14:49 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving items requires repetitive clicking. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 --- Comment #1 from Fred P --- Created attachment 9881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9881&action=edit Our local Acquisitions Workflow What are alternative workflows? I understand we can also create items through cataloging or when receiving them, using the AcqCreateItems system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 16:15:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 14:15:05 +0000 Subject: [Koha-bugs] [Bug 8180] New: cataloguing/additem.pl plack scoping Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Priority: P5 - low Change sponsored?: --- Bug ID: 8180 Assignee: gmcharlt at gmail.com Summary: cataloguing/additem.pl plack scoping Severity: enhancement Classification: Unclassified OS: All Reporter: dpavlin at rot13.org Hardware: All Status: NEW Version: rel_3_8 Component: Cataloging Product: Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 16:17:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 14:17:19 +0000 Subject: [Koha-bugs] [Bug 7351] ability to edit a range of holidays In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351 --- Comment #33 from Christophe Croullebois --- Created attachment 9882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9882&action=edit this is an addon after M. de Rooy's patch As stated in patch comment, I have just put a space between the radio button and the text for the new lines.. And I have replaced tabulations by space. You must have applied before : "[SIGN OFF]Bug 7351 : feature that allows to delete a range of dates" "Patch for minor textual changes" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 16:26:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 14:26:11 +0000 Subject: [Koha-bugs] [Bug 8174] OpacNavBottom appears between OpacNav and Patron Links when patron is logged in and browses to /koha/opac-main.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8174 --- Comment #1 from Owen Leonard --- (In reply to comment #0) > When a Patron logs in and clicks the back button on their browser or clicks > on a "Home" link that links back to /koha/opac-main.pl, the OpacNavBottom > content shows between OpacNav and the Patron Links. I don't understand. If I log in and then go to the OPAC home page I won't see the patron links anymore. Patron links aren't shown on the home page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 16:32:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 14:32:22 +0000 Subject: [Koha-bugs] [Bug 3708] Add another customizable region to the OPAC: right sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3708 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9841|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 9883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9883&action=edit Bug 3708 - Add another customizable region to the OPAC: right sidebar This patch creates a new system preference, OpacRightSidebar, in which the librarian can add HTML which will appear on the OPAC main page under the login form. If the user is logged in the content will appear in place of the login form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 16:39:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 14:39:53 +0000 Subject: [Koha-bugs] [Bug 8175] Missing defined check in catalogue/details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |master --- Comment #1 from Owen Leonard --- Confirmed in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 16:40:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 14:40:09 +0000 Subject: [Koha-bugs] [Bug 8180] cataloguing/additem.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 --- Comment #1 from Dobrica Pavlinusic --- Created attachment 9884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9884&action=edit Bug 8180 - cataloguing/additem.pl plack scoping $dbh needs our scoping when using "Add item" to prevent error Can't call method "prepare" on an undefined value at /srv/koha/cataloguing/additem.pl line 88. Test scenario: 1. start intranet with plack 2. select one Edit items on one record 3. fill in new item and click on "Add item" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 16:41:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 14:41:12 +0000 Subject: [Koha-bugs] [Bug 8180] cataloguing/additem.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Blocks| |7172 Assignee|gmcharlt at gmail.com |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 16:41:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 14:41:12 +0000 Subject: [Koha-bugs] [Bug 7172] Data Persistency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7172 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8180 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 17:26:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 15:26:15 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to potential malicious code execution In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 --- Comment #2 from William Hurley --- You may be correct that I have not identified the source of the bug. You are incorrect when you say that the problem is that the quotation marks are not escaped during the actual search. The problem is that the quotation marks are not escaped when one chooses edit-> replace record via z39.50. If the title contains double quotes, everything from the first set of quotes back disappears, and is not transferred into the search window. The quoted text never makes it into the actual search. It is easy to replicate this bug. Pick any title in your collection and edit marc field $245a by appending "test quotes" at the end of the title. Then click on z39.50 search. The words "test quote" do not appear in the pop-up search window. Therefore, whatever module controls this behavior is not properly escaping the quotes. If you would kindly identify this module I would be greatly appreciative. Thanks for your quick response and all your help in this matter. (In reply to comment #1) > Hi William > > On line 228 term is the name of the column. It is not the variable. > > The variable is in > $sth->execute($query, $type, $serverlist, $requestid); > > The query is escaped by use of placeholders ie the (?,?,?,?) > > Which means $query is escaped and replaces the first ? in that list. > > So that part is not the problem, I suspect the actual problem is that the "" > are not escaped when doing the actual search. > > Ill leave this open because it is a valid but, bug I don't think your > solution will work (or addresses the problem :)) > > If you want to read up about placeholders please look here > http://search.cpan.org/dist/DBI/DBI.pm#Placeholders_and_Bind_Values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 17:44:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 15:44:25 +0000 Subject: [Koha-bugs] [Bug 8062] Cart email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 --- Comment #12 from Fr?d?ric Demians --- > Perharps a followup is required to specified the new dependency (in > C4/Installer/PerlDependencies.pm ?) The template contains a 'USE HtmlToText' directive, which use a Template::Toolkit module. It's not a Perl module, and it's included by default with Template::Toolkit. Is it the dependency we were thinking about? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 17:45:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 15:45:37 +0000 Subject: [Koha-bugs] [Bug 8178] circ/circulation.pl under plack duplicates checkout rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8178 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9877|0 |1 is obsolete| | --- Comment #2 from Dobrica Pavlinusic --- Created attachment 9885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9885&action=edit Bug 8178 - circ/circulation.pl under plack duplicates checkout rows Bug 7851 introduced our scoping for vairables, unfortunatly it has side-effect that checkout rows accumulate on page reloads instead of being initialized to empty array (which this patch fixes) This also fixes %renew_failed initialization on each request. Test scenario: 1. start intranet under plack 2. open /cgi-bin/koha/circ/circulation.pl and reload page few time confirming that rows gets duplicated 3. apply patch and reload page to verify that it works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 18:22:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 16:22:19 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 --- Comment #1 from Owen Leonard --- Created attachment 9886 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9886&action=edit Bug 8143 - Upgrade jQuery tabs to current jQueryUI version Current jQuery-driven tabs are done using a very old version of the tabs plugin. This patch upgrades jQueryUI to the latest version and adds the tabs widget dependency to the jqueryui js file and updates the syntax for existing tabs: - $("#foo > ul").tabs(); changes to $("#foo").tabs(); - Remove full URL from tab links (use #anchor only). Pages with "static" tabs (tabs which are built in the markup rather than generated by the plugin) have been modified to use their own style. Examples: pay.tt in the staff client and opac-readingrecord.tt in the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 18:22:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 16:22:40 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 18:36:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 16:36:48 +0000 Subject: [Koha-bugs] [Bug 8181] New: Replace DynArch calendar widget with jQueryUI version Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Priority: P5 - low Change sponsored?: --- Bug ID: 8181 Assignee: oleonard at myacpl.org Blocks: 5481 Summary: Replace DynArch calendar widget with jQueryUI version Severity: enhancement Classification: Unclassified OS: All Reporter: oleonard at myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Templates Depends on: 8143 Product: Koha Currently Koha uses a JavaScript calendar plugin from http://www.dynarch.com/projects/calendar/old/. This older version of the plugin is open source but is now unmaintained. The newer version is not open source. This plugin can be replaced by the jQueryUI datepicker widget: http://jqueryui.com/demos/datepicker/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 18:36:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 16:36:48 +0000 Subject: [Koha-bugs] [Bug 5481] Replace YUI JS libraries with Jquery UI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5481 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8181 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 18:36:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 16:36:48 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8181 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 19:21:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 17:21:46 +0000 Subject: [Koha-bugs] [Bug 7847] OPAC search dies with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7847 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9806|0 |1 is obsolete| | --- Comment #19 from Paul Poulain --- Created attachment 9887 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9887&action=edit Bug 7847: OPAC search dies with Plack Due to a dependency cycle between C4::Search and C4::Items, searches in the OPAC die spectacularly under Plack. This counter-patch extends dpavlin's solution and replaces use with require for C4::Search in C4::Items and for C4::Items in C4::Search. Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 19:22:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 17:22:16 +0000 Subject: [Koha-bugs] [Bug 7847] OPAC search dies with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7847 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #20 from Paul Poulain --- Testing : * BEFORE the patch - opac & staff without Plack = work fine - opac with Plack = Undefined subroutine &C4::Search::GetHiddenItemnumbers called at /home/paul/koha.dev/koha-community/C4/Search.pm line 1634. at /home/paul/koha.dev/koha-community/opac/opac-search.pl line 806 - staff with Plack = work fine * AFTER the patch - both opac & staff work fine with or without Plack signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 19:35:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 17:35:40 +0000 Subject: [Koha-bugs] [Bug 7857] database upgrade fails with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7857 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8729|0 |1 is obsolete| | --- Comment #8 from Paul Poulain --- Created attachment 9888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9888&action=edit Bug 7857 - database upgrade fails with plack Updating database structure Update errors : Can't locate C4/Context.pm in @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.10.1 /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl /usr/local/lib/perl/5.10.0 /usr/local/share/perl/5.10.0 .) at /srv/koha/installer/data/mysql/updatedatabase.pl line 37. BEGIN failed--compilation aborted at /srv/koha/installer/data/mysql/updatedatabase.pl line 37. It seems that plack cleans enviroment, so we have to re-instart PERL5LIB so script invocation won't fail. It also fixes exit 1 which fail with plack. Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 19:37:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 17:37:16 +0000 Subject: [Koha-bugs] [Bug 7857] database upgrade fails with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7857 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #9 from Paul Poulain --- Patch Bug 7857 - database upgrade fails with plack signed off, please QA. The patch "Bug 7857 - invalidate cached preferences after SetVersion" should be put "in discussion". Plus there is a CHI cache management that should hit Koha very soon, that could make the discussion obsolete -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 19:42:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 17:42:55 +0000 Subject: [Koha-bugs] [Bug 3708] Add another customizable region to the OPAC: right sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3708 --- Comment #4 from Martin Renvoize --- Tested again using the biblibre sandboxs.. All seems to work as expected now giving out good clean markup. Will try and grab a copy locally to sign-ff on properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 19:45:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 17:45:52 +0000 Subject: [Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #2 from Paul Poulain --- QA comment: * there is an unconditional warn added: + warn "## Name [$opts{Name}] $fh"; please remove it of write $ENV{DEBUG} and warn "## Name [$opts{Name}] $fh"; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 20:28:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 18:28:16 +0000 Subject: [Koha-bugs] [Bug 8182] New: Problem with overdue fine calculations after upgrade Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182 Priority: P5 - low Change sponsored?: --- Bug ID: 8182 Assignee: gmcharlt at gmail.com Summary: Problem with overdue fine calculations after upgrade Severity: enhancement Classification: Unclassified OS: All Reporter: kyle.m.hall at gmail.com Hardware: All Status: NEW Version: master Component: Database Product: Koha Items that were overdue and still out as of 5/26 (date of Upgrade) were charged overdue fines as of 5/26. When the items DO come back, the overdue fines are calculated again from the due date to the date of checkin. Therefore the patron is being charged double overdue fines from the original date up to 5/26. This is caused by issues.date_due being changed to a datetime, with the hour/minute/secons time portion defaulting to 00:00:00. It should be 23::50::00 instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 20:30:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 18:30:07 +0000 Subject: [Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182 --- Comment #1 from Kyle M Hall --- Created attachment 9889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9889&action=edit Bug 8182 - Problem with overdue fine calculations after upgrade Items that were overdue and still out as of 5/26 (date of Upgrade) were charged overdue fines as of 5/26. When the items DO come back, the overdue fines are calculated again from the due date to the date of checkin. Therefore the patron is being charged double overdue fines from the original date up to 5/26. This is caused by issues.date_due being changed to a datetime, with the hour/minute/secons time portion defaulting to 00:00:00. It should be 23::50::00 instead. This is an unusual patch as it modifies a previous database update. This make sense because if a install has already been updated past the db rev update, this fix will be too late. It will only help those that have not updated past that db revision. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 20:30:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 18:30:20 +0000 Subject: [Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 20:32:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 18:32:21 +0000 Subject: [Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9889|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 9890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9890&action=edit Bug 8182 - Problem with overdue fine calculations after upgrade Items that were overdue and still out as of 5/26 (date of Upgrade) were charged overdue fines as of 5/26. When the items DO come back, the overdue fines are calculated again from the due date to the date of checkin. Therefore the patron is being charged double overdue fines from the original date up to 5/26. This is caused by issues.date_due being changed to a datetime, with the hour/minute/secons time portion defaulting to 00:00:00. It should be 23::50::00 instead. This is an unusual patch as it modifies a previous database update. This make sense because if a install has already been updated past the db rev update, this fix will be too late. It will only help those that have not updated past that db revision. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 20:36:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 18:36:25 +0000 Subject: [Koha-bugs] [Bug 8183] New: acqui/parcels.pl plack scoping Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183 Priority: P5 - low Change sponsored?: --- Bug ID: 8183 Assignee: henridamien at koha-fr.org Summary: acqui/parcels.pl plack scoping Severity: enhancement Classification: Unclassified OS: All Reporter: dpavlin at rot13.org Hardware: All Status: NEW Version: rel_3_8 Component: Acquisitions Product: Koha Can't call method "param" on an undefined value at /srv/koha_ffzg/acqui/parcels.pl line 177. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 20:59:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 18:59:36 +0000 Subject: [Koha-bugs] [Bug 8184] New: Duplicate budget page lacks heading and breadcrumbs Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8184 Priority: P5 - low Change sponsored?: --- Bug ID: 8184 Assignee: oleonard at myacpl.org Summary: Duplicate budget page lacks heading and breadcrumbs Severity: normal Classification: Unclassified OS: All Reporter: oleonard at myacpl.org Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha When you use the menu option to duplicate a budget the resulting page doesn't have a heading or a breadcrumb. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 21:04:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 19:04:19 +0000 Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 --- Comment #5 from Kyle M Hall --- Created attachment 9891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9891&action=edit Bug 8043 - today's checkouts are in Previous checkouts in circulation.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 21:05:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 19:05:05 +0000 Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 21:11:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 19:11:56 +0000 Subject: [Koha-bugs] [Bug 8183] acqui/parcels.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183 --- Comment #1 from Dobrica Pavlinusic --- Created attachment 9892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9892&action=edit Bug 8183 - acqui/parcels.pl plack scoping Scope our $template for plack to prevent following error: Can't call method "param" on an undefined value at /srv/koha_ffzg/acqui/parcels.pl line 177. Test scenario: 1. Home > Acquisitions > Search for vendor 2. click on "Receive shipment" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 21:24:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 19:24:49 +0000 Subject: [Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9161|0 |1 is obsolete| | --- Comment #3 from Dobrica Pavlinusic --- Created attachment 9893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9893&action=edit Bug 7952 - PDF::Reuse under plack writes to console STDOUT instead to browser Without name option to prFile, PDF::Reuse opens '-' file which is real console STDOUT on plack so pdf file gets emited to terminal instead of sending it to browser. This change creates temporary file using File::Temp, pass it to PDF::Reuse and then reads it back and prints it out for plack (or CGI) to pick up. DEBUG=1 it will debugging output Test secenario: 1. Home ? Tools ? Patron Card Creator ? Manage Card Batches 2. select batch checkbox and click Export 3. select template and click Export 4. click on pdf file to download it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 21:25:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 19:25:44 +0000 Subject: [Koha-bugs] [Bug 8183] acqui/parcels.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|henridamien at koha-fr.org |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 21:26:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 19:26:37 +0000 Subject: [Koha-bugs] [Bug 8165] due date of 00:00 instead of 23:59 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8165 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Melia Meggs --- *** This bug has been marked as a duplicate of bug 8182 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 21:26:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 19:26:38 +0000 Subject: [Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia at bywatersolutions.com --- Comment #3 from Melia Meggs --- *** Bug 8165 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 21:30:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 19:30:23 +0000 Subject: [Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high CC| |chris at bigballofwax.co.nz Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 21:32:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 19:32:41 +0000 Subject: [Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182 --- Comment #4 from Chris Cormack --- Are we sure we can't fix those who have upgraded already too? With an update statement? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 21:37:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 19:37:33 +0000 Subject: [Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182 --- Comment #5 from Chris Cormack --- Created attachment 9894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9894&action=edit Bug 8182 - Problem with overdue fine calculations after upgrade Items that were overdue and still out as of 5/26 (date of Upgrade) were charged overdue fines as of 5/26. When the items DO come back, the overdue fines are calculated again from the due date to the date of checkin. Therefore the patron is being charged double overdue fines from the original date up to 5/26. This is caused by issues.date_due being changed to a datetime, with the hour/minute/secons time portion defaulting to 00:00:00. It should be 23::50::00 instead. This is an unusual patch as it modifies a previous database update. This make sense because if a install has already been updated past the db rev update, this fix will be too late. It will only help those that have not updated past that db revision. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 21:38:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 19:38:05 +0000 Subject: [Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9890|0 |1 is obsolete| | Attachment #9894|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 9895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9895&action=edit Bug 8182 - Problem with overdue fine calculations after upgrade Items that were overdue and still out as of 5/26 (date of Upgrade) were charged overdue fines as of 5/26. When the items DO come back, the overdue fines are calculated again from the due date to the date of checkin. Therefore the patron is being charged double overdue fines from the original date up to 5/26. This is caused by issues.date_due being changed to a datetime, with the hour/minute/secons time portion defaulting to 00:00:00. It should be 23::50::00 instead. This is an unusual patch as it modifies a previous database update. This make sense because if a install has already been updated past the db rev update, this fix will be too late. It will only help those that have not updated past that db revision. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 21:39:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 19:39:22 +0000 Subject: [Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Chris Cormack --- Signed off the fix, it will fix anyone upgrading from 3.6/3.4 .. but I think we still need a follow up to catch the ones who already have. Or at least a nice easy recipe for them to follow to clean up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 21:40:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 19:40:11 +0000 Subject: [Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182 --- Comment #8 from Chris Cormack --- NOTE: This is only a problem on upgrades, fresh installs are ok I'd definitely like it in before the 3.8.2 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 22:05:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 20:05:45 +0000 Subject: [Koha-bugs] [Bug 8140] Error when exporting label xml In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8140 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 22:06:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 20:06:13 +0000 Subject: [Koha-bugs] [Bug 8177] Correct a double declaration of variable in Addreturn subroutine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8177 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris at bigballofwax.co.nz --- Comment #1 from Chris Cormack --- Applying: Correct double declaration of variable in Addreturn fatal: sha1 information is lacking or useless (C4/Circulation.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Correct double declaration of variable in Addreturn When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 22:09:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 20:09:57 +0000 Subject: [Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 --- Comment #9 from Chris Cormack --- Created attachment 9896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9896&action=edit Bug 7304: More permissions for budgets - Possibility to add users to a budget - Restrictions changed to: - None - Owner - Owner and users - Owner, users and library - Restricted users cannot spent on these budgets (they cannot modify them either) Modified pages: - admin/aqbudgets.pl - admin/aqplan.pl - suggestion/suggestion.pl - acqui/acqui-home.pl - acqui/addorderiso2709.pl - acqui/basket.pl - acqui/neworderempty.pl Unit tests in t/Budgets/CanUserUseBudget.t and t/Budgets/CanUserModifyBudget.t Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 22:10:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 20:10:41 +0000 Subject: [Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9837|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 22:11:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 20:11:27 +0000 Subject: [Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off CC| |chris at bigballofwax.co.nz Version|rel_3_8 |master --- Comment #10 from Chris Cormack --- Fixed merge conflict on updatedatabase.pl. Works welll, and yay for more unit tests! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 22:19:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 20:19:06 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Improper escaping of quotes |Improper escaping of quotes |during z39.50 queries leads |during z39.50 queries leads |to potential malicious code |to broken html |execution | --- Comment #3 from Chris Cormack --- (In reply to comment #2) > You may be correct that I have not identified the source of the bug. You > are incorrect when you say that the problem is that the quotation marks are > not escaped during the actual search. The problem is that the quotation > marks are not escaped when one chooses edit-> replace record via z39.50. If > the title contains double quotes, everything from the first set of quotes > back disappears, and is not transferred into the search window. The quoted > text never makes it into the actual search. I was just guessing where the problem was, since I haven't tried to replicate. But I can guarantee that changing the column name in the sql, will have utterly no effect on value that is stored in that column. > > It is easy to replicate this bug. Pick any title in your collection and > edit marc field $245a by appending "test quotes" at the end of the title. > Then click on z39.50 search. The words "test quote" do not appear in the > pop-up search window. Therefore, whatever module controls this behavior is > not properly escaping the quotes. If you would kindly identify this module > I would be greatly appreciative. Thanks for your quick response and all > your help in this matter. > I would look into the perl code that is outputting it and/or the template. It is not being stored in the database incorrectly, the placeholders are escaping all bad characters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 22:26:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 20:26:39 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 --- Comment #4 from Chris Cormack --- Check line 95 in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/
    2. My theory is if [% title %] starts with a " then you get value="" and there is the problem. So you could try adding [% title |html %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 22:35:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 20:35:28 +0000 Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Hmm I think the plan is to slowly kill C4::Dates, because it doesnt understand times at all. I am not sure on that, so will check but I think that was the plan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 22:35:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 20:35:57 +0000 Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9455|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 22:36:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 20:36:16 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 --- Comment #5 from William Hurley --- Ok cool. I will try this patch on a fresh install of the latest stable branch on my development box and see if the problem resolves it's self. Should be able to let you know by early next week, as I almost certainly won't finish that before the end of the work day here in NYC. (In reply to comment #4) > Check line 95 in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/ > >
    1. name="title" value="[% title %]" />
      2. > > My theory is if [% title %] starts with a " then you get value="" and there > is the problem. > > So you could try adding [% title |html %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 1 22:46:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 20:46:36 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 --- Comment #6 from Chris Cormack --- (In reply to comment #5) > Ok cool. I will try this patch on a fresh install of the latest stable > branch on my development box and see if the problem resolves it's self. > Should be able to let you know by early next week, as I almost certainly > won't finish that before the end of the work day here in NYC. That's ok, its already 8.30am on Saturday here anyway, if it does work you could make an actual patch and attach it to here, and set the bug to needs signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 2 00:30:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 22:30:48 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #172 from Chris Cormack --- Created attachment 9897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9897&action=edit Bug 5327 : Fix for XISBN test, thingisbn is now handing back different results -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 2 00:31:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 22:31:44 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 2 00:57:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 22:57:46 +0000 Subject: [Koha-bugs] [Bug 8061] Koha's templates do not cope well with right-to-left languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8061 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Hi Ruth Unfortunately the first patch no longer applies Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-review.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-addbybiblionumber.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-addbybiblionumber.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc Auto-merging koha-tmpl/opac-tmpl/prog/en/css/opac.css Failed to merge in the changes. Patch failed at 0001 Bug 8061: RTL CSS overrides (OPAC) The second one conflicts too Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/member-flags.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 2 00:59:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 22:59:58 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 2 01:07:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 23:07:26 +0000 Subject: [Koha-bugs] [Bug 8160] Link to cataloging appears for users without cataloging permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8160 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9842|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 9898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9898&action=edit Bug 8160 - Link to cataloging appears for users without cataloging permission This patch wraps cataloging links on the staff client home page and in the header menu with checks for edit_catalogue OR edit_items permission. To test, access the staff client as a user with various permissions. The "cataloging" link on the main page and in the header menu should only appear to a user with edit_catalogue permission, edit_items permission, or both. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 2 01:08:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 23:08:03 +0000 Subject: [Koha-bugs] [Bug 8160] Link to cataloging appears for users without cataloging permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8160 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 2 01:09:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 23:09:46 +0000 Subject: [Koha-bugs] [Bug 8111] Language chooser display problem in self-checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8111 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9622|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 9899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9899&action=edit Bug 8111 - Language chooser display problem in self-checkout - Adds required JavaScript and JavaScript linked files - Updates CSS with changes relevant to this feature which had been made to the main CSS file. - Removes an image file which has been made obsolete now that sco.css uses the main image sprite like opac.css does. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 2 01:10:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Jun 2012 23:10:16 +0000 Subject: [Koha-bugs] [Bug 8111] Language chooser display problem in self-checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8111 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 2 09:40:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jun 2012 07:40:02 +0000 Subject: [Koha-bugs] [Bug 7951] Suspending holds needs a system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7951 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9563|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 9900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9900&action=edit Bug 7951 - Suspending holds needs a system preference Adds system preferences SuspendHoldsIntranet and SuspendHoldsOpac. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 2 09:40:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jun 2012 07:40:35 +0000 Subject: [Koha-bugs] [Bug 7951] Suspending holds needs a system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7951 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 2 09:51:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jun 2012 07:51:19 +0000 Subject: [Koha-bugs] [Bug 3638] Status of hold not changed when item checked in via SIP2 Interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3638 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5423|0 |1 is obsolete| | --- Comment #14 from Chris Cormack --- Created attachment 9901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9901&action=edit Bug 3638 Self Check Should Capture Hold Items Shelf Check was receiving messages saying item was wanted for a hold but the item was discharged to the shelf not associated with the hold or transited to the pickup location. The message was also being sent on discharge of items when a suitable item had already been captured. Checkin now associates the item with the hold and sets the appropriate data for a correct checkin response Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 2 09:51:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jun 2012 07:51:46 +0000 Subject: [Koha-bugs] [Bug 3638] Status of hold not changed when item checked in via SIP2 Interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3638 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5424|0 |1 is obsolete| | --- Comment #15 from Chris Cormack --- Created attachment 9902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9902&action=edit Bug 3638 : Captured Holds may need to generate a transfer If a discharged item is captured for a hold at another branch the selfcheck should generate a branchtransfer for it. This was complicated as the checkin routine was setting its own location from a field not set in many scm machines (e.g. 3M) also in ILS::Transaction the test for location was incorrect assuming that an empty string or undefined was a valid location Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 2 09:52:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jun 2012 07:52:25 +0000 Subject: [Koha-bugs] [Bug 3638] Status of hold not changed when item checked in via SIP2 Interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3638 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #16 from Chris Cormack --- Thanks for the test script example Colin, was very handy for testing. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 2 19:20:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jun 2012 17:20:25 +0000 Subject: [Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #15 from Jared Camins-Esakov --- > However, I won't push this patch yet, because I think Koha::Utils is a too > generic term, that will quickly result in a place where there is everything > and anything. > I'll propose quickly a naming convention and organisation (and a follow-up > patch). Do you have a proposal for the naming convention? I have further work which is dependent on untying this stuff from C4, and moving SearchAuthorities into Koha::Search. > Let me a few days. > > Other than this, I like this patch (and I think we could get rid of NoZebra > completely, as it does not work at all for now) I think there's another bug for removing NoZebra somewhere in Bugzilla. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 2 19:28:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jun 2012 17:28:40 +0000 Subject: [Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #16 from Jared Camins-Esakov --- Created attachment 9903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9903&action=edit Bug 7430 - ModZebra should not be in C4::Biblio This proof-of-concept commit does the following: * Moves all the functionality from C4::Biblio::ModZebra into a new Koha::Search::Engine namespace, breaking it up into a Zebra class for the relevant section. * Rather than calling ModZebra, callers should now use Koha::Search and call AddToIndexQueue() with the same arguments. * Creates a new Koha::Utils class with GetMarcFromKohaField and GetAuthType methods, in an attempt to begin the process of reducing circular dependencies * Adds a syspref SearchEngine to specify which search engine should be used. At present the only option is Zebra. IMPORTANT NOTE: The syspref is added by the atomicupdate in installer/data/mysql/atomicupdate/bug_7430_add_searchengine_syspref IMPORTANT NOTE: NoZebra was deprecated for 3.4.0, and this commit entirely removes portions of the NoZebra code. Signed-off-by: Jared Camins-Esakov Signing off that the behavior is the same as in my original patch, except for a fix to the return type of Koha::Search::Engine::get_indexes and Koha::Search::GetIndexes. Another sign off is required. Signed-off-by: Henri-Damien LAURENT Signed-off-by: Mason James Signed-off-by: Jared Camins-Esakov Rebased 2 June 2012. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 2 19:28:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jun 2012 17:28:59 +0000 Subject: [Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9240|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 2 19:30:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Jun 2012 17:30:35 +0000 Subject: [Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430 --- Comment #17 from Jared Camins-Esakov --- I rebased the patch on latest master, and corrected an encoding issue that broke the patch subject. There are no changes in the latest version of the patch, so the status should remain at Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 3 19:20:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jun 2012 17:20:48 +0000 Subject: [Koha-bugs] [Bug 8185] New: Plugin for linking records in MARC21 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Priority: P5 - low Change sponsored?: --- Bug ID: 8185 Assignee: gmcharlt at gmail.com Summary: Plugin for linking records in MARC21 Severity: enhancement Classification: Unclassified OS: All Reporter: tajoli at cilea.it Hardware: All Status: NEW Version: rel_3_8 Component: Cataloging Product: Koha In cataloguing/value_builder there is a plugin for linking records. But is only for unimarc (unimarc_field_4XX.pl). We need a plugin also for MARC21 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 3 19:21:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jun 2012 17:21:40 +0000 Subject: [Koha-bugs] [Bug 8185] Plugin for linking records in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |tajoli at cilea.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 3 19:52:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jun 2012 17:52:20 +0000 Subject: [Koha-bugs] [Bug 8185] Plugin for linking records in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 --- Comment #1 from Zeno Tajoli --- Created attachment 9904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9904&action=edit code of the plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 3 19:54:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Jun 2012 17:54:53 +0000 Subject: [Koha-bugs] [Bug 8185] Plugin for linking records in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Zeno Tajoli --- This is the plugin for linking records in Marc21. It works like the unimarc plugin unimarc_field_4XX. It insert: $9 -> biblionumber $w -> 001 $t -> 245$a (title ) $x -> 022$a (ISSN) $z -> 020$a (ISBN) The search is done on 'any' index. Data are inserted only in the working record. To insert data in the connected record, you need to open the other record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 06:07:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 04:07:11 +0000 Subject: [Koha-bugs] [Bug 7910] Batch renewal of serials and order creation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 --- Comment #1 from Amit Gupta --- Created attachment 9905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9905&action=edit Batch renewal of serials Batch renewal of serials To Test: 1) Go to Serials click on Check expiration link. 2) Search some subscription which have to expire it will give some result. 3) Select atleast one subscription which you want to renew. 4) Check the expiration date after renew. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 06:07:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 04:07:27 +0000 Subject: [Koha-bugs] [Bug 7910] Batch renewal of serials and order creation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7910 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 08:26:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 06:26:33 +0000 Subject: [Koha-bugs] [Bug 6846] Dont allow staff to change own permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6846 --- Comment #2 from Meenakshi --- Created attachment 9906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9906&action=edit Sending Improved Patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 08:26:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 06:26:53 +0000 Subject: [Koha-bugs] [Bug 6846] Dont allow staff to change own permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6846 Meenakshi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 08:27:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 06:27:31 +0000 Subject: [Koha-bugs] [Bug 6846] Dont allow staff to change own permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6846 Meenakshi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 08:28:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 06:28:44 +0000 Subject: [Koha-bugs] [Bug 6846] Dont allow staff to change own permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6846 --- Comment #3 from Meenakshi --- The Patch which I send was wrong Patch. Working on This Patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 08:29:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 06:29:57 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 --- Comment #3 from Meenakshi --- Created attachment 9907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9907&action=edit Sending Improved Patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 08:30:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 06:30:35 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 Meenakshi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 08:30:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 06:30:56 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 Meenakshi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 09:57:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 07:57:17 +0000 Subject: [Koha-bugs] [Bug 8062] Cart email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 --- Comment #13 from Jonathan Druart --- To test your patch, I had to install the Template::Plugin::HtmlToText module via cpan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 10:09:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 08:09:48 +0000 Subject: [Koha-bugs] [Bug 8062] Cart email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 --- Comment #14 from Fr?d?ric Demians --- Created attachment 9908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9908&action=edit Add Perl module dependency My fault... You're correct, this a new required Perl module. Here it is. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 11:04:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 09:04:57 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Julian Maurice --- You still needs the order_manage permission to access pages. order_manage_all is just an additional permission to grant more rights. So you have to check both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 11:08:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 09:08:54 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8962|0 |1 is obsolete| | --- Comment #6 from Julian Maurice --- Created attachment 9909 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9909&action=edit Order line transfers Rebased on current master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 11:09:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 09:09:01 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 14:18:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 12:18:22 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 --- Comment #15 from Julian Maurice --- No answers on the mailing list. I worked on this for better integration into current translation workflow. Patches follow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 14:19:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 12:19:23 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9449|0 |1 is obsolete| | --- Comment #16 from Julian Maurice --- Created attachment 9910 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9910&action=edit First draft for Koha localization using Locale::Maketext You have to use the new module Koha::I18N Code example: use Koha::I18N; use CGI; my $input = new CGI; my $lh = Koha::I18N->get_handle_from_context($input, 'intranet'); print $lh->maketext("Localized string!"); PO files are in misc/translator/po/LANG-messages.po. Creation of PO files are integrated to existing workflow, so to create PO file for a language, just run in misc/translator: ./translate create LANG To update: ./translate update LANG You can then translate the PO with your favorite editor. Strings will be localized at runtime. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 14:20:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 12:20:35 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9416|0 |1 is obsolete| | --- Comment #17 from Julian Maurice --- Created attachment 9911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9911&action=edit Translate basket CSV column names using Koha::I18N This is a test case for new module Koha::I18N. It translate CSV columns headers when you export a basket as CSV. To test: - go to a basket page in staff interface with english interface - click on "Export this basket as CSV" and check that column titles are there and in english - change language and click on the same button. - column titles are still in english - now open a terminal, go to misc/translator and run: ./translate create LANG (e.g. fr-FR) - translate the po misc/translator/po/LANG-messages.po with your favorite po editor. - go back to the navigator and click again on the Export button - column names must be translated, according to the PO file. -- Same patch, but the commit message differ. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 14:23:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 12:23:56 +0000 Subject: [Koha-bugs] [Bug 8044] Localization for Perl scripts and modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8044 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #18 from Julian Maurice --- The new thing is that locale/ directory and locale/update_po.pl have disappeared. All is now done by misc/translator/translate script. So you just have to do ./translate create LANG the first time, and then ./translate update LANG every time you want the po to be updated. PO files are in misc/translator/po/LANG-messages.po -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 15:20:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 13:20:38 +0000 Subject: [Koha-bugs] [Bug 8063] Hold print notices do not sort by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9696|0 |1 is obsolete| | --- Comment #7 from Julian Maurice --- Created attachment 9912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9912&action=edit [SIGNED-OFF] Bug 8063 - Hold print notices do not sort by branch Still works ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 15:22:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 13:22:53 +0000 Subject: [Koha-bugs] [Bug 8063] Hold print notices do not sort by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9697|0 |1 is obsolete| | --- Comment #8 from Julian Maurice --- Created attachment 9913 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9913&action=edit [SIGNED-OFF] Bug 8063 - Followup - Make C4/Letters.pm conform to PBP I don't understand why making things explicit is a high severity violation of best practices... but the patch is ok and perlcritic doesn't complain anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 15:23:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 13:23:05 +0000 Subject: [Koha-bugs] [Bug 8063] Hold print notices do not sort by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 16:08:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 14:08:23 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 --- Comment #52 from Julian Maurice --- Elliott, next time you'll submit changes like this, could you just submit a follow-up patch instead of the whole patch + your changes? It's easier to see what you changed, and then easier to test. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 16:20:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 14:20:10 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 --- Comment #53 from Elliott Davis --- Yeah I can Julian. Sorry about messing that up. (In reply to comment #52) > Elliott, next time you'll submit changes like this, could you just submit a > follow-up patch instead of the whole patch + your changes? It's easier to > see what you changed, and then easier to test. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 17:23:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 15:23:16 +0000 Subject: [Koha-bugs] [Bug 8129] quick slips issuing does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8129 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #4 from Ian Walls --- Handles the date formatting with substrings... not the most general approach, but it works. Less load on the system than using DateTime to cast as a date. Updates variable name from "$today" to "$now", which is more general in our new hourly loan context. I'm in favour. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 17:25:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 15:25:23 +0000 Subject: [Koha-bugs] [Bug 8176] $sqlwhere is undefined in C4::Serials in GetSubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8176 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #4 from Ian Walls --- Just gives $sqlwhere a default defined value of empty string. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 17:30:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 15:30:47 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9874|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Comment on attachment 9874 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9874 Attached Patch. Don't forget to mark old patches obsolete when you submit revised versions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 17:32:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 15:32:28 +0000 Subject: [Koha-bugs] [Bug 7848] Issues data missing from circulation notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7848 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Ian Walls --- Unconditional WARNs need to be removed. Once that's done, this can do to Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 17:34:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 15:34:29 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9878|0 |1 is obsolete| | --- Comment #5 from Owen Leonard --- Created attachment 9914 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9914&action=edit Screenshot showing inaccurate availability information The revised patch is an improvement but there is still no connection between the detailed status information and the list of items. Comparing the cart view on the left with the detail view of the right we can see that the cart isn't showing accurate information. The cart view is going to have to tie the status information directly to the location/call number information somehow, probably by putting it in the same table cell, or perhaps by moving all the the item information into a nested table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 17:34:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 15:34:52 +0000 Subject: [Koha-bugs] [Bug 7599] Cart JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7599 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Ian Walls --- Moves string out of JS and into a variable so translation can work it's magic. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 17:35:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 15:35:24 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 --- Comment #6 from Owen Leonard --- I also notice this patch doesn't add any information to the cart view one reaches by clicking the "more details" link. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 17:50:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 15:50:39 +0000 Subject: [Koha-bugs] [Bug 8063] Hold print notices do not sort by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #9 from Ian Walls --- First patch: Moves some code around, as well as adding a new loop and hash for splitting by branchcode. Marking Passed QA. Second patch: Just PBP cleanup, safe and sane, passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 18:06:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 16:06:30 +0000 Subject: [Koha-bugs] [Bug 7847] OPAC search dies with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7847 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #21 from Ian Walls --- Bends (but does not completely break) circular dependency between C4::Items and C4::Search by moving the inclusion into the specific subroutines that require the module. That, along with some scoping, are the primary changes here. As far as I can tell, these two subroutines are all that require the other modules, so this is safe. marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 18:14:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 16:14:55 +0000 Subject: [Koha-bugs] [Bug 8111] Language chooser display problem in self-checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8111 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #3 from Ian Walls --- Template only change, largely CSS and some YUI JS. Also adds a new image. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 18:46:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 16:46:31 +0000 Subject: [Koha-bugs] [Bug 8116] z3950 empty search causes silent warning in koha-error_log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8116 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #2 from Ian Walls --- Adds a default value of empty string to $query; marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 18:56:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 16:56:19 +0000 Subject: [Koha-bugs] [Bug 8082] The: IssuingInProcess configuration setting is working in reverse. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8082 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #5 from Ian Walls --- Reverses language on the syspref file. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 18:58:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 16:58:00 +0000 Subject: [Koha-bugs] [Bug 8160] Link to cataloging appears for users without cataloging permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8160 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #3 from Ian Walls --- Makes permissions check for display of cataloging page consistent and logical (user must have catalog or item editing permissions to get to the page where one can do that...) Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 19:25:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 17:25:33 +0000 Subject: [Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #9 from Ian Walls --- Simple patch to set the due time to the end of the day, rather than the beginning. Marking as Passed QA. I don't think there is going to be a good way to repeal any fines erroneously assessed in this way; while accountlines does have a timestamp field, it is updated every time the fine increments or is paid down, so we lose data about when the overdue was originally assessed. This needs to be fixed with a rebuilding of the accounts system, but that's beyond the scope of this particular issue. To clean up, the key variable would be the date of upgrade... anything due on that date could be credited 1 day's worth against it's overdue value... but this doesn't factor in after-due renewals, or materials that have already been returned (paid or not). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 20:25:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 18:25:32 +0000 Subject: [Koha-bugs] [Bug 8186] New: Form structure problem in serials claims filter Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8186 Priority: P5 - low Change sponsored?: --- Bug ID: 8186 Assignee: oleonard at myacpl.org Summary: Form structure problem in serials claims filter Severity: minor Classification: Unclassified OS: All Reporter: oleonard at myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Serials Product: Koha The serial claims filter form is structured so that form fields and labels are jumbled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 20:58:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 18:58:47 +0000 Subject: [Koha-bugs] [Bug 8187] New: Batch patron modification missing from tools sidebar menu Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8187 Priority: P5 - low Change sponsored?: --- Bug ID: 8187 Assignee: oleonard at myacpl.org Summary: Batch patron modification missing from tools sidebar menu Severity: minor Classification: Unclassified OS: All Reporter: oleonard at myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Templates Product: Koha The links to batch patrons modification appears on tools-home.pl but not in the tools sidebar menu which appears in the left-hand sidebar of most tools pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 21:11:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 19:11:48 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 --- Comment #7 from William Hurley --- Created attachment 9915 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9915&action=edit Test of proposed patch I tested the patch suggested last week and it works as advertised. Please Q&A when possible. I used the most current development version as provided by git, on lubuntu 12.04. Thanks for all your help in this matter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 21:12:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 19:12:11 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 William Hurley changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 21:25:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 19:25:57 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 --- Comment #8 from Owen Leonard --- Created attachment 9916 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9916&action=edit Bug 8171 - Improper escaping of quotes during z39.50 queries leads to broken html Implementing fix as suggested by Chris Cormack: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171#c4 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 21:26:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 19:26:15 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9915|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 21:26:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 19:26:41 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|PC |All Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 21:38:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 19:38:21 +0000 Subject: [Koha-bugs] [Bug 8188] New: OPAC allow hold date in future is controlled by staff-side preference Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8188 Priority: P5 - low Change sponsored?: --- Bug ID: 8188 CC: gmcharlt at gmail.com Assignee: koha.sekjal at gmail.com Summary: OPAC allow hold date in future is controlled by staff-side preference Severity: major Classification: Unclassified OS: All Reporter: oleonard at myacpl.org Hardware: All Status: NEW Version: master Component: Hold requests Product: Koha The OPAC's "Allow hold date in future" feature only works if the "AllowHoldDateInFuture" preference is enabled. Enabling the "OPACAllowHoldDateInFuture" preference has no effect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 21:40:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 19:40:37 +0000 Subject: [Koha-bugs] [Bug 8188] OPAC allow hold date in future is controlled by staff-side preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8188 --- Comment #1 from Owen Leonard --- Correction: *both* preferences have to be turned on for it to work. This doesn't seem consistent with other similar features in Koha. Why does it require both? # can set reserve date in future if ( C4::Context->preference( 'AllowHoldDateInFuture' ) && C4::Context->preference( 'OPACAllowHoldDateInFuture' ) ) { $template->param( reserve_in_future => 1, ); } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 21:41:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 19:41:02 +0000 Subject: [Koha-bugs] [Bug 8188] OPAC allow hold date in future requires both OPAC and staff-side preferences to be ON In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8188 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC allow hold date in |OPAC allow hold date in |future is controlled by |future requires both OPAC |staff-side preference |and staff-side preferences | |to be ON -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 22:02:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 20:02:54 +0000 Subject: [Koha-bugs] [Bug 7932] twitter share doesn't work with socialnetworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Ian Walls --- URL is hardcoded to https://, even if that's not the way the library is currently configured. Also tries to set data-lang = [% en %], which I do not believe is a valid template parameter (and if it is, it needs a different name). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 22:14:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 20:14:23 +0000 Subject: [Koha-bugs] [Bug 3638] Status of hold not changed when item checked in via SIP2 Interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3638 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P2 Status|Signed Off |Passed QA --- Comment #17 from Ian Walls --- First patch: modifies some subroutines in SIP/ILS/Item.pm to take borrowernumber/branchcode params, and set them for the hold. Moves hold handling to do_checkin instead of handle_checkin, and adds the processing from C4::Reserves we'd normally get in the staff client. Also strips out some commented lines. Marking as Passed QA. Second patch: Better handling of conditional (separate lines and shift instead of a Perl one-liner). Adds return_date to do_checkin call. Adds a call to ModItemTransfer where applicable. Bulk of work is to set a default current location, as the self check machine may not. Also marked Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 22:19:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 20:19:38 +0000 Subject: [Koha-bugs] [Bug 8161] Cataloging home page should be accessible to users with permission to edit catalog or edit items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8161 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #3 from Ian Walls --- Generalizes permissions slightly to cover more cases of valid users, then uses permissions to hide unusable links in the template. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 4 23:06:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 21:06:18 +0000 Subject: [Koha-bugs] [Bug 7643] Can't upload and import zipped file of patron images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7643 Katie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kaust at nhusd.k12.ca.us -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 01:21:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Jun 2012 23:21:14 +0000 Subject: [Koha-bugs] [Bug 8189] New: checkout history link gives error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8189 Priority: P5 - low Change sponsored?: --- Bug ID: 8189 CC: gmcharlt at gmail.com Assignee: kyle.m.hall at gmail.com Summary: checkout history link gives error Severity: enhancement Classification: Unclassified OS: All Reporter: melia at bywatersolutions.com Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha If you search the catalog, then click on the title of an item, clicking the checkout history tab on the left side of the screen produces the following error message. Software error: The 'month' parameter ("0") to DateTime::new did not pass the 'an integer between 1 and 12' callback at /usr/lib/perl5/DateTime.pm line 194 DateTime::new(undef, 'hour', 00, 'minute', 00, 'month', 0, 'second', 0, ...) called at /usr/share/perl5/DateTime/Format/DateParse.pm line 58 DateTime::Format::DateParse::parse_datetime('DateTime::Format::DateParse', '0000-00-00 00:00:00', 'America/New_York') called at /home/koha/kohaclone/Koha/DateUtils.pm line 86 Koha::DateUtils::dt_from_string('0000-00-00 00:00:00', 'sql') called at /home/koha/kohaclone/Koha/DateUtils.pm line 160 Koha::DateUtils::format_sqldatetime('0000-00-00 00:00:00') called at /home/koha/kohaclone/catalogue/issuehistory.pl line 74 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 05:34:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 03:34:12 +0000 Subject: [Koha-bugs] [Bug 7630] Warning on moremember.pl about param without key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7630 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com Severity|enhancement |minor --- Comment #1 from M. Tompsett --- This is similar to bug 7352. However, I don't believe patron quick search is memberentry.pl I was going to enter something similar, but since I think that would be a duplicate of this problem, I'll add this commentary with my debugging hunt. C4::Template generated the following error log entry: [Mon Jun 04 11:50:36 2012] [error] [client 192.168.100.2] [Mon Jun 4 11:50:36 2012] moremember.pl: Problem = a value of 1 has been passed to param without key at /usr/share/koha/lib/C4/Templates.pm line 186., referer: https://.../cgi-bin/koha/members/memberentry.pl So I looked around line 186 of C4::Templates.pm if ( $key ) { $self->{VARS}->{$key} = $val; } else { warn "Problem = a value of $val has been passed to param without key"; } So I figured that moremember.pl must have $template->param( ... => 1 ... Line 145 in moremember.pl looked like a candidate, but I figured not. $_ would have some value most likely. I kept looking (/\$template->param). I skipped a few lines which had concatenations, because I was hoping they'd be initialized and not be the problem. That's when I found line 445 which has a number of parameters across many lines. One of them was $error (around line 466). $error => 1, I then decided to search for $error backwards (?\$error). That's when I saw the code of line 74: my $error = $input->param('error'); I then looked at memberentry.pl the only set of lines with moremember.pl mentioned are: $input->redirect("/cgi-bin/koha/circ/circulation.pl?borrowernumber=$borrowernumber") : $input->redirect("/cgi-bin/koha/members/moremember.pl?borrowernumber=$borrowernumber") ; exit; # You can only send 1 redirect! After that, content or other headers don't matter. -- If someone noticed this before, why is it here? Also, notice there is no "&error=..." as well, so this isn't passing a value to $error. I figure that something similar to bug 6840 can be done in moremember.pl Split the $template->param() call: -- original ++ tweak $template->param( detailview => 1, AllowRenewalLimitOverride => C4::Context->preference("AllowRenewalLimitOverride"), DHTMLcalendar_dateformat => C4::Dates->DHTMLcalendar(), CANDELETEUSER => $candeleteuser, roaddetails => $roaddetails, borrowernumber => $borrowernumber, othernames => $data->{'othernames'}, categoryname => $data->{'description'}, reregistration => $reregistration, branch => $branch, todaysdate => C4::Dates->today(), totalprice => sprintf("%.2f", $totalprice), totaldue => sprintf("%.2f", $total), totaldue_raw => $total, issueloop => @issuedata, relissueloop => @relissuedata, issuecount => $issuecount, relissuecount => $relissuecount, overdues_exist => $overdues_exist, - error => $error, - $error => 1, StaffMember => ($category_type eq 'S'), is_child => ($category_type eq 'C'), # reserveloop => \@reservedata, dateformat => C4::Context->preference("dateformat"), "dateformat_" . (C4::Context->preference("dateformat") || '') => 1, samebranch => $samebranch, quickslip => $quickslip, ); ++$template->param(error => $error, $error => 1) if $error; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 05:39:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 03:39:28 +0000 Subject: [Koha-bugs] [Bug 7352] moremember.pl generates error in Template.pm related to missing $key value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7352 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #1 from M. Tompsett --- I believe that implementing my suggestion on bug 7630 would solve this problem too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 08:01:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 06:01:48 +0000 Subject: [Koha-bugs] [Bug 8174] OpacNavBottom appears between OpacNav and Patron Links when patron is logged in and browses to /koha/opac-main.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8174 --- Comment #2 from Robbie Meerman --- (In reply to comment #1) > I don't understand. If I log in and then go to the OPAC home page I won't > see the patron links anymore. Patron links aren't shown on the home page. Hmm then we have a mis-configuration on our end then. My apologies, I will check with Calyx. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 08:31:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 06:31:02 +0000 Subject: [Koha-bugs] [Bug 7630] Warning on moremember.pl about param without key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7630 --- Comment #2 from M. Tompsett --- Actually, the template file (moremember.tt) has an error check: [% IF ( error ) %] So, I wondered how does it handle undefined values or empty strings. I found my answer: http://my.safaribooksonline.com/book/programming/perl/0596004761/template-directives/perltt-chp-4-sect-5 "If the result of this statement is 0 or "" (the empty string), test is considered to be false; everything else is true. Variables that have not been assigned a value, either with DEFAULT or SET, are considered to be false (the value of an undefined variable is an empty string)." I was contemplating if my potential patch was overkill, or would break templates. It would seem that it wouldn't, though perhaps a simpler solution is better: -- original ++ tweak $template->param( detailview => 1, AllowRenewalLimitOverride => C4::Context->preference("AllowRenewalLimitOverride"), DHTMLcalendar_dateformat => C4::Dates->DHTMLcalendar(), CANDELETEUSER => $candeleteuser, roaddetails => $roaddetails, borrowernumber => $borrowernumber, othernames => $data->{'othernames'}, categoryname => $data->{'description'}, reregistration => $reregistration, branch => $branch, todaysdate => C4::Dates->today(), totalprice => sprintf("%.2f", $totalprice), totaldue => sprintf("%.2f", $total), totaldue_raw => $total, issueloop => @issuedata, relissueloop => @relissuedata, issuecount => $issuecount, relissuecount => $relissuecount, overdues_exist => $overdues_exist, error => $error, - $error => 1, StaffMember => ($category_type eq 'S'), is_child => ($category_type eq 'C'), # reserveloop => \@reservedata, dateformat => C4::Context->preference("dateformat"), "dateformat_" . (C4::Context->preference("dateformat") || '') => 1, samebranch => $samebranch, quickslip => $quickslip, ); ++$template->param($error => 1) if $error; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 09:27:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 07:27:08 +0000 Subject: [Koha-bugs] [Bug 1918] Minify JavaScript and CSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1918 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9112|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 9917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9917&action=edit Bug 1918 - Minify JavaScript and CSS Rebased patch. I test for curiosity :) For testing, install libjavascript-minifier-xs-perl and libcss-minifier-xs-perl. You need to create a koha-tmpl/intranet-tmpl/prog/en/combined directory with write mode for www-data Feedback: With firebug, I see 2 errors on the intranet detail page: GET menu-button-arrow.png 404 Not Found GET sprite.png 404 Not Found detail.pl: 21 requests 165.2 KB (159 KB from cache) 2.41s (onload: 2.5s) vs 9 requests 158.9 KB (146.2 KB from cache) 2.66s (121.8 KB JS + 24.3 KB CSS) search.pl (results): 20 requests 167.8 KB (159 KB from cache) 1.6s (onload: 3.68s) vs 4 requests 158.2 KB (146.2 KB from cache) 4.04s (onload: 4.05s) (121.8 KB JS + 24.3 KB CSS) We observe a decrease of the number of requests and data size, but also a small increase of the load time. I don't know if you have checked the load time. I did not test with Plack ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 09:58:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 07:58:50 +0000 Subject: [Koha-bugs] [Bug 6840] error in Template.pm in logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6840 M. Tompsett changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com --- Comment #7 from M. Tompsett --- This patch is fine, in my opinion. The comment made by Fred P 2011-12-13 16:52:38 UTC is a different problem, in my reading. I proposed a solution to his bug in bug 7630 (see also bug 7352). The problem is not all modules call with the 'error' parameter set. And Fred P's suggestion of: #addition to test error parameter status if ( $error ) { $template -> param ( $error => 1, error => 1, ); } is overkill compared to simply splitting up the large $template->param() call, and having $template->param($error => 1) if $error; separately from the long list. No, I didn't do any testing. I just don't want a good patch wasted. :) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 10:54:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 08:54:54 +0000 Subject: [Koha-bugs] [Bug 6840] error in Template.pm in logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6840 --- Comment #8 from Chris Cormack --- (In reply to comment #7) > This patch is fine, in my opinion. The comment made by Fred P 2011-12-13 > 16:52:38 UTC is a different problem, in my reading. I proposed a solution to > his bug in bug 7630 (see also bug 7352). > > The problem is not all modules call with the 'error' parameter set. And Fred > P's suggestion of: > #addition to test error parameter status > if ( $error ) { > $template -> param ( > $error => 1, > error => 1, > ); > } > is overkill compared to simply splitting up the large $template->param() > call, > and having > $template->param($error => 1) if $error; > separately from the long list. > > No, I didn't do any testing. I just don't want a good patch wasted. :) Well setting $error=>1 is different because the value of $error isn't 'error' so you would have to change the template as well. To match that in your patch you arent setting error in the template -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 12:02:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 10:02:52 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 Meenakshi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9907|0 |1 is obsolete| | Attachment #9914|0 |1 is obsolete| | --- Comment #7 from Meenakshi --- Created attachment 9918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9918&action=edit Latest Patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 12:07:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 10:07:11 +0000 Subject: [Koha-bugs] [Bug 8108] Remove unused images from the OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8108 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #5 from Paul Poulain --- I searched remaining references to some (not all) files removed. Could not find any problem. Patch pushed Patch could be backported to 3.8 but can also wait for 3.10 to avoid any regression in case we missed something -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 12:38:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 10:38:07 +0000 Subject: [Koha-bugs] [Bug 6840] error in Template.pm in logs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6840 --- Comment #9 from M. Tompsett --- (In reply to comment #8) > (In reply to comment #7) ... > > Fred P's suggestion of: > > #addition to test error parameter status > > if ( $error ) { > > $template -> param ( > > $error => 1, > > error => 1, > > ); > > } > > is overkill compared to simply splitting up the large $template->param() > > call, > > and having > > $template->param($error => 1) if $error; > > separately from the long list. > > > > No, I didn't do any testing. I just don't want a good patch wasted. :) > > Well setting $error=>1 is different because the value of $error isn't > 'error' so you would have to change the template as well. To match that in > your patch you arent setting error in the template True it should be: > > $error => 1, > > error => $error, I was merely quoting from comment #5 Otherwise, it would potentially break: upload-images.tt edithelp.tt addbooks.tt paycollect.tt step2.tt (the web installer!) step3.tt (yes, the web installer!) sms-home.tt But, it would probably still work in: linkitem.tt moveitem.tt senshelfform.tt moremember.tt label-manage.tt clone-rules.tt sendbasketform.tt opac-sendbasketform.tt opac-sendshelfform.tt On a git repo of master, I did a: $ vi `grep -l "IF ( error )" \`find . -name '*.tt'\`` This obviously may miss the plain [% error %]. So I did a: $ vi `grep -l "% error %" \`find . -name '*.tt'\`` And it returned 6 of the 7 files I listed as potentially broken. And as I said before, Fred P.'s suggestion to fix what bug he did find is better served by taking the '$error => 1' out of the larger $template->param() section and putting: $template->param($error => 1) if $error; just after that large section. The bug described by Fred P. is likely the same as the one discussed in bug 7352 and bug 7630. In fact, I decided to do a: $ grep "\$error\s*=>\s1" `find .` I found: ./tools/batchMod.pl ./cataloguing/additem.pl ./members/moremember.pl ./members/member-password.pl ./members/memberentry.pl If $error is undefined, all these modules will have problems. I did not look further, as that is beyond the scope of this error and the two bug reports I have mentioned. The patch viewable by diff is perfectly sufficient for the bug described in this bug report. However, as I said before Fred P.'s suggestion is better addressed by bug 7352 and bug 7630 being fixed as suggested above. A warning, which this patch generates, is better than the error generated by not having it. Clearly this patch is functioning, because it seems to be in 3.6.3 which we are currently running, and I found the other errors as a result of this cleanly generated "error" (really a warning), rather than an ugly error. In short, I think the status should be closed, so focus on bug 7352 and bug 7630 can be dealt with, which is what I believe Fred P. encountered. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 12:53:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 10:53:22 +0000 Subject: [Koha-bugs] [Bug 4838] Repeated authority headings break biblio record data entry form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 --- Comment #10 from Fr?d?ric Demians --- In 3.8, this functionality doesn't work anymore. Recent work on authorities broke the template which was distinguishing authorities repetitions. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 13:03:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 11:03:18 +0000 Subject: [Koha-bugs] [Bug 4838] Repeated authority headings break biblio record data entry form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4367|0 |1 is obsolete| | --- Comment #11 from Fr?d?ric Demians --- Created attachment 9919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9919&action=edit Proposed patch for 3.8 (and HEAD) How to test: Create an authority, with more than one heading, for example a UNIMARC multilingual author: 200 $7 da $a ? $b ?? 200 $7 ba $a Hara $b Junsuke In data entry form, on 700 field, you click on ... Search for the above author. In auhtority search result page, you just have a 'Choose' link, and so you just can select the first heading (in Chinesse writing). Apply the patch. Repeat. Now you have, on result page, you have two links, and can select one heading or the other. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 13:03:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 11:03:30 +0000 Subject: [Koha-bugs] [Bug 4838] Repeated authority headings break biblio record data entry form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 13:26:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 11:26:12 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #9 from Paul Poulain --- Patch tested with a sandbox, by Paul Poulain demoing at KohaCon12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 13:26:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 11:26:25 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9916|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 13:26:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 11:26:31 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 --- Comment #10 from Paul Poulain --- Created attachment 9920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9920&action=edit Bug 8171 - Improper escaping of quotes during z39.50 queries leads to broken html Implementing fix as suggested by Chris Cormack: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171#c4 Signed-off-by: Paul Poulain demoing at KohaCon12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 13:33:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 11:33:23 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #11 from Paul Poulain --- switching back to need signoff, it was just for the KohaCon12 demo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 13:33:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 11:33:40 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9916|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 13:33:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 11:33:53 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9920|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 15:30:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 13:30:07 +0000 Subject: [Koha-bugs] [Bug 8129] quick slips issuing does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8129 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 15:31:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 13:31:52 +0000 Subject: [Koha-bugs] [Bug 8176] $sqlwhere is undefined in C4::Serials in GetSubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8176 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #5 from Paul Poulain --- Colin, a question before pushing the patch : why =q{} and not ='' ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 15:33:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 13:33:12 +0000 Subject: [Koha-bugs] [Bug 7599] Cart JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7599 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 15:44:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 13:44:57 +0000 Subject: [Koha-bugs] [Bug 8063] Hold print notices do not sort by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #10 from Paul Poulain --- mmm... Kyle/Julian, When trying to run this script I gat a nasty: 15:42 ~/koha.dev/koha-community (new/bug_8063 $%)$ ./misc/cronjobs/gather_print_notices.pl Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 81. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 95. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 102. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 106. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 120. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 127. Execution of ./misc/cronjobs/gather_print_notices.pl aborted due to compilation errors. WTF ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 15:45:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 13:45:46 +0000 Subject: [Koha-bugs] [Bug 8063] Hold print notices do not sort by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com Severity|major |enhancement --- Comment #11 from Paul Poulain --- changing severity, it's an ENH, as well as assignee -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 15:47:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 13:47:15 +0000 Subject: [Koha-bugs] [Bug 7847] OPAC search dies with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7847 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Paul Poulain --- This patch, related to Plack and OPAC should be backported to 3.8 I think, as Plack is announced as working for OPAC in 3.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 15:52:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 13:52:17 +0000 Subject: [Koha-bugs] [Bug 8190] New: Koha does not have a logging module Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Priority: P5 - low Change sponsored?: --- Bug ID: 8190 Assignee: gmcharlt at gmail.com Summary: Koha does not have a logging module Severity: enhancement Classification: Unclassified OS: All Reporter: jonathan.druart at biblibre.com Hardware: All Status: NEW Version: unspecified Component: Architecture, internals, and plumbing Product: Koha I would be great to specify a log level (to differentiate production and development environment for example). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 15:52:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 13:52:28 +0000 Subject: [Koha-bugs] [Bug 8111] Language chooser display problem in self-checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8111 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #4 from Paul Poulain --- QA comment: the help page (sco/help.pl) still does not have the language chooser. That's not a big deal, as the user probably choose the language before hitting HELP, but just FYI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 15:52:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 13:52:30 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 15:55:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 13:55:48 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #1 from Jonathan Druart --- Created attachment 9921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9921&action=edit Bug 8190: C4::Logger, Logging module How it works: use C4::Logger qw/$log/; $log = C4::Logger->new; $log->debug("This is a debug message"); $log->info("This is an information"); $log->error("This is an error !"); The Logger constructor can take an hash reference with "file" and "level" to define a filepath or a log level. For a log level >= warning, a call stack is printed. Prerequisite: - set an environment variable LOG in your virtual host: SetEnv LOG /home/koha/var/log/opac.log - set a write flag for www-data on this file Please have a look at t/Logger.t for more details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 15:55:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 13:55:55 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 15:56:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 13:56:00 +0000 Subject: [Koha-bugs] [Bug 8116] z3950 empty search causes silent warning in koha-error_log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8116 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com --- Comment #3 from Paul Poulain --- Patch pushed, welcome to our 183th contributor ! ( Piotr, it's you ;-) ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 15:57:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 13:57:41 +0000 Subject: [Koha-bugs] [Bug 8082] The: IssuingInProcess configuration setting is working in reverse. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8082 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|rel_3_6 |unspecified Assignee|kyle.m.hall at gmail.com |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 16:00:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 14:00:34 +0000 Subject: [Koha-bugs] [Bug 8082] The: IssuingInProcess configuration setting is working in reverse. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8082 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 16:02:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 14:02:37 +0000 Subject: [Koha-bugs] [Bug 8160] Link to cataloging appears for users without cataloging permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8160 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 16:05:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 14:05:16 +0000 Subject: [Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #10 from Paul Poulain --- Patch pushed, I agree it will be hard to fix already upgraded libraries. One question: why have you defined 23:59:00, and not 23:59:59 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 16:14:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 14:14:22 +0000 Subject: [Koha-bugs] [Bug 3638] Status of hold not changed when item checked in via SIP2 Interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3638 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #18 from Paul Poulain --- QA comment: I couldn't test the patch with a true selfcheck machine, but patch pushed. Colin, before the patch there was some perlcritic problems, they are still here after the patch. If you can submit a follow-up to fix them, that would be nice. Should be very easy (removal or "return undef" in favour of "return" and removing prototyping of subs) 16:11 ~/koha.dev/koha-community (new/bug_3638 $%)$ perlcritic C4/SIP/ILS/Item.pm C4/SIP/ILS/Transaction/Checkin.pm C4/SIP/Sip/MsgType.pm C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 89, column 3. See page 199 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: Subroutine prototypes used at line 350, column 1. See page 194 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 352, column 26. See page 199 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 353, column 51. See page 199 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: Subroutine prototypes used at line 356, column 1. See page 194 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 359, column 28. See page 199 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 360, column 28. See page 199 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 361, column 61. See page 199 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: Subroutine prototypes used at line 364, column 1. See page 194 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 366, column 25. See page 199 of PBP. (Severity: 5) C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 368, column 24. See page 199 of PBP. (Severity: 5) C4/SIP/ILS/Transaction/Checkin.pm source OK C4/SIP/Sip/MsgType.pm: "return" statement with explicit "undef" at line 408, column 3. See page 199 of PBP. (Severity: 5) C4/SIP/Sip/MsgType.pm: Subroutine prototypes used at line 797, column 1. See page 194 of PBP. (Severity: 5) C4/SIP/Sip/MsgType.pm: "return" statement with explicit "undef" at line 798, column 24. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 16:18:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 14:18:25 +0000 Subject: [Koha-bugs] [Bug 8176] $sqlwhere is undefined in C4::Serials in GetSubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8176 --- Comment #6 from Jonathan Druart --- Paul, q{} is preferable according to the PBP. http://cpan.uwinnipeg.ca/htdocs/Perl-Critic/Perl/Critic/Policy/ValuesAndExpressions/ProhibitEmptyQuotes.pm.html and http://cheat.errtheblog.com/s/perl_best/1 #34 (Don?t use "" or '' for an empty string.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 16:25:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 14:25:41 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9897|0 |1 is obsolete| | --- Comment #173 from Paul Poulain --- Comment on attachment 9897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9897 Bug 5327 : Fix for XISBN test, thingisbn is now handing back different results This patch has been pushed, should please jenkins (seems librarything changes the returned results, making the test fail) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 16:37:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 14:37:23 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 16:54:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 14:54:03 +0000 Subject: [Koha-bugs] [Bug 8191] New: New value for 8 position in coded data field 100 in unimarc Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8191 Priority: P5 - low Change sponsored?: --- Bug ID: 8191 Assignee: gmcharlt at gmail.com Summary: New value for 8 position in coded data field 100 in unimarc Severity: enhancement Classification: Unclassified OS: All Reporter: sophie.meynieux at biblibre.com Hardware: All Status: NEW Version: unspecified Component: Cataloging Product: Koha Starting from July 2012, unimarc norm evolves and a new value must be added for position 8 in coded datafield 100 : k = "monography having both publication date and print date" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 16:56:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 14:56:36 +0000 Subject: [Koha-bugs] [Bug 8191] New value for 8 position in coded data field 100 in unimarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8191 --- Comment #1 from Sophie MEYNIEUX --- For more information see http://multimedia.bnf.fr/unimarcb_trad/B100-6-2010.pdf (Ticket mantis : http://suivi.biblibre.com/view.php?id=8661) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 17:00:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 15:00:25 +0000 Subject: [Koha-bugs] [Bug 8129] quick slips issuing does not work In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8129 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Bug fix, pushed to 3.8.x will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 17:00:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 15:00:28 +0000 Subject: [Koha-bugs] [Bug 8138] Add 773$t field to xslt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8138 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com QA Contact| |koha.sekjal at gmail.com --- Comment #38 from Ian Walls --- XSLT only patch to add 773$t to results if it exists. Simple and clean. Introduces new string "Source: ". Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 17:00:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 15:00:41 +0000 Subject: [Koha-bugs] [Bug 8161] Cataloging home page should be accessible to users with permission to edit catalog or edit items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8161 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 17:01:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 15:01:09 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org --- Comment #2 from Dobrica Pavlinusic --- Should we also wrap warn(s) to emit debug output like this? $SIG{__WARN__} = sub { C4::Logger->new->debug( @_ ); } Right now every warn in code makes patch fail QA (I know that first hand ;-) and it seems to me it's easier to just put warn instead of C4::Logger->new->debug( "this used to be warn" ); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 17:04:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 15:04:12 +0000 Subject: [Koha-bugs] [Bug 8176] $sqlwhere is undefined in C4::Serials in GetSubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8176 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|unspecified |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 17:07:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 15:07:48 +0000 Subject: [Koha-bugs] [Bug 7599] Cart JavaScript contains untranslatable English strings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7599 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 17:14:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 15:14:42 +0000 Subject: [Koha-bugs] [Bug 7847] OPAC search dies with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7847 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #23 from Chris Cormack --- Paul is correct, pushing to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 17:19:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 15:19:51 +0000 Subject: [Koha-bugs] [Bug 8192] New: Update libraries and Missing library in install_misc/ubuntu.packages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8192 Priority: P5 - low Change sponsored?: --- Bug ID: 8192 Assignee: gmcharlt at gmail.com Summary: Update libraries and Missing library in install_misc/ubuntu.packages Severity: enhancement Classification: Unclassified OS: Linux Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Installation and upgrade (command-line installer) Product: Koha Was doing a fresh install of what I pulled from the git repository a couple days ago. I am running Ubuntu 12.04 libdatetime-format-mysql-perl was missing after I did something similar to : apt-get install `./install_misc/ubuntu_pkg_check.sh | grep none | cut -f1 -d' '` I then did a ./koha_perl_deps.pl -m It said DateTime::Format::MySQL (the capitalization may be off, I'm doing this from memory). So I did: aptitude search datetime-format-mysql And such a library existed, so I installed it. And the koha_perl_deps.sh didn't complain about anything missing. I figure it is a quick one-line add. I confirmed that libdatetime-format-mysql-perl also exists on Ubuntu 10.10 Though, I was noticing the ubuntu.packages still references yaz3. The current version is yaz4. yaz3 does not exist on 12.04, nor 10.10. Please change libyaz3 and libyaz3-dev to libyaz4 and libyaz4-dev. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 17:27:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 15:27:07 +0000 Subject: [Koha-bugs] [Bug 8111] Language chooser display problem in self-checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8111 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #5 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 17:45:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 15:45:16 +0000 Subject: [Koha-bugs] [Bug 8116] z3950 empty search causes silent warning in koha-error_log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8116 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #4 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 17:47:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 15:47:55 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 --- Comment #2 from Owen Leonard --- This patch touches a lot of files, so I thought it might be helpful to list the pages which should be checked. In this first list, these are pages which can be viewed to check changes to include files. On each of these pages the search header include was modified: acquisitions-search.inc: acqui/acqui-home.pl authorities-search.inc: authorities/authorities-home.pl budgets-admin-search.inc: admin/aqbudgetperiods.pl cat-search.inc: virtualshelves/shelves.pl cataloging-search.inc: cataloguing/addbooks.pl checkin-search.inc: circ/returns.pl circ-search.inc: circ/circulation-home.pl cities-admin-search.inc: admin/cities.pl contracts-admin-search.inc: admin/aqcontract.pl?booksellerid=1 currencies-admin-search.inc: admin/currency.pl home-search.inc: mainpage.pl letters-search.inc: tools/letter.pl patron-search.inc: members/members-home.pl patrons-admin-search.inc: admin/categorie.pl prefs-admin-search.inc: admin/preferences.pl printers-admin-search.inc: admin/printers.pl roadtype-admin-search.inc: admin/roadtype.pl serials-search.inc: serials/serials-home.pl stopwords-admin-search.inc: admin/stopwords.pl suggestions-add-search.inc: acqui/newordersuggestion.pl?booksellerid=1&basketno=1 sysprefs-admin-search.inc: admin/systempreferences.pl z3950-admin-search.inc: admin/z3950servers.pl These pages have changes to their main templates: about.pl acqui/basketgroup.pl admin/auth_subfields_structure.pl admin/authorised_values.pl admin/branch_transfer_limits.pl admin/item_circulation_alerts.pl admin/itemtypes.pl admin/marc_subfields_structure.pl authorities/authorities.pl authorities/detail.pl catalogue/MARCdetail.pl catalogue/advsearch.pl catalogue/detail.pl cataloguing/addbiblio.pl cataloguing/merge.pl circ/circulation.pl circ/waitingreserves.pl members/boraccount.pl members/mancredit.pl members/maninvoice.pl members/moremember.pl members/pay.pl members/paycollect.pl reviews/reviewswaiting.pl serials/serials-collection.pl serials/subscription-detail.pl suggestion/suggestion.pl tools/csv-profiles.pl tools/overduerules.pl virtualshelves/shelves.pl opac-advsearch.pl opac-detail.pl opac-readingrecord.pl opac-user.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 17:53:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 15:53:08 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9886|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 9922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9922&action=edit Bug 8143 [REVISED] Upgrade jQuery tabs to current jQueryUI version Current jQuery-driven tabs are done using a very old version of the tabs plugin. This patch upgrades jQueryUI to the latest version and adds the tabs widget dependency to the jqueryui js file and updates the syntax for existing tabs: - $("#foo > ul").tabs(); changes to $("#foo").tabs(); - Remove full URL from tab links (use #anchor only). Pages with "static" tabs (tabs which are built in the markup rather than generated by the plugin) have been modified to use their own style. Examples: pay.tt in the staff client and opac-readingrecord.tt in the OPAC. Edit: Minor revision to some uncorrected markup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 17:58:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 15:58:39 +0000 Subject: [Koha-bugs] [Bug 8191] New value for 8 position in coded data field 100 in unimarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8191 --- Comment #2 from Sophie MEYNIEUX --- Created attachment 9923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9923&action=edit Bug 8191 : Adding a new value to 8 position of coded data field 100 From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 17:59:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 15:59:28 +0000 Subject: [Koha-bugs] [Bug 8191] New value for 8 position in coded data field 100 in unimarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8191 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 17:59:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 15:59:50 +0000 Subject: [Koha-bugs] [Bug 8191] New value for 8 position in coded data field 100 in unimarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8191 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |sophie.meynieux at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 18:05:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 16:05:16 +0000 Subject: [Koha-bugs] [Bug 8193] New: Why isn't Owen at NEKLS for the KohaCon12 ? Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8193 Priority: P5 - low Change sponsored?: --- Bug ID: 8193 Assignee: oleonard at myacpl.org Summary: Why isn't Owen at NEKLS for the KohaCon12 ? Severity: enhancement Classification: Unclassified OS: All Reporter: paul.poulain at biblibre.com Hardware: All Status: NEW Version: master Component: About Product: Koha jcamins: Why are you at NEKLS? oleonard: 'cause I couldn't go to Edinburgh. * druthb (~druthb at 24.124.17.146) a rejoint #koha So the question is really why am I not at NEKLS? oleonard: I don't know! Why aren't you at NEKLS? that is a very good question. we have a seat here for you. oleonard = you're the only one knowing :D :D why *aren't* you at nekls :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 18:13:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 16:13:41 +0000 Subject: [Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182 --- Comment #11 from Kyle M Hall --- Either way should be functionally equivalent, at least until we implement fines at the per-second level ; ) Kyle (In reply to comment #10) > Patch pushed, I agree it will be hard to fix already upgraded libraries. > > One question: why have you defined 23:59:00, and not 23:59:59 ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 18:25:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 16:25:28 +0000 Subject: [Koha-bugs] [Bug 8004] Items on Hold Lose Transfer After Being Scanned Twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004 Melissa Geist changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mgeist at sekls.org --- Comment #2 from Melissa Geist --- Test with a sandbox. Works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 18:27:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 16:27:14 +0000 Subject: [Koha-bugs] [Bug 8187] Batch patron modification missing from tools sidebar menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8187 --- Comment #1 from Owen Leonard --- Created attachment 9924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9924&action=edit Bug 8187 - Batch patron modification missing from tools sidebar menu Adding a link to the tools sidebar menu for batch patron modification. Also changing the link text on the Tools home page to make it somewhat clearer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 18:27:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 16:27:55 +0000 Subject: [Koha-bugs] [Bug 8193] Why isn't Owen at NEKLS for the KohaCon12 ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8193 --- Comment #1 from Ian Walls --- Created attachment 9925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9925&action=edit Proposed Patch Updates Owen Leonard's location to "NEKLS offices, Lawrence, KS, USA" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 18:28:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 16:28:02 +0000 Subject: [Koha-bugs] [Bug 8193] Why isn't Owen at NEKLS for the KohaCon12 ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8193 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |koha.sekjal at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 18:28:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 16:28:13 +0000 Subject: [Koha-bugs] [Bug 8187] Batch patron modification missing from tools sidebar menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8187 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 18:53:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 16:53:45 +0000 Subject: [Koha-bugs] [Bug 8184] Duplicate budget page lacks heading and breadcrumbs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8184 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 18:58:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 16:58:54 +0000 Subject: [Koha-bugs] [Bug 8184] Duplicate budget page lacks heading and breadcrumbs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8184 --- Comment #1 from Owen Leonard --- Created attachment 9926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9926&action=edit Bug 8184 - Duplicate budget page lacks heading and breadcrumbs Adding title, heading, and breadcrumbs for "duplicate a budget" operation. Also: - adding cancel link for duplicate and edit - correcting the CSS so that the "edit" menu button is styled like an edit button. operations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 18:59:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 16:59:38 +0000 Subject: [Koha-bugs] [Bug 8184] Duplicate budget page lacks heading and breadcrumbs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8184 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 19:00:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 17:00:01 +0000 Subject: [Koha-bugs] [Bug 8170] 5XX fields get hidden under Title notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8170 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 19:15:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 17:15:04 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |wizzyrea at gmail.com --- Comment #8 from Liz Rea --- I found a problem in step 6 of the testing protocol - I have issues in my DB but every item shows 0 issues when the script is run. Trivial problem - the documentation refers to update_total_issues.pl, the name of the script in the filesystem is update_totalissues.pl. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 19:17:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 17:17:27 +0000 Subject: [Koha-bugs] [Bug 8119] Show hint when disabling active currency checkbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8119 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9657|0 |1 is obsolete| | Attachment #9692|0 |1 is obsolete| | --- Comment #4 from Jared Camins-Esakov --- Created attachment 9927 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9927&action=edit Bug 8119 - Show hint when disabling active currency checkbox Display a hint when the exchange rate != 1.0: "The active currency must have a rate of 1.0" Signed-off-by: Chris Cormack Signed-off-by: Shari Perkins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 19:17:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 17:17:57 +0000 Subject: [Koha-bugs] [Bug 8119] Show hint when disabling active currency checkbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8119 --- Comment #5 from Jared Camins-Esakov --- Created attachment 9928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9928&action=edit Bug 8119 - Followup Show hint when disabling active currency checkbox Display the message on editing Signed-off-by: Shari Perkins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 19:20:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 17:20:07 +0000 Subject: [Koha-bugs] [Bug 8119] Show hint when disabling active currency checkbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8119 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Jared Camins-Esakov --- Signed off by Shari Perkins, uploaded with Jared Camins-Esakov's account. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 19:43:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 17:43:17 +0000 Subject: [Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melia at bywatersolutions.com --- Comment #15 from Melia Meggs --- Changing status back to "signed off" because the first patch needs QA from someone other than Ian, please. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 21:19:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 19:19:05 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9180|0 |1 is obsolete| | Attachment #9181|0 |1 is obsolete| | Attachment #9186|0 |1 is obsolete| | Attachment #9187|0 |1 is obsolete| | --- Comment #62 from Jared Camins-Esakov --- Created attachment 9929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9929&action=edit Bug 7936: Acq Help Files for 3.8 Signed-off-by: Shari Perkins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 21:19:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 19:19:29 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 --- Comment #63 from Jared Camins-Esakov --- Created attachment 9930 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9930&action=edit Bug 7936: Admin Help files for 3.8 Signed-off-by: Shari Perkins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 21:19:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 19:19:46 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 --- Comment #64 from Jared Camins-Esakov --- Created attachment 9931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9931&action=edit Bug 7936: Offline Circ Help This is missing a new file for the Firefox plugin because I haven't documented it yet because I can't get it to work. Signed-off-by: Shari Perkins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 21:20:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 19:20:06 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 --- Comment #65 from Jared Camins-Esakov --- Created attachment 9932 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9932&action=edit Bug 7936: Serials Help for 3.8 Signed-off-by: Shari Perkins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 21:20:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 19:20:56 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #66 from Jared Camins-Esakov --- Signed off by Shari Perkins, uploaded by Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 21:44:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 19:44:26 +0000 Subject: [Koha-bugs] [Bug 8082] The: IssuingInProcess configuration setting is working in reverse. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8082 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 21:51:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 19:51:23 +0000 Subject: [Koha-bugs] [Bug 8160] Link to cataloging appears for users without cataloging permission In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8160 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #4 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 22:02:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 20:02:11 +0000 Subject: [Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 22:24:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 20:24:28 +0000 Subject: [Koha-bugs] [Bug 6039] Cancel all waiting holds button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion CC| |melia at bywatersolutions.com --- Comment #20 from Melia Meggs --- Two libraries on 3.8.1 have reported that the "Cancel All" button is not working as expected. After clicking the "Cancel All" button, all of their waiting holds were deleted, not just the expired ones. We had to restore the waiting holds from backup. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 23:42:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 21:42:44 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9929|0 |1 is obsolete| | Attachment #9930|0 |1 is obsolete| | Attachment #9931|0 |1 is obsolete| | Attachment #9932|0 |1 is obsolete| | --- Comment #67 from Jared Camins-Esakov --- Created attachment 9933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9933&action=edit Bug 7936: Acq Help Files for 3.8 Signed-off-by: Shari Perkins Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 23:42:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 21:42:56 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 --- Comment #68 from Jared Camins-Esakov --- Created attachment 9934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9934&action=edit Bug 7936: Admin Help files for 3.8 Signed-off-by: Shari Perkins Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 23:43:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 21:43:13 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 --- Comment #69 from Jared Camins-Esakov --- Created attachment 9935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9935&action=edit Bug 7936: Admin Help files for 3.8 Signed-off-by: Shari Perkins Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 23:43:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 21:43:22 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 --- Comment #70 from Jared Camins-Esakov --- Created attachment 9936 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9936&action=edit Bug 7936: Offline Circ Help This is missing a new file for the Firefox plugin because I haven't documented it yet because I can't get it to work. Signed-off-by: Shari Perkins Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 23:43:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 21:43:31 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 --- Comment #71 from Jared Camins-Esakov --- Created attachment 9937 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9937&action=edit Bug 7936: Serials Help for 3.8 Signed-off-by: Shari Perkins Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 23:44:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 21:44:12 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 --- Comment #72 from Jared Camins-Esakov --- Created attachment 9938 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9938&action=edit Bug 7936 followup: Copyedited Acquisitions help files Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 23:44:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 21:44:22 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 --- Comment #73 from Jared Camins-Esakov --- Created attachment 9939 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9939&action=edit Bug 7936 followup: Copyedited Offline Circ help files Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 23:44:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 21:44:47 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9935|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 5 23:45:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 21:45:28 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 --- Comment #74 from Jared Camins-Esakov --- All attached patches have been signed off. Followups were written by Shari Perkins, signed off and uploaded by jcamins. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 01:26:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 23:26:15 +0000 Subject: [Koha-bugs] [Bug 6039] Cancel all waiting holds button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 --- Comment #21 from Srdjan Jankovic --- That is misfortunate. To my defence, I have to say that the request was for ?Cancel All?, not ?Cancel All Expired? button. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 01:45:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 23:45:01 +0000 Subject: [Koha-bugs] [Bug 6039] Cancel all waiting holds button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 --- Comment #22 from Melia Meggs --- So let's clarify what the button is supposed to do. - Cancel all holds on the holds over tab? Or - Cancel all holds on the holds over AND holds waiting tabs? Right now it is canceling all holds over and all holds waiting. So it is canceling holds regardless of whether they are older than the ReservesMaxPickUpDelay. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 01:56:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Jun 2012 23:56:58 +0000 Subject: [Koha-bugs] [Bug 6039] Cancel all waiting holds button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 --- Comment #23 from Srdjan Jankovic --- Ok, now when I look at the screen I think it is rewasonable to expect only the holds over to be cancelled, because it is on that tab. How do we sort this one out? maybe create another bug cause this one has already been pushed? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 02:05:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 00:05:23 +0000 Subject: [Koha-bugs] [Bug 6039] Cancel all waiting holds button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 --- Comment #24 from Melia Meggs --- Yes, I agree that it should only cancel holds over (which is the same as holds that are older than ReservesMaxPickUpDelay, yes?). The holds waiting do not all need to be canceled. I don't know if it's best to create another bug report or just submit a follow up patch. Not sure what the community likes to do in a case like this. Either way is fine with me! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 02:24:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 00:24:07 +0000 Subject: [Koha-bugs] [Bug 6039] Cancel all waiting holds button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 --- Comment #25 from Srdjan Jankovic --- (In reply to comment #24) > Yes, I agree that it should only cancel holds over (which is the same as > holds that are older than ReservesMaxPickUpDelay, yes?). I presume. In any case whatever is on that tab and not for transfer. > I don't know if it's best to create another bug report or just submit a > follow up patch. Not sure what the community likes to do in a case like > this. Either way is fine with me! I will wait for the second opinion, but I think whatever is pushed to a release should not be touched any more. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 05:17:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 03:17:05 +0000 Subject: [Koha-bugs] [Bug 8009] Item descriptive data not populated on pay.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 --- Comment #8 from D Ruth Bavousett --- Fix or enhancement, I'd really like to see it in Stable, if that's possible. We've got several libraries that are asking for it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 05:25:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 03:25:54 +0000 Subject: [Koha-bugs] [Bug 8009] Item descriptive data not populated on pay.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_10 |rel_3_8 Severity|enhancement |minor --- Comment #9 from Jared Camins-Esakov --- I would consider this a bugfix. I intend to backport to 3.6.x, as it is a low-risk patch that fixes an obvious error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 07:00:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 05:00:09 +0000 Subject: [Koha-bugs] [Bug 3638] Status of hold not changed when item checked in via SIP2 Interface In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3638 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #19 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 07:35:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 05:35:14 +0000 Subject: [Koha-bugs] [Bug 8161] Cataloging home page should be accessible to users with permission to edit catalog or edit items In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8161 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 07:37:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 05:37:05 +0000 Subject: [Koha-bugs] [Bug 8176] $sqlwhere is undefined in C4::Serials in GetSubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8176 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 07:51:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 05:51:43 +0000 Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 09:07:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 07:07:32 +0000 Subject: [Koha-bugs] [Bug 8194] New: Subscription-add.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8194 Priority: P5 - low Change sponsored?: --- Bug ID: 8194 Assignee: oleonard at myacpl.org Summary: Subscription-add.tt Severity: enhancement Classification: Unclassified OS: All Reporter: dcook at prosentient.com.au Hardware: All Status: NEW Version: rel_3_8 Component: Templates Product: Koha The serials planning / subscription form planning DIV isn't being floated to the right as it should. One solution would be to force the subscription DIV to be be longer, but I'm sure that there is likely a better solution... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 09:23:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 07:23:06 +0000 Subject: [Koha-bugs] [Bug 7586] Search: Language restriction does NOT show expected results (no items shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7586 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Assignee|oleonard at myacpl.org |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 10:04:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 08:04:07 +0000 Subject: [Koha-bugs] [Bug 8062] Cart email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9908|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart --- Created attachment 9940 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9940&action=edit Bug 8062 [SIGNED-OFF] Perl module dependency Template::Plugin::HtmlToText Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 10:15:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 08:15:54 +0000 Subject: [Koha-bugs] [Bug 8187] Batch patron modification missing from tools sidebar menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8187 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9924|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart --- Created attachment 9941 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9941&action=edit Bug 8187 - [SIGNED-OFF] Batch patron modification missing from tools sidebar menu Adding a link to the tools sidebar menu for batch patron modification. Also changing the link text on the Tools home page to make it somewhat clearer. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 10:21:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 08:21:48 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for recieving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 --- Comment #4 from Julian Maurice --- (In reply to comment #3) > i can't test in a sandbox No, this patch cannot be tested on sandboxes because it depends on another patch that is not in master (bug 7295). But both patches (for bug 7295 and this bug) doesn't apply anymore on master. I will rebase and resubmit them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 10:26:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 08:26:41 +0000 Subject: [Koha-bugs] [Bug 8195] New: The selected link in include menus must be bold Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8195 Priority: P5 - low Change sponsored?: --- Bug ID: 8195 Assignee: oleonard at myacpl.org Summary: The selected link in include menus must be bold Severity: enhancement Classification: Unclassified OS: All Reporter: jonathan.druart at biblibre.com Hardware: All Status: NEW Version: unspecified Component: Templates Product: Koha For several links, the selected entry is not bold, try with these pages: admin/smart-rules.pl admin/biblio_framework.pl tools/export.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 10:26:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 08:26:53 +0000 Subject: [Koha-bugs] [Bug 8195] The selected link in include menus must be bold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8195 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 10:30:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 08:30:02 +0000 Subject: [Koha-bugs] [Bug 8195] The selected link in include menus must be bold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8195 --- Comment #1 from Jonathan Druart --- Created attachment 9942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9942&action=edit Bug 8195: Selected link must be bold (in admin and tools) For several links, the selected entry is not bold, try with these pages: admin/smart-rules.pl admin/biblio_framework.pl tools/export.pl This patch fixes this behaviour -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 10:30:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 08:30:24 +0000 Subject: [Koha-bugs] [Bug 8195] The selected link in include menus must be bold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8195 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 10:41:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 08:41:31 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9309|0 |1 is obsolete| | --- Comment #4 from Julian Maurice --- Created attachment 9943 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9943&action=edit More granular permissions for baskets Patch rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 10:42:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 08:42:11 +0000 Subject: [Koha-bugs] [Bug 7290] new permission for recieving In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7290 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9399|0 |1 is obsolete| | --- Comment #5 from Julian Maurice --- Created attachment 9944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9944&action=edit More granular permissions for order receiving Patch rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 12:09:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 10:09:01 +0000 Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #7 from Nicole C. Engard --- *** Bug 7925 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 12:09:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 10:09:01 +0000 Subject: [Koha-bugs] [Bug 7925] today's checkouts not splitting out anymore In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7925 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Nicole C. Engard --- *** This bug has been marked as a duplicate of bug 8043 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 12:09:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 10:09:28 +0000 Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 --- Comment #8 from Nicole C. Engard --- Just a note from the other bug report: On the checkout summary it used to split today's checkouts and previous checkouts: http://manual.koha-community.org/3.6/en/images/circ/checkoutsummary.png -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 12:12:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 10:12:27 +0000 Subject: [Koha-bugs] [Bug 8063] Hold print notices do not sort by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 12:28:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 10:28:01 +0000 Subject: [Koha-bugs] [Bug 7911] Greater flexibility in auto barcode number generation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7911 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta at osslabs.biz Assignee|gmcharlt at gmail.com |amit.gupta at osslabs.biz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 12:28:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 10:28:15 +0000 Subject: [Koha-bugs] [Bug 7911] Greater flexibility in auto barcode number generation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7911 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 12:30:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 10:30:40 +0000 Subject: [Koha-bugs] [Bug 8196] New: members/memberentry.pl?op=add shows all extended attribute values from database Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 Priority: P5 - low Change sponsored?: --- Bug ID: 8196 CC: gmcharlt at gmail.com Assignee: kyle.m.hall at gmail.com Summary: members/memberentry.pl?op=add shows all extended attribute values from database Severity: enhancement Classification: Unclassified OS: All Reporter: dpavlin at rot13.org Hardware: All Status: NEW Version: master Component: Patrons Product: Koha Adding new patrons with extended attributes shows all values from database as opposed to empty input boxes for attributes available. Bug 5742 changed code in C4/Members/Attributes.pm so that WHERE doesn't work correctly when used without borrowernumber (and it's undef when adding new patron) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 12:31:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 10:31:31 +0000 Subject: [Koha-bugs] [Bug 5742] batch edit patrons In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5742 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org --- Comment #26 from Dobrica Pavlinusic --- This bug breaks members/memberentry.pl?op=add when you are using extended attributes since it displays all extended attributes available in database as opposed to empty input boxes for available attributes. Bug 8196 will contain fix for this problem. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 12:55:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 10:55:50 +0000 Subject: [Koha-bugs] [Bug 8196] members/memberentry.pl?op=add shows all extended attribute values from database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Assignee|kyle.m.hall at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 12:55:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 10:55:56 +0000 Subject: [Koha-bugs] [Bug 8196] members/memberentry.pl?op=add shows all extended attribute values from database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 13:12:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 11:12:32 +0000 Subject: [Koha-bugs] [Bug 8193] Why isn't Owen at NEKLS for the KohaCon12 ? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8193 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from Paul Poulain --- seems this bug won't be fixed, so closing it to avoid having a bug opened without any reason. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 13:44:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 11:44:43 +0000 Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 --- Comment #2 from Meenakshi --- Created attachment 9945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9945&action=edit Attaching Patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 13:45:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 11:45:07 +0000 Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Meenakshi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 13:50:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 11:50:41 +0000 Subject: [Koha-bugs] [Bug 6777] Display link to related acquisitions details from catalogue record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6777 --- Comment #2 from shinoy m --- Created attachment 9946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9946&action=edit Display link to related acquisitions details from catalogue record -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 13:51:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 11:51:03 +0000 Subject: [Koha-bugs] [Bug 7915] Print a barcoded membership card from member detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7915 --- Comment #1 from Ebin Joseph --- Created attachment 9947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9947&action=edit Patch for printing the barcoded membership card -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 13:51:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 11:51:22 +0000 Subject: [Koha-bugs] [Bug 7915] Print a barcoded membership card from member detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7915 Ebin Joseph changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |ebin.joseph at osslabs.biz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 13:54:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 11:54:12 +0000 Subject: [Koha-bugs] [Bug 8196] members/memberentry.pl?op=add shows all extended attribute values from database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 --- Comment #1 from Jonathan Druart --- Created attachment 9948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9948&action=edit Bug 8196: FIX for Bug 5742: All extended attributes are shown when editing a patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 13:54:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 11:54:25 +0000 Subject: [Koha-bugs] [Bug 8196] members/memberentry.pl?op=add shows all extended attribute values from database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 13:56:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 11:56:42 +0000 Subject: [Koha-bugs] [Bug 6777] Display link to related acquisitions details from catalogue record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6777 shinoy m changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 13:56:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 11:56:57 +0000 Subject: [Koha-bugs] [Bug 8196] members/memberentry.pl?op=add shows all extended attribute values from database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 --- Comment #2 from Jonathan Druart --- I don't know why I change the behaviour of this routine for Bug 5742. It appears useless and introduced side effect. I put back the code like it was before the batch edit patron patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 14:04:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 12:04:46 +0000 Subject: [Koha-bugs] [Bug 7911] Greater flexibility in auto barcode number generation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7911 --- Comment #2 from Amit Gupta --- Created attachment 9949 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9949&action=edit Greater flexibility in auto barcode number Add option to generate autoBarcode with itemtype as prefix To Test: 1) Go to More->Adminstration->Global system preferences 2) Choose (generated in the form itemtypecode) under autobarcode option. 3) Create one bibliographic record and add item. 4) Click on barcode field it will generate barcode automatically for ex: BK0001 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 14:04:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 12:04:54 +0000 Subject: [Koha-bugs] [Bug 7911] Greater flexibility in auto barcode number generation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7911 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 15:01:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 13:01:44 +0000 Subject: [Koha-bugs] [Bug 8195] The selected link in include menus must be bold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8195 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9942|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 9950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9950&action=edit Bug 8195: Selected link must be bold (in admin and tools) For several links, the selected entry is not bold, try with these pages: admin/smart-rules.pl admin/biblio_framework.pl tools/export.pl This patch fixes this behaviour Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 15:02:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 13:02:07 +0000 Subject: [Koha-bugs] [Bug 8197] New: Software error when you have cleaned cookies in your browser and try to past the url to opac-topissues.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8197 Priority: P5 - low Change sponsored?: --- Bug ID: 8197 Assignee: oleonard at myacpl.org Summary: Software error when you have cleaned cookies in your browser and try to past the url to opac-topissues.pl Severity: normal Classification: Unclassified OS: All Reporter: christophe.croullebois at biblibre.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha To test : for Opera ie :Settings/Delete Private Data/Detailed options => Delete sessions cookies Paste in your browser : ...cgi-bin/koha/opac-topissues.pl Without patch you'll have : Can't use an undefined value as a HASH reference at ...community/opac/opac-topissues.pl line 133. For help, please send mail to the webmaster..... This coding error must be tracked in all koha and corrected. I'll report that fact in an other bug. For this one it just corrects for opac-topissues.pl page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 15:02:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 13:02:57 +0000 Subject: [Koha-bugs] [Bug 8195] The selected link in include menus must be bold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8195 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 15:02:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 13:02:59 +0000 Subject: [Koha-bugs] [Bug 8197] Software error when you have cleaned cookies in your browser and try to past the url to opac-topissues.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8197 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |christophe.croullebois at bibl | |ibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 15:13:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 13:13:11 +0000 Subject: [Koha-bugs] [Bug 8138] Add 773$t field to xslt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8138 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|unspecified |rel_3_10 --- Comment #39 from Paul Poulain --- Can probably be back-ported to 3.8 safely & usefully -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 15:32:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 13:32:57 +0000 Subject: [Koha-bugs] [Bug 8196] members/memberentry.pl?op=add shows all extended attribute values from database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9948|0 |1 is obsolete| | --- Comment #3 from Dobrica Pavlinusic --- Created attachment 9951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9951&action=edit Bug 8196: FIX for Bug 5742: All extended attributes are shown when editing a patron Test scenario: 1. make sure that you have ExtendedPatronAttributes enabled 2. open /cgi-bin/koha/members/memberentry.pl?op=add;categorycode=S0 (you might need to modify categorycode according to your local config) 3. verify that you get all extended patron attributes in form Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 15:33:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 13:33:54 +0000 Subject: [Koha-bugs] [Bug 8196] members/memberentry.pl?op=add shows all extended attribute values from database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Dobrica Pavlinusic --- Thanks Jonathan, I intended to fix this myself but was distracted by lunch break :-) Anyhow, least I can do is sign off :-)) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 15:34:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 13:34:38 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 --- Comment #8 from Owen Leonard --- Created attachment 9952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9952&action=edit Screenshot showing inaccurate availability information This patch is improving, but still isn't giving entirely accurate information. As this screenshot shows, lost, damaged, and withdrawn show correctly. However, checked-out and in-transit do not. Hold status is unknown on the Cart listing, but ambiguous on the detail page so I'm not sure the burden is on this patch to resolve it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 15:34:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 13:34:47 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 15:42:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 13:42:27 +0000 Subject: [Koha-bugs] [Bug 8063] Hold print notices do not sort by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 --- Comment #12 from Kyle M Hall --- Created attachment 9953 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9953&action=edit Bug 8063 - Followup - Bug fix $OUTPUT being used but not being declared. When trying to run this script I gat a nasty: 15:42 ~/koha.dev/koha-community (new/bug_8063 $%)$ ./misc/cronjobs/gather_print_notices.pl Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 81. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 95. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 102. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 106. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 120. Global symbol "$OUTPUT" requires explicit package name at ./misc/cronjobs/gather_print_notices.pl line 127. Execution of ./misc/cronjobs/gather_print_notices.pl aborted due to compilation errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 15:42:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 13:42:46 +0000 Subject: [Koha-bugs] [Bug 8063] Hold print notices do not sort by branch In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8063 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 15:49:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 13:49:33 +0000 Subject: [Koha-bugs] [Bug 8197] Software error when you have cleaned cookies in your browser and try to past the url to opac-topissues.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8197 --- Comment #1 from Christophe Croullebois --- Created attachment 9954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9954&action=edit patch thx for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 15:52:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 13:52:12 +0000 Subject: [Koha-bugs] [Bug 5600] Bulk MARC biblio export script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Assignee|koha.sekjal at gmail.com |julian.maurice at biblibre.com --- Comment #2 from Julian Maurice --- Created attachment 9955 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9955&action=edit Bug 5600: Command line interface for tools/export.pl export.pl [--format=format] [--date=date] [--dont_export_items] [--deleted_barcodes] [--clean] --filename=outputfile * format is either 'xml' or 'marc' (default) * date should be entered as the 'dateformat' syspref is set (dd/mm/yyyy for metric, yyyy-mm-dd for iso, mm/dd/yyyy for us) * records exported are the ones that have been modified since 'date' * if --deleted_barcodes is used, a list of barcodes of items deleted since 'date' is produced (or from all deleted items if no date is specified) * --clean removes NSE/NSB -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 15:55:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 13:55:52 +0000 Subject: [Koha-bugs] [Bug 5600] Bulk MARC biblio export script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 --- Comment #3 from Jared Camins-Esakov --- This patch seems to eliminate the ability to export from the staff client. Wouldn't it be better to either make the script so that it can be accessed via CGI or command-line, or add a second script (which I think may have been what Ian and Paul agreed was the best option for this sort of script)? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 16:13:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 14:13:36 +0000 Subject: [Koha-bugs] [Bug 8198] New: Need to track the call to "C4::Context->userenv->{'xxxx'} without check if it is undefined Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8198 Priority: P5 - low Change sponsored?: --- Bug ID: 8198 Assignee: gmcharlt at gmail.com Summary: Need to track the call to "C4::Context->userenv->{'xxxx'} without check if it is undefined Severity: normal Classification: Unclassified OS: All Reporter: christophe.croullebois at biblibre.com Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha linked with bug 8197, all the lines like that will return a koha error if session cookies have been deleted. It would be nice to correct all the relevant lines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 16:14:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 14:14:44 +0000 Subject: [Koha-bugs] [Bug 8198] Need to track the call to "C4::Context->userenv->{'xxxx'} without check if it is undefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8198 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |christophe.croullebois at bibl | |ibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 16:14:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 14:14:52 +0000 Subject: [Koha-bugs] [Bug 8197] Software error when you have cleaned cookies in your browser and try to past the url to opac-topissues.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8197 Christophe Croullebois changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 16:29:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 14:29:26 +0000 Subject: [Koha-bugs] [Bug 8199] New: Search results are contained into a table html element Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199 Priority: P5 - low Change sponsored?: --- Bug ID: 8199 Assignee: oleonard at myacpl.org Summary: Search results are contained into a table html element Severity: enhancement Classification: Unclassified OS: All Reporter: jonathan.druart at biblibre.com Hardware: All Status: NEW Version: unspecified Component: Templates Product: Koha It would be better to change the structure of opac-results.tt and catalogue/results.tt by replacing "table" elements with a more ergonomic structure (like div, span, etc.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 16:29:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 14:29:35 +0000 Subject: [Koha-bugs] [Bug 8199] Search results are contained into a table html element In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard at myacpl.org |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 16:32:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 14:32:26 +0000 Subject: [Koha-bugs] [Bug 8199] Search results are contained into a table html element In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199 --- Comment #1 from Jonathan Druart --- Created attachment 9956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9956&action=edit Bug 8199 : Replace table in opac-results with div Test plan: launch a query from your opac search form and compare results before and after applying this patch. Normally, You don't show a lot of differences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 16:35:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 14:35:23 +0000 Subject: [Koha-bugs] [Bug 8199] Search results are contained into a table html element In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #2 from Jonathan Druart --- This patch is a first draft. I would like to have feed back about this patch before to continue (and to adapt to catalogue/results.tt) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 17:12:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 15:12:10 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 --- Comment #75 from Nicole C. Engard --- Can you please submit these as patches to the manual as well? Otherwise in 3.10 the help files will lose these updates because the help files come right from the manual. Thanks Nicole -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 17:27:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 15:27:04 +0000 Subject: [Koha-bugs] [Bug 8200] New: /home/chris/git/koha.git in /usr/share/koha/misc/translator/update.pl Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8200 Priority: P5 - low Change sponsored?: --- Bug ID: 8200 Assignee: gmcharlt at gmail.com Summary: /home/chris/git/koha.git in /usr/share/koha/misc/translator/update.pl Severity: trivial Classification: Unclassified OS: All Reporter: mtompset at hotmail.com Hardware: All Status: NEW Version: rel_3_6 Component: Command-line Utilities Product: Koha Obviously such a hard coded path is BAD. However, I was just informed on the IRC channel by jcamins that this is deprecated. In which case, this directory needs to be cleaned up, by at least deleting this file. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 17:39:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 15:39:39 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9765|0 |1 is obsolete| | Attachment #9766|0 |1 is obsolete| | Attachment #9767|0 |1 is obsolete| | --- Comment #9 from Jared Camins-Esakov --- Created attachment 9957 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9957&action=edit Bug 6557: Syspref to control total issue counting Because updating the total issues count associated with a bibliographic record on issue could cause a significant load on the server, this commit adds the syspref UpdateTotalIssuesOnCirc (which defaults to OFF to match existing behavior). The syspref has the following description: Do/Do not update a bibliographic record's total issues count whenever an item is issued (WARNING! This increases server load significantly; if performance is a concern, use the update_totalissues.pl cron job to update the total issues count). This patch to Koha was sponsored by the Arcadia Public Library and the Arcadia Public Library Foundation in honor of Jackie Faust-Moreno, late director of the Arcadia Public Library. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 17:39:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 15:39:50 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 --- Comment #10 from Jared Camins-Esakov --- Created attachment 9958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9958&action=edit Bug 6557: automatically increment totalissues Adds the ability to automatically increment biblioitems.totalissues whenever an item is issued. To test: 1) Choose a record with at least one item that can circulate 2) Check the value of 942$0 (you may need to look at the plain MARC view on the OPAC). Most likely there won't be any 942$0 at all 3) Enable UpdateTotalIssuesOnCirc 4) Check out the item you selected 5) Check the value of 942$0 (you may need to look at the plain MARC view on the OPAC). That value should now be one greater than before 6) Discharge the item 7) Disable UpdateTotalIssuesOnCirc 8) Check out the item you selected again 9) Check the value of 942$0 (you may need to look at the plain MARC view on the OPAC). That value should not have changed This patch to Koha was sponsored by the Arcadia Public Library and the Arcadia Public Library Foundation in honor of Jackie Faust-Moreno, late director of the Arcadia Public Library. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 17:40:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 15:40:01 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 --- Comment #11 from Jared Camins-Esakov --- Created attachment 9959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9959&action=edit Bug 6557: add script to update totalissues from stats NAME update_totalissues.pl SYNOPSIS update_totalissues.pl --use-stats update_totalissues.pl --use-items update_totalissues.pl --commit=1000 update_totalissues.pl --since='2012-01-01' update_totalissues.pl --interval=30d DESCRIPTION This batch job populates bibliographic records' total issues count based on historical issue statistics. --help Prints this help -v|--verbose Provide verbose log information (list every bib modified). --use-stats Use the data in the statistics table for populating total issues. --use-items Use items.issues data for populating total issues. Note that issues data from the items table does not respect the --since or --interval options, by definition. Also note that if both --use-stats and --use-items are specified, the count of biblios processed will be misleading. -s|--since=DATE Only process issues recorded in the statistics table since DATE. -i|--interval=S Only process issues recorded in the statistics table in the last N units of time. The interval should consist of a number with a one-letter unit suffix. The valid suffixes are h (hours), d (days), w (weeks), m (months), and y (years). The default unit is days. --incremental Add the number of issues found in the statistics table to the existing total issues count. Intended so that this script can be used as a cron job to update popularity information during low-usage periods. --commit=N Commit the results to the database after every N records are processed. --test Only test the popularity population script. === TESTING PLAN === NOTE: in order to test this script, you will need to have some sort of circulation data already existing in your Koha installation. 1) Disable UpdateTotalIssuesOnCirc 2) Run: misc/cronjobs/update_totalissues.pl --use-items -t -v 3) If you have total checkout data in your item records (i.e. anything in 952$l), you should see messages like "Processing bib 43 (1 issues)" 4) Choose one of the lines that shows more than 0 issues, and view the record with that biblionumber in the staff client, choosing the "Items" tab (moredetail.pl). Add up the "Total checkouts" listed for each item, and confirm it matches what the script reported 5) Run: misc/cronjobs/update_totalissues.pl --use-stats -t -v 6) If you have any circulation statistics in your database (i.e. any 'issue' entries in your statistics table), you should see messages like "Processing bib 43 (1 issues)"; 7) Choose one of the lines and view the record with that biblionumber in the staff client, choosing the "Items" tab (moredetail.pl). If you count the number of checkouts listed in each item's checkout history, the total should match what the script reported. 8) Check out an item 9) Run: misc/cronjobs/update_totalissues.pl --use-stats --since=1h -t -v 10) You should see one line reporting a single circ for the bib record associated with the item you just checked out (there may be more if you checked out any books in the hour prior to running these tests 11) If the results in steps 4, 7, and 10 match the predictions, the script worked This patch to Koha was sponsored by the Arcadia Public Library and the Arcadia Public Library Foundation in honor of Jackie Faust-Moreno, late director of the Arcadia Public Library. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 17:40:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 15:40:16 +0000 Subject: [Koha-bugs] [Bug 7961] Local cover images should support CSV link files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7961 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9796|0 |1 is obsolete| | --- Comment #7 from Dobrica Pavlinusic --- Created attachment 9960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9960&action=edit Bug 7961 - Local cover images should support CSV link files Corrent code doesn't have support for filenames which contain spaces or commans which breaks CSV files saved from spreadsheet similar to: 12345, "conver image, with spaces.jpg" This patch tweaks file parsing a bit. We are always splitting line to only two values (to support commas as part of filename) and removing spaces only on beginning and end of filename (to cover space after comma in CSV example above while preserving spaces in filename). With this change only invalid character in picture filename left are quotes (") which are commonly used to quote strings with spaces. Covers added will be logged in action_log, using CATALOGUING / MODIFY action (which is shown as "Catalog" in tools > Log viewer) Test scenario: 1. collect pictures with spaces and commas in name 2. dump file list into CSV file and add biblio number as first column (name of file is idlink.txt or datalink.txt) 3. create zip with CSV file and pictures 4. verify that all pictures got uploaded and linked to biblio records 5. verify that modification log includes cover image name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 17:41:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 15:41:43 +0000 Subject: [Koha-bugs] [Bug 7961] Local cover images should support CSV link files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7961 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 17:49:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 15:49:13 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9959|0 |1 is obsolete| | --- Comment #12 from Jared Camins-Esakov --- Created attachment 9961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9961&action=edit Bug 6557: add script to update totalissues from stats NAME update_totalissues.pl SYNOPSIS update_totalissues.pl --use-stats update_totalissues.pl --use-items update_totalissues.pl --commit=1000 update_totalissues.pl --since='2012-01-01' update_totalissues.pl --interval=30d DESCRIPTION This batch job populates bibliographic records' total issues count based on historical issue statistics. --help Prints this help -v|--verbose Provide verbose log information (list every bib modified). --use-stats Use the data in the statistics table for populating total issues. --use-items Use items.issues data for populating total issues. Note that issues data from the items table does not respect the --since or --interval options, by definition. Also note that if both --use-stats and --use-items are specified, the count of biblios processed will be misleading. -s|--since=DATE Only process issues recorded in the statistics table since DATE. -i|--interval=S Only process issues recorded in the statistics table in the last N units of time. The interval should consist of a number with a one-letter unit suffix. The valid suffixes are h (hours), d (days), w (weeks), m (months), and y (years). The default unit is days. --incremental Add the number of issues found in the statistics table to the existing total issues count. Intended so that this script can be used as a cron job to update popularity information during low-usage periods. --commit=N Commit the results to the database after every N records are processed. --test Only test the popularity population script. === TESTING PLAN === NOTE: in order to test this script, you will need to have some sort of circulation data already existing in your Koha installation. 1) Disable UpdateTotalIssuesOnCirc 2) Run: misc/cronjobs/update_totalissues.pl --use-items -t -v 3) If you have total checkout data in your item records (i.e. anything in 952$l), you should see messages like "Processing bib 43 (1 issues)" 4) Choose one of the lines that shows more than 0 issues, and view the record with that biblionumber in the staff client, choosing the "Items" tab (moredetail.pl). Add up the "Total checkouts" listed for each item, and confirm it matches what the script reported 5) Run: misc/cronjobs/update_totalissues.pl --use-stats -t -v 6) If you have any circulation statistics in your database (i.e. any 'issue' entries in your statistics table), you should see messages like "Processing bib 43 (1 issues)"; 7) Choose one of the lines and view the record with that biblionumber in the staff client, choosing the "Items" tab (moredetail.pl). If you count the number of checkouts listed in each item's checkout history, the total should match what the script reported. 8) Check out an item 9) Run: misc/cronjobs/update_totalissues.pl --use-stats --incremental --since=1h -t -v 10) You should see one line reporting a single circ for the bib record associated with the item you just checked out (there may be more if you checked out any books in the hour prior to running these tests 11) If the results in steps 4, 7, and 10 match the predictions, the script worked This patch to Koha was sponsored by the Arcadia Public Library and the Arcadia Public Library Foundation in honor of Jackie Faust-Moreno, late director of the Arcadia Public Library. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 18:05:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 16:05:35 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9961|0 |1 is obsolete| | --- Comment #13 from Jared Camins-Esakov --- Created attachment 9962 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9962&action=edit Bug 6557: add script to update totalissues from stats NAME update_totalissues.pl SYNOPSIS update_totalissues.pl --use-stats update_totalissues.pl --use-items update_totalissues.pl --commit=1000 update_totalissues.pl --since='2012-01-01' update_totalissues.pl --interval=30d DESCRIPTION This batch job populates bibliographic records' total issues count based on historical issue statistics. --help Prints this help -v|--verbose Provide verbose log information (list every bib modified). --use-stats Use the data in the statistics table for populating total issues. --use-items Use items.issues data for populating total issues. Note that issues data from the items table does not respect the --since or --interval options, by definition. Also note that if both --use-stats and --use-items are specified, the count of biblios processed will be misleading. -s|--since=DATE Only process issues recorded in the statistics table since DATE. -i|--interval=S Only process issues recorded in the statistics table in the last N units of time. The interval should consist of a number with a one-letter unit suffix. The valid suffixes are h (hours), d (days), w (weeks), m (months), and y (years). The default unit is days. --incremental Add the number of issues found in the statistics table to the existing total issues count. Intended so that this script can be used as a cron job to update popularity information during low-usage periods. --commit=N Commit the results to the database after every N records are processed. --test Only test the popularity population script. === TESTING PLAN === NOTE: in order to test this script, you will need to have some sort of circulation data already existing in your Koha installation. 1) Disable UpdateTotalIssuesOnCirc 2) Run: misc/cronjobs/update_totalissues.pl --use-items -t -v 3) If you have total checkout data in your item records (i.e. anything in 952$l), you should see messages like "Processing bib 43 (1 issues)" 4) Choose one of the lines that shows more than 0 issues, and view the record with that biblionumber in the staff client, choosing the "Items" tab (moredetail.pl). Add up the "Total checkouts" listed for each item, and confirm it matches what the script reported 5) Run: misc/cronjobs/update_totalissues.pl --use-stats -t -v 6) If you have any circulation statistics in your database (i.e. any 'issue' entries in your statistics table), you should see messages like "Processing bib 43 (1 issues)"; 7) Choose one of the lines and view the record with that biblionumber in the staff client, choosing the "Items" tab (moredetail.pl). If you count the number of checkouts listed in each item's checkout history, the total should match what the script reported. 8) Check out an item 9) Run: misc/cronjobs/update_totalissues.pl --use-stats --incremental --since=1h -t -v 10) You should see one line reporting a single circ for the bib record associated with the item you just checked out (there may be more if you checked out any books in the hour prior to running these tests 11) If the results in steps 4, 7, and 10 match the predictions, the script worked This patch to Koha was sponsored by the Arcadia Public Library and the Arcadia Public Library Foundation in honor of Jackie Faust-Moreno, late director of the Arcadia Public Library. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 18:22:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 16:22:20 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9962|0 |1 is obsolete| | --- Comment #14 from Jared Camins-Esakov --- Created attachment 9963 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9963&action=edit Bug 6557: add script to update totalissues from stats NAME update_totalissues.pl SYNOPSIS update_totalissues.pl --use-stats update_totalissues.pl --use-items update_totalissues.pl --commit=1000 update_totalissues.pl --since='2012-01-01' update_totalissues.pl --interval=30d DESCRIPTION This batch job populates bibliographic records' total issues count based on historical issue statistics. --help Prints this help -v|--verbose Provide verbose log information (list every bib modified). --use-stats Use the data in the statistics table for populating total issues. --use-items Use items.issues data for populating total issues. Note that issues data from the items table does not respect the --since or --interval options, by definition. Also note that if both --use-stats and --use-items are specified, the count of biblios processed will be misleading. -s|--since=DATE Only process issues recorded in the statistics table since DATE. -i|--interval=S Only process issues recorded in the statistics table in the last N units of time. The interval should consist of a number with a one-letter unit suffix. The valid suffixes are h (hours), d (days), w (weeks), m (months), and y (years). The default unit is days. --incremental Add the number of issues found in the statistics table to the existing total issues count. Intended so that this script can be used as a cron job to update popularity information during low-usage periods. --commit=N Commit the results to the database after every N records are processed. --test Only test the popularity population script. === TESTING PLAN === NOTE: in order to test this script, you will need to have some sort of circulation data already existing in your Koha installation. 1) Disable UpdateTotalIssuesOnCirc 2) Run: misc/cronjobs/update_totalissues.pl --use-items -t -v 3) If you have total checkout data in your item records (i.e. anything in 952$l), you should see messages like "Processing bib 43 (1 issues)" 4) Choose one of the lines that shows more than 0 issues, and view the record with that biblionumber in the staff client, choosing the "Items" tab (moredetail.pl). Add up the "Total checkouts" listed for each item, and confirm it matches what the script reported 5) Run: misc/cronjobs/update_totalissues.pl --use-stats -t -v 6) If you have any circulation statistics in your database (i.e. any 'issue' entries in your statistics table), you should see messages like "Processing bib 43 (1 issues)"; 7) Choose one of the lines and view the record with that biblionumber in the staff client, choosing the "Items" tab (moredetail.pl). If you count the number of checkouts listed in each item's checkout history, the total should match what the script reported. 8) Check out an item 9) Run: misc/cronjobs/update_totalissues.pl --use-stats --incremental --interval=1h -t -v 10) You should see one line reporting a single circ for the bib record associated with the item you just checked out (there may be more if you checked out any books in the hour prior to running these tests 11) If the results in steps 4, 7, and 10 match the predictions, the script worked NOTE: The --interval argument takes an interval identifier like "1h" and the --since argument takes an actual date like "2012-06-06 12:00:00". Also note that if the time on your database server does not match the time on your Koha server, you will need to adjust the intervals. This patch to Koha was sponsored by the Arcadia Public Library and the Arcadia Public Library Foundation in honor of Jackie Faust-Moreno, late director of the Arcadia Public Library. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 18:24:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 16:24:04 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9963|0 |1 is obsolete| | --- Comment #15 from Jared Camins-Esakov --- Created attachment 9964 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9964&action=edit Bug 6557: add script to update totalissues from stats NAME update_totalissues.pl SYNOPSIS update_totalissues.pl --use-stats update_totalissues.pl --use-items update_totalissues.pl --commit=1000 update_totalissues.pl --since='2012-01-01' update_totalissues.pl --interval=30d DESCRIPTION This batch job populates bibliographic records' total issues count based on historical issue statistics. --help Prints this help -v|--verbose Provide verbose log information (list every bib modified). --use-stats Use the data in the statistics table for populating total issues. --use-items Use items.issues data for populating total issues. Note that issues data from the items table does not respect the --since or --interval options, by definition. Also note that if both --use-stats and --use-items are specified, the count of biblios processed will be misleading. -s|--since=DATE Only process issues recorded in the statistics table since DATE. -i|--interval=S Only process issues recorded in the statistics table in the last N units of time. The interval should consist of a number with a one-letter unit suffix. The valid suffixes are h (hours), d (days), w (weeks), m (months), and y (years). The default unit is days. --incremental Add the number of issues found in the statistics table to the existing total issues count. Intended so that this script can be used as a cron job to update popularity information during low-usage periods. --commit=N Commit the results to the database after every N records are processed. --test Only test the popularity population script. === TESTING PLAN === NOTE: in order to test this script, you will need to have some sort of circulation data already existing in your Koha installation. 1) Disable UpdateTotalIssuesOnCirc 2) Run: misc/cronjobs/update_totalissues.pl --use-items -t -v 3) If you have total checkout data in your item records (i.e. anything in 952$l), you should see messages like "Processing bib 43 (1 issues)" 4) Choose one of the lines that shows more than 0 issues, and view the record with that biblionumber in the staff client, choosing the "Items" tab (moredetail.pl). Add up the "Total checkouts" listed for each item, and confirm it matches what the script reported 5) Run: misc/cronjobs/update_totalissues.pl --use-stats -t -v 6) If you have any circulation statistics in your database (i.e. any 'issue' entries in your statistics table), you should see messages like "Processing bib 43 (1 issues)"; 7) Choose one of the lines and view the record with that biblionumber in the staff client, choosing the "Items" tab (moredetail.pl). If you count the number of checkouts listed in each item's checkout history, the total should match what the script reported. 8) Check out an item 9) Run: misc/cronjobs/update_totalissues.pl --use-stats --incremental --interval=1h -t -v 10) You should see one line reporting a single circ for the bib record associated with the item you just checked out (there may be more if you checked out any books in the hour prior to running these tests 11) If the results in steps 4, 7, and 10 match the predictions, the script worked NOTE: The --interval argument takes an interval identifier like "1h" and the --since argument takes an actual date like "2012-06-06 12:00:00". Also note that if the time on your database server does not match the time on your Koha server, you will need to adjust the intervals. This patch to Koha was sponsored by the Arcadia Public Library and the Arcadia Public Library Foundation in honor of Jackie Faust-Moreno, late director of the Arcadia Public Library. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 18:37:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 16:37:06 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9964|0 |1 is obsolete| | --- Comment #16 from Jared Camins-Esakov --- Created attachment 9965 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9965&action=edit Bug 6557: add script to update totalissues from stats NAME update_totalissues.pl SYNOPSIS update_totalissues.pl --use-stats update_totalissues.pl --use-items update_totalissues.pl --commit=1000 update_totalissues.pl --since='2012-01-01' update_totalissues.pl --interval=30d DESCRIPTION This batch job populates bibliographic records' total issues count based on historical issue statistics. --help Prints this help -v|--verbose Provide verbose log information (list every bib modified). --use-stats Use the data in the statistics table for populating total issues. --use-items Use items.issues data for populating total issues. Note that issues data from the items table does not respect the --since or --interval options, by definition. Also note that if both --use-stats and --use-items are specified, the count of biblios processed will be misleading. -s|--since=DATE Only process issues recorded in the statistics table since DATE. -i|--interval=S Only process issues recorded in the statistics table in the last N units of time. The interval should consist of a number with a one-letter unit suffix. The valid suffixes are h (hours), d (days), w (weeks), m (months), and y (years). The default unit is days. --incremental Add the number of issues found in the statistics table to the existing total issues count. Intended so that this script can be used as a cron job to update popularity information during low-usage periods. If neither --since or --interval are specified, incremental mode will default to processing the last twenty-four hours. --commit=N Commit the results to the database after every N records are processed. --test Only test the popularity population script. WARNING If the time on your database server does not match the time on your Koha server you will need to take that into account, and probably use the --since argument instead of the --interval argument for incremental updating. === TESTING PLAN === NOTE: in order to test this script, you will need to have some sort of circulation data already existing in your Koha installation. 1) Disable UpdateTotalIssuesOnCirc 2) Run: misc/cronjobs/update_totalissues.pl --use-items -t -v 3) If you have total checkout data in your item records (i.e. anything in 952$l), you should see messages like "Processing bib 43 (1 issues)" 4) Choose one of the lines that shows more than 0 issues, and view the record with that biblionumber in the staff client, choosing the "Items" tab (moredetail.pl). Add up the "Total checkouts" listed for each item, and confirm it matches what the script reported 5) Run: misc/cronjobs/update_totalissues.pl --use-stats -t -v 6) If you have any circulation statistics in your database (i.e. any 'issue' entries in your statistics table), you should see messages like "Processing bib 43 (1 issues)"; 7) Choose one of the lines and view the record with that biblionumber in the staff client, choosing the "Items" tab (moredetail.pl). If you count the number of checkouts listed in each item's checkout history, the total should match what the script reported. 8) Check out an item 9) Run: misc/cronjobs/update_totalissues.pl --use-stats --incremental --interval=1h -t -v 10) You should see one line reporting a single circ for the bib record associated with the item you just checked out (there may be more if you checked out any books in the hour prior to running these tests 11) If the results in steps 4, 7, and 10 match the predictions, the script worked This patch to Koha was sponsored by the Arcadia Public Library and the Arcadia Public Library Foundation in honor of Jackie Faust-Moreno, late director of the Arcadia Public Library. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 18:47:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 16:47:02 +0000 Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #28 from Paul Poulain --- I've tested this patch, and after some pain understanding which files I must put where, I succeded. Just a comment, I get a nasty error when using the -x flag: 18:22 ~/koha.dev/installs/lecannetdesmaures/etc$ ~/koha.dev/koha-community/misc/migration_tools/rebuild_zebra.pl -b -v -x --offset=100 --length=10 -r Entity: line 84: parser error : Extra content at the end of the document References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 --- Comment #17 from Liz Rea --- Created attachment 9966 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9966&action=edit Bug 6557: Syspref to control total issue counting Because updating the total issues count associated with a bibliographic record on issue could cause a significant load on the server, this commit adds the syspref UpdateTotalIssuesOnCirc (which defaults to OFF to match existing behavior). The syspref has the following description: Do/Do not update a bibliographic record's total issues count whenever an item is issued (WARNING! This increases server load significantly; if performance is a concern, use the update_totalissues.pl cron job to update the total issues count). Bug 6557: automatically increment totalissues Adds the ability to automatically increment biblioitems.totalissues whenever an item is issued. To test: 1) Choose a record with at least one item that can circulate 2) Check the value of 942$0 (you may need to look at the plain MARC view on the OPAC). Most likely there won't be any 942$0 at all 3) Enable UpdateTotalIssuesOnCirc 4) Check out the item you selected 5) Check the value of 942$0 (you may need to look at the plain MARC view on the OPAC). That value should now be one greater than before 6) Discharge the item 7) Disable UpdateTotalIssuesOnCirc 8) Check out the item you selected again 9) Check the value of 942$0 (you may need to look at the plain MARC view on the OPAC). That value should not have changed Bug 6557: add script to update totalissues from stats NAME update_totalissues.pl SYNOPSIS update_totalissues.pl --use-stats update_totalissues.pl --use-items update_totalissues.pl --commit=1000 update_totalissues.pl --since='2012-01-01' update_totalissues.pl --interval=30d DESCRIPTION This batch job populates bibliographic records' total issues count based on historical issue statistics. --help Prints this help -v|--verbose Provide verbose log information (list every bib modified). --use-stats Use the data in the statistics table for populating total issues. --use-items Use items.issues data for populating total issues. Note that issues data from the items table does not respect the --since or --interval options, by definition. Also note that if both --use-stats and --use-items are specified, the count of biblios processed will be misleading. -s|--since=DATE Only process issues recorded in the statistics table since DATE. -i|--interval=S Only process issues recorded in the statistics table in the last N units of time. The interval should consist of a number with a one-letter unit suffix. The valid suffixes are h (hours), d (days), w (weeks), m (months), and y (years). The default unit is days. --incremental Add the number of issues found in the statistics table to the existing total issues count. Intended so that this script can be used as a cron job to update popularity information during low-usage periods. If neither --since or --interval are specified, incremental mode will default to processing the last twenty-four hours. --commit=N Commit the results to the database after every N records are processed. --test Only test the popularity population script. WARNING If the time on your database server does not match the time on your Koha server you will need to take that into account, and probably use the --since argument instead of the --interval argument for incremental updating. === TESTING PLAN === NOTE: in order to test this script, you will need to have some sort of circulation data already existing in your Koha installation. 1) Disable UpdateTotalIssuesOnCirc 2) Run: misc/cronjobs/update_totalissues.pl --use-items -t -v 3) If you have total checkout data in your item records (i.e. anything in 952$l), you should see messages like "Processing bib 43 (1 issues)" 4) Choose one of the lines that shows more than 0 issues, and view the record with that biblionumber in the staff client, choosing the "Items" tab (moredetail.pl). Add up the "Total checkouts" listed for each item, and confirm it matches what the script reported 5) Run: misc/cronjobs/update_totalissues.pl --use-stats -t -v 6) If you have any circulation statistics in your database (i.e. any 'issue' entries in your statistics table), you should see messages like "Processing bib 43 (1 issues)"; 7) Choose one of the lines and view the record with that biblionumber in the staff client, choosing the "Items" tab (moredetail.pl). If you count the number of checkouts listed in each item's checkout history, the total should match what the script reported. 8) Check out an item 9) Run: misc/cronjobs/update_totalissues.pl --use-stats --incremental --interval=1h -t -v 10) You should see one line reporting a single circ for the bib record associated with the item you just checked out (there may be more if you checked out any books in the hour prior to running these tests 11) If the results in steps 4, 7, and 10 match the predictions, the script worked This patch to Koha was sponsored by the Arcadia Public Library and the Arcadia Public Library Foundation in honor of Jackie Faust-Moreno, late director of the Arcadia Public Library. Signed-off-by: Liz Rea Tested this with my test data - numbers are correct and updated appropriately. More importantly - if I do a popularity search, the most popular items *come up first*. Amazing. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 18:51:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 16:51:03 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9965|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 18:51:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 16:51:10 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 19:45:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 17:45:07 +0000 Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 --- Comment #29 from Paul Poulain --- I can't make it work properly, so I need to understand what I made wrong... Here are the steps I followed on an existing (UNIMARC) setup: * Edit etc/zebradb/zebra-biblios.cfg file: - update profilePath: line by appending xsl path: :$KOHA/etc/zebradb/xsl - comment the following line: marcxml.recordType:grs.sgml - add after the commented line: recordtype: dom.$KOHA/etc/zebradb/biblios/etc/dom-config.xml marcxml.recordtype: dom.$KOHA/etc/zebradb/biblios/etc/dom-config.xml iso2709.recordtype: dom.$KOHA/etc/zebradb/biblios/etc/dom-config-marc.xml - if your $KOHA setup is not where your koha code is, you must copy 2 new files: cp $KOHAGIT/etc/zebradb/biblios/etc/*.xml $KOHA/etc/zebradb/biblios/etc/ - generate xsl configuration: $KOHA/misc/maintenance/make_zebra_dom_cfg_from_record_abs --input $ZEBRADIR/zebradb/marc_defs/unimarc/biblios/record.abs --output $ZEBRADIR/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xml xsltproc $ZEBRADIR/etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl $ZEBRADIR/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xml >zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl Once I've made that, if I try to reindex: 19:41 ~/koha.dev/installs/koha-community/etc$ ~/koha.dev/koha-community/misc/migration_tools/rebuild_zebra.pl -b -v --offset=0 --length=10 -r -x -k Zebra configuration information ================================ Zebra biblio directory = /home/paul/koha.dev/installs/koha-community/var/lib/zebradb/biblios Zebra authorities directory = /home/paul/koha.dev/installs/koha-community/var/lib/zebradb/authorities Koha directory = /home/paul/koha.dev/koha-community BIBLIONUMBER in : 001$@ BIBLIOITEMNUMBER in : 090$a ================================ skipping authorities ==================== exporting biblio ==================== 1......... Records exported: 10 ==================== REINDEXING zebra ==================== Entity: line 741: parser error : Extra content at the end of the document References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 --- Comment #30 from Paul Poulain --- Trying the -x and --nosanitize flags, I get another error: 19:55 ~/koha.dev/installs/koha-community/etc$ ~/koha.dev/koha-community/misc/migration_tools/rebuild_zebra.pl -b -v --offset=0 --length=10 -r -x -k --nosanitize Zebra configuration information ==================== REINDEXING zebra ==================== Entity: line 742: parser error : XML declaration allowed only at the start of the document ^ 19:55:27-06/06 zebraidx(13014) [warn] extract error: generic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 20:08:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 18:08:01 +0000 Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 --- Comment #31 from Fr?d?ric Demians --- > 18:22 ~/koha.dev/installs/lecannetdesmaures/etc$ > ~/koha.dev/koha-community/misc/migration_tools/rebuild_zebra.pl -b -v > -x --offset=100 --length=10 -r Entity: line 84: parser error : Extra > content at the end of the document I think it means that the file containing the exported marcxml biblio is not a valid XML file. is missing. Try to add it by hand, and reindex directly with zebraidx. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 21:26:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 19:26:50 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.sekjal at gmail.com --- Comment #18 from Ian Walls --- UpdateTotalIssues() has an avoidable inefficiency: it calls both GetBiblioData, and GetMarcBiblio. GetBiblioData returns all columns from biblio, biblioitems and itemtypes. We only need biblio.frameworkcode, biblioitems.totalissues and the $record (which can be obtained from biblioitems.marcxml). Additionally, the call from C4/Circulation to UpdateTotalIssues() occurs in AddIssue, which already has a copy of the biblio pulled in from a call to GetBiblioFromItemnumber (biblioitems.marc and biblioitems.marcxml). So we already have all the data we need in AddIssues to do the update; it would just be a matter of creating the MARC::Record object and doing a ModBiblio to update the right field. Modifying the cronjob to also return the MARC record and frameworkcode would let both means interface with the subroutine, so the library can still decide whether to take the slightened performance hit (or build from stats the first time). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 23:05:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 21:05:40 +0000 Subject: [Koha-bugs] [Bug 7063] Add available perl packages for Debian in install_misc/debian.packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7063 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |magnus at enger.priv.no Resolution|--- |FIXED --- Comment #3 from Magnus Enger --- Works in master, as far as I can tell. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 6 23:27:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Jun 2012 21:27:40 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 --- Comment #76 from Jared Camins-Esakov --- Created attachment 9967 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9967&action=edit Bug 7936 followup: Copyediting Help Files Copyedited Admin Help Files beginning with the letter "a." Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 05:51:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 03:51:41 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|navya.vp at osslabs.biz |amit.gupta at osslabs.biz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 05:52:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 03:52:12 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs at lists.koha-commun |koha.sekjal at gmail.com |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 05:52:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 03:52:23 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 10:01:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 08:01:34 +0000 Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 --- Comment #32 from Fr?d?ric Demians --- Created attachment 9968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9968&action=edit Bug 7818 Fix rebuild_zebra.pl --nosanitize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 10:51:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 08:51:14 +0000 Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 --- Comment #33 from Paul Poulain --- (In reply to comment #31) > > 18:22 ~/koha.dev/installs/lecannetdesmaures/etc$ > > ~/koha.dev/koha-community/misc/migration_tools/rebuild_zebra.pl -b -v > > -x --offset=100 --length=10 -r Entity: line 84: parser error : Extra > > content at the end of the document > > I think it means that the file containing the exported marcxml biblio is > not a valid XML file. is missing. Try to add > it by hand, and reindex directly with zebraidx. OK, seems you're right Frederic: zebraidx -c /home/paul/koha.dev/installs/koha-community/etc/zebradb/zebra-biblios.cfg -g marcxml -d biblios update /tmp/kUzN0iLpkp/biblio/ => without changing anything to /tmp/kUzN0iLpkp/biblio/ I get Entity: line 741: parser error : Extra content at the end of the document after adding and I get: 20:20:26-06/06 zebraidx(13208) [log] update dom./home/paul/koha.dev/installs/koha-community/etc/zebradb/biblios/etc/dom-config.xml /tmp/kUzN0iLpkp/biblio/exported_records 102404 20:20:26-06/06 zebraidx(13208) [log] Iterations: isam/dict 1808/1803 20:20:26-06/06 zebraidx(13208) [log] Dict: inserts/updates/deletions: 901/0/902 20:20:27-06/06 zebraidx(13208) [log] Records: 10 i/u/d 0/10/0 So the NEXT QUESTION is = why is'nt the included automatically (as it used to be) Looking at the code, it's clearly related to sub include_xml_wrapper {} This sub should return 1 and return 0. It should return 1 from this line: return 1 if $record_type eq 'biblio' and $bib_index_mode eq 'dom'; The $bib_index_mode is set by: my $bib_index_mode = C4::Context->config('zebra_bib_index_mode') || 'grs1'; looking at my configuration file... There is no __BIB_INDEX_MODE__ adding it.... and it works, with the exception of a warning i'll investigate later, but if you have an idea, let me know ! 20:27:55-06/06 zebraidx(13358) [warn] Unknown register type: (nothing after the "register type:") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 12:22:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 10:22:47 +0000 Subject: [Koha-bugs] [Bug 8187] Batch patron modification missing from tools sidebar menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8187 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 12:46:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 10:46:16 +0000 Subject: [Koha-bugs] [Bug 8098] DataTables in Acquisision module: parcel.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8098 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9604|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 9969 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9969&action=edit parcel.tt Rebased patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 12:48:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 10:48:29 +0000 Subject: [Koha-bugs] [Bug 8201] New: can't change receive date Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8201 Priority: P5 - low Change sponsored?: --- Bug ID: 8201 Assignee: henridamien at koha-fr.org Summary: can't change receive date Severity: major Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha When receiving a shipment you can enter the invoice date. I entered a date in the past and it showed that date after hitting submit, but after I receive one item it changes the date back to today's date instead. The date needs to stay set to what the librarian sets - not change to anything else. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 12:50:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 10:50:14 +0000 Subject: [Koha-bugs] [Bug 8201] can't change receive date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8201 --- Comment #1 from Nicole C. Engard --- More: http://screencast.com/t/fegwGMZ3WzQ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 12:56:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 10:56:01 +0000 Subject: [Koha-bugs] [Bug 6874] File upload in MARC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger at biblibr | |e.com --- Comment #26 from Matthias Meusburger --- I've tried to reproduce the bug described by Jared as well, but it did work correctly for me. Using /tmp, I had (root) and the only www-data writable directory (and it's subdirectories). Non www-data writable directories were hidden. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 12:56:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 10:56:21 +0000 Subject: [Koha-bugs] [Bug 8201] can't change receive date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8201 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- We had a library reporting this for 3.6.3 - didn't confirm it so far, but the report matches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 13:07:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 11:07:22 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9754|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart --- Created attachment 9970 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9970&action=edit Rebased patch Rebased patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 13:13:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 11:13:28 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #5 from Matthias Meusburger --- Hi Katrin, Which status are you referring too? (damaged, notforloan, lost, restricted, ?) -> notforloan I am not sure about the use case for limited_item_edition and items_limited_batchmod.[...] I agree with that. What if the user could define which fields have to be limited (or allowed, like in Bug 7412 :)) ? Would that be ok for you ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 13:50:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 11:50:33 +0000 Subject: [Koha-bugs] [Bug 8101] DataTables in Acquisision module: orderreceive.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8101 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9614|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart --- Created attachment 9971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9971&action=edit orderreceive.tt rebased patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 13:53:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 11:53:27 +0000 Subject: [Koha-bugs] [Bug 7986] Export issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9269|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart --- Created attachment 9972 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9972&action=edit Bug 7986: Export issues for patron Rebased patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 13:59:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 11:59:24 +0000 Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9170|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart --- Created attachment 9973 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9973&action=edit Bug 7919 : Display of values depending on the connexion librairy Display of values depending on the connexion librairy Rebased patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 14:03:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 12:03:01 +0000 Subject: [Koha-bugs] [Bug 7302] CSV export of a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7302 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9227|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 9974 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9974&action=edit Bug 7302 Export basketgroup as CSV rebased patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 14:24:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 12:24:09 +0000 Subject: [Koha-bugs] [Bug 8051] Makefile.PL needs a quiet mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8051 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Jared Camins-Esakov --- Yes there is: export PERL_MM_USE_DEFAULT=1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 14:31:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 12:31:49 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing addess improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9230|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 9975 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9975&action=edit Bug 5356: delivery place and billing place centralised in basket management Rebased patch. This patch must be applied AFTER Bug 7302 ! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 14:32:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 12:32:17 +0000 Subject: [Koha-bugs] [Bug 3462] Link see alsos in authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |jcamins at cpbibliography.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 14:33:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 12:33:14 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |jcamins at cpbibliography.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 14:34:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 12:34:25 +0000 Subject: [Koha-bugs] [Bug 8202] New: Add authorities to export tool Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Priority: P5 - low Change sponsored?: --- Bug ID: 8202 Assignee: jcamins at cpbibliography.com Summary: Add authorities to export tool Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: ASSIGNED Version: master Component: Tools Product: Koha Right now it is not possible to export authorities from the staff client. It should be possible to export authorities using the export tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 14:34:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 12:34:37 +0000 Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 14:35:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 12:35:50 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9168|0 |1 is obsolete| | --- Comment #25 from Jonathan Druart --- Created attachment 9976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9976&action=edit Bug 5342: Adds a claims_count field in the serial table rebased patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 14:36:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 12:36:50 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9169|0 |1 is obsolete| | --- Comment #26 from Jonathan Druart --- Created attachment 9977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9977&action=edit Bug 5342: Followup: Delete all occurrences of preview rebased patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 14:54:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 12:54:09 +0000 Subject: [Koha-bugs] [Bug 8203] New: Should be possible to save individual authorities Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8203 Priority: P5 - low Change sponsored?: --- Bug ID: 8203 Assignee: jcamins at cpbibliography.com Summary: Should be possible to save individual authorities Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: ASSIGNED Version: master Component: MARC Authority data support Product: Koha Right now there is no convenient way to save an individual authority record. I propose adding a Save button to the authority view in the staff client which allows records to be saved as MARC, MARCXML, and (at least for MARC21) MADS. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 14:54:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 12:54:37 +0000 Subject: [Koha-bugs] [Bug 8203] Should be possible to save individual authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8203 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8202 Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 14:54:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 12:54:37 +0000 Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8203 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 14:55:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 12:55:22 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Seeking cosponsors |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 14:56:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 12:56:50 +0000 Subject: [Koha-bugs] [Bug 5600] Bulk MARC biblio export script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger at biblibr | |e.com --- Comment #4 from Matthias Meusburger --- Jared, it's the case: the script tools/export.pl is accessible via CGI and command-line. I've tested this patch and both command-line and CGI worked for me. Can you give us more information about how it did not work for you ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 15:00:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 13:00:34 +0000 Subject: [Koha-bugs] [Bug 5600] Bulk MARC biblio export script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 --- Comment #5 from Jared Camins-Esakov --- Matthias, (In reply to comment #4) > Jared, it's the case: the script tools/export.pl is accessible via CGI and > command-line. > > I've tested this patch and both command-line and CGI worked for me. > > Can you give us more information about how it did not work for you ? I did not try the patch yet. I was going to test it, but when I took a look at the patch to see what it did, it looked like it turned the CGI script into a command-line script. If I misunderstood what it is supposed to do, that's excellent, and I will test and sign off. Sorry for the confusion! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 15:05:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 13:05:41 +0000 Subject: [Koha-bugs] [Bug 8204] New: Authority viewer in OPAC ugly, unfriendly, and mostly useless Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 Priority: P5 - low Change sponsored?: --- Bug ID: 8204 Assignee: jcamins at cpbibliography.com Summary: Authority viewer in OPAC ugly, unfriendly, and mostly useless Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: ASSIGNED Version: master Component: OPAC Product: Koha The authority viewer in the OPAC provides only an expanded MARC view of authority records, which is barely even of use to librarians, much less patrons. There should be an authority view more like the biblio details view, which provides friendly access to the information in authority records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 15:06:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 13:06:01 +0000 Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 15:06:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 13:06:35 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |jcamins at cpbibliography.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 15:28:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 13:28:05 +0000 Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 --- Comment #34 from Paul Poulain --- Trying to search, I get no results, but a nasty Can't call method "data" on an undefined value at /home/paul/koha.dev/koha-community/C4/Search.pm line 1496. Adding a warning in the code, I see: DUMP$VAR1 = bless( { '_fields' => [], '_leader' => ' ', '_warnings' => [ 'Record length "" is not numeric in record 1' ] }, 'MARC::Record' ); Adding the following lines that are missing in the koha-conf.xml: and after the The result is the same: zebra log file says: 12:27:16-07/06 zebrasrv(1) [session] Session - OK 1 unix:/home/paul/koha.dev/installs/lecannetdesmaures/var/run/zebradb/bibliosocket 19584 12:27:16-07/06 zebrasrv(1) [request] Auth idPass kohauser - 12:27:16-07/06 zebrasrv(1) [request] Init OK - ID:81 Name:ZOOM-C/YAZ Version:4.2.18 cc3abee6f861d0166bef5333b1fc72fbdc8bd94c 12:27:16-07/06 zebrasrv(1) [warn] Missing attribute 'type' in attribute info 12:27:16-07/06 zebrasrv(1) [warn] Missing attribute 'type' in attribute info 12:27:16-07/06 zebrasrv(1) [warn] Missing attribute 'type' in attribute info 12:27:16-07/06 zebrasrv(1) [warn] Missing attribute 'type' in attribute info 12:27:16-07/06 zebrasrv(1) [warn] Missing attribute 'type' in attribute info 12:27:16-07/06 zebrasrv(1) [warn] Missing attribute 'type' in attribute info 12:27:16-07/06 zebrasrv(1) [log] dict_lookup_grep: (\x01\x02)(j(e|\xC3\xA9|\xC3\xA8|\xC3\xAA|\xE1\xBA\xBD|\xC4\x95|\xC4\x99|\xC4\x97|\xC4\x9B|\xC8\x85|\xC8\x87)(a|\xC3\xA1|\xC3\xA0|\xC3\xA3|\xC3\xA5|\xC3\xA2|\xC4\x83|\xC4\x85|\xC8\xA7|\xC7\x8E|\xC8\x81|\xC8\x83)n) 12:27:16-07/06 zebrasrv(1) [request] Search biblios OK 1 1 1+0 RPN @attrset Bib-1 @attr 1=1016 @attr 4=6 jean 12:27:16-07/06 zebrasrv(1) [log] /home/paul/koha.dev/koha-community/etc/zebradb/biblios/etc/dom-config.xml dom filter: loading config file /home/paul/koha.dev/koha-community/etc/zebradb/biblios/etc/dom-config.xml 12:27:16-07/06 zebrasrv(1) [request] Present OK - 1 1+1 12:27:16-07/06 zebrasrv(1) [session] Connection closed by client Checking what zebrasrv says when you launch it, I see: I/O warning : failed to load external entity "/home/paul/koha.dev/installs/lecannetdesmaures/etc/zebradb/retrieval-info-bib-dom.xml" the file is not here, copying it at the right place (from $KOHA/etc/zebradb/) it works ! will summarize all my tests in a wiki page: "switching to DOM indexing when you have Koha already running" ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 15:29:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 13:29:54 +0000 Subject: [Koha-bugs] [Bug 8205] New: Should be possible to hide unused authorities in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205 Priority: P5 - low Change sponsored?: --- Bug ID: 8205 Assignee: jcamins at cpbibliography.com Summary: Should be possible to hide unused authorities in OPAC Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: ASSIGNED Version: master Component: OPAC Product: Koha For libraries which load complete authority files into their Koha installations, authority records which are not in use can overwhelm those that are in the "Browse subjects and authors" in the OPAC. I propose to add an OPACShowUnusedAuthorities system preference that can be set to "off" so that the display can be limited to only those authorities referenced in the bibliographic database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 15:30:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 13:30:01 +0000 Subject: [Koha-bugs] [Bug 8205] Should be possible to hide unused authorities in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 15:43:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 13:43:15 +0000 Subject: [Koha-bugs] [Bug 8206] New: Add additional search options to authority browser in OPAC Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 Priority: P5 - low Change sponsored?: --- Bug ID: 8206 Assignee: jcamins at cpbibliography.com Summary: Add additional search options to authority browser in OPAC Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: ASSIGNED Version: master Component: OPAC Product: Koha The OPAC authority browser used to have several boxes for the different types of authority searches that are possible. This was confusing to users, and rather ugly. However, the additional options were useful for libraries with massive authority files. I propose adding a dropdown to the authority search page on the OPAC which can be easily hidden using CSS, but offers the option to choose whether to look in main entries, headings, or anywhere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 15:43:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 13:43:26 +0000 Subject: [Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 15:56:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 13:56:41 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #6 from Katrin Fischer --- Hi Matthias, I think I would really like being able to configure a list of item fields for the permission. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 16:02:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 14:02:11 +0000 Subject: [Koha-bugs] [Bug 8207] New: Modify authority type frameworks to allow see also fields to link to thesauri Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8207 Priority: P5 - low Change sponsored?: --- Bug ID: 8207 Assignee: jcamins at cpbibliography.com Summary: Modify authority type frameworks to allow see also fields to link to thesauri Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: ASSIGNED Version: master Component: MARC Authority data support Product: Koha Right now if you were to link a field in an authority to a thesaurus, it will not work properly. The authority type frameworks require some adjustments to allow see also headings to be linked to thesauri (such as adding subfield $9). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 16:02:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 14:02:22 +0000 Subject: [Koha-bugs] [Bug 8207] Modify authority type frameworks to allow see also fields to link to thesauri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8207 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 16:19:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 14:19:25 +0000 Subject: [Koha-bugs] [Bug 8208] New: Add "create authority" button to auth_finder plugin Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8208 Priority: P5 - low Change sponsored?: --- Bug ID: 8208 Assignee: jcamins at cpbibliography.com Summary: Add "create authority" button to auth_finder plugin Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: ASSIGNED Version: master Component: Cataloging Product: Koha Right now if you want to link a heading to a new authority record, you have to either use BiblioAddsAuthorities to automatically generate the authority, or create a new authority in the authority module, and wait for the indexer to catch up. There should be a "create authority" button that -- like the fast add functionality in circ -- allows you to create an authority and immediately populate the heading. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 16:19:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 14:19:38 +0000 Subject: [Koha-bugs] [Bug 8208] Add "create authority" button to auth_finder plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8208 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 16:31:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 14:31:07 +0000 Subject: [Koha-bugs] [Bug 8209] New: "Did you mean?" suggestions based on authorities Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Priority: P5 - low Change sponsored?: --- Bug ID: 8209 Assignee: jcamins at cpbibliography.com Summary: "Did you mean?" suggestions based on authorities Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: ASSIGNED Version: master Component: Searching Product: Koha One of the ideas behind authority records is that users who search for one term should have related terms (according to the authority file) suggested to them. At the moment, Koha doesn't do that. Adding an authority searching step to regular searches and displaying any suggestions in a "Did you mean" bar at the top of the results would be very useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 16:31:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 14:31:54 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 16:37:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 14:37:10 +0000 Subject: [Koha-bugs] [Bug 8210] New: Headings in OPAC bib details should link to authority record Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Priority: P5 - low Change sponsored?: --- Bug ID: 8210 Assignee: jcamins at cpbibliography.com Summary: Headings in OPAC bib details should link to authority record Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: ASSIGNED Version: master Component: OPAC Depends on: 5888 Product: Koha There should be a link to used authority records from the bibliographic details display. This is already done in 5888 for the "normal" display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 16:37:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 14:37:10 +0000 Subject: [Koha-bugs] [Bug 5888] opac-detail subject/author links improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8210 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 16:50:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 14:50:16 +0000 Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8211 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 16:50:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 14:50:16 +0000 Subject: [Koha-bugs] [Bug 8211] New: Add "subject (broader), " "subject (narrower), " and "subject (related)" options for search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8211 Priority: P5 - low Change sponsored?: Sponsored Bug ID: 8211 Assignee: jcamins at cpbibliography.com Summary: Add "subject (broader)," "subject (narrower)," and "subject (related)" options for search Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: ASSIGNED Version: master Component: Searching Depends on: 7818 Product: Koha With the addition of DOM indexing, it is now possible to do "exploded" searches which search for records with broader, narrower, and other related headings by searching authorities for the specified term, then using authorities that match the specified criteria to do a more inclusive search for bib records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:01:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:01:21 +0000 Subject: [Koha-bugs] [Bug 3462] Link see alsos in authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:01:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:01:21 +0000 Subject: [Koha-bugs] [Bug 8212] New: Omnibus bug report for C & P authority developments Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8212 Priority: P5 - low Change sponsored?: --- Bug ID: 8212 Assignee: jcamins at cpbibliography.com Summary: Omnibus bug report for C & P authority developments Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: ASSIGNED Version: master Component: MARC Authority data support Depends on: 2060, 3462, 6720, 7417, 7418, 7419, 7475, 8202, 8203, 8204, 8205, 8206, 8207, 8208, 8209, 8210, 8211 Product: Koha This bug report serves to aggregate the various authority developments undertaken by C & P Bibliography Services, as well as closely-related bugs. I will close it once all the developments have been finished. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:01:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:01:21 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:01:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:01:21 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:01:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:01:21 +0000 Subject: [Koha-bugs] [Bug 7419] Add authority deduplication script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7419 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:01:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:01:21 +0000 Subject: [Koha-bugs] [Bug 7418] Add heading flipper script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7418 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:01:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:01:21 +0000 Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:01:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:01:21 +0000 Subject: [Koha-bugs] [Bug 7475] Option to overlay authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7475 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:01:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:01:21 +0000 Subject: [Koha-bugs] [Bug 8203] Should be possible to save individual authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8203 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:01:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:01:21 +0000 Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly, and mostly useless In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:01:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:01:21 +0000 Subject: [Koha-bugs] [Bug 8208] Add "create authority" button to auth_finder plugin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8208 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:01:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:01:21 +0000 Subject: [Koha-bugs] [Bug 8209] "Did you mean?" suggestions based on authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8209 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:01:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:01:21 +0000 Subject: [Koha-bugs] [Bug 8205] Should be possible to hide unused authorities in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:01:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:01:21 +0000 Subject: [Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:01:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:01:21 +0000 Subject: [Koha-bugs] [Bug 8211] Add "subject (broader), " "subject (narrower), " and "subject (related)" options for search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8211 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:01:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:01:21 +0000 Subject: [Koha-bugs] [Bug 8207] Modify authority type frameworks to allow see also fields to link to thesauri In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8207 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:01:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:01:21 +0000 Subject: [Koha-bugs] [Bug 8210] Headings in OPAC bib details should link to authority record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8210 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:01:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:01:21 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:02:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:02:40 +0000 Subject: [Koha-bugs] [Bug 8212] Omnibus bug report for C & P authority developments In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8212 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5888, 7818, 8115 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:02:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:02:40 +0000 Subject: [Koha-bugs] [Bug 5888] opac-detail subject/author links improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:02:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:02:40 +0000 Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:02:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:02:40 +0000 Subject: [Koha-bugs] [Bug 8115] DOM indexing configuration should compute totalissues from items.issues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8115 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8212 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 17:38:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 15:38:03 +0000 Subject: [Koha-bugs] [Bug 7417] Include alternate forms from authorities in bibliographic searches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7417 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 21:21:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 19:21:08 +0000 Subject: [Koha-bugs] [Bug 6039] Cancel all waiting holds button In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED --- Comment #26 from Ian Walls --- Best to file a new bug against this behaviour, since the feature has already been pushed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 7 22:56:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Jun 2012 20:56:13 +0000 Subject: [Koha-bugs] [Bug 7872] C4::Items should use C4::Koha methods instead of duplicating SQL queries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7872 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 08:06:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 06:06:44 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |savitra.sirohi at osslabs.biz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 08:15:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 06:15:30 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 Meenakshi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9918|0 |1 is obsolete| | Attachment #9952|0 |1 is obsolete| | --- Comment #9 from Meenakshi --- Created attachment 9978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9978&action=edit Attaches Patch. Sending Improved patch for accurate availability status in cart. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 08:16:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 06:16:16 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 Meenakshi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 08:25:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 06:25:39 +0000 Subject: [Koha-bugs] [Bug 5280] Fix password field in members.pl so that the password is masked as it is entered In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5280 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #27 from David Cook --- (In reply to comment #13) > (In reply to comment #12) > > QA comment: > > I get a "Debug is on (level 1)" > > just below the "Modify Adult patron xxxx" > > (I have DEBUG set to yes in my setup) > > Is it because DEBUG=1 or a test that should be removed ? > > Owen / chris, bumping my question ! I'm still confused by this :/. I'm getting 3 "Use of uninitialized value in concatenation (.) or string" errors (for "dateofbirth: \tdateenrolled: \tdateexpiry", I think). I'm also getting 3 "xsub: [(($6||0),($5||0),($4||0),$3, $2 - 1, $1 - 1900)]" errors. I don't see any fundamental changes from 3.2 in regards to these fields, so I'm at a loss for why this "Debug is on (level 1)" message is still being displayed in memberentrygen.pl, even when DebugLevel is set to "no" :S. Any thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 08:48:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 06:48:16 +0000 Subject: [Koha-bugs] [Bug 7571] Maintain exchange rate history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571 Sagar.B.R changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sagar.br at osslabs.biz --- Comment #2 from Sagar.B.R --- Daily Exchange Rates This feature is implemented for displaying the history of exchange rates. 1. New table is needed to add the exchange rates. 2. edit currency.pl file Insert currency and edit currency are the main two operations available in Currencies and Exchange Rates page, The operations are done by add_validate() sub procedure, It has the condition to identify whether the operation is insert or edit, In both insert and update case the values needs to be copy to ex_rates(new table) table also, So the insert command for ex_rates table should be in same sub procedure . -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 10:02:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 08:02:10 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #12 from Marc V?ron --- Created attachment 9979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9979&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Test scenario: 1) Make sure that you have a column 'agerestriction' in table biblioitems. This will be handled by updatedatabase.pl. If you want to insert the column using mysql, you can do: ALTER TABLE biblioitems ADD COLUMN 'agerestriction' VARCHAR(255) DEFAULT NULL AFTER 'cn_sort' 2) In the staff client, go to Home . Administration . Koha to MARC mapping and choose biblioitems + OK. In the field list, the field 'agerestriction' should show up. Edit it and map the field e.g. to 521a 3) Go to Home . Administration . System preferences and edit Circulation: AgeRestrictionMarker (add eg.: FSK|PEGI|Age) and AgeRestrictionOverride (Prevent or Don't prevent) 4) Create a young patron account e.g. with age < 16 5) Create or edit a biblio with e.g. the value FSK 16 in the field 521a (same field as mapped above) 6) Try to check out to young patron 7) Chckout should be blocked or issue a warning with override (depending on AgeRestrictionOverride) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 10:06:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 08:06:08 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9219|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 10:07:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 08:07:49 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #13 from Marc V?ron --- Previous patch did not longer apply. Remade patch and tested. Would be nice if somebody could sign off - thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 12:12:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 10:12:12 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #19 from shinoy m --- Created attachment 9980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9980&action=edit Additional patch to show the ordered status in catalogue page The new patch is applied ahead on the old patch which is already in the attachment. The new patch will be helpful for showing the ordered status in the catalog page. The status can be seen in the catalog search result also.For the proper working of this patch two more fields to be mapped to the same marc field where the other aqorder fields are mapped. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 13:02:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 11:02:24 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 --- Comment #6 from Marc V?ron --- Created attachment 9981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9981&action=edit Bug 7563 [ENH] - Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference Configure slip printers to print slips (silently) to a special printer using the Firefox PlugIn jsPrintSetUp. All other print actions are not affected. See http://jsprintsetup.mozdev.org/ for all the possibilities (e.g. change header/footer, get a list of printers, set printer etc.). The overall concept is to have a new staff client preference (IntranetSlipPrinterJS) where one can enter the necessary JavaScript. If the preference is empty, Koha falls back to te default behaviour. An example of JavaScript can be found on: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 i# Please enter the commit message for your changes. Lines starting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 13:02:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 11:02:57 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9307|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 13:04:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 11:04:05 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 --- Comment #7 from Marc V?ron --- Did not longer apply. Remade patch, would be nice to get a signoff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 13:17:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 11:17:30 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 --- Comment #2 from Amit Gupta --- Created attachment 9982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9982&action=edit Acquistions duplicate search across orders, suggestions and catalog Create a an suggestion, order and catalog record for a certain title. Use the duplicate search tool available in the acquisitions menu (left navigation bar) to search and find the suggestion, order and catalog record matching the search term. Enter one or more of title, author and ISBN in the search criteria. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 13:17:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 11:17:51 +0000 Subject: [Koha-bugs] [Bug 6813] Acquistions - duplicate search across orders, suggestions and catalog In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 13:30:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 11:30:49 +0000 Subject: [Koha-bugs] [Bug 7909] Serials: payments and credit notes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7909 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|savitra.sirohi at osslabs.biz |amit.gupta at osslabs.biz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 13:43:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 11:43:19 +0000 Subject: [Koha-bugs] [Bug 7586] Search: Language restriction does NOT show expected results (no items shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7586 --- Comment #1 from Marc V?ron --- Created attachment 9983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9983&action=edit Bug 7586 - Search: Language restriction does NOT show expected results (no items shown) modified: etc/zebradb/marc_defs/marc21/biblios/record.abs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 13:45:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 11:45:24 +0000 Subject: [Koha-bugs] [Bug 7586] Search: Language restriction does NOT show expected results (no items shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7586 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high Status|NEW |Needs Signoff Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 13:51:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 11:51:10 +0000 Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #6 from Paul Poulain --- Patch tested with a sandbox, by Delaye Stephane -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 13:51:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 11:51:24 +0000 Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9973|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 13:51:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 11:51:30 +0000 Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #7 from Paul Poulain --- Created attachment 9984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9984&action=edit Bug 7919 : Display of values depending on the connexion librairy In a librairies network, we would like to declare specific values just for one (or more) librairy. Here we implement the ability to associate categories, patron attributes types and/or authorised_values with librairies (branches). This patch adds 3 new association tables: - categories_branches ( association table between categories and branches ) - authorised_values_branches ( association table between authorised_values and branches ) - borrower_attribute_types_branches (association table between borrower_attribute_types and branches ) Plan test: - Create (or modify) categories, patron attributes and authorised_values and link it with one (or more) library. - Set one of these librairies - Go to one of the multiple pages where this specific value must be displayed and check that it does appear. - Set a librairy not concerned. - Check on the same pages this value is doest not appear. A page list: cataloguing/addbiblio.pl cataloguing/additems.pl members/members-home.pl members/memberentry.pl acqui/neworderempty.pl tools/import_borrowers.pl and others :) Please say me if filters don't work on some pages. Signed-off-by: Delaye Stephane -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 14:07:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 12:07:47 +0000 Subject: [Koha-bugs] [Bug 6774] Display barcode on OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6774 --- Comment #9 from Ebin Joseph --- Created attachment 9985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9985&action=edit Patch to display the barcode in catalog detail page. Attached is the patch to display the barcode in catalog detail page. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 14:08:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 12:08:00 +0000 Subject: [Koha-bugs] [Bug 6774] Display barcode on OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6774 Ebin Joseph changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |ebin.joseph at osslabs.biz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 14:13:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 12:13:48 +0000 Subject: [Koha-bugs] [Bug 7911] Greater flexibility in auto barcode number generation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7911 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 15:13:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 13:13:43 +0000 Subject: [Koha-bugs] [Bug 8187] Batch patron modification missing from tools sidebar menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8187 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #3 from Ian Walls --- Template only change to add a link and change the name of another. Marking Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 15:28:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 13:28:37 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|koha-bugs at lists.koha-commun |koha.sekjal at gmail.com |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 15:36:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 13:36:09 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal at gmail.com |m.de.rooy at rijksmuseum.nl --- Comment #19 from Ian Walls --- Talking this out in IRC, while it may be more efficient to modify the subroutine to take in parts that we already have in AddIssue, it would not make for clean, readable code. And since computing popularity really doesn't need to be an up-to-the-minute thing, and a script is provided to do it on cron, I just can't justify holding up QA for this. Code is very clean, well documented and non-invasive. Provides a mechanism for both real-time and scheduled updates, and the initial population can be handled using the cron script as well. Assigning to Marcel for QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 16:00:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 14:00:21 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9957|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 16:00:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 14:00:39 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9958|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 16:03:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 14:03:46 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9966|0 |1 is obsolete| | --- Comment #20 from M. de Rooy --- Created attachment 9986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9986&action=edit Bug 6557: Record bib popularity in totalissues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 16:04:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 14:04:12 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9986|0 |1 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 17:02:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 15:02:41 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #21 from M. de Rooy --- QA Comment Nice feature. Well documented incl. test plan. Code looks good. Just a thought on UpdateTotalIssues: BTW Note the comment from Ian earlier. Also: something simple: checking if biblionumber makes sense? Record exists? (Strange things happen..) Could be handled in the same followup suggested for Ians remarks. Will your use of commit trigger commit-ineffective-warnings in most cases (autocommit will be on by default) ? You do not have begin_work / rollback stuff. Since you offer a commit parameter, I wonder if you promise too much? Normally, the update is written directly to the database. If you actually would use a transaction with begin_work, you should check if it is possible etc. too. No blocker for me. process_stats could have used a few comments on the various queries used. See now what it does, but should not need that deduction ;) Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 17:29:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 15:29:01 +0000 Subject: [Koha-bugs] [Bug 5337] acq EAN search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 17:29:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 15:29:29 +0000 Subject: [Koha-bugs] [Bug 5337] acq EAN search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337 --- Comment #29 from M. de Rooy --- Still applies. Will take a look. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 17:47:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 15:47:00 +0000 Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 --- Comment #3 from Marc V?ron --- Created attachment 9987 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9987&action=edit Bug 7601 - Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") When a new marc record is added, the language code in field 008 Range 35-37 defaults to Englih ("eng"). This makes cataloguing inefficient and error-prone for librarians if most of the bibliographic data is e.g. in German or in French. Test: - Apply patch - Edit preference DefaultLanguageField008, fill in e.g. 'ger' - Go to Cataloguing, Add marc Record - Click in field 008. Language code should read 'ger' (instead of 'eng') -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 17:47:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 15:47:24 +0000 Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7882|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 17:47:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 15:47:40 +0000 Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7881|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 17:48:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 15:48:44 +0000 Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 17:49:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 15:49:18 +0000 Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 17:56:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 15:56:45 +0000 Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 18:26:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 16:26:33 +0000 Subject: [Koha-bugs] [Bug 8213] New: "Cancel All" button on holds over tab cancels both holds over and holds waiting Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 Priority: P5 - low Change sponsored?: --- Bug ID: 8213 CC: gmcharlt at gmail.com Assignee: kyle.m.hall at gmail.com Summary: "Cancel All" button on holds over tab cancels both holds over and holds waiting Severity: major Classification: Unclassified OS: All Reporter: melia at bywatersolutions.com Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha The "Cancel All" button on the Holds Over tab currently cancels all holds over and all holds waiting. This doesn't make sense - librarians are inadvertently canceling all of their holds that are waiting to be picked up. The "Cancel All" button should cancel only the holds over that do not need to be transferred (these are the ones that are older than ReservesMaxPickUpDelay). It should not cancel the holds waiting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 18:27:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 16:27:15 +0000 Subject: [Koha-bugs] [Bug 8213] "Cancel All" button on holds over tab cancels both holds over and holds waiting In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213 --- Comment #1 from Melia Meggs --- Related to http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6039 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 18:36:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 16:36:56 +0000 Subject: [Koha-bugs] [Bug 5337] acq EAN search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #30 from M. de Rooy --- QA Comment: Although I agree with Ian that a more general solution would be welcome, I do not oppose this patch. But this problem will come up again. And if we continuously would say "Next time we must solve it better..", we will never come there. So, it would be nice to trigger that discussion now. But who will take care of the generic housekeeping solution.. Specific comments on this patch below. Note that Paul wanted to pass qa already on it, but I unfortunately disagree. Note that it was signed-off by jean-manuel.broust at univ-lyon2.fr. The patch commit does not show that however. Please fix that too. The atomicupdate file could be removed (adding the field is done in updatedatabase)? The version number there should be filled with XXX instead of 005. This is a BLOCKER. Why do you need a index in deletedbiblioitems on ean? Please clarify. The commit reads: However, if you already have records with ean, you will have to run misc/batchRebuildBiblioTables.pl to populate biblioitems.ean. Should this be published too in the update print statement or anywhere else too? Routine GetSubscriptions: You add line: $sqlwhere .= ( $sqlwhere ? " AND " : " WHERE " ) . "(" . join( ") OR (", @sqlstrings ) . ")"; Please add an additional ( and ) around this construct, just as is done a few lines above it. This prevents wrong interpretation of the whole expression. Since you are adding parameters to existing routines: Did you check if you did not miss any function call for the two routines changed? You should grep on the name only. Do not assume that the name always is immediately followed by parenthesis. Could be whitespace also. Note that I find instances of test scripts referring to the function that you do not change (e.g. t/db_dependent/Serials.t). Please verify. BLOCKER too. Please clarify: Why a span if biblionumber passed and otherwise a label in neworderempty.tt change? Changing status to reflect need for corrections and clarification. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 20:39:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 18:39:00 +0000 Subject: [Koha-bugs] [Bug 8195] The selected link in include menus must be bold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8195 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #3 from Ian Walls --- Javascript only change to provide a default value of '' for "params" var when the regex doesn't match. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 20:41:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 18:41:45 +0000 Subject: [Koha-bugs] [Bug 8119] Show hint when disabling active currency checkbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8119 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #7 from Ian Walls --- Both patches are javascript-only, first adding a hint where appropriate (in a translatable way, I believe), then making a new subroutine to check for this. Marking Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 20:51:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 18:51:04 +0000 Subject: [Koha-bugs] [Bug 8196] members/memberentry.pl?op=add shows all extended attribute values from database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #5 from Ian Walls --- It's unclear why the code was changed for bug 5742, as I cannot seem to find a valid situation where we should still get the attributes even without the borrowernumber. As this is a small and clear revision to restore things to the way they behaved before, marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 21:04:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 19:04:50 +0000 Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion CC| |ruth at bywatersolutions.com --- Comment #8 from Ian Walls --- I'm all for having more granular control of system features on the branch level, but this patch seems to be doing it in a very ad-hoc, bolt-on way for only certain features. There are lots of other things that would be good to control on a per-branch level, and I'd like to see clean, well thought out approach that can handle these use cases and many others with one approach. While it's certainly more work to do it this way, it would lead to more uniform, clean and understandable code, with lower maintenance costs and better extensibility. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 21:50:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 19:50:01 +0000 Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9987|0 |1 is obsolete| | --- Comment #4 from Chris Cormack --- Created attachment 9988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9988&action=edit Bug 7601 - Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") When a new marc record is added, the language code in field 008 Range 35-37 defaults to Englih ("eng"). This makes cataloguing inefficient and error-prone for librarians if most of the bibliographic data is e.g. in German or in French. Test: - Apply patch - Edit preference DefaultLanguageField008, fill in e.g. 'ger' - Go to Cataloguing, Add marc Record - Click in field 008. Language code should read 'ger' (instead of 'eng') Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 21:50:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 19:50:39 +0000 Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 22:34:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 20:34:21 +0000 Subject: [Koha-bugs] [Bug 8214] New: Create a bound with function Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8214 Priority: P5 - low Change sponsored?: --- Bug ID: 8214 Assignee: gmcharlt at gmail.com Summary: Create a bound with function Severity: enhancement Classification: Unclassified OS: All Reporter: steven_jeffery at fmi.com Hardware: All Status: NEW Version: unspecified Component: Cataloging Product: Koha There are occassionally multiple distinct monographs which are bound together. Koha currently lacks a good way to handle these items. Examples: 1. US Geological Survey Bulletins 12 and 13 are bound into one volume. Each was originally published separately, have their own OCLC records, etc. 2. Eight pamphlets on soccer are bound together. Each was published separately but were bound together. They each have separate publishers and records. The key features of this would be: * All the items would have the same barcode. * There would be some sort of item-level display indicating what it was bound with. * All the items would have the same call number. * It would not be necessary to create an additional "ghost" record to hold the sub-records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 8 23:16:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Jun 2012 21:16:02 +0000 Subject: [Koha-bugs] [Bug 8185] Plugin for linking records in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Mirko <5p4m at gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |5p4m at gmx.de --- Comment #3 from Mirko <5p4m at gmx.de> --- - I set up sandbox 8 (http://pro.test8.biblibre.com/) to display 773 9, t, w, x, z in default marc framework - linked the new plugin for subfield 9 - added a second biblio - added data in 001, 020, 022 to second biblio, saved - opened first biblio (sandbox test) - clicked plugin button at 777$9 - searched for "test" - chose biblio2 (marc21 test) All data was added to fields 773 9, t, w, x, z, script is functional. But it is in Italian. Text comes from tt file so it should be translatable strings instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 07:15:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 05:15:26 +0000 Subject: [Koha-bugs] [Bug 7586] Search: Language restriction does NOT show expected results (no items shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7586 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9983|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 9989 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9989&action=edit Bug 7586 - Search: Language restriction does NOT show expected results (no items shown) modified: etc/zebradb/marc_defs/marc21/biblios/record.abs Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 07:16:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 05:16:06 +0000 Subject: [Koha-bugs] [Bug 7586] Search: Language restriction does NOT show expected results (no items shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7586 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 09:09:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 07:09:06 +0000 Subject: [Koha-bugs] [Bug 7911] Greater flexibility in auto barcode number generation In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7911 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #3 from Marc V?ron --- Would it be possible to resolve Bug 6981 "barcode not incrementing" together with this enhancement? Problem of Bug 6981 is that numbers do not incrementing correctly after 2345678765345431 (precision problem because representation of integers change to float). E.g. if you set the value to 2345678765345435 the form will show a value of 2345678765345441 See tests and description in Bug 6981 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 09:10:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 07:10:12 +0000 Subject: [Koha-bugs] [Bug 6981] barcode not incrementing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6981 --- Comment #6 from Marc V?ron --- Could be resolved together with Bug 7911 - Greater flexibility in auto barcode number generation -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 10:57:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 08:57:18 +0000 Subject: [Koha-bugs] [Bug 8215] New: Add Course Reserves Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Priority: P5 - low Change sponsored?: --- Bug ID: 8215 CC: gmcharlt at gmail.com Assignee: koha.sekjal at gmail.com Summary: Add Course Reserves Severity: enhancement Classification: Unclassified OS: All Reporter: kyle.m.hall at gmail.com Hardware: All Status: NEW Version: master Component: Hold requests Product: Koha Add a system for placing academic course reserves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 11:02:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 09:02:35 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #1 from Kyle M Hall --- Created attachment 9990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9990&action=edit Course Reserves Adds a course reserves system for academic libraries. The course reserves system allows libraries to create courses and put items on reserves for those courses. Each item with at least one reserve can have some of its attributes modified while it is on reserve for at least one active course. These attributes include item type, collection code, shelving location, and holding library. If there are no active courses with this item on reserve, it's attributes will revert to the original attributes it had before going on reserve. Testing Scenario: 1) Create new authorised value categories DEPARTMENT and TERM 2) Create a new course, add instructors to that course. 3) Reserve items for that course, verify item attributes have changed. 4) Disable course, verify item attributes have reverted. 5) Enable course again, verify item attributes again. 6) Delete course, verify item attributes again. 7) Create two new courses, add the same item(s) to both courses. 8) Disable one course, verify item attributes have not reverted. 9) Disable both courses, verify item attributes have reverted. 10) Enable one course, verify item attributes are again set to the new values. 11) Edit reserve item attributes, verify. 12) Disable all courses, edit reserve item attributes, verify the item itself still has its original attributes, verify the reserve item attributes have been updated. 13) Verify the ability to remove instructors from a course. 14) Verify new permissions, top level coursereserves, with subpermissions add_reserves and delete_reserves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 11:08:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 09:08:52 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 11:20:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 09:20:22 +0000 Subject: [Koha-bugs] [Bug 7153] Show Open Library as Search Target in "More Searches" in OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6218|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 9991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9991&action=edit Update syspref OPACSearchForTitleIn to include Open Library as a target in More Searches in the OPAC detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 11:22:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 09:22:17 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 11:24:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 09:24:42 +0000 Subject: [Koha-bugs] [Bug 7153] Show Open Library as Search Target in "More Searches" in OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 --- Comment #14 from Kyle M Hall --- Created attachment 9992 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9992&action=edit Bug 7153 - Followup - Remove syspref modification Remove the database update that is modifying an existing systempreference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 11:27:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 09:27:38 +0000 Subject: [Koha-bugs] [Bug 7153] Show Open Library as Search Target in "More Searches" in OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7153 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 11:34:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 09:34:06 +0000 Subject: [Koha-bugs] [Bug 7586] Search: Language restriction does NOT show expected results (no items shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7586 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |P5 - low CC| |m.de.rooy at rijksmuseum.nl QA Contact|koha.sekjal at gmail.com |m.de.rooy at rijksmuseum.nl Severity|critical |minor --- Comment #3 from M. de Rooy --- QA Comment: Good catch, Marc. Simple but effective change. Looks good. Passed QA Note: I am lowering the priority. This is not that critical ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 11:35:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 09:35:13 +0000 Subject: [Koha-bugs] [Bug 8185] Plugin for linking records in MARC21 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8185 Zeno Tajoli changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED CC| |tajoli at cilea.it --- Comment #4 from Zeno Tajoli --- Correct, there are strings in italian. I update a new version full in english as soon as possible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 11:40:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 09:40:35 +0000 Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Version|unspecified |master QA Contact|koha.sekjal at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 11:45:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 09:45:56 +0000 Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #35 from Paul Poulain --- PAtch pushed, and http://wiki.koha-community.org/wiki/Switching_to_dom_indexing created. It's a big & major patch, I'll call for more testers on koha-devel immediatly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 11:50:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 09:50:44 +0000 Subject: [Koha-bugs] [Bug 7872] C4::Items should use C4::Koha methods instead of duplicating SQL queries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7872 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8923|0 |1 is obsolete| | --- Comment #11 from Chris Cormack --- Created attachment 9993 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9993&action=edit Bug 7872 - C4::Items::GetItemsInfo should use C4::Koha instead of SQL queries directly This simplifies code, and has nice side-effect that memoize of C4::Koha functions will be more effective. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 11:51:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 09:51:33 +0000 Subject: [Koha-bugs] [Bug 7872] C4::Items should use C4::Koha methods instead of duplicating SQL queries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7872 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 11:52:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 09:52:44 +0000 Subject: [Koha-bugs] [Bug 4945] Patron search is limited by default to the currently logged-in library In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 11:52:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 09:52:46 +0000 Subject: [Koha-bugs] [Bug 6253] Unified Patron Search subroutine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6253 Bug 6253 depends on bug 4945, which changed state. Bug 4945 Summary: Patron search is limited by default to the currently logged-in library http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4945 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 11:57:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 09:57:27 +0000 Subject: [Koha-bugs] [Bug 8187] Batch patron modification missing from tools sidebar menu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8187 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #4 from Paul Poulain --- patch related tobatch patron modif, that is for 3.10, so no need to port this patch to 3.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 11:58:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 09:58:19 +0000 Subject: [Koha-bugs] [Bug 3708] Add another customizable region to the OPAC: right sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3708 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9883|0 |1 is obsolete| | Status|Needs Signoff |Signed Off Assignee|chris at bigballofwax.co.nz |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Created attachment 9994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9994&action=edit Signoff Patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:03:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:03:15 +0000 Subject: [Koha-bugs] [Bug 7447] Allow to specify a date in overdue_notice.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7447 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7175|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 9995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9995&action=edit [SIGNED-OFF] Bug 7447 allow to specify a date in overdue_notice.pl This patch add a new parameter to overdue_notices.pl, that is a date. If you add --date=YYYY-MM-DD when running overdue_notices, it will generate overdues as if you were on date provided that's usefull if you want to relaunch an overdue calculation that has failed, of after changing your circ rules Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:03:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:03:43 +0000 Subject: [Koha-bugs] [Bug 7447] Allow to specify a date in overdue_notice.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7447 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:04:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:04:24 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #22 from Paul Poulain --- Some questions about this patch: * why do you use a cronjob instead of UPDATing when there is any circulation. The items.issues field is updated this way, for consistency biblioitems.totalissue should be too * I can't see a case where a library would want NOT to record totalissue. Thus, I can't see a case where the syspref would be set to 0. So, is the syspref needed ? The fact that you declared this bug as "normal" and not as "enhancement" make me feel it's more a bugguy behaviour thant something the library would be able to change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:10:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:10:40 +0000 Subject: [Koha-bugs] [Bug 6090] empty mails in message_queue are sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6090 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8085|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 9996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9996&action=edit [SIGNED-OFF] Bug 6090: Do not enqueue empty messages This patch avoid enqueuing messages that have an empty body. It can happen when letter is empty or becomes empty after being processed by parseletter Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:10:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:10:47 +0000 Subject: [Koha-bugs] [Bug 5312] XHTML correction in authority summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5085|0 |1 is obsolete| | --- Comment #6 from Chris Cormack --- Created attachment 9997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9997&action=edit BUG 5312 XHTML correction in authority summary -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:11:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:11:06 +0000 Subject: [Koha-bugs] [Bug 6090] empty mails in message_queue are sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6090 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:11:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:11:13 +0000 Subject: [Koha-bugs] [Bug 5312] XHTML correction in authority summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:13:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:13:51 +0000 Subject: [Koha-bugs] [Bug 7652] add item barcode on top of its editing form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7652 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8041|0 |1 is obsolete| | --- Comment #7 from Adrien SAURAT --- Created attachment 9998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9998&action=edit signed off patch Tested OK (after resolving a conflict). Barcode displayed when editing an item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:16:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:16:10 +0000 Subject: [Koha-bugs] [Bug 8154] The export today's checked in barcodes generated file is always empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |paul.poulain at biblibre.com --- Comment #2 from Paul Poulain --- Patch tested with a sandbox, by Francois Charbonnier -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:16:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:16:11 +0000 Subject: [Koha-bugs] [Bug 5312] XHTML correction in authority summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9997|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall --- Created attachment 9999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9999&action=edit [SIGNED-OFF] BUG5312 XHTML correction in authority summary Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:16:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:16:24 +0000 Subject: [Koha-bugs] [Bug 8154] The export today's checked in barcodes generated file is always empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9774|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:16:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:16:29 +0000 Subject: [Koha-bugs] [Bug 8154] The export today's checked in barcodes generated file is always empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 --- Comment #3 from Paul Poulain --- Created attachment 10000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10000&action=edit Bug 8154 - The export today's checked in barcodes generated file is always empty Comparation of date and datetime is always false Signed-off-by: Francois Charbonnier -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:16:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:16:33 +0000 Subject: [Koha-bugs] [Bug 5312] XHTML correction in authority summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:21:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:21:02 +0000 Subject: [Koha-bugs] [Bug 8197] Software error when you have cleaned cookies in your browser and try to past the url to opac-topissues.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8197 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9954|0 |1 is obsolete| | Status|Needs Signoff |Signed Off Assignee|christophe.croullebois at bibl |martin.renvoize at ptfs-europe |ibre.com |.com --- Comment #2 from Martin Renvoize --- Created attachment 10001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10001&action=edit Bug8197:Software error when you have cleaned cookie Error verified as present in master. Patch tested and working in both Firefox and Chrome. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:21:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:21:12 +0000 Subject: [Koha-bugs] [Bug 8154] The export today's checked in barcodes generated file is always empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at biblib | |re.com --- Comment #4 from Francois Charbonnier --- I did 2 tests : 1/ - checked-out 2 books - checked-in these books through returns.pl page - exported today's checkins barcode 2/ - checked-out 2 books - checked-in these books through circulation.pl page - exported today's checkins barcode In both cases it works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:21:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:21:15 +0000 Subject: [Koha-bugs] [Bug 7652] add item barcode on top of its editing form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7652 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9998|0 |1 is obsolete| | --- Comment #8 from Adrien SAURAT --- Created attachment 10002 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10002&action=edit Signed-off patch (fixed Author) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:21:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:21:41 +0000 Subject: [Koha-bugs] [Bug 7652] add item barcode on top of its editing form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7652 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |adrien.saurat at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:22:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:22:44 +0000 Subject: [Koha-bugs] [Bug 3708] Add another customizable region to the OPAC: right sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3708 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com Assignee|martin.renvoize at ptfs-europe |oleonard at myacpl.org |.com | --- Comment #6 from Paul Poulain --- Martin, when you sign-off a patch, there's no need to assign the bug to you. The assignee of a bug is/should be the patch writer. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:28:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:28:20 +0000 Subject: [Koha-bugs] [Bug 8176] $sqlwhere is undefined in C4::Serials in GetSubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8176 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9872|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 10003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10003&action=edit Bug 8176 [SIGNED-OFF] Assign an intial value to $sqlwhere warnings in log because of undefined value in string concatenation variable should be initialized to empty string rather than left undefined Signed-off-by: Jonathan Druart Removes a warning in logs Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:28:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:28:43 +0000 Subject: [Koha-bugs] [Bug 7186] add new 'Koha Stats' tab to 'About' page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:31:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:31:04 +0000 Subject: [Koha-bugs] [Bug 8176] $sqlwhere is undefined in C4::Serials in GetSubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8176 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10003|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:31:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:31:30 +0000 Subject: [Koha-bugs] [Bug 8176] $sqlwhere is undefined in C4::Serials in GetSubscriptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8176 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9872|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:32:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:32:19 +0000 Subject: [Koha-bugs] [Bug 8195] The selected link in include menus must be bold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8195 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 Severity|enhancement |minor --- Comment #4 from Paul Poulain --- Very minor bugfix, could be backported in 3.8 I think -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:32:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:32:56 +0000 Subject: [Koha-bugs] [Bug 8216] New: Enable critic tests on SIP modules Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8216 Priority: P5 - low Change sponsored?: --- Bug ID: 8216 Assignee: colin.campbell at ptfs-europe.com Summary: Enable critic tests on SIP modules Severity: enhancement Classification: Unclassified OS: All Reporter: colin.campbell at ptfs-europe.com Hardware: All Status: NEW Version: unspecified Component: SIP2 Product: Koha Paul remarked in relation to pushing a fix for another bug that SIP modules continued to issue a number of perlcritic warnings. This patch will add C4/SIP to the testcritic diirectories and address those issues which are warnings (mainly return undef and subroutine prototypes) it also removes some dead code that was no longer used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:35:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:35:10 +0000 Subject: [Koha-bugs] [Bug 7186] add new 'Koha Stats' tab to 'About' page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6241|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 10004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10004&action=edit Bug 7186 - add new 'Koha Stats' tab to 'About' page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:36:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:36:35 +0000 Subject: [Koha-bugs] [Bug 8119] Show hint when disabling active currency checkbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8119 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #8 from Paul Poulain --- more a tiny ENH than a bugfix, but chris_c, I let you decide. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:37:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:37:18 +0000 Subject: [Koha-bugs] [Bug 7299] ILSDI HoldItem service does't set the itemnumber in reserves table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7299 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6521|0 |1 is obsolete| | --- Comment #3 from Alex Arnaud --- Created attachment 10005 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10005&action=edit Bug 7299 passe itemnumber in ILSDI holditem service -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:37:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:37:40 +0000 Subject: [Koha-bugs] [Bug 8217] New: Focus on search box in Detail page (staff search) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Priority: P5 - low Change sponsored?: --- Bug ID: 8217 Assignee: adrien.saurat at biblibre.com Summary: Focus on search box in Detail page (staff search) Severity: enhancement Classification: Unclassified OS: All Reporter: adrien.saurat at biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Searching Product: Koha Koha Team Lyon3 proposal/patch: When accessing a detail page after a search, it would be useful to have the focus on the search box. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:38:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:38:57 +0000 Subject: [Koha-bugs] [Bug 7299] ILSDI HoldItem service does't set the itemnumber in reserves table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7299 --- Comment #4 from Alex Arnaud --- This new patch does 2 things: - Remove biblioitemnumber - Add full namespace for call to CanItemBeReserved function -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:39:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:39:11 +0000 Subject: [Koha-bugs] [Bug 8196] members/memberentry.pl?op=add shows all extended attribute values from database In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8196 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 Severity|enhancement |minor --- Comment #6 from Paul Poulain --- bugfix, but consequence of an ENH that will be in 3.10, so no need for this patch in 3.8 I think -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:39:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:39:27 +0000 Subject: [Koha-bugs] [Bug 7299] ILSDI HoldItem service does't set the itemnumber in reserves table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7299 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:40:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:40:35 +0000 Subject: [Koha-bugs] [Bug 8216] Enable critic tests on SIP modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8216 --- Comment #1 from Colin Campbell --- Created attachment 10006 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10006&action=edit Proposed patch Adds C4/SIP to critic tests To Test set environment variable TEST_QA to 1 from top level ran critic tests: prove t/00-testcritic.t no warnings should be generated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:41:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:41:36 +0000 Subject: [Koha-bugs] [Bug 8216] Enable critic tests on SIP modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8216 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:42:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:42:40 +0000 Subject: [Koha-bugs] [Bug 5337] acq EAN search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337 --- Comment #31 from Matthias Meusburger --- (En r?ponse au commentaire 30) > Note that it was signed-off by jean-manuel.broust at univ-lyon2.fr. The patch commit does not show that however. Please fix that too. Done > The atomicupdate file could be removed (adding the field is done in > updatedatabase)? Ok, removed. The version number there should be filled with XXX instead of 005. Fixed > Why do you need a index in deletedbiblioitems on ean? Please clarify. You're right, indeed. Nothing really justify the use of and index on this field. Removed. > > The commit reads: However, if you already have records with ean, you will > have to run misc/batchRebuildBiblioTables.pl to populate biblioitems.ean. > Should this be published too in the update print statement or anywhere else > too? I've added the message in the updatedatabase (in case the marcflavor is unimarc, otherwise the mapping is not automatically added, and there's no need for rebuilding biblio tables). Do you think of another place where this message should be added? > > Routine GetSubscriptions: You add line: > $sqlwhere .= ( $sqlwhere ? " AND " : " WHERE " ) . "(" . join( ") OR (", > @sqlstrings ) . ")"; > Please add an additional ( and ) around this construct, just as is done a > few lines above it. This prevents wrong interpretation of the whole > expression. Done > > Since you are adding parameters to existing routines: Did you check if you > did not miss any function call for the two routines changed? You should grep > on the name only. Do not assume that the name always is immediately followed > by parenthesis. Could be whitespace also. Note that I find instances of test > scripts referring to the function that you do not change (e.g. > t/db_dependent/Serials.t). Please verify. BLOCKER too. I've done the grep with only the function name and it seems that every call in the source code has been changed. But yes, the tests should have been changed too. Now it's done. I added ean test to t/db_dependent/Serials.t. I added ean (and isbn, which was missing) test to t/db_dependent/lib/KohaTest/Acquisition/GetHistory.pm. > > Please clarify: Why a span if biblionumber passed and otherwise a label in > neworderempty.tt change? The neworderempty page allows to add catalogue informations (title, author, ean...) to an order while creating a new order. However, those informations cannot be directly modified when editing an existing order (there's a link for editing the record). This is why it's only a label when there is a biblionumber. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:45:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:45:20 +0000 Subject: [Koha-bugs] [Bug 8184] Duplicate budget page lacks heading and breadcrumbs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8184 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9926|0 |1 is obsolete| | Status|Needs Signoff |Signed Off Assignee|oleonard at myacpl.org |martin.renvoize at ptfs-europe | |.com --- Comment #2 from Martin Renvoize --- Created attachment 10007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10007&action=edit Bug 8184 - Duplicate budget page lacks heading and breadcrumbs Corrects the problem.. however I have one question regarding headings. Is there any docs anywhere suggesting rules for which level of heading should be used where? Example.. just in the budgets dialogues, we have h1, h2 and h3 all used and there's no obvious pattern to why? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:47:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:47:28 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 --- Comment #1 from Adrien SAURAT --- Created attachment 10008 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10008&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:48:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:48:00 +0000 Subject: [Koha-bugs] [Bug 5337] acq EAN search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9759|0 |1 is obsolete| | --- Comment #32 from Matthias Meusburger --- Created attachment 10009 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10009&action=edit Bug 5337: EAN management : Adds ean for various searches - in various acquisition pages and serials home - in database : biblioitems.ean - adds ean and its mapping in default english bibliographic framework - adds ean mapping in default french bibliographic framework - ean search is not enabled for MARC21 The required mapping between the ean marc field and the biblioitems.ean database field will be automatically added on an existing unimarc installation. However, if you already have records with ean, you will have to run misc/batchRebuildBiblioTables.pl to populate biblioitems.ean Signed-off-by: jmbroust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:48:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:48:14 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Adrien SAURAT --- TEST PLAN : In staff interface, search for a biblio, then access its detail page. Once the page is loaded the focus should be on the search box. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:51:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:51:18 +0000 Subject: [Koha-bugs] [Bug 5337] acq EAN search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:52:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:52:24 +0000 Subject: [Koha-bugs] [Bug 5292] Google Preview Option for OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5292 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2868|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 10010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10010&action=edit Bug 5292 - Google Preview Option for OPAC Adds option to insert link for Google Books preview into opac for items with available preview. Patch based on original work by Darrel Ulm. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:52:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:52:40 +0000 Subject: [Koha-bugs] [Bug 5292] Google Preview Option for OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5292 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 12:54:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 10:54:51 +0000 Subject: [Koha-bugs] [Bug 3708] Add another customizable region to the OPAC: right sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3708 --- Comment #7 from Martin Renvoize --- Thanks Paul, I'de just misread that checkbox in bugzilla.. oops. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:02:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:02:14 +0000 Subject: [Koha-bugs] [Bug 5468] libyaz3 debian dependency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5468 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4830|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:05:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:05:10 +0000 Subject: [Koha-bugs] [Bug 5468] libyaz3 debian dependency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5468 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5579|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:05:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:05:33 +0000 Subject: [Koha-bugs] [Bug 5468] libyaz3 debian dependency In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5468 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |FIXED --- Comment #16 from Chris Cormack --- This is now all fixed in master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:06:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:06:09 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain at biblibre.com --- Comment #5 from Paul Poulain --- QA comments: * I don't understand the need/use of + my $userenv_branch = $userenv ? $userenv->{"branch"} : undef; why don't you use $userenv->{"branch"} ? * the sub + =head2 get_user_printer must not be in C4/Auth.pm, but in C4/Print.pm (not a perfect option) or in Koha:: namespace (in the hackfest currently running, I've proposed a time to discuss of naming convention/organisation for Koha:: namespace) * same comment for sub GetPrinterDetails {, should not be in C4/Koha.pm Other than this, the code looks OK (haven't tested it yet) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:06:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:06:33 +0000 Subject: [Koha-bugs] [Bug 6141] html glitches causing problems to translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3836|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 10011 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10011&action=edit Bug 6141 - html glitches causing problems to translator * opac-topissue.pl = untranslatable string removed * authorities.pl missing _() in javascript Rewrite of patch authored by Julian Maurice. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:06:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:06:52 +0000 Subject: [Koha-bugs] [Bug 6141] html glitches causing problems to translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:12:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:12:08 +0000 Subject: [Koha-bugs] [Bug 7787] SIP server closes the TCP connection when it receives an invalid message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7787 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8511|0 |1 is obsolete| | --- Comment #8 from Colin Campbell --- Created attachment 10012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10012&action=edit Reformatted Patch The original patch gave some whitespace errors on being applied. The reformatted patch fixes these. I also reformatted the commit message so that it was all readable on a standard screen (It was a single line) ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:13:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:13:22 +0000 Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m --- Comment #9 from Sophie MEYNIEUX --- A simple solution could be to only get date in sql request : SELECT DATE(issuedate), DATE(date_due), ... But if all thoses columns are now Datetime, I suppose that's because we need the time somewhere (I didn't see where). If C4::Dates should be abandonned, we could use DateTime module and truncate date variables to day before comparison where we don't need time. I think some kind of global best practice should be written to handle date and time consistantly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:14:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:14:26 +0000 Subject: [Koha-bugs] [Bug 8092] Koha should use CHI caching framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8092 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Paul Poulain --- QA comments: looks correct. perlcritic OK. passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:14:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:14:40 +0000 Subject: [Koha-bugs] [Bug 8092] Koha should use CHI caching framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8092 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:14:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:14:57 +0000 Subject: [Koha-bugs] [Bug 8005] Lost item is not anonymized when checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9293|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 10013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10013&action=edit Bug 8005 - Lost item is not anonymized when checked in -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:15:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:15:14 +0000 Subject: [Koha-bugs] [Bug 8005] Lost item is not anonymized when checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8005 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:15:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:15:39 +0000 Subject: [Koha-bugs] [Bug 7787] SIP server closes the TCP connection when it receives an invalid message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7787 --- Comment #9 from Colin Campbell --- Not sure of the telnet logic as the connection is not broken after three failed logins sending garbage to a telnet port will permanently occupy that session(?) could it generate a kind of DOS against a sip port in this way. Will try testing this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:16:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:16:43 +0000 Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from M. de Rooy --- QA Comment: Rebased the updatedatabase part. Will attach it. Patch appears to have external signoff. But the commit does not show it. Please correct. Statistics.pm: $VERSION = 3.02; Do we need it? Why 3.02? Seems just to be copied.. construct_query: This routine is not very clear. Note also that you do not check the contents of the pref: column whatever can be put into the pref and will just be copied over. So it is somehwat error sensitive (not even talking about security issues). This point is not a definitive blocker for me, but if you can improve this code, you are welcome ;) GetPrecedentStateByBorrower: Please confirm if the second where clause is correct. You say returndate=now while I was expecting returndate{$cn} ~~ $h->{$cn} ) { Note that tilde tilde operator is a way to force scalar context. It makes code obscure; better avoid it. Please clarify. build_array function: Might need some more comments too. Makes maintenance easier. (The current oneliner does not really explain it to me..) Warning in the logfile: [Sat Jun 09 10:34:39 2012] [error] [client 129.215.5.255] [Sat Jun 9 12:34:39 2012] statistics.pl: Use of uninitialized value in addition (+) at /usr/share/koha/testclone/members/statistics.pl line 74. Please check undefined values. statistics.tt: variable unknowuser: Is a correct typo ;) Should be corrected in members.pl and some templates. (But outside scope of your report) In conclusion: There are a few comments and questions needing attention before passing qa now rightaway. Please clarify or correct to "save this kitten" (hackfest term). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:17:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:17:27 +0000 Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 --- Comment #10 from Chris Cormack --- (In reply to comment #9) > A simple solution could be to only get date in sql request : > SELECT DATE(issuedate), DATE(date_due), ... > But if all thoses columns are now Datetime, I suppose that's because we need > the time somewhere (I didn't see where). > In circulation now, you can specify hourly loans, so times are used for calculating overdues etc. > If C4::Dates should be abandonned, we could use DateTime module and truncate > date variables to day before comparison where we don't need time. > > I think some kind of global best practice should be written to handle date > and time consistantly. Definitely -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:18:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:18:25 +0000 Subject: [Koha-bugs] [Bug 6707] Add alternative, textual MARC editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6707 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5101|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 10014 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10014&action=edit Bug 6707 - Add textual MARC editor Add an alternate MARC editor, which allows entering biblios in a textual format. This allows a faster workflow for experienced catalogers. Possible improvements: * Remove untranslateable strings from code * Replace parser with simpler version, if possible * Remove ugly redirect-hack Known problems: * Does not support authorities. Adding this would be quite complicated. * Also not authorized values. Would be tough, but doable. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:18:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:18:44 +0000 Subject: [Koha-bugs] [Bug 6707] Add alternative, textual MARC editor In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6707 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:19:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:19:40 +0000 Subject: [Koha-bugs] [Bug 7619] 3M self checkout don't work in France In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 --- Comment #11 from Colin Campbell --- Telnet uses CRLF because thats the telnet protocol. The fact SIP is protocol agnostic (i.e. you can use sip by carrier pidgeon if you want) obscures the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:20:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:20:58 +0000 Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9771|0 |1 is obsolete| | --- Comment #10 from M. de Rooy --- Created attachment 10015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10015&action=edit Rebased patch Rebase for updatedatabase only -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:27:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:27:52 +0000 Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557 --- Comment #23 from Jared Camins-Esakov --- Paul, (In reply to comment #22) > Some questions about this patch: > * why do you use a cronjob instead of UPDATing when there is any > circulation. The items.issues field is updated this way, for consistency > biblioitems.totalissue should be too Updating the biblio at circ is very expensive. It is much better not to edit the bib record at all at circulation. By making the update-at-circ optional, we won't be giving any libraries with underpowered servers an unpleasant shock. > * I can't see a case where a library would want NOT to record totalissue. > Thus, I can't see a case where the syspref would be set to 0. So, is the > syspref needed ? The fact that you declared this bug as "normal" and not as > "enhancement" make me feel it's more a bugguy behaviour thant something the > library would be able to change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:35:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:35:37 +0000 Subject: [Koha-bugs] [Bug 7805] Exposing the new list permissions in opac and staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #6 from Paul Poulain --- QA comment: * discussing of this feature with Marcel=if you select "private" list, the other 3 flags are irrelevant. In the future, users will be able to share private lists with who they want. * perlcritic in C4/VirtualShelves.pm was complaining before the patch and after the patch, so I won't reject it, but it would be nice to fix it in a later patch: C4/VirtualShelves.pm: Subroutine prototypes used at line 224, column 1. See page 194 of PBP. (Severity: 5) C4/VirtualShelves.pm: Subroutine prototypes used at line 255, column 1. See page 194 of PBP. (Severity: 5) C4/VirtualShelves.pm: "return" statement with explicit "undef" at line 354, column 22. See page 199 of PBP. (Severity: 5) C4/VirtualShelves.pm: Subroutine prototypes used at line 661, column 1. See page 194 of PBP. (Severity: 5) C4/VirtualShelves.pm: Don't modify $_ in list functions at line 664, column 5. See page 114 of PBP. (Severity: 5) No other comment, passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:35:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:35:50 +0000 Subject: [Koha-bugs] [Bug 7805] Exposing the new list permissions in opac and staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:39:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:39:47 +0000 Subject: [Koha-bugs] [Bug 5337] acq EAN search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10009|0 |1 is obsolete| | --- Comment #33 from M. de Rooy --- Created attachment 10016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10016&action=edit Patch for EAN Amended for removing merge marker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:46:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:46:03 +0000 Subject: [Koha-bugs] [Bug 5337] acq EAN search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Version|rel_3_8 |master --- Comment #34 from M. de Rooy --- QA Comment: All points have got attention. Thanks for the quick fix. Note that the test t/db_dependent/lib/KohaTest like others in that directory seems to be obsolete. Passed QA We saved a kitten! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:46:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:46:31 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #23 from Marc V?ron --- Katrin and I found a bug while testing the patch during Kohacon 12 Hackfest. If you add new items to a basket, the form "Item" is rpeated several times. We double checked with and without patch applied and with and without ACQ framework defined. Additionally, in the Items list table we had a line missing between the first and the second item. See screenshot attached. ---------------- We found a misspelling in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref If you want more than 1 value, please separe with |) should read If you want more than 1 value, please separate with |) ---------------- We found several Bugs on Bugzilla that probably could be related to or resolved by this one: Bug 7495 - Tax calculations problem for new orders. Bug 7686 - Tax rate wrong calculation in reception summary page Bug 6965 - Tax and dicount rate should be formatted the same Bug 3980 - Vendor GST being ignored -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 13:47:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 11:47:26 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #24 from Marc V?ron --- Created attachment 10017 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10017&action=edit Screenshot of duplicated form -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 14:37:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 12:37:36 +0000 Subject: [Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9753|0 |1 is obsolete| | --- Comment #14 from M. de Rooy --- Created attachment 10018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10018&action=edit Patch 6835 Fixed trivial conflict -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 14:38:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 12:38:20 +0000 Subject: [Koha-bugs] [Bug 6267] custom http user-agent in check-url.pl (fix for books.google.com 401 error) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6267 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Paul Poulain --- QA comment : tiny & obvious patch replacing a ; by a , to avoid an error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 14:40:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 12:40:50 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 14:44:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 12:44:41 +0000 Subject: [Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 --- Comment #15 from M. de Rooy --- QA Comment: Do not want to step into your conversation ;) I do not oppose this new sub, but Paul's question deserves an answer first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 14:45:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 12:45:14 +0000 Subject: [Koha-bugs] [Bug 6267] custom http user-agent in check-url.pl (fix for books.google.com 401 error) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6267 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Paul Poulain --- Patch pushed on master branch, I can't push it on new/bug_6267 Should be backported in 3.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 14:49:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 12:49:08 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 --- Comment #8 from Dobrica Pavlinusic --- Created attachment 10019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10019&action=edit Bug 6448 [1/3] EAN-13/UPC-A itemBarcodeInputFilter This filter which check validity of EAN-13 barcode and padd it with zeros up to full 13 digit number. This will also expand 12 digit UPC-A barcodes to EAN-13 automatically which is useful for older barcode readers which tend to ignore first zero in EAN-13 if they have just UPC-A support. It should be noted that EAN-13 or UPC-A product codes printed on books are not good choice for barcodes in Koha since each item has to have unique barcode. Test scenario: 1. prove t/Circulation_barcodedecode.t this checks expansion of 12 digit UPC-A to 13 digit EAN-13 and zero padding 2. in systempreferences search for itemBarcodeInputFilter and select EAN-13 3. edit one item and assign it valid EAN-13 barcode, eg. 0000000695152, check it out 4. test checkin with just 695152 to test leading zero expansion -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 14:49:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 12:49:53 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9192|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 14:50:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 12:50:41 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 --- Comment #9 from Dobrica Pavlinusic --- First patch again bit-rotted because development moved on. Instruction how to apply diffs in correct order still apply -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 14:51:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 12:51:35 +0000 Subject: [Koha-bugs] [Bug 8139] Fix the CSS for the recent comments to prevent leftmenu overlapping it. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8139 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9734|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 10020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10020&action=edit [SIGNED-OFF] Bug 8139 - add margin to recent comments CSS to fix stuff with menus Signed-off-by: Katrin Fischer Simple CSS change, fixes the problem with left navigation overlapping list of recent comments on small screens in OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 14:51:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 12:51:54 +0000 Subject: [Koha-bugs] [Bug 8139] Fix the CSS for the recent comments to prevent leftmenu overlapping it. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8139 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 14:56:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 12:56:44 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 --- Comment #3 from Marc V?ron --- Created attachment 10021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10021&action=edit Bug 8217:[SIGNED-OFF] Focus on search box in staff detail page Signed-off-by: Marc Veron Works exactly as expected. Adds onload="document.getElementById('search-form').focus() to HTMP body. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 14:57:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 12:57:12 +0000 Subject: [Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 --- Comment #16 from Matthias Meusburger --- (En r?ponse au commentaire 13) > QA comments: > * I don't see the necessity of GetValidEmailAddresses sub. GetMember will > return all email addresses (with other informations) GetMember does a heavier query than GetValidEmailAddresses. To my opinion, that unique point make the creation of GetValidEmailAddresses relevant, at a time we're trying to optimize koha. Moreover, the fetching of email addresses is done in nested loops. In such case, having lightweight queries does seem important to me. Do we agree on that ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 14:57:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 12:57:31 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10008|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 15:01:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 13:01:41 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 15:06:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 13:06:09 +0000 Subject: [Koha-bugs] [Bug 8167] Add syspref allow a choice of blocking, non-blocking, or do nothing when issuing lost items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8167 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from M. de Rooy --- QA Comment: Code looks good to me. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 15:06:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 13:06:11 +0000 Subject: [Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain at biblibre.com --- Comment #25 from Paul Poulain --- QA comments: * perlcritic problem: C4/HoldsQueue.pm: Don't modify $_ in list functions at line 571, column 27. See page 114 of PBP. (Severity: 5) * why is this code in this patch? +sub _flush_preferences { + %sysprefs = (); +} * we're supposed not to add anything to C4::, but use Koha:: instead. You're creating HoldsQueue.pm. As we haven't defined a clear organization for Koha::, I can't say where this code should be, it's probably fair to have it in C4. Plus I don't want Koha:: be filled with C4:: like scripts, so won't reject the patch for this reason The line: # XXX GetHoldsQueueItems() does not support $itemtypeslimit! should be # FIXME GetHoldsQueueItems() does not support $itemtypeslimit! Just a question, not related to QA: if the syspref is OFF, how are things sorted ? as before ? (if yes, good point you've set the value to 0 by default, it means there won't be any change for users) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 15:09:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 13:09:59 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8280|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 10022 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10022&action=edit Bug 7671 - add a real primary key "accountlinesid" in accountlines Rebased against master... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 15:10:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 13:10:36 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |martin.renvoize at ptfs-europe | |.com Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 15:17:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 13:17:41 +0000 Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771 --- Comment #7 from Alex Arnaud --- Created attachment 10023 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10023&action=edit Bug 5771 - Follow up MT2894 Adds a download link for big error reports to import_borrowers -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 15:18:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 13:18:27 +0000 Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Alex Arnaud --- This patch is a follow up. I have fixed errors reported by Owen and reformatted errors_filename template variable for T:T. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 15:19:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 13:19:35 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon's AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2165|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 10024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10024&action=edit Bug 4460 - Amazon's AssociateID tag not used in links so referred revenue lost Rewrite of patch authored by Reed Wade -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 15:19:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 13:19:49 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon's AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 15:27:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 13:27:51 +0000 Subject: [Koha-bugs] [Bug 7053] inner name patron searching fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7053 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6409|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 10025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10025&action=edit Bug 7053: patron name search Allows search on names containing spaces. Example: "LA JOIE" Allows search on strings included in name Example: "james acevedo" to find "henry hames acevedo III" -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 15:28:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 13:28:07 +0000 Subject: [Koha-bugs] [Bug 7053] inner name patron searching fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7053 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 15:33:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 13:33:54 +0000 Subject: [Koha-bugs] [Bug 3701] If the ReturnToShelvingCart syspref is on, and something needs to go in transit, the shelving cart setting is overriding the transit. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3701 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #1524|0 |1 is obsolete| | --- Comment #1 from Kyle M Hall --- Created attachment 10026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10026&action=edit BugFix - ReturnToShelvingCart If the ReturnToShelvingCart syspref is on, and something needs to go in transit, the shelving cart setting is overriding the transit. What seems to be happening is this: * Item is checked in, and flagged as needing to go in transit from A to B. * Item is immediately flagged as shelving cart, though. Current display says both shelving cart and in transit. * After the cart-to-shelf script runs, item comes out of transit and shows as being available at the destination library, although it hasn't arrived yet and no one has manually checked it in. It looks like the "checkin" from the script is telling Koha that the in-transit has been received. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 15:34:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 13:34:11 +0000 Subject: [Koha-bugs] [Bug 3701] If the ReturnToShelvingCart syspref is on, and something needs to go in transit, the shelving cart setting is overriding the transit. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3701 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 15:36:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 13:36:21 +0000 Subject: [Koha-bugs] [Bug 8218] New: Add a script to sanitize entity where "&" character was wrongly replaced with "& " Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Priority: P5 - low Change sponsored?: --- Bug ID: 8218 Assignee: gmcharlt at gmail.com Summary: Add a script to sanitize entity where "&" character was wrongly replaced with "&" Severity: enhancement Classification: Unclassified OS: All Reporter: sophie.meynieux at biblibre.com Hardware: All Status: NEW Version: unspecified Component: MARC Authority data support Product: Koha In some import dealing with authorities like "vendangeur", some bug introduced some misleading "&" character in title or comment. This script remove them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 15:36:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 13:36:25 +0000 Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6576|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 10027 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10027&action=edit Bug 3280 Restrict Send basket feature In order to prevent spamming using sendbasket.pl, some counter-measure are done: - permit send basket only for authenticated user - permit send basket only if basket contains items - use username & email for 'To' field (with fallback to KohaAdminEmailAddress) - add field X-Orig-IP with IP of sender - add field X-Abuse-Report with KohaAdminEmailAddress -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 15:36:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 13:36:39 +0000 Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 15:45:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 13:45:23 +0000 Subject: [Koha-bugs] [Bug 3541] Show items on hold as not available In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3541 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED CC| |kyle.m.hall at gmail.com Resolution|--- |WORKSFORME --- Comment #1 from Kyle M Hall --- Shows as 'on hold' rather than 'on loan', but the end product is the same; The borrower knows it's not on the shelf and won't go looking for it be accident. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:09:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:09:10 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9785|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 10028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10028&action=edit [SIGNED-OFF] Bug 7642 - OpacShowTagCloudWeight system preference This system preference allows the mouseover text on the tag cloud to be turned off. The text consists of the weight for the tag, but users are more likely to confuse it with the number of items that have this tag. Signed-off-by: Katrin Fischer Works as advertised, tiny change to the HTML output. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:09:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:09:20 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:09:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:09:32 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #9 from Katrin Fischer --- Leaving decision to QA team and RM. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:11:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:11:44 +0000 Subject: [Koha-bugs] [Bug 5983] Change the wording around the CAS login In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3489|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:15:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:15:24 +0000 Subject: [Koha-bugs] [Bug 5983] Change the wording around the CAS login In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED CC| |kyle.m.hall at gmail.com Resolution|--- |WORKSFORME --- Comment #9 from Kyle M Hall --- Looks like this was implemented by another patch at some point. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:15:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:15:25 +0000 Subject: [Koha-bugs] [Bug 5584] BibLibre OPAC improvements for 3.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5584 Bug 5584 depends on bug 5983, which changed state. Bug 5983 Summary: Change the wording around the CAS login http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5983 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:21:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:21:24 +0000 Subject: [Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #5 from Alex Arnaud --- Created attachment 10029 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10029&action=edit Bug 5979 - Follow up: using OPACISBD systempreference to display link -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:22:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:22:19 +0000 Subject: [Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Alex Arnaud --- This follow up adds the OPACISBD syspref -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:26:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:26:28 +0000 Subject: [Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from M. de Rooy --- QA Comment: All earlier points have been revisited and corrected. Only discussion on routine left. Your query is somewhat lighter, but we still speak about one record. No objection however to this new routine. Let me put the status to Passed QA now and leave it to RM ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:27:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:27:14 +0000 Subject: [Koha-bugs] [Bug 7129] actual cost showing too many zeros In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7305|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 10030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10030&action=edit Bug 7129: Added a sprintf to format the actual cost. Signed-off-by: Katrin Fischer Rebased to current master, please test. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:27:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:27:21 +0000 Subject: [Koha-bugs] [Bug 8167] Add syspref allow a choice of blocking, non-blocking, or do nothing when issuing lost items. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8167 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #3 from Paul Poulain --- I've pushed the patch because it works as advertised BUT I feel that: + nothing : "do nothing" can be confusing. Does it mean "do the check-in without saying anything" or "refuse to do the check-in". (Reading the code it's "do the check-in saying nothing") -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:27:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:27:32 +0000 Subject: [Koha-bugs] [Bug 7129] actual cost showing too many zeros In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:31:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:31:19 +0000 Subject: [Koha-bugs] [Bug 7619] 3M self checkout don't work in France In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7937|0 |1 is obsolete| | Assignee|paul.poulain at biblibre.com |colin.campbell at ptfs-europe. | |com --- Comment #12 from Colin Campbell --- Created attachment 10031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10031&action=edit Revised Patch I was tempted to sign this off as I've had to implement my own version of Paul's patch on two or three sites. However I've abstracted it sightly using a constant for the message terminator and adding comments describing how to reset this. In the longer term we should extract this out to allow the parameter to be settable by the admin user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:33:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:33:52 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9909|0 |1 is obsolete| | --- Comment #7 from Marc V?ron --- Created attachment 10032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10032&action=edit [SIGNED-OFF] Bug 5349: Order line transfers On basket.pl and parcel.pl there is a 'Transfer' link which allow you to transfer order lines from a basket to another. The link lead to a new page which allow you to search for a bookseller, then display this bookseller's baskets. Then you can pickup a basket and the transfer will be done. This add a message in new column aqorders.internalnotes which is displayed in basket.pl Signed-off-by: Marc Veron Note: Tested with different Vendors and Baskets, works as expected. Small glitch in ergonomy: The page where you can choose the new bookseller could better be a pop up like in Patrons->Guarantor information->Set to patron. Otherwise users could mistake and use the Vendors search at the top of the page (is active by default). If they do so they loose track of the transfer process. This could be fixed in a follow up - will sign off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:34:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:34:21 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:36:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:36:27 +0000 Subject: [Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|koha.sekjal at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:38:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:38:19 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9861|0 |1 is obsolete| | --- Comment #60 from Chris Cormack --- Created attachment 10033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10033&action=edit Bug 7167, tiny display change, separating koha number and DBrev applied This patch separated the Koha number and the list of database revision that have been applied on this database. Before the patch: a single string was computed in .pl and displayed After the patch: the string containing the kohaVersion and the string containing the list of database revisions applied have been splitted in 2 separate T::T variable The display has been updated a little, with a new string in the template Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:39:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:39:35 +0000 Subject: [Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #18 from Paul Poulain --- After discussing of this with Matthias (hackfest), I mark failed QA = the gain in terms of performance is tiny, and it would add a sub that isn't necessary. We're trying to gain speed, but also remove code or at least not intruduce useless one) marking failed QA, sorry -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:40:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:40:41 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9862|0 |1 is obsolete| | --- Comment #61 from Chris Cormack --- Created attachment 10034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10034&action=edit Bug 7167 follow-up display tweaking * changing datatable look to have the same as other places where datatable is used * removing some ul/li that made comment, query and errors be displayed in a tiny width * reordering header and adding missing datatables-strings.inc Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:41:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:41:08 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:45:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:45:30 +0000 Subject: [Koha-bugs] [Bug 6141] html glitches causing problems to translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10011|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 10035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10035&action=edit Bug 6141 - html glitches causing problems to translator Simple fix, works... 'nuff said' -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:47:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:47:38 +0000 Subject: [Koha-bugs] [Bug 6141] html glitches causing problems to translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Signed off... but: Can anyone care to explain what the Importance being set to "PATCH-Sent (DO NOT USE)" actually means? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:50:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:50:26 +0000 Subject: [Koha-bugs] [Bug 7379] copynumber is displayed 'as is' when linked to autorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7379 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7977|0 |1 is obsolete| | --- Comment #23 from Adrien SAURAT --- Created attachment 10036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10036&action=edit proposed patch #3 New patch, with default value appearing in "moredetail" even if the AV does not exist. (to test this specific behaviour : select a value then delete the AV associated to it) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:52:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:52:22 +0000 Subject: [Koha-bugs] [Bug 7379] copynumber is displayed 'as is' when linked to autorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7379 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:57:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:57:25 +0000 Subject: [Koha-bugs] [Bug 8092] Koha should use CHI caching framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8092 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9664|0 |1 is obsolete| | Attachment #9802|0 |1 is obsolete| | --- Comment #9 from Jared Camins-Esakov --- Created attachment 10037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10037&action=edit Bug 8092: Cheer up Jenkins on loading Cache modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:58:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:58:10 +0000 Subject: [Koha-bugs] [Bug 8092] Koha should use CHI caching framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8092 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 16:58:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 14:58:22 +0000 Subject: [Koha-bugs] [Bug 8092] Koha should use CHI caching framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8092 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 17:04:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 15:04:18 +0000 Subject: [Koha-bugs] [Bug 8178] circ/circulation.pl under plack duplicates checkout rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8178 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9885|0 |1 is obsolete| | --- Comment #3 from Alex Arnaud --- Created attachment 10038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10038&action=edit [Signed-off] Bug 8178 - circ/circulation.pl under plack duplicates checkout rows Bug 7851 introduced our scoping for vairables, unfortunatly it has side-effect that checkout rows accumulate on page reloads instead of being initialized to empty array (which this patch fixes) This also fixes %renew_failed initialization on each request. Test scenario: 1. start intranet under plack 2. open /cgi-bin/koha/circ/circulation.pl and reload page few time confirming that rows gets duplicated 3. apply patch and reload page to verify that it works Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 17:04:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 15:04:38 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger at biblibr | |e.com --- Comment #25 from Matthias Meusburger --- Apart from the bugs reported by Marc, I found a blocking bug too. Showing a basket (cgi-bin/koha/acqui/basket.pl?basketno=xxx) produces a software error: Software error: Undefined subroutine &main::get_infos called at /home/koha/versions/kohacommunity/acqui/basket.pl line 272. Of course, it does not happen without the patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 17:05:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 15:05:07 +0000 Subject: [Koha-bugs] [Bug 8178] circ/circulation.pl under plack duplicates checkout rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8178 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 17:05:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 15:05:13 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 --- Comment #1 from Sophie MEYNIEUX --- Created attachment 10039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10039&action=edit Bug 8218 : Adding SanitizeEntity and entity_clean sub which replace & by & in a record Bug 8218 : adding script for maintenance to clean any & in strings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 17:06:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 15:06:00 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 17:06:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 15:06:12 +0000 Subject: [Koha-bugs] [Bug 8218] Add a script to sanitize entity where "&" character was wrongly replaced with "& " In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8218 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |sophie.meynieux at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 17:14:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 15:14:51 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #26 from Matthias Meusburger --- About the items repetion, javascript fails on the page because a call function called calcNeworderTotal is triggered but never defined. That causes entered items fields never to be hidden. Hence the repetition. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 17:17:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 15:17:13 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9834|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize --- Created attachment 10040 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10040&action=edit Bug 7751 : Decrease Loans for Items with Highholds Re-based again to apply to master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 17:29:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 15:29:08 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 --- Comment #7 from claire.hernandez at biblibre.com --- Created attachment 10041 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10041&action=edit Fix indenting mistakes Fix error parse yaml files with $ perl yaml_valid.pl -f After fixing all these mini mistakes I got: $ prove yaml_valid.t yaml_valid.t .. ../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences at yaml_valid.t line 27. yaml_valid.t .. ok All tests successful. Files=1, Tests=16, 0 wallclock secs ( 0.04 usr 0.00 sys + 0.45 cusr 0.00 csys = 0.49 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 17:32:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 15:32:59 +0000 Subject: [Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9893|0 |1 is obsolete| | --- Comment #4 from Alex Arnaud --- Created attachment 10042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10042&action=edit [Signed-off] Bug 7952 - PDF::Reuse under plack writes to console STDOUT instead to browser Without name option to prFile, PDF::Reuse opens '-' file which is real console STDOUT on plack so pdf file gets emited to terminal instead of sending it to browser. This change creates temporary file using File::Temp, pass it to PDF::Reuse and then reads it back and prints it out for plack (or CGI) to pick up. DEBUG=1 it will debugging output Test secenario: 1. Home ? Tools ? Patron Card Creator ? Manage Card Batches 2. select batch checkbox and click Export 3. select template and click Export 4. click on pdf file to download it Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 17:33:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 15:33:38 +0000 Subject: [Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 17:34:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 15:34:04 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9277|0 |1 is obsolete| | Attachment #9278|0 |1 is obsolete| | Attachment #10041|0 |1 is obsolete| | --- Comment #8 from claire.hernandez at biblibre.com --- Created attachment 10043 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10043&action=edit replace old patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 17:34:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 15:34:52 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10043|0 |1 is obsolete| | --- Comment #9 from claire.hernandez at biblibre.com --- Created attachment 10044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10044&action=edit Bug-7994-scripts-to-check-yaml-files.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 17:35:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 15:35:23 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 --- Comment #10 from claire.hernandez at biblibre.com --- Created attachment 10045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10045&action=edit Bug-7994-Fix-indenting-mistakes.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 17:38:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 15:38:21 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #11 from claire.hernandez at biblibre.com --- Should be better: $ git bz apply 7994 ... $ cd xt $ prove yaml_valid.t yaml_valid.t .. ../koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences at yaml_valid.t line 27. yaml_valid.t .. ok All tests successful. Files=1, Tests=16, 1 wallclock secs ( 0.04 usr 0.01 sys + 0.46 cusr 0.01 csys = 0.52 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 18:19:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 16:19:43 +0000 Subject: [Koha-bugs] [Bug 7815] Order pickup library list by name rather than by code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7815 Marijana Glavica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8593|0 |1 is obsolete| | --- Comment #3 from Marijana Glavica --- Created attachment 10046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10046&action=edit [SIGNED-OFF] Bug 7815 : Order pickup libraries list by name rather than by code Signed-off-by: Marijana Glavica -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 18:20:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 16:20:51 +0000 Subject: [Koha-bugs] [Bug 7815] Order pickup library list by name rather than by code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7815 Marijana Glavica changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mglavica at ffzg.hr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 18:29:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 16:29:56 +0000 Subject: [Koha-bugs] [Bug 5337] acq EAN search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 18:34:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 16:34:15 +0000 Subject: [Koha-bugs] [Bug 7161] Open Library - Larger image, Read, borrow and checked-out status In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #8 from Paul Poulain --- Marcel, you already made a 1st QA, so I let this one for you. Looking at the code I don't see anything wrong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 18:36:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 16:36:27 +0000 Subject: [Koha-bugs] [Bug 7211] Invoice number not saved when selecting a later page in Receive shipment In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7211 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- I can't reproduce this on current master, but might only be in 3.4 in maybe in 3.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 18:43:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 16:43:14 +0000 Subject: [Koha-bugs] [Bug 8177] Correct a double declaration of variable in Addreturn subroutine In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8177 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- I checked the code on current master and the problem seems to be resolved there. Marking the patch resolved for this reason. if($issue->{'overdue'}){ my ( $amount, $type, $daycounttotal ) = C4::Overdues::CalcFine( $item, $borrower->{categorycode},$branch, $datedue, $today ); $type ||= q{}; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 18:43:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 16:43:42 +0000 Subject: [Koha-bugs] [Bug 7747] Replace YUI autocomplete with jQueryUI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9880|0 |1 is obsolete| | --- Comment #10 from Michael Davis --- Created attachment 10047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10047&action=edit [SIGNED-OFF] Bug 7747 [FOLLOW-UP] Replace YUI autocomplete with jQueryUI This patch removes the template calls to the now-obsolete YUI JS dependencies and removes the relevant YUI files themselves. First two work perfectly, circulation search header and overdues patron authorized value. Authorities search does not seem to work, old yui file are still referenced in auth_finder.tt. The jquery works, but data set is not found, or I messed up my authority record. Signed-off-by: Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 18:49:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 16:49:55 +0000 Subject: [Koha-bugs] [Bug 7411] remove diacritics when automatically generating userid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|sophie.meynieux at biblibre.co |katrin.fischer at bsz-bw.de |m | --- Comment #6 from Katrin Fischer --- I talked to Sophie and will try writing a patch using the module suggested by Dobrica. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 18:50:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 16:50:10 +0000 Subject: [Koha-bugs] [Bug 7951] Suspending holds needs a system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7951 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #7 from Paul Poulain --- QA comment: * small patch that improves a recently added feature * does that in the most logical way * nothing to say from coding guidelines POV passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 19:13:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 17:13:35 +0000 Subject: [Koha-bugs] [Bug 8004] Items on Hold Lose Transfer After Being Scanned Twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #3 from Paul Poulain --- QA comment: * Kyle, what is fun is the answer to your question: > This is because at some point, someone replaced the template > variable WrongTransfer, which had previously contained the branchcode for > the library to transfer to, with the full name of the library instead ( I > assume to make a look nicer ). git blame circ/returns.pl, says: 74f6e35c (Kyle M Hall 2010-04-01 15:45:25 +0000 340) $messages->{'WrongTransfer'} = GetBranchName( $messa... :D :D (and, incenditally, it's 2 years old !) However, this is a tiny patch, that adds a new plugin. After the presentation chris made today about T::T plugins/views/..., i'm wondering if creating a plugin for that is the best option we have. Shouldn't it be a view ? Plus, if I push this patch, it means we should get rid of any branchname display everywhere, remove LEFT JOIN branches USING(branchname) in many SQL queries, cache GetBranchName to avoid useless SQL queries (branches are not updated frequently, they are a good candidate for caching). I'm not against this idea (in fact, I like it quite a lot), but we must advertise it as much as possible, and if you can promize you'll take care of patches cleaning branchname dependancies, that would be a good + ;-) I won't push the patch immediately, I suggest we speak of it tomorrow with other hackers, and chris_c first, as he is experienced on T::T -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 19:16:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 17:16:53 +0000 Subject: [Koha-bugs] [Bug 5292] Google Preview Option for OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5292 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org --- Comment #13 from Dobrica Pavlinusic --- Excuse my ignorance, but in current master we already have Google preview link when using google book covers. Why do we need another implementation of it? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 19:17:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 17:17:20 +0000 Subject: [Koha-bugs] [Bug 7411] remove diacritics when automatically generating userid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7064|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 10048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10048&action=edit Bug 7411: Remove diacritics from generated userid Patch introduces a new module Text::Unaccent. To test: 1) Add a new patron with diacritics in surname and first name, leave userid empty. 2) Save user and check the created userid has only the base characters and diacritics have been removed correctly. 3) Create another user with the same surname and first name, check userid is generated correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 19:17:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 17:17:42 +0000 Subject: [Koha-bugs] [Bug 7411] remove diacritics when automatically generating userid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 19:28:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 17:28:28 +0000 Subject: [Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain at biblibre.com --- Comment #16 from Paul Poulain --- (In reply to comment #15) > Changing status back to "signed off" because the first patch needs QA from > someone other than Ian, please. Melia, when you say "1st patch", are you talking of 3.6.x or http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9487 (Talking Tech Support - Phase I) ? QA comments (considering the 3.6.x patch is irrelevant) 1- the 3 patches (excludint 3.6.x one) apply smoothly on master 2- I tested with the syspref OFF (default), no noticeable change, as expected 3- the 2 new scripts does not pass perlcritic: misc/cronjobs/thirdparty/TalkingTech_itiva_inbound.pl: Two-argument "open" used at line 63, column 4. See page 207 of PBP. (Severity: 5) misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl: Bareword file handle opened at line 87, column 4. See pages 202,204 of PBP. (Severity: 5) misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl: Two-argument "open" used at line 87, column 4. See page 207 of PBP. (Severity: 5) misc/cronjobs/thirdparty/TalkingTech_itiva_outbound.pl: Bareword file handle opened at line 90, column 4. See pages 202,204 of PBP. (Severity: 5) 4- You changed the signature of the Enqueueletter sub: - return $result; + return $dbh->last_insert_id(undef,undef,'message_queue', undef); However, others use of this sub weren't managing any returned value, so that's not a problem. Please fix 3 and explain what should be done with the 3.6.x patch (obsoleted ?) to earn passed QA status -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 19:34:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 17:34:20 +0000 Subject: [Koha-bugs] [Bug 8062] Cart email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #16 from Paul Poulain --- QA comment: * small patch, that uses a T::T plugin to fix an annoying problem * introduces a new dependency that could be usefull in other circumstances, so it's OK * remove some commented/dead code ++ * opac/opac-sendbasket.pl still passes perlcritic passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 19:34:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 17:34:43 +0000 Subject: [Koha-bugs] [Bug 8062] Cart email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_8 --- Comment #17 from Paul Poulain --- critical problem in non-english languages, worth porting it to 3.8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 19:35:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 17:35:00 +0000 Subject: [Koha-bugs] [Bug 8062] Cart email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 19:35:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 17:35:56 +0000 Subject: [Koha-bugs] [Bug 2930] Put other name on CKO screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2930 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- The attached patch makes a lot of changes not related to the bug description. The display name of the patron is generated in an include file now: [% IF category_type == 'I' %] [% surname %] [% IF othernames %] ([% othernames %]) [% END %] [% ELSE %] [% firstname %] [% surname %] [% END %] ([% cardnumber %]) So for an "organisation" the othername will already be displyed. How should the display for othername look like? Can we agree on something here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 19:36:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 17:36:21 +0000 Subject: [Koha-bugs] [Bug 2930] Put other name on CKO screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2930 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=5172 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 19:36:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 17:36:21 +0000 Subject: [Koha-bugs] [Bug 5172] Use other name rather than first name when referring to the user In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5172 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=2930 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 19:36:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 17:36:27 +0000 Subject: [Koha-bugs] [Bug 7951] Suspending holds needs a system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7951 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 19:36:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 17:36:27 +0000 Subject: [Koha-bugs] [Bug 2930] Put other name on CKO screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2930 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_2 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 19:37:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 17:37:02 +0000 Subject: [Koha-bugs] [Bug 7411] remove diacritics when automatically generating userid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10048|0 |1 is obsolete| | --- Comment #8 from Dobrica Pavlinusic --- Created attachment 10049 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10049&action=edit Bug 7411: Remove diacritics from generated userid Patch introduces a new module Text::Unaccent. To test: 1) Add a new patron with diacritics in surname and first name, leave userid empty. 2) Save user and check the created userid has only the base characters and diacritics have been removed correctly. 3) Create another user with the same surname and first name, check userid is generated correctly. Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 19:37:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 17:37:25 +0000 Subject: [Koha-bugs] [Bug 7411] remove diacritics when automatically generating userid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 19:39:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 17:39:07 +0000 Subject: [Koha-bugs] [Bug 5292] Google Preview Option for OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5292 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 19:50:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 17:50:51 +0000 Subject: [Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8639|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 21:18:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 19:18:31 +0000 Subject: [Koha-bugs] [Bug 6554] Broken encoding in members home/search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 --- Comment #31 from Jared Camins-Esakov --- Dobrica, Could you please resubmit the patch for this bug in git format? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 21:22:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 19:22:46 +0000 Subject: [Koha-bugs] [Bug 6713] marc import not matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6713 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4975|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 21:29:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 19:29:20 +0000 Subject: [Koha-bugs] [Bug 6713] marc import not matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6713 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 21:38:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 19:38:10 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9746|0 |1 is obsolete| | Attachment #9747|0 |1 is obsolete| | Attachment #9748|0 |1 is obsolete| | Attachment #9749|0 |1 is obsolete| | Attachment #9750|0 |1 is obsolete| | --- Comment #68 from Jared Camins-Esakov --- Created attachment 10050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10050&action=edit Bug 6679: Fixing 26 perlcritic violations in C4/Tags.pm Subroutine prototypes used at line XXX, column 1. See page 194 of PBP. (Severity: 5) Note: Rebased on master 06/09/2012 by jcamins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 21:38:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 19:38:31 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #69 from Jared Camins-Esakov --- Created attachment 10051 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10051&action=edit Bug 6679: Fixing 23 perlcritic violations in C4/Tags.pm return" statement with explicit "undef" at line XXX, column 26. See page 199 of PBP. (Severity: 5) note: i have tested the Tags feature OK, after appliying this patch Note: Rebased on master 06/09/2012 by jcamins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 21:38:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 19:38:43 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #70 from Jared Camins-Esakov --- Created attachment 10052 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10052&action=edit Bug 6679: Fixing 5 perlcritic violations in opac/* 1 more to go... :) opac/changelanguage.pl: Code before strictures are enabled at line 24, column 1. See page 429 of PBP. (Severity: 5) Note: Rebased on master 06/09/2012 by jcamins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 21:38:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 19:38:54 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #71 from Jared Camins-Esakov --- Created attachment 10053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10053&action=edit Bug 6679: Fixing 24 perlcritic violations in misc/translator/TmplTokenizer.pm Subroutine prototypes used at line XXX, column 1. See page 194 of PBP. (Severity: 5) Note: Rebased on master 06/09/2012 by jcamins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 21:39:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 19:39:10 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #72 from Jared Camins-Esakov --- Created attachment 10054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10054&action=edit Bug 6679: Fixing 13 perlcritic violations in C4/Barcodes.pm Subroutine prototypes used at line XXX, column 1. See page 194 of PBP. (Severity: 5) Note: Rebased on master 06/09/2012 by jcamins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 21:39:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 19:39:40 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #73 from Jared Camins-Esakov --- All patches rebased on latest master. Signoff needed. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 21:43:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 19:43:37 +0000 Subject: [Koha-bugs] [Bug 5600] Bulk MARC biblio export script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Jared Camins-Esakov --- When I apply this patch and try to view tools/export.pl in the web browser, I got the following software error: Can't use an undefined value as a HASH reference at /home/jcamins/kohaclone/tools/export.pl line 99. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 21:53:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 19:53:13 +0000 Subject: [Koha-bugs] [Bug 8180] cataloguing/additem.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 --- Comment #2 from Jared Camins-Esakov --- This works fine for me under Plack. Can you please confirm exactly how one would go about reproducing this bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 22:03:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 20:03:10 +0000 Subject: [Koha-bugs] [Bug 8166] Adding new currencies & exchange rates if not fill any field it save blank record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8166 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9846|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov --- Created attachment 10055 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10055&action=edit Bug 8166 - Adding new currencies & exchange rates if not fill any field it save blank record To Test: 1) Go to Currencies & Exchange rates. 2) Create New currency 3) If you not fill any field for ex: (Currency, rate, symbol) it will not save the record. Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 22:06:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 20:06:48 +0000 Subject: [Koha-bugs] [Bug 8166] Adding new currencies & exchange rates if not fill any field it save blank record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8166 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 9 23:49:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Jun 2012 21:49:14 +0000 Subject: [Koha-bugs] [Bug 8180] cataloguing/additem.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 --- Comment #3 from Dobrica Pavlinusic --- I just verified it with current master using following: 1. search for word in intranet (I'm using human with URL /cgi-bin/koha/catalogue/search.pl?idx=kw&q=human&idx=kw&q=&idx=kw&q=&limit=&limit=&limit=&limit=&limit=&sort_by=relevance) 2. select "edit item" from first result 3. press "add item" button on add item form 4. Can't call method "prepare" on an undefined value at /srv/koha/cataloguing/additem.pl line 88. Hope this helps. p.s. I can also reproduce it with different search queries, and this patch still fixes problem for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 02:39:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 00:39:00 +0000 Subject: [Koha-bugs] [Bug 8219] New: get_biblio_authorised_values embarrassingly inefficient Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8219 Priority: P5 - low Change sponsored?: --- Bug ID: 8219 Assignee: gmcharlt at gmail.com Summary: get_biblio_authorised_values embarrassingly inefficient Severity: normal Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha The routine C4::Biblio::get_biblio_authorised_values is horrifyingly inefficient. In a relatively low-powered system with a large number of authorized values, exclusive time in get_biblio_authorised_values can be several seconds or more when doing a search, since the routine is called once per result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 03:29:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 01:29:42 +0000 Subject: [Koha-bugs] [Bug 5871] CSS changes for OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5871 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Jared Camins-Esakov --- The CSS has been incorporated into the patch on bug 5888. Closing. *** This bug has been marked as a duplicate of bug 5888 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 03:29:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 01:29:42 +0000 Subject: [Koha-bugs] [Bug 5888] opac-detail subject/author links improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888 --- Comment #12 from Jared Camins-Esakov --- *** Bug 5871 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 03:29:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 01:29:43 +0000 Subject: [Koha-bugs] [Bug 5584] BibLibre OPAC improvements for 3.4 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5584 Bug 5584 depends on bug 5871, which changed state. Bug 5871 Summary: CSS changes for OPAC http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5871 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 03:46:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 01:46:44 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 --- Comment #33 from Jared Camins-Esakov --- Katrin, (In reply to comment #32) > (kohafield IS NULL OR kohafield = '') means the data is saved to > more_subfields_xml. I disagree with failing the patch because of the mapping update. It very carefully makes sure not to clobber any existing mappings. The only case where an existing mapping might be clobbered is if someone has manually created an items.nonpublicnote column and mapped something other than 952$x to it. If someone already has non-public notes in their item records, adding the mapping will not make it any more inaccessible than it already is. To restate the following SQL in English: UPDATE marc_subfield_structure SET kohafield='items.nonpublicnote' WHERE (kohafield IS NULL OR kohafield = '') AND tagfield='952' AND tagsubfield='x' "Map 952$x to items.nonpublicnote if and only if 952$x is not mapped to anything else." The updatedatabase is MARC21/NORMARC-specific, though, and doesn't check that the flavour is MARC21 or NORMARC before updating. I will add a follow-up adjusting it to check the marcflavour, and also not remap items.nonpublicnote if it has already been mapped to a field. I think it's much better to have non-public notes accessible in some cases than none, which is our current situation. I can already edit non-public item notes. Also, it's worth noting that if someone has changed their mappings for the 952 field, they will have had to redo the Zebra configuration files, so they clearly know what they are doing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 04:05:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 02:05:50 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8048|0 |1 is obsolete| | --- Comment #34 from Jared Camins-Esakov --- Created attachment 10056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10056&action=edit Bug 4222 - allow nonpublicnote to be a mapped DB column This means that it's possible (and easy) to put non-public notes (usually 952$x) on a template, same as public notes. It creates a mapping between the 952$x field and the new database column. Note that when this is applied, it will only work on newly saved records. It is possible this will need to be altered to allow for UNIMARC etc. if they use 952 differently. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 04:06:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 02:06:03 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 --- Comment #35 from Jared Camins-Esakov --- Created attachment 10057 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10057&action=edit Bug 4222 followup: Do not update mappings unless we ought This follow-up modifies the database update for 4222 to only modify mappings if the installation is not UNIMARC, and nothing else has been mapped to the items.nonpublicnotes column (which did not exist before the patch for bug 4222). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 04:06:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 02:06:17 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 05:02:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 03:02:14 +0000 Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6389|0 |1 is obsolete| | --- Comment #12 from Jared Camins-Esakov --- Created attachment 10058 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10058&action=edit Bug 6828 - Add basic Dashboard for staff users. This enhancement adds the option of switching on/off a Dashboard on the Staff users mainpage. The information displayed is specific to the users logged in branch but will also show a system wide overview. Its visibility is controlled by a new SysPref. This first revision takes its data from an XML file which needs to be populated on a cronjob. The file to run is in misc/migration_tools/dashboard_xml.pl. The usual Koha env will need to be set for the user running the script. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 05:02:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 03:02:32 +0000 Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 --- Comment #13 from Jared Camins-Esakov --- Created attachment 10059 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10059&action=edit Bug 6828 follow-up: adapt dashboard to new staff client theme This follow-up makes a few cosmetic changes: * Moves the dashboard to underneath the "pending" panel * Switches the layout to CSS-based instead of table-based * Makes the error message translatable * Reindents some sections of the added code to make things more readable -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 05:05:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 03:05:17 +0000 Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 05:16:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 03:16:28 +0000 Subject: [Koha-bugs] [Bug 6855] bullet point showing in wrong place on error message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5408|0 |1 is obsolete| | --- Comment #6 from Jared Camins-Esakov --- Created attachment 10060 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10060&action=edit Fix for Bug 6855 - List bullet showing in wrong place on error message Added some more specific CSS to help Webkit browsers display the lists bullets correctly. Signed-off-by: Jared Camins-Esakov Rebased 9 June 2012. Signing off as well, since the rebase and test were trivial. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 05:17:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 03:17:33 +0000 Subject: [Koha-bugs] [Bug 6855] bullet point showing in wrong place on error message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 05:17:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 03:17:44 +0000 Subject: [Koha-bugs] [Bug 6855] bullet point showing in wrong place on error message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 05:18:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 03:18:25 +0000 Subject: [Koha-bugs] [Bug 6855] bullet point showing in wrong place on error message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 --- Comment #7 from Jared Camins-Esakov --- Created attachment 10061 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10061&action=edit Error message on Chrome for Mac after patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 08:49:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 06:49:22 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 --- Comment #36 from Katrin Fischer --- Hi Jared, I might be wrong here, because I can't remember disagreeing with you. :) But I think maybe I didn't explain it well before? If you leave the mapping empty (which yes, we did...) the value will be saved into the more_subfields_xml column in XML format. So after updating the mapping, the value will still be there, but you will not be able to access the information from the interface. So I was suggesting that there should be a way to copy that information into the new field or give at least a warning, that you might have to do so. So it's not only when people created a new column, but also when they were using the methods Koha provides to add additional subfields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 10:35:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 08:35:38 +0000 Subject: [Koha-bugs] [Bug 7747] Replace YUI autocomplete with jQueryUI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |m.r.davis at cranfield.ac.uk --- Comment #11 from Michael Davis --- I would apply this, and open a new bug to resolve the authorities autocomplete search and to remove the redundant js files from auth_finder.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 10:37:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 08:37:03 +0000 Subject: [Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246 --- Comment #17 from Kyle M Hall --- Created attachment 10062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10062&action=edit Talking Tech Support - Phase I - Followup 3 - Follow PBP * Fixes violations of Perl Best Practices, where possible * perltidy both scripts -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 10:38:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 08:38:33 +0000 Subject: [Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 10:42:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 08:42:06 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #77 from Paul Poulain --- QA comment: all patches passes valid_templates.t and translatable_templates.t, passed QA. Will push & obsolet each patch now, switching to assigned for missing help files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 10:42:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 08:42:28 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9933|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 10:42:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 08:42:34 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9934|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 10:42:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 08:42:39 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9936|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 10:42:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 08:42:44 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9937|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 10:42:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 08:42:49 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9938|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 10:42:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 08:42:54 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9939|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 10:42:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 08:42:59 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for 3.8 help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9967|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 10:44:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 08:44:58 +0000 Subject: [Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 10:45:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 08:45:45 +0000 Subject: [Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Kyle M Hall --- Setting to Passed QA as per Paul's comments. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 10:46:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 08:46:46 +0000 Subject: [Koha-bugs] [Bug 7936] general ticket for help file updates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7936 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|general ticket for 3.8 help |general ticket for help |file updates |file updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 10:51:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 08:51:25 +0000 Subject: [Koha-bugs] [Bug 7308] new column in admin/aqbudgets In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7308 Marijana Glavica changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mglavica at ffzg.hr --- Comment #2 from Marijana Glavica --- I tested the patch. "Base level ordered" column is now visible. But there are few more things which maybe should be changed in this table: 1. Amount shown in "Base-level remaining" column should be same as "Avail" column in acqui/acqui-home.pl, i.e. remaining = allocated - ordered - spent. 2. We should have the same wording for this two columns for consistency reasons (available or remaining) 3. "Base-level remaining" column should also have sorting feature (Claire noticed that) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 10:57:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 08:57:46 +0000 Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #5 from Paul Poulain --- QA comment: * small patch that replaces a hardcoded value by a syspref * Despite his size, the content of the patch is tiny, loading the syspref, filling it to 3 chars, and using it instead of the default passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 10:57:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 08:57:57 +0000 Subject: [Koha-bugs] [Bug 7601] Preference for default language for field 008 Range 35-37 (instead of hard coded "eng") In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7601 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:00:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:00:00 +0000 Subject: [Koha-bugs] [Bug 7586] Search: Language restriction does NOT show expected results (no items shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7586 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #4 from Paul Poulain --- QA comment: really tiny patch, that just move ln:n:range(data,35,3) to ln:w:range(data,35,3) in a very long line. passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:02:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:02:00 +0000 Subject: [Koha-bugs] [Bug 7586] Search: Language restriction does NOT show expected results (no items shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7586 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 Severity|minor |normal --- Comment #5 from Paul Poulain --- Not a so minor bugfix, worth porting to 3.8.x (and be announced in the release notes, as it requires a copy of .abs file and full reindexing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:03:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:03:45 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |m.r.davis at cranfield.ac.uk --- Comment #4 from Michael Davis --- error: patch failed: koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc:29 error: koha-tmpl/intranet-tmpl/prog/en/includes/doc-head-close.inc: patch does not apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:05:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:05:48 +0000 Subject: [Koha-bugs] [Bug 7586] Search: Language restriction does NOT show expected results (no items shown) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7586 --- Comment #6 from Paul Poulain --- IMPORTANT NOTICE: Yesterday, I pushed the DOM indexing patch, that replaces, for new setup, record.abs to biblio-koha-indexdef.xml If I'm not wrong, the patch must also be ported here: ln:n => it should be ln:w isn't it ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:07:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:07:41 +0000 Subject: [Koha-bugs] [Bug 7872] C4::Items should use C4::Koha methods instead of duplicating SQL queries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7872 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #12 from Paul Poulain --- QA comment: this patch replaces 30 lines by 3, using an existing function to avoid duplicaing code dobrica++ ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:09:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:09:27 +0000 Subject: [Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |francois.charbonnier at biblib | |re.com --- Comment #16 from Francois Charbonnier --- I'm not sure I have been able to reproduce this bug. I didn't know the set up so, here are the set ups I used to test this : The count of "Holds allowed" within the circulation matrix (Library / Category code / Item type) is : All / All / All = 3 All / Librarian / Book = 3 Library A / All / All = 3 Library A / Librarian / Book = 3 I worked with 4 system preferences : * maxreserves * item-level_itypes * OPACItemHolds * ReservesControlBranch The maxreserves syspref is set up to : maxreserves = 4 Then I tried every set up possible with the three other sysprefs. I worked with 4 differents items that have : biblioitems.itemtype = Book items.itype = Book The patron I used to place hold is a Librarian from Library A. When I tested the set ups with OPACItemHolds = yes, every holds placed were on the item level. If OPACItemHolds was set up to "no", every holds placed were on the biblio level. What I noticed is that : * if koha knows the patron category code, the patron or the item library and the itemtype, the limit used is the one from the circulation matrix _BUT_ I have the wrong message : "Sorry, none of these items can be placed on hold". I should have "Sorry, you cannot place more than X holds." * if koha doesn't know the item's library ou the item's item type, I can't place more than 4 holds. So the limit comes from the maxreserves syspref. It's logical but I think, we should use the "default" rule from the circulation matrix instead to be more flexible. The maxreserves syspref should be used only when nothing else apply. Or maybe, we could get rid of the maxreserves syspref, saying that the default rule (Library =all / Category code = all / Item type = all) is the one koha should use when nothing apply. Since, the documentation says this rule is required, I think it would logical to give it a use. Set ups and test results : 1/ item-level_itypes = biblio OPACItemHolds = no ReservesControlBranch = patron's branch -> it looks like it works but I have the wrong message "Sorry, none of these items can be placed on hold". I should have "Sorry, you cannot place more than X holds." 2/ item-level_itypes = item OPACItemHolds = no ReservesControlBranch = patron's branch -> The control looks like it comes from "maxreserves". 3/ item-level_itypes = item OPACItemHolds = yes ReservesControlBranch = patron's branch -> it looks like it works but I have the wrong message "Sorry, none of these items can be placed on hold". I should have "Sorry, you cannot place more than X holds." 4/ item-level_itypes = biblio OPACItemHolds = no ReservesControlBranch = item's branch -> The control looks like it comes from "maxreserves". 5/ item-level_itypes = biblio OPACItemHolds = yes ReservesControlBranch = item's branch -> it looks like it works but I have the wrong message "Sorry, none of these items can be placed on hold". I should have "Sorry, you cannot place more than X holds." 6/ item-level_itypes = item OPACItemHolds = yes ReservesControlBranch = item's branch -> it looks like it works but I have the wrong message "Sorry, none of these items can be placed on hold". I should have "Sorry, you cannot place more than X holds." 7/ item-level_itypes = biblio OPACItemHolds = yes ReservesControlBranch = patron's branch -> it looks like it works but I have the wrong message "Sorry, none of these items can be placed on hold". I should have "Sorry, you cannot place more than X holds." 8/ item-level_itypes = item OPACItemHolds = no ReservesControlBranch = item's branch -> The control looks like it comes from "maxreserves". -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:11:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:11:37 +0000 Subject: [Koha-bugs] [Bug 7872] C4::Items should use C4::Koha methods instead of duplicating SQL queries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7872 --- Comment #13 from Paul Poulain --- (In reply to comment #10) > (In reply to comment #6) > > (In reply to comment #5) > > > > > LIMIT 1 is not needed since adding framework to WHERE always returns single > > > row and it's more correct. > > > > Why more correct ? I don't understand. > > For me, LIMIT 1 should be used if we want only a unique row. I think it can > > increase performance (I agree with you, it is negligible). > > Actually a where on an indexed column is a lot faster than using limit, > explain is a good tool for looking at the query plan to see how mysql is > optimising the query. There is a whole project of sql optimisation we could > do by checking some of our more used queries. Site comment: investigating DBI, we've found that all handlers are automatically closed when a query has returned all results. If plan not to fetch all results, then you must explicitely close $sth, or you may have some useless memory consumption -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:11:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:11:50 +0000 Subject: [Koha-bugs] [Bug 7872] C4::Items should use C4::Koha methods instead of duplicating SQL queries In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7872 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:12:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:12:09 +0000 Subject: [Koha-bugs] [Bug 8138] Add 773$t field to xslt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8138 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #40 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:15:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:15:17 +0000 Subject: [Koha-bugs] [Bug 6090] empty mails in message_queue are sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6090 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain at biblibre.com --- Comment #9 from Paul Poulain --- QA comment: there is an unconditionnal warn + warn "Trying to add an empty message to the message queue"; that is thrown every time there is an empty letter. This should be issued only if you're in DEBUG mode -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:16:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:16:51 +0000 Subject: [Koha-bugs] [Bug 5312] XHTML correction in authority summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #8 from Paul Poulain --- QA comment: tiny patch that produces valid XHTML, passes QA of course ! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:17:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:17:36 +0000 Subject: [Koha-bugs] [Bug 5312] XHTML correction in authority summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Passed QA |Pushed to Master Version|rel_3_2 |rel_3_8 --- Comment #9 from Paul Poulain --- worth porting to 3.8 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:19:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:19:43 +0000 Subject: [Koha-bugs] [Bug 8195] The selected link in include menus must be bold In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8195 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Pushed to 3.8.x, will be 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:20:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:20:58 +0000 Subject: [Koha-bugs] [Bug 8197] Software error when you have cleaned cookies in your browser and try to past the url to opac-topissues.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8197 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #3 from Paul Poulain --- QA comment: tiny patch that fixes an obvious problem in the best possible way, passes QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:21:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:21:08 +0000 Subject: [Koha-bugs] [Bug 8197] Software error when you have cleaned cookies in your browser and try to past the url to opac-topissues.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8197 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:25:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:25:33 +0000 Subject: [Koha-bugs] [Bug 7053] inner name patron searching fails In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7053 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Kyle M Hall --- Nicole, if this is still an issue, please reopen this bug. So far, we have been unable to reproduce the error. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:26:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:26:16 +0000 Subject: [Koha-bugs] [Bug 8119] Show hint when disabling active currency checkbox In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8119 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:27:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:27:04 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9981|0 |1 is obsolete| | --- Comment #8 from Marc V?ron --- Created attachment 10063 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10063&action=edit Bug 7563 [ENH] - Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference Configure slip printers to print slips (silently) to a special printer using the Firefox PlugIn jsPrintSetUp. All other print actions are not affected. See http://jsprintsetup.mozdev.org/ for all the possibilities (e.g. change header/footer, get a list of printers, set printer etc.). The overall concept is to have a new staff client preference (IntranetSlipPrinterJS) where one can enter the necessary JavaScript. If the preference is empty, Koha falls back to te default behaviour. An example of JavaScript can be found on: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 i# Please enter the commit message for your changes. Lines starting Signed-off-by: Marc Veron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:28:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:28:57 +0000 Subject: [Koha-bugs] [Bug 7548] Missing arguments in the pagination of receptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7548 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7951|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:29:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:29:58 +0000 Subject: [Koha-bugs] [Bug 7548] Missing arguments in the pagination of receptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7548 --- Comment #10 from Katrin Fischer --- Created attachment 10064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10064&action=edit 3.6.x patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:30:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:30:11 +0000 Subject: [Koha-bugs] [Bug 7548] Missing arguments in the pagination of receptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7548 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:30:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:30:19 +0000 Subject: [Koha-bugs] [Bug 7548] Missing arguments in the pagination of receptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7548 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:30:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:30:25 +0000 Subject: [Koha-bugs] [Bug 7548] Missing arguments in the pagination of receptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7548 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:31:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:31:08 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 --- Comment #9 from Marc V?ron --- Did not longer apply, redone patch. "Signed off by " in last comment by mistake. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:39:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:39:43 +0000 Subject: [Koha-bugs] [Bug 6267] custom http user-agent in check-url.pl (fix for books.google.com 401 error) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6267 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:49:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:49:29 +0000 Subject: [Koha-bugs] [Bug 7652] add item barcode on top of its editing form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7652 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #9 from Paul Poulain --- QA comment: tiny patch, that probably add some overhead because of GetBarcodeFromItemnumber sub, that queries SQL, but that's the proper way to handle this feature. Passes QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:51:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:51:08 +0000 Subject: [Koha-bugs] [Bug 7652] add item barcode on top of its editing form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7652 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:51:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:51:11 +0000 Subject: [Koha-bugs] [Bug 8220] New: Allow koc uploads to go to process queue instead of being applied directly. Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220 Priority: P5 - low Change sponsored?: --- Bug ID: 8220 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Allow koc uploads to go to process queue instead of being applied directly. Severity: enhancement Classification: Unclassified OS: All Reporter: kyle.m.hall at gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:51:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:51:20 +0000 Subject: [Koha-bugs] [Bug 8201] can't change receive date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8201 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|henridamien at koha-fr.org |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Ok, found the problem, patch coming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:51:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:51:26 +0000 Subject: [Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:52:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:52:18 +0000 Subject: [Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220 --- Comment #1 from Kyle M Hall --- Created attachment 10065 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10065&action=edit Bug 8220 - Allow koc uploads to go to process queue instead of being applied directly. The primary advantage to the Firefox offline cirulation plugin when compared to the offline circulation desktop application, is the ability to add offline circulation actions to a queue so that multiple machines running offline circ can have their circ actions combined and ordered chronologically before being executed. This commit adds the ability to put actions from uploaded KOC files into this queue. In this way, both the FF plugina and the desktop application can be run side by side with no ill effects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:54:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:54:36 +0000 Subject: [Koha-bugs] [Bug 4838] Repeated authority headings break biblio record data entry form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier at biblib | |re.com --- Comment #12 from Francois Charbonnier --- I tested this patch with Frederic indications and it works fine. I tested both links, everything was ok. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:55:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:55:34 +0000 Subject: [Koha-bugs] [Bug 4838] Repeated authority headings break biblio record data entry form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 --- Comment #13 from Francois Charbonnier --- Created attachment 10066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10066&action=edit [SIGNED-OFF] Bug 4838 Fix repeated authorities selection How to test: Create an authority, with more than one heading, for example a UNIMARC multilingual author: 200 $7 da $a ? $b ?? 200 $7 ba $a Hara $b Junsuke In data entry form, on 700 field, you click on ... Search for the above author. In auhtority search result page, you just have a 'Choose' link, and so you just can select the first heading (in Chinesse writing). Apply the patch. Repeat. Now you have, on result page, you have two links, and can select one heading or the other. Signed-off-by: Fran?ois Charbonnier -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:56:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:56:42 +0000 Subject: [Koha-bugs] [Bug 4838] Repeated authority headings break biblio record data entry form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:57:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:57:25 +0000 Subject: [Koha-bugs] [Bug 4838] Repeated authority headings break biblio record data entry form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9919|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:58:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:58:09 +0000 Subject: [Koha-bugs] [Bug 8201] can't change receive date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8201 --- Comment #4 from Katrin Fischer --- Created attachment 10067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10067&action=edit Bug 8201: Receive date not passed through correctly All orders were received with today's date instead of the receive date given with the invoice number. To test: 1) Add an order with a few order lines 2) Create a new invoice, receive date != today's date 3) Start receiving orders, check date on receive screens is correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:58:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:58:28 +0000 Subject: [Koha-bugs] [Bug 8201] can't change receive date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8201 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 11:59:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 09:59:21 +0000 Subject: [Koha-bugs] [Bug 7951] Suspending holds needs a system preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7951 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Chris Cormack --- The suspend holds functionality is already in 3.8.x but no way to turn it on our off, this implements that. So I am counting more as a bug fix. Pushed to 3.8.x will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:00:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:00:22 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Applies cleanly to master for me... changing status to Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:05:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:05:06 +0000 Subject: [Koha-bugs] [Bug 8062] Cart email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #18 from Chris Cormack --- pushed to 3.8.x will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:12:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:12:33 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #7 from Matthias Meusburger --- After discussing with Katrin (hackfest), I'll implement something to specify the fields to *allow*. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:13:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:13:24 +0000 Subject: [Koha-bugs] [Bug 7961] Local cover images should support CSV link files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7961 Olugbenga Adara changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |gbengaadara at yahoo.com --- Comment #8 from Olugbenga Adara --- I have tested this using a Biblibre sandbox with the patch applied. I added two more biblios and created the required zip file with images that had spaces in their filename. The file was uploaded and the OPAC displayed the uploaded images. In the staff client, the catalog log showed the three uploaded images with the proper filename. I have verified that all pictures got uploaded and linked to biblio records and that modification log includes cover image name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:13:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:13:48 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10063|0 |1 is obsolete| | --- Comment #10 from Chris Cormack --- Created attachment 10068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10068&action=edit Bug 7563 [ENH] - Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference Configure slip printers to print slips (silently) to a special printer using the Firefox PlugIn jsPrintSetUp. All other print actions are not affected. See http://jsprintsetup.mozdev.org/ for all the possibilities (e.g. change header/footer, get a list of printers, set printer etc.). The overall concept is to have a new staff client preference (IntranetSlipPrinterJS) where one can enter the necessary JavaScript. If the preference is empty, Koha falls back to te default behaviour. An example of JavaScript can be found on: Signed-off-by: Marc Veron Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:14:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:14:14 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:17:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:17:11 +0000 Subject: [Koha-bugs] [Bug 7961] Local cover images should support CSV link files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7961 --- Comment #9 from Paul Poulain --- (In reply to comment #8) > I have tested this using a Biblibre sandbox with the patch applied. > > I added two more biblios and created the required zip file with images that > had spaces in their filename. The file was uploaded and the OPAC displayed > the uploaded images. In the staff client, the catalog log showed the three > uploaded images with the proper filename. > > I have verified that all pictures got uploaded and linked to biblio records > and that modification log includes cover image name Hi Olugbenga Adara, A lot of thanks for this great report of what you tested ! really. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:17:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:17:43 +0000 Subject: [Koha-bugs] [Bug 8184] Duplicate budget page lacks heading and breadcrumbs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8184 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #3 from Paul Poulain --- QA comment: template only patch, adds a breadcrumb where needed, passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:20:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:20:06 +0000 Subject: [Koha-bugs] [Bug 8184] Duplicate budget page lacks heading and breadcrumbs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8184 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:20:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:20:48 +0000 Subject: [Koha-bugs] [Bug 7186] add new 'Koha Stats' tab to 'About' page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |francois.charbonnier at biblib | |re.com --- Comment #10 from Francois Charbonnier --- Patch tested : * the stastistic tab appears well * but the syspref interface css looks broken. Question : Is there a syspref to turn this stat tab on/off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:21:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:21:10 +0000 Subject: [Koha-bugs] [Bug 7412] Pre-filling items in cataloguing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7685|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer --- Comment on attachment 7685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7685 proposed patch >From f80b4d1115262d2cdace9eb7494da7c22116ebf0 Mon Sep 17 00:00:00 2001 >From: Matthias Meusburger >Date: Fri, 6 Jan 2012 14:55:45 +0100 >Subject: [PATCH] Bug 7412: Pre-filling items in cataloguing > >Pre-filling of items: remember what was in the previous item filled, to be able to create multiple items quickly. > >By default, all subfields are prefilled when the PrefillItem syspref is on. >If you want some subfields not to be prefilled, you can use the SubfieldsToDiscardWhenPrefill syspref. >With a value of "f u v", the $f, $u and $v won't be prefilled, for example. >--- > cataloguing/additem.pl | 123 +++++++++++++++++--- > installer/data/mysql/sysprefs.sql | 2 + > installer/data/mysql/updatedatabase.pl | 16 +++- > .../en/modules/admin/preferences/cataloguing.pref | 10 ++ > 4 files changed, 134 insertions(+), 17 deletions(-) > >diff --git a/cataloguing/additem.pl b/cataloguing/additem.pl >index a734d0f..b10c986 100755 >--- a/cataloguing/additem.pl >+++ b/cataloguing/additem.pl >@@ -32,6 +32,10 @@ use C4::Branch; # XXX subfield_is_koha_internal_p > use C4::ClassSource; > use C4::Dates; > use List::MoreUtils qw/any/; >+use Storable qw(thaw freeze); >+use URI::Escape; >+ >+ > > use MARC::File::XML; > use URI::Escape; >@@ -275,6 +279,29 @@ sub generate_subfield_form { > return \%subfield_data; > } > >+# Removes some subfields (defined in the SubfieldsToDiscardWhenPrefill syspref) when prefilling items >+sub removeFieldsForPrefill { >+ >+ my $item = shift; >+ >+ # Getting item tag >+ my ($tag, $subtag) = GetMarcFromKohaField("items.barcode", ''); >+ >+ # Getting list of subfields to remove >+ my $subfieldsToDiscardWhenPrefill = C4::Context->preference('SubfieldsToDiscardWhenPrefill'); >+ >+ # Removing subfields >+ if ($tag && $subfieldsToDiscardWhenPrefill) { >+ my $field = $item->field($tag); >+ my @subfieldsToDiscard= split(/ /,$subfieldsToDiscardWhenPrefill); >+ foreach my $subfieldsDiscard(@subfieldsToDiscard) { >+ $field->delete_subfield(code => $subfieldsDiscard); >+ } >+ } >+ >+ return $item; >+ >+} > > my $input = new CGI; > my $error = $input->param('error'); >@@ -315,9 +342,26 @@ my $oldrecord = TransformMarcToKoha($dbh,$record); > my $itemrecord; > my $nextop="additem"; > my @errors; # store errors found while checking data BEFORE saving item. >+ >+# Getting last created item cookie >+my $prefillitem = C4::Context->preference('PrefillItem'); >+my $justaddeditem; >+my $cookieitemrecord; >+if ($prefillitem) { >+ my $lastitemcookie = $input->cookie('LastCreatedItem'); >+ if ($lastitemcookie) { >+ $lastitemcookie = uri_unescape($lastitemcookie); >+ if ( thaw($lastitemcookie) ) { >+ $cookieitemrecord = thaw($lastitemcookie) ; >+ $cookieitemrecord = removeFieldsForPrefill($cookieitemrecord); >+ } >+ } >+} >+ > #------------------------------------------------------------------------------- > if ($op eq "additem") { >-#------------------------------------------------------------------------------- >+ >+ #------------------------------------------------------------------------------- > # rebuild > my @tags = $input->param('tag'); > my @subfields = $input->param('subfield'); >@@ -334,26 +378,69 @@ if ($op eq "additem") { > my $add_multiple_copies_submit = $input->param('add_multiple_copies_submit'); > my $number_of_copies = $input->param('number_of_copies'); > >+ # This is a bit tricky : if there is a cookie for the last created item and >+ # we just added an item, the cookie value is not correct yet (it will be updated >+ # next page). To prevent the form from being filled with outdated values, we >+ # force the use of "add and duplicate" feature, so the form will be filled with >+ # correct values. >+ $add_duplicate_submit = 1 if ($prefillitem); >+ $justaddeditem = 1; >+ >+ # if autoBarcode is set to 'incremental', calculate barcode... >+ # NOTE: This code is subject to change in 3.2 with the implemenation of ajax based autobarcode code >+ # NOTE: 'incremental' is the ONLY autoBarcode option available to those not using javascript >+ if ( C4::Context->preference('autoBarcode') eq 'incremental' ) { >+ my ( $tagfield, $tagsubfield ) = &GetMarcFromKohaField( "items.barcode", $frameworkcode ); >+ unless ( $record->field($tagfield)->subfield($tagsubfield) ) { >+ my $sth_barcode = $dbh->prepare("select max(abs(barcode)) from items"); >+ $sth_barcode->execute; >+ my ($newbarcode) = $sth_barcode->fetchrow; >+ $newbarcode++; >+ >+ # OK, we have the new barcode, now create the entry in MARC record >+ my $fieldItem = $record->field($tagfield); >+ $record->delete_field($fieldItem); >+ $fieldItem->add_subfields( $tagsubfield => $newbarcode ); >+ $record->insert_fields_ordered($fieldItem); >+ } >+ } >+ >+ > if (C4::Context->preference('autoBarcode') eq 'incremental') { > $record = _increment_barcode($record, $frameworkcode); > } > >- my $addedolditem = TransformMarcToKoha($dbh,$record); >+ my $addedolditem = TransformMarcToKoha( $dbh, $record ); > > # If we have to add or add & duplicate, we add the item >- if ($add_submit || $add_duplicate_submit) { >- # check for item barcode # being unique >- my $exist_itemnumber = get_item_from_barcode($addedolditem->{'barcode'}); >- push @errors,"barcode_not_unique" if($exist_itemnumber); >- # if barcode exists, don't create, but report The problem. >- unless ($exist_itemnumber) { >- my ($oldbiblionumber,$oldbibnum,$oldbibitemnum) = AddItemFromMarc($record,$biblionumber); >- set_item_default_location($oldbibitemnum); >- } >- $nextop = "additem"; >- if ($exist_itemnumber) { >- $itemrecord = $record; >- } >+ if ( $add_submit || $add_duplicate_submit ) { >+ >+ # check for item barcode # being unique >+ my $exist_itemnumber = get_item_from_barcode( $addedolditem->{'barcode'} ); >+ push @errors, "barcode_not_unique" if ($exist_itemnumber); >+ >+ # if barcode exists, don't create, but report The problem. >+ unless ($exist_itemnumber) { >+ my ( $oldbiblionumber, $oldbibnum, $oldbibitemnum ) = AddItemFromMarc( $record, $biblionumber ); >+ set_item_default_location($oldbibitemnum); >+ >+ # Pushing the last created item cookie back >+ if ($prefillitem && defined $record) { >+ my $itemcookie = $input->cookie( >+ -name => 'LastCreatedItem', >+ # We uri_escape the whole freezed structure so we're sure we won't have any encoding problems >+ -value => uri_escape( freeze( $record ) ), >+ -expires => '' >+ ); >+ >+ $cookie = ( $cookie, $itemcookie ); >+ } >+ >+ } >+ $nextop = "additem"; >+ if ($exist_itemnumber) { >+ $itemrecord = $record; >+ } > } > > # If we have to add & duplicate >@@ -370,6 +457,7 @@ if ($op eq "additem") { > $fieldItem->delete_subfields($tagsubfield); > $itemrecord->insert_fields_ordered($fieldItem); > } >+ $itemrecord = removeFieldsForPrefill($itemrecord) if ($prefillitem); > } > > # If we have to add multiple copies >@@ -698,6 +786,11 @@ if($itemrecord){ > } > # and now we add fields that are empty > >+# Using last created item if it exists >+ >+$itemrecord = $cookieitemrecord if ($prefillitem and not $justaddeditem and $op ne "edititem"); >+ >+# We generate form, and fill with values if defined > foreach my $tag ( keys %{$tagslib}){ > foreach my $subtag (keys %{$tagslib->{$tag}}){ > next if subfield_is_koha_internal_p($subtag); >diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql >index 128c9b2..e9070a8 100755 >--- a/installer/data/mysql/sysprefs.sql >+++ b/installer/data/mysql/sysprefs.sql >@@ -328,4 +328,6 @@ INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES(' > INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES ('OpacKohaUrl','1',"Show 'Powered by Koha' text on OPAC footer.",NULL,NULL); > INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('EasyAnalyticalRecords','0','If on, display in the catalogue screens tools to easily setup analytical record relationships','','YesNo'); > INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('OpacShowRecentComments',0,'If ON a link to recent comments will appear in the OPAC masthead',NULL,'YesNo'); >+INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES('PrefillItem','0','When a new item is added, should it be prefilled with last created item values?','','YesNo'); >+INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES ('SubfieldsToDiscardWhenPrefill','','Define a list of subfields to discard when prefilling items (separated by space)','','Free'); > >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 67708fa..014b96e 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -4585,6 +4585,20 @@ if (C4::Context->preference("Version") < TransformToNum($DBversion)) { > SetVersion($DBversion); > } > >+$DBversion = "3.06.03.002"; >+if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { >+ $dbh->do(" >+ INSERT IGNORE INTO `systempreferences` (variable,value,explanation,options,type) VALUES('PrefillItem','0','When a new item is added, should it be prefilled with last created item values?','','YesNo'); >+ "); >+ >+ $dbh->do( >+ "INSERT INTO systempreferences (variable,value,explanation,options,type) VALUES ('SubfieldsToDiscardWhenPrefill','','Define a list of subfields to discard when prefilling items (separated by space)','','Free');" >+ ); >+ >+ print "Upgrade to $DBversion done (Adding PrefillItem and SubfieldsToDiscardWhenPrefill sysprefs)\n"; >+ SetVersion($DBversion); >+} >+ > =head1 FUNCTIONS > > =head2 DropAllForeignKeys($table) >@@ -4592,8 +4606,6 @@ if (C4::Context->preference("Version") < TransformToNum($DBversion)) { > Drop all foreign keys of the table $table > > =cut >- >- > sub DropAllForeignKeys { > my ($table) = @_; > # get the table description >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref >index 10e1d13..885c73d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/cataloguing.pref >@@ -90,6 +90,16 @@ Cataloging: > annual: generated in the form <year>-0001, <year>-0002. > hbyymmincr: generated in the form <branchcode>yymm0001. > "OFF": not generated automatically. >+ - >+ - When a new item is added, should it be prefilled with last created item values? >+ - pref: PrefillItem >+ choices: >+ yes: the new item is prefilled with last created item values >+ no: the new item is not prefilled with last created item values >+ - >+ - Define a list of subfields to discard when prefilling items (separated by space) >+ - pref: SubfieldsToDiscardWhenPrefill >+ > Display: > - > - 'Separate multiple displayed authors, series or subjects with ' >-- >1.7.5.4 > -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:22:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:22:20 +0000 Subject: [Koha-bugs] [Bug 7412] Pre-filling items in cataloguing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 --- Comment #21 from Katrin Fischer --- Oups. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:23:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:23:53 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 --- Comment #6 from Michael Davis --- Doesn't apply if you add the 7747 patch first, which I assume is needed as it's listed as a dependency. Adding this patch only breaks the tabs, for instance on cataloguing/addbiblio.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:24:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:24:23 +0000 Subject: [Koha-bugs] [Bug 3708] Add another customizable region to the OPAC: right sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3708 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #8 from Paul Poulain --- QA comment: We already have OpacNav and OpacNavBottom. for consistency, I would like to see this syspref called OpacNavRight, that would be more logical. I would be highly pleased if you could update your patch in this direction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:26:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:26:27 +0000 Subject: [Koha-bugs] [Bug 7186] add new 'Koha Stats' tab to 'About' page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7186 --- Comment #11 from Katrin Fischer --- I would really like to see an option to have this configurable (see comment 7). It's a nice feature, but might introduce some problems for data privacy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:28:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:28:36 +0000 Subject: [Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10018|0 |1 is obsolete| | --- Comment #19 from Matthias Meusburger --- Created attachment 10069 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10069&action=edit Bug 6835 - Ability to specify types of email address in overdue_notices.pl Adds the -email option to overdue_notices.pl, which is repeatable -email value can be: - 'email' - 'emailpro' or - 'B_email' - perltidy done - in production for a BibLibre customer - validated by the customer Signed-off-by: Claire Hernandez -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:29:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:29:36 +0000 Subject: [Koha-bugs] [Bug 7329] The "undo import into catalog" command deletes items onloan without checking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 --- Comment #4 from Sophie MEYNIEUX --- Created attachment 10070 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10070&action=edit Bug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch table, if items are not deleted beacause on loan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:30:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:30:00 +0000 Subject: [Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #20 from Matthias Meusburger --- This new patch removes the GetValidEmailAddresses function (and uses GetMember instead). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:32:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:32:04 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10068|0 |1 is obsolete| | --- Comment #11 from Marc V?ron --- Created attachment 10071 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10071&action=edit Bug 7563 [ENH] - Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference Configure slip printers to print slips (silently) to a special printer using the Firefox PlugIn jsPrintSetUp. All other print actions are not affected. See http://jsprintsetup.mozdev.org/ for all the possibilities (e.g. change header/footer, get a list of printers, set printer etc.). The overall concept is to have a new staff client preference (IntranetSlipPrinterJS) where one can enter the necessary JavaScript. If the preference is empty, Koha falls back to te default behaviour. An example of JavaScript can be found on: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:33:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:33:16 +0000 Subject: [Koha-bugs] [Bug 7329] The "undo import into catalog" command deletes items onloan without checking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |sophie.meynieux at biblibre.co | |m --- Comment #5 from Sophie MEYNIEUX --- First patch was ok but uncomplete. This follow-up keep tracks in import tool itself, that some biblios remain in the catalog because corresponding items are issued and can't be deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:35:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:35:55 +0000 Subject: [Koha-bugs] [Bug 8005] Lost item is not anonymized when checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8005 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #3 from Paul Poulain --- QA comment: small patch, using a sub (GetMemberDetails) that is an heavy one, but using it quite unfrequentely, so it's OK. Other than this, only 3 lines added, passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:37:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:37:27 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9979|0 |1 is obsolete| | --- Comment #14 from Chris Cormack --- Created attachment 10072 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10072&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Test scenario: 1) Make sure that you have a column 'agerestriction' in table biblioitems. This will be handled by updatedatabase.pl. If you want to insert the column using mysql, you can do: ALTER TABLE biblioitems ADD COLUMN 'agerestriction' VARCHAR(255) DEFAULT NULL AFTER 'cn_sort' 2) In the staff client, go to Home . Administration . Koha to MARC mapping and choose biblioitems + OK. In the field list, the field 'agerestriction' should show up. Edit it and map the field e.g. to 521a 3) Go to Home . Administration . System preferences and edit Circulation: AgeRestrictionMarker (add eg.: FSK|PEGI|Age) and AgeRestrictionOverride (Prevent or Don't prevent) 4) Create a young patron account e.g. with age < 16 5) Create or edit a biblio with e.g. the value FSK 16 in the field 521a (same field as mapped above) 6) Try to check out to young patron 7) Chckout should be blocked or issue a warning with override (depending on AgeRestrictionOverride) Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:38:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:38:11 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from Chris Cormack --- Works well, has no effect unless the syspref is on. Safe change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:38:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:38:15 +0000 Subject: [Koha-bugs] [Bug 8005] Lost item is not anonymized when checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8005 --- Comment #4 from Paul Poulain --- Side question: in ReturnLostItem, we use the same sub: MarkIssueReturned( $borrowernumber, $itemnum ); shouldn't we also add ->privacy parameter ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:38:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:38:32 +0000 Subject: [Koha-bugs] [Bug 8005] Lost item is not anonymized when checked in In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8005 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:39:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:39:48 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10071|0 |1 is obsolete| | --- Comment #12 from Chris Cormack --- Created attachment 10073 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10073&action=edit Bug 7563 [ENH] - Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference Configure slip printers to print slips (silently) to a special printer using the Firefox PlugIn jsPrintSetUp. All other print actions are not affected. See http://jsprintsetup.mozdev.org/ for all the possibilities (e.g. change header/footer, get a list of printers, set printer etc.). The overall concept is to have a new staff client preference (IntranetSlipPrinterJS) where one can enter the necessary JavaScript. If the preference is empty, Koha falls back to te default behaviour. An example of JavaScript can be found on: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:40:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:40:20 +0000 Subject: [Koha-bugs] [Bug 8139] Fix the CSS for the recent comments to prevent leftmenu overlapping it. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8139 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #4 from Paul Poulain --- QA comment: tiny patch, css only, nothing to say except: passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:43:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:43:10 +0000 Subject: [Koha-bugs] [Bug 8139] Fix the CSS for the recent comments to prevent leftmenu overlapping it. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8139 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Severity|enhancement |minor --- Comment #5 from Paul Poulain --- It's not an ENH, but a minor bugfix (could be interesting in 3.8) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:44:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:44:03 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |francois.charbonnier at biblib | |re.com --- Comment #34 from Francois Charbonnier --- Patch doesn't apply : Bug 7720 - Ambiguity in OPAC Details location. Apply? [yn] y Applying: Bug 7720 - Ambiguity in OPAC Details location. Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Items.pm Auto-merging installer/data/mysql/sysprefs.sql CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Auto-merging opac/opac-detail.pl Failed to merge in the changes. Patch failed at 0001 Bug 7720 - Ambiguity in OPAC Details location. When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-7720---Ambiguity-in-OPAC-Details-location-CmCdA1.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:49:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:49:34 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9922|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 10074 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10074&action=edit Bug 8143 [SIGNED] Upgrade jQuery tabs to current jQueryUI version All appears to work in Chrome and Firefox.. probably worth a second sign off in case I missed anything... there's allot of pages affected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:49:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:49:41 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10054|0 |1 is obsolete| | --- Comment #74 from Joy Nelson --- Created attachment 10075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10075&action=edit [SIGNED-OFF] Bug 6679: Fixing 13 perlcritic violations in C4/Barcodes.pm Subroutine prototypes used at line XXX, column 1. See page 194 of PBP. (Severity: 5) Note: Rebased on master 06/09/2012 by jcamins Signed-off-by: Joy Nelson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:49:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:49:52 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:50:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:50:28 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #4 from Paul Poulain --- QA comment: tiny patch nothing specific to say from QA pov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:51:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:51:15 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #5 from Paul Poulain --- This tiny ENH could be ported to 3.8 safely & would be useful I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:51:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:51:22 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:52:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:52:46 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 --- Comment #8 from Martin Renvoize --- Good catch Michael, I'de missed the dependency.. Will re-test/re-base as needed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:53:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:53:57 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10053|0 |1 is obsolete| | --- Comment #75 from Joy Nelson --- Created attachment 10076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10076&action=edit [SIGNED-OFF] Bug 6679: Fixing 24 perlcritic violations in misc/translator/TmplTokenizer.pm Subroutine prototypes used at line XXX, column 1. See page 194 of PBP. (Severity: 5) Note: Rebased on master 06/09/2012 by jcamins Signed-off-by: Joy Nelson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:54:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:54:49 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10052|0 |1 is obsolete| | --- Comment #76 from Joy Nelson --- Created attachment 10077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10077&action=edit [SIGNED OFF] Bug 6679: Fixing 5 perlcritic violations in opac/* 1 more to go... :) opac/changelanguage.pl: Code before strictures are enabled at line 24, column 1. See page 429 of PBP. (Severity: 5) Note: Rebased on master 06/09/2012 by jcamins Signed-off-by: Joy Nelson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:54:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:54:58 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain at biblibre.com --- Comment #10 from Paul Poulain --- (In reply to comment #9) > Leaving decision to QA team and RM. RM fully agreeing with owen & katrin & is happy to see he's not the only member of FAUSP ("Fighters Against Useless System Preferences") let's go to disabling this option : if the number is confusing (and I agree it is), just remove it ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:55:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:55:47 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10051|0 |1 is obsolete| | --- Comment #77 from Joy Nelson --- Created attachment 10078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10078&action=edit [SIGNED OFF] Bug 6679: Fixing 23 perlcritic violations in C4/Tags.pm return" statement with explicit "undef" at line XXX, column 26. See page 199 of PBP. (Severity: 5) note: i have tested the Tags feature OK, after appliying this patch Note: Rebased on master 06/09/2012 by jcamins Signed-off-by: Joy Nelson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:56:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:56:31 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10050|0 |1 is obsolete| | --- Comment #78 from Joy Nelson --- Created attachment 10079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10079&action=edit [SIGNED OFF] Bug 6679: Fixing 26 perlcritic violations in C4/Tags.pm Subroutine prototypes used at line XXX, column 1. See page 194 of PBP. (Severity: 5) Note: Rebased on master 06/09/2012 by jcamins Signed-off-by: Joy Nelson -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:59:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:59:23 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |joy at bywatersolutions.com --- Comment #79 from Joy Nelson --- FYI - Still additional PBP violations in TmplTokenizer.pm and C4/Barcodes.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 12:59:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 10:59:39 +0000 Subject: [Koha-bugs] [Bug 6141] html glitches causing problems to translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #7 from Paul Poulain --- QA comment: as Martin said : Simple fix, works... 'nuff said' & passed QA (In reply to comment #6) > Signed off... but: Can anyone care to explain what the Importance being set > to "PATCH-Sent (DO NOT USE)" actually means? Our workflow used to use this "PATCH sent" to warn that the patch has been sent. Now, and since some months, it's in the status, so this priority should not be used anymore, and it's here only for some legacy entries. Feel free to update priority if you encounter a bug with this priority ! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:00:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:00:09 +0000 Subject: [Koha-bugs] [Bug 6141] html glitches causing problems to translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 Severity|trivial |minor -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:00:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:00:51 +0000 Subject: [Koha-bugs] [Bug 8201] can't change receive date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8201 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10067|0 |1 is obsolete| | --- Comment #5 from Matthias Meusburger --- Created attachment 10080 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10080&action=edit [Signed-off] Bug 8201: Receive date not passed through correctly All orders were received with today's date instead of the receive date given with the invoice number. To test: 1) Add an order with a few order lines 2) Create a new invoice, receive date != today's date 3) Start receiving orders, check date on receive screens is correct Signed-off-by: Matthias Meusburger -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:00:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:00:56 +0000 Subject: [Koha-bugs] [Bug 8201] can't change receive date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8201 --- Comment #6 from Sophie MEYNIEUX --- Created attachment 10081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10081&action=edit Bug 8201 [SIGNED-OFF] : Receive date not passed through correctly All orders were received with today's date instead of the receive date given with the invoice number. To test: 1) Add an order with a few order lines 2) Create a new invoice, receive date != today's date 3) Start receiving orders, check date on receive screens is correct Signed-off-by: Sophie Meynieux -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:01:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:01:56 +0000 Subject: [Koha-bugs] [Bug 8178] circ/circulation.pl under plack duplicates checkout rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8178 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #4 from Paul Poulain --- QA comment: tiny patch, that proves we should never declare a variable without initializing it ;-) passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:02:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:02:16 +0000 Subject: [Koha-bugs] [Bug 8178] circ/circulation.pl under plack duplicates checkout rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8178 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:02:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:02:40 +0000 Subject: [Koha-bugs] [Bug 7844] plack scripts for developers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7844 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9879|0 |1 is obsolete| | --- Comment #14 from Dobrica Pavlinusic --- Created attachment 10082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10082&action=edit Bug 7844 - plack intranet tooling for developers koha.psgi example and plackup.sh script to run any Koha site intranet or opac interface under plack with optional multi-process Starman server plackup.sh site-name [intranet] site-name is used to find config /etc/koha/sites/site-name/koha-conf.xml All configuration is specified in koha.psgi, which you are welcomed to edit and tune according to your development needs (enable memcache, enable/disable debugging modules for plack and so on). For deployment of opac or intranet you would probably want to take a look in plackup.sh and enable starman as web server (which is pre-forking server written in perl) and put some web server in front of it to serve static web files (e.g. ngnix, apache) When you are happy with it, rename koha.psgi and plackup.sh it to site name and save it for safe-keeping. This version does not have mapping to / of opac or intranet, so you need to use full URLs to pages as specified in test scenario. This will be fixed when we are ready to deploy plack, but for now it's clear indication that this is intended for developers which know what to do anyway. Test scenario: 1. install plack and dependencies, as documented at http://wiki.koha-community.org/wiki/Plack 2. start ./plackup.sh sitename i[ntranet] 3. open intranet page http://localhost:5001/cgi-bin/koha/mainpage.pl and verify that it works 4. start ./plackup.sh sitename 5. open OPAC http://localhost:5000/cgi-bin/koha/opac-main.pl and verify that it works 6. next step is to take a look into koha.psgi and enable additional debug modules, save file and reload page (plackup will reload code automatically) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:04:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:04:01 +0000 Subject: [Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Paul Poulain --- QA comment: * sorry about that, but there's an unconditionnal warn: + warn "## Name [$opts{Name}] $fh"; so, failed QA until you've removed it (or $ENV{DEBUG} &&...) Other than this, tiny patch, will pass QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:04:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:04:17 +0000 Subject: [Koha-bugs] [Bug 8201] can't change receive date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8201 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |matthias.meusburger at biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:05:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:05:18 +0000 Subject: [Koha-bugs] [Bug 8105] DataTables in Acquisision module: basketgroup.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8105 Marijana Glavica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9611|0 |1 is obsolete| | --- Comment #2 from Marijana Glavica --- Created attachment 10083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10083&action=edit [SIGNED-OFF] Bug 5345: DataTables integration in acquisition module [5] basketgroup.tt http://bugs.koha-community.org/show_bug.cgi?id=8105 Signed-off-by: Marijana Glavica -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:05:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:05:53 +0000 Subject: [Koha-bugs] [Bug 8105] DataTables in Acquisision module: basketgroup.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8105 Marijana Glavica changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mglavica at ffzg.hr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:07:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:07:51 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10074|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 10084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10084&action=edit Bug 8143 [SIGNED] Upgrade jQuery tabs to current jQueryUI version Now applied after bug7747, still seems to apply cleanly for me? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:08:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:08:03 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:08:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:08:48 +0000 Subject: [Koha-bugs] [Bug 7815] Order pickup library list by name rather than by code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7815 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #4 from Paul Poulain --- (In reply to comment #2) > Hi Sophie, > I tried to replicate the problem on the holds page in staff and in the OPAC. > In both places my branches appeared in alphabetical order. Can you give me a > hint where or in which case the order is wrong? In order to reproduce this problem, the order of code must differ from the order of descriptions. For example: code Description X library street X A that is another library Before the patch, A appears before X (and if you've 20+ libraries, you'll face pain to find the one you want !), after the patch, it's ordered by description QA comment: tiny patch, sorting a hash, passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:08:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:08:51 +0000 Subject: [Koha-bugs] [Bug 8104] DataTables in Acquisision module: lateorders.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8104 Marijana Glavica changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9610|0 |1 is obsolete| | --- Comment #2 from Marijana Glavica --- Created attachment 10085 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10085&action=edit [SIGNED-OFF] Bug 5345: DataTables integration in acquisition module [7] lateorders.tt http://bugs.koha-community.org/show_bug.cgi?id=8104 Signed-off-by: Marijana Glavica -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:09:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:09:15 +0000 Subject: [Koha-bugs] [Bug 8104] DataTables in Acquisision module: lateorders.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8104 Marijana Glavica changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mglavica at ffzg.hr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:09:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:09:43 +0000 Subject: [Koha-bugs] [Bug 7815] Order pickup library list by name rather than by code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7815 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Severity|enhancement |minor --- Comment #5 from Paul Poulain --- more a bugfix than an ENH, worth porting on 3.8 even if minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:12:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:12:38 +0000 Subject: [Koha-bugs] [Bug 6175] Mismatch between marc_subfield_structure and authorised_values tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6175 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3911|0 |1 is obsolete| | --- Comment #3 from MJ Ray (software.coop) --- Created attachment 10086 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10086&action=edit Bug 6175 Mismatch on tables definition kohastructure.sql defines: marc_subfield_structure.authorised_value varchar(20) this column points to: authorised_values.category varchar(10) At first tought you would think about shortening in marc_subfield_structure table, but install scripts had values longer than 10 characters. Also there's been talk in the list about expanding the column. So: - Expand on authorised_values.category. - Add foreign keys constraints. - Reshuffle sql scripts to allow insertions given the new constraints. - Expand template input text field to match database column. Signed-off-by: MJ Ray -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:14:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:14:29 +0000 Subject: [Koha-bugs] [Bug 6175] Mismatch between marc_subfield_structure and authorised_values tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6175 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off CC| |mjr at software.coop --- Comment #4 from MJ Ray (software.coop) --- At a basic level, this looks like it works (it now applies and tests pass), so I have signed it off. If the brokenness was more subtle/structural, please make it Failed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:15:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:15:20 +0000 Subject: [Koha-bugs] [Bug 5981] OPAC: Add limits to search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5659|0 |1 is obsolete| | --- Comment #22 from Alex Arnaud --- Created attachment 10087 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10087&action=edit Bug 5981 - OPAC: Add limits to search history -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:15:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:15:41 +0000 Subject: [Koha-bugs] [Bug 7412] Pre-filling items in cataloguing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #22 from Katrin Fischer --- Ok, here are my testing comments: I like the new way better - a positive system preference to add all fields I want to have prefilled. I am wondering if we really need 2 new preferences for that. Perhaps turning the feature off could be done by leaving the field empty instead? That said, turning the feature off/on works. Only fields I wanted to be copied to the next item get copied. Adding items, duplicating items and adding multiple copies of an item seem to work nicely. Adding items in serials seems not to be affected and worked ok for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:16:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:16:12 +0000 Subject: [Koha-bugs] [Bug 7412] Pre-filling items in cataloguing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8718|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer --- Created attachment 10088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10088&action=edit [SIGNED-OFF] Bug 7412: Pre-filling items in cataloguing Pre-filling of items: remember what was in the previous item filled, to be able to create multiple items quickly. By default, all subfields are prefilled when the PrefillItem syspref is on, unless you specify which fields you want to prefill in the SubfieldsToUseWhenPrefill syspref. With a value of "f u v", only the $f, $u and $v will be prefilled, for example. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:17:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:17:31 +0000 Subject: [Koha-bugs] [Bug 5981] OPAC: Add limits to search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #23 from Alex Arnaud --- This patch does the same thing than the previous one but it should apply. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:18:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:18:36 +0000 Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |francois.charbonnier at biblib | |re.com --- Comment #7 from Francois Charbonnier --- The patch does not apply : OPACNoResults, add keyword to search string Apply? [yn] y Applying: OPACNoResult, Add keyword to query string Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging opac/opac-search.pl CONFLICT (content): Merge conflict in opac/opac-search.pl Failed to merge in the changes. Patch failed at 0001 OPACNoResult, Add keyword to query string When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/OPACNoResults-add-keyword-to-search-string-cfak79.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:19:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:19:04 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mjr at software.coop --- Comment #20 from MJ Ray (software.coop) --- fatal: sha1 information is lacking or useless (acqui/addorder.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 7294:Additional patch to show the ordered status in catalogue page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:21:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:21:22 +0000 Subject: [Koha-bugs] [Bug 8015] Add MARC Modifications Templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8015 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9331|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 10089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10089&action=edit Bug 8015 - Add MARC Modifications Templates The MARC Modification Templates system gives Koha users the power to make alterations to MARC records automatically while staging MARC records for import. This tool is useful for altering MARC records from various venders work with your MARC framework. The system essentially allows one to create a basic script using actions to Copy, Move, Add, Update and Delete fields. Each action can also have an optional condition to check the value or existance of another field. The Copy & Move actions also support Regular Expressions, which can be used to automatically modify field values during the copy/move. An example would be to strip out the '$' character in field 020$c. Furthermore, the value for an update can include variables that change each time the template is used. Currently, the system supports two variables, __BRANCHCODE__ which is replaced with the branchcode of the library currently using the template, and __CURRENTDATE__ which is replaced with the current date in ISO format ( YYYY-MM-DD ). At its simplist, it can perform functions such as: Copy field 092$a to 952$c At its most complex it can run actions like: Copy field 020$c to 020$c using RegEx s/\$// if 020$c equals RegEx m/^\$/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:21:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:21:43 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Francois Charbonnier changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:29:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:29:06 +0000 Subject: [Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10042|0 |1 is obsolete| | --- Comment #6 from Dobrica Pavlinusic --- Created attachment 10090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10090&action=edit Bug 7952 - PDF::Reuse under plack writes to console STDOUT instead to browser Without name option to prFile, PDF::Reuse opens '-' file which is real console STDOUT on plack so pdf file gets emited to terminal instead of sending it to browser. This change creates temporary file using File::Temp, pass it to PDF::Reuse and then reads it back and prints it out for plack (or CGI) to pick up. Test secenario: 1. Home ? Tools ? Patron Card Creator ? Manage Card Batches 2. select batch checkbox and click Export 3. select template and click Export 4. click on pdf file to download it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:29:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:29:10 +0000 Subject: [Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|henridamien at koha-fr.org |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:30:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:30:05 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #11 from Robin Sheat --- Alrighty then, I'll modify it to do so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:31:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:31:59 +0000 Subject: [Koha-bugs] [Bug 4325] Standardize buttons cancel In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4325 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |INVALID --- Comment #1 from Alex Arnaud --- This bug/patch is not relevant anymore with the new staff design. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:33:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:33:37 +0000 Subject: [Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Dobrica Pavlinusic --- Sorry about that. It seems that I wanted to add $ENV{DEBUG} around that warn (and even included it in commit message) but never changed code. On second look, I think it's not really useful to anyone expect me while development so it's removed -- less cruft, more kittens! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:35:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:35:57 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8600|0 |1 is obsolete| | --- Comment #8 from MJ Ray (software.coop) --- Created attachment 10091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10091&action=edit Bug 7710 - multiple holds per title - Part 1 - Add new system preference MaxHoldsPerRecord -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:43:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:43:38 +0000 Subject: [Koha-bugs] [Bug 8216] Enable critic tests on SIP modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8216 Stacey Walker changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10006|0 |1 is obsolete| | --- Comment #2 from Stacey Walker --- Created attachment 10092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10092&action=edit Signed off patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:43:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:43:46 +0000 Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 Olugbenga Adara changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gbengaadara at yahoo.com --- Comment #4 from Olugbenga Adara --- Trying to sign off on this patch using Biblibre's sandbox. Got the message below

      Something went wrong !

      Applying: Bug 8130 - attach PDF files to a patron record
      Using index info to reconstruct a base tree...
      Falling back to patching base and 3-way merge...
      Auto-merging installer/data/mysql/sysprefs.sql
      CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
      Auto-merging installer/data/mysql/updatedatabase.pl
      CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
      Failed to merge in the changes.
      Patch failed at 0001 Bug 8130 - attach PDF files to a patron record
      -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:43:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:43:52 +0000 Subject: [Koha-bugs] [Bug 8216] Enable critic tests on SIP modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8216 Stacey Walker changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |stacey at catalyst-eu.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:58:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:58:10 +0000 Subject: [Koha-bugs] [Bug 8166] Adding new currencies & exchange rates if not fill any field it save blank record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8166 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #3 from Paul Poulain --- QA comment: tiny patch, passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 13:58:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 11:58:26 +0000 Subject: [Koha-bugs] [Bug 8166] Adding new currencies & exchange rates if not fill any field it save blank record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8166 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:03:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:03:21 +0000 Subject: [Koha-bugs] [Bug 6855] bullet point showing in wrong place on error message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #8 from Paul Poulain --- QA comment: tiny patch css only, passed QA Note that it seems that the patch also changes the dialog windows look without announcing the change: +div.dialog { + background : #FFC url(../../img/dialog-bg.gif) repeat-x left 0; <<<<<<<<< HERE + text-align : center; +} A small change, not worth complaining, just pointing that -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:03:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:03:33 +0000 Subject: [Koha-bugs] [Bug 6855] bullet point showing in wrong place on error message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:05:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:05:07 +0000 Subject: [Koha-bugs] [Bug 7747] Replace YUI autocomplete with jQueryUI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Paul Poulain --- QA comment: removing code-only path, nothing to object from QA point of view :D Note the signoff-er name does not appear, i'll fix it when pushing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:06:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:06:40 +0000 Subject: [Koha-bugs] [Bug 7747] Replace YUI autocomplete with jQueryUI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #13 from Paul Poulain --- (In reply to comment #11) > I would apply this, and open a new bug to resolve the authorities > autocomplete search and to remove the redundant js files from auth_finder.tt Agreed. Patch pushed, please provide follow-up in another bug (that could usefully be marking as dependant on this one) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:06:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:06:58 +0000 Subject: [Koha-bugs] [Bug 7747] Replace YUI autocomplete with jQueryUI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:11:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:11:48 +0000 Subject: [Koha-bugs] [Bug 4838] Repeated authority headings break biblio record data entry form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com --- Comment #14 from Paul Poulain --- QA comment: template only changes that switches from a single display to a loop in case a value is repeated. passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:12:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:12:19 +0000 Subject: [Koha-bugs] [Bug 4838] Repeated authority headings break biblio record data entry form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|rel_3_2 |rel_3_8 Severity|major |normal --- Comment #15 from Paul Poulain --- Lowering severity as the case is quite rare, but it's a bugfix, so valuable in 3.8 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:14:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:14:39 +0000 Subject: [Koha-bugs] [Bug 1807] ':' character blocks search ; search () give odd results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #370 is|0 |1 obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:14:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:14:55 +0000 Subject: [Koha-bugs] [Bug 1807] ':' character blocks search ; search () give odd results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #371 is|0 |1 obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:18:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:18:43 +0000 Subject: [Koha-bugs] [Bug 1807] search () give odd results In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1807 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED CC| |mjr at software.coop Version|rel_3_6 |master Summary|':' character blocks search |search () give odd results |; search () give odd | |results | --- Comment #7 from MJ Ray (software.coop) --- I have tested this on master with a search like Code and other laws (of cyberspace) and it does not work when it should. I have checked that the attached patches are in git, so I am marking them obsolete and putting this bug back to ASSIGNED which I think is more accurate and nearer the start of the lifecycle than Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:21:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:21:04 +0000 Subject: [Koha-bugs] [Bug 7961] Local cover images should support CSV link files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7961 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #10 from Paul Poulain --- QA comment: just one, but it will result in failed QA: You must test the syspref CataloguingLog before logging action: + logaction('CATALOGUING', 'MODIFY', $biblionumber, "cover image: $filename"); if (C4::Context->preference("CataloguingLog")) { logaction('CATALOGUING', 'MODIFY', $biblionumber, "cover image: $filename"); } will make you earn QA ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:22:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:22:32 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 --- Comment #37 from Jared Camins-Esakov --- Katrin, (In reply to comment #36) > Hi Jared, > I might be wrong here, because I can't remember disagreeing with you. :) > > But I think maybe I didn't explain it well before? If you leave the mapping > empty (which yes, we did...) the value will be saved into the > more_subfields_xml column in XML format. So after updating the mapping, the > value will still be there, but you will not be able to access the > information from the interface. So I was suggesting that there should be a > way to copy that information into the new field or give at least a warning, > that you might have to do so. > So it's not only when people created a new column, but also when they were > using the methods Koha provides to add additional subfields. As far as I can tell, the situation is no worse after applying the patch than it was before applying the patch. Are you able to find a situation where the patch makes things worse than they already are? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:27:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:27:36 +0000 Subject: [Koha-bugs] [Bug 8092] Koha should use CHI caching framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8092 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10037|0 |1 is obsolete| | --- Comment #10 from Chris Cormack --- Created attachment 10093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10093&action=edit Bug 8092: Cheer up Jenkins on loading Cache modules Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:40:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:40:01 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain at biblibre.com --- Comment #16 from Paul Poulain --- QA comment: Fails QA for 2 reason, plus one request * Your patch introduce a perlcritic error: C4/Circulation.pm: Integer with leading zeros: "02" at line 976, column 41. See page 58 of PBP. (Severity: 5) * The description of the syspref look a little bit too complex to me: "Do not prevent patrons from checking out an item whose age restriction would apply". Saying "No" means "do not not prevent from ..." That's a typical "no-no" thing. It's much readable to have a yes-yes: "Prevent patrons from checking out..." "Yes/No". * for existing setups, it will be necessary to do some manual operations: - Add the Age Restriction marker and link it to biblioitems.agerestriction - if the Age Rescrition marker is already here, an UPDATE will be needed (something like "UPDATE biblioitems SET agerestriction=ExtractValue('@521$a',marcxml)") to fill the new biblioitems field That's worth adding a wiki page describing that and pointing to it during updatedatabase (I'll take care of this in the Release Notes as well) Note that this script is MARCflavour agnostic, so it should work in UNIMARC as well, (probably with field 333) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:42:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:42:01 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9916|0 |1 is obsolete| | --- Comment #12 from Jared Camins-Esakov --- Created attachment 10094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10094&action=edit Bug 8171 - Improper escaping of quotes during z39.50 queries leads to broken html Implementing fix as suggested by Chris Cormack: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171#c4 Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:44:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:44:28 +0000 Subject: [Koha-bugs] [Bug 6855] bullet point showing in wrong place on error message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 --- Comment #9 from Owen Leonard --- (In reply to comment #8) > +div.dialog { > + background : #FFC url(../../img/dialog-bg.gif) repeat-x left 0; <<<<<<<<< > HERE > + text-align : center; > +} This is a regression of Bug 6865 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:47:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:47:01 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #10 from Martin Renvoize --- Michael, what exactly do you mean by "breaks tabs".. for example on cataloguing/addbiblio.pl I'm seeing perfect normal operation.. Wondering if I have something cached somewhere or similar and am there for not seeing the effect of the patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:47:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:47:23 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:49:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:49:25 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 --- Comment #6 from Owen Leonard --- It should be put in the coding guidelines that using is not the best way to add load events to a page. Generally the event should be added to the jQuery $document(ready)() function. That lets jQuery handle all the onload events and helps prevent conflicts. I think a follow-up for this should be submitted to change this and ask that this not be pushed to 3.8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:50:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:50:03 +0000 Subject: [Koha-bugs] [Bug 6855] bullet point showing in wrong place on error message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 --- Comment #10 from Paul Poulain --- (In reply to comment #9) > (In reply to comment #8) > > +div.dialog { > > + background : #FFC url(../../img/dialog-bg.gif) repeat-x left 0; <<<<<<<<< > > HERE > > + text-align : center; > > +} > > This is a regression of Bug 6865 Owen, I'm not sure I get what you mean here = this div.dialog is a regression and should be discarded ? Should I revert the patch and ask for one that is dealing with .ialog li only ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 14:54:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 12:54:56 +0000 Subject: [Koha-bugs] [Bug 6855] bullet point showing in wrong place on error message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 --- Comment #11 from Owen Leonard --- (In reply to comment #10) > > > + background : #FFC url(../../img/dialog-bg.gif) repeat-x left 0; <<<<<<<<< > > This is a regression of Bug 6865 > > Owen, I'm not sure I get what you mean here = this div.dialog is a > regression and should be discarded ? If the patch adds a call to "url(../../img/dialog-bg.gif)" in the CSS then it is a regression of Bug 6865 which removed all such calls to background gradient images. It's not a big deal, but it requires a follow-up to correct it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:04:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:04:03 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain at biblibre.com --- Comment #13 from Paul Poulain --- QA comment: I think this change was not really wanted: - SetVersion($DBversion); -} as it result in updatedatabase not compiling: Missing right curly or square bracket at installer/data/mysql/updatedatabase.pl line 5434, at end of line syntax error at installer/data/mysql/updatedatabase.pl line 5434, at EOF installer/data/mysql/updatedatabase.pl had compilation errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:06:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:06:31 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10075|0 |1 is obsolete| | --- Comment #80 from Paul Poulain --- Comment on attachment 10075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10075 [SIGNED-OFF] Bug 6679: Fixing 13 perlcritic violations in C4/Barcodes.pm OK, this patch fixes error, but there are still some: "return" statement with explicit "undef" at line 57, column 2. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 131, column 3. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 147, column 22. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 152, column 22. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 157, column 22. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 193, column 3. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 197, column 3. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 228, column 2. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:06:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:06:37 +0000 Subject: [Koha-bugs] [Bug 7286] Introduce rebuild_zebra_sliced.zsh to recursively rebuild zebra & be error proof In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7286 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #7629|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize --- Created attachment 10095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10095&action=edit Bug 7286 [Signed] Rebuild Zebra Sliced Works as expected, very useful for finding errant biblios that don't want to index. Minor comment, when running from command line some further feedback might be nice as currently if it's a slow index with large chunk size the screen is left blank for a long time leaving the user unsure whether anything is happening. Not enough to hold back sign-off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:06:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:06:53 +0000 Subject: [Koha-bugs] [Bug 7286] Introduce rebuild_zebra_sliced.zsh to recursively rebuild zebra & be error proof In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7286 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:08:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:08:37 +0000 Subject: [Koha-bugs] [Bug 7548] Missing arguments in the pagination of receptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7548 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10064|0 |1 is obsolete| | --- Comment #11 from MJ Ray (software.coop) --- Created attachment 10096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10096&action=edit Bug 7548: Missing arguments when receiving orders Patch redone for 3.6.x to fix TT scoping problems and taking care of changed variable names (booksellerid vs supplierid). To test: Check pagination works correctly when receiving orders. Invoice number and date received should always appear in your URL and be shown at the top of the website. Signed-off-by: MJ Ray -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:09:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:09:32 +0000 Subject: [Koha-bugs] [Bug 7548] Missing arguments in the pagination of receptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7548 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mjr at software.coop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:11:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:11:16 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10076|0 |1 is obsolete| | --- Comment #81 from Paul Poulain --- Comment on attachment 10076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10076 [SIGNED-OFF] Bug 6679: Fixing 24 perlcritic violations in misc/translator/TmplTokenizer.pm Patch pushed, still one perlcritic problem in this file: "return" statement with explicit "undef" at line 319, column 17. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:12:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:12:06 +0000 Subject: [Koha-bugs] [Bug 8201] can't change receive date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8201 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10080|0 |1 is obsolete| | Attachment #10081|0 |1 is obsolete| | --- Comment #7 from MJ Ray (software.coop) --- Created attachment 10097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10097&action=edit Bug 8201: Receive date not passed through correctly All orders were received with today's date instead of the receive date given with the invoice number. To test: 1) Add an order with a few order lines 2) Create a new invoice, receive date != today's date 3) Start receiving orders, check date on receive screens is correct Signed-off-by: Matthias Meusburger Signed-off-by: Sophie Meynieux Signed-off-by: MJ Ray -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:12:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:12:38 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10077|0 |1 is obsolete| | --- Comment #82 from Paul Poulain --- Comment on attachment 10077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10077 [SIGNED OFF] Bug 6679: Fixing 5 perlcritic violations in opac/* patch pushed,OPAC almost perlcritic compliant, just one error to solve: opac/ilsdi.pl: Stricture disabled at line 217, column 17. See page 429 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:12:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:12:42 +0000 Subject: [Koha-bugs] [Bug 8201] can't change receive date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8201 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mjr at software.coop --- Comment #8 from MJ Ray (software.coop) --- Trivial patch. Fixed whitespace and merged signed-offs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:13:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:13:20 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 --- Comment #83 from Paul Poulain --- Comment on attachment 10078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10078 [SIGNED OFF] Bug 6679: Fixing 23 perlcritic violations in C4/Tags.pm I can't apply this one: Applying: Bug 6679: Fixing 23 perlcritic violations in C4/Tags.pm fatal: sha1 information is lacking or useless (C4/Tags.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 6679: Fixing 23 perlcritic violations in C4/Tags.pm When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:13:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:13:42 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10091|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 10098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10098&action=edit Bug 7710 - multiple holds per title - Part 1 - Add new system preference MaxHoldsPerRecord -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:13:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:13:58 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8601|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 10099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10099&action=edit Bug 7710 - multiple holds per title - Part 2 - Switch to using reserve_id Where necessary, switch from using biblionumber/borrowernumber to using reserve_id to reference individual reserves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:14:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:14:13 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8602|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 10100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10100&action=edit Bug 7710 - multiple holds per title - Part 3 - Add multiple holds per record for intranet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:14:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:14:29 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10078|0 |1 is obsolete| | --- Comment #84 from Paul Poulain --- Comment on attachment 10078 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10078 [SIGNED OFF] Bug 6679: Fixing 23 perlcritic violations in C4/Tags.pm This patch does not apply, replaced by another one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:14:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:14:29 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8603|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 10101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10101&action=edit Bug 7710 - multiple holds per title - Part 4 - Add multiple holds per record for the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:14:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:14:44 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 --- Comment #13 from Kyle M Hall --- Created attachment 10102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10102&action=edit Bug 7710 - multiple holds per title - Part 5 - Clean up missed 'reservenumber's, convert to reserve_id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:15:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:15:07 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|7065 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:15:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:15:07 +0000 Subject: [Koha-bugs] [Bug 7065] reserves table needs a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|7710 | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:15:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:15:28 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7065 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:15:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:15:28 +0000 Subject: [Koha-bugs] [Bug 7065] reserves table needs a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7710 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:15:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:15:58 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10079|0 |1 is obsolete| | --- Comment #85 from Paul Poulain --- Comment on attachment 10079 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10079 [SIGNED OFF] Bug 6679: Fixing 26 perlcritic violations in C4/Tags.pm this patch has been pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:16:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:16:17 +0000 Subject: [Koha-bugs] [Bug 7710] multiple holds per title In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7710 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7065 Depends on|7065 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:16:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:16:17 +0000 Subject: [Koha-bugs] [Bug 7065] reserves table needs a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|7710 | Depends on| |7710 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:16:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:16:47 +0000 Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic tests In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #86 from Paul Poulain --- (In reply to comment #85) > Comment on attachment 10079 [details] > [SIGNED OFF] Bug 6679: Fixing 26 perlcritic violations in C4/Tags.pm > > this patch has been pushed Still a lot of things to update in C4/Tags.pm: "return" statement with explicit "undef" at line 120, column 25. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 126, column 27. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 148, column 10. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 154, column 10. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 160, column 10. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 166, column 10. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 362, column 22. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 373, column 22. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 387, column 23. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 409, column 23. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 422, column 23. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 429, column 23. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 438, column 22. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 463, column 23. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 464, column 26. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 473, column 30. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 474, column 30. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 487, column 10. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 508, column 47. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 560, column 30. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 561, column 30. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 565, column 13. See page 199 of PBP. (Severity: 5) "return" statement with explicit "undef" at line 574, column 3. See page 199 of PBP. (Severity: 5) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:18:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:18:55 +0000 Subject: [Koha-bugs] [Bug 8201] can't change receive date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8201 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #9 from Paul Poulain --- QA comment: tiny patch that just replaces datereceived=[% loop_order.invoicedatereceived %] by datereceived=[% invoicedatereceived %] passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:19:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:19:47 +0000 Subject: [Koha-bugs] [Bug 8201] can't change receive date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8201 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #10 from Paul Poulain --- Not sure 3.8 is affected, but if it is, then worth pushing it onto stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:23:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:23:38 +0000 Subject: [Koha-bugs] [Bug 7653] make OPAC subscriptions view clearer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7653 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8031|0 |1 is obsolete| | --- Comment #5 from Chris Cormack --- Created attachment 10103 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10103&action=edit Bug 7563 [ENH] - Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference Configure slip printers to print slips (silently) to a special printer using the Firefox PlugIn jsPrintSetUp. All other print actions are not affected. See http://jsprintsetup.mozdev.org/ for all the possibilities (e.g. change header/footer, get a list of printers, set printer etc.). The overall concept is to have a new staff client preference (IntranetSlipPrinterJS) where one can enter the necessary JavaScript. If the preference is empty, Koha falls back to te default behaviour. An example of JavaScript can be found on: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:24:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:24:07 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #14 from Chris Cormack --- Fixed, was a bad merge conflict fix -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:27:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:27:01 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10073|0 |1 is obsolete| | --- Comment #15 from Chris Cormack --- Created attachment 10104 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10104&action=edit Bug 7563 [ENH] - Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference Configure slip printers to print slips (silently) to a special printer using the Firefox PlugIn jsPrintSetUp. All other print actions are not affected. See http://jsprintsetup.mozdev.org/ for all the possibilities (e.g. change header/footer, get a list of printers, set printer etc.). The overall concept is to have a new staff client preference (IntranetSlipPrinterJS) where one can enter the necessary JavaScript. If the preference is empty, Koha falls back to te default behaviour. An example of JavaScript can be found on: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Signed-off-by: Chris Cormack http://bugs.koha-community.org/show_bug.cgi?id=7653 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:27:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:27:45 +0000 Subject: [Koha-bugs] [Bug 7653] make OPAC subscriptions view clearer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7653 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10103|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:28:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:28:00 +0000 Subject: [Koha-bugs] [Bug 7653] make OPAC subscriptions view clearer In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7653 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8031|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:29:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:29:51 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Michael Davis --- (In reply to comment #10) > Michael, what exactly do you mean by "breaks tabs".. for example on > cataloguing/addbiblio.pl > > I'm seeing perfect normal operation.. Wondering if I have something cached > somewhere or similar and am there for not seeing the effect of the patch? The tabs are not styled as tabs, but appearing as an unstyled ul list. This should be styled by the jquery-ui.css, so either I'm not getting this when I should, or you're getting it when you shouldn't. Could be a caching issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:31:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:31:00 +0000 Subject: [Koha-bugs] [Bug 8136] Changes the expected lenght of 100$a in rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8136 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |sophie.meynieux at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:32:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:32:01 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff CC| |paul.poulain at biblibre.com --- Comment #12 from Paul Poulain --- QA comment: very large patch, but most of it is the new version of jquery tab. Changes in templates are all the same, changing links and tab declaration. I checked some pages and couldn't see anything wrong. No reason to object passed QA, even if, due to the size of the patch, I haven't checked everything ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:33:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:33:13 +0000 Subject: [Koha-bugs] [Bug 8201] can't change receive date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8201 --- Comment #11 from Katrin Fischer --- From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:35:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:35:18 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Paul Poulain --- (In reply to comment #11) > (In reply to comment #10) > > Michael, what exactly do you mean by "breaks tabs".. for example on > > cataloguing/addbiblio.pl > > > > I'm seeing perfect normal operation.. Wondering if I have something cached > > somewhere or similar and am there for not seeing the effect of the patch? > > The tabs are not styled as tabs, but appearing as an unstyled ul list. This > should be styled by the jquery-ui.css, so either I'm not getting this when I > should, or you're getting it when you shouldn't. Could be a caching issue. OK, checked with Michael, seems it was a FF cache issue, will push -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:35:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:35:37 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Pushed for QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:35:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:35:53 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed for QA |Pushed to Master Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:36:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:36:21 +0000 Subject: [Koha-bugs] [Bug 3144] anti-spam for opac-suggestions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3144 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:37:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:37:20 +0000 Subject: [Koha-bugs] [Bug 7961] Local cover images should support CSV link files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7961 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9960|0 |1 is obsolete| | --- Comment #11 from Dobrica Pavlinusic --- Created attachment 10105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10105&action=edit Bug 7961 - Local cover images should support CSV link files Corrent code doesn't have support for filenames which contain spaces or commans which breaks CSV files saved from spreadsheet similar to: 12345, "conver image, with spaces.jpg" This patch tweaks file parsing a bit. We are always splitting line to only two values (to support commas as part of filename) and removing spaces only on beginning and end of filename (to cover space after comma in CSV example above while preserving spaces in filename). With this change only invalid character in picture filename left are quotes (") which are commonly used to quote strings with spaces. Covers added will be logged in action_log, using CATALOGUING / MODIFY action (which is shown as "Catalog" in tools > Log viewer) Test scenario: 1. collect pictures with spaces and commas in name 2. dump file list into CSV file and add biblio number as first column (name of file is idlink.txt or datalink.txt) 3. create zip with CSV file and pictures 4. verify that all pictures got uploaded and linked to biblio records 5. verify that modification log includes cover image name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:37:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:37:41 +0000 Subject: [Koha-bugs] [Bug 7941] Fix version numbers in modules and set up a system to keep them up to date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7941 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9097|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall --- Created attachment 10106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10106&action=edit Bug 7941 : Fix version numbers in modules Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:38:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:38:08 +0000 Subject: [Koha-bugs] [Bug 7941] Fix version numbers in modules and set up a system to keep them up to date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7941 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:38:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:38:49 +0000 Subject: [Koha-bugs] [Bug 7961] Local cover images should support CSV link files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7961 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:43:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:43:01 +0000 Subject: [Koha-bugs] [Bug 3571] AutoTruncation is not allowed alone In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3571 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED CC| |mjr at software.coop Resolution|--- |FIXED --- Comment #3 from MJ Ray (software.coop) --- I think that this is already in master C4::Search::buildQuery somehow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:44:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:44:41 +0000 Subject: [Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |martin.renvoize at ptfs-europe | |.com --- Comment #9 from Martin Renvoize --- Needs re-basing against master... taking a look now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:48:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:48:00 +0000 Subject: [Koha-bugs] [Bug 4527] Item details don't respect newlines in details data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4527 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2143|0 |1 is obsolete| | --- Comment #5 from MJ Ray (software.coop) --- Created attachment 10107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10107&action=edit Bug 4527 - Support newlines in the notes field when displaying Signed-off-by: MJ Ray -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:48:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:48:17 +0000 Subject: [Koha-bugs] [Bug 4527] Item details don't respect newlines in details data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4527 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off CC| |mjr at software.coop -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:51:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:51:45 +0000 Subject: [Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8130|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize --- Created attachment 10108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10108&action=edit Bug 7444: [REBASED] Update circ/circulation.pl to use KohaDates TT Plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:52:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:52:02 +0000 Subject: [Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:57:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:57:52 +0000 Subject: [Koha-bugs] [Bug 8201] can't change receive date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8201 --- Comment #12 from Katrin Fischer --- Created attachment 10109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10109&action=edit [3.6.x] Bug 8201: Receive date not passed through correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:58:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:58:36 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon's AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10024|0 |1 is obsolete| | --- Comment #5 from Jared Camins-Esakov --- Created attachment 10110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10110&action=edit Bug 4460 - Amazon's AssociateID tag not used in links so referred revenue lost Rewrite of patch authored by Reed Wade Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 15:59:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 13:59:21 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon's AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:02:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:02:30 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #12 from Robin Sheat --- Created attachment 10111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10111&action=edit Bug 7642 - remove the cloud weight from the tags -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:02:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:02:55 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10028|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:03:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:03:16 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:05:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:05:04 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9978|0 |1 is obsolete| | --- Comment #10 from Michael Davis --- Created attachment 10112 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10112&action=edit [SIGNED-OFF] Bug 7570 - Add Item availability status to cart. Added Item availability status to cart(Location table cell). Changes: -opac/opac-basket.pl: Added code to show In transmit status and modified @items to call "GetItemsInfo" instead of "GetItemsLocationInfo" to get accurate avalibility status. -koha-tmpl/opac-tmpl/prog/en/modules/opac-basket.tt: Added code for showing availibility staus in opac-basket page and in "More details" link. Test Cases: -Add records to your cart with different cases like 1 record with different Item status(Lost,Avaliable,Withdrawn,etc). -Click on your cart and see the results in a new window. -Click on "More details" link and check the results. Signed-off-by: Michael Davis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:05:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:05:38 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 --- Comment #11 from Michael Davis --- Created attachment 10113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10113&action=edit bug 7570: add a space to the table header Add a space to separate Location from (Status) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:10:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:10:13 +0000 Subject: [Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10108|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 10114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10114&action=edit 10108: Bug 7444: [SIGNED] Update circ/circulation.pl to use KohaDates TT Plugin Tested as outline in Ian's comment. All working as expected, taking note of the syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:10:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:10:34 +0000 Subject: [Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:12:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:12:03 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10113|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer --- Created attachment 10115 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10115&action=edit [SIGNED-OFF] bug 7570: add a space to the table header Add a space to separate Location from (Status) Signed-off-by: Katrin Fischer Typo fix, all ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:12:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:12:16 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:13:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:13:57 +0000 Subject: [Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 --- Comment #12 from Martin Renvoize --- Related Note: Under "Details" tab for patron record, the checkouts summary at the bottom of the page displays as a Date Time (i.e is followed by 00:00) This is not consistent with how the table is displayed elsewhere.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:17:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:17:41 +0000 Subject: [Koha-bugs] [Bug 5910] Authorities : allow users to search on all auth types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4909|0 |1 is obsolete| | --- Comment #10 from Jared Camins-Esakov --- Created attachment 10116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10116&action=edit Bug 5910: allow users to search on all auth types Add search on "all authorities types" option in the authorities type select rewritten for T::T Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:17:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:17:53 +0000 Subject: [Koha-bugs] [Bug 5910] Authorities : allow users to search on all auth types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910 --- Comment #11 from Jared Camins-Esakov --- Created attachment 10117 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10117&action=edit Bug 5910: only add "All authority types" for UNIMARC UNIMARC is the only marcflavour that does not already have an option for searching all authority types, so check that the marcflavour is UNIMARC before displaying the additional "All authority types" option. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:18:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:18:40 +0000 Subject: [Koha-bugs] [Bug 5910] Authorities : allow users to search on all auth types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Version|rel_3_4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:19:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:19:48 +0000 Subject: [Koha-bugs] [Bug 8066] action logs default value In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8066 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #8 from Paul Poulain --- OK, won't argue more and accept letting the syspref to 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:20:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:20:53 +0000 Subject: [Koha-bugs] [Bug 6554] Broken encoding in members home/search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6083|0 |1 is obsolete| | --- Comment #32 from MJ Ray (software.coop) --- Created attachment 10118 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10118&action=edit Bug 6554 - added session CGI queries and all ZebraPAR utf8_decode Rebased from added-session-CGI-queries-and-all-ZebraPAR-utf8-de-O_t1Z2.patch Original-Author: Dobrica Pavlinusic -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:21:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:21:16 +0000 Subject: [Koha-bugs] [Bug 6554] Broken encoding in members home/search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |mjr at software.coop -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:26:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:26:03 +0000 Subject: [Koha-bugs] [Bug 8201] can't change receive date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8201 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10109|0 |1 is obsolete| | --- Comment #13 from MJ Ray (software.coop) --- Created attachment 10119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10119&action=edit [3.6.x] Bug 8201: Receive date not passed through correctly Separate patch for 3.6.x because variable name got changed between versions. (supplieried instead of booksellerid) Signed-off-by: MJ Ray -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:36:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:36:44 +0000 Subject: [Koha-bugs] [Bug 7810] C4/Auth.pm - on plack restart session is undefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7810 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8553|0 |1 is obsolete| | --- Comment #8 from Jared Camins-Esakov --- Created attachment 10120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10120&action=edit Bug 7810 - C4/Auth.pm - on plack restart session is undefined So we shouldn't try to delete it. This produces application error instead of redirection to login page. I had similar problems with CGI, especially when session in browser is still active, and one on filesystem or database is already expired. Signed-off-by: Jared Camins-Esakov Solved the problem when my Plack installation started acting up due to stale cookies. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:37:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:37:21 +0000 Subject: [Koha-bugs] [Bug 6782] Move auto member cardnumber generation to occur when record is "Saved" (avoid collisions) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6782 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |m.r.davis at cranfield.ac.uk --- Comment #3 from Michael Davis --- The field is still marked as required, so fails the javascript validation on form submit. The comment under the field would be better if it followed the style under the other form elements -
      -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:37:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:37:47 +0000 Subject: [Koha-bugs] [Bug 7810] C4/Auth.pm - on plack restart session is undefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7810 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:43:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:43:18 +0000 Subject: [Koha-bugs] [Bug 8197] Software error when you have cleaned cookies in your browser and try to past the url to opac-topissues.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8197 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:46:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:46:24 +0000 Subject: [Koha-bugs] [Bug 8221] New: Adding item to patroncard Batch causes error in Plack Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8221 Priority: P5 - low Change sponsored?: --- Bug ID: 8221 Assignee: cnighswonger at foundations.edu Summary: Adding item to patroncard Batch causes error in Plack Severity: minor Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: NEW Version: master Component: Label printing Product: Koha Can't call method "get_attr" without a package or object reference at /home/jcamins/kohaclone/patroncards/edit-batch.pl line 126. at /home/jcamins/kohaclone/patroncards/edit-batch.pl line 145 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:46:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:46:42 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8922|0 |1 is obsolete| | --- Comment #21 from Matthias Meusburger --- Created attachment 10121 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10121&action=edit Bug 7294: Adds acquisition informations in marc record "View status 'in order' to the OPAC and staff interface. Specific fields from aqorders can be mapped to marc fields (using ACQ bibliographic framework): aqorders.branchcode aqorders.quantity aqorders.listprice aqorders.uncertainprice aqorders.rrp aqorders.ecost aqorders.notes aqorders.supplierreference aqorders.ordernumber This way, you can keep track on what is currently on order at biblio level until you receive everything. Once all items have been received, the marc field is deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:46:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:46:56 +0000 Subject: [Koha-bugs] [Bug 7302] CSV export of a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7302 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer --- Testing this without 5356 - billing address fields don't show up as expected, but feature works nicely. Will provide a follow up changing the column name from "Client number" to "Account number" to match description of the field in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:46:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:46:57 +0000 Subject: [Koha-bugs] [Bug 8184] Duplicate budget page lacks heading and breadcrumbs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8184 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz Version|rel_3_10 |rel_3_8 --- Comment #4 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:48:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:48:10 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:51:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:51:27 +0000 Subject: [Koha-bugs] [Bug 6698] Detail page for organisations should show only valid fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6698 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5021|0 |1 is obsolete| | --- Comment #7 from MJ Ray (software.coop) --- Created attachment 10122 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10122&action=edit Fix for Bug 6698, Detail page for organisations should show only valid fields The output of moremember.pl is supposed to change if the patron in question is an organization (has a category which is of type "I"). The script was checking borrowers.categorycode when it should have been checking categories.category_type. With this correction the right variable is passed to the template. The template needed additional corrections to be sure the correct fields were appearing. The patron entry form offers only phonepro and emailpro, so moremember.pl should output those fields in particular. This patch hides other fields as suggested by the Bug report. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:52:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:52:21 +0000 Subject: [Koha-bugs] [Bug 6698] Detail page for organisations should show only valid fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6698 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |mjr at software.coop --- Comment #8 from MJ Ray (software.coop) --- Is this rebasing correct? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:54:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:54:31 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing addess improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #13 from Katrin Fischer --- Tried testing this together with 7302 and directly on master, but in both cases patch does not apply. Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 5356: delivery place and billing place centralised in basket management fatal: sha1 information is lacking or useless (C4/Acquisition.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 5356: delivery place and billing place centralised in basket management When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:54:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:54:53 +0000 Subject: [Koha-bugs] [Bug 8222] New: The zip code field is mandatory by default Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8222 Priority: P5 - low Change sponsored?: --- Bug ID: 8222 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: The zip code field is mandatory by default Severity: trivial Classification: Unclassified OS: All Reporter: robin at catalyst.net.nz Hardware: All Status: NEW Version: unspecified Component: Patrons Product: Koha The 'zipcode' field is mandatory by default when creating a patron. This is quite annoying in places where the zipcode isn't all that important. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:55:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:55:32 +0000 Subject: [Koha-bugs] [Bug 7302] CSV export of a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7302 --- Comment #14 from Katrin Fischer --- Patch depends on 5356 so testing not yet complete. Waiting for rebase of 5356. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:56:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:56:48 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Stacey Walker changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10111|0 |1 is obsolete| | Status|Needs Signoff |Signed Off Assignee|robin at catalyst.net.nz |stacey at catalyst-eu.net --- Comment #13 from Stacey Walker --- Created attachment 10123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10123&action=edit signed off patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:57:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:57:59 +0000 Subject: [Koha-bugs] [Bug 8222] The zip code field is mandatory by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8222 --- Comment #1 from Robin Sheat --- Created attachment 10124 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10124&action=edit Bug 8222 - make the zipcode no longer mandatory Having the zipcode field mandatory by default is a bit annoying for places where no one cares about it. This patch stops it being the case on new installs. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 16:58:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 14:58:18 +0000 Subject: [Koha-bugs] [Bug 8222] The zip code field is mandatory by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8222 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:06:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:06:43 +0000 Subject: [Koha-bugs] [Bug 7329] The "undo import into catalog" command deletes items onloan without checking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10070|0 |1 is obsolete| | --- Comment #6 from Sophie MEYNIEUX --- Created attachment 10125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10125&action=edit Bug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch table, if items are not deleted because they are issued. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:08:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:08:04 +0000 Subject: [Koha-bugs] [Bug 7329] The "undo import into catalog" command deletes items onloan without checking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 --- Comment #7 from Sophie MEYNIEUX --- Followup corrected to take care of biblios with several items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:08:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:08:26 +0000 Subject: [Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10090|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 10126 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10126&action=edit Bug 7952 - PDF::Reuse under plack writes to console STDOUT instead to browser Without name option to prFile, PDF::Reuse opens '-' file which is real console STDOUT on plack so pdf file gets emited to terminal instead of sending it to browser. This change creates temporary file using File::Temp, pass it to PDF::Reuse and then reads it back and prints it out for plack (or CGI) to pick up. Test secenario: 1. Home ? Tools ? Patron Card Creator ? Manage Card Batches 2. select batch checkbox and click Export 3. select template and click Export 4. click on pdf file to download it Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:08:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:08:43 +0000 Subject: [Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:12:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:12:36 +0000 Subject: [Koha-bugs] [Bug 6774] Display barcode on OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6774 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |m.r.davis at cranfield.ac.uk --- Comment #10 from Michael Davis --- Applying: Display barcode on OPAC detail page error: patch failed: installer/data/mysql/updatedatabase.pl:5308 error: installer/data/mysql/updatedatabase.pl: patch does not apply Patch failed at 0001 Display barcode on OPAC detail page The two patches are similar, so first should probably be obsoleted. Neither apply, so need to be resubmitted. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:15:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:15:33 +0000 Subject: [Koha-bugs] [Bug 7715] Add biblio.subtitle and appropriate mappings to MARC frameworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7715 Marijana Glavica changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mglavica at ffzg.hr --- Comment #5 from Marijana Glavica --- The problem with having "subtitle" field in a database is that there is no such field in MARC21 nor in UNIMARC. MARC21 has 245$b - remainder of title (subtitle, paralel title, etc.) UNIMARC has 200$e - other title information (subtitle and other information subordinate to title proper) On the other hand, from the practical point of view, it is very tempting to have separate database filed for this, because in SQL reports title is often not enough. But than, for some cases, title + subtitle is also not enough because we also have multipart items so we need title and subtitle together with number of part and title of part. Keywords to MARC mapping is much nicer solution, but it is not usable in SQL reports. But than, for SQL reports we now can use MySQL XML handling function, so this is not so big problem as before MySQL 5.1.5 So in conclusion, I vote against having subtitle field in database. If we go (back) in that direction, the name of this field should not be subtitle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:16:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:16:39 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 --- Comment #10 from Dobrica Pavlinusic --- Created attachment 10127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10127&action=edit Bug 6448 [1/3] EAN-13/UPC-A itemBarcodeInputFilter This filter which check validity of EAN-13 barcode and padd it with zeros up to full 13 digit number. This will also expand 12 digit UPC-A barcodes to EAN-13 automatically which is useful for older barcode readers which tend to ignore first zero in EAN-13 if they have just UPC-A support. It should be noted that EAN-13 or UPC-A product codes printed on books are not good choice for barcodes in Koha since each item has to have unique barcode. Test scenario: 1. prove t/Circulation_barcodedecode.t this checks expansion of 12 digit UPC-A to 13 digit EAN-13 and zero padding 2. in systempreferences search for itemBarcodeInputFilter and select EAN-13 3. edit one item and assign it valid EAN-13 barcode, eg. 0000000695152, check it out 4. test checkin with just 695152 to test leading zero expansion -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:17:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:17:18 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10019|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:25:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:25:01 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10127|0 |1 is obsolete| | --- Comment #11 from Chris Cormack --- Created attachment 10128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10128&action=edit Bug 6448 [1/3] EAN-13/UPC-A itemBarcodeInputFilter This filter which check validity of EAN-13 barcode and padd it with zeros up to full 13 digit number. This will also expand 12 digit UPC-A barcodes to EAN-13 automatically which is useful for older barcode readers which tend to ignore first zero in EAN-13 if they have just UPC-A support. It should be noted that EAN-13 or UPC-A product codes printed on books are not good choice for barcodes in Koha since each item has to have unique barcode. Test scenario: 1. prove t/Circulation_barcodedecode.t this checks expansion of 12 digit UPC-A to 13 digit EAN-13 and zero padding 2. in systempreferences search for itemBarcodeInputFilter and select EAN-13 3. edit one item and assign it valid EAN-13 barcode, eg. 0000000695152, check it out 4. test checkin with just 695152 to test leading zero expansion Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:27:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:27:59 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8669|0 |1 is obsolete| | --- Comment #12 from Chris Cormack --- Created attachment 10129 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10129&action=edit Bug 6448 [2/3] Barcodes::EAN13 autoBarcode Implement auto-incrementing EAN-13 barcodes To make this work, C4::Barcodes::next was modified to call process_tail with new incremented value so that process_tail can generate correct checksum. Since process_tail is currenlty not used by any barcodes, this change is safe. C4::Barcodes is used by addbiblio.pl when adding multiple records, while value_builder is used in all other cases. Test scenario: 1. prove t/Barcodes_EAN13.t 2. KOHA_CONF=/etc/koha/sites/fer/koha-conf.xml prove t/db_dependent/Barcodes.t this will check C4::Barcode implementataion 3. in systempreference change autoBarcode to incremental EAN-13 barcode 4. edit two items of any biblio assigning barcodes and verify that numbers are increasing. Have in mind that last digit is check digit, and it doesn't increment, but is calculated from barcode itself. Example with checksum in brackets: 000000086275[2], 000000086276[9], 000000086277[6] 5. Add Item and verify that it gets assigned next barcode 6. Add & Duplicate item and verify barcode increase 7. Add Multiple Copies and verify that barcode increase for each copy Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:32:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:32:48 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #22 from Matthias Meusburger --- Here's how to test: - Create the wanted koha to marc mappings. Only ordernumber is mandatory. - Place an order - Check that the mapped fields are reported in the record - Place another order - Modify one of the orders - Check that the modified order applies to the matching field of the record - Delete an order - Check that the order is deleted in the record - Delete the other order - Check that the order is deleted in the record and that the field to which it was mapped is also deleted (as there are no orders left). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:36:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:36:47 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8670|0 |1 is obsolete| | --- Comment #13 from Chris Cormack --- Created attachment 10130 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10130&action=edit Bug 6448 [3/3] EAN-13 barcode labels Current implementation doesn't scale barcodes because low-price CCD barcode readers are very sensitive about size Test scenario: 1. in Tools > Labels create or edit Layout and select EAN13 as barcode type 2. export one of existing batches using EAN13 layout and verify that generated pdf file contains barcodes 3. print pdf file and test it with barcode reader Signed-off-by: Chris Cormack -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:38:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:38:02 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:42:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:42:46 +0000 Subject: [Koha-bugs] [Bug 8222] The zip code field is mandatory by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8222 --- Comment #2 from Michael Davis --- Created attachment 10131 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10131&action=edit Bug 8222 - make the zipcode no longer mandatory Having the zipcode field mandatory by default is a bit annoying for places where no one cares about it. This patch stops it being the case on new installs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:43:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:43:02 +0000 Subject: [Koha-bugs] [Bug 4221] defaultSortField & OPACdefaultSortField non functioning In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4221 --- Comment #8 from Sophie MEYNIEUX --- Without applying any patch, I have tried to change the value of thoses sysprefs several times and search results seems to be correctly sorted. Nicole, could you give more information if it still does not work for you ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:43:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:43:34 +0000 Subject: [Koha-bugs] [Bug 7686] Tax rate wrong calculation in reception summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7686 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9864|0 |1 is obsolete| | --- Comment #5 from Adrien SAURAT --- Created attachment 10132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10132&action=edit signed off patch Tested OK with : 1/ tax calculated at reception 2/ tax included at order -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:43:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:43:42 +0000 Subject: [Koha-bugs] [Bug 7686] Tax rate wrong calculation in reception summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7686 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |adrien.saurat at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:43:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:43:53 +0000 Subject: [Koha-bugs] [Bug 8222] The zip code field is mandatory by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8222 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10124|0 |1 is obsolete| | Attachment #10131|0 |1 is obsolete| | --- Comment #3 from Michael Davis --- Created attachment 10133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10133&action=edit [SIGNED-OFF] Bug 8222 - make the zipcode no longer mandatory Having the zipcode field mandatory by default is a bit annoying for places where no one cares about it. This patch stops it being the case on new installs. Signed-off-by: Michael Davis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:44:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:44:50 +0000 Subject: [Koha-bugs] [Bug 8222] The zip code field is mandatory by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8222 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |m.r.davis at cranfield.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:45:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:45:30 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #27 from Katrin Fischer --- Found a small problem in the database update: 1) Database update kohastructure: `claimdate` date default NULL, + claims_count int(11) default 0, `routingnotes` text, updatedatabase: +if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { + $dbh->do("ALTER TABLE serial ADD COLUMN claims_count INT(11) DEFAULT 0"); + print "Upgrade to $DBversion done (Add claims_count field in serial table)\n"; + SetVersion($DBversion); +} + So the result will be a slightly different sequence of fields in the tables. I think would be better to make it the same to avoid confusion and possible problems. 2) Dates could be displayed using the TT Dates plugin 3) It would be nice if dates in the email could be formatted according to dateformat system preference (order date for example). Currently shows as: 2012-02-01 4) It would be good to update the sample notice to have the new syntax so people know how to use it. (like we did for 5347) 5) Commit message tells to use tags, but when I do, it does not get replaced: Template: <> <> <> <> <> <> <> <> <> <> Generated email: Quellensammlung zur Kulturgeschichte 24 8 12 2012-05-01 2012-04-10 Vol 2011, Issue 55 Quellensammlung zur Kulturgeschichte 25 8 12 2012-06-01 2012-04-10 Vol 2011, Issue 56 Failing QA mainly for 1 and 5. Sorry :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:48:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:48:49 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Marijana Glavica changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mglavica at ffzg.hr --- Comment #5 from Marijana Glavica --- This is interesting and very needed. I would like to test it, but patch does not apply any more. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:52:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:52:10 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- I agree with Marijana :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:53:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:53:23 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 --- Comment #14 from Dobrica Pavlinusic --- Created attachment 10134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10134&action=edit Bug 6448 [3/3] EAN-13 barcode labels Current implementation doesn't scale barcodes because low-price CCD barcode readers are very sensitive about size Test scenario: 1. in Tools > Labels create or edit Layout and select EAN13 as barcode type 2. export one of existing batches using EAN13 layout and verify that generated pdf file contains barcodes 3. print pdf file and test it with barcode reader -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:55:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:55:26 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9382|0 |1 is obsolete| | --- Comment #54 from MJ Ray (software.coop) --- Created attachment 10135 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10135&action=edit Bug 5339 rebased and rolled into one commit. Capstone for Elliott Author: Elliott Davis -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:56:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:56:36 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10072|0 |1 is obsolete| | --- Comment #17 from Marc V?ron --- Created attachment 10136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10136&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Test scenario: 1) Make sure that you have a column 'agerestriction' in table biblioitems. This will be handled by updatedatabase.pl. If you want to insert the column using mysql, you can do: ALTER TABLE biblioitems ADD COLUMN 'agerestriction' VARCHAR(255) DEFAULT NULL AFTER 'cn_sort' 2) In the staff client, go to Home . Administration . Koha to MARC mapping and choose biblioitems + OK. In the field list, the field 'agerestriction' should show up. Edit it and map the field e.g. to 521a 3) Go to Home . Administration . System preferences and edit Circulation: AgeRestrictionMarker (add eg.: FSK|PEGI|Age) and AgeRestrictionOverride (Prevent or Don't prevent) 4) Create a young patron account e.g. with age < 16 5) Create or edit a biblio with e.g. the value FSK 16 in the field 521a (same field as mapped above) 6) Try to check out to young patron 7) Chckout should be blocked or issue a warning with override (depending on AgeRestrictionOverride) Signed-off-by: Chris Cormack New version implementing Paul's advice. Wiki page prepared (http://wiki.koha-community.org/wiki/Age_restriction) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:56:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:56:51 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10135|0 |1 is obsolete| | --- Comment #55 from MJ Ray (software.coop) --- Created attachment 10137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10137&action=edit Bug 5339 rebased and rolled into one commit. Capstone for Elliott Signed-off-by: MJ Ray -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 17:57:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 15:57:09 +0000 Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mjr at software.coop -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 18:02:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 16:02:21 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 18:02:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 16:02:58 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 --- Comment #3 from Katrin Fischer --- Created attachment 10138 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10138&action=edit screenshot of budget page Hi Jonathan, the javasript page on the page seems to be broken for me. I tried refreshing the cache and closing the browser completely. I think it should not be separate tables but tabs? Perhaps patch could also make use of the Koha dates plugin? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 18:03:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 16:03:04 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 18:03:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 16:03:31 +0000 Subject: [Koha-bugs] [Bug 7494] Use partial barcode or callnumber as a fallback for the barcode search in checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7494 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8652|0 |1 is obsolete| | --- Comment #2 from MJ Ray (software.coop) --- Created attachment 10139 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10139&action=edit bug 7494: optional checkout-time fallback search for a book -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 18:04:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 16:04:43 +0000 Subject: [Koha-bugs] [Bug 7494] Use partial barcode or callnumber as a fallback for the barcode search in checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7494 --- Comment #3 from MJ Ray (software.coop) --- rebased to current master. The idea of this feature is that if nothing is found as a barcode, it will do a regular search and use that if there is a match, warning if there were multiple matches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 18:17:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 16:17:27 +0000 Subject: [Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246 --- Comment #19 from Paul Poulain --- Trying to apply this patch, I get a SQL constraint error: INSERT INTO message_transports -> (message_attribute_id, message_transport_type, is_digest, letter_module, letter_code) VALUES -> (4, 'phone', 0, 'reserves', 'HOLD_PHONE'), -> (2, 'phone', 0, 'circulation', 'PREDUE_PHONE') -> ; ERROR 1452 (23000): Cannot add or update a child row: a foreign key constraint fails (`lecannetdesmaures`.`message_transports`, CONSTRAINT `message_transports_ibfk_1` FOREIGN KEY (`message_attribute_id`) REFERENCES `message_attributes` (`message_attribute_id`) ON DELETE CASCADE) portable lecannetdesmaures>select * from message_attributes; Investigating a little show that the message_transports table does not contain message_attribute_id 4 and 2 Investigating more, it's my sample database that is wrong. Adding the values that I don't have fixes the problem will push now -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 18:18:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 16:18:20 +0000 Subject: [Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #20 from Paul Poulain --- Patch pushed, but untested as I don't have Talking Tech subscription. Please test again in case there's a problem ! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 18:20:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 16:20:24 +0000 Subject: [Koha-bugs] [Bug 7065] reserves table needs a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065 --- Comment #22 from Paul Poulain --- As the _id proposal seems to make most ppl happy, I'll push the patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 18:21:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 16:21:59 +0000 Subject: [Koha-bugs] [Bug 7329] The "undo import into catalog" command deletes items onloan without checking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10070|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 18:38:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 16:38:41 +0000 Subject: [Koha-bugs] [Bug 7065] reserves table needs a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #23 from Paul Poulain --- Failed QA, and a tricky one !!! When tmp_reserve is created, it is from reserves, so with borrowernumber being NOT NULL default 0 When old_reserves is copied to tmp_reserves ... all NULL borrowernumbers are transformed to 0 ... and when it's copied back to old_reserves ... booom, contraint failed: [Sun Jun 10 18:28:14 2012] updatedatabase.pl: DBD::mysql::db do failed: Cannot add or update a child row: a foreign key constraint fails (`lecannetdesmaures`.`old_reserves`, CONSTRAINT `old_reserves_ibfk_1` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE SET NULL) at /home/paul/koha.dev/koha-community/installer/data/mysql/updatedatabase.pl line 5395. That's a common situation to have NULL in old_reserves, when a borrower is removed from the database but we want to keep the history of the hold "someone placed a hold on yyyy-mm-dd" I think the solution would be to have tmp_reserve be created from old_reserve, to enable the NULL field ! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 21:25:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 19:25:35 +0000 Subject: [Koha-bugs] [Bug 7065] reserves table needs a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9740|0 |1 is obsolete| | --- Comment #24 from Kyle M Hall --- Created attachment 10140 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10140&action=edit Bug 7065 - reserves table needs a primary key Adds the primary key reserve_id to reserves and old_reserves. Thanks to gmcharlt and jcamins for contributions. Signed-off-by: MJ Ray Signed-off-by: Ian Walls Updated DBrev to start with 3.09... instead of 3.08... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 10 21:26:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Jun 2012 19:26:06 +0000 Subject: [Koha-bugs] [Bug 7065] reserves table needs a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 07:55:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 05:55:16 +0000 Subject: [Koha-bugs] [Bug 7914] Easy printing of barcode label from catalog detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7914 Meenakshi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |meenakshi.r at osslabs.biz Assignee|savitra.sirohi at osslabs.biz |meenakshi.r at osslabs.biz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 08:09:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 06:09:07 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10136|0 |1 is obsolete| | --- Comment #18 from Marc V?ron --- Created attachment 10141 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10141&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Test scenario: 1) Make sure that you have a column 'agerestriction' in table biblioitems. This will be handled by updatedatabase.pl. If you want to insert the column using mysql, you can do: ALTER TABLE biblioitems ADD COLUMN 'agerestriction' VARCHAR(255) DEFAULT NULL AFTER 'cn_sort' 2) In the staff client, go to Home . Administration . Koha to MARC mapping and choose biblioitems + OK. In the field list, the field 'agerestriction' should show up. Edit it and map the field e.g. to 521a 3) Go to Home . Administration . System preferences and edit Circulation: AgeRestrictionMarker (add eg.: FSK|PEGI|Age) and AgeRestrictionOverride (Prevent or Don't prevent) 4) Create a young patron account e.g. with age < 16 5) Create or edit a biblio with e.g. the value FSK 16 in the field 521a (same field as mapped above) 6) Try to check out to young patron 7) Chckout should be blocked or issue a warning with override (depending on AgeRestrictionOverride) Signed-off-by: Chris Cormack New version implementing Paul's advice. Wiki page prepared (http://wiki.koha-community.org/wiki/Age_restriction) (Added modified file) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 08:10:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 06:10:39 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 08:43:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 06:43:10 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10141|0 |1 is obsolete| | --- Comment #19 from Marc V?ron --- Created attachment 10142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10142&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Test scenario: Signed-off-by: Chris Cormack New version implementing Paul's advice. Wiki page prepared (http://wiki.koha-community.org/wiki/Age_restrict (Added modified files..) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 08:48:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 06:48:25 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10142|0 |1 is obsolete| | --- Comment #20 from Marc V?ron --- Created attachment 10143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10143&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Test scenario: Signed-off-by: Chris Cormack New version implementing Paul's advice. Wiki page prepared (http://wiki.koha-community.org/wiki/Age_restrict (Added modified files..,) Sorry for that many patches, mistaked with adding files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 08:54:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 06:54:57 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10143|0 |1 is obsolete| | --- Comment #21 from Marc V?ron --- Created attachment 10144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10144&action=edit BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age without using categories Test scenario: Signed-off-by: Chris Cormack New version implementing Paul's advice. Wiki page prepared (http://wiki.koha-community.org/wiki/Age_restrict (Added modified files..,) Sorry for that many patches, mistaked with adding files. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 08:57:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 06:57:09 +0000 Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title with borrower's age without using categories In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621 --- Comment #22 from Marc V?ron --- Finally I got all files :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 09:19:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 07:19:58 +0000 Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #14 from Marc V?ron --- Installed patch yesterday, looked great, but in the meantime I get "Does not apply" error, sorry. Applying: Bug 6828 follow-up: adapt dashboard to new staff client theme error: patch failed: koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css:2274 error: koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css: patch does not apply Additionally, it would be nice to have a span around the line "last updated..." to make it possible to format or to hide it with CSS. Marc -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 09:30:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 07:30:42 +0000 Subject: [Koha-bugs] [Bug 8004] Items on Hold Lose Transfer After Being Scanned Twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004 --- Comment #4 from Kyle M Hall --- I guess I need to yell at myself from two years ago ; ) I don't think this is a good case for a view, considering the simplicity of the action. We can definitely discuss it though. I do think we could indeed get rid of perl code that gets the branchname and replace it with this filter, it will make code simpler and more understandable. It seems more correct to me, considering it is a matter of presentation, which is the job of the templates. (In reply to comment #3) > QA comment: > > * Kyle, what is fun is the answer to your question: > > This is because at some point, someone replaced the template > > variable WrongTransfer, which had previously contained the branchcode for > > the library to transfer to, with the full name of the library instead ( I > > assume to make a look nicer ). > git blame circ/returns.pl, says: > 74f6e35c (Kyle M Hall 2010-04-01 15:45:25 +0000 340) > $messages->{'WrongTransfer'} = GetBranchName( $messa... > > :D :D (and, incenditally, it's 2 years old !) > > However, this is a tiny patch, that adds a new plugin. After the > presentation chris made today about T::T plugins/views/..., i'm wondering if > creating a plugin for that is the best option we have. Shouldn't it be a > view ? > > Plus, if I push this patch, it means we should get rid of any branchname > display everywhere, remove LEFT JOIN branches USING(branchname) in many SQL > queries, cache GetBranchName to avoid useless SQL queries (branches are not > updated frequently, they are a good candidate for caching). > I'm not against this idea (in fact, I like it quite a lot), but we must > advertise it as much as possible, and if you can promize you'll take care of > patches cleaning branchname dependancies, that would be a good + ;-) > > I won't push the patch immediately, I suggest we speak of it tomorrow with > other hackers, and chris_c first, as he is experienced on T::T -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 09:56:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 07:56:56 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8941|0 |1 is obsolete| | --- Comment #7 from Julian Maurice --- Created attachment 10145 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10145&action=edit Database files Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 09:58:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 07:58:07 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8942|0 |1 is obsolete| | --- Comment #8 from Julian Maurice --- Created attachment 10146 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10146&action=edit Change subscription numbering pattern and frequencies Rebased on master and fixed two minor things that stopped working with new version of jQuery. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 09:58:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 07:58:37 +0000 Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and frequencies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:20:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:20:41 +0000 Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9858|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall --- Created attachment 10147 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10147&action=edit Bug 8130 - attach PDF files to a patron record Adds the ability to attach unlimited arbitrary files to a borrower record. Test Plan: 1) Enable system preference EnableBorrowerFiles 2) Look up borrower record, click 'Files' tab on left 3) Upload a file, download the file, delete the file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:22:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:22:40 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9970|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart --- Created attachment 10148 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10148&action=edit Rebased patch Rebased patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:23:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:23:11 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:28:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:28:34 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9762|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall --- Created attachment 10149 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10149&action=edit Bug 7720 - Ambiguity in OPAC Details location. Currently, in opac-detail.pl, there exists a column named 'Location'. This column lists the name of the holding branch, and the item's location description. This can cause confusion to borrowers, as they may assume that the holding branch is the *owning* branch (homebranch) of an item. This could cause a situation where a borrower waits for an item to be returned to his or her library, only to find that the library never owned that item, and it was transferred back to it's homebranch. It could also lead a borrower to falsely assume that his or her home library does not own a copy of a particular item because the borrower does not see an his or her home library listed for any of the items on the record. In addition, even when the holding branch is different than the home branch, the item's shelving location is displayed, even though that branch may not use that location. This commit makes the item details table equivilent to the intranet details page by adding a "Home Library" column, which displays the item's home library, as well as the shelving location. If singleBranchMode is enabled, this column disappears and the "Location" column displays the shelving location only. This commit adds two new system preferences: OpacLocationBranchToDisplay, which defines whether to display the holding library, the home library, or both for the opac details page. OpacLocationBranchToDisplayShelving, which defines where the shelving location should be displayed, under the home library, the holding library, or both. http://bugs.koha-community.org/show_bug.cgi?id=7220 http://bugs.koha-community.org/show_bug.cgi?id=3556 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:28:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:28:59 +0000 Subject: [Koha-bugs] [Bug 7720] Ambiguity in OPAC Details location. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:29:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:29:14 +0000 Subject: [Koha-bugs] [Bug 7302] CSV export of a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7302 --- Comment #15 from Jonathan Druart --- Created attachment 10150 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10150&action=edit Bug 7302: Followup: rename "Client number" column with "Account number" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:32:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:32:44 +0000 Subject: [Koha-bugs] [Bug 6090] empty mails in message_queue are sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6090 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9996|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 10151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10151&action=edit Bug 6090: Do not enqueue empty messages This patch avoid enqueuing messages that have an empty body. It can happen when letter is empty or becomes empty after being processed by parseletter Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:33:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:33:03 +0000 Subject: [Koha-bugs] [Bug 6090] empty mails in message_queue are sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6090 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:35:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:35:22 +0000 Subject: [Koha-bugs] [Bug 8004] Items on Hold Lose Transfer After Being Scanned Twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha.sekjal at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:36:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:36:48 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing addess improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9975|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 10152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10152&action=edit Bug 5356: delivery place and billing place centralised in basket management Rebased patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:37:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:37:24 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing addess improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:45:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:45:37 +0000 Subject: [Koha-bugs] [Bug 8223] New: Properly format SQL query in C4::Bookseller::GetBookSeller Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8223 Priority: P5 - low Change sponsored?: --- Bug ID: 8223 Assignee: koha-bugs at lists.koha-community.org Summary: Properly format SQL query in C4::Bookseller::GetBookSeller Severity: enhancement Classification: Unclassified OS: All Reporter: kyle.m.hall at gmail.com Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:46:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:46:30 +0000 Subject: [Koha-bugs] [Bug 8223] Properly format SQL query in C4::Bookseller::GetBookSeller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8223 --- Comment #1 from Kyle M Hall --- Created attachment 10153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10153&action=edit Bug 8223 - Properly format SQL query in C4::Bookseller::GetBookSeller -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:46:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:46:43 +0000 Subject: [Koha-bugs] [Bug 8223] Properly format SQL query in C4::Bookseller::GetBookSeller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8223 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:55:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:55:23 +0000 Subject: [Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8189|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 10154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10154&action=edit Bug 7401 - Shelving Location facet instead of Branch facet when only 1 branch configured Signed-off-by: Kyle M Hall Enable for either A) SingleBranchMode is enabled or B) There is only one branch in the branches table Signed-off-by: Nicole C. Engard Tested with one branch and with multiple branches, tested with SingleBranchMode on and off. All tests passed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:55:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:55:36 +0000 Subject: [Koha-bugs] [Bug 8224] New: aqplan.pl and aqbudgets: authorized values doesn't appear in planning list Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8224 Priority: P5 - low Change sponsored?: --- Bug ID: 8224 Assignee: koha-bugs at lists.koha-community.org Summary: aqplan.pl and aqbudgets: authorized values doesn't appear in planning list Severity: normal Classification: Unclassified OS: All Reporter: alex.arnaud at biblibre.com Hardware: All Status: NEW Version: rel_3_8 Component: Acquisitions Product: Koha When going to cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=1, authorized values defined for each funds doesn't appear in the planning list. Also, from here, if i click on "plan by (months|libraries|item types)", authorized values now appear but 'budget_period_id' is not defined in the url. Then planning by an authorized value make they all disappear again. This bug is a continuation of bug 4857. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:56:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:56:06 +0000 Subject: [Koha-bugs] [Bug 8224] aqplan.pl and aqbudgets: authorized values doesn't appear in planning list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8224 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |4857 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:56:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:56:06 +0000 Subject: [Koha-bugs] [Bug 4857] aqplan.pl: consideration of Planning categories with authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4857 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8224 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:56:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:56:15 +0000 Subject: [Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:56:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:56:30 +0000 Subject: [Koha-bugs] [Bug 7329] The "undo import into catalog" command deletes items onloan without checking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Katrin Fischer --- I am ready to sign-off on the first three patches, but there is a small thing I have to note. If you have a record with more than one item and one of the items is checked out, undoing the import will delete all items except for the checked out one. So this is perfectly correct. However, if you repeat the import after that, the additional items do not get readded to the record. I think this is only a very small issue and the import works a lot nicer with the patches. so signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:56:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:56:42 +0000 Subject: [Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha.sekjal at gmail.com |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:58:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:58:12 +0000 Subject: [Koha-bugs] [Bug 7329] The "undo import into catalog" command deletes items onloan without checking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6635|0 |1 is obsolete| | Attachment #10070|0 |1 is obsolete| | Attachment #10125|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 10155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10155&action=edit [SIGNED-OFF] Bug 7329: Items onloan are deleted when undoing import into catalog this patch checks the "on loan" and "reserved" status before deleting item, and do noting in this case, so the record can't be deleted due to existing item. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:58:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:58:19 +0000 Subject: [Koha-bugs] [Bug 7329] The "undo import into catalog" command deletes items onloan without checking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 --- Comment #10 from Katrin Fischer --- Created attachment 10156 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10156&action=edit [SIGNED-OFF] Bug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch table, if items are not deleted beacause on loan. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:58:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:58:26 +0000 Subject: [Koha-bugs] [Bug 7329] The "undo import into catalog" command deletes items onloan without checking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 --- Comment #11 from Katrin Fischer --- Created attachment 10157 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10157&action=edit [SIGNED-OFF] Bug 7329 [Followup] : when reverting an import, keep matching biblionumber in batch table, if items are not deleted because they are issued. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 10:59:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 08:59:48 +0000 Subject: [Koha-bugs] [Bug 8224] aqplan.pl and aqbudgets: authorized values doesn't appear in planning list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8224 --- Comment #1 from Alex Arnaud --- Created attachment 10158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10158&action=edit Bug 8224 - Make authorized values appear in planning list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:00:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:00:14 +0000 Subject: [Koha-bugs] [Bug 8224] aqplan.pl and aqbudgets: authorized values doesn't appear in planning list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8224 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:04:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:04:27 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #28 from Pierre Angot --- I've noticed a problem with the columns when I've saved a basket. They are shifted (cf bug_table.png). Test on sandbox 1. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:04:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:04:44 +0000 Subject: [Koha-bugs] [Bug 4857] aqplan.pl: consideration of Planning categories with authorised values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4857 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #9 from Alex Arnaud --- I created a new bug (bug 8224) for the remaining issues and sent a fix. So this one can be marked as resolved. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:04:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:04:44 +0000 Subject: [Koha-bugs] [Bug 8224] aqplan.pl and aqbudgets: authorized values doesn't appear in planning list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8224 Bug 8224 depends on bug 4857, which changed state. Bug 4857 Summary: aqplan.pl: consideration of Planning categories with authorised values http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4857 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:05:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:05:05 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #29 from Pierre Angot --- Created attachment 10159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10159&action=edit bug with columns -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:10:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:10:29 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch --- Comment #16 from Marc V?ron --- Wanted to sign off, but got "Does not apply" errors. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:10:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:10:51 +0000 Subject: [Koha-bugs] [Bug 4956] ordering from external doesn't let you search more than 2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4956 --- Comment #2 from Alex Arnaud --- I can't see the problem. Can you confirm it has been fixed ? So i could mark it as resolved. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:13:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:13:29 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 --- Comment #4 from Jonathan Druart --- Created attachment 10160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10160&action=edit Bug 8117: Followup: FIX compatibility for the new version of jQuery tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:14:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:14:28 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 --- Comment #5 from Jonathan Druart --- Created attachment 10161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10161&action=edit Bug 8117: Followup: Use the KohaDates plugin in aqbudgetperiods.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:14:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:14:39 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:23:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:23:56 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10134|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:24:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:24:47 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 --- Comment #7 from Jonathan Druart --- Created attachment 10162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10162&action=edit Bug 8217: Followup: move code to the document.ready function I agree with Owen. Could you test this patch and verify it do the same thing as previous please ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:24:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:24:54 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:25:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:25:00 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:26:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:26:11 +0000 Subject: [Koha-bugs] [Bug 6809] Add branch filter in holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6809 --- Comment #1 from Sagar.B.R --- Created attachment 10163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10163&action=edit Branch filter in holds to pull report Branch filter in holds to pull report -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:27:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:27:25 +0000 Subject: [Koha-bugs] [Bug 6809] Add branch filter in holds to pull report In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6809 Sagar.B.R changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Sagar.B.R --- Patch for applying branch filter to holds to pull report. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:31:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:31:37 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 --- Comment #8 from Jonathan Druart --- Sorry, Monday morning, I have troubles with my grammar... I reformulate : "Could you test this patch and verify that it does the same thing as previous please ?" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:32:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:32:28 +0000 Subject: [Koha-bugs] [Bug 7961] Local cover images should support CSV link files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7961 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:34:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:34:30 +0000 Subject: [Koha-bugs] [Bug 7961] Local cover images should support CSV link files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7961 --- Comment #12 from Dobrica Pavlinusic --- I asked Paul and he said we can skip sign-off for last change since it already got two sign-offs. However, currently submitted patch does not include sign-off lines (because I wrote it so it would be sheeting) so they would have to be added in QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:36:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:36:02 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #1848|0 |1 is obsolete| | --- Comment #1 from Kyle M Hall --- Created attachment 10164 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10164&action=edit Bugfix 4118 - Add Collection Code to Statistics Table - Updated C4 Modules to add Collection Codes to stats table -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:40:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:40:14 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #1849|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 10165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10165&action=edit Bugfix 4118 - Add Collection Code to Statistics Table - DB Update -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:40:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:40:31 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 11:55:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 09:55:08 +0000 Subject: [Koha-bugs] [Bug 7329] The "undo import into catalog" command deletes items onloan without checking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 --- Comment #12 from Sophie MEYNIEUX --- Katrin ; the problem is that the record is not totally reverted (one item left) and not totally imported (some items have been deleted). Should we add a status for this situation ("partially reverted" or "partially imported" ) ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:01:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:01:50 +0000 Subject: [Koha-bugs] [Bug 4807] C4/Reserves.pm : define a max pick up date when reserving an item In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4807 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |INVALID --- Comment #3 from Alex Arnaud --- I don't konw why i did this patch anymore ... And looks like this feature already in 3.8. So mark it as resolved invalid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:02:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:02:26 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:04:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:04:43 +0000 Subject: [Koha-bugs] [Bug 8225] New: Problem to view title details Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8225 Priority: P5 - low Change sponsored?: --- Bug ID: 8225 Assignee: oleonard at myacpl.org Summary: Problem to view title details Severity: normal Classification: Unclassified OS: All Reporter: vinod_librarian at rediffmail.com Hardware: All Status: NEW Version: rel_3_6 Component: OPAC Product: Koha When we click only first title of the second page of OPAC system gives following error in version 3.6.4 Software error: Can't use string ("07875nam a2200913Ia 450000800410") as an ARRAY ref while "strict refs" in use at /usr/share/koha/lib/C4/Search.pm line 1493. For help, please send mail to the webmaster (webmaster at koha-desktop), giving this error message and the time and date of the error. Another issue is alphabetical arrangement of Opac results disturb after Result number 1001 Vinod Kumar Mishra IIT Roorkee India -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:05:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:05:21 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9665|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 10166 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10166&action=edit Bug 8089: Use Koha::Cache for all caching 1. Replace all instances of memoize_memcached with appropriate calls into Koha::Cache: * reports/guided_reports.pl * C4::Biblio::GetMarcStructure * C4::Languages::getFrameworkLanguages * C4::Languages::getAllLanguages * C4::SQLHelper::GetPrimaryKeys * C4::SQLHelper::_get_columns 2. Replace all references to memcached with the appropriate calls into Koha::Cache in C4::Context. Test plan : * have DEBUG env set to 1 * reach addbiblio page to test the patch in Biblio.pm, or setup more than 1 language * you should see in the logs that you're reading and writing from cache * run the test suite twice both with and without the following environment variables set: export MEMCACHED_SERVERS=127.0.0.1:11211 export MEMCACHED_NAMESPACE=KOHA export CACHING_SYSTEM=memcached Signed-off-by: Chris Cormack I'm unsure about some of the caching times 10000 is a long long time, but other than that, works fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:06:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:06:46 +0000 Subject: [Koha-bugs] [Bug 6835] Ability to specify types of email address in overdue_notices.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6835 --- Comment #21 from M. de Rooy --- OK for changing existing routine. Final question: The if- condition ( @emails && !$nomail ) is clear, but what about its else-part? If the nomail flag is set, I think you should not send a mail. So please check that condition too in the else part (make it a elsif). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:07:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:07:49 +0000 Subject: [Koha-bugs] [Bug 8225] Problem to view title details in OPAC result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8225 vinod changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vinod_librarian at rediffmail. | |com Summary|Problem to view title |Problem to view title |details |details in OPAC result -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:08:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:08:46 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9666|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 10167 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10167&action=edit Bug 8089: Cache sysprefs using Koha::Cache Cache sysprefs using Koha::Cache in a way that is safe even for caching-related sysprefs. This lays the groundwork for removing caching configuration from the httpd.conf and configuring it using sysprefs. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:09:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:09:00 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9673|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 10168 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10168&action=edit Bug 8089: Correct cache timeout to 1000 There was a typo in the original patch for bug 8089 which set the cache timeout on getAllLanguages to 10000. Correct it to 1000. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:09:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:09:45 +0000 Subject: [Koha-bugs] [Bug 8089] Use Koha::Cache everywhere In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8089 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:12:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:12:04 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing addess improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #15 from Katrin Fischer --- Asking for a follow up for: 1) Changing the display to show the library name instead of branchcode on the basket summary page. Currently shows: Basketgroup Delivery place: MPL Basketgroup Billing place: MPL 2) Maybe changing the branchcode to the description in the CSV export file ? Not sure about this one. 3) On basket header the pull downs for delivery place and billing place don't sort alphabetically by description, but I think by code. 4) Same sorting problem for the pull downs on the basket group page. Failing QA for: 5) I am testing this on top of 7302 and the colums for basket and basket group delivery and shipping places remain empty in my exported basket group CSV. Jonathan- could you perhaps fix that in a follow up? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:13:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:13:24 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9616|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 10169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10169&action=edit Bug 7572 - Add Clubs & Services Feature This features adds the ability to create clubs and services which patrons may be enrolled in. It is particularly useful for tracking summer reading programs, book clubs and other such clubs. It includes 2 built-in service archetypes: Bestsellers Club : Batch generate a holds list which shuffles the holds queue when new items matching a given title or author are catalogued. New Items Weekly Mailing Lists : Create custom mailing lists to alert subscribers to new items in your library. This code has been in production for a number of years at the Crawford County Federated Library System. Test Plan: 1) Add clubs & services permissions for a librarian account. 2) Create a new archetype 3) Create a new club or service based on the archetype 4) Enroll a borrower in the club or service 5) Cancel the enrollment in the club or service 6) Verify the permissions work correctly by turning off each one in turn and attempt to perform the action that should be denied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:14:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:14:40 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:17:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:17:58 +0000 Subject: [Koha-bugs] [Bug 7572] Add Clubs & Services Feature In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7572 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:22:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:22:05 +0000 Subject: [Koha-bugs] [Bug 8226] New: 'OpacFooter' markup/css improvements Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8226 Priority: P5 - low Change sponsored?: --- Bug ID: 8226 Assignee: oleonard at myacpl.org Summary: 'OpacFooter' markup/css improvements Severity: trivial Classification: Unclassified OS: All Reporter: mtj at kohaaloha.com Hardware: All Status: NEW Version: master Component: OPAC Product: Koha here are 2 small 'OpacFooter' markup and css improvements 1) add a 'nofollow' attribute to the tag 2) add a color and font-size improvement to the tag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:24:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:24:33 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #30 from Jonathan Druart --- Hi Pierre, I can't reproduce your problem, could you explain the procedure to reproduce please ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:26:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:26:19 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Marijana Glavica changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mglavica at ffzg.hr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:27:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:27:19 +0000 Subject: [Koha-bugs] [Bug 7908] Acquisitions: Maintain payment details against vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7908 --- Comment #2 from Amit Gupta --- Created attachment 10170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10170&action=edit Acquisitions: Maintain payment details against vendors New payments button against each vendor. Capture payment details - cheque no, date and notes against one or more invoices that show under section "Pending payments". Once invoices are paid the invoices move to the section "Already paid". Screens are very similar to invoice receiving screens. Currently the "order_receive" permission is used to allow access to this feature, this will be changed in a subsequent patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:27:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:27:35 +0000 Subject: [Koha-bugs] [Bug 7908] Acquisitions: Maintain payment details against vendors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7908 Amit Gupta changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:32:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:32:34 +0000 Subject: [Koha-bugs] [Bug 8227] New: Remove compile time warning from C4::Serials Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8227 Priority: P5 - low Change sponsored?: --- Bug ID: 8227 CC: colin.campbell at ptfs-europe.com Assignee: koha-bugs at lists.koha-community.org Summary: Remove compile time warning from C4::Serials Severity: minor Classification: Unclassified OS: All Reporter: colin.campbell at ptfs-europe.com Hardware: All Status: NEW Version: unspecified Component: Serials Product: Koha C4::Serials issues a depreciation warning over the use of qw(...) as parentheses In earlier perl code qw( ... ) was assumed to be equivalent to ( qw( ... ) ) since 5.14 this is no longer the case and different code is generated. perl 5.14.2 and 5.16.0 issue warnings and this will become an error in later perls -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:34:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:34:37 +0000 Subject: [Koha-bugs] [Bug 8228] New: Koha Offline Circulation screen does not render correctly in Ubuntu Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8228 Priority: P5 - low Change sponsored?: --- Bug ID: 8228 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Koha Offline Circulation screen does not render correctly in Ubuntu Severity: normal Classification: Unclassified OS: All Reporter: bob at calyx.net.au Hardware: All Status: NEW Version: rel_3_6 Component: Circulation Product: Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:36:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:36:28 +0000 Subject: [Koha-bugs] [Bug 8152] Clicking cancel on edit suggestion redirect to the suggestion detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8152 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9773|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 10171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10171&action=edit [SIGNED-OFF] Bug 8152: Clicking cancel link on edit suggestion redirect to the suggestions list Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:37:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:37:58 +0000 Subject: [Koha-bugs] [Bug 8226] 'OpacFooter' markup/css improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8226 --- Comment #1 from Mason James --- Created attachment 10172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10172&action=edit patch for Bug 8226 - 'OpacFooter' markup/css improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:39:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:39:57 +0000 Subject: [Koha-bugs] [Bug 8226] 'OpacFooter' markup/css improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8226 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Mason James --- patch sent :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:41:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:41:21 +0000 Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 --- Comment #6 from Michael Davis --- Created attachment 10173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10173&action=edit bug 8130: remove merge marker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:41:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:41:35 +0000 Subject: [Koha-bugs] [Bug 8228] Koha Offline Circulation screen does not render correctly in Ubuntu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8228 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|All |PC OS|All |Linux --- Comment #1 from Bob Birchall --- The Koha Offline Circulation screen, when installed to Ubuntu (from download, not the Firefox plug-in) fails to render correctly. The screen is overly large and the user is unable to click into any field. Ubuntu 10.04 LTS GNOME 2.30.2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:43:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:43:41 +0000 Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.r.davis at cranfield.ac.uk --- Comment #7 from Michael Davis --- Works fine, except there does not seem to be any delete function. Either add delete function or change remit to not include a delete function and add a new bug for delete capability. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:44:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:44:09 +0000 Subject: [Koha-bugs] [Bug 8152] Clicking cancel on edit suggestion redirect to the suggestion detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8152 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:45:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:45:05 +0000 Subject: [Koha-bugs] [Bug 8227] Remove compile time warning from C4::Serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8227 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell --- Created attachment 10174 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10174&action=edit Proposed Patch To test perl -wc C4/Serials.pm should not produce a warning over the missing parentheses I believe warning is only issued by perl >= 5.14 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:46:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:46:48 +0000 Subject: [Koha-bugs] [Bug 5295] ctype index Zebra configuration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com --- Comment #5 from Alex Arnaud --- Tiny patch. Tested searches on Content-type and it works. So signing off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:47:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:47:37 +0000 Subject: [Koha-bugs] [Bug 5295] ctype index Zebra configuration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9655|0 |1 is obsolete| | --- Comment #6 from Alex Arnaud --- Created attachment 10175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10175&action=edit [Signed-off] Bug 5295 : ctype index Zebra configuration Patch submitted originally by Fridolyn SOMERS Reformatted as a git patch Signed-off-by: Alex Arnaud -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:48:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:48:03 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #31 from Pierre Angot --- Nothing sp?cial ^^ - manage suggest - create basket - add an order line from suggest I have tested with Chromium. No problem with Firefox. Maybe a bug with Chromium ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:48:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:48:20 +0000 Subject: [Koha-bugs] [Bug 5295] ctype index Zebra configuration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:48:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:48:22 +0000 Subject: [Koha-bugs] [Bug 8004] Items on Hold Lose Transfer After Being Scanned Twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004 --- Comment #5 from Kyle M Hall --- Spoke to Chris about his, he also feels that the filter is the right way to go. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:50:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:50:21 +0000 Subject: [Koha-bugs] [Bug 8004] Items on Hold Lose Transfer After Being Scanned Twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:50:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:50:52 +0000 Subject: [Koha-bugs] [Bug 8228] Koha Offline Circulation screen does not render correctly in Ubuntu In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8228 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:51:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:51:31 +0000 Subject: [Koha-bugs] [Bug 7329] The "undo import into catalog" command deletes items onloan without checking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 --- Comment #13 from Katrin Fischer --- I think it would be nice, but perhaps could be a different bug and enhancement :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 12:59:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 10:59:23 +0000 Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 --- Comment #8 from Kyle M Hall --- Created attachment 10176 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10176&action=edit Bug 8130 - Fix incorrect permission, allow deletion of files of logged in user has 'borrowers' permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:00:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:00:28 +0000 Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10147|0 |1 is obsolete| | Attachment #10173|0 |1 is obsolete| | Attachment #10176|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall --- Created attachment 10177 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10177&action=edit Bug 8130 - attach PDF files to a patron record Adds the ability to attach unlimited arbitrary files to a borrower record. Test Plan: 1) Enable system preference EnableBorrowerFiles 2) Look up borrower record, click 'Files' tab on left 3) Upload a file, download the file, delete the file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:01:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:01:09 +0000 Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 --- Comment #10 from Kyle M Hall --- Squashed all patches together for ease of use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:02:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:02:02 +0000 Subject: [Koha-bugs] [Bug 7963] Parallel HTTP requests when checking URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org --- Comment #4 from Dobrica Pavlinusic --- Works nicely, but here are two nit-picks: * script should be named check-url-parallel or something similar so that users know why we have two scripts with almost same name but not quite * --host-pro should probably be --host-intranet to better convey meaning of flag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:09:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:09:32 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9635|0 |1 is obsolete| | Attachment #10160|0 |1 is obsolete| | Attachment #10161|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 10178 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10178&action=edit [SIGNED-OFF] Bug 8117: Divide budget periods into two tabs Budget periods are now divided into two tabs : active and inactive budget periods. The original author of this patch is Julian Maurice Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:09:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:09:40 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 --- Comment #7 from Katrin Fischer --- Created attachment 10179 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10179&action=edit [SIGNED-OFF] Bug 8117: Followup: FIX compatibility for the new version of jQuery tabs Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:09:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:09:47 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 --- Comment #8 from Katrin Fischer --- Created attachment 10180 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10180&action=edit [SIGNED-OFF] Bug 8117: Followup: Use the KohaDates plugin in aqbudgetperiods.tt Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:10:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:10:19 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:10:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:10:53 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9990|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 10181 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10181&action=edit Course Reserves Adds a course reserves system for academic libraries. The course reserves system allows libraries to create courses and put items on reserves for those courses. Each item with at least one reserve can have some of its attributes modified while it is on reserve for at least one active course. These attributes include item type, collection code, shelving location, and holding library. If there are no active courses with this item on reserve, it's attributes will revert to the original attributes it had before going on reserve. Testing Scenario: 1) Create new authorised value categories DEPARTMENT and TERM 2) Create a new course, add instructors to that course. 3) Reserve items for that course, verify item attributes have changed. 4) Disable course, verify item attributes have reverted. 5) Enable course again, verify item attributes again. 6) Delete course, verify item attributes again. 7) Create two new courses, add the same item(s) to both courses. 8) Disable one course, verify item attributes have not reverted. 9) Disable both courses, verify item attributes have reverted. 10) Enable one course, verify item attributes are again set to the new values. 11) Edit reserve item attributes, verify. 12) Disable all courses, edit reserve item attributes, verify the item itself still has its original attributes, verify the reserve item attributes have been updated. 13) Verify the ability to remove instructors from a course. 14) Verify new permissions, top level coursereserves, with subpermissions add_reserves and delete_reserves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:11:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:11:14 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:14:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:14:40 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.r.davis at cranfield.ac.uk --- Comment #9 from Michael Davis --- Looks really good, and I think this is a really good feature. However, it fails a javascript validation error when the patch is applied. To recreate, add two active budgets, apply patch, refresh budgets page. DataTables warning (table id = 'inactiveperiodst'): Requested unknown parameter '1' from the data source for row 0 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:16:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:16:47 +0000 Subject: [Koha-bugs] [Bug 8180] cataloguing/additem.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- I also can not replicate this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:17:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:17:47 +0000 Subject: [Koha-bugs] [Bug 8103] DataTables in Acquisision module: parcels.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8103 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9617|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 10182 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10182&action=edit [SIGNED-OFF] Bug 5345: DataTables integration in acquisition module [12] parcels.tt http://bugs.koha-community.org/show_bug.cgi?id=8103 Signed-off-by: Katrin Fischer Works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:18:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:18:15 +0000 Subject: [Koha-bugs] [Bug 8103] DataTables in Acquisision module: parcels.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8103 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:19:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:19:51 +0000 Subject: [Koha-bugs] [Bug 8183] acqui/parcels.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack --- Hmm, I can't recreate this bug I'm afraid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:20:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:20:46 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Marijana Glavica changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |mglavica at ffzg.hr --- Comment #6 from Marijana Glavica --- Except not showing call numbers, as Owen noted, there are few more things I noticed until now, so here are my examples: Before: Availability: Copies available for loan: Gimnazija Po?ega [456] (1), Knji?nica FFZG [678] (1). Copies available for reference: Knji?nica FFZG [R-123] (2). Damaged (1). After: Availability: Copies available for loan: Gimnazija Po?ega [456] (1), Knji?nica FFZG [678] (1). Damaged (1). Not for loan (1). Staff Collection (1). So, everything is now in one line. I don't agree that this is nicer, because now we have "not for loan" items under "Copies available for loan" label. The solution would be to change label only to "Available" or "Available for use" or something. This is tiny change to make, but there is another problem. In my second example I have situation like this: Before: Availability: Copies available for reference: Knji?nica FFZG [not for loan] (1). After: Availability: No copies available Not for loan (1). So, in my first example i have "not for loan" items under "Copies available for loan", but in my second example with just one item for biblio, this label disappears. In our library, items marked with "not for loan" status are available, but they can be used only in library, so the label "copies available for reference" was telling our users exactly that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:21:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:21:30 +0000 Subject: [Koha-bugs] [Bug 7973] Allow for new type of LDAP authentication In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7973 --- Comment #4 from Dobrica Pavlinusic --- I was thinking about renaming bind_as_service and reusing it to specify LDAP attribute from which to get login like: distinguishedName I know it's a long name, but this way we have just one configuration option (which is good istead of having two of them which would have to be modified in pair). It also provides some sense what does it do without reading documentation. Variants include: bind_as_user_and_get_login_from, bind_as_service_and_get_login but both of those are not much better than one above. I'm welcoming suggestion for better and/or cleaner option name. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:21:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:21:41 +0000 Subject: [Koha-bugs] [Bug 8102] DataTables in Acquisision module: supplier.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8102 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9780|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 10183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10183&action=edit [SIGNED-OFF] Bug 8102: DataTables integration in acquisition module [14] supplier.tt http://bugs.koha-community.org/show_bug.cgi?id=8102 Signed-off-by: Katrin Fischer Corrected bug number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:21:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:21:54 +0000 Subject: [Koha-bugs] [Bug 8102] DataTables in Acquisision module: supplier.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8102 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:26:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:26:50 +0000 Subject: [Koha-bugs] [Bug 7422] Prevent creation of vendors with the same name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7422 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:27:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:27:26 +0000 Subject: [Koha-bugs] [Bug 4255] Add item type to facet list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4255 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9847|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 10184 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10184&action=edit [SIGNED-OFF] Bug 4255 - Add item type to facet list This is for MARC 21 only. Made following changed: - In getFacets in C4/Koha.pm added item type facet for 952y and 942c - In getRecords in C4:Search.pm added code to get description of itemtype codes - facets.inc in both staff and opac to show item types related label in the facets block To test: Add records such that a certain itype (say BK) is present in both 942c and 952y in two DIFFERENT records. Run a search where both test records are present. Test to see if itype types are presented in the facets block (both OPAC and staff). Click on the itype (say BK), both the test records should appear in the refined results. This shows that the feature works for both 942c and 952y. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:27:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:27:49 +0000 Subject: [Koha-bugs] [Bug 4255] Add item type to facet list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4255 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:30:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:30:20 +0000 Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 --- Comment #11 from Michael Davis --- Created attachment 10185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10185&action=edit Bug 8130 - attach PDF files to a patron record Adds the ability to attach unlimited arbitrary files to a borrower record. Test Plan: 1) Enable system preference EnableBorrowerFiles 2) Look up borrower record, click 'Files' tab on left 3) Upload a file, download the file, delete the file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:30:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:30:58 +0000 Subject: [Koha-bugs] [Bug 8225] Problem to view title details in OPAC result In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8225 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |magnus at enger.priv.no Resolution|--- |DUPLICATE --- Comment #1 from Magnus Enger --- The problem with the first records on the second page is already described in bug 7894. The problem with sorting more than 1000 hits can be solved by editing etc/zebradb/zebra-biblios.cfg - see bug 7041. *** This bug has been marked as a duplicate of bug 7894 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:30:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:30:58 +0000 Subject: [Koha-bugs] [Bug 7894] Broken detail page for first link on page 2 from search result page in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7894 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vinod_librarian at rediffmail. | |com --- Comment #10 from Magnus Enger --- *** Bug 8225 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:32:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:32:07 +0000 Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10177|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:32:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:32:58 +0000 Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:33:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:33:52 +0000 Subject: [Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from M. de Rooy --- QA Comment: Larger patch. Generally looks good. Nice feature. Some points still need to be addressed: (Not blocking:) Is there (perhaps) a way to combine CanUserModifyBudget with CanUserUseBudget to eliminate duplicate code? If you could do so in a followup, you are welcome.. (Please clarify:) acqui/acqui-home.pl You change line: my $budget_arr = GetBudgetHierarchy; All parameters are removed in the call. Do you ask for all budgets now and check each budget in the loop? If so, is it economical to do so? Could some of this work already be done in a better phrased sql call? (BTW Seems to be that quite some calls in this loop are repeated for the same borrower/branch, but that goes outside the scope of this report.) [Same point repeated for the other acqui scripts.] (typo level:) admin/aqbudget_user_search.pl comment lines: script to find a guarantor? copy-and-paste.. Since you rename the file, could you please correct that too? (Please clarify/correct:) table aqbudgetborrowers (kohastructure and updatedatabase): Do you also need a UPDATE/DELETE clause on the constraints for budget id and borrower? unit tests: Great to have them! You introduce a new dependency however: Test::MockModule for testing both budget functions. I would rather suggest to get consensus from the dev list for adding dependencies (especially for limited testing only) than just adding them to a unit test. Note that a new dependency must be added to several files (install, packaging, etc.) Is there a simple way to achieve the same result without adding the dependency? (More theoretically: how much does the value of a unit test decrease if you mock function calls?) (Please clarify:) Since there is a "empty" budget test in t and a non-empty one in t/db_dependent, why do you add tests to t instead of t/db ? Please provide some answers on questions raised. Especially the dependency remark still holds me back from marking it ok right now. I will move it to Failed QA for now, but you could also choose for In Discussion while referring it to the list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:33:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:33:54 +0000 Subject: [Koha-bugs] [Bug 8101] DataTables in Acquisision module: orderreceive.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8101 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer --- Hi Jonathan, I am looking at this with Sophie and I have no idea how to get to that page from the acquisition module - can you help us? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:40:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:40:27 +0000 Subject: [Koha-bugs] [Bug 8226] 'OpacFooter' markup/css improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8226 --- Comment #3 from Michael Davis --- Created attachment 10186 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10186&action=edit patch for Bug 8226 - 'OpacFooter' markup/css improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:41:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:41:44 +0000 Subject: [Koha-bugs] [Bug 8226] 'OpacFooter' markup/css improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8226 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10172|0 |1 is obsolete| | Attachment #10186|0 |1 is obsolete| | --- Comment #4 from Michael Davis --- Created attachment 10187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10187&action=edit [SIGNED-OFF] patch for Bug 8226 - 'OpacFooter' markup/css improvements Signed-off-by: Michael Davis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:42:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:42:14 +0000 Subject: [Koha-bugs] [Bug 8226] 'OpacFooter' markup/css improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8226 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |m.r.davis at cranfield.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:42:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:42:28 +0000 Subject: [Koha-bugs] [Bug 8180] cataloguing/additem.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Dobrica Pavlinusic --- This bug depends on barcodes, so your item.barcode must be used in framework and you should have (any) barcode plugin enabled in system preferences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 13:49:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 11:49:46 +0000 Subject: [Koha-bugs] [Bug 8229] New: Tabs in marc subfield structure is not shown correctly Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8229 Priority: P5 - low Change sponsored?: --- Bug ID: 8229 Assignee: oleonard at myacpl.org Summary: Tabs in marc subfield structure is not shown correctly Severity: enhancement Classification: Unclassified OS: All Reporter: juan.sieira at xercode.es Hardware: All Status: NEW Version: rel_3_8 Component: Templates Product: Koha Created attachment 10188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10188&action=edit Capture When trying to edit subfields in Koha administration framework, tabs are not shown correctly. Header is inside of those tab contents. A image is attached to show it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:00:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:00:20 +0000 Subject: [Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10065|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall --- Created attachment 10189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10189&action=edit Bug 8220 - Allow koc uploads to go to process queue instead of being applied directly. The primary advantage to the Firefox offline cirulation plugin when compared to the offline circulation desktop application, is the ability to add offline circulation actions to a queue so that multiple machines running offline circ can have their circ actions combined and ordered chronologically before being executed. This commit adds the ability to put actions from uploaded KOC files into this queue. In this way, both the FF plugina and the desktop application can be run side by side with no ill effects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:03:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:03:34 +0000 Subject: [Koha-bugs] [Bug 8226] 'OpacFooter' markup/css improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8226 --- Comment #5 from Owen Leonard --- What is the reason for the "nofollow?" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:09:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:09:06 +0000 Subject: [Koha-bugs] [Bug 8229] Tabs in marc subfield structure is not shown correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8229 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8143 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:09:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:09:06 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8229 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:19:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:19:37 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9564|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:23:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:23:32 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 --- Comment #8 from Julian Maurice --- Created attachment 10190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10190&action=edit Follow-up: run transferorder.pl in a popup (In reply to comment #7) > Small glitch in ergonomy: The page where you can choose the new bookseller > could better be a pop up like in Patrons->Guarantor information->Set to > patron. > Otherwise users could mistake and use the Vendors search at the top of the > page > (is active by default). If they do so they loose track of the transfer > process. I leave the bug status to "Signed off" so QA team can see it. (Note for QA team: only the first patch is signed off) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:25:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:25:12 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 --- Comment #17 from M. de Rooy --- Created attachment 10191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10191&action=edit Patch for history.txt Very trivial fix of whitespace. Restores correct display in about (tabs for spaces). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:25:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:25:21 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:25:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:25:28 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:25:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:25:34 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:25:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:25:56 +0000 Subject: [Koha-bugs] [Bug 8101] DataTables in Acquisision module: orderreceive.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8101 --- Comment #5 from Jonathan Druart --- Humm, indeed, that is strange. The table is displayed if there are several orders for one ordernumber (??). I don't know how it is possible. Perhaps it is a dead code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:28:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:28:15 +0000 Subject: [Koha-bugs] [Bug 8101] DataTables in Acquisision module: orderreceive.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8101 --- Comment #6 from Katrin Fischer --- Perhaps it is - I think it might not be referenced anywhere with the right parameters to get to that view. Can we check that and perhaps mark the bug INVALID if it's the case? (also removing the code maybe, but not sure if it's something that should be brought back or is not working with new acq) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:32:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:32:49 +0000 Subject: [Koha-bugs] [Bug 8100] DataTables in Acquisision module: neworderbiblio.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8100 --- Comment #5 from Katrin Fischer --- I am not sure what this patch does. I think it changes the result list for when you are searching for an existing record? I can see it adds zebra striping to the table, but there seem to be no options for sorting and the old pagination is still in place. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:36:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:36:03 +0000 Subject: [Koha-bugs] [Bug 8226] 'OpacFooter' markup/css improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8226 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Bots should not follow it, having multiple links from site to the same other site, is often miscontrued as linkspam by search engines. We were hit very hard by this recently with koha-community.org dropping out of search results in google entirely. This is the recommended way to provide a link, without looking like you are trying to game pagerank. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:38:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:38:15 +0000 Subject: [Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9536|0 |1 is obsolete| | Status|Failed QA |Needs Signoff Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com --- Comment #4 from Colin Campbell --- Created attachment 10192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10192&action=edit Proposed Amended Patch Patch rebased against master. Have added sanitizing of order and limit parameters (although order is currently always passed a constant string from the caller) Note on issue 2 adding parens around the variable forces the tt parser to evaluate as an expression. i.e. potentially adding processing where a simple variable is used. While it was used defensively in converting templates I'd suggest following normal tt style in new code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:38:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:38:36 +0000 Subject: [Koha-bugs] [Bug 8099] DataTables in Acquisision module: acqui-home.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8099 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9782|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 10193 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10193&action=edit [SIGNED-OFF] Bug 8099: DataTables integration in acquisition module [2] acqui-home.tt http://bugs.koha-community.org/show_bug.cgi?id=8099 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:38:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:38:56 +0000 Subject: [Koha-bugs] [Bug 8099] DataTables in Acquisision module: acqui-home.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8099 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:40:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:40:17 +0000 Subject: [Koha-bugs] [Bug 7963] Parallel HTTP requests when checking URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9206|0 |1 is obsolete| | --- Comment #5 from Fr?d?ric Demians --- Created attachment 10194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10194&action=edit Proposed patch Thanks Dobrica for your comments that make sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:40:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:40:53 +0000 Subject: [Koha-bugs] [Bug 7963] Parallel HTTP requests when checking URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963 --- Comment #6 from Fr?d?ric Demians --- Created attachment 10195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10195&action=edit Dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:44:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:44:00 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #32 from Jonathan Druart --- Pierre, I have tested with FF >= 3.6 and chromium v.20 and the display is correct. Could you update your browser and retest please ? It seems there is a bug when we hide the th elements. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:47:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:47:14 +0000 Subject: [Koha-bugs] [Bug 8100] DataTables in Acquisision module: neworderbiblio.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8100 --- Comment #6 from Jonathan Druart --- Yes, this patch adds datatable but without sort, filters and pagination. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:49:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:49:04 +0000 Subject: [Koha-bugs] [Bug 7787] SIP server closes the TCP connection when it receives an invalid message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7787 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:49:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:49:19 +0000 Subject: [Koha-bugs] [Bug 7967] Z39.50 client should negotiate encoding with server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7967 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:49:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:49:23 +0000 Subject: [Koha-bugs] [Bug 8098] DataTables in Acquisision module: parcel.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8098 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9969|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 10196 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10196&action=edit [SIGNED-OFF] Bug : DataTables integration in acquisition module [1] parcel.tt http://bugs.koha-community.org/show_bug.cgi?id=8098 Signed-off-by: Katrin Fischer Fixed bug number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:49:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:49:37 +0000 Subject: [Koha-bugs] [Bug 8098] DataTables in Acquisision module: parcel.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8098 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:51:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:51:10 +0000 Subject: [Koha-bugs] [Bug 8100] DataTables in Acquisision module: neworderbiblio.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8100 --- Comment #7 from Katrin Fischer --- Well, in that case it's all ok :) Sign off coming. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:51:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:51:37 +0000 Subject: [Koha-bugs] [Bug 8230] New: Show the ordered status in catalogue page Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 Priority: P5 - low Change sponsored?: --- Bug ID: 8230 Assignee: koha-bugs at lists.koha-community.org Summary: Show the ordered status in catalogue page Severity: enhancement Classification: Unclassified OS: All Reporter: matthias.meusburger at biblibre.com Hardware: All Status: NEW Version: rel_3_8 Component: Acquisitions Product: Koha This patch will be helpful for showing the ordered status in the catalog page. The status can be seen in the catalog search result also.For the proper working of this patch two more fields to be mapped to the same marc field where the other aqorder fields are mapped. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:52:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:52:29 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 --- Comment #1 from Matthias Meusburger --- Created attachment 10197 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10197&action=edit Proposed patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:52:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:52:44 +0000 Subject: [Koha-bugs] [Bug 8100] DataTables in Acquisision module: neworderbiblio.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9781|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 10198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10198&action=edit [SIGNED-OFF] Bug 8100: DataTables integration in acquisition module [8] neworderbiblio.tt http://bugs.koha-community.org/show_bug.cgi?id=8100 Signed-off-by: Katrin Fischer Fixed bug number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:52:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:52:58 +0000 Subject: [Koha-bugs] [Bug 8100] DataTables in Acquisision module: neworderbiblio.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8100 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:53:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:53:31 +0000 Subject: [Koha-bugs] [Bug 8230] Show the ordered status in catalogue page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7294 Assignee|koha-bugs at lists.koha-commun |shinoy.m at osslabs.biz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:53:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:53:31 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8230 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:54:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:54:56 +0000 Subject: [Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:55:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:55:49 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #23 from Matthias Meusburger --- Hi shinoy m, I created a new bug that I assigned to you for your additional patch : http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8230 Having two separate smaller patches will make the sign-off and QA process much easier. Hope it's ok for you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:56:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:56:43 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9980|0 |1 is obsolete| | --- Comment #24 from Matthias Meusburger --- Comment on attachment 9980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9980 Additional patch to show the ordered status in catalogue page Obsoleted this patch, as it is now in 8230. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:59:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:59:51 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #62 from M. de Rooy --- Some question to revive the topic (for me) before starting QA (..), also due to the fact that these patches deviated from the initial starting point as described. Commit message talks about koha-conf.xml changes? Is that obsolete? What is the exact use of the yaml file now? Only listing the versions directory? Or also for a new db revision number? If I recall correctly, you could switch modes via $ENV{DEBUG} in koha-httpd, but it only seems now to hide the Execute button in normal mode. Am I correct? Wasn't it meant to enable/disable linear vs non-linear updates? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 14:59:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 12:59:52 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:00:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:00:06 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha.sekjal at gmail.com |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:04:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:04:03 +0000 Subject: [Koha-bugs] [Bug 4211] Acquisitions actions on suggestions don't generate email In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4211 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |FIXED --- Comment #13 from Katrin Fischer --- I just checked. On current master mails for ordering, accepting and rejecting suggestions are generated nicely and are sent to the patron. Closing this RESOLVED FIXED. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:04:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:04:04 +0000 Subject: [Koha-bugs] [Bug 1886] Managing Suggestions - keep patron updated on process In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1886 Bug 1886 depends on bug 4211, which changed state. Bug 4211 Summary: Acquisitions actions on suggestions don't generate email http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4211 What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:07:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:07:19 +0000 Subject: [Koha-bugs] [Bug 4327] Booksellers sort and typo In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4327 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |FIXED --- Comment #2 from Katrin Fischer --- The new vendor search result list sorts nicely by vendor name. Also the button description "New vendor" is consistent with similar buttons in other places of Koha. Closing this bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:09:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:09:24 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10040|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize --- Created attachment 10199 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10199&action=edit Bug 7751 : Decrease Loans for Items with Highholds Rebased yet again for master.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:13:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:13:45 +0000 Subject: [Koha-bugs] [Bug 8183] acqui/parcels.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:14:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:14:16 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #63 from M. de Rooy --- Argument "test01" isn't numeric in numeric comparison (<=>) at /usr/share/koha/testclone/admin/updatedatabase.pl line 88 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:15:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:15:54 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8229 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:15:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:15:54 +0000 Subject: [Koha-bugs] [Bug 8229] Tabs in marc subfield structure is not shown correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8229 Matthias Meusburger changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7294 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:16:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:16:15 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #25 from Matthias Meusburger --- Blocked by 8229 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:17:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:17:55 +0000 Subject: [Koha-bugs] [Bug 7494] Use partial barcode or callnumber as a fallback for the barcode search in checkout In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7494 Marijana Glavica changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |mglavica at ffzg.hr --- Comment #4 from Marijana Glavica --- It works in the simplest case when you have just one item attached to your biblio. It offers you always just first item. If that first item is already on loan, it will not offer you next one available. Also, if you have more than one item, and first one is marked as "not for loan", it will tell you that item is not for loan (because it looks just at the fist item). It offers you just first biblio if more than one result exist, but that is fine, you can search more precisely. So, you can use this feature only if you always have just one item attached to every biblio. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:18:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:18:32 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 --- Comment #15 from Dobrica Pavlinusic --- Please ignore last patch which was git bz gone wrong and just concentrate on Chirs' patches -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:19:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:19:17 +0000 Subject: [Koha-bugs] [Bug 5600] Bulk MARC biblio export script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9955|0 |1 is obsolete| | --- Comment #7 from Julian Maurice --- Created attachment 10200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10200&action=edit Bug 5600: Command line interface for tools/export.pl Fixed bug when IndependantBranches is ON. It was caused by calling C4::Context->userenv before get_template_and_user (userenv is undef in this case). Rebased on master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:19:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:19:28 +0000 Subject: [Koha-bugs] [Bug 5600] Bulk MARC biblio export script In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5600 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:24:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:24:52 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing addess improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #16 from Jonathan Druart --- Created attachment 10201 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10201&action=edit Bug 5356: Followup sort and branchname - Sort is now the same as C4::Branch::GetBranchesLoop - branchcodes are replaced with branchnames 1) Done. 2) I don't understand what you want exactly. 3, 4) Done 5) If I edit a basket and set it a delivery and billing place. I add this basket to a basketgroup, close it and export it as csv, I have the 4 informations filled in the generated csv file. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:25:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:25:08 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing addess improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:25:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:25:17 +0000 Subject: [Koha-bugs] [Bug 8229] Tabs in marc subfield structure is not shown correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8229 --- Comment #1 from Matthias Meusburger --- Created attachment 10202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10202&action=edit Bug 8229: Tabs in marc subfield structure is not shown correctly - Fixed URLs in marc_subfields_structure.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:26:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:26:19 +0000 Subject: [Koha-bugs] [Bug 1091] in the opac search, a second pass with shorter terms if there are no results? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1091 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Attached patch is 'ancient' predates git and Zebra. I am marking it as obsolete, because a complete new implementation would be needed to add this feature to current Koha. Changing bug status back to new. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:26:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:26:28 +0000 Subject: [Koha-bugs] [Bug 1091] in the opac search, a second pass with shorter terms if there are no results? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1091 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:27:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:27:13 +0000 Subject: [Koha-bugs] [Bug 1091] in the opac search, a second pass with shorter terms if there are no results? In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1091 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67 is|0 |1 obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:27:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:27:43 +0000 Subject: [Koha-bugs] [Bug 8229] Tabs in marc subfield structure is not shown correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8229 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10202|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 10203 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10203&action=edit [SIGNED-OFF] Bug 8229: Tabs in marc subfield structure is not shown correctly - Fixed URLs in marc_subfields_structure.tt Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:28:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:28:25 +0000 Subject: [Koha-bugs] [Bug 8229] Tabs in marc subfield structure is not shown correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8229 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:28:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:28:31 +0000 Subject: [Koha-bugs] [Bug 8229] Tabs in marc subfield structure is not shown correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8229 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:28:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:28:40 +0000 Subject: [Koha-bugs] [Bug 8229] Tabs in marc subfield structure is not shown correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8229 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:29:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:29:30 +0000 Subject: [Koha-bugs] [Bug 7887] Add Option To Include Items That Will Be Available When Calculating Holds Ratios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |alex.arnaud at biblibre.com --- Comment #2 from Alex Arnaud --- This patch doesn't apply using 3-way merge. "CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/help/circ/reserveratios.tt Failed to merge in the changes." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:30:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:30:51 +0000 Subject: [Koha-bugs] [Bug 8231] New: Warning on Check in if borrower is restricted Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Priority: P5 - low Change sponsored?: --- Bug ID: 8231 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha at univ-lyon3.fr Summary: Warning on Check in if borrower is restricted Severity: enhancement Classification: Unclassified OS: All Reporter: adrien.saurat at biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Circulation Product: Koha Enhancement: when checking in for a restricted patron, display of a warning telling about this status. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:32:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:32:16 +0000 Subject: [Koha-bugs] [Bug 7963] Parallel HTTP requests when checking URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963 --- Comment #7 from Dobrica Pavlinusic --- You still love --host-pro flag I guess :-) I needed to read source code twice to figure out which URL this is so I really think that flag name needs change. I had a quick chat with Chris about dependencies on AnyEvent::HTTP which isn't part of Debian stable and came out with solution to mark both AnyEvent and AnyEvent::HTTP as optional dependency (using required => 0) so that we don't bring in additional modules but still offer then as suggested in Debian package. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:41:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:41:58 +0000 Subject: [Koha-bugs] [Bug 7286] Introduce rebuild_zebra_sliced.zsh to recursively rebuild zebra & be error proof In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7286 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org --- Comment #15 from Dobrica Pavlinusic --- Does this script really need zsh? While I don't have anything against zsh as interactive shell, I think it's bad practice to introduce additional dependency to zsh for every Koha installation which want to use this script. I for one don't use zsh and don't have it installed on servers. Than again, this might be my Debian bias -- system scripts should use /bin/sh and not /bin/bash /bin/zfs, /bin/t?csh.... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:46:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:46:56 +0000 Subject: [Koha-bugs] [Bug 7963] Parallel HTTP requests when checking URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963 --- Comment #8 from Fr?d?ric Demians --- > You still love --host-pro flag I guess :-) Too bad! I've changed the help text, and forgot to change the code. I will do that this evening, quietly. > I had a quick chat with Chris about dependencies on AnyEvent::HTTP which > isn't part of Debian stable and came out with solution to mark both AnyEvent > and AnyEvent::HTTP as optional dependency (using required => 0) so that we > don't bring in additional modules but still offer then as suggested in > Debian package. Will change dependency patch accordingly. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:47:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:47:27 +0000 Subject: [Koha-bugs] [Bug 7751] Decrease loan period on items with a high number of holds In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10199|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize --- Created attachment 10204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10204&action=edit Bug 7751 : Decrease Loans for Items with Highholds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:48:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:48:12 +0000 Subject: [Koha-bugs] [Bug 4460] Amazon's AssociateID tag not used in links so referred revenue lost In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4460 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |koha.sekjal at gmail.com --- Comment #6 from Ian Walls --- Typos and scoping issues: Scoping: global variable is locally scoped: XISBN.AmazonAssocTag Typo: READING>RECOR instead of READING_RECOR Easy fixes, but Failed QA until such is done. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:48:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:48:26 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10044|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall --- Created attachment 10205 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10205&action=edit [SIGNED-OFF] Bug 7994: scripts to check yaml files $ prove yaml_valid.t checks a closed list of files $ perl yaml_valid.pl -f myfile.yaml try to load a yaml file with YAML::LoadFile and show errors (both files pertidied) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:49:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:49:11 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 --- Comment #1 from Adrien SAURAT --- Created attachment 10206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10206&action=edit proposed patch #1 Rebased a patch from Lyon3 working on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:49:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:49:29 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 --- Comment #13 from Kyle M Hall --- Yaml checker works. Second patch does not apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:50:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:50:15 +0000 Subject: [Koha-bugs] [Bug 8231] Warning on Check in if borrower is restricted In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8231 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:50:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:50:57 +0000 Subject: [Koha-bugs] [Bug 8183] acqui/parcels.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183 --- Comment #3 from Dobrica Pavlinusic --- This bug seems to be specific to bookseller=2 on our system and doesn't appear for others, so I will have to investigate a bit more why is that so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:51:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:51:33 +0000 Subject: [Koha-bugs] [Bug 7887] Add Option To Include Items That Will Be Available When Calculating Holds Ratios In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7887 --- Comment #3 from Alex Arnaud --- Kyle, i just realize that this conflict is not relevant. It should apply without errors. Have you this problem when applying the patch ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:52:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:52:13 +0000 Subject: [Koha-bugs] [Bug 8216] Enable critic tests on SIP modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8216 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #3 from Ian Walls --- PBP patch; almost all changes to code are completely functionally equivalent to their old forms, but now conform to guidelines. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:53:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:53:53 +0000 Subject: [Koha-bugs] [Bug 8222] The zip code field is mandatory by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8222 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #4 from Ian Walls --- Thank you, this has been an annoyance on my test machines many a time. Simple patch, changes default entry for syspref value only. Upgraded installs unaffected. Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:54:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:54:10 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 --- Comment #14 from claire.hernandez at biblibre.com --- Created attachment 10207 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10207&action=edit Bug 7994: scripts to check yaml files $ prove yaml_valid.t checks a closed list of files $ perl yaml_valid.pl -f myfile.yaml try to load a yaml file with YAML::LoadFile and show errors (both files pertidied) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:56:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:56:42 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10045|0 |1 is obsolete| | --- Comment #15 from claire.hernandez at biblibre.com --- Created attachment 10208 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10208&action=edit Bug 7994: Fix pref yaml errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:58:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:58:16 +0000 Subject: [Koha-bugs] [Bug 8223] Properly format SQL query in C4::Bookseller::GetBookSeller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8223 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10153|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize --- Created attachment 10209 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10209&action=edit Bug 8223 - Properly format SQL query in C4::Bookseller::GetBookSeller: Simple code formatting improvement.. as expected from code, breaks nothing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 15:58:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 13:58:30 +0000 Subject: [Koha-bugs] [Bug 8223] Properly format SQL query in C4::Bookseller::GetBookSeller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8223 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:01:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:01:05 +0000 Subject: [Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 --- Comment #18 from Michael Davis --- Created attachment 10210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10210&action=edit [SIGNED-OFF] Bug 7401 - Shelving Location facet instead of Branch facet when only 1 branch configured Signed-off-by: Kyle M Hall Enable for either A) SingleBranchMode is enabled or B) There is only one branch in the branches table Signed-off-by: Nicole C. Engard Tested with one branch and with multiple branches, tested with SingleBranchMode on and off. All tests passed. Signed-off-by: Michael Davis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:01:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:01:36 +0000 Subject: [Koha-bugs] [Bug 7401] Shelving Location facet instead of Branch facet when only 1 branch configured In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7401 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |m.r.davis at cranfield.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:04:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:04:10 +0000 Subject: [Koha-bugs] [Bug 8004] Items on Hold Lose Transfer After Being Scanned Twice In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|rel_3_6 |rel_3_10 --- Comment #6 from Paul Poulain --- Patch pushed. thinking of it Kyle, I think naming it KohaBranchName.pm could be improved to Branchname.pm, because it's all about Koha, so... if you want to change the name in the follow-ups you'll do... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:05:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:05:08 +0000 Subject: [Koha-bugs] [Bug 7129] actual cost showing too many zeros In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Mirko <5p4m at gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |5p4m at gmx.de --- Comment #8 from Mirko <5p4m at gmx.de> --- Tried to test this patch in a sandbox but could not put any items to the basket because a mandatory field was set to readonly and could not be edited. Should have nothing to do with this patch but can't signoff because can't test it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:05:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:05:52 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9976|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart --- Created attachment 10211 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10211&action=edit Bug 5342: Adds a claims_count field in the serial table 1) Done 2) It appears it is not easy for this page. There are filters, etc. and I don't want to break something. But it's a good idea :) 3) It seems a general problem for all letters. Perhaps a new bug report is needed for this problem. 4) Arf, I forgot. I try to do that in a followup. Currently I have no time :-/ 5) Hum, It is a problem for Bug 5347 too. Bug I don't find where I can do this without introducing side effect with Bug 7001. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:07:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:07:47 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9977|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart --- Created attachment 10212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10212&action=edit Bug 5342: Followup: Delete all occurrences of preview rebased patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:07:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:07:52 +0000 Subject: [Koha-bugs] [Bug 7129] actual cost showing too many zeros In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 --- Comment #9 from Katrin Fischer --- Hi Mirko, try clicking the "Add link" at the end of the item form. Quantity will go up if you do that. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:08:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:08:02 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:11:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:11:03 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10207|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:13:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:13:19 +0000 Subject: [Koha-bugs] [Bug 8183] acqui/parcels.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #4 from Dobrica Pavlinusic --- I got this one nailed down: you need to have more than 20 items pending for acquisition (or whatever number you pass in in ?resultsperpage=xx param) so that sub set_page_navigation gets called because error appears in it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:13:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:13:23 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #16 from claire.hernandez at biblibre.com --- rebased / fixed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:14:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:14:36 +0000 Subject: [Koha-bugs] [Bug 8232] New: Comments in OPAC contain untranslatable javascript messages Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8232 Priority: P5 - low Change sponsored?: --- Bug ID: 8232 Assignee: katrin.fischer at bsz-bw.de Summary: Comments in OPAC contain untranslatable javascript messages Severity: enhancement Classification: Unclassified OS: All Reporter: katrin.fischer at bsz-bw.de Hardware: All Status: ASSIGNED Version: master Component: OPAC Product: Koha To test: - add a new comment to a record in the OPAC - Your comment (preview, pending approval) is not translatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:15:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:15:13 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10164|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize --- Created attachment 10213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10213&action=edit [SIGNED] Bugfix 4118 - Add Collection Code to Statistics Table - Updated C4 Modules to add Collection Codes to stats table -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:15:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:15:50 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10165|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 10214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10214&action=edit [SIGNED] Bugfix 4118 - Add Collection Code to Statistics Table - DB Update -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:15:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:15:56 +0000 Subject: [Koha-bugs] [Bug 7129] actual cost showing too many zeros In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Mirko <5p4m at gmx.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Mirko <5p4m at gmx.de> --- My bad, it works now and fixes the problem, thanks Katrin. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:16:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:16:15 +0000 Subject: [Koha-bugs] [Bug 8232] Comments in OPAC contain untranslatable javascript messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8232 --- Comment #1 from Katrin Fischer --- Created attachment 10215 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10215&action=edit Bug 8232: Comments in OPAC contain untranslatable javascript messages To test: - add a new comment to a record in the OPAC - Your comment (preview, pending approval) is not translatable - update po files by running 'perl translate update ' - Open po file and check if strings are there, translate - install language again by running 'perl translate install ' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:16:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:16:25 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Add data as expected... Signing off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:16:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:16:32 +0000 Subject: [Koha-bugs] [Bug 8232] Comments in OPAC contain untranslatable javascript messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8232 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:18:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:18:20 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #64 from Paul Poulain --- (In reply to comment #62) > Commit message talks about koha-conf.xml changes? Is that obsolete? If you're talking of: add a section /path/to/your/install/dir in your koha-conf.xml I'll ask jonathan to reupload a patch with the commit message fixed & other QA comments if there are. > What is the exact use of the yaml file now? Only listing the versions > directory? Yes > Or also for a new db revision number? Nope. They are stored in new tables (updatedb_error, updatedb_query, updatedb_report) > If I recall correctly, you could switch modes via $ENV{DEBUG} in koha-httpd, > but it only seems now to hide the Execute button in normal mode. Am I > correct? > Wasn't it meant to enable/disable linear vs non-linear updates? ??? I don't understand what you mean here. (In reply to comment #63) > Argument "test01" isn't numeric in numeric comparison (<=>) at > /usr/share/koha/testclone/admin/updatedatabase.pl line 88 Can you explain what you made ? I suspect you have added a test SQL in installer/data/mysql/versions/ and called it test01.sql. It's wrong, it must be a number 3.09.00.014 for example (could also be 123.456, but it must be numbers+. only) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:21:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:21:28 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 --- Comment #30 from Katrin Fischer --- I think we need to fix 5) then :( Because sending the email is the main part of this functionality and you can't claim without sending a notice (perhaps you should be able to do so, but that's outside of the scope of this bug) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:26:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:26:01 +0000 Subject: [Koha-bugs] [Bug 5360] From Zebra to solR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5360 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:27:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:27:01 +0000 Subject: [Koha-bugs] [Bug 5250] Various enhancements to web based checkouts In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5250 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- Patches are still for H:T:P - perhaps someone can reformat? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:28:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:28:10 +0000 Subject: [Koha-bugs] [Bug 8233] New: New search engine layer - introduce solr without breaking anything else Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Priority: P5 - low Change sponsored?: --- Bug ID: 8233 Assignee: gmcharlt at gmail.com Summary: New search engine layer - introduce solr without breaking anything else Severity: enhancement Classification: Unclassified OS: All Reporter: claire.hernandez at biblibre.com Hardware: All Status: NEW Version: unspecified Component: Searching Product: Koha Introduce the Koha::SearchEngine work (hackfest12 kohacon12) and a first poc with Solr. The goal is to break nothing and provide a first work wich will be enhance. Please use the wiki or koha-devel for discussion: http://wiki.koha-community.org/wiki/SearchEngine_Layer_RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:28:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:28:30 +0000 Subject: [Koha-bugs] [Bug 7129] actual cost showing too many zeros In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10030|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 10216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10216&action=edit [SIGNED-OFF] Bug 7129: Added a sprintf to format the actual cost. Signed-off-by: Katrin Fischer Rebased to current master, please test. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:34:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:34:20 +0000 Subject: [Koha-bugs] [Bug 8092] Koha should use CHI caching framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8092 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:36:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:36:27 +0000 Subject: [Koha-bugs] [Bug 6018] Batch modifitcation of items Enchancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6018 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer --- I think the second patch is still needed. I tried batch editing an item from the fast add framework and for example $i does not show up in the list of item fields. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:36:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:36:34 +0000 Subject: [Koha-bugs] [Bug 6018] Batch modifitcation of items Enchancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6018 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:36:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:36:52 +0000 Subject: [Koha-bugs] [Bug 6018] Batch modifitcation of items Enchancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6018 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3561|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:38:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:38:13 +0000 Subject: [Koha-bugs] [Bug 6018] Batch modifitcation of items Enchancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6018 --- Comment #10 from Katrin Fischer --- Second patch does not apply and can't fix the conflict. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:40:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:40:56 +0000 Subject: [Koha-bugs] [Bug 6634] manager_id not populated when paying fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Irma Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |irma at calyx.net.au --- Comment #24 from Irma Birchall --- I have tested the payment of fines and Paul has verified in koha.accountlines.manager_id that each of the operations recorded the borrowernumber and the manager_id details. This patch can be signed off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:42:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:42:12 +0000 Subject: [Koha-bugs] [Bug 7411] remove diacritics when automatically generating userid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com Version|rel_3_6 |rel_3_10 QA Contact|koha.sekjal at gmail.com |paul.poulain at biblibre.com --- Comment #9 from Paul Poulain --- QA comment: Tiny patch that adds a dependency, but this dep could be used in other places. also adds packages dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:43:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:43:27 +0000 Subject: [Koha-bugs] [Bug 7411] remove diacritics when automatically generating userid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Paul Poulain --- This patch introduces a new dependency to fix a bug that happens rarely, I think it should be for 3.10 only, but chris, you decide -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:44:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:44:11 +0000 Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10058|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall --- Created attachment 10217 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10217&action=edit [SIGNED-OFF] Bug 6828[ENH] - Add basic Dashboard for staff users. This enhancement adds the option of switching on/off a Dashboard on the Staff users mainpage. The information displayed is specific to the users logged in branch but will also show a system wide overview. Its visibility is controlled by a new SysPref. This first revision takes its data from an XML file which needs to be populated on a cronjob. The file to run is in misc/migration_tools/dashboard_xml.pl. The usual Koha env will need to be set for the user running the script. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:44:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:44:29 +0000 Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10059|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall --- Created attachment 10218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10218&action=edit [SIGNED-OFF] Bug 6828 follow-up: adapt dashboard to new staff client theme This follow-up makes a few cosmetic changes: * Moves the dashboard to underneath the "pending" panel * Switches the layout to CSS-based instead of table-based * Makes the error message translatable * Reindents some sections of the added code to make things more readable Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:44:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:44:52 +0000 Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:47:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:47:35 +0000 Subject: [Koha-bugs] [Bug 8006] Loading offline circulation does not anonymize In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8006 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bob at calyx.net.au --- Comment #2 from Bob Birchall --- Sys prefs were set as follows: opac/annonymous patron = (borrower number) opac/opacprivacy = Allow opac/opacreadinghistory = Allow patrons/intranetreadinghistory = Allow In the OPAC, at the MyPrivacy tab, the parameter was set to 'Never' On upload and processing of the file, the name of the book and the name of the patron were displayed. However this is the same as in normal circulation. This may require further consideration? On checking the Circulation History tab of the patron's record in the staff client, the system displays 'This patron has no circulation history.' This is what I understand to have been the objective of the patch. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:51:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:51:19 +0000 Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8713|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer --- Created attachment 10219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10219&action=edit OPACNoResult, Add keyword to query string This patch add the keywords to the string entered by the user to OPACNoResultFound Signed-off-by: Katrin Fischer Rebased 2012-06-11 Note: Patch does not work for search terms containing umlauts like ???. Those characters are lost from the displayed search term. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:51:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:51:34 +0000 Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:52:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:52:16 +0000 Subject: [Koha-bugs] [Bug 6175] Mismatch between marc_subfield_structure and authorised_values tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6175 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain at biblibre.com --- Comment #5 from Paul Poulain --- QA comment: This patch has some problems: * it introduces a constraint that is wrong: + CONSTRAINT `auth_subfield_structure_ibfk_1` FOREIGN KEY (`authorised_value`) REFERENCES `authorised_values` (`category`) ON DELETE CASCADE ON UPDATE CASCADE => the constraint can be on authorised_values, but also on branches or itemtype, so a SQL constraint is unapplicable here * it contains a lot of changes in french file that are just moving things from the bottom to the top of file without reason (at least without relation to this patch. As the patch has been made by someone from argentina, I think it was not intended to update french files !) * there is no updatedatabase part on this patch making existing Koha being de-synchronised from freshly installed Koha for those reasons, failed QA, sorry -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:55:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:55:46 +0000 Subject: [Koha-bugs] [Bug 8234] New: Dates are not well sorted on Transfers to receive Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 Priority: P5 - low Change sponsored?: --- Bug ID: 8234 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Dates are not well sorted on Transfers to receive Severity: enhancement Classification: Unclassified OS: All Reporter: sophie.meynieux at biblibre.com Hardware: All Status: NEW Version: unspecified Component: Circulation Product: Koha In "Transfers to receive" table, date are not well sorted. DataTable should be used as in other tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:55:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:55:57 +0000 Subject: [Koha-bugs] [Bug 7844] plack scripts for developers In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7844 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10082|0 |1 is obsolete| | --- Comment #15 from Dobrica Pavlinusic --- Created attachment 10220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10220&action=edit Bug 7844 - plack intranet tooling for developers koha.psgi example and plackup.sh script to run any Koha site intranet or opac interface under plack with optional multi-process Starman server plackup.sh site-name [intranet] site-name is used to find config /etc/koha/sites/site-name/koha-conf.xml All configuration is specified in koha.psgi, which you are welcomed to edit and tune according to your development needs (enable memcache, enable/disable debugging modules for plack and so on). For deployment of opac or intranet you would probably want to take a look in plackup.sh and enable starman as web server (which is pre-forking server written in perl) and put some web server in front of it to serve static web files (e.g. ngnix, apache) When you are happy with it, rename koha.psgi and plackup.sh it to site name and save it for safe-keeping. This version does not have mapping to / of opac or intranet, so you need to use full URLs to pages as specified in test scenario. This will be fixed when we are ready to deploy plack, but for now it's clear indication that this is intended for developers which know what to do anyway. This commit message is included in patch as README.plack because it includes useful information for people using plack for first time. Test scenario: 1. install plack and dependencies, as documented at http://wiki.koha-community.org/wiki/Plack 2. start ./plackup.sh sitename i[ntranet] 3. open intranet page http://localhost:5001/cgi-bin/koha/mainpage.pl and verify that it works 4. start ./plackup.sh sitename 5. open OPAC http://localhost:5000/cgi-bin/koha/opac-main.pl and verify that it works 6. next step is to take a look into koha.psgi and enable additional debug modules, save file and reload page (plackup will reload code automatically) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:56:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:56:49 +0000 Subject: [Koha-bugs] [Bug 8092] Koha should use CHI caching framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8092 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #11 from Paul Poulain --- QA comment: The follow-up intend to remove any error if CHI is not installed (as it's optional). Nothing specific to say, probably the most logical way to do it ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:56:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:56:58 +0000 Subject: [Koha-bugs] [Bug 8092] Koha should use CHI caching framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8092 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:57:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:57:44 +0000 Subject: [Koha-bugs] [Bug 5345] DataTables in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sophie.meynieux at biblibre.co | |m Depends on| |8234 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 16:57:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 14:57:44 +0000 Subject: [Koha-bugs] [Bug 8234] Dates are not well sorted on Transfers to receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5345 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:00:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:00:25 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |m.r.davis at cranfield.ac.uk --- Comment #3 from Michael Davis --- Applying: Course Reserves /home/koha/sites/koha_hackfest/.git/rebase-apply/patch:200: trailing whitespace. /home/koha/sites/koha_hackfest/.git/rebase-apply/patch:1005: trailing whitespace. /home/koha/sites/koha_hackfest/.git/rebase-apply/patch:1024: trailing whitespace. /home/koha/sites/koha_hackfest/.git/rebase-apply/patch:1188: trailing whitespace. /home/koha/sites/koha_hackfest/.git/rebase-apply/patch:1193: trailing whitespace. error: patch failed: installer/data/mysql/updatedatabase.pl:5343 error: installer/data/mysql/updatedatabase.pl: patch does not apply Patch failed at 0001 Course Reserves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:01:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:01:11 +0000 Subject: [Koha-bugs] [Bug 8162] packaging scripts create user incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8162 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz --- Comment #3 from Robin Sheat --- Do you know why? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:01:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:01:20 +0000 Subject: [Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 --- Comment #12 from Julian Maurice --- (In reply to comment #11) > QA Comment: > Larger patch. Generally looks good. Nice feature. Some points still need to > be addressed: > > (Not blocking:) Is there (perhaps) a way to combine CanUserModifyBudget with > CanUserUseBudget to eliminate duplicate code? If you could do so in a > followup, you are welcome.. As CanUserModifyBudget already uses CanUserUseBudget. I don't know which piece of code you're talking about. Are you talking about this? if (not ref $borrower) { $borrower = C4::Members::GetMember(borrowernumber => $borrower); } ... It's duplicated in both subs, but I don't know where to place it otherwise. I'm open to any suggestions :) > > (Please clarify:) acqui/acqui-home.pl > You change line: my $budget_arr = GetBudgetHierarchy; > All parameters are removed in the call. Do you ask for all budgets now and > check each budget in the loop? If so, is it economical to do so? Could some > of this work already be done in a better phrased sql call? (BTW Seems to be > that quite some calls in this loop are repeated for the same > borrower/branch, but that goes outside the scope of this report.) > [Same point repeated for the other acqui scripts.] Hmm, I don't know. But since tests to do depend on budget_permission, it will require a sql query like this: SELECT ... FROM aqbudgets WHERE (budget_permission = 0) OR (budget_permission = 1 AND budget_owner_id...) OR (budget_permission = 2 ...) -- require a join with aqbudgetborrowers for 2 and 3 OR ... Is it possible to do a "conditionnal join" ? Is this sample query the good way to do this? > > (typo level:) admin/aqbudget_user_search.pl > comment lines: script to find a guarantor? copy-and-paste.. Since you rename > the file, could you please correct that too? > Ok, will fix that. > (Please clarify/correct:) table aqbudgetborrowers (kohastructure and > updatedatabase): > Do you also need a UPDATE/DELETE clause on the constraints for budget id and > borrower? > Will fix that too. > unit tests: > Great to have them! > You introduce a new dependency however: Test::MockModule for testing both > budget functions. > I would rather suggest to get consensus from the dev list for adding > dependencies (especially for limited testing only) than just adding them to > a unit test. Note that a new dependency must be added to several files > (install, packaging, etc.) > Is there a simple way to achieve the same result without adding the > dependency? (More theoretically: how much does the value of a unit test > decrease if you mock function calls?) > (Please clarify:) Since there is a "empty" budget test in t and a non-empty > one in t/db_dependent, why do you add tests to t instead of t/db ? I use Test::MockModule to not be "database-dependent". And that's why unit tests are not in t/db_dependent. About dependencies files, should a module only used for unit tests be listed in Koha dependencies? It is not required at all to run Koha and it's only useful to developers. Is there something like a 'dependency level' (required/recommended/...) in those files ? > > Please provide some answers on questions raised. > Especially the dependency remark still holds me back from marking it ok > right now. I will move it to Failed QA for now, but you could also choose > for In Discussion while referring it to the list. Thanks for the review. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:01:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:01:24 +0000 Subject: [Koha-bugs] [Bug 8162] packaging scripts create user incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8162 --- Comment #4 from Robin Sheat --- (and under what circumstances?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:01:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:01:42 +0000 Subject: [Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10189|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall --- Created attachment 10221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10221&action=edit Bug 8220 - Allow koc uploads to go to process queue instead of being applied directly. The primary advantage to the Firefox offline cirulation plugin when compared to the offline circulation desktop application, is the ability to add offline circulation actions to a queue so that multiple machines running offline circ can have their circ actions combined and ordered chronologically before being executed. This commit adds the ability to put actions from uploaded KOC files into this queue. In this way, both the FF plugina and the desktop application can be run side by side with no ill effects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:03:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:03:24 +0000 Subject: [Koha-bugs] [Bug 8235] New: Packaging scripts get upset with non-Debian perl modules Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8235 Priority: P5 - low Change sponsored?: --- Bug ID: 8235 CC: robin at catalyst.net.nz Assignee: koha-bugs at lists.koha-community.org Summary: Packaging scripts get upset with non-Debian perl modules Severity: minor Classification: Unclassified OS: All Reporter: robin at catalyst.net.nz Hardware: All Status: NEW Version: unspecified Component: Packaging Product: Koha debian/update-control complains about any package that's not in the debian repo. However, some packages are in the Koha one, and it doesn't understand this. This patch makes it able to handle the extra modules that it knows about. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:03:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:03:33 +0000 Subject: [Koha-bugs] [Bug 8235] Packaging scripts get upset with non-Debian perl modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8235 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:05:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:05:10 +0000 Subject: [Koha-bugs] [Bug 8235] Packaging scripts get upset with non-Debian perl modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8235 --- Comment #1 from Robin Sheat --- Created attachment 10222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10222&action=edit Bug 8235 - allow a whitelist of modules that aren't in Debian This allows modules that aren't in the main debian repos to be handled by the list-deps script when building a control file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:06:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:06:16 +0000 Subject: [Koha-bugs] [Bug 8235] Packaging scripts get upset with non-Debian perl modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8235 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:06:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:06:19 +0000 Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9776|0 |1 is obsolete| | Attachment #10015|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart --- Created attachment 10223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10223&action=edit Bug 7955: Statistics tab for Patron checkouts (In reply to comment #9) > QA Comment: > Patch appears to have external signoff. But the commit does not show it. > Please correct. Done > Statistics.pm: $VERSION = 3.02; Do we need it? Why 3.02? Seems just to be > copied.. Removed > construct_query: This routine is not very clear. Note also that you do not > check the contents of the pref: column whatever can be put into the pref and > will just be copied over. So it is somehwat error sensitive (not even > talking about security issues). > This point is not a definitive blocker for me, but if you can improve this > code, you are welcome ;) I add a $dbh->quote > GetPrecedentStateByBorrower: Please confirm if the second where clause is > correct. You say returndate=now while I was expecting returndate circ-menu.inc, circ-menu.tt, etc.: You are testing for statisticsview. OK. > But it is always 1. No, statisticsview = 1 when we are on the statistics.pl page, else it is false. (circ-menu.* are include files) > patrons.pref: Please explain how to fill in this field (with | char). > Perhaps mention again the default values. Done > statistics.pl > general remark: In your code I saw some case like this one: > my $precedent_state = GetPrecedentStateByBorrower $borrowernumber; > Since the function is declared before, this is allowed. But calling > subroutines without parentheses could cause problems, especially with > multiple pars. I would prefer to always add the parentheses. It also makes > it more visible as a function call. Humm, it is not my opinion, but it is done :) > merge function: Not sure what you are doing there exactly and why in that > way. Can this be done easier and more transparently? > This line in particular calls for clarification: > if ( not $ch->{$cn} ~~ $h->{$cn} ) { > Note that tilde tilde operator is a way to force scalar context. It makes > code obscure; better avoid it. > Please clarify. If you want, I can replace tilde operator with the eq operator. In this case, that changes nothing. > build_array function: Might need some more comments too. Makes maintenance > easier. (The current oneliner does not really explain it to me..) I add few comments for merge and build_array functions > Warning in the logfile: [Sat Jun 09 10:34:39 2012] [error] [client > 129.215.5.255] [Sat Jun 9 12:34:39 2012] statistics.pl: Use of > uninitialized value in addition (+) at > /usr/share/koha/testclone/members/statistics.pl line 74. Please check > undefined values. Done > In conclusion: There are a few comments and questions needing attention > before passing qa now rightaway. Please clarify or correct to "save this > kitten" (hackfest term). Thanks for your review ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:06:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:06:31 +0000 Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:06:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:06:51 +0000 Subject: [Koha-bugs] [Bug 8235] Packaging scripts get upset with non-Debian perl modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8235 --- Comment #2 from Robin Sheat --- Note: this should go happily into stable versions as well as master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:10:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:10:54 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10181|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall --- Created attachment 10224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10224&action=edit Course Reserves Adds a course reserves system for academic libraries. The course reserves system allows libraries to create courses and put items on reserves for those courses. Each item with at least one reserve can have some of its attributes modified while it is on reserve for at least one active course. These attributes include item type, collection code, shelving location, and holding library. If there are no active courses with this item on reserve, it's attributes will revert to the original attributes it had before going on reserve. Testing Scenario: 1) Create new authorised value categories DEPARTMENT and TERM 2) Create a new course, add instructors to that course. 3) Reserve items for that course, verify item attributes have changed. 4) Disable course, verify item attributes have reverted. 5) Enable course again, verify item attributes again. 6) Delete course, verify item attributes again. 7) Create two new courses, add the same item(s) to both courses. 8) Disable one course, verify item attributes have not reverted. 9) Disable both courses, verify item attributes have reverted. 10) Enable one course, verify item attributes are again set to the new values. 11) Edit reserve item attributes, verify. 12) Disable all courses, edit reserve item attributes, verify the item itself still has its original attributes, verify the reserve item attributes have been updated. 13) Verify the ability to remove instructors from a course. 14) Verify new permissions, top level coursereserves, with subpermissions add_reserves and delete_reserves. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:11:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:11:38 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:12:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:12:06 +0000 Subject: [Koha-bugs] [Bug 8236] New: Prevent renewing if overdue or restriction Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Priority: P5 - low Change sponsored?: --- Bug ID: 8236 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha at univ-lyon3.fr Summary: Prevent renewing if overdue or restriction Severity: enhancement Classification: Unclassified OS: All Reporter: adrien.saurat at biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Circulation Product: Koha Goal: no renewal possible if an item is overdue or if the patron is restricted (for consistency with the initial checkout rules) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:12:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:12:48 +0000 Subject: [Koha-bugs] [Bug 6774] Display barcode on OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6774 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5758|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 10225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10225&action=edit Bug 6774 Display barcode on OPAC detail page(Correcting Typo). Signed-off-by: Katrin Fischer Rebased to current master, works in my tests, but needs another set of eyes. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:12:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:12:54 +0000 Subject: [Koha-bugs] [Bug 1918] Minify JavaScript and CSS In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1918 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #5 from Dobrica Pavlinusic --- Thanks for rebase, I don't think this patch is really ready for sign-off so I'm changing status of this bug. I will need to investigate increase for on-load time, but since we are executing extra code to produce combined files, and emitting larger CSS and JavaScript files I would expect a small difference. For one thing, it still has warn(s) in it, so RM will fail QA on it, and on the other there are a few references to Koha::Persistant which is my internal thingy to track usage and should be replaced with Koha::Cache code in future. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:14:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:14:08 +0000 Subject: [Koha-bugs] [Bug 6774] Display barcode on OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6774 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |katrin.fischer at bsz-bw.de --- Comment #12 from Katrin Fischer --- Apart from the name of the system preference are basically the same. I have rebased the first Patch from Amit Gupta, as he did the earlier patch for this. To test, only one of the patches should be applied. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:14:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:14:58 +0000 Subject: [Koha-bugs] [Bug 6774] Display barcode on OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6774 --- Comment #13 from Katrin Fischer --- Note: Amit's patch is the second on the bug now. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:15:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:15:29 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Assignee|gmcharlt at gmail.com |oleonard at myacpl.org --- Comment #13 from Paul Poulain --- QA comment: tiny patch that fixes a problem using T::T features -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:15:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:15:57 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:21:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:21:17 +0000 Subject: [Koha-bugs] [Bug 8180] cataloguing/additem.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Alex Arnaud changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com --- Comment #6 from Alex Arnaud --- Dobrica, my item.barcode is linked to Plugin:barcode.pl. Also, i use autoBarcode syspref but can't reproduce the bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:22:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:22:41 +0000 Subject: [Koha-bugs] [Bug 7736] Edifact QUOTE and ORDER functionality In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7736 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8635|0 |1 is obsolete| | --- Comment #10 from Colin Campbell --- Created attachment 10226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10226&action=edit Rebased patch I have rebased Mark's patch against master and added entries to deal with the issues raised by Katrin in her last comment. Also if people have sample Edifact messages I'll gladly add them to the tests in the cpan Edifact module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:22:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:22:44 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 --- Comment #5 from Michael Davis --- Created attachment 10227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10227&action=edit Attachment to Bug 7295 - list of librarian managing a basket Bug 7295: More granular permissions for baskets Add branch info to baskets Add a list of borrowers that are allowed to manage a basket (one list for each basket). Add a new subpermission: acquisition => order_manage_all rebase If user is superlibrarian, or if he has permission acquisition = 1 (GranularPermissions = OFF), or subpermission acquisition => order_manage_all (GranularPermissions = ON). He's authorised to manage all baskets. Depending on syspref AcqViewBaskets: 'all': user can manage all baskets 'branch': user can manage baskets of his branch (the basket branch is taken into account, not the branch of the basket's creator). If basket branch is not defined, all user can manage this basket. 'user': user can manage baskets he created, and baskets he's in their user list There are unit tests in t/Acquisition/CanUserManageBasket.t, which require Test::MockModule You can edit basket's branch and users list in basket modification page (acqui/basket.pl) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:22:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:22:55 +0000 Subject: [Koha-bugs] [Bug 8232] Comments in OPAC contain untranslatable javascript messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8232 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10215|0 |1 is obsolete| | --- Comment #2 from Owen Leonard --- Created attachment 10228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10228&action=edit [SIGNED-OFF] Bug 8232: Comments in OPAC contain untranslatable javascript messages To test: - add a new comment to a record in the OPAC - Your comment (preview, pending approval) is not translatable - update po files by running 'perl translate update ' - Open po file and check if strings are there, translate - install language again by running 'perl translate install ' Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:23:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:23:41 +0000 Subject: [Koha-bugs] [Bug 8232] Comments in OPAC contain untranslatable javascript messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8232 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:24:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:24:24 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 --- Comment #16 from Paul Poulain --- QA Comment: small new feature, introduced nicely through a systempreference, in a nice and extensible way I think. It would be worth to add it also on other places where we do a window.print() for consistency. grep -R "window.print()" * shows that we print in the following pages: koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detailprint.tt: window.print(); koha-tmpl/intranet-tmpl/prog/en/modules/members/printinvoice.tt: window.print(); koha-tmpl/intranet-tmpl/prog/en/modules/members/printfeercpt.tt: window.print(); koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-receipt.tt: window.print(); koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-print.tt: window.print(); koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt: koha-tmpl/intranet-tmpl/prog/en/modules/labels/spinelabel-print.tt: koha-tmpl/intranet-tmpl/prog/en/modules/circ/transfer-slip.tt:window.print(); koha-tmpl/intranet-tmpl/prog/en/modules/circ/printslip.tt:window.print(); koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing-preview-slip.tt: Print   Close koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt:

      Print   Close

      koha-tmpl/intranet-tmpl/prog/en/xslt/oilsMARC21slim2HTML.xsl:
      I hesitate failing QA because of this non consistent behaviour, I won't mark it passed QA nor failed QA, to get another QA team opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:25:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:25:00 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10208|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall --- Created attachment 10229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10229&action=edit [SIGNED-OFF] Bug 7994: Fix pref yaml errors Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:25:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:25:21 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:25:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:25:27 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9943|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:25:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:25:49 +0000 Subject: [Koha-bugs] [Bug 8215] Add Course Reserves In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215 --- Comment #5 from Marijana Glavica --- This is very nice! There are two things i discovered: 1. Instructor Search does not work 2. Not possible to add more than one course :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:27:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:27:48 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 --- Comment #1 from Adrien SAURAT --- Created attachment 10230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10230&action=edit proposed patch #1 Rebased a patch made by the Lyon3 team. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:27:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:27:57 +0000 Subject: [Koha-bugs] [Bug 8236] Prevent renewing if overdue or restriction In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8236 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:29:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:29:28 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 --- Comment #10 from Jonathan Druart --- Created attachment 10231 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10231&action=edit Bug 8117: Followup Move the "no budget" string outside the table Hi Michael, Thanks for testing. I can't reproduce your javascript error. Could you test with this followup please ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:29:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:29:27 +0000 Subject: [Koha-bugs] [Bug 7941] Fix version numbers in modules and set up a system to keep them up to date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7941 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com Assignee|gmcharlt at gmail.com |chris at bigballofwax.co.nz --- Comment #7 from Paul Poulain --- QA comment: nothing specific to say: set the VERSION number for all packages, passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:29:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:29:36 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:30:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:30:22 +0000 Subject: [Koha-bugs] [Bug 6774] Display barcode on OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6774 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9985|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:30:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:30:26 +0000 Subject: [Koha-bugs] [Bug 7941] Fix version numbers in modules and set up a system to keep them up to date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7941 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 QA Contact|koha.sekjal at gmail.com |paul.poulain at biblibre.com --- Comment #8 from Paul Poulain --- can be backported to 3.8 or not, chris, it's up to you to decide -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:32:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:32:09 +0000 Subject: [Koha-bugs] [Bug 5332] Add batch reversion capability to bin/commit_biblios_file.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5332 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2725|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer --- Created attachment 10232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10232&action=edit Add batch revert capability (--revert) to commit_biblios_file.pl. Also add --progress-interval to facilitate debugging bad MARC batches. The basis for this enhancement was a bad batch of MARC records that had some unknown Unicode characters in them which caused the batch import function from the web interface to abort after importing only a portion of the records. At this point you are completely stuck using the web user interface. You can't go forward because the only option is to try the import again from the beginning (which fails again). You cannot revert either since there is no way to revert a partially committed batch. This change uses the existing BatchRevertBibRecords function. Bug reference: 5332 Signed-off-by: Katrin Fischer Rebased to current master 2012-06-11 - please test. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:32:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:32:23 +0000 Subject: [Koha-bugs] [Bug 5332] Add batch reversion capability to bin/commit_biblios_file.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5332 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:34:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:34:08 +0000 Subject: [Koha-bugs] [Bug 4527] Item details don't respect newlines in details data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4527 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain at biblibre.com --- Comment #6 from Paul Poulain --- QA comment: that's something for T::T plugins ! and it even already exist and is provided by default. For more information, see: http://template-toolkit.org/docs/manual/Filters.html#section_html_line_break -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:36:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:36:50 +0000 Subject: [Koha-bugs] [Bug 6092] default sort field and order when syspref are NULL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6092 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer --- I think this still needs a fix: 157 INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('defaultSortField',NULL,'Specify the default field used for sorting','relevance|popularity|call_number|pubdate|acqdate|title|author','Choice'); 158 INSERT INTO `systempreferences` (variable,value,explanation,options,type) VALUES('defaultSortOrder',NULL,'Specify the default sort order','asc|dsc|az|za','Choice'); -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:39:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:39:02 +0000 Subject: [Koha-bugs] [Bug 7294] status "in order" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7294 --- Comment #26 from Matthias Meusburger --- Works for me, but didn't work for mveron and alex_a when adding from new record or suggestion. I should try with the default koha community database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:47:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:47:49 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com Version|master |rel_3_10 --- Comment #13 from Paul Poulain --- QA comment: * patch adding dependencies on C4::Circulation and C4::Branch, that is quite heavy, but the page is rarely used, so it's OK * The patch is only a few line, no other objection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:49:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:49:32 +0000 Subject: [Koha-bugs] [Bug 6092] default sort field and order when syspref are NULL In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6092 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_4 |master --- Comment #6 from Katrin Fischer --- Fridolyn, could you perhaps resubmit this patch with changes to the syspref.sql file? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:52:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:52:58 +0000 Subject: [Koha-bugs] [Bug 3708] Add another customizable region to the OPAC: right sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3708 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9994|0 |1 is obsolete| | --- Comment #9 from Owen Leonard --- Created attachment 10233 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10233&action=edit Bug 3708 - Add another customizable region to the OPAC: right sidebar nav This patch creates a new system preference, OpacNavRight, in which the librarian can add HTML which will appear on the OPAC main page under the login form. If the user is logged in the content will appear in place of the login form. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:53:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:53:19 +0000 Subject: [Koha-bugs] [Bug 3708] Add another customizable region to the OPAC: right sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3708 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:55:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:55:35 +0000 Subject: [Koha-bugs] [Bug 7570] Add Item availability status to cart In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7570 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Paul Poulain --- Patch pushed, I've updated the follow-up to add another space in another similar place where we had no space in location(s)(status) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 17:56:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 15:56:27 +0000 Subject: [Koha-bugs] [Bug 7500] Use CSS Sprites for faster page loading In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7500 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9241|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:04:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:04:05 +0000 Subject: [Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Version|master |rel_3_10 --- Comment #13 from Paul Poulain --- QA comment: cleaning code patch only, no more reason to object ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:04:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:04:16 +0000 Subject: [Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:11:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:11:00 +0000 Subject: [Koha-bugs] [Bug 7810] C4/Auth.pm - on plack restart session is undefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7810 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain at biblibre.com Severity|enhancement |normal --- Comment #9 from Paul Poulain --- QA comment: tiny patch that can't be harmfull in CGI mode, as it just add a test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:11:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:11:43 +0000 Subject: [Koha-bugs] [Bug 7810] C4/Auth.pm - on plack restart session is undefined In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7810 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:14:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:14:00 +0000 Subject: [Koha-bugs] [Bug 6810] Send membership expiry reminder notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6810 Irma Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |irma at calyx.net.au Version|rel_3_10 |rel_3_8 --- Comment #6 from Irma Birchall --- Can't be tested in a sandbox as it needs command line access. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:14:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:14:14 +0000 Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327 --- Comment #174 from Stacey Walker --- Created attachment 10234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10234&action=edit Added some C4/Items.pm tests -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:16:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:16:41 +0000 Subject: [Koha-bugs] [Bug 8237] New: HTML-table in timeline broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8237 Priority: P5 - low Change sponsored?: --- Bug ID: 8237 Assignee: nengard at gmail.com Summary: HTML-table in timeline broken Severity: enhancement Classification: Unclassified OS: All Reporter: veron at veron.ch Hardware: All Status: NEW Version: master Component: About Product: Koha timeline in Home ? About Koha? Table does not display well, sometimes the date is together with the Description, e.g. December 6 2011... Reason: Missing tabs in docs/history.txt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:17:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:17:06 +0000 Subject: [Koha-bugs] [Bug 8237] HTML-table in timeline broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8237 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:17:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:17:38 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10178|0 |1 is obsolete| | Attachment #10179|0 |1 is obsolete| | Attachment #10180|0 |1 is obsolete| | Attachment #10231|0 |1 is obsolete| | --- Comment #11 from Michael Davis --- Created attachment 10235 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10235&action=edit [SIGNED-OFF] Bug 8117: Followup Move the "no budget" string outside the table Signed-off-by: Michael Davis -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:18:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:18:50 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10180|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:19:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:19:08 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10179|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:19:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:19:28 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 Michael Davis changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10178|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:20:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:20:24 +0000 Subject: [Koha-bugs] [Bug 8117] Divide budget periods into two tabs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8117 --- Comment #12 from Michael Davis --- This works for me, thanks, but I may have messed up the patches, so someone else should sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:21:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:21:04 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 --- Comment #14 from Paul Poulain --- QA comment: tiniest patch ever maybe, but I've a doubt. In opac-tags.pl, there is still some references to cloudweight field that you remove from the template (and is no more used in the template), for example: $_->{cloudweight} = $strata; I'm not sure I'm right, so I let someone else investigating and confirming or infirming. Not changing QA status for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:22:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:22:40 +0000 Subject: [Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Paul Poulain --- QA comment: this time it's OK, nothing to object ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:24:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:24:24 +0000 Subject: [Koha-bugs] [Bug 8220] Allow koc uploads to go to process queue instead of being applied directly. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8220 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob at calyx.net.au --- Comment #4 from Bob Birchall --- I ordered a Biblibre sandbox to test this patch. It appears that the patch did not apply. The extra links do not appear on the Circulation page. The email from the sandbox creator included the following: The patches attached to bugzilla 8220 have been applied, and the result is

      Something went wrong !

      Applying: Bug 8220 - Allow koc uploads to go to process queue instead of being applied directly.
      Using index info to reconstruct a base tree...
      Falling back to patching base and 3-way merge...
      Auto-merging C4/Circulation.pm
      Auto-merging installer/data/mysql/updatedatabase.pl
      CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
      Failed to merge in the changes.
      Patch failed at 0001 Bug 8220 - Allow koc uploads to go to process queue instead of being applied directly.
      When you have resolved this problem run git am --resolved.
      If you would prefer to skip this patch, instead run git am --skip.
      To restore the original branch and stop patching run git am --abort.
      Bug 8220 - Allow koc uploads to go to process queue instead of being applied directly.

      Bug 8220 - Allow koc uploads to go to process queue instead of being applied directly.
      Apply? [yn]
      Patch left in /tmp/Bug-8220---Allow-koc-uploads-to-go-to-process-queu-W6oPhU.patch
      Unable to sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:24:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:24:51 +0000 Subject: [Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|rel_3_6 |rel_3_8 --- Comment #10 from Paul Poulain --- Patch pushed (I haven't tested it, I have no patron cards on y test database) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:24:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:24:53 +0000 Subject: [Koha-bugs] [Bug 3708] Add another customizable region to the OPAC: right sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3708 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10233|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall --- Created attachment 10236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10236&action=edit [SIGNED-OFF] Bug 3708 - Add another customizable region to the OPAC: right sidebar nav This patch creates a new system preference, OpacNavRight, in which the librarian can add HTML which will appear on the OPAC main page under the login form. If the user is logged in the content will appear in place of the login form. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:25:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:25:10 +0000 Subject: [Koha-bugs] [Bug 3708] Add another customizable region to the OPAC: right sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3708 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:26:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:26:09 +0000 Subject: [Koha-bugs] [Bug 8136] Changes the expected lenght of 100$a in rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8136 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9699|0 |1 is obsolete| | --- Comment #2 from Sophie MEYNIEUX --- Created attachment 10237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10237&action=edit [SIGNED-OFF] Bug 8136 Changes the expected lenght of 100$a in rebuild_zebra.pl In rebuild_zebra.pl, if we are in "unimarc" ("marcflavour" syspref), the sub "fix_unimarc_100" is called and checks if 100$a lenght is equal to 35. If it is not the case, the sub inserts the localtime and more, so we loose the datas in reindexing. The standart lenght is 36. I have just changed 35 to 36. Signed-off-by: Sophie Meynieux -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:26:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:26:53 +0000 Subject: [Koha-bugs] [Bug 8136] Changes the expected lenght of 100$a in rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8136 Sophie MEYNIEUX changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:28:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:28:11 +0000 Subject: [Koha-bugs] [Bug 7553] automated checking that "need signoff" patch still applies In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7553 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |LATER --- Comment #5 from Paul Poulain --- The script does not work anymore, I'll try from time to time to check if something has changed on bugzilla or bugz, but until then, marking "RESO LATER" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:31:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:31:36 +0000 Subject: [Koha-bugs] [Bug 8136] Changes the expected lenght of 100$a in rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8136 --- Comment #3 from Sophie MEYNIEUX --- Modified record.abs to index pubdate in 100 field (UNIMARC) rebuild_zebra without the patch : Sorting on pubdate is not relevant rebuild_zebra with the patch : sorting on pubdate is relevant for biblio with 100 well filled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:34:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:34:22 +0000 Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a tag in the tag cloud isn't the number of items with that tag In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Ian Walls --- cloudweight looks to be an attempt to cluster the various weightings of terms into strata groups, 1 through 5. This isn't even the tag's raw weight, just it's relative weight projected to a 5 point scale. I don't think this is worth keeping, as it does nothing to inform the patron about anything they can actually use. Marking this as Passed QA, as it's perfectly valid code, and that it removes is okay (by my opinion) to remove. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:35:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:35:07 +0000 Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 --- Comment #9 from Koha Team Lyon 3 --- Ok,I think I see the reason why now : The \w class can match accentuated characters (as it does at lyon3) but unfortunately only if the adequate set of locales is installed on the system. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:45:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:45:30 +0000 Subject: [Koha-bugs] [Bug 7932] twitter share doesn't work with socialnetworks In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7932 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:51:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:51:08 +0000 Subject: [Koha-bugs] [Bug 7963] Parallel HTTP requests when checking URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10194|0 |1 is obsolete| | --- Comment #9 from Fr?d?ric Demians --- Created attachment 10238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10238&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:51:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:51:35 +0000 Subject: [Koha-bugs] [Bug 7963] Parallel HTTP requests when checking URLs In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7963 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10195|0 |1 is obsolete| | --- Comment #10 from Fr?d?ric Demians --- Created attachment 10239 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10239&action=edit Dependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 18:59:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 16:59:59 +0000 Subject: [Koha-bugs] [Bug 8199] Search results are contained into a table html element In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199 --- Comment #3 from Owen Leonard --- I don't think there's anything inherently more ergonomic about showing search results in divs instead of tables, so I'd be interested in seeing a test case that shows how this makes things more flexible. Is the goal to be able to rearrange the elements somehow? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 19:58:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 17:58:57 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 --- Comment #33 from Pierre Angot --- Yep, that's what I wanted to do. But, I've got a big problem with my Ubuntu (10.04 -> 12.04 = crash). Many paquets are corrupted, and I can't upgrade anything ^^ I'll test thursday on (?) an other install. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 20:42:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 18:42:34 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #65 from M. de Rooy --- (In reply to comment #64) > > If I recall correctly, you could switch modes via $ENV{DEBUG} in koha-httpd, > > but it only seems now to hide the Execute button in normal mode. Am I > > correct? > > Wasn't it meant to enable/disable linear vs non-linear updates? > ??? I don't understand what you mean here. If you set DEBUG=1, what is the difference? Seems to me only hiding the Execute button. I see that it indeed prevents non-linear updating. Question solved more or less; will come back to it in QA. > Can you explain what you made ? I suspect you have added a test SQL in > installer/data/mysql/versions/ and called it test01.sql. It's wrong, it must > be a number 3.09.00.014 for example (could also be 123.456, but it must be > numbers+. only) Yes, I made that file. Instead of such an error message, I would propose just to ignore files that do not match the numbering scheme. Perhaps mark them as inappropriate on the new updatedatabase form, or so. (In a folder you can always expect files with other names..) Will return to that too soon. Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 20:55:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 18:55:53 +0000 Subject: [Koha-bugs] [Bug 8237] HTML-table in timeline broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8237 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #1 from M. de Rooy --- I submitted a patch for that under report 7368 this afternoon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 21:08:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 19:08:30 +0000 Subject: [Koha-bugs] [Bug 8009] Item descriptive data not populated on pay.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 Susie Hastings changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hastingssf at vmi.edu --- Comment #10 from Susie Hastings --- Just weighing in on this issue, ?from the field? (Preston Library at VMI). We?re an academic library whose faculty have a loan period of a whole academic year. All their books are due on April 15, and when they are not returned after 28 days, they all become ?Billed?. It would not be too unusual for a faculty member to want to pay for one item from a list of other billed items that he expects to return in a few days. You can imagine in that case how hard it would be to receive payment for the correct item, since there is no description on the ?Pay Fines? tab. So, to me, this seems more like a fix than an enhancement, and it would be great to have it fixed as soon as possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 21:40:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 19:40:36 +0000 Subject: [Koha-bugs] [Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613 --- Comment #34 from D Ruth Bavousett --- Created attachment 10240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10240&action=edit Followup patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 21:40:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 19:40:53 +0000 Subject: [Koha-bugs] [Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613 D Ruth Bavousett changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 21:50:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 19:50:32 +0000 Subject: [Koha-bugs] [Bug 8238] New: Holds limits broken Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8238 Priority: P5 - low Change sponsored?: --- Bug ID: 8238 CC: gmcharlt at gmail.com Assignee: koha.sekjal at gmail.com Summary: Holds limits broken Severity: critical Classification: Unclassified OS: All Reporter: oleonard at myacpl.org Hardware: All Status: NEW Version: master Component: Hold requests Product: Koha Neither the OPAC nor staff client seem to respect any hold limit specified in circulation rule. This problem appears in master (my test installation) and as far back as 3.6.1 (my library's in-production system). The difference I find between master and 3.6.1 is that in 3.6.1 the staff client seems to respect the limit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 11 21:50:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 19:50:44 +0000 Subject: [Koha-bugs] [Bug 8238] Hold limits broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8238 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Holds limits broken |Hold limits broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 00:11:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 22:11:27 +0000 Subject: [Koha-bugs] [Bug 8237] HTML-table in timeline broken In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8237 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7368 Resolution|--- |DUPLICATE --- Comment #2 from Marc V?ron --- *** This bug has been marked as a duplicate of bug 7368 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 00:11:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 22:11:27 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8237 --- Comment #18 from Marc V?ron --- *** Bug 8237 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 01:15:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Jun 2012 23:15:32 +0000 Subject: [Koha-bugs] [Bug 7613] OCLC Connexion Gateway, including extension svc/import_bib In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7613 --- Comment #35 from Srdjan Jankovic --- The patch is good, except for one issue - it was requested for svc/import_bib to be a drop in replacement for svc/new_bib. This patch changes interface, ie makes a proper url encoded post param/value POST request. svc/new_bib has pure XML in POST body. Please check if that is fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 02:13:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 00:13:24 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 --- Comment #6 from Srdjan Jankovic --- (In reply to comment #5) > QA comments: > > * I don't understand the need/use of > + my $userenv_branch = $userenv ? $userenv->{"branch"} : undef; > why don't you use $userenv->{"branch"} ? I was not sure that $userenv is guaranteed to be there. > * the sub > + =head2 get_user_printer > must not be in C4/Auth.pm, but in C4/Print.pm (not a perfect option) /() should not be in C4/Print.pm, because Print.pm is doing printing, not printer queue selection. get_user_printer() is a matter of session, that's why I placed it there (same as library selection). > or in > Koha:: namespace (in the hackfest currently running, I've proposed a time to > discuss of naming convention/organisation for Koha:: namespace) > * same comment for sub GetPrinterDetails {, should not be in C4/Koha.pm > > Other than this, the code looks OK (haven't tested it yet) I can move GetPrinter* functions to C4/Print.pm. I'd probably prefer to have C4/Printer.pm, but C4/Print.pm would do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 04:18:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 02:18:55 +0000 Subject: [Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911 --- Comment #26 from Srdjan Jankovic --- Created attachment 10241 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10241&action=edit bug_5911: make perlcdritic happy, shut up warnings -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 04:33:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 02:33:31 +0000 Subject: [Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an item between branches In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911 Srdjan Jankovic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #27 from Srdjan Jankovic --- (In reply to comment #25) > QA comments: > * perlcritic problem: > C4/HoldsQueue.pm: Don't modify $_ in list functions at line 571, column 27. > See page 114 of PBP. (Severity: 5) perlcritic can be such a pain... > * why is this code in this patch? > +sub _flush_preferences { > + %sysprefs = (); > +} It is a poor man's sysprefs flush as per the comment above the code: # FIXME: running this under mod_perl will require a means of # flushing the caching mechanism I did not want to remove the comment because: a) this solution was created in anger, so may not fit all b) I did not address mod_perl/plack/ any other persistant env, just needed a way to change sysprefs for the test > > * we're supposed not to add anything to C4::, but use Koha:: instead. You're > creating HoldsQueue.pm. As we haven't defined a clear organization for > Koha::, I can't say where this code should be, it's probably fair to have it > in C4. Plus I don't want Koha:: be filled with C4:: like scripts, so won't > reject the patch for this reason When I started this, I did not even know of Koha namespace. Now I know, but not sure how to put things there :) > > The line: > # XXX GetHoldsQueueItems() does not support $itemtypeslimit! > > should be > # FIXME GetHoldsQueueItems() does not support $itemtypeslimit! I was not sure if that needs addressing, just wanted to add a note. I can change this if required. > > Just a question, not related to QA: if the syspref is OFF, how are things > sorted ? as before ? (if yes, good point you've set the value to 0 by > default, it means there won't be any change for users) Yes, if off it behaves as before. Default is 0. t/db_dependent/HoldsQueue.t tests both cases. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 06:57:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 04:57:49 +0000 Subject: [Koha-bugs] [Bug 8239] New: Z39.50 Search/Import doesn't work with unicode characters from a specific server Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8239 Priority: P5 - low Change sponsored?: --- Bug ID: 8239 Assignee: gmcharlt at gmail.com Summary: Z39.50 Search/Import doesn't work with unicode characters from a specific server Severity: normal Classification: Unclassified OS: All Reporter: derrynj at gmail.com Hardware: All Status: NEW Version: rel_3_8 Component: Cataloging Product: Koha Created attachment 10242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10242&action=edit Screenshots depicting both functioning and non-functioning unicode searches I have in my list of Z39.50 servers, a couple of servers which return the unprintable code {FFFD} when it is supposed to put a ? character. Other servers with the same search work fine. Trying the same search in MarcEdit's Z39.50 client, it comes out with the correct character. The servers in question are (and these are exactly the settings I have in my Koha installation): Australian National University host: library.anu.edu.au port: 210 databse: innopac syntax: USMARC encoding: MARC-8 and University of Melbourne host: cat.lib.unimelb.edu.au port: 210 databse: innopac syntax: USMARC encoding: MARC-8 Steps to reproduce? With the above servers added to Z39.50 Client Targets list: 1) Search for 'Francis Alys' in Title 2) Look down the list for title 'Francis Al?s' by Author 'Medina, Cuauhtm?oc' 3) See that there is a ? character where there should be a ? Actual result? Result from Australia National Uni - Koha: Francis Al?s / Medina, Cuauht?moc Expected Result? Francis Al?s / Medina, Cuauhtm?oc Result from Aust National Uni - MarcEdit: Francis Al?s / Medina, Cuauhtm?oc Additional information: Attached are screenshots of 2 cases where the characters don't show properly (University of Melbourne and Australian National University), a shot of the same search with La Trobe University, which appears correctly, and a shot of the Australian National University search done (successfully) on MarcEdit's Z39.50 Client. Here is a link to the catalogued item on Australian National Uni's own library system: http://library.anu.edu.au/record=b2298563 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 08:32:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 06:32:08 +0000 Subject: [Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #11 from Chris Cormack --- This now needs a follow up to correct the behaviour in t/Creators.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 08:38:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 06:38:44 +0000 Subject: [Koha-bugs] [Bug 5337] acq EAN search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 08:39:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 06:39:49 +0000 Subject: [Koha-bugs] [Bug 5337] acq EAN search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10016|0 |1 is obsolete| | --- Comment #35 from Chris Cormack --- Created attachment 10243 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10243&action=edit Bug 5337 : Upping the count of the unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 08:40:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 06:40:14 +0000 Subject: [Koha-bugs] [Bug 5337] acq EAN search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #36 from Chris Cormack --- Just a follow up to make jenkins happy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 08:50:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 06:50:03 +0000 Subject: [Koha-bugs] [Bug 7307] OPACBaseURL not used in opac-search.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7307 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #16 from David Cook --- Since Koha already has http hard-coded in, why not just replace it with another system preference where Koha admins can specify whether it's http or https? I found it already hard-coded in: virtualshelves/sendshelf.tt /xslt/MARC21slim2intranetDetail.xsl /modules/opac-sendshelf.tt I had to add it to the following to get the RSS feeds (both the link and the actual feed, since it relied on opac-search.pl for OPACBaseURL) to work in the OPAC (after initializing OPACBaseURL in opac-search.pl): /includes/masthead.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 09:21:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 07:21:24 +0000 Subject: [Koha-bugs] [Bug 8009] Item descriptive data not populated on pay.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #11 from Chris Cormack --- Pushed to 3.8.x .. I will personally ring everyone of you if anyone complains about it being in 3.8.2 :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 09:38:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 07:38:37 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #9 from Chris Cormack --- Pushed the first patch, the follow up looks fine to me, will push that to 3.8.x when it is pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 09:39:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 07:39:45 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 09:49:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 07:49:01 +0000 Subject: [Koha-bugs] [Bug 8240] New: There is dead code in orderreceive.tt Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8240 Priority: P5 - low Change sponsored?: --- Bug ID: 8240 Assignee: koha-bugs at lists.koha-community.org Summary: There is dead code in orderreceive.tt Severity: enhancement Classification: Unclassified OS: All Reporter: jonathan.druart at biblibre.com Hardware: All Status: NEW Version: unspecified Component: Acquisitions Product: Koha The function C4::Acquisition::SearchOrder can't return more than 1 result with a given ordernumber. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 09:49:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 07:49:09 +0000 Subject: [Koha-bugs] [Bug 8240] There is dead code in orderreceive.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8240 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 09:50:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 07:50:49 +0000 Subject: [Koha-bugs] [Bug 8240] There is dead code in orderreceive.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8240 --- Comment #1 from Jonathan Druart --- Created attachment 10244 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10244&action=edit Bug 8240: Remove dead code from orderreceive I think this code is useless and can be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 09:50:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 07:50:56 +0000 Subject: [Koha-bugs] [Bug 8240] There is dead code in orderreceive.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8240 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 09:51:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 07:51:40 +0000 Subject: [Koha-bugs] [Bug 8101] DataTables in Acquisision module: orderreceive.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8101 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Depends on| |8240 Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 09:51:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 07:51:41 +0000 Subject: [Koha-bugs] [Bug 5345] DataTables in Koha In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5345 Bug 5345 depends on bug 8101, which changed state. Bug 8101 Summary: DataTables in Acquisision module: orderreceive.tt http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8101 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 09:51:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 07:51:40 +0000 Subject: [Koha-bugs] [Bug 8240] There is dead code in orderreceive.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8240 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8101 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 09:52:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 07:52:34 +0000 Subject: [Koha-bugs] [Bug 8101] DataTables in Acquisision module: orderreceive.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8101 --- Comment #7 from Jonathan Druart --- See Bug 8240 (remove dead code) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 10:07:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 08:07:34 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #19 from Jonathan Druart --- Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 10:35:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 08:35:08 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 --- Comment #31 from Jonathan Druart --- Created attachment 10245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10245&action=edit Bug 5342: Followup Delete tags on letters This patch remove the tag order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 10:39:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 08:39:38 +0000 Subject: [Koha-bugs] [Bug 8227] Remove compile time warning from C4::Serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8227 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10174|0 |1 is obsolete| | --- Comment #2 from Julian Maurice --- Created attachment 10246 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10246&action=edit [SIGNED-OFF] Bug 8227 Fix deprecated construct compile time warning in Serials On master: $ perl -cw C4/Serials.pm Use of qw(...) as parentheses is deprecated at C4/Serials.pm line 604. C4/Serials.pm syntax OK With patch: $ perl -cw C4/Serials.pm C4/Serials.pm syntax OK Signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 10:39:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 08:39:47 +0000 Subject: [Koha-bugs] [Bug 8227] Remove compile time warning from C4::Serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8227 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 10:51:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 08:51:03 +0000 Subject: [Koha-bugs] [Bug 8229] Tabs in marc subfield structure is not shown correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8229 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- QA Comments: FIX compatibility for the new version of jQuery UI Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 10:53:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 08:53:00 +0000 Subject: [Koha-bugs] [Bug 2930] Put other name on CKO screen In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2930 --- Comment #2 from MJ Ray (software.coop) --- (In reply to comment #1) > So for an "organisation" the othername will already be displyed. How should > the display for othername look like? Can we agree on something here? I suspect it should be: [% firstname %] [% IF othernames %] ([% othernames %]) [% END %] [% surname %] Does anyone see a problem with that? It is one of the suggested forms in http://dictionary2.classic.reference.com/writing/styleguide/personal.html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 10:55:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 08:55:57 +0000 Subject: [Koha-bugs] [Bug 4527] Item details don't respect newlines in details data In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4527 MJ Ray (software.coop) changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #7 from MJ Ray (software.coop) --- (In reply to comment #6) > QA comment: that's something for T::T plugins ! and it even already exist > and is provided by default. For more information, see: > http://template-toolkit.org/docs/manual/Filters.html#section_html_line_break So do detail.tt and opac-detail.tt need patching or not at all? Anyone got a nice test case for the original bug? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 11:02:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 09:02:03 +0000 Subject: [Koha-bugs] [Bug 6175] Mismatch between marc_subfield_structure and authorised_values tables In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6175 --- Comment #6 from MJ Ray (software.coop) --- (In reply to comment #5) > QA comment: This patch has some problems: > * it introduces a constraint that is wrong: > + CONSTRAINT `auth_subfield_structure_ibfk_1` FOREIGN KEY > (`authorised_value`) REFERENCES `authorised_values` (`category`) ON DELETE > CASCADE ON UPDATE CASCADE > => the constraint can be on authorised_values, but also on branches or > itemtype, so a SQL constraint is unapplicable here So is this potential mismatch unavoidable with the current database design? > * it contains a lot of changes in french file that are just moving things from > the bottom to the top of file without reason (at least without relation to this > patch. As the patch has been made by someone from argentina, I think it was not > intended to update french files !) > * there is no updatedatabase part on this patch making existing Koha being > de-synchronised from freshly installed Koha These are not currently among the http://wiki.koha-community.org/wiki/Coding_Guidelines#Database but perhaps they should be? This would not be the first patch to change kohastructure.sql without a matching updatedatabase, after all... but I remember them because they caused bugs, so maybe it should be a guideline. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 11:05:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 09:05:21 +0000 Subject: [Koha-bugs] [Bug 8227] Remove compile time warning from C4::Serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8227 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Removes warning from C4/Serials.pm Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 11:27:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 09:27:34 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #18 from Jonathan Druart --- QA Comments: 1/ Usage is not correct: +=head1 USAGE + +From Koha root directory: + +prove -v xt/tt_valid.t 2/ It not possible to launch the test file from the koha home directory (prove xt/yaml_valid.t) (see the FindBin module) 3/ Don't you think it would be more friendly to do a test file (thus using Test::More) for your pl file ? 4/ You add a new dependency Test::YAML::Valid. I dont know if we have to add this dependency to koha (given that it is used for unit tests). Marking as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 11:40:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 09:40:13 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #17 from Jonathan Druart --- Paul, I agree with you, this feature must be used for all occurrences of "window.print". But it is not blocking. I think this patch could be pushed though a followup is required asap. I let you make the decision ;-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 11:44:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 09:44:06 +0000 Subject: [Koha-bugs] [Bug 8232] Comments in OPAC contain untranslatable javascript messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8232 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- Make translatable 2 strings in opac-review.tt Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 11:58:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 09:58:49 +0000 Subject: [Koha-bugs] [Bug 8172] Missing dereference marker for buildQuery parameter in addbooks.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172 --- Comment #1 from M. Tompsett --- I was looking originally at 3.6.3. I downloaded 3.8.1 and confirmed this bug exists in it as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 12:02:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 10:02:41 +0000 Subject: [Koha-bugs] [Bug 8175] Missing defined check in catalogue/details.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175 --- Comment #2 from M. Tompsett --- Under 3.8.1 is just below the analytics section that was added with tabs, instead of spaces. Line 260. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 12:15:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 10:15:14 +0000 Subject: [Koha-bugs] [Bug 6828] Add Admin Dashboard for staff users. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6828 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #17 from Jonathan Druart --- QA Comments: 1/ I think the Copyright is not the good one :) (+# Copyright 2000-2002 Katipo Communications) 2/ SQL reserved words must be uppercased 3/ all files are not pertidied (indentation, etc.) 4/ intranet-main.tt > Tables does not contain a body tag. However, its contain style (width="400") whitch can be set into the css file. 5/ The first table (Overview) contains an empty row (the last one). 6/ The value of the syspref DashBoardDisplayed is send to the template from C4/Auth.pm. I think it can be sent from the mainpage.pl 7/ Why the default value for DashBoardDisplayed is "show" ? We have to launch the dashboard_xml.pl script then I think the default value could be "Don't show" Marking as Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 13:45:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 11:45:49 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 14:31:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 12:31:08 +0000 Subject: [Koha-bugs] [Bug 8199] Search results are contained into a table html element In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9956|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart --- Created attachment 10247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10247&action=edit Bug 8199 : Replace table in opac-results with div -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 14:36:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 12:36:04 +0000 Subject: [Koha-bugs] [Bug 8199] Search results are contained into a table html element In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8199 --- Comment #5 from Jonathan Druart --- Hi Owen, For example: currently (with the table structure) it is not possible to move the image from right to left. With this patch, we can filled the OPACUserCSS syspref with: .result > input { float: none; } .result > span { float: none; margin-left: 5px; } .all_results > div > span.biblio_infos { display: block; max-width: 80%; padding-left: 120px; margin-top: -15px; } .result > span.image { margin-left: 30px; margin-top: -70px; position: absolute; } -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 14:57:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 12:57:02 +0000 Subject: [Koha-bugs] [Bug 7387] Add Template::Toolkit plugin to allow caching of includes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |jonathan.druart at biblibre.co | |m --- Comment #5 from Jonathan Druart --- Bug 7248 is pushed, I switch this one to "Signed off" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 14:57:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 12:57:08 +0000 Subject: [Koha-bugs] [Bug 7387] Add Template::Toolkit plugin to allow caching of includes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7387 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 15:02:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 13:02:26 +0000 Subject: [Koha-bugs] [Bug 6774] Display barcode on OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6774 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10225|0 |1 is obsolete| | --- Comment #14 from Julian Maurice --- Created attachment 10248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10248&action=edit [SIGNED-OFF]?Bug 6774 Display barcode on OPAC detail page(Correcting Typo) Works for me too on current master. Signed off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 15:02:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 13:02:33 +0000 Subject: [Koha-bugs] [Bug 6774] Display barcode on OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6774 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 15:06:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 13:06:56 +0000 Subject: [Koha-bugs] [Bug 5910] Authorities : allow users to search on all auth types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10117|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 10249 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10249&action=edit Bug 5910: [SIGNED-OFF] only add "All authority types" for UNIMARC UNIMARC is the only marcflavour that does not already have an option for searching all authority types, so check that the marcflavour is UNIMARC before displaying the additional "All authority types" option. Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 15:07:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 13:07:13 +0000 Subject: [Koha-bugs] [Bug 5910] Authorities : allow users to search on all auth types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 15:14:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 13:14:25 +0000 Subject: [Koha-bugs] [Bug 5544] All Notices from Branch Email Address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #2 from Jonathan Druart --- QA Comment: I think you can rewrite + my $branch = GetBranchDetail( $member->{'branchcode'} ); + From => $message->{'from_address'} || $branch->{'branchemail'} || C4::Context->preference('KohaAdminEmailAddress'), With: From => $message->{'from_address'} || GetBranchDetail( $member->{'branchcode'} )->{'branchemail'} || C4::Context->preference('KohaAdminEmailAddress'), In order to bypassed an useless call (GetBranchDetail) in some cases ($message->{from_address} not defined). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 15:30:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 13:30:57 +0000 Subject: [Koha-bugs] [Bug 6774] Display barcode on OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6774 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #15 from Jonathan Druart --- QA Comments: Adds a new syspref OPACShowBarcode for the opac-detail page. Marking as Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 15:43:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 13:43:29 +0000 Subject: [Koha-bugs] [Bug 7065] reserves table needs a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10140|0 |1 is obsolete| | --- Comment #25 from Julian Maurice --- Created attachment 10250 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10250&action=edit [SIGNED-OFF] Bug 7065 - reserves table needs a primary key Ok, tmp_reserve is created from old_reserve like said in Paul's comment. Still works as expected, signed off. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 15:43:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 13:43:39 +0000 Subject: [Koha-bugs] [Bug 7065] reserves table needs a primary key In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7065 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 15:44:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 13:44:57 +0000 Subject: [Koha-bugs] [Bug 8241] New: Remove stray references to YUI autocomplete Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8241 Priority: P5 - low Change sponsored?: --- Bug ID: 8241 Assignee: oleonard at myacpl.org Blocks: 7747 Summary: Remove stray references to YUI autocomplete Severity: normal Classification: Unclassified OS: All Reporter: oleonard at myacpl.org Hardware: All Status: ASSIGNED Version: master Component: Templates Product: Koha There are a couple of templates which still reference YUI autocomplete: help-top.inc and authorities/auth_finder.tt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 15:44:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 13:44:57 +0000 Subject: [Koha-bugs] [Bug 7747] Replace YUI autocomplete with jQueryUI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8241 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 15:49:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 13:49:27 +0000 Subject: [Koha-bugs] [Bug 8226] 'OpacFooter' markup/css improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8226 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl --- Comment #7 from M. de Rooy --- Looks good. Nofollow explained on report. Just small change in css and template. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 15:53:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 13:53:35 +0000 Subject: [Koha-bugs] [Bug 6090] empty mails in message_queue are sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6090 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #11 from M. de Rooy --- Typo: +kfpackage C4::Letters; How was this tested? :-) Please correct and set back to Needs signoff. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 15:54:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 13:54:59 +0000 Subject: [Koha-bugs] [Bug 6090] empty mails in message_queue are sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6090 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 16:03:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 14:03:15 +0000 Subject: [Koha-bugs] [Bug 8223] Properly format SQL query in C4::Bookseller::GetBookSeller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8223 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy at rijksmuseum.nl Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | QA Contact| |m.de.rooy at rijksmuseum.nl --- Comment #3 from M. de Rooy --- Thx for housekeeping ;) Passed QA Kyle: In this case you should have clicked "take" to make yourself the assignee instead of koha bugs list. (Just reminding..) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 17:08:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 15:08:32 +0000 Subject: [Koha-bugs] [Bug 8163] Click to populate XSLT preferences with "default" or empty values In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8163 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #2 from Julian Maurice --- I wonder if we can make things more generic, like for example: Set to default Leave empty with JS: $(".set_syspref").click(function() { var s = $(this).attr('data-syspref'); var v = $(this).attr('data-value'); $("#pref_"+s).val(v); }); or something like this. What do you think? This way we can provide default button for all 'Free' and 'Integer' sysprefs that have a default value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 17:34:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 15:34:59 +0000 Subject: [Koha-bugs] [Bug 8241] Remove stray references to YUI autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8241 --- Comment #1 from Owen Leonard --- Created attachment 10251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10251&action=edit Bug 8241 - Remove stray references to YUI autocomplete - Removing unused references to YUI assets in authorities/auth_finder.tt - Removing unneeded call to autocomplete JS in help-top.inc and adding new jQuery dependencies. - Minor HTML markup corrections to auth-finder-search.inc discovered in debugging the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 17:35:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 15:35:18 +0000 Subject: [Koha-bugs] [Bug 8241] Remove stray references to YUI autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8241 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 17:37:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 15:37:14 +0000 Subject: [Koha-bugs] [Bug 7747] Replace YUI autocomplete with jQueryUI In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747 --- Comment #14 from Owen Leonard --- I've submitted a follow-up in Bug 8241. > Authorities search does not seem to work It's working fine for me, so please re-test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 18:27:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 16:27:26 +0000 Subject: [Koha-bugs] [Bug 8194] Subscription-add.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8194 --- Comment #1 from Owen Leonard --- Created attachment 10252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10252&action=edit Screenshot showing possible problem I see that when "manual history" is enabled the serials planning block is pushed to the right instead of down. Is this the problem you're seeing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 18:55:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 16:55:10 +0000 Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10219|0 |1 is obsolete| | --- Comment #10 from Koha Team Lyon 3 --- Created attachment 10253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10253&action=edit OPACNoResultsFound, Add keyword to query string Further investigations showed that was not a question of \w class with locales but an encoding problem on the keywords extracted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 18:55:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 16:55:32 +0000 Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 18:56:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 16:56:39 +0000 Subject: [Koha-bugs] [Bug 8186] Form structure problem in serials claims filter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8186 --- Comment #1 from Owen Leonard --- Created attachment 10254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10254&action=edit Bug 8186 - Form structure problem in serials claims filter Correcting form markup so that form fields and buttons are properly spaced. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 19:03:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 17:03:35 +0000 Subject: [Koha-bugs] [Bug 8186] Form structure problem in serials claims filter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8186 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Owen Leonard --- I think the filter form should probably also be moved into the left-hand sidebar but it's not clear to me how that would work in the mode hinted at in the markup by [% UNLESS ( preview ) %]. Under what conditions is the page in "preview" mode? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 19:04:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 17:04:30 +0000 Subject: [Koha-bugs] [Bug 8174] OpacNavBottom appears between OpacNav and Patron Links when patron is logged in and browses to /koha/opac-main.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8174 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 12 19:59:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 17:59:00 +0000 Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #11 from Katrin Fischer --- I am sorry, but I think should be "needs signoff" for the improved patch. Thx for fixing it! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 01:39:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Jun 2012 23:39:48 +0000 Subject: [Koha-bugs] [Bug 8194] Subscription-add.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8194 --- Comment #2 from David Cook --- Created attachment 10255 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10255&action=edit Screenshot of interim solution Yes, Owen. That is precisely the problem that I was seeing. It isn't much of an issue at present for us (see attached screenshot), since we added the tiny mce editor class to the OPAC and Nonpublic notes, which forced the Subscription details block to be longer and the other blocks to float to the right. However, I think that's more a coincidental, interim fix than a real solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 09:10:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 07:10:23 +0000 Subject: [Koha-bugs] [Bug 8186] Form structure problem in serials claims filter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8186 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #3 from Jonathan Druart --- (In reply to comment #2) > I think the filter form should probably also be moved into the left-hand > sidebar but it's not clear to me how that would work in the mode hinted at > in the markup by [% UNLESS ( preview ) %]. Under what conditions is the page > in "preview" mode? Hi Owen, I did not find any conditions for this preview mode. Moreover, I delete this part of code in a patch for Bug 5342 (attachment 10212). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 09:22:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 07:22:20 +0000 Subject: [Koha-bugs] [Bug 8186] Form structure problem in serials claims filter In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8186 --- Comment #4 from Jonathan Druart --- And I think the problem you raise in this issue is probably resolved by the main patch proposed for Bug 5342 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 09:53:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 07:53:41 +0000 Subject: [Koha-bugs] [Bug 7620] OPACNoResult, add search string to available parameters In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7620 --- Comment #12 from Koha Team Lyon 3 --- Do you mean I declared "Signed Off" status instead of "Needs Signoff" ? If so, I'm sorry. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 10:39:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 08:39:33 +0000 Subject: [Koha-bugs] [Bug 5312] XHTML correction in authority summary In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5312 --- Comment #10 from Fridolyn SOMERS --- Thanks everyone. I've learned a bit of XHTML since : new line is "
      " (no space). Patch is correct. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 11:21:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 09:21:42 +0000 Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn jsPrintSetup and new staff client preference In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563 --- Comment #18 from Marc V?ron --- Paul and Jonathan, Thank you for your comments. When I introduced this feature, I was aware that it could be used at other places as well. This version is just for the use case where a lot of printing occurs, and it was made by advice of the librarians in our group who often work at the front desk and who told me that not having this feature could be a killer argument against Koha. I really would appreciate if you could push it, and I will be happy to deliver follow ups for the other use cases as well. Thanks again Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 12:57:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 10:57:24 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #66 from Paul Poulain --- (In reply to comment #65) > (In reply to comment #64) > > > If I recall correctly, you could switch modes via $ENV{DEBUG} in koha-httpd, > > > but it only seems now to hide the Execute button in normal mode. Am I > > > correct? > > > Wasn't it meant to enable/disable linear vs non-linear updates? > > ??? I don't understand what you mean here. > If you set DEBUG=1, what is the difference? Seems to me only hiding the > Execute button. I see that it indeed prevents non-linear updating. Question > solved more or less; will come back to it in QA. OK, got it ! The idea behind this was that, in production environment, there is no reason not to apply all patches. So if DEBUG=0, having only the option to apply all update sounds OK. If DEBUG=1, a *developer* can find some reason not to apply everything. > > Can you explain what you made ? I suspect you have added a test SQL in > > installer/data/mysql/versions/ and called it test01.sql. It's wrong, it must > > be a number 3.09.00.014 for example (could also be 123.456, but it must be > > numbers+. only) > Yes, I made that file. Instead of such an error message, I would propose > just to ignore files that do not match the numbering scheme. Perhaps mark > them as inappropriate on the new updatedatabase form, or so. (In a folder > you can always expect files with other names..) Will return to that too soon. If someone submit a patch including a file with a wrong name it won't pass QA, that's as simple as that, I'm not sure it's needed to check for the format. Also note that, when the patch will be pushed, i'll start a wiki page where ppl, when submitting a patch with a DB update, will be able to mark/reserve a number to avoid having a conflict. And if a number does not make his way into Koha finally, that's not a big problem, we can let the number empty or create a fake DB update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 13:03:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 11:03:28 +0000 Subject: [Koha-bugs] [Bug 8034] Enable server print queue selection In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034 --- Comment #7 from Paul Poulain --- (In reply to comment #6) > (In reply to comment #5) > > QA comments: > > > > * I don't understand the need/use of > > + my $userenv_branch = $userenv ? $userenv->{"branch"} : undef; > > why don't you use $userenv->{"branch"} ? > > I was not sure that $userenv is guaranteed to be there. as it's related to staff interface, you must have a $userenv available, otherwise there's a problem somewhere, and it must be fixed where it is. > > * the sub > > + =head2 get_user_printer > > must not be in C4/Auth.pm, but in C4/Print.pm (not a perfect option) > > /() should not be in C4/Print.pm, because Print.pm is doing printing, not > printer queue selection. get_user_printer() is a matter of session, that's > why I placed it there (same as library selection). OK, got it. > > or in > > Koha:: namespace (in the hackfest currently running, I've proposed a time to > > discuss of naming convention/organisation for Koha:: namespace) > > * same comment for sub GetPrinterDetails {, should not be in C4/Koha.pm > > > > Other than this, the code looks OK (haven't tested it yet) > > I can move GetPrinter* functions to C4/Print.pm. I'd probably prefer to have > C4/Printer.pm, but C4/Print.pm would do. mmm... I hesitate... I think I agree with you and the best would be to have a C4/Printer.pm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 13:19:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 11:19:57 +0000 Subject: [Koha-bugs] [Bug 8242] New: Permission for "change password" button in members toolbar should be "borrowers" instead of "staffaccess" Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Priority: P5 - low Change sponsored?: --- Bug ID: 8242 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Permission for "change password" button in members toolbar should be "borrowers" instead of "staffaccess" Severity: enhancement Classification: Unclassified OS: All Reporter: koha at univ-lyon3.fr Hardware: All Status: NEW Version: rel_3_8 Component: Patrons Product: Koha Created attachment 10256 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10256&action=edit Patch members-toolbar.inc Same thing than bug Bogue 7888 but in members tab : allow a use with edit borrowers permission to change the password. Patch changes permisison for "change password" button in members-toolbar.inc from staffaccess to borrowers. To test : To test: - With a staff user with borrowers permission, verify the change password button is shown for a normal patron. - With a staff user without borrowers permission, verify the change password button does not appear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 13:34:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 11:34:59 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #67 from Jared Camins-Esakov --- > > > Can you explain what you made ? I suspect you have added a test SQL in > > > installer/data/mysql/versions/ and called it test01.sql. It's wrong, it must > > > be a number 3.09.00.014 for example (could also be 123.456, but it must be > > > numbers+. only) > > Yes, I made that file. Instead of such an error message, I would propose > > just to ignore files that do not match the numbering scheme. Perhaps mark > > them as inappropriate on the new updatedatabase form, or so. (In a folder > > you can always expect files with other names..) Will return to that too soon. > If someone submit a patch including a file with a wrong name it won't pass > QA, that's as simple as that, I'm not sure it's needed to check for the > format. I think it would be best to catch that error and inform the user there is an incorrectly named file. The goal is to lower the barrier to entry for developers, and if a developer doesn't understand the correct naming scheme, they should get useful feedback ("a file with an invalid name was provided") instead of a scary error. > Also note that, when the patch will be pushed, i'll start a wiki page where > ppl, when submitting a patch with a DB update, will be able to mark/reserve > a number to avoid having a conflict. And if a number does not make his way > into Koha finally, that's not a big problem, we can let the number empty or > create a fake DB update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 13:39:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 11:39:37 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #68 from M. de Rooy --- (In reply to comment #67) > I think it would be best to catch that error and inform the user there is an > incorrectly named file. The goal is to lower the barrier to entry for > developers, and if a developer doesn't understand the correct naming scheme, > they should get useful feedback ("a file with an invalid name was provided") > instead of a scary error. I am still working on this report. But in advance: I think we should have two sets of dbrevs: the numbered ones belonging to approved, pushed patches and unnumbered ones, belonging to patches in dev stage. These last set should only be available in dev mode and can (theoretically) be executed in any order. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 13:46:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 11:46:46 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 --- Comment #69 from Jared Camins-Esakov --- (In reply to comment #68) > (In reply to comment #67) > > I think it would be best to catch that error and inform the user there is an > > incorrectly named file. The goal is to lower the barrier to entry for > > developers, and if a developer doesn't understand the correct naming scheme, > > they should get useful feedback ("a file with an invalid name was provided") > > instead of a scary error. > > I am still working on this report. But in advance: I think we should have > two sets of dbrevs: the numbered ones belonging to approved, pushed patches > and unnumbered ones, belonging to patches in dev stage. These last set > should only be available in dev mode and can (theoretically) be executed in > any order. That makes sense to me. If everything has to have a numeric dbrev, even code that might not ever work well enough to make it into Koha, we might as well just continues to use the current updatedatabase.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 13:54:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 11:54:24 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Created attachment 10257 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10257&action=edit SearchEngine: Add a Koha::SearchEngine module First draft introducing solr into Koha :-) List of files : $ tree t/searchengine/ t/searchengine |-- 000_conn | `-- conn.t |-- 001_search | `-- search_base.t |-- 002_index | `-- index_base.t |-- 003_query | `-- buildquery.t |-- 004_config | `-- load_config.t `-- indexes.yaml just do `prove -r t/searchengine/**/*.t` t/lib |-- Mocks | `-- Context.pm `-- Mocks.pm provide a mock to SearchEngine syspref (set_zebra and set_solr). $ tree Koha/SearchEngine Koha/SearchEngine |-- Config.pm |-- ConfigRole.pm |-- FacetsBuilder.pm |-- FacetsBuilderRole.pm |-- Index.pm |-- IndexRole.pm |-- QueryBuilder.pm |-- QueryBuilderRole.pm |-- Search.pm |-- SearchRole.pm |-- Solr | |-- Config.pm | |-- FacetsBuilder.pm | |-- Index.pm | |-- QueryBuilder.pm | `-- Search.pm |-- Solr.pm |-- Zebra | |-- QueryBuilder.pm | `-- Search.pm `-- Zebra.pm How to install and configure Solr ? See the wiki page: http://wiki.koha-community.org/wiki/SearchEngine_Layer_RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 14:47:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 12:47:13 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10245|0 |1 is obsolete| | --- Comment #32 from Jonathan Druart --- Created attachment 10258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10258&action=edit Bug 5342: Followup Delete tags for letters which are not html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 15:37:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 13:37:54 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 --- Comment #8 from Marc V?ron --- Tried to apply the patch and got: "fatal: cannot convert from UTF-8utf-8 to UTF-8" In the header of the patch the Content-Type appears twice: (...) Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" (...) This was not the case in the previous patch, it was only: (...) Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit (...) So my guess is that the double Content-Type header is the reason for the error. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 15:51:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 13:51:26 +0000 Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 --- Comment #9 from Jonathan Druart --- (In reply to comment #8) Hi Ian, Yes you are right, it is not very clean. But... it is Koha and I cannot find 10 days to rewrite completely an Authorised Values module. I don't know how filter authorised values functions of the branch level without adding a join on each SELECT query. The authorised value management is, for me, one of the most dirty part of Koha and it could be difficult to make something clean. Likewise, I do not know how it is possible to filter elements simply (here AV, borrower attributes, categories, what else do you think about ?), with the current code of Koha. > I'd like to see clean, well thought out approach that can handle these use cases and many others with one approach How do you see this approach ? Thanks for your review :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 16:13:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 14:13:05 +0000 Subject: [Koha-bugs] [Bug 8181] Replace DynArch calendar widget with jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 --- Comment #1 from Owen Leonard --- Created attachment 10259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10259&action=edit Bug 8181 - Replace DynArch calendar widget with jQueryUI version All instances of the old DynArch calendar have been replaced with jQueryUI versions and the old library files have been removed. There is now a helper function in staff-global.js for triggering a datepicker prompt on any input field. Just add a "datepicker" class to the input field. If you would like two fields in one from to limit each other (one is date from, one is date to), add these classes to each: "datepickerfrom" and "datepickerto." This will prevent an invalid entry, e.g. a date in the latter which falls before the former. jQueryUI is now upgraded to the latest verision, 1.8.21. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 16:18:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 14:18:29 +0000 Subject: [Koha-bugs] [Bug 8181] Replace DynArch calendar widget with jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Owen Leonard --- A couple of notes: This patch re-introduces a couple of image files which are used by the jQueryUI library in general. The datepicker uses some elements of the image sprite. If subsequent jQuery modules don't use other elements of the sprite it might be worth a follow-up to remove it in favor of an alternative style. This patch moves some of the CSS introduced in previous jQueryUI patches out of staff-global.css and into jquery-ui.css in order to make it a more generalized Koha theme. Here is a list of pages modified by this patch: includes/checkouts-table-footer.inc (used by circulation.pl and moremember.pl (renewal due date)) acqui/histsearch.tt acqui/lateorders.tt acqui/parcels.tt admin/aqbudgetperiods.tt admin/aqcontract.tt admin/categorie.tt admin/smart-rules.tt circ/circulation.tt circ/overdue.tt circ/pendingreserves.tt circ/reserveratios.tt labels/search.tt members/memberentrygen.tt members/moremember.tt reports/acquisitions_stats.tt reports/bor_issues_top.tt reports/borrowers_out.tt reports/borrowers_stats.tt reports/cat_issues_top.tt reports/catalogue_stats.tt reports/dictionary.tt reports/guided_reports_start.tt reports/issues_avg_stats.tt reports/issues_by_borrower_category.tt reports/issues_stats.tt reports/reserves_stats.tt reports/stats_screen.tt reserve/request.tt serials/checkexpiration.tt serials/claims.tt serials/subscription-add.tt suggestion/suggestion.tt tags/review.tt tools/cleanborrowers.tt tools/export.tt tools/holidays.tt tools/inventory.tt tools/koha-news.tt tools/modborrowers.tt tools/scheduler.tt tools/viewlog.tt opac-reserve.tt opac-user.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 16:25:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 14:25:07 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #70 from M. de Rooy --- QA comment: Larger patch with greater impact. Good work! Code generally looks good. Nice idea. Will make testing patches with dbrevs easier. Because of the impact of this patch, I think that we still need some adjustments before it passes qa. The points below may look like a lot of work, but will not need that much code changes. I believe that it can be done within some hours. (Please note that I would really LIKE to see this feature be pushed soon!) I change status to In Discussion and will ask for input from the dev list. Before you change the patch, it would be good to have some additional community consensus about it (when given). My main (functional) point is actually: make a distinction between numbered dbrevs (from master) and unnumbered dbrevs (from test patches or custom development). An upgrade should always run the numbered dbrevs in linear order. The unnumbered ones can be executed in any order from the new update form if you are in dev mode. This makes a wiki with picking dbrev numbers unneeded. The RM still takes care of the numbering (rename a file). A developer just adds a file without dbrev number in a new patch, perhaps referrring to a bug report. There will be no gaps in the numbering scheme. About lists the correct official Koha version and the applied 'custom' dbrevs. YAML: As I understand, the idea was initially to have dbrevs in a yaml file. In the current implementation, only the version dir is in that file. Additionally, you do not use the dirload, only the fileload. For simplicity, I recommend to remove the YAML file and associated code. The versions directory can be hardcoded in my opinion within the install/data.. region. I would suggest to rename it to dbrev or something similar, and have numbered version subdirectories within it. Example: This will eventually lead to dirs and files like dbrevs/3.09/3.09.00.001.sql or dbrevs/3.10/3.10.02.003.pl, etc. Development mode: Currently, you rely on $ENV{DEBUG} from koha-httpd file. I would turn this into a systempref. It is easier for developers to toggle it (compared to restarting httpd service). Skeleton: I see it in a regex as well as some code inserting into foo. Assume that it was used in testing. Please remove it. In actual use, you will find enough examples to find your way. Or just put some comments into a readme file. Mainpage: Some code was removed from Auth.pm. The version check is now in mainpage.pl itself. I would rather have that check in an appropriate module. It was in Auth.pm. You could leave it there? I think we should let the version check stay within the scope of the checkauth call included in the get_user_and_template call. (See also comment on Auth.pm below). Authorization (Auth.pm): I agree that if a user already logged in, it is not needed to check the version every time. The ("new") initial check in checkauth if the db contains a version, is fine. The former moment of the "complete" version check was too early. I think we should leave it in checkauth, but do it at a later moment: If we start a new session and we verified the password, then we should do the extended version check (database versus kohaversion.pl). That is close to line 748 in the adjusted Auth.pm (depending on the value of $return). This will prevent Koha from checking it every time, but only for a new session. If the version check fails at that moment, we should redirect to installer step 3 (updatestructure). Note that there is some problem in current code, that forces me to login twice when there is an update available. (It redirects to admin/updatedatabase, but I must relogin again.) Please correct. Probably you should only pass the $cookie in your redirect call too. Like: print $query->redirect(-uri=>"/cgi-bin/koha/admin/updatedatabase.pl",-cookie=>$cookie); Upgrading: When coming from an older version (before 3.9.0.x), you should run the old updatedatabase and after that you should run the new dbrevs in the dbrev directories. This is currently done in two passes. First it runs the old update. You think that it is ready. When you login, you are prompted to the new update form. It should not be too difficult to merge this into one pass (less confusing). Please adjust install.pl for that: You should check if it is still needed to call the old update before running the new one (for numbered dbrevs only). Update form: Since numbered dbrevs are run via installer, only allow executing unnumbered dbrevs here (in dev mode). In normal mode, you can only browse history here. (I would suggest to not even show the unnumbered dbrevs if you are in normal mode.) File structure: As mentioned above, make directories for a Koha release. Getting all updates means fetching the updates from a few directories. This makes the feature more future-proof. Stable version: The md5 test will be of good use here! If we backport this to 3.8.X, we could already check what updates we already have run from 3.9 folder with the md5 checksum. When upgrading from 3.8 to 3.10, some dbrevs are new, others will be incorporated already. So this remark only serves the purpose of discussing "Should we also get this into stable already (within reasonable time)?". admin/updatedatabase.pl: Line 33 adds a fixme to new code: Add a new flag? Commit message: please make it up-to-date. E.g. section on installdir. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 16:50:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 14:50:05 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 17:33:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 15:33:35 +0000 Subject: [Koha-bugs] [Bug 8243] New: calendar being ignored Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8243 Priority: P5 - low Change sponsored?: --- Bug ID: 8243 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: calendar being ignored Severity: critical Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha When calculating due dates and fine amounts it appears that in 3.8.1 Koha is ignoring the calendar and making things due on days the library is closed and charging fines for closed days even if the settings say not to. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 18:13:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 16:13:10 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10022|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize --- Created attachment 10260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10260&action=edit [SIGNED] Bug 7671 - add a real primary key "accountlinesid" in accountlines Hmm, That's strange, not seen that before. Just format-patched it again and the header seems correct this time. How odd.. New patch attached. Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 18:13:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 16:13:25 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 18:14:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 16:14:23 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10260|[SIGNED] Bug 7671 - add a |Bug 7671 - add a real description|real primary key |primary key |"accountlinesid" in |"accountlinesid" in |accountlines |accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 18:14:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 16:14:33 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 20:06:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 18:06:09 +0000 Subject: [Koha-bugs] [Bug 7367] General OPAC typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367 Albert Oller changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ago at bywatersolutions.com --- Comment #11 from Albert Oller --- opac-suggestions.pl?op=add currently: Only the title is required, but the more information you enter the easier it will be for the librarians to find title you're requesting. should be: Only the title is required, but the more information you enter the easier it will be for the librarians to find the title you're requesting. missing "the" before "title you're requesting." Adding this as note, I haven't fixed it yet because I hosed my Koha, and need to rebuild. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 20:41:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 18:41:44 +0000 Subject: [Koha-bugs] [Bug 8243] calendar being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8243 --- Comment #1 from Nicole C. Engard --- I don't know if this is related but grace periods are also being ignored. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 20:49:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 18:49:09 +0000 Subject: [Koha-bugs] [Bug 5161] patron attributes clearing if error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5161 --- Comment #2 from Nicole C. Engard --- The same thing happens if you get a warning about the patron being a duplicate. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 13 21:07:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 19:07:56 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 --- Comment #10 from Marc V?ron --- Sorry, Martin, but now I have error: patch failed: installer/data/mysql/updatedatabase.pl:5308 error: installer/data/mysql/updatedatabase.pl: patch does not apply Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 00:00:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 22:00:45 +0000 Subject: [Koha-bugs] [Bug 7943] Untranslatable strings in OPAC's authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7943 --- Comment #1 from Jared Camins-Esakov --- Created attachment 10261 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10261&action=edit Bug 7943: Authority search results are untranslatable The HTML for authority search results was previously generated in C4::AuthoritiesMarc::BuildSummary, which meant that it couldn't be translated. This patch moves the HTML generation into the templates by introducing a new authorities-search-results.inc include file for both the OPAC and the Intranet which contains a Template::Toolkit BLOCK for rendering the authority results. Fixes the authority autocomplete by removing the untranslatable strings, and returning only data from the database. To test: 1. Apply patch. 2. Test authority searching in the authority module in the staff client 3. Test authority searching in the authority control plugin in the cataloguing module (and the plugin for UNIMARC field 210$c, if you can figure out how) 4. Test authority searching in the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 00:01:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 22:01:53 +0000 Subject: [Koha-bugs] [Bug 7943] Untranslatable strings in OPAC's authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7943 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Change sponsored?|--- |Sponsored Assignee|frederic at tamil.fr |jcamins at cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 00:09:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 22:09:38 +0000 Subject: [Koha-bugs] [Bug 7475] Option to overlay authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7475 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2060 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 00:09:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 22:09:38 +0000 Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff Client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7475 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 00:24:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 22:24:26 +0000 Subject: [Koha-bugs] [Bug 7475] Option to overlay authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7475 --- Comment #1 from Jared Camins-Esakov --- Created attachment 10262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10262&action=edit Bug 7475: Enable authority overlay This patch does the following: * Completes authority support within Koha's import batch code * Completes authority support in Koha's matching rule code * Exposes the ability to stage and commit batches of authorities using the renamed scripts misc/stage_file.pl and misc/commit_file.pl To test: 1. Find a file of authorities (a sample file with MARC21 authorities is attached to bug 7475) and download it to your server 2. Stage the file using the following command (replace with the name of the file you saved in step 1): > misc/stage_file.pl --file --authorities 3. Note the batch number the script assigns to your batch 4. Commit the records using the following command (replace with the batch number you made note of in step 3): > misc/commit_file.pl --batch-number 5. Index the authorities Zebraqueue (or wait) 6. Confirm that the new authorities appear. 7. Revert the import with the following command: > misc/commit_file.pl --batch-number --revert 8. Index the authorities Zebraqueue (or wait) 9. Confirm that the records have been removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 00:24:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 22:24:52 +0000 Subject: [Koha-bugs] [Bug 7475] Option to overlay authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7475 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 01:23:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 23:23:54 +0000 Subject: [Koha-bugs] [Bug 7475] Option to overlay authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7475 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10262|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov --- Comment on attachment 10262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10262 Bug 7475: Enable authority overlay False alarm, sorry. This was the wrong patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 01:24:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 23:24:43 +0000 Subject: [Koha-bugs] [Bug 7475] Option to overlay authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7475 --- Comment #3 from Jared Camins-Esakov --- Created attachment 10263 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10263&action=edit Example authority record Example authority record (version 1) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 01:25:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 23:25:23 +0000 Subject: [Koha-bugs] [Bug 7475] Option to overlay authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7475 --- Comment #4 from Jared Camins-Esakov --- Created attachment 10264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10264&action=edit Example authority record Example authority record (version 2) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 01:27:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 23:27:03 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 --- Comment #2 from Jared Camins-Esakov --- Created attachment 10265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10265&action=edit Bug 6720: Display the authority type in OPAC Due to a peculiarity in the way SearchAuthorities worked, the authority search results on the OPAC always listed the authority type that the user searched for, rather than the authority type of the results. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 01:27:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 23:27:29 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 01:28:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 23:28:53 +0000 Subject: [Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 --- Comment #1 from Jared Camins-Esakov --- Created attachment 10266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10266&action=edit Bug 8206: Specify index in OPAC authority search Adds a dropdown to allow the user to choose to search the 'mainentry,' 'match-heading,' and 'see-from' indexes, in addition to the 'any' index which is the default. To test (you will need authority records with see-from and see-also headings): 1. Go to the browse subjects and authors section in the OPAC 2. Do a search for a fairly generic term that is used as a see-also term in a lot of records. Note that your search results include both the record that you wanted and all the other records that refer to it. 3. Apply the patch. 4. Repeat the search from step 2. Notice there is no change to the results. 5. Repeat the search from step 2, but choose "in main entry" and observe that you are now only seeing authority records with the search entered in their main entry. 6. Repeat the search from step 2, but choose "in any heading" and observe that the results are the same as in step 2. This is intentional, so that in the future notes in authorities can be made searchable. 7. Search for an obsolete form of heading with the "in keyword" option selected. Notice what results you get. 8. Repeat the search from step 7 with the "in see from heading" option selected, and notice that the results are more specific (at least if the term you are searching for is generic enough to find false positives in keyword searches on current headings) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 01:29:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 23:29:20 +0000 Subject: [Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 01:31:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 23:31:04 +0000 Subject: [Koha-bugs] [Bug 8205] Should be possible to hide unused authorities in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205 --- Comment #1 from Jared Camins-Esakov --- Created attachment 10267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10267&action=edit Bug 8205: Add OPACShowUnusedAuthorities syspref Rather than list authorities that are not actually used by a library, this commit introduces a new syspref: OPACShowUnusedAuthorities to enable libraries to hide unused authorities in the OPAC authority browser. To test: 1) Do a search in the OPAC authority browser that brings up multiple results, including some that are used in the bibliographic database and some that are not. 2) Observe that the results include both used and unused authorities. 3) Set OPACShowUnusedAuthorities to "Do not." 4) Repeat the same search as in step 1. 5) Observe that the results no longer include unused authorities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 01:31:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 23:31:33 +0000 Subject: [Koha-bugs] [Bug 8205] Should be possible to hide unused authorities in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 01:36:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 23:36:28 +0000 Subject: [Koha-bugs] [Bug 8162] packaging scripts create user incorrectly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8162 --- Comment #5 from Jared Camins-Esakov --- Sorry, didn't notice the question. When MySQL is on the same host and the --create-db option is used on koha-create, the database users created by the script are not used by the web server because of a combination of % not matching localhost (I think), and anonymous users taking precedence over non-anonymous users in MySQL 5.5. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 01:41:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Jun 2012 23:41:22 +0000 Subject: [Koha-bugs] [Bug 7475] Option to overlay authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7475 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 02:55:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 00:55:08 +0000 Subject: [Koha-bugs] [Bug 6141] html glitches causing problems to translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 --- Comment #8 from Chris Cormack --- Patch does not apply to 3.8.x, please reformat for 3.8.x. (It contains changes to do with authorities, which haven't been pushed to 3.8.x namely <<<<<<< HEAD ======= $(document).ready(function() { yuiToolbar(); $("#addauthc,#action").empty(); }); // YUI Toolbar Functions function yuiToolbar() { etc) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 02:57:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 00:57:10 +0000 Subject: [Koha-bugs] [Bug 8178] circ/circulation.pl under plack duplicates checkout rows In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8178 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Bug fix, pushed to 3.8.x will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 02:59:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 00:59:30 +0000 Subject: [Koha-bugs] [Bug 7815] Order pickup library list by name rather than by code In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7815 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #6 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 08:46:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 06:46:14 +0000 Subject: [Koha-bugs] [Bug 8166] Adding new currencies & exchange rates if not fill any field it save blank record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8166 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 08:48:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 06:48:26 +0000 Subject: [Koha-bugs] [Bug 6855] bullet point showing in wrong place on error message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #12 from Chris Cormack --- Waiting until the follow up is added, before I push this to 3.8.x -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 08:52:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 06:52:27 +0000 Subject: [Koha-bugs] [Bug 4838] Repeated authority headings break biblio record data entry form In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4838 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.2 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 08:55:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 06:55:21 +0000 Subject: [Koha-bugs] [Bug 8201] can't change receive date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8201 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #14 from Chris Cormack --- Pushed to 3.8.x will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 09:00:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 07:00:08 +0000 Subject: [Koha-bugs] [Bug 7367] General OPAC typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 09:00:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 07:00:49 +0000 Subject: [Koha-bugs] [Bug 7367] General OPAC typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367 --- Comment #12 from M. de Rooy --- Created attachment 10268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10268&action=edit Patch for opac-suggestions template Typo found by Albert Oller. Very trivial fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 09:00:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 07:00:58 +0000 Subject: [Koha-bugs] [Bug 7367] General OPAC typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 09:01:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 07:01:07 +0000 Subject: [Koha-bugs] [Bug 7367] General OPAC typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 09:14:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 07:14:36 +0000 Subject: [Koha-bugs] [Bug 8171] Improper escaping of quotes during z39.50 queries leads to broken html In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8171 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Chris Cormack --- Pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 09:18:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 07:18:30 +0000 Subject: [Koha-bugs] [Bug 7941] Fix version numbers in modules and set up a system to keep them up to date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7941 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Chris Cormack --- Pushed to 3.8.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 09:37:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 07:37:05 +0000 Subject: [Koha-bugs] [Bug 8183] acqui/parcels.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9892|0 |1 is obsolete| | --- Comment #5 from Julian Maurice --- Created attachment 10269 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10269&action=edit [SIGNED-OFF] Bug 8183 - acqui/parcels.pl plack scoping It fixes the bug, so I signoff. But it also works by passing the $template variable to the sub, which seems cleaner to me than using global variables in subs. Why did you choose this solution ? (I'm just curious :-)) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 09:37:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 07:37:31 +0000 Subject: [Koha-bugs] [Bug 8183] acqui/parcels.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 10:09:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 08:09:22 +0000 Subject: [Koha-bugs] [Bug 8180] cataloguing/additem.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9884|0 |1 is obsolete| | --- Comment #7 from Julian Maurice --- Created attachment 10270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10270&action=edit [SIGNED-OFF] Bug 8180 - cataloguing/additem.pl plack scoping Steps to reproduce the bug: - Set autoBarcode syspref to "incremental" ("generated in the form 1, 2, 3.") - Assure you have an item subfield mapped to items.barcode - Go to cataloguing/additem.pl and add a new item leaving empty the barcode field. Signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 10:09:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 08:09:29 +0000 Subject: [Koha-bugs] [Bug 8180] cataloguing/additem.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 11:54:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 09:54:29 +0000 Subject: [Koha-bugs] [Bug 8244] New: Script to find exporter problems Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 Priority: P5 - low Change sponsored?: --- Bug ID: 8244 CC: jonathan.druart at biblibre.com Assignee: julian.maurice at biblibre.com Summary: Script to find exporter problems Severity: enhancement Classification: Unclassified OS: All Reporter: julian.maurice at biblibre.com Hardware: All Status: NEW Version: master Component: Test Suite Product: Koha About one month ago, we (BibLibre) discover a bug in our source code. The problem was: a page that used to work correctly suddenly refuse to work because of "Undefined subroutine &get_infos_of at C4/Items.pm (line 1075)" (approximative message) in reserve/request.pl The piece of code in cause was a "use C4::Members" in C4/Budgets.pm. A modification of C4::Budgets was causing reserve/request.pl to crash... (ouch!) In fact it introduced a circular dependency. To avoid this kind of discovery, we decide to write a script that try to detect as many problems as possible. Patch and description follow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 12:02:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 10:02:04 +0000 Subject: [Koha-bugs] [Bug 7571] Maintain exchange rate history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571 --- Comment #3 from Sagar.B.R --- Created attachment 10271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10271&action=edit Maintain exchange rate history Maintain exchange rate history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 12:02:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 10:02:20 +0000 Subject: [Koha-bugs] [Bug 7571] Maintain exchange rate history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571 Sagar.B.R changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #4 from Sagar.B.R --- Maintain exchange rate history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 12:12:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 10:12:41 +0000 Subject: [Koha-bugs] [Bug 8183] acqui/parcels.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183 --- Comment #6 from Dobrica Pavlinusic --- I tried to always make smallest possible change to code when introducing plack scoping. Since other patches for plack use global scoping, I opted to do it consistently instead of changing method signature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 12:18:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 10:18:57 +0000 Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 --- Comment #1 from Julian Maurice --- Created attachment 10272 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10272&action=edit Bug 8244: New script xt/find-undefined-subroutines.pl This script tends to detect if Koha scripts use subroutines that are not correctly exported by modules. This can happen when we have circular dependencies between modules. This script does mainly two things: - It rebuilds the hierarchy of Koha Perl modules and replace all the code within subroutines by tests (using Test::More). For each subroutine called in a subroutine, a test is done on if the called subroutine is defined. If it's defined, then it's called (Tested subroutines are only those available in Koha Perl modules, not external modules subroutines). It does almost the same work with Koha Perl scripts, replacing all the code by tests and calling the subroutines if defined. - Launch prove on all created Perl scripts. This results in a summary where failed tests are subroutines that are not exported, but called without the module name prepended. -- To use it: xt/find-undefined-subroutines.pl --src-path /path/to/koha --dest-path /another/path [-v] If you launch it on current master, you will find that almost all scripts return that GetMember is not defined in C4/Auth.pm. Indeed, line 154, GetMember is called without the module name prepended, and before the require statement. But I tried to make this piece of code crash, without success. It seems that this is "dead code". The script doesn't test subroutines prepended by the module name (we assume that they should work in every case, even when there are circular dependencies) so you could temporarily hide these messages by prepending GetMember with the module name in C4::Auth::get_template_and_user Another interesting error returned by the script: in acqui/basketgroup.pl GetBookSeller is undefined. You can test by going to acqui/basketgroup.pl and remove the '?booksellerid=X' part of the url. I think it's dead code too, because fixing this bug causes another bug a little bit further. Note: in acqui/basketgroup.pl, GetBiblioData and GetItemTypes are returned as not defined too, but there is no problem with them in "real code". This is because C4::Biblio and C4::Koha are imported by using require/import instead of use and this is not handled by the script (could be an enhancement). Important note: This script requires PPI module which is not a Koha dependency, but I don't think it should be because this script is only for debugging purposes and of no usefulness for end-users. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 12:19:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 10:19:59 +0000 Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 12:26:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 10:26:18 +0000 Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 --- Comment #12 from M. de Rooy --- Hi Jonathan: Just came across this sentence from Perl Best Practices: More importantly, leaving off the parentheses on subroutines makes them harder to distinguish from builtins, and therefore increases the mental search space when the reader is confronted with either type of construct. Your code will be easier to read and understand if the subroutines always use parentheses and the built-in functions always don?t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 12:33:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 10:33:54 +0000 Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9891|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall --- Created attachment 10273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10273&action=edit Bug 8043 - today's checkouts are in Previous checkouts in circulation.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 12:34:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 10:34:35 +0000 Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 12:35:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 10:35:25 +0000 Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 --- Comment #2 from Julian Maurice --- Note: this require to have $KOHA_CONF to be correctly set ($PERL5LIB is not needed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 12:40:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 10:40:32 +0000 Subject: [Koha-bugs] [Bug 7805] Exposing the new list permissions in opac and staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED --- Comment #7 from M. de Rooy --- Sending a followup for QA comments. Just housekeeping. Removed the prototypes and return undef. The obsolete code of each_biblionumbers has been removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 12:48:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 10:48:53 +0000 Subject: [Koha-bugs] [Bug 7805] Exposing the new list permissions in opac and staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 --- Comment #8 from M. de Rooy --- Test the patch (with call to GetShelf and GetShelfContents) by going to Lists and doubleclicking a list to see its contents (in opac or staff). Does it work? No warnings in your log too? You are ready to sign off ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 12:49:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 10:49:52 +0000 Subject: [Koha-bugs] [Bug 7805] Exposing the new list permissions in opac and staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 --- Comment #9 from M. de Rooy --- Created attachment 10274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10274&action=edit Patch for perlcritic comments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 12:50:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 10:50:36 +0000 Subject: [Koha-bugs] [Bug 7805] Exposing the new list permissions in opac and staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9805|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 12:51:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 10:51:20 +0000 Subject: [Koha-bugs] [Bug 7805] Exposing the new list permissions in opac and staff In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7805 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 12:52:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 10:52:34 +0000 Subject: [Koha-bugs] [Bug 8245] New: in acqui-home.pl with hierarchic bugdets the calculation of a sum spent in sub-budget is not in the budget Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8245 Priority: P5 - low Change sponsored?: --- Bug ID: 8245 Assignee: koha-bugs at lists.koha-community.org Summary: in acqui-home.pl with hierarchic bugdets the calculation of a sum spent in sub-budget is not in the budget Severity: enhancement Classification: Unclassified OS: All Reporter: christophe.croullebois at biblibre.com Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha Created attachment 10275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10275&action=edit snapshot of budgets in acqui-home.pl See snapshot, in "Spent" column, the parent budget "hist" have "0", must have "136,50", because "histjeun" and "histvieil" are its sub-budgets. Big work to do... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 13:35:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 11:35:51 +0000 Subject: [Koha-bugs] [Bug 6141] html glitches causing problems to translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 --- Comment #9 from Kyle M Hall --- Created attachment 10276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10276&action=edit Bug 6141 - html glitches causing problems to translator - 3.8.x * opac-topissue.pl = untranslatable string removed * authorities.pl missing _() in javascript Rewrite of patch authored by Julian Maurice. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 13:37:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 11:37:01 +0000 Subject: [Koha-bugs] [Bug 6141] html glitches causing problems to translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 --- Comment #10 from Kyle M Hall --- Chris, here you go. Does this need to go through so and qa? (In reply to comment #8) > Patch does not apply to 3.8.x, please reformat for 3.8.x. > > (It contains changes to do with authorities, which haven't been pushed to > 3.8.x namely > > <<<<<<< HEAD > ======= > $(document).ready(function() { > yuiToolbar(); > $("#addauthc,#action").empty(); > }); > // YUI Toolbar Functions > function yuiToolbar() { > > etc) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 13:41:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 11:41:48 +0000 Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from M. de Rooy --- Checked the revised patch. All points mentioned before got attention. As well as adding Datatables and a check on existing borrower. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 13:48:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 11:48:08 +0000 Subject: [Koha-bugs] [Bug 8025] Patron attribute not selected if value is zero In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8025 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_6 --- Comment #4 from Jared Camins-Esakov --- This patch will be in 3.6.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 13:48:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 11:48:42 +0000 Subject: [Koha-bugs] [Bug 3413] repeatable tickbox not sticking 1st time round In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3413 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_6 --- Comment #8 from Jared Camins-Esakov --- This patch will be in 3.6.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 13:49:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 11:49:18 +0000 Subject: [Koha-bugs] [Bug 2399] All status fields in the item edit interface offer two blank/null entries per dropdown instead of one In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2399 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_6 --- Comment #12 from Jared Camins-Esakov --- This patch will be in 3.6.6. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 13:49:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 11:49:40 +0000 Subject: [Koha-bugs] [Bug 7987] Typo causing invalid markup in circulation.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7987 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_6 --- Comment #4 from Jared Camins-Esakov --- This patch will be in 3.6.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 13:49:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 11:49:58 +0000 Subject: [Koha-bugs] [Bug 7929] Duplicate id "availability" on XSLT result page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7929 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_6 --- Comment #8 from Jared Camins-Esakov --- This patch will be in 3.6.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 13:50:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 11:50:19 +0000 Subject: [Koha-bugs] [Bug 8008] Fix typo in man page for koha-create In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8008 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_6 --- Comment #5 from Jared Camins-Esakov --- This patch will be in 3.6.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 13:50:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 11:50:37 +0000 Subject: [Koha-bugs] [Bug 7990] bad html attribute into aqplan.tt : styl= insted of style= In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7990 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_6 --- Comment #4 from Jared Camins-Esakov --- This patch will be in 3.6.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 13:52:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 11:52:10 +0000 Subject: [Koha-bugs] [Bug 7820] Missing packages from install_misc/debian.packages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7820 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_10 |rel_3_6 --- Comment #8 from Jared Camins-Esakov --- This patch will be in 3.6.6. Even though it adds some unnecessary packages, it also adds some that are necessary for 3.6.x (Modern::Perl). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 13:52:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 11:52:39 +0000 Subject: [Koha-bugs] [Bug 8022] Permissions test doesn't check all languages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8022 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_6 --- Comment #5 from Jared Camins-Esakov --- This patch will be in 3.6.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 13:53:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 11:53:52 +0000 Subject: [Koha-bugs] [Bug 7213] Document /svc/ HTTP API and provide example command-line client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7213 --- Comment #20 from Jared Camins-Esakov --- As the /svc/ API already existed in 3.6.x, having documentation would be useful. This patch will be in 3.6.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 13:54:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 11:54:50 +0000 Subject: [Koha-bugs] [Bug 7722] Insidious problem with searching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7722 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_6 --- Comment #8 from Jared Camins-Esakov --- This patch will be in 3.6.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 13:55:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 11:55:19 +0000 Subject: [Koha-bugs] [Bug 8201] can't change receive date In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8201 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_6 --- Comment #15 from Jared Camins-Esakov --- This patch will be in 3.6.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 13:56:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 11:56:00 +0000 Subject: [Koha-bugs] [Bug 7548] Missing arguments in the pagination of receptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7548 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Jared Camins-Esakov --- This patch will be in 3.6.6. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 13:56:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 11:56:16 +0000 Subject: [Koha-bugs] [Bug 7548] Missing arguments in the pagination of receptions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7548 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 13:56:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 11:56:56 +0000 Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10273|0 |1 is obsolete| | --- Comment #12 from Nicole C. Engard --- Created attachment 10277 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10277&action=edit [SIGNED-OFF] Bug 8043 - today's checkouts are in Previous checkouts in circulation.pl Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 14:02:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 12:02:05 +0000 Subject: [Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10126|0 |1 is obsolete| | --- Comment #12 from Dobrica Pavlinusic --- Created attachment 10278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10278&action=edit Bug 7952 - followup to fix t/Creators.t Since we are now using temporary file, we are creating test.pdf at end of test and checking if it exists and have non-zero size. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 14:04:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 12:04:17 +0000 Subject: [Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 14:06:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 12:06:23 +0000 Subject: [Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #14 from Kyle M Hall --- This patch has stripped the hour/minute portion of the date due out on circulation.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 14:10:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 12:10:38 +0000 Subject: [Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #15 from Nicole C. Engard --- This patch appears to have removed the time from the list of checkouts - the time is necessary for hourly loans .... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 14:11:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 12:11:15 +0000 Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7444 --- Comment #13 from Nicole C. Engard --- The one problem here is related to bug 7444 and that's that the time has been removed. The timestamp was there because of hourly loans and needs to be there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 14:11:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 12:11:15 +0000 Subject: [Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8043 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 14:12:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 12:12:32 +0000 Subject: [Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 --- Comment #16 from Nicole C. Engard --- Created attachment 10279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10279&action=edit timestamp This is the timestamp that was there in 3.8.1 and needs to be put back ... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 14:15:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 12:15:13 +0000 Subject: [Koha-bugs] [Bug 8062] Cart email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 --- Comment #19 from Jared Camins-Esakov --- The patch for this major bug will require a few things for inclusion in 3.6.x: 1. A new patch that does not conflict on koha-tmpl/opac-tmpl/prog/en/modules/opac-sendbasket.tt 2. A follow-up patch that adds instructions for installing the new Perl module via CPAN and/or the debian.koha-community.org apt repository 3. A packaged version of libtemplate-plugin-htmltotext-perl for the oldstable distribution on debian.koha-community.org 4. An explanation of what the new dependency is required for so that I can put it in the release notes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 14:17:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 12:17:39 +0000 Subject: [Koha-bugs] [Bug 6027] Delete biblios if deleting all their items in batch deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 --- Comment #17 from Nicole C. Engard --- I'm going to have to add to this. The feature works, but only on small batches I saved the report of withdrawn titles, and when I ran it I got a message saying the list was too long to display individual barcodes, but all titles would be deleted. I did not get the checkbox with the choice of "Delete records if no items remain". I do see this checkbox is I'm loading in a smaller file though. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 14:37:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 12:37:16 +0000 Subject: [Koha-bugs] [Bug 8062] Cart email broken for non english templates In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062 --- Comment #20 from Fr?d?ric Demians --- I have no time now for your points 1-3. > 4. An explanation of what the new dependency is required for so that I > can put it in the release notes. With Template::Plugin::HtmlToText, it's possible to transform HTML into Text! as suggested by the module name. It allows Koha developers to use standard (for Koha) Template::Toolkit templating system to generate HTML, and then, if necessary to transform this HTML into raw text. This is required for example for email sent by Koha, which use to be in Text. Benefits: --email templates can have a rich HTML-base layout, but still being sent in Text ; --email templates are translatable like Koha web pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 14:46:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 12:46:13 +0000 Subject: [Koha-bugs] [Bug 8189] checkout history link gives error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8189 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Kyle M Hall --- Melia, I cannot reproduce this bug in either the 3.8.x branch, or in master. This means either the bug has been resolved, or my server is not set up in such a way as to cause the bug to reveal itself. Can you provide some more details? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 14:50:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 12:50:37 +0000 Subject: [Koha-bugs] [Bug 8180] cataloguing/additem.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #8 from Jonathan Druart --- I can't reproduce with: - syspref autoBarcode=incremental (generated in the form 1, 2, 3.) - items.barcode mapped with 995$f mysql> select kohafield, frameworkcode from marc_subfield_structure where tagfield=995 and tagsubfield='f'; +---------------+---------------+ | kohafield | frameworkcode | +---------------+---------------+ | items.barcode | | | items.barcode | ACQ | - I can edit and create items on a biblio which already contains (or not) items So I can't passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 14:52:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 12:52:28 +0000 Subject: [Koha-bugs] [Bug 7857] database upgrade fails with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7857 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m QA Contact|koha.sekjal at gmail.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:11:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:11:37 +0000 Subject: [Koha-bugs] [Bug 6027] Delete biblios if deleting all their items in batch deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 --- Comment #18 from Kyle M Hall --- Nicole, could you open a new bug for this problem and put it in the see also on this bug? Thanks, Kyle (In reply to comment #17) > I'm going to have to add to this. The feature works, but only on small > batches > > I saved the report of withdrawn titles, and when I ran it I got a message > saying the list was too long to display individual barcodes, but all titles > would be > deleted. I did not get the checkbox with the choice of "Delete records if no > items remain". > > I do see this checkbox is I'm loading in a smaller file though. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:15:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:15:28 +0000 Subject: [Koha-bugs] [Bug 7857] database upgrade fails with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7857 --- Comment #10 from Jonathan Druart --- I don't know if it's normal but I have another error : Can't locate InstallAuth.pm in @INC (@INC contains: /home/koha/src /etc/perl /usr/local/lib/perl/5.14.2 /usr/local/share/perl/5.14.2 /usr/lib/perl5 /usr/share/perl5 /usr/lib/perl/5.14 /usr/share/perl/5.14 /usr/local/lib/site_perl .) at /home/koha/src/installer/install.pl line 7. BEGIN failed--compilation aborted at /home/koha/src/installer/install.pl line 7 (#1) I start plack like this: KOHA_CONF=/home/koha/etc/koha-conf.xml PERL5LIB=/home/koha/src; plackup --reload intranet.psgi --port=5001 I don't get this error if I start like: KOHA_CONF=/home/koha/etc/koha-conf.xml PERL5LIB=/home/koha/src:/home/koha/src/installer plackup --reload intranet.psgi --port=5001 But it it that we want ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:16:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:16:27 +0000 Subject: [Koha-bugs] [Bug 7857] database upgrade fails with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7857 --- Comment #11 from Jonathan Druart --- Replace last sentence with: But is it what we want ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:17:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:17:11 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 --- Comment #10 from Paul Poulain --- (In reply to comment #6) > It should be put in the coding guidelines that using is not > the best way to add load events to a page. Generally the event should be > added to the jQuery $document(ready)() function. That lets jQuery handle all > the onload events and helps prevent conflicts. I think a follow-up for this > should be submitted to change this and ask that this not be pushed to 3.8. Done: http://wiki.koha-community.org/wiki/Coding_Guidelines#don.27t_use_js_in_.3Cbody_onload.3D....3E -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:20:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:20:23 +0000 Subject: [Koha-bugs] [Bug 6855] bullet point showing in wrong place on error message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6855 --- Comment #13 from Paul Poulain --- (In reply to comment #11) > If the patch adds a call to "url(../../img/dialog-bg.gif)" in the CSS then > it is a regression of Bug 6865 which removed all such calls to background > gradient images. It's not a big deal, but it requires a follow-up to correct > it. As you're the author of the patch, I suppose you plan to write the follow-up? Please confirm, (or I can revert this patch if you prefer) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:28:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:28:01 +0000 Subject: [Koha-bugs] [Bug 2720] Fines that debar automatically, should undebar automatically when paid. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #2 from Kyle M Hall --- Right now, Koha debars a borrower when borrowers.debarred is set to a date ( which is the date the borrower's debarment will expire ). An optional comment is stored in borrowers.debarredocmment. Since there are numerous reasons for debarment, not just fines, but overdues, or a manual debarment, I imagine the best way to go about this is to add a table borrower_debarment which would have the fields borrowernumber, reason, date, comment. Reason would be an enumerated data type such as fines, overdues, and manual. When a borrowers fines go over the limit, a debarment for the borrower would go into this table. The same for overdues and manual debarment. If a borrower has a least one row in this table, they will be debarred. Paying fines will automatically remove a fines debarment, and returning overdue books will automatically remove an overdues debarment. This would require modifying all code that involves debarring, in particular C4::Overdues::CheckBorrowerDebarred, the borrower editing page, and the circulation pages. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:37:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:37:04 +0000 Subject: [Koha-bugs] [Bug 7367] General OPAC typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart at biblibre.co | |m --- Comment #13 from Jonathan Druart --- Trivial patch. Marking as Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:41:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:41:54 +0000 Subject: [Koha-bugs] [Bug 7686] Tax rate wrong calculation in reception summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7686 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Depends on| |5335 --- Comment #6 from Jonathan Druart --- Please verify that this issue is not fixed by patch for Bug 5335 before continuing the workflow of this bug. Bug 5335 has already been rebased a lot of time and it is very difficult to do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:41:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:41:54 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7686 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:43:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:43:54 +0000 Subject: [Koha-bugs] [Bug 7495] Tax calculations problem for new orders. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7495 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m Depends on| |5335 --- Comment #3 from Jonathan Druart --- Please verify that this issue is not fixed by patch for Bug 5335 before continuing the workflow of this bug. Bug 5335 has already been rebased a lot of time and it is very difficult to do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:43:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:43:54 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7495 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:44:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:44:19 +0000 Subject: [Koha-bugs] [Bug 6965] Tax and dicount rate should be formatted the same In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #1 from Jonathan Druart --- Please verify that this issue is not fixed by patch for Bug 5335 before continuing the workflow of this bug. Bug 5335 has already been rebased a lot of time and it is very difficult to do it. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:44:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:44:21 +0000 Subject: [Koha-bugs] [Bug 5337] acq EAN search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #37 from Paul Poulain --- trivial patch, pushing immediately -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:44:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:44:32 +0000 Subject: [Koha-bugs] [Bug 6965] Tax and dicount rate should be formatted the same In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6965 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5335 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:44:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:44:32 +0000 Subject: [Koha-bugs] [Bug 5335] More granular VAT In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6965 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:44:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:44:37 +0000 Subject: [Koha-bugs] [Bug 5337] acq EAN search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:45:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:45:01 +0000 Subject: [Koha-bugs] [Bug 5337] acq EAN search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:54:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:54:49 +0000 Subject: [Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Paul Poulain --- Trivial follow-up, make test working, will signoff/pass QA/push in one go -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:56:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:56:03 +0000 Subject: [Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 15:56:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 13:56:12 +0000 Subject: [Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 16:21:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 14:21:27 +0000 Subject: [Koha-bugs] [Bug 8180] cataloguing/additem.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 --- Comment #9 from Dobrica Pavlinusic --- I probably forgot to say that you SHOULD NOT enter barcode using plugin, but to leave it empty to trigger code path which this bug fixes. If you already have barcode or you fill it in using plugin it will not show up. Jonathan, could you please insert warn inside sub _increment_barcode to verify which framework gets passed like this: my ($tagfield,$tagsubfield) = &GetMarcFromKohaField("items.barcode",$frameworkcode); warn "## $frameworkcode $tagfield $tagsubfield"; unless ($record->field($tagfield)->subfield($tagsubfield)) { # triggers bug } In my case this warn produce "LIB 952 p" which is consistent with our configuration: mysql> select variable,value from systempreferences where variable = 'autoBarcode' ; +-------------+-------------+ | variable | value | +-------------+-------------+ | autoBarcode | incremental | +-------------+-------------+ mysql> select kohafield, frameworkcode, tagfield, tagsubfield from marc_subfield_structure where kohafield='items.barcode' and frameworkcode='LIB' ; +---------------+---------------+----------+-------------+ | kohafield | frameworkcode | tagfield | tagsubfield | +---------------+---------------+----------+-------------+ | items.barcode | LIB | 952 | p | +---------------+---------------+----------+-------------+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 16:47:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 14:47:32 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Stefano Bargioni changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bargioni at pusc.it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 16:55:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 14:55:22 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:10:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:10:16 +0000 Subject: [Koha-bugs] [Bug 7382] normalization on isbn matching rule In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7382 Albert Oller changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ago at bywatersolutions.com --- Comment #3 from Albert Oller --- Hi, according to the manual: Koha only has one 'Normalization rule' that removes extra characters such as commas and semicolons. The value you enter in this field is irrelevant to the normalization process. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:12:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:12:57 +0000 Subject: [Koha-bugs] [Bug 8246] New: can't delete bibs in big batch delete Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 Priority: P5 - low Change sponsored?: --- Bug ID: 8246 Assignee: gmcharlt at gmail.com Summary: can't delete bibs in big batch delete Severity: major Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Tools Product: Koha I saved the report of withdrawn titles, and when I ran it I got a message saying the list was too long to display individual barcodes, but all titles would be deleted. I did not get the checkbox with the choice of "Delete records if no items remain". I do see this checkbox is I'm loading in a smaller file though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:13:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:13:13 +0000 Subject: [Koha-bugs] [Bug 8246] can't delete bibs in big batch delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8246 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6027 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:13:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:13:13 +0000 Subject: [Koha-bugs] [Bug 6027] Delete biblios if deleting all their items in batch deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8246 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:13:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:13:28 +0000 Subject: [Koha-bugs] [Bug 6027] Delete biblios if deleting all their items in batch deletion In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6027 --- Comment #19 from Nicole C. Engard --- Done -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:13:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:13:43 +0000 Subject: [Koha-bugs] [Bug 8247] New: adding basket doesn't save basket name, internal and vendor note Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8247 Priority: P5 - low Change sponsored?: --- Bug ID: 8247 Assignee: koha-bugs at lists.koha-community.org Summary: adding basket doesn't save basket name, internal and vendor note Severity: major Classification: Unclassified OS: All Reporter: dpavlin at rot13.org Hardware: All Status: NEW Version: rel_3_8 Component: Acquisitions Product: Koha URL: /cgi-bin/koha/acqui/basketheader.pl?booksellerid=32&op=add_form I'm also getting mysql referential integrity error: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_srvgit`.`aqbasket`, CONSTRAINT `aqbasket_ibfk_1` FOREIGN KEY (`booksellerid`) REFERENCES `aqbooksellers` (`id`) ON UPDATE CASCADE) at /srv/koha/C4/Acquisition.pm line 416. Test scenario: 1. Find vendor and select "New basket" 2. fill in basket name, internal and vendor note 3. press save 4. verify that created basket doesn't have name nor internal or vendor notes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:15:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:15:45 +0000 Subject: [Koha-bugs] [Bug 8247] adding basket doesn't save basket name, internal and vendor note In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8247 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |dpavlin at rot13.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:18:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:18:50 +0000 Subject: [Koha-bugs] [Bug 8247] adding basket doesn't save basket name, internal or vendor note In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8247 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|adding basket doesn't save |adding basket doesn't save |basket name, internal and |basket name, internal or |vendor note |vendor note -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:19:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:19:20 +0000 Subject: [Koha-bugs] [Bug 8247] adding basket doesn't save basket name, internal or vendor note In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8247 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:20:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:20:47 +0000 Subject: [Koha-bugs] [Bug 8247] adding basket doesn't save basket name, internal or vendor note In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8247 --- Comment #1 from Dobrica Pavlinusic --- Created attachment 10280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10280&action=edit Bug 8247 - adding basket doesn't save basket name, internal or vendor note URL: /cgi-bin/koha/acqui/basketheader.pl?booksellerid=32&op=add_form I'm also getting mysql referential integrity error: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_srvgit`.`aqbasket`, CONSTRAINT `aqbasket_ibfk_1` FOREIGN KEY (`booksellerid`) REFERENCES `aqbooksellers` (`id`) ON UPDATE CASCADE) at /srv/koha/C4/Acquisition.pm line 416. Test scenario: 1. Find vendor and select "New basket" 2. fill in basket name, internal and vendor note 3. press save 4. verify that created basket doesn't have name nor internal or vendor notes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:29:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:29:09 +0000 Subject: [Koha-bugs] [Bug 8247] adding basket doesn't save basket name, internal or vendor note In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8247 Marijana Glavica changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mglavica at ffzg.hr Severity|major |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:32:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:32:17 +0000 Subject: [Koha-bugs] [Bug 8221] Adding item to patroncard Batch causes error in Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8221 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:45:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:45:48 +0000 Subject: [Koha-bugs] [Bug 8092] Koha should use CHI caching framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8092 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10093|0 |1 is obsolete| | --- Comment #12 from Jared Camins-Esakov --- Created attachment 10281 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10281&action=edit Bug 8092 follow-up: Fix perlcritic violations Apparently you are not supposed to use "return undef;" or perlcritic gets mad. Sorry, perlcritic! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:49:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:49:04 +0000 Subject: [Koha-bugs] [Bug 8092] Koha should use CHI caching framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8092 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:49:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:49:49 +0000 Subject: [Koha-bugs] [Bug 8221] Adding item to patroncard Batch causes error in Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8221 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|cnighswonger at foundations.ed |dpavlin at rot13.org |u | --- Comment #1 from Dobrica Pavlinusic --- I can't reproduce that error. Do you get that error in pop-up window which "Add item(s)" opens? I'm not very good in using Koha, so I would appreciate step-by-step test scenario to reproduce it :-) I did notice that "Remove duplicates" doesn't work for me under plack and always leave just first item in batch and it seems that Export items always exports single item, so something is fishy there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:50:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:50:03 +0000 Subject: [Koha-bugs] [Bug 8092] Koha should use CHI caching framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8092 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:52:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:52:49 +0000 Subject: [Koha-bugs] [Bug 8248] New: Invalid characters entered in bib record cause 500 error Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8248 Priority: P5 - low Change sponsored?: --- Bug ID: 8248 Assignee: gmcharlt at gmail.com Summary: Invalid characters entered in bib record cause 500 error Severity: enhancement Classification: Unclassified OS: All Reporter: steven_jeffery at fmi.com Hardware: All Status: NEW Version: rel_3_8 Component: Cataloging Product: Koha Created attachment 10282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10282&action=edit text to reproduce error Entering text with invalid characters causes Koha to return a 500 Internal Server Error in when submit is pressed. The bib record is NOT created. I am attaching a document here with text (see the English abstract) that causes this to happen. This occurs in both 3.6 and 3.8 in IE8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:52:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:52:56 +0000 Subject: [Koha-bugs] [Bug 8247] adding basket doesn't save basket name, internal or vendor note In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8247 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:54:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:54:06 +0000 Subject: [Koha-bugs] [Bug 8248] Invalid characters entered in bib record cause 500 error In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8248 SJeffery changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:55:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:55:08 +0000 Subject: [Koha-bugs] [Bug 8247] adding basket doesn't save basket name, internal or vendor note In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8247 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:56:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:56:29 +0000 Subject: [Koha-bugs] [Bug 8092] Koha should use CHI caching framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8092 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #13 from Paul Poulain --- Trivial patch, will push immediately to fix jenkins -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:56:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:56:53 +0000 Subject: [Koha-bugs] [Bug 8092] Koha should use CHI caching framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8092 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 17:57:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 15:57:07 +0000 Subject: [Koha-bugs] [Bug 8092] Koha should use CHI caching framework In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8092 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 18:01:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 16:01:02 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10260|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 10283 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10283&action=edit [REBASED] Bug 7671 - add a real primary key "accountlinesid" in accountlines Rebased again... touch wood master doesn't move on again before we're signed off. Looking forward to Bug 7167 making it into master so this becomes less of an issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 18:48:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 16:48:12 +0000 Subject: [Koha-bugs] [Bug 8249] New: can't add extra issues to prediction Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8249 Priority: P5 - low Change sponsored?: --- Bug ID: 8249 CC: colin.campbell at ptfs-europe.com Assignee: koha-bugs at lists.koha-community.org Summary: can't add extra issues to prediction Severity: normal Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Serials Product: Koha Created attachment 10284 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10284&action=edit prediction of more issues When doing a serial prediction if you enter fewer issues than expected it asks what months/weeks no issues are expected, but if you enter more than are expected it doesn't let you say which months have multiple issues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 18:54:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 16:54:01 +0000 Subject: [Koha-bugs] [Bug 8250] New: can't leave barcode blank when adding serial items Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8250 Priority: P5 - low Change sponsored?: --- Bug ID: 8250 CC: colin.campbell at ptfs-europe.com Assignee: koha-bugs at lists.koha-community.org Summary: can't leave barcode blank when adding serial items Severity: normal Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Serials Product: Koha Created attachment 10285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10285&action=edit barcode dup error If you try to leave the barcode blank when adding a serial item on the serial receive page it gives you an error about the duplicate barcode ... I agree we need to check for dups - but blanks should not count. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 20:13:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 18:13:13 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 --- Comment #12 from Marc V?ron --- - Patch applied. - Update database done. - Went to Home ? Patrons ? Account for (...) - Clicked Tab "Pay fines" Result: Global symbol "$writeoff_sth" requires explicit package name at /usr/share/kohaclone/members/pay.pl line 117. Global symbol "$add_writeoff_sth" requires explicit package name at /usr/share/kohaclone/members/pay.pl line 120. Global symbol "$writeoff_sth" requires explicit package name at /usr/share/kohaclone/members/pay.pl line 276. Global symbol "$writeoff_sth" requires explicit package name at /usr/share/kohaclone/members/pay.pl line 284. Global symbol "$add_writeoff_sth" requires explicit package name at /usr/share/kohaclone/members/pay.pl line 288. (Same errors as at the nd of my comment #6) - Switched back to Master to make sure that this is relatd to the patch - Went to Home ? Patrons ? Account for (...) - Clicked Tab "Pay fines" Result: No erros on branch Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 20:29:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 18:29:27 +0000 Subject: [Koha-bugs] [Bug 8247] adding basket doesn't save basket name, internal or vendor note In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8247 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10280|0 |1 is obsolete| | --- Comment #2 from Marc V?ron --- Created attachment 10286 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10286&action=edit [SIGNED-OFF] Bug 8247 - adding basket doesn't save basket name, internal or vendor note URL: /cgi-bin/koha/acqui/basketheader.pl?booksellerid=32&op=add_form I'm also getting mysql referential integrity error: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_srvgit`.`aqbasket`, CONSTRAINT `aqbasket_ibfk_1` FOREIGN KEY (`booksellerid`) REFERENCES `aqbooksellers` (`id`) ON UPDATE CASCADE) at /srv/koha/C4/Acquisition.pm line 416. Test scenario: 1. Find vendor and select "New basket" 2. fill in basket name, internal and vendor note 3. press save 4. verify that created basket doesn't have name nor internal or vendor notes Signed-off-by: Marc Veron First tested without patch applied, new basket's name and internal / vendor notes were empty- Applied patch, new basket's name and notes behave OK. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 20:37:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 18:37:57 +0000 Subject: [Koha-bugs] [Bug 8247] adding basket doesn't save basket name, internal or vendor note In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8247 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 21:19:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 19:19:47 +0000 Subject: [Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jcamins at cpbibliography.com, | |koha.sekjal at gmail.com --- Comment #13 from Ian Walls --- There is a way of marking Perl modules as optional or required in C4/Installer/PerlDependencies.pm. If it's not required, one adds a note about what feature or context it could be used in. Looks like this module is indeed packaged for Debian (or at least old Ubuntu), so it wouldn't give us too many problems there. But I'd like to avoid new dependencies wherever possible, as it makes it that much harder to install Koha, and adds one more piece of the puzzle that we don't have direct control over. What's the goal of Test::MockModule? What is it doing, and how? jcamins is working on a testing suite using HTML::Recorder and Test::WWW::Mechanize... is there any overlap here? I encourage discussion here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 21:23:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 19:23:37 +0000 Subject: [Koha-bugs] [Bug 7915] Print a barcoded membership card from member detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7915 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron at veron.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 21:54:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 19:54:10 +0000 Subject: [Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 --- Comment #14 from Jared Camins-Esakov --- (In reply to comment #13) > There is a way of marking Perl modules as optional or required in > C4/Installer/PerlDependencies.pm. If it's not required, one adds a note > about what feature or context it could be used in. > > Looks like this module is indeed packaged for Debian (or at least old > Ubuntu), so it wouldn't give us too many problems there. But I'd like to > avoid new dependencies wherever possible, as it makes it that much harder to > install Koha, and adds one more piece of the puzzle that we don't have > direct control over. I would like to see Test::MockModule as an optional dependency, at least, and I think there is a strong argument for making it a required dependency. My plan for the Test::WWW::Mechanize tests is to add a t/www directory for all the tests that require a configured installation. If there is a concern with Test::MockModule, perhaps we should have a t/mock directory for those tests? > What's the goal of Test::MockModule? What is it doing, and how? jcamins is > working on a testing suite using HTML::Recorder and Test::WWW::Mechanize... > is there any overlap here? I encourage discussion here. Test::MockModule is used for selectively overriding methods for testing. This could be used to write unit tests that test both MARC21 and UNIMARC in one run, for example. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 23:34:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 21:34:28 +0000 Subject: [Koha-bugs] [Bug 7857] database upgrade fails with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7857 --- Comment #12 from Dobrica Pavlinusic --- No, of course not :-) There is hidden -Iinstaller include in Bug 7844 - plack scripts for developers thanks for catching that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 23:35:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 21:35:11 +0000 Subject: [Koha-bugs] [Bug 7857] database upgrade fails with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7857 --- Comment #13 from Dobrica Pavlinusic --- Created attachment 10287 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10287&action=edit Bug 7857 - database upgrade fails with plack This patch fixes PERL5LIB path injection to include installer dir which is required -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Jun 14 23:37:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Jun 2012 21:37:17 +0000 Subject: [Koha-bugs] [Bug 7857] database upgrade fails with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7857 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10287|Bug-7857---database-upgrade |Bug-7857-PERL5LIB-followup. filename|-fails-with-plack.patch |patch Attachment #10287|Bug 7857 - database upgrade |Bug 7857 - fix PERL5LIB description|fails with plack |followup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 07:49:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 05:49:34 +0000 Subject: [Koha-bugs] [Bug 5409] Call number is not show on Opac search result page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Meenakshi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2754|0 |1 is obsolete| | --- Comment #6 from Meenakshi --- Created attachment 10288 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10288&action=edit Attaching Patch. Fixes Bug 5409, Set the syspref value to 1 if it is itemdetails and 0 if it is statuses, leaving it alone if it is already 1 or 0 and change the type of the syspref to YesNo. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 07:49:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 05:49:52 +0000 Subject: [Koha-bugs] [Bug 5409] Call number is not show on Opac search result page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Meenakshi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |meenakshi.r at osslabs.biz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 07:50:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 05:50:23 +0000 Subject: [Koha-bugs] [Bug 5409] Call number is not show on Opac search result page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Meenakshi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |meenakshi.r at osslabs.biz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 07:50:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 05:50:45 +0000 Subject: [Koha-bugs] [Bug 5409] Call number is not show on Opac search result page. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409 Meenakshi changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_2 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 10:09:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 08:09:07 +0000 Subject: [Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 --- Comment #15 from claire.hernandez at biblibre.com --- I think this discussion about tests (good practices, wich perl library for what etc.) would have more sense here http://wiki.koha-community.org/w/index.php?title=Talk:Unit_Tests&action=edit&redlink=1 or on koha-devel ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 13:03:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 11:03:08 +0000 Subject: [Koha-bugs] [Bug 8242] Permission for "change password" button in members toolbar should be "borrowers" instead of "staffaccess" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 13:04:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 11:04:51 +0000 Subject: [Koha-bugs] [Bug 8242] Permission for "change password" button in members toolbar should be "borrowers" instead of "staffaccess" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |koha at univ-lyon3.fr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 13:05:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 11:05:04 +0000 Subject: [Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 --- Comment #16 from M. de Rooy --- (In reply to comment #15) Claire, you are right of course where this leads to a general discussion. Just to make a shortcut for this report: Ian: He only uses MockModule to redefine two routines in Budgets.pm. Julian:: In order to do this without a new dependency, just change the symbol table: *Module::routine= \&mockroutine; Note that if you imported routine, you should use *routine=.. I agree that this code is not really nice, but MockModule just does the same. (Note my earlier comment on mocking in a unit test; I am certainly not promoting mocking routines in unit tests.) I checked this call with perlcritic and it is not complaining. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 13:53:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 11:53:09 +0000 Subject: [Koha-bugs] [Bug 8251] New: Patrons are systematically debarred at checkin Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Priority: P1 - high Change sponsored?: --- Bug ID: 8251 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha at univ-lyon3.fr Summary: Patrons are systematically debarred at checkin Severity: critical Classification: Unclassified OS: All Reporter: koha at univ-lyon3.fr Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha Created attachment 10289 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10289&action=edit Patrons systematically debarred at checkin When suspension in days are used, the delta days between due-date and checkindate is tested in _FixFineDaysOnReturn line 1843 : if ( ( $deltadays - $grace )->is_positive ) and if positive the patron is debarred. The problem is that it's always positive even if the borrower is not late because the delta_days function of the Datetime module used in 'days_between' function always return a positive delta (from what I understood) Test plan : 1) configure a rule in issuingrules that includes a suspension in days 2) do a checkout for a borrower and document type corresponding to the rule. 3) do a checkin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 13:53:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 11:53:24 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 15:25:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 13:25:27 +0000 Subject: [Koha-bugs] [Bug 7943] Untranslatable strings in OPAC's authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7943 --- Comment #2 from Jared Camins-Esakov --- Katrin pointed out that I should know for QA purposes that I did not add the AuthDisplayHierarchy syspref, nor, indeed, modify the UNIMARC hierarchy code in any meaningful way. The fact that the syspref is not included in default installations is, I presume, intentional, though I have no idea why we wouldn't include it in all installations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 15:26:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 13:26:58 +0000 Subject: [Koha-bugs] [Bug 7943] Untranslatable strings in OPAC's authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7943 --- Comment #3 from Jared Camins-Esakov --- (In reply to comment #2) > Katrin pointed out that I should know for QA purposes that I did not add the > AuthDisplayHierarchy syspref, nor, indeed, modify the UNIMARC hierarchy code > in any meaningful way. The fact that the syspref is not included in default > installations is, I presume, intentional, though I have no idea why we > wouldn't include it in all installations. That I should let *you*, unidentified QAer, know. Time for some coffee. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 15:29:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 13:29:56 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 15:42:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 13:42:32 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 --- Comment #13 from Martin Renvoize --- (In reply to comment #3) > during hackfest, functions involved in this patch have been modified. I > remade the patch Hi Stephanie, Quick question, i'm not seeing a remade patch in the above attachments.. your comment of a remade patch is a few days after the original patch was attached.. did you attach a new one.. Looking at Marc's comments i've got a feeling i rebased the old patch, not taking into account the function changes.. Might be easier for you to do that bit as it's originals your code? Although i'm happy to take a look if i get a chance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 15:44:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 13:44:29 +0000 Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of bibliographic records In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8252 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 15:44:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 13:44:29 +0000 Subject: [Koha-bugs] [Bug 8252] New: Error in DOM biblio for UNIMARC (no range for fields 1xx) Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8252 Priority: P5 - low Change sponsored?: --- Bug ID: 8252 Assignee: paul.poulain at biblibre.com Blocks: 7818 Summary: Error in DOM biblio for UNIMARC (no range for fields 1xx) Severity: critical Classification: Unclassified OS: All Reporter: paul.poulain at biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Searching Product: Koha The biblio-koha-indexdefs.xml in case of UNIMARC is wrong for coded fields (1xx) For example, the 100 field says: tpubdate:s ta:w ta:w ta:w Modified-code:n ln:s char-encoding:n char-encoding:n char-encoding:n script-Title:n We should use ranges like what it made for MARC21: ff7-00:w and use offset and length -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:00:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:00:00 +0000 Subject: [Koha-bugs] [Bug 8234] Dates are not well sorted on Transfers to receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |adrien.saurat at biblibre.com --- Comment #1 from Adrien SAURAT --- They are sorted, but with an UK date format. Parameter : dateFormat: 'uk' For the 10th of June, 2012, we have the following date in France: 10/06/2012 But the DataTable consider this to be 06/10/2012 This breaks the sorting for Koha installations using non UK-dates. The problem could be present in other pages. I still have to see how to correct this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:00:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:00:15 +0000 Subject: [Koha-bugs] [Bug 8234] Dates are not well sorted on Transfers to receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 Adrien SAURAT changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |adrien.saurat at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:04:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:04:11 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10289|0 |1 is obsolete| | --- Comment #1 from Koha Team Lyon 3 --- Created attachment 10290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10290&action=edit Patrons systematically debarred at checkin Oups ! I left a dirty bare i on first version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:06:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:06:24 +0000 Subject: [Koha-bugs] [Bug 7943] Untranslatable strings in OPAC's authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7943 --- Comment #4 from Jared Camins-Esakov --- Created attachment 10291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10291&action=edit Bug 7943 follow-up: Fix template filename In preparation for some later work on authorities, the filename for the OPAC authority viewer changed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:08:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:08:40 +0000 Subject: [Koha-bugs] [Bug 8234] Dates are not well sorted on Transfers to receive In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8234 --- Comment #2 from Adrien SAURAT --- But shouldn't this MM/DD/YY way of writing dates be the US format? In fact, it looks like the case was supposed to be handled (there's a IF checking for metric format), but it doesn't work well. $("#transferst[% branchesloo.branchcode %]").tablesorter({[% IF ( branchesloo.dateformat_metric ) %] dateFormat: 'uk',[% END %] sortList: [[0,0]], headers: { 1: { sorter: 'articles' }} }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:10:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:10:22 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high CC| |wizzyrea at gmail.com Severity|normal |blocker --- Comment #3 from Liz Rea --- Calculating fines correctly is insanely important. This is a big deal. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:11:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:11:09 +0000 Subject: [Koha-bugs] [Bug 8243] calendar being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8243 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Severity|critical |blocker -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:11:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:11:37 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8243 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:11:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:11:37 +0000 Subject: [Koha-bugs] [Bug 8243] calendar being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8243 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8110 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:12:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:12:01 +0000 Subject: [Koha-bugs] [Bug 8087] Calendar not working in dropbox mode In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8087 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8243 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:12:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:12:01 +0000 Subject: [Koha-bugs] [Bug 8243] calendar being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8243 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8087 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:14:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:14:17 +0000 Subject: [Koha-bugs] [Bug 8253] New: Fine doubling Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253 Priority: P5 - low Change sponsored?: --- Bug ID: 8253 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Fine doubling Severity: blocker Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha We're still researching this, but Koha appears to be doubling fines after an upgrade from 3.6.x to 3.8.1. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:14:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:14:57 +0000 Subject: [Koha-bugs] [Bug 8253] Fine doubling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8110 Assignee|koha-bugs at lists.koha-commun |kyle.m.hall at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:14:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:14:57 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8253 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:14:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:14:58 +0000 Subject: [Koha-bugs] [Bug 7943] Untranslatable strings in OPAC's authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7943 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10261|0 |1 is obsolete| | Attachment #10291|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 10292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10292&action=edit [SIGNED-OFF] Bug 7943: Authority search results are untranslatable The HTML for authority search results was previously generated in C4::AuthoritiesMarc::BuildSummary, which meant that it couldn't be translated. This patch moves the HTML generation into the templates by introducing a new authorities-search-results.inc include file for both the OPAC and the Intranet which contains a Template::Toolkit BLOCK for rendering the authority results. Fixes the authority autocomplete by removing the untranslatable strings, and returning only data from the database. To test: 1. Apply patch. 2. Test authority searching in the authority module in the staff client 3. Test authority searching in the authority control plugin in the cataloguing module (and the plugin for UNIMARC field 210$c, if you can figure out how) 4. Test authority searching in the OPAC Signed-off-by: Katrin Fischer Tested with MARC21 data. 1) Applies cleanly on current HEAD. 2) Authority search in staff Patch works wonderfully, only some small notes found while testing that have not been changed by this patch: ENH note: Search terms show up nowhere. So if I want to change the sorting, I have to repeat typing in my search term. Even if the form does not keep the term, it should be visible somewhere on the screen what I searched for. ENH note: The pagination on top and at the bottom of the result list are formatted differently. Maybe some missing CSS? ENH note: Also the authority type is not shown at all in the result list. 3) Cataloguing and authority plugins The autocomplete function works nicely. ENH note: There is only one small enhancement I could imagine. If I start my search from 100 it will limit the search to 'persons' but the autocomplete will also suggest other authorities. It would be a bit cleaner, if the autocomplete could limit by the appropriate authority type too. Very nice feature. Plugins overall work nicely. Created links include the authority numbers and work correctly. 4) Authority search in OPAC Works nicely. Display is consistent, but translatability greatly improved. ENH note: In staff we use 'Details' in OPAC we use 'View full heading' - I wonder if maybe 'details' would be better understandable for users? Note: Code reveals a system preference 'AuthDisplayHierarchy' that is not available in the system preference editor. I talked to Jared and he will work on this feature later on. For now it's no regression, as the preference has never been visible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:16:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:16:45 +0000 Subject: [Koha-bugs] [Bug 7943] Untranslatable strings in OPAC's authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7943 --- Comment #6 from Katrin Fischer --- Created attachment 10293 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10293&action=edit [SIGNED-OFF] Bug 7943 follow-up: Fix template filename In preparation for some later work on authorities, the filename for the OPAC authority viewer changed. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:18:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:18:46 +0000 Subject: [Koha-bugs] [Bug 7943] Untranslatable strings in OPAC's authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7943 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:22:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:22:44 +0000 Subject: [Koha-bugs] [Bug 7382] normalization on isbn matching rule In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7382 David Schuster changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dschust1 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:24:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:24:08 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10265|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 10294 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10294&action=edit [SIGNED-OFF] Bug 6720: Display the authority type in OPAC Due to a peculiarity in the way SearchAuthorities worked, the authority search results on the OPAC always listed the authority type that the user searched for, rather than the authority type of the results. Signed-off-by: Katrin Fischer Works nicely, result list for OPAC search now shows the authority type for each record. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:25:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:25:54 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Katrin Fischer --- Small note: Bug should remain open after pushing this patch. The problem also still exists on the authority detail page in staff. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:32:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:32:37 +0000 Subject: [Koha-bugs] [Bug 8154] The export today's checked in barcodes generated file is always empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |koha.sekjal at gmail.com --- Comment #5 from Ian Walls --- Reformats the datetime in issue->{returndate} into iso-formatted date. Uses C4::Dates, rather than DateTime, though, which we're looking to phase out. if ( ($input->param('op') eq 'export_barcodes') and ($today eq C4::Dates->new( $issue->{'returndate'}, 'iso' )->output("iso")) ) { could be my $return_dt = Koha::DateUtils::dt_from_string($issue->{'returndate'}, 'iso'); if ( ($input->param('op') eq 'export_barcodes') and ($today eq $return_dt->ymd() ) { My initial testing shows this change should work, and it won't introduce a new dependence on C4::Dates we'll just have to replace later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:34:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:34:15 +0000 Subject: [Koha-bugs] [Bug 8247] adding basket doesn't save basket name, internal or vendor note In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8247 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #3 from Ian Walls --- Adds missing required parameter to ModBasketHeader, and that's all. Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:37:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:37:15 +0000 Subject: [Koha-bugs] [Bug 8165] due date of 00:00 instead of 23:59 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8165 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7444 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:37:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:37:15 +0000 Subject: [Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8165 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:37:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:37:34 +0000 Subject: [Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7444 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:37:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:37:34 +0000 Subject: [Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8182 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:40:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:40:00 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 --- Comment #5 from Jared Camins-Esakov --- Created attachment 10295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10295&action=edit Bug 6720: show authority type in auth details -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:40:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:40:13 +0000 Subject: [Koha-bugs] [Bug 8173] Have Full title (245) to always display in system In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8173 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com Version|rel_3_6 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:41:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:41:07 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving items requires repetitive clicking. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:41:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:41:14 +0000 Subject: [Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- New search option "in see from headings" does not work for me. Talking to Jared it probably needs a follow-up - failing QA for the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:41:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:41:58 +0000 Subject: [Koha-bugs] [Bug 8253] Fine doubling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8182 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:41:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:41:58 +0000 Subject: [Koha-bugs] [Bug 8182] Problem with overdue fine calculations after upgrade In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8182 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8253 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:42:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:42:53 +0000 Subject: [Koha-bugs] [Bug 6846] Dont allow staff to change own permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6846 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:42:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:42:58 +0000 Subject: [Koha-bugs] [Bug 4255] Add item type to facet list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4255 --- Comment #5 from Ian Walls --- Created attachment 10296 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10296&action=edit [PASSED QA] Bug 4255 - Add item type to facet list This is for MARC 21 only. Made following changed: - In getFacets in C4/Koha.pm added item type facet for 952y and 942c - In getRecords in C4:Search.pm added code to get description of itemtype codes - facets.inc in both staff and opac to show item types related label in the facets block To test: Add records such that a certain itype (say BK) is present in both 942c and 952y in two DIFFERENT records. Run a search where both test records are present. Test to see if itype types are presented in the facets block (both OPAC and staff). Click on the itype (say BK), both the test records should appear in the refined results. This shows that the feature works for both 942c and 952y. Signed-off-by: Kyle M Hall Signed-off-by: Ian Walls QA Comment: fixed capitalization in template includes according to HTML4 coding guideline ("Item types" instead of "ItemTypes") -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:43:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:43:18 +0000 Subject: [Koha-bugs] [Bug 4255] Add item type to facet list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4255 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10184|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:43:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:43:25 +0000 Subject: [Koha-bugs] [Bug 4255] Add item type to facet list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4255 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Ian Walls --- According to coding guideline HTML4, the string in the templates should be "Item types" not "ItemTypes". Otherwise, this patch is very good, even if it's MARC21-only. I'm so pleased with it, I've made the capitalization fixes myself, and resubmitted with QA signoff. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:43:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:43:40 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10295|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer --- Created attachment 10297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10297&action=edit [SIGNED-OFF] Bug 6720: show authority type in auth details Signed-off-by: Katrin Fischer Authority type on detail page in staff now shows correctly. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:44:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:44:45 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 --- Comment #7 from Katrin Fischer --- Thx Jared for providing an additional patch for the staff side problem! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:45:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:45:24 +0000 Subject: [Koha-bugs] [Bug 8254] New: issn and isbn search on Z targets not working Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8254 Priority: P5 - low Change sponsored?: --- Bug ID: 8254 Assignee: gmcharlt at gmail.com Summary: issn and isbn search on Z targets not working Severity: major Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Cataloging Product: Koha I have tried on several targets that I know have a popular ISBN but the search returns no results in master. I have had similar reports from those using 3.8.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:46:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:46:46 +0000 Subject: [Koha-bugs] [Bug 5295] ctype index Zebra configuration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #7 from Ian Walls --- Replaces bib1.att ctype with Content-type, which is the correct index according to external sources, as well as ccl.properties. Marking Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 16:59:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 14:59:49 +0000 Subject: [Koha-bugs] [Bug 8194] Layout problem on subscription add when showing manual history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8194 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|rel_3_8 |master Summary|Subscription-add.tt |Layout problem on | |subscription add when | |showing manual history -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:05:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:05:02 +0000 Subject: [Koha-bugs] [Bug 8194] Layout problem on subscription add when showing manual history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8194 --- Comment #3 from Owen Leonard --- Created attachment 10298 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10298&action=edit Bug 8194 - Layout problem on subscription add when showing manual history Markup errors were causing display problems when the "manual history" section is shown. To test, apply the patch, load the subscription add page, and check the "manual history" checkbox. The "Serials planning" section should appear directly below the "manual history" section. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:05:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:05:20 +0000 Subject: [Koha-bugs] [Bug 8194] Layout problem on subscription add when showing manual history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8194 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:05:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:05:31 +0000 Subject: [Koha-bugs] [Bug 8194] Layout problem on subscription add when showing manual history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8194 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:06:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:06:37 +0000 Subject: [Koha-bugs] [Bug 7943] Untranslatable strings in OPAC's authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7943 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Ian Walls --- Code is cleanly written and well documented. Followup is simple, providing a small consistency change to enable further work. New template block is translatable, which is the ultimate goal. More followup may be required to address Katrin's enhancement requests, and as other work comes in, but this as it stands Passes QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:13:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:13:35 +0000 Subject: [Koha-bugs] [Bug 8205] Should be possible to hide unused authorities in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10267|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 10299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10299&action=edit [SIGNED-OFF] Bug 8205: Add OPACShowUnusedAuthorities syspref Rather than list authorities that are not actually used by a library, this commit introduces a new syspref: OPACShowUnusedAuthorities to enable libraries to hide unused authorities in the OPAC authority browser. To test: 1) Do a search in the OPAC authority browser that brings up multiple results, including some that are used in the bibliographic database and some that are not. 2) Observe that the results include both used and unused authorities. 3) Set OPACShowUnusedAuthorities to "Do not." 4) Repeat the same search as in step 1. 5) Observe that the results no longer include unused authorities. Signed-off-by: Katrin Fischer Preference is implemented cleanly and works like advertised. As a note: The unused authority records will be hidden from display, but the result list paging does not adjust for the hidden records. So the result pages will show more or less records total, depending on how many records are hidden. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:14:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:14:08 +0000 Subject: [Koha-bugs] [Bug 8205] Should be possible to hide unused authorities in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:15:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:15:47 +0000 Subject: [Koha-bugs] [Bug 7129] actual cost showing too many zeros In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 --- Comment #12 from Ian Walls --- Created attachment 10300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10300&action=edit [PASSED QA] Bug 7129: Added a sprintf to format the actual cost. Signed-off-by: Katrin Fischer Rebased to current master, please test. Signed-off-by: Kyle M Hall Signed-off-by: Ian Walls QA note: changed call to use $order instead of @$results[0], for consistency with surrounding variables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:16:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:16:04 +0000 Subject: [Koha-bugs] [Bug 7129] actual cost showing too many zeros In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10216|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:16:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:16:37 +0000 Subject: [Koha-bugs] [Bug 7129] actual cost showing too many zeros In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Ian Walls --- Same work that passed QA the first time, just updated to reflect new variable names. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:18:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:18:48 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 --- Comment #19 from claire.hernandez at biblibre.com --- Created attachment 10301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10301&action=edit Bug 7994: scripts to check yaml files $ prove yaml_valid.t checks a closed list of files $ perl yaml_valid.pl -f myfile.yaml try to load a yaml file with YAML::LoadFile and show errors (both files pertidied) Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:19:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:19:09 +0000 Subject: [Koha-bugs] [Bug 8136] Changes the expected lenght of 100$a in rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8136 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #4 from Ian Walls --- Adjust length check by 1 to conform to standards. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:20:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:20:26 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10205|0 |1 is obsolete| | Attachment #10301|0 |1 is obsolete| | --- Comment #20 from claire.hernandez at biblibre.com --- Created attachment 10302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10302&action=edit [SIGNED-OFF] Bug 7994: scripts to check yaml files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:20:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:20:59 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 claire.hernandez at biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10229|0 |1 is obsolete| | --- Comment #21 from claire.hernandez at biblibre.com --- Created attachment 10303 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10303&action=edit [SIGNED-OFF] Bug 7994: Fix pref yaml errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:23:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:23:49 +0000 Subject: [Koha-bugs] [Bug 7447] Allow to specify a date in overdue_notice.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7447 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Ian Walls --- $dbh->quote takes care of the cleanliness, so my original objection is withdrawn. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:24:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:24:29 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 --- Comment #22 from claire.hernandez at biblibre.com --- (In reply to comment #18) > 1/ Usage is not correct: > +=head1 USAGE > + > +From Koha root directory: > + > +prove -v xt/tt_valid.t Yep done. > 2/ It not possible to launch the test file from the koha home directory > (prove xt/yaml_valid.t) (see the FindBin module) Done but too much code for me for adding this "feature" - nothing more sexy? > 3/ Don't you think it would be more friendly to do a test file (thus using > Test::More) for your pl file ? I don't know how to give a parameter to a test file and I wanted to have a "-f" option to test whatever you want (sudoc yaml file for example). > 4/ You add a new dependency Test::YAML::Valid. I dont know if we have to add > this dependency to koha (given that it is used for unit tests). I think we should be free to add new test libraies if we need it for testing. For discusion irl monday :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:25:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:25:51 +0000 Subject: [Koha-bugs] [Bug 8105] DataTables in Acquisision module: basketgroup.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8105 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #3 from Ian Walls --- Template change only. Adds DataTables JS and CSS, and reformats table layout slightly to conform to it. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:27:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:27:25 +0000 Subject: [Koha-bugs] [Bug 8104] DataTables in Acquisision module: lateorders.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8104 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #3 from Ian Walls --- Template change only. Includes JS, CSS, strings include and some reformatting of the table for consistency. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:29:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:29:54 +0000 Subject: [Koha-bugs] [Bug 8152] Clicking cancel on edit suggestion redirect to the suggestion detail In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8152 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #3 from Ian Walls --- Template only change removing some query params in order to show the preferred content. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:39:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:39:14 +0000 Subject: [Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6371|1 |0 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:39:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:39:30 +0000 Subject: [Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #17 from Liz Rea --- I want to see both patches get anot -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:41:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:41:29 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 --- Comment #23 from Paul Poulain --- (In reply to comment #22) > > 4/ You add a new dependency Test::YAML::Valid. I dont know if we have to add > > this dependency to koha (given that it is used for unit tests). > > I think we should be free to add new test libraies if we need it for > testing. For discusion irl monday :) I agree with claire = it's not a Koha dependency, it's a jenkins one, I think it's OK not to add it to Koha (claire = shouldn't you switch back to signed-off ?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:41:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:41:29 +0000 Subject: [Koha-bugs] [Bug 6976] User hold limit can be avoided by users in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976 --- Comment #18 from Liz Rea --- Lol dangit. I want to see these patches get another look - this is no trivial issue for libraries - we can't have patrons requesting and getting items over the limits libraries have set in policy. At this point, I am convinced that it is better to look at a partial fix to get SOME limit, SOMEWHERE working. I will look at both fixes by Monday, june 18 2012. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 17:55:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 15:55:06 +0000 Subject: [Koha-bugs] [Bug 4118] Add Collection Code to Statistics Table In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4118 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |koha.sekjal at gmail.com --- Comment #6 from Ian Walls --- First patch is okay, just adds ccode to the stats table so you don't have to do a multi-table join to get it from items and deleteditems. The database update, though, looks a little janky: ALTER TABLE `statistics` ADD `ccode` VARCHAR( 80 ) NULL ; should be more like ALTER TABLE `statistics` ADD COLUMN `ccode` VARCHAR ( 10 ) AFTER `associatedborrower` The update message is also inaccurate ("Category code" instead of "collection code") -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 18:48:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 16:48:14 +0000 Subject: [Koha-bugs] [Bug 8243] calendar being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8243 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia at bywatersolutions.com --- Comment #2 from Melia Meggs --- Is this the same as Bug 8110? Or two different problems? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:01:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:01:42 +0000 Subject: [Koha-bugs] [Bug 8103] DataTables in Acquisision module: parcels.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8103 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #5 from Ian Walls --- Template only change, includes JS, CSS and includes strings, as well as reformatting of the table to make it all work. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:03:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:03:35 +0000 Subject: [Koha-bugs] [Bug 5910] Authorities : allow users to search on all auth types In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Ian Walls --- Both patches together add the "all authority types" option for UNIMARC in a safe and sane way. Marking Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:05:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:05:08 +0000 Subject: [Koha-bugs] [Bug 8102] DataTables in Acquisision module: supplier.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8102 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #5 from Ian Walls --- Mostly a template change, but also adds the dateformat param to exported template variables. Includes JS, CSS, includes strings and reformats table to make it work. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:05:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:05:30 +0000 Subject: [Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10266|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov --- Created attachment 10304 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10304&action=edit Bug 8206: Specify index in OPAC authority search Adds a dropdown to allow the user to choose to search the 'mainentry,' and 'match-heading'indexes, in addition to the 'any' index which is the default. To test (you will need authority records with see-from and see-also headings): 1. Go to the browse subjects and authors section in the OPAC 2. Do a search for a fairly generic term that is used as a see-also term in a lot of records. Note that your search results include both the record that you wanted and all the other records that refer to it. 3. Apply the patch. 4. Repeat the search from step 2. Notice there is no change to the results. 5. Repeat the search from step 2, but choose "in main entry" and observe that you are now only seeing authority records with the search entered in their main entry. 6. Repeat the search from step 2, but choose "in any heading" and observe that the results are the same as in step 2. This is intentional, so that in the future notes in authorities can be made searchable. 7. Search for an obsolete form of heading with the "in keyword" option selected. Notice what results you get. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:06:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:06:02 +0000 Subject: [Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:11:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:11:00 +0000 Subject: [Koha-bugs] [Bug 8180] cataloguing/additem.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #10 from Ian Walls --- Plack scoping change only, ruled safe for CGI environments, marking Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:11:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:11:41 +0000 Subject: [Koha-bugs] [Bug 8183] acqui/parcels.pl plack scoping In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #7 from Ian Walls --- Plack scoping only, safe for CGI environments, marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:13:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:13:01 +0000 Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 --- Comment #1 from Jared Camins-Esakov --- Created attachment 10305 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10305&action=edit Bug 8202: Add authority export to tools/export.pl Adds a separate tab on tools/export.pl for exporting authority records. To test: 1. Try exporting authority records from the "Export data" tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:13:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:13:19 +0000 Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:13:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:13:57 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Ian Walls --- Patch 1: adds new template param to get the Auth Type properly, then displays it in the template. Passed QA. Patch 2: replaces an empty string with the actual Auth Type. Marking Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:17:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:17:03 +0000 Subject: [Koha-bugs] [Bug 8203] Should be possible to save individual authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8203 --- Comment #1 from Jared Camins-Esakov --- Created attachment 10306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10306&action=edit Bug 8203: Add ability to save individual authorities Adds the ability to save individual authority records in MADS, MARCXML, or binary MARC format to the staff client. To test: 1. Apply patch 2. View authority record in staff client 3. Try saving record as MADS, MARCXML, and MARC, and confirm that the resulting files are what you expect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:17:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:17:21 +0000 Subject: [Koha-bugs] [Bug 8203] Should be possible to save individual authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8203 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:17:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:17:38 +0000 Subject: [Koha-bugs] [Bug 3708] Add another customizable region to the OPAC: right sidebar In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3708 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #11 from Ian Walls --- Adds a new system preference (OpacNavRight) correctly, and shows it in the place in the diagram where expected. Strips out some YUI divs that may not be necessary... I differ to Owen on such user interface changes. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:19:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:19:17 +0000 Subject: [Koha-bugs] [Bug 8099] DataTables in Acquisision module: acqui-home.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8099 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #6 from Ian Walls --- Template only change, includes JS, CSS and includes strings, as well as a new sort method, which is called on the page. No changes to the table structure. Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:21:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:21:08 +0000 Subject: [Koha-bugs] [Bug 6634] manager_id not populated when paying fines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #25 from Ian Walls --- Adds managerid recording to recordpayment(), chargelostitem(), and recordpayment_selectaccts() subroutines. Marking Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:23:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:23:02 +0000 Subject: [Koha-bugs] [Bug 8098] DataTables in Acquisision module: parcel.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8098 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #7 from Ian Walls --- Template only change, includes JS, CSS and includes strings. Fixes some table structure. Also includes new sort functions... possible conflict with bug 8099. But, in terms of Master, it's good, so marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:24:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:24:18 +0000 Subject: [Koha-bugs] [Bug 8100] DataTables in Acquisision module: neworderbiblio.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8100 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #9 from Ian Walls --- Template only change, includes JS, CSS, and includes strings. Minor table structure fixes. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:25:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:25:44 +0000 Subject: [Koha-bugs] [Bug 8006] Loading offline circulation does not anonymize In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8006 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Ian Walls --- Simple fix to add another value to exported params. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:31:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:31:13 +0000 Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Jared Camins-Esakov --- I am not sure about using requiring arguments to an xt/ test. Would it be possible to have it automatically know that kohaclone is in dirname($0)/.. and then use tempdir for a destination directory? If we did that, then this test could safely be included in Koha? Also, much more significantly, this script does not work for me. I ran the following command: > perl xt/find-undefined-subroutines.pl --src-path=/home/jcamins/kohaclone --dest-path=/home/jcamins/kohatmp -v It copied everything into /home/jcamins/kohatmp/home/jcamins/kohaclone, then gave the following error: cp: cannot create regular file `/home/jcamins/kohatmp/C4/Context.pm': No such file or directory sh: cannot create /home/jcamins/kohatmp/misc/kohalib.pl: Directory nonexistent Unknown option: trap Unable to continue at /usr/bin/prove line 10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:32:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:32:41 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |koha.sekjal at gmail.com --- Comment #9 from Ian Walls --- First patch no longer applies... probably a conflict in updatedatabase -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:33:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:33:18 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 --- Comment #3 from Jared Camins-Esakov --- I had a thought about this. Would it be possible to have the logging module serve dual purposes, for both debug logging and for action_logs logging? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:33:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:33:36 +0000 Subject: [Koha-bugs] [Bug 7686] Tax rate wrong calculation in reception summary page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7686 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #7 from Ian Walls --- Setting status to "In Discussion" while 5335 is checked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:36:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:36:38 +0000 Subject: [Koha-bugs] [Bug 7961] Local cover images should support CSV link files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7961 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Ian Walls --- Changes are well-reviewed by now, optimized over several QAings. Code is simple change, handles split more elegantly, and scrubs for leading/trailing whitespace instead of whitespace anywhere in filename. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:40:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:40:51 +0000 Subject: [Koha-bugs] [Bug 7329] The "undo import into catalog" command deletes items onloan without checking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Ian Walls --- Patch 1: uses DelItemCheck instead of DelItem, with logic to handle when an item cannot be deleted. Good use of existing subroutine. Passed QA. Patch 2 + 3: Work together to prevent the biblio from being NULLifed if the item isn't deleted. SQL only change, with a comment, marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:44:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:44:44 +0000 Subject: [Koha-bugs] [Bug 8205] Should be possible to hide unused authorities in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |koha.sekjal at gmail.com --- Comment #3 from Ian Walls --- Adds new syspref in standard manner. Original behavior of system is kept, making this 'opt-in'. Greps through authority results for whether used > 0. Changes template display language to 'fuzzify' (my own word) the description when the syspref is turned off. Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:52:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:52:11 +0000 Subject: [Koha-bugs] [Bug 8255] New: Local cover images should be cacheable Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8255 Priority: P5 - low Change sponsored?: --- Bug ID: 8255 Assignee: jcamins at cpbibliography.com Summary: Local cover images should be cacheable Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: ASSIGNED Version: master Component: OPAC Product: Koha At the moment, local cover images cannot be cached by the web browser or any intermediate reverse proxies. This results in an unnecessary load on the server, and is entirely unnecessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:55:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:55:14 +0000 Subject: [Koha-bugs] [Bug 8255] Local cover images should be cacheable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8255 --- Comment #1 from Jared Camins-Esakov --- Created attachment 10307 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10307&action=edit Bug 8255: allow local cover images to be cached -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:55:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:55:26 +0000 Subject: [Koha-bugs] [Bug 8255] Local cover images should be cacheable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8255 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:58:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:58:03 +0000 Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |koha.sekjal at gmail.com --- Comment #12 from Ian Walls --- Patch does not apply; probably a merge conflict in updatedatabase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:59:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:59:20 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10290|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi --- Created attachment 10308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10308&action=edit Bug 8251 - Patrons get incorrectly debarred Patrons get incorrectly debarred because of the use of Datetime->delta_days wich happens to always return a positive number. Also changed the use of Datetime->truncate function so it follows the docs, using 'day' instead of 'days' (which is used in DateTime::Duration). This patch has been tested against master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 19:59:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 17:59:55 +0000 Subject: [Koha-bugs] [Bug 8256] New: Reports webservice should allow selection by name Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256 Priority: P5 - low Change sponsored?: --- Bug ID: 8256 Assignee: gmcharlt at gmail.com Summary: Reports webservice should allow selection by name Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: NEW Version: master Component: Reports Product: Koha At the moment, reports cannot be selected from the reports webservice by name, only by report ID. It would be very useful to be able to select a report by name. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 20:08:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 18:08:43 +0000 Subject: [Koha-bugs] [Bug 6448] EAN-13 barcode support In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6448 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Ian Walls --- First patch does not update sysprefs.sql to reflect the new EAN13 option. DB Rev is also at 3.07.... instead of 3.09.. (though the RM has to fix that manually, anyway). In Patch 2, C4/Barcodes/EAN13 is missing copyright statement. Also, subroutines are prototyped, which fails our perlcritic. Another syspref altered without changes to sysprefs.sql. Marking Failed QA for above reasons. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 20:13:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 18:13:59 +0000 Subject: [Koha-bugs] [Bug 7387] Add Template::Toolkit plugin to allow caching of includes In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7387 Ian Walls changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Ian Walls --- Mostly just adding the new plugin, which appears to be functional. Example of usage in intranet-main, to get the doc-head-open.inc for 6 minutes. Should be an easy enough thing to revert if we later find some deep dark nastiness, but I can't see any right now, and will mark Passed QA. Note that 3-way merge is required... git bz is not applying for me here directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 20:20:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 18:20:12 +0000 Subject: [Koha-bugs] [Bug 8221] Adding item to patroncard Batch causes error in Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8221 --- Comment #2 from Dobrica Pavlinusic --- I manage to replicate this problem, but and it happen when you are logged in with koha admin account which doesn't have library (branch) assigned. Adding batch dies because of referential integrity error (since branch is NULL) and editing dies because there is no row created to edit. It does work for CGI version, more research needs to be done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 20:40:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 18:40:27 +0000 Subject: [Koha-bugs] [Bug 8256] Reports webservice should allow selection by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256 --- Comment #1 from Jared Camins-Esakov --- Created attachment 10309 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10309&action=edit Bug 8256: Teach webservice to select reports by name Adds the ability to pass a hash to C4::Reports::Guided::get_saved_report which specifies a name or id to select the report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 20:43:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 18:43:16 +0000 Subject: [Koha-bugs] [Bug 8256] Reports webservice should allow selection by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |jcamins at cpbibliography.com --- Comment #2 from Jared Camins-Esakov --- Test plan: 1. Create a report (or choose an existing one), and mark it public 2. Run the report using the web service: [IntranetBaseURL]/cgi-bin/koha/svc/report?id=whatever 3. Confirm you get the expected results 4. Run the report by name using the web service: [IntranetBaseURL]/cgi-bin/koha/svc/report?name=[Report name] (keep spaces in the name) 5. Confirm you get the same results 6. Run the report using the public web service: [OPACBaseURL]/cgi-bin/koha/svc/report?id=whatever 7. Confirm you get the same results 8. Run the report by name using the public web service: [OPACBaseURL]/cgi-bin/koha/svc/report?name=[Report name] (keep spaces in the name) 9. Confirm you get the same results 10. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 20:44:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 18:44:25 +0000 Subject: [Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10304|0 |1 is obsolete| | --- Comment #4 from Jared Camins-Esakov --- Created attachment 10310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10310&action=edit Bug 8206: Specify index in OPAC authority search Adds a dropdown to allow the user to choose to search the 'mainentry,' and 'match-heading'indexes, in addition to the 'any' index which is the default. To test (you will need authority records with see-from and see-also headings): 1. Go to the browse subjects and authors section in the OPAC 2. Do a search for a fairly generic term that is used as a see-also term in a lot of records. Note that your search results include both the record that you wanted and all the other records that refer to it. 3. Apply the patch. 4. Repeat the search from step 2. Notice there is no change to the results. 5. Repeat the search from step 2, but choose "in main entry" and observe that you are now only seeing authority records with the search entered in their main entry. 6. Repeat the search from step 2, but choose "in any heading" and observe that the results are the same as in step 2. This is intentional, so that in the future notes in authorities can be made searchable. 7. Search for an obsolete form of heading with the "in keyword" option selected. Notice what results you get. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 21:02:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 19:02:36 +0000 Subject: [Koha-bugs] [Bug 7952] PDF::Reuse under plack writes to console STDOUT instead to browser In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7952 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #14 from Chris Cormack --- Pushed both the original and follow up to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 21:24:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 19:24:17 +0000 Subject: [Koha-bugs] [Bug 8239] Z39.50 Search/Import doesn't work with unicode characters from a specific server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8239 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #1 from Chris Cormack --- What happens if you tell it to get utf8 instead of marc8? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 21:32:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 19:32:03 +0000 Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10305|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 10311 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10311&action=edit [SIGNED-OFF] Bug 8202: Add authority export to tools/export.pl Adds a separate tab on tools/export.pl for exporting authority records. To test: 1. Try exporting authority records from the "Export data" tool Signed-off-by: Katrin Fischer Tried different exports and everything worked nicely: - removing fields from export (example: 942) - limiting to one authority type - changing the given file name - exporting as MARC or XML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 21:32:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 19:32:44 +0000 Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 21:37:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 19:37:33 +0000 Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10185|0 |1 is obsolete| | --- Comment #13 from Liz Rea --- Created attachment 10312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10312&action=edit Bug 8130 - attach PDF files to a patron record Adds the ability to attach unlimited arbitrary files to a borrower record. Test Plan: 1) Enable system preference EnableBorrowerFiles 2) Look up borrower record, click 'Files' tab on left 3) Upload a file, download the file, delete the file. Signed-off-by: Liz Rea rebased for current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 21:38:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 19:38:15 +0000 Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off CC| |wizzyrea at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 21:57:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 19:57:32 +0000 Subject: [Koha-bugs] [Bug 8190] Koha does not have a logging module In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #4 from Chris Cormack --- Perhaps also take a look at Log4Perl http://search.cpan.org/~mschilli/Log-Log4perl-1.37/lib/Log/Log4perl.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 22:02:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 20:02:40 +0000 Subject: [Koha-bugs] [Bug 8221] Adding item to patroncard Batch causes error in Plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8221 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #3 from Chris Cormack --- (In reply to comment #2) > I manage to replicate this problem, but and it happen when you are logged in > with koha admin account which doesn't have library (branch) assigned. > Ahh yeah, we really really should stop people doing this, or at least strongly recommend they don't. Should only ever use the kohaadmin user for upgrades and setting up your first real user. > Adding batch dies because of referential integrity error (since branch is > NULL) and editing dies because there is no row created to edit. > > It does work for CGI version, more research needs to be done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 22:09:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 20:09:09 +0000 Subject: [Koha-bugs] [Bug 8256] Reports webservice should allow selection by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Jared, I can't get this to work :( The id works nicely for OPAC and for staff, but the name does not work for me. http://localhost:8080/cgi-bin/koha/svc/report?name=Borrowers Can't call method "fetchall_arrayref" on an undefined value at /home/katrin/kohaclone/svc/report line 65. or http://localhost/cgi-bin/koha/svc/report?name=Borrowers Sorry this report is not public With id=2 both URLs work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 23:18:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 21:18:00 +0000 Subject: [Koha-bugs] [Bug 8203] Should be possible to save individual authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8203 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10306|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 10313 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10313&action=edit [SIGNED-OFF] Bug 8203: Add ability to save individual authorities Adds the ability to save individual authority records in MADS, MARCXML, or binary MARC format to the staff client. To test: 1. Apply patch 2. View authority record in staff client 3. Try saving record as MADS, MARCXML, and MARC, and confirm that the resulting files are what you expect Signed-off-by: Katrin Fischer Works nicely, tested different export options on different records. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Jun 15 23:18:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 21:18:19 +0000 Subject: [Koha-bugs] [Bug 8203] Should be possible to save individual authorities In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8203 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 00:01:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 22:01:49 +0000 Subject: [Koha-bugs] [Bug 8256] Reports webservice should allow selection by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10309|0 |1 is obsolete| | --- Comment #4 from Jared Camins-Esakov --- Created attachment 10314 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10314&action=edit Bug 8256: Teach webservice to select reports by name Adds the ability to pass a hash to C4::Reports::Guided::get_saved_report which specifies a name or id to select the report. Test plan: 1. Create a report (or choose an existing one), and mark it public 2. Run the report using the web service: [IntranetBaseURL]/cgi-bin/koha/svc/report?id=whatever 3. Confirm you get the expected results 4. Run the report by name using the web service: [IntranetBaseURL]/cgi-bin/koha/svc/report?name=[Report name] (keep spaces in the name) 5. Confirm you get the same results 6. Run the report using the public web service: [OPACBaseURL]/cgi-bin/koha/svc/report?id=whatever 7. Confirm you get the same results 8. Run the report by name using the public web service: [OPACBaseURL]/cgi-bin/koha/svc/report?name=[Report name] (keep spaces in the name) 9. Confirm you get the same results 10. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 00:03:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Jun 2012 22:03:13 +0000 Subject: [Koha-bugs] [Bug 8256] Reports webservice should allow selection by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Jared Camins-Esakov --- I'm not sure the changes I made will have fixed it, but could you please try again? At the very least, you shouldn't get that error about fetchall_arrayref not working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 02:25:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 00:25:27 +0000 Subject: [Koha-bugs] [Bug 8239] Z39.50 Search/Import doesn't work with unicode characters from a specific server In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8239 --- Comment #2 from Derryn --- Exactly the same result with both marc-8 and utf8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 11:28:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 09:28:34 +0000 Subject: [Koha-bugs] [Bug 8256] Reports webservice should allow selection by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Katrin Fischer --- Hi Jared, the new feature works fine with the new patch, but I found another big problem. After applying your patch I can not edit existing reports. All fields are empty on the edit screen. Another interesting find is a problem with authentication. I reached the URL for the report today, before I logged into the staff client. I got redirected to the login screen, which is fine. I logged in and got to see the report's results. But the URL changed from http://localhost:8080/cgi-bin/koha/svc/report?id=2 to http://localhost:8080/cgi-bin/koha/svc/report. I opened a new tab and tried again to reach the page with the first URL and got told my session has timed out. Not sure if this is a problem or not, but there is some difference between logging in from one of the webservice pages and logging in from the normal staff client URL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 11:36:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 09:36:08 +0000 Subject: [Koha-bugs] [Bug 8256] Reports webservice should allow selection by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256 --- Comment #7 from Katrin Fischer --- [Sat Jun 16 11:22:15 2012] [error] [client 127.0.0.1] [Sat Jun 16 11:22:15 2012] report: "my" variable $report_id masks earlier declaration in same scope at /home/katrin/kohaclone/opac/svc/report line 36. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 11:38:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 09:38:53 +0000 Subject: [Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10310|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer --- Created attachment 10315 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10315&action=edit [SIGNED-OFF] Bug 8206: Specify index in OPAC authority search Adds a dropdown to allow the user to choose to search the 'mainentry,' and 'match-heading'indexes, in addition to the 'any' index which is the default. To test (you will need authority records with see-from and see-also headings): 1. Go to the browse subjects and authors section in the OPAC 2. Do a search for a fairly generic term that is used as a see-also term in a lot of records. Note that your search results include both the record that you wanted and all the other records that refer to it. 3. Apply the patch. 4. Repeat the search from step 2. Notice there is no change to the results. 5. Repeat the search from step 2, but choose "in main entry" and observe that you are now only seeing authority records with the search entered in their main entry. 6. Repeat the search from step 2, but choose "in any heading" and observe that the results are the same as in step 2. This is intentional, so that in the future notes in authorities can be made searchable. 7. Search for an obsolete form of heading with the "in keyword" option selected. Notice what results you get. Signed-off-by: Katrin Fischer Works nicely. Hiding the new options can be done with CSS: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 11:39:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 09:39:08 +0000 Subject: [Koha-bugs] [Bug 8206] Add additional search options to authority browser in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8206 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 12:05:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 10:05:22 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 --- Comment #38 from Chris Cormack --- (In reply to comment #37) > Katrin, > > (In reply to comment #36) > > Hi Jared, > > I might be wrong here, because I can't remember disagreeing with you. :) > > > > But I think maybe I didn't explain it well before? If you leave the mapping > > empty (which yes, we did...) the value will be saved into the > > more_subfields_xml column in XML format. So after updating the mapping, the > > value will still be there, but you will not be able to access the > > information from the interface. So I was suggesting that there should be a > > way to copy that information into the new field or give at least a warning, > > that you might have to do so. > > So it's not only when people created a new column, but also when they were > > using the methods Koha provides to add additional subfields. > > As far as I can tell, the situation is no worse after applying the patch > than it was before applying the patch. Are you able to find a situation > where the patch makes things worse than they already are? I think it is worse, because now you have data stored, you can no longer edit or even access. It will stay in the more_subfields_xml column until you edit an item and at that point it will get deleted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 12:20:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 10:20:11 +0000 Subject: [Koha-bugs] [Bug 5981] OPAC: Add limits to search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10087|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer --- Created attachment 10316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10316&action=edit [SIGNED-OFF] Bug 5981 - OPAC: Add limits to search history Signed-off-by: Katrin Fischer Fixed a conflict in updatedatabase and removed kohaversion.pl from the patch. Patch works nicely, tested with different searches and limits. Note: Sort options don't get into the history still. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 12:21:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 10:21:42 +0000 Subject: [Koha-bugs] [Bug 5981] OPAC: Add limits to search history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de Version|rel_3_4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 12:37:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 10:37:18 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |chris at bigballofwax.co.nz --- Comment #24 from Chris Cormack --- I agree with Paul, this is a test patch ... someone wrote a test!! we should be giving them flowers not making it harder for it to get into Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 12:50:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 10:50:08 +0000 Subject: [Koha-bugs] [Bug 7905] Multi-line notes are displayed on one line in Staff Serials page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7905 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8924|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 10317 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10317&action=edit [SIGNED-OFF] Bug 7905: display serial notes on several lines Signed-off-by: Katrin Fischer Patch works and makes use of TT filters! I agree the display could be improved to work a bit nicer for long lines or multi-line comments, but this is still a nice improvement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 12:50:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 10:50:48 +0000 Subject: [Koha-bugs] [Bug 7905] Multi-line notes are displayed on one line in Staff Serials page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7905 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 13:24:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 11:24:01 +0000 Subject: [Koha-bugs] [Bug 4222] Nonpublic note not appearing in the staff client In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4222 --- Comment #39 from Jared Camins-Esakov --- (In reply to comment #38) > I think it is worse, because now you have data stored, you can no longer > edit or even access. It will stay in the more_subfields_xml column until you > edit an item and at that point it will get deleted. I must have had something misconfigured, because when I tried editing a record with data in the subfield $x, the data showed up in the edit item screen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 13:45:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 11:45:45 +0000 Subject: [Koha-bugs] [Bug 8256] Reports webservice should allow selection by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10314|0 |1 is obsolete| | --- Comment #8 from Jared Camins-Esakov --- Created attachment 10318 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10318&action=edit Thanks, Katrin, for testing! Bug 8256: Teach webservice to select reports by name Adds the ability to pass a hash to C4::Reports::Guided::get_saved_report which specifies a name or id to select the report. Test plan: 1. Create a report (or choose an existing one), and mark it public 2. Run the report using the web service: [IntranetBaseURL]/cgi-bin/koha/svc/report?id=whatever 3. Confirm you get the expected results 4. Run the report by name using the web service: [IntranetBaseURL]/cgi-bin/koha/svc/report?name=[Report name] (keep spaces in the name) 5. Confirm you get the same results 6. Run the report using the public web service: [OPACBaseURL]/cgi-bin/koha/svc/report?id=whatever 7. Confirm you get the same results 8. Run the report by name using the public web service: [OPACBaseURL]/cgi-bin/koha/svc/report?name=[Report name] (keep spaces in the name) 9. Confirm you get the same results 10. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 13:47:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 11:47:05 +0000 Subject: [Koha-bugs] [Bug 8256] Reports webservice should allow selection by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 14:20:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 12:20:43 +0000 Subject: [Koha-bugs] [Bug 7905] Multi-line notes are displayed on one line in Staff Serials page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7905 --- Comment #5 from Katrin Fischer --- Created attachment 10319 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10319&action=edit Bug 7905: Follow up - Multi-line subscription notes This patch adds the TT filter to other places where we are displaying the subscription notes: - OPAC detail page, subscription tab - OPAC subscription brief history page - Staff detail page, subscription tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 14:31:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 12:31:03 +0000 Subject: [Koha-bugs] [Bug 8256] Reports webservice should allow selection by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10318|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer --- Created attachment 10320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10320&action=edit [SIGNED-OFF] Bug 8256: Teach webservice to select reports by name Adds the ability to pass a hash to C4::Reports::Guided::get_saved_report which specifies a name or id to select the report. Test plan: 1. Create a report (or choose an existing one), and mark it public 2. Run the report using the web service: [IntranetBaseURL]/cgi-bin/koha/svc/report?id=whatever 3. Confirm you get the expected results 4. Run the report by name using the web service: [IntranetBaseURL]/cgi-bin/koha/svc/report?name=[Report name] (keep spaces in the name) 5. Confirm you get the same results 6. Run the report using the public web service: [OPACBaseURL]/cgi-bin/koha/svc/report?id=whatever 7. Confirm you get the same results 8. Run the report by name using the public web service: [OPACBaseURL]/cgi-bin/koha/svc/report?name=[Report name] (keep spaces in the name) 9. Confirm you get the same results 10. Sign off Signed-off-by: Katrin Fischer - Adding, editing and deleting reports works - id parameter works - new name parameter works - public and non-public works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 14:31:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 12:31:37 +0000 Subject: [Koha-bugs] [Bug 8256] Reports webservice should allow selection by name In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8256 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 14:50:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 12:50:31 +0000 Subject: [Koha-bugs] [Bug 8191] New value for 8 position in coded data field 100 in unimarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8191 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9923|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 10321 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10321&action=edit [SIGNED-OFF] Bug 8191 : Adding a new value to 8 position of coded data field 100 From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 14:50:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 12:50:44 +0000 Subject: [Koha-bugs] [Bug 8191] New value for 8 position in coded data field 100 in unimarc In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8191 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 15:00:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 13:00:25 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 --- Comment #14 from Katrin Fischer --- Created attachment 10322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10322&action=edit Bug 8143: Follow up - Fixing tabs when editing subfields Fixes broken layout on page for editing subfields of a field in bibliographic MARC frameworks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Jun 16 15:02:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Jun 2012 13:02:15 +0000 Subject: [Koha-bugs] [Bug 8143] Upgrade jQuery tabs to current jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8143 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10322|0 |1 is obsolete| | --- Comment #15 from Katrin Fischer --- Comment on attachment 10322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10322 Bug 8143: Follow up - Fixing tabs when editing subfields Missed there is already a patch on bug 8229 :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 06:54:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 04:54:10 +0000 Subject: [Koha-bugs] [Bug 8071] link beween bib and authorities with the authid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8071 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer --- Hi, this is marked as blocker, but I am not sure how to test it. Can you perhaps provide a test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 07:18:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 05:18:06 +0000 Subject: [Koha-bugs] [Bug 8257] New: Translation scripts show lots of warnings Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8257 Priority: P5 - low Change sponsored?: --- Bug ID: 8257 CC: frederic at tamil.fr Assignee: koha-bugs at lists.koha-community.org Summary: Translation scripts show lots of warnings Severity: normal Classification: Unclassified OS: All Reporter: katrin.fischer at bsz-bw.de Hardware: All Status: NEW Version: master Component: I18N/L10N Product: Koha When running the translation scripts with "perl translate install ..." a lot of warnings are shown: Use of uninitialized value in pattern match (m//) at /usr/share/perl5/Locale/PO.pm line 472, line 95569. Use of uninitialized value $key in hash element at /usr/share/perl5/Locale/PO.pm line 472, line 95569. Use of uninitialized value in pattern match (m//) at /usr/share/perl5/Locale/PO.pm line 472, line 95569. Use of uninitialized value in hash element at /usr/share/perl5/Locale/PO.pm line 343, line 95569. ... My test was on current master with uk-UA, but it also happens with other languages. Translation process still seems to be working and finishes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 07:25:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 05:25:22 +0000 Subject: [Koha-bugs] [Bug 6554] Broken encoding in members home/search page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6554 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 --- Comment #33 from Katrin Fischer --- I installed uk-UA (Ukrainian) and tried to replicate the display problems. I checked the item type page, creating new itemtypes with "ukrainian" (copied some strings from other places) descriptions, I checked the Z39.50 page and the system preferences. I am not sure how to test this, without being able to replicate the problem. Dobrica, can you help? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 07:40:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 05:40:14 +0000 Subject: [Koha-bugs] [Bug 8241] Remove stray references to YUI autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8241 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10251|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 10323 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10323&action=edit [SIGNED-OFF] Bug 8241 - Remove stray references to YUI autocomplete - Removing unused references to YUI assets in authorities/auth_finder.tt - Removing unneeded call to autocomplete JS in help-top.inc and adding new jQuery dependencies. - Minor HTML markup corrections to auth-finder-search.inc discovered in debugging the patch. Signed-off-by: Katrin Fischer Tested: - help files on various pages - auth finder plugin in cataloguing - authority search in authorities module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 07:40:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 05:40:26 +0000 Subject: [Koha-bugs] [Bug 8241] Remove stray references to YUI autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8241 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 07:43:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 05:43:49 +0000 Subject: [Koha-bugs] [Bug 8241] Remove stray references to YUI autocomplete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8241 --- Comment #3 from Katrin Fischer --- Created attachment 10324 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10324&action=edit Bug 8241: Remove text fragment from Z39.50-Server search Removes an accidently added "curr" from below the search options for administration > Z39.50 client targets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 07:45:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 05:45:06 +0000 Subject: [Koha-bugs] [Bug 8224] aqplan.pl and aqbudgets: authorized values doesn't appear in planning list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8224 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|rel_3_8 |master Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 07:50:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 05:50:57 +0000 Subject: [Koha-bugs] [Bug 8224] aqplan.pl and aqbudgets: authorized values doesn't appear in planning list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8224 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10158|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 10325 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10325&action=edit [SIGNED-OFF] Bug 8224 - Make authorized values appear in planning list Signed-off-by: Katrin Fischer I can confirm the bugs on current master and this patch fixes both problems. - Pull down list for "Planning" on the budget page was not showing categories of authorized values - Planning page showed the categories, but budget_period_id was missing from the URL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 07:51:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 05:51:14 +0000 Subject: [Koha-bugs] [Bug 8224] aqplan.pl and aqbudgets: authorized values doesn't appear in planning list In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8224 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 07:52:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 05:52:43 +0000 Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de Version|rel_3_8 |master --- Comment #14 from Katrin Fischer --- Switching this to "Signed off", because of Nicole's comment and attached patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 07:55:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 05:55:12 +0000 Subject: [Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 CC| |katrin.fischer at bsz-bw.de Version|rel_3_4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 08:06:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 06:06:58 +0000 Subject: [Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3480|0 |1 is obsolete| | Attachment #10029|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 10326 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10326&action=edit [SIGNED-OFF] Bug 5979 : OPAC : using OPACISBD systempreference to display link The OPACISBD system preference is used in order to be able to have one ISBD for OPAC another one for intranet. But the link ISBD at OPAC was depending on the presence or absence of value in ISBD which is for intranet. This patch fixes the behaviour to depend on the correct system preference at OPAC Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 08:07:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 06:07:15 +0000 Subject: [Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 --- Comment #8 from Katrin Fischer --- Created attachment 10327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10327&action=edit [SIGNED-OFF] Bug 5979 - Follow up: using OPACISBD systempreference to display link Signed-off-by: Katrin Fischer Verified that new system preference is added cleanly and ISBD view can be configured independently for staff and OPAC using OPACISBD and viewISBD system preferences. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 08:07:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 06:07:25 +0000 Subject: [Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to display link In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 09:26:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 07:26:32 +0000 Subject: [Koha-bugs] [Bug 4048] CSS and JS libs must be outside of translated paths In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4048 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Katrin Fischer --- I checked out Owen's branch and applied Julian's patches on top of those. I had to fix some conflicts in the second patch, which I hopefully did right. I then deleted the lib, css and js directories from intranet-tmpl. Following problems have been found while testing: 1) http://localhost:8080/cgi-bin/koha/about.pl > Tabs are broken 2) http://localhost:8080/cgi-bin/koha/admin/systempreferences.pl > New preference button broken 3) http://localhost:8080/cgi-bin/koha/admin/branches.pl > New buttons are broken 4) http://localhost:8080/cgi-bin/koha/admin/itemtypes.pl?op=add_form&itemtype=BK > tabs layout slightly broken, still functional 5) http://localhost:8080/cgi-bin/koha/admin/authorised_values.pl > toolbar broken 6) http://localhost:8080/cgi-bin/koha/admin/authorised_values.pl?op=add_form&id=21&offset=0 > tabs layout slightly broken, still functional 7) http://localhost:8080/cgi-bin/koha/cataloguing/addbooks.pl > toolbar broken 8) http://localhost:8080/cgi-bin/koha/cataloguing/addbiblio.pl > layout of framework and tabs broken 9) http://localhost:8080/cgi-bin/koha/authorities/auth_finder.pl?authtypecode=PERSO_NAME&index=tag_100_subfield_a_320307_288334&value_main= > autocomplete of auth-finder plugin broken Stopping here, I think some problems have the same source, but more work is needed. I think including this in Koha soon would be good, because there is still plenty of time until the next release, so bugs could be found and fixed until then. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 09:45:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 07:45:18 +0000 Subject: [Koha-bugs] [Bug 6713] marc import not matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6713 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #21 from Katrin Fischer --- I used sandbox 3 with current master, to do a first test on the matching. I followed hdl's instructions on comment 18. I don't see problems with the matching algorithm, the results for my second import were perfect: 627 records in file 0 records not staged because of MARC error 627 records staged 627 records with at least one match in catalog per matching rule "ISBN" Not sure how to move on from here? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 09:47:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 07:47:21 +0000 Subject: [Koha-bugs] [Bug 6713] marc import not matching In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6713 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |master Assignee|chris at bigballofwax.co.nz |henridamien.laurent at biblibr | |e.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 09:57:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 07:57:09 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #11 from Katrin Fischer --- Testing shows, that after applying the second patch, the focus is not in the search box. On current HEAD it's ok. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 09:57:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 07:57:21 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 10:05:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 08:05:29 +0000 Subject: [Koha-bugs] [Bug 8194] Layout problem on subscription add when showing manual history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8194 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10298|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 10328 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10328&action=edit [SIGNED-OFF] Bug 8194 - Layout problem on subscription add when showing manual history Markup errors were causing display problems when the "manual history" section is shown. To test, apply the patch, load the subscription add page, and check the "manual history" checkbox. The "Serials planning" section should appear directly below the "manual history" section. Signed-off-by: Katrin Fischer Works nicely. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 10:05:42 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 08:05:42 +0000 Subject: [Koha-bugs] [Bug 8194] Layout problem on subscription add when showing manual history In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8194 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 10:06:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 08:06:48 +0000 Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x or 200$y In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 CC| |katrin.fischer at bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 10:16:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 08:16:00 +0000 Subject: [Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444 --- Comment #17 from Chris Cormack --- Reverted from 3.8.x, so needs to be fixed before the 3.10.0 release -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 10:34:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 08:34:17 +0000 Subject: [Koha-bugs] [Bug 6141] html glitches causing problems to translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 --- Comment #11 from Chris Cormack --- (In reply to comment #10) > Chris, here you go. Does this need to go through so and qa? > > Nope the original one was signed off, and this removes the conflicting code, I will test and push -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 10:45:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 08:45:48 +0000 Subject: [Koha-bugs] [Bug 6141] html glitches causing problems to translator In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6141 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Chris Cormack --- Patch pushed to 3.8.x will be in 3.8.2 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 10:50:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 08:50:12 +0000 Subject: [Koha-bugs] [Bug 8240] There is dead code in orderreceive.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8240 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10244|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer --- Created attachment 10329 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10329&action=edit [SIGNED-OFF] Bug 8240: Remove dead code from orderreceive Signed-off-by: Katrin Fischer Patch removes a lot of code from acquisitions. I tested 2 complete acquisition workflows from ordering the item to receiving it, with AcqCreateItem set to 'on order' and to 'on receive'. Both worked without any visible changes after applying the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 10:50:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 08:50:43 +0000 Subject: [Koha-bugs] [Bug 8240] There is dead code in orderreceive.tt In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8240 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 12:08:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 10:08:26 +0000 Subject: [Koha-bugs] [Bug 8257] Translation scripts show lots of warnings In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8257 Fr?d?ric Demians changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |trivial --- Comment #1 from Fr?d?ric Demians --- > Use of uninitialized value in pattern match (m//) at > /usr/share/perl5/Locale/PO.pm line 472, line 95569. As you can see, it always happens on this line. This is at the end of staff interface .po file. At this place, there are few lines of comments which have nothing to do there. You could delete them, and you will see that the translation script will stop throwing this warning. It's really safe. We may clean all .po files. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 14:50:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 12:50:51 +0000 Subject: [Koha-bugs] [Bug 8255] Local cover images should be cacheable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8255 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 15:21:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 13:21:09 +0000 Subject: [Koha-bugs] [Bug 7442] Crash when selecting an authority with 200$x or 200$y In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7442 --- Comment #7 from Katrin Fischer --- I tried testing this on sandbox2 - I had problems cataloguing a UNIMARC authority that would give me numbers to choose from in the auth finder. Can you perhaps attach some example records I could copy from? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 15:45:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 13:45:15 +0000 Subject: [Koha-bugs] [Bug 6698] Detail page for organisations should show only valid fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6698 --- Comment #9 from Katrin Fischer --- Hi Owen, the rebased patch form MJ applied, but I am wondering about the memberentry screen. In the past it was possible to add as many email addresses and phone numbers to an organisational patron as to a normal patron. After the patch, the number is reduced to one email and one phone number. I am not sure, we can make this change without disconnecting libraries from their entered data. Maybe keep all fields in the screen, but make display on the summary dependent on existance? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 15:45:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 13:45:39 +0000 Subject: [Koha-bugs] [Bug 6698] Detail page for organisations should show only valid fields In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6698 --- Comment #10 from Katrin Fischer --- Created attachment 10330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10330&action=edit screenshot of new member entry screen -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 15:53:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 13:53:53 +0000 Subject: [Koha-bugs] [Bug 8242] Permission for "change password" button in members toolbar should be "borrowers" instead of "staffaccess" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10256|0 |1 is patch| | Attachment #10256|application/octet-stream |text/plain mime type| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 16:07:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 14:07:24 +0000 Subject: [Koha-bugs] [Bug 8242] Permission for "change password" button in members toolbar should be "borrowers" instead of "staffaccess" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|rel_3_8 |master --- Comment #1 from Katrin Fischer --- The change is logical and works as expected. I am only wondering under which circumstances it was possible to reach the page with staffaccess but without borrowers permission? Both the memberentry and the passwordchange template require borrowers permission to be accessible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 16:12:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 14:12:34 +0000 Subject: [Koha-bugs] [Bug 8242] Permission for "change password" button in members toolbar should be "borrowers" instead of "staffaccess" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 --- Comment #2 from Katrin Fischer --- I think at some point in time it was not possible for staff users to change their own or the passwords of other staff members. Passwords could be changed in OPAC or by the superlibrarian. I am not sure when this changed, but the change is not dependend on this patch. Do we want it to work this way or should the former feature be restored? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 16:14:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 14:14:13 +0000 Subject: [Koha-bugs] [Bug 8242] Permission for "change password" button in members toolbar should be "borrowers" instead of "staffaccess" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10256|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer --- Created attachment 10331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10331&action=edit [SIGNED-OFF] Permission for change password button in members toolbar should be borrowers instead of staffaccess http://bugs.koha-community.org/show_bug.cgi?id=8242 Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 16:14:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 14:14:29 +0000 Subject: [Koha-bugs] [Bug 8242] Permission for "change password" button in members toolbar should be "borrowers" instead of "staffaccess" In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8242 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 16:20:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 14:20:13 +0000 Subject: [Koha-bugs] [Bug 3383] Item due reminder digests - cannot display title information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3383 --- Comment #6 from Katrin Fischer --- Hi Kyle, only a short note: <> can be customized using the parameters of the advance_notices.pl cronjob. It would be nice, if the syntax would be made available in the item due and due notices, as it is more flexible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 16:40:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 14:40:41 +0000 Subject: [Koha-bugs] [Bug 3383] Item due reminder digests - cannot display title information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8872|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer --- Created attachment 10332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10332&action=edit [SIGNED-OFF] Bug 3383 - Item due reminder digests - cannot display title information Adds the ability to use branches.* fields in digest notices and have them be parsed correctly. Also adds a warning to the notices editor for digests. Signed-off-by: Katrin Fischer I like the idea to show a warning, but I would perhaps move it under the message body label to be more obvious. Patch works nicely, branch data of my user's home library is displayed in the notice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 16:40:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 14:40:55 +0000 Subject: [Koha-bugs] [Bug 3383] Item due reminder digests - cannot display title information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3383 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 16:43:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 14:43:53 +0000 Subject: [Koha-bugs] [Bug 8258] New: Branch specific DUEDGST notice is not used Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8258 Priority: P5 - low Change sponsored?: --- Bug ID: 8258 Assignee: koha-bugs at lists.koha-community.org Summary: Branch specific DUEDGST notice is not used Severity: enhancement Classification: Unclassified OS: All Reporter: katrin.fischer at bsz-bw.de Hardware: All Status: NEW Version: master Component: Notices Product: Koha While testing bug 3383 I noticed, that it's possible to add branch specific DUEDGST notices, but they are not used when generating notices. Instead the notice for (All libraries) was being used. My patron's home library was Midway, books were checked out from Midway and another library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 16:44:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 14:44:13 +0000 Subject: [Koha-bugs] [Bug 3383] Item due reminder digests - cannot display title information In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3383 --- Comment #8 from Katrin Fischer --- While testing that, I discovered that my branch specific DUEDGST notice was not being used for my notice. Instead the notice template for (All libraries) was used. Filing separate bug 8258 for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 17:32:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 15:32:48 +0000 Subject: [Koha-bugs] [Bug 8181] Replace DynArch calendar widget with jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer --- Hi Owen, thx for another big patch to add a shiny new calendar :) Your patch applied cleanly, but I found some smaller problems: 1) In the holidays calendar, the calendar does not display, until I copy a calendar somewhere. So for example, the calendar does not show, when I enter the page. Changing the location on top, does not refresh the page or bring up another calendar. 2) In acquisitions late orders the filters do not respect the dateformat setting. I have metric DD/MM/YYYY but the dates from the datepicker are MM/DD/YYYY. In other places like the holiday calendar the display is correct. (acqui/lateorders.pl) Same problem occurs on: acqui/histsearch.pl acqui/parcels.pl admin/aqbudetperiods.pl admin/aqcontract.pl admin/category.pl (stopping here) 3) The tooltip for the calendar shows up as a black box with '...' in it. It was a bit irritating for me, perhaps you have an idea? 4) The today button does not enter today's date, but does switch back to the correct 'page' of the calendar. Today's date is not very clearly marked there. It's not so easy to spot in the calendar. Perhaps it could stand out a bit more? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 18:22:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 16:22:48 +0000 Subject: [Koha-bugs] [Bug 8255] Local cover images should be cacheable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8255 --- Comment #2 from Dobrica Pavlinusic --- Created attachment 10333 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10333&action=edit Bug 8255: allow local cover images to be cached At the moment, local cover images cannot be cached by the web browser or any intermediate reverse proxies. This results in an unnecessary load on the server, and is entirely unnecessary. Signed-off-by: Dobrica Pavlinusic -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 18:23:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 16:23:14 +0000 Subject: [Koha-bugs] [Bug 8255] Local cover images should be cacheable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8255 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10307|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 18:24:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 16:24:02 +0000 Subject: [Koha-bugs] [Bug 8255] Local cover images should be cacheable In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8255 Dobrica Pavlinusic changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Dobrica Pavlinusic --- I think this patch provides more value than I managed to stuff into commit message. Tested with Firefox and Chrome -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 18:34:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 16:34:49 +0000 Subject: [Koha-bugs] [Bug 7001] User Configurable Slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001 --- Comment #108 from Katrin Fischer --- I am not sure why this is in discussion and which patches have been applied already? Can someone explain? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 18:39:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 16:39:47 +0000 Subject: [Koha-bugs] [Bug 8259] New: No longer possible to have multiple serial notices Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8259 Priority: P2 Change sponsored?: --- Bug ID: 8259 Keywords: regression Assignee: koha-bugs at lists.koha-community.org Blocks: 7001 Summary: No longer possible to have multiple serial notices Severity: major Classification: Unclassified OS: All Reporter: katrin.fischer at bsz-bw.de Hardware: All Status: NEW Version: master Component: Notices Product: Koha Late orders in serial claims provides a pull down below the form where you can select which notice template should be used for the serial claim. The pull down used to list all notices that have the right module for serial claiming. This no longer works. To make it worse, I can't create a second notice for the module with a different code and the same library. Every time I save the notice, it gets added to 'all libaries' instead. Editing and changing the library does also not work. Now the pull down should list all notice templates for the user's library + all libraries. This is a regression :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 18:39:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 16:39:47 +0000 Subject: [Koha-bugs] [Bug 7001] User Configurable Slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |8259 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 18:46:16 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 16:46:16 +0000 Subject: [Koha-bugs] [Bug 8259] Library for notices not saving correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8259 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|regression | Summary|No longer possible to have |Library for notices not |multiple serial notices |saving correctly --- Comment #1 from Katrin Fischer --- Ok, I have to correct myself, because now it worked - the pull down contains all notices with serial claims module from the current library and all libraries. The problem is, that the branch is not saving. The list with multiple notices is shown correctly. My logs show following errors: [Sun Jun 17 18:41:35 2012] [error] [client 127.0.0.1] [Sun Jun 17 18:41:35 2012] letter.pl: Use of uninitialized value $module in string eq at /home/katrin/kohaclone/tools/letter.pl line 175., referer: http://localhost:8080/cgi-bin/koha/tools/letter.pl [Sun Jun 17 18:41:35 2012] [error] [client 127.0.0.1] [Sun Jun 17 18:41:35 2012] letter.pl: Use of uninitialized value $module in string eq at /home/katrin/kohaclone/tools/letter.pl line 178., referer: http://localhost:8080/cgi-bin/koha/tools/letter.pl [Sun Jun 17 18:41:35 2012] [error] [client 127.0.0.1] [Sun Jun 17 18:41:35 2012] letter.pl: Use of uninitialized value $module in string eq at /home/katrin/kohaclone/tools/letter.pl line 181., referer: http://localhost:8080/cgi-bin/koha/tools/letter.pl [Sun Jun 17 18:41:35 2012] [error] [client 127.0.0.1] [Sun Jun 17 18:41:35 2012] letter.pl: Use of uninitialized value $module in string eq at /home/katrin/kohaclone/tools/letter.pl line 192., referer: http://localhost:8080/cgi-bin/koha/tools/letter.pl [Sun Jun 17 18:41:35 2012] [error] [client 127.0.0.1] [Sun Jun 17 18:41:35 2012] letter.pl: Use of uninitialized value $module in string eq at /home/katrin/kohaclone/tools/letter.pl line 200., referer: http://localhost:8080/cgi-bin/koha/tools/letter.pl [Sun Jun 17 18:41:35 2012] [error] [client 127.0.0.1] [Sun Jun 17 18:41:35 2012] letter.pl: Problem = a value of 1 has been passed to param without key at /home/katrin/kohaclone/C4/Templates.pm line 187., referer: http://localhost:8080/cgi-bin/koha/tools/letter.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 19:35:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 17:35:49 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #33 from Katrin Fischer --- 1) <>, <> (<>) will not get replaced, when inside of . This is a problem if you want to claim issues for various titles at the same vendor. 2) The date columns are not sorting correctly - only noting, i think that can be fixed later when introducing datatables? 3) CSV export has supplier, title, issue number and late since. Ideally it should also show library, status, claim count and claim date. 4) I am worried, that will not work for HTML notices, as you write. This needs documentation, but it would be better to fix it. Does the tag also not work for HTML notices? 5) When I mark the email template as HTML, it's still sent out as text mail. Failing QA because of 1). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 19:42:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 17:42:37 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #2 from Chris Cormack --- I tested the solr work at kohacon12 and it worked very well. I note that this patch allows us to toggle the syspref and use solr, and toggle it back and be back using zebra. Currently it only effects the opac search, but that is a great place to start. I see no harm in getting this into master as soon as possible so others can work on the Koha::SearchEngine::Zebra more easily. Especially since if you do not choose solr this has no affect on your current system. Exactly the way it should be. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 19:48:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 17:48:18 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10257|0 |1 is obsolete| | --- Comment #3 from Chris Cormack --- Created attachment 10334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10334&action=edit Bug 8233 : SearchEngine: Add a Koha::SearchEngine module First draft introducing solr into Koha :-) List of files : $ tree t/searchengine/ t/searchengine |-- 000_conn | `-- conn.t |-- 001_search | `-- search_base.t |-- 002_index | `-- index_base.t |-- 003_query | `-- buildquery.t |-- 004_config | `-- load_config.t `-- indexes.yaml just do `prove -r t/searchengine/**/*.t` t/lib |-- Mocks | `-- Context.pm `-- Mocks.pm provide a mock to SearchEngine syspref (set_zebra and set_solr). $ tree Koha/SearchEngine Koha/SearchEngine |-- Config.pm |-- ConfigRole.pm |-- FacetsBuilder.pm |-- FacetsBuilderRole.pm |-- Index.pm |-- IndexRole.pm |-- QueryBuilder.pm |-- QueryBuilderRole.pm |-- Search.pm |-- SearchRole.pm |-- Solr | |-- Config.pm | |-- FacetsBuilder.pm | |-- Index.pm | |-- QueryBuilder.pm | `-- Search.pm |-- Solr.pm |-- Zebra | |-- QueryBuilder.pm | `-- Search.pm `-- Zebra.pm How to install and configure Solr ? See the wiki page: http://wiki.koha-community.org/wiki/SearchEngine_Layer_RFC http://bugs.koha-community.org/show_bug.cgi?id=8233 Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 19:50:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 17:50:19 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #4 from Chris Cormack --- I have signed off, and will now send a couple of follow ups to fix updatedatabase and few unconditional warns. But I would urge people to not fail QA on those issues, it is more important to get this up so it can be tested by lots of people.. now while we still have 4 months before the 3.10.0 release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 19:56:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 17:56:06 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 --- Comment #5 from Chris Cormack --- Created attachment 10335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10335&action=edit Bug 8233 fixing the number in updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 19:59:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 17:59:53 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 --- Comment #6 from Chris Cormack --- Actually the warns are only in the Koha::SearchEngine::Zebra::* area, which is totally still being developed, so I think leaving them unqualified for now is ok and as that code is fleshed out and developed we can remove them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 20:04:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 18:04:02 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 --- Comment #7 from Jared Camins-Esakov --- (In reply to comment #6) > Actually the warns are only in the Koha::SearchEngine::Zebra::* area, which > is totally still being developed, so I think leaving them unqualified for > now is ok and as that code is fleshed out and developed we can remove them. For what it's worth, I think unconditional warns in Koha::SearchEngine::Zebra::* are a good idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 20:04:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 18:04:55 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 --- Comment #8 from Jared Camins-Esakov --- (In reply to comment #7) > (In reply to comment #6) > > Actually the warns are only in the Koha::SearchEngine::Zebra::* area, which > > is totally still being developed, so I think leaving them unqualified for > > now is ok and as that code is fleshed out and developed we can remove them. > > For what it's worth, I think unconditional warns in > Koha::SearchEngine::Zebra::* are a good idea. It *is* a good idea. Sorry, I haven't eaten lunch yet and apparently that's affecting my grammar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 21:14:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 19:14:36 +0000 Subject: [Koha-bugs] [Bug 5544] All Notices from Branch Email Address In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5544 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|savitra.sirohi at osslabs.biz |kyle.m.hall at gmail.com QA Contact|koha-bugs at lists.koha-commun | |ity.org | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 21:16:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 19:16:01 +0000 Subject: [Koha-bugs] [Bug 5771] Better error handling for import borrowers - Provide a download file of errors In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5771 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Version|rel_3_4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 21:31:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 19:31:45 +0000 Subject: [Koha-bugs] [Bug 7302] CSV export of a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7302 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9974|0 |1 is obsolete| | Attachment #10150|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer --- Created attachment 10336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10336&action=edit [SIGNED-OFF] Bug 7302: Export basketgroup as CSV Adds new action export for basketgroup. This action is available only if your basketgroup is closed. This export generates a csv file with order informations. Signed-off-by: Katrin Fischer Tested together with bug 5356. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 21:31:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 19:31:55 +0000 Subject: [Koha-bugs] [Bug 7302] CSV export of a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7302 --- Comment #17 from Katrin Fischer --- Created attachment 10337 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10337&action=edit [SIGNED-OFF] Bug 7302: Followup: rename "Client number" column with "Account number" Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 21:32:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 19:32:28 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing addess improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10152|0 |1 is obsolete| | Attachment #10201|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer --- Created attachment 10338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10338&action=edit [SIGNED-OFF] Bug 7302: Followup: rename "Client number" column with "Account number" Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 21:33:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 19:33:28 +0000 Subject: [Koha-bugs] [Bug 7302] CSV export of a basketgroup In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7302 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 21:34:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 19:34:15 +0000 Subject: [Koha-bugs] [Bug 7392] Add system preference to configure export options for OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7392 --- Comment #22 from Katrin Fischer --- Created attachment 10339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10339&action=edit [SIGNED-OFF] Bug 7302: Followup: rename "Client number" column with "Account number" Signed-off-by: Katrin Fischer http://bugs.koha-community.org/show_bug.cgi?id=5356 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 21:37:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 19:37:14 +0000 Subject: [Koha-bugs] [Bug 7392] Add system preference to configure export options for OPAC detail page In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7392 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10339|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer --- Comment on attachment 10339 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10339 [SIGNED-OFF] Bug 7302: Followup: rename "Client number" column with "Account number" wrong bug number, sorry! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 21:43:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 19:43:18 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing addess improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10338|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer --- Created attachment 10340 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10340&action=edit [SIGNED-OFF] Bug 5356: delivery place and billing place centralised in basket management - adding 2 select option in basdketheader.tmpl (delivery and billing place) - adding 2 more fields in basket csv export Signed-off-by: Katrin Fischer Tested together with patches for bug 7302. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 21:43:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 19:43:26 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing addess improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 --- Comment #19 from Katrin Fischer --- Created attachment 10341 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10341&action=edit [SIGNED-OFF] Bug 5356: Followup sort and branchname - Sort is now the same as C4::Branch::GetBranchesLoop - branchcodes are replaced with branchnames Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Jun 17 21:44:15 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 19:44:15 +0000 Subject: [Koha-bugs] [Bug 5356] Shipping billing addess improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5356 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|rel_3_4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 00:27:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Jun 2012 22:27:36 +0000 Subject: [Koha-bugs] [Bug 7295] list of librarian managing a basket In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7295 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer --- Hi Julian, I started testing this today, here are some first notes: 1) The list of libraries is not ordered by description but code. 2) I think it should not be possible to change the branch, when independantbranches is turned on? 3) Why is the default of the branch "no branch"? Shouldn't it be the branch of the basket creator or the branch the staff member is currently logged in at? 4) We keep adding lots of functionality and options to acquisitons. This is good, but also adds a lot of complexity. I think most libraries don't need this granular level of control, so perhaps we should think about moving some of the new features into system preferences. For this feature I think it would be great if unique ids could be added to the
    2. elements on the basket summary page. This way both options can be hidden, if a library does not want to use them. 5) The descriptions of the permissions are not very clear and don't show up next to each other in my installation. I am not sure what can be done about this. There is also bug 3849 about this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 02:30:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 00:30:33 +0000 Subject: [Koha-bugs] [Bug 7001] User Configurable Slips In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7001 --- Comment #109 from Srdjan Jankovic --- This one is pushed to release and definitely should not be discussed here any more. All issues should be opening a new bug and refer to this bug. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 02:42:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 00:42:48 +0000 Subject: [Koha-bugs] [Bug 8247] adding basket doesn't save basket name, internal or vendor note In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8247 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au Depends on| |7757 --- Comment #4 from David Cook --- I was quite confused by this bug until I realized that booksellerid was added to ModBasketHeader in Bug 7757... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 02:42:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 00:42:48 +0000 Subject: [Koha-bugs] [Bug 7757] Edit basket vendor after it has been created In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7757 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8247 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 04:25:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 02:25:45 +0000 Subject: [Koha-bugs] [Bug 8260] New: Routing List Ranking Needs Re-order After Patron Delete Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 Priority: P5 - low Change sponsored?: --- Bug ID: 8260 CC: colin.campbell at ptfs-europe.com Assignee: koha-bugs at lists.koha-community.org Summary: Routing List Ranking Needs Re-order After Patron Delete Severity: minor Classification: Unclassified OS: All Reporter: dcook at prosentient.com.au Hardware: All Status: NEW Version: master Component: Serials Product: Koha Currently, deleting a patron will create a missing value in the ranking of members in a routing list. For instance, the ranking will go 1, 2, 3, 5 in the database when the patron ranked at #4 is deleted. This causes the intranet to display these rankings as 1, 2, 3, 1, since 5 is not a valid option due to there only being 4 entries in the database. I've written up a little re-order function based on the reorder_members function, which just re-orders all the members for that routing list every time routing.pl or routing-preview.pl are called. It might be more ideal to only run it if errors are detected, but that error detection would require more code that might just add more bulk. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 04:25:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 02:25:59 +0000 Subject: [Koha-bugs] [Bug 8260] Routing List Ranking Needs Re-order After Patron Delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |dcook at prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 04:28:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 02:28:13 +0000 Subject: [Koha-bugs] [Bug 8260] Routing List Ranking Needs Re-order After Patron Delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 --- Comment #1 from David Cook --- Actually, I'm not currently running it for routing-preview.pl, since there are no numbers displayed. (In reply to comment #0) > Currently, deleting a patron will create a missing value in the ranking of > members in a routing list. For instance, the ranking will go 1, 2, 3, 5 in > the database when the patron ranked at #4 is deleted. > > This causes the intranet to display these rankings as 1, 2, 3, 1, since 5 is > not a valid option due to there only being 4 entries in the database. > > I've written up a little re-order function based on the reorder_members > function, which just re-orders all the members for that routing list every > time routing.pl or routing-preview.pl are called. > > It might be more ideal to only run it if errors are detected, but that error > detection would require more code that might just add more bulk. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 05:13:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 03:13:54 +0000 Subject: [Koha-bugs] [Bug 8260] Routing List Ranking Needs Re-order After Patron Delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 --- Comment #2 from David Cook --- Created attachment 10342 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10342&action=edit Force re-order of routing list rankings on page load -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 05:19:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 03:19:24 +0000 Subject: [Koha-bugs] [Bug 8260] Routing List Ranking Needs Re-order After Patron Delete In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 06:51:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 04:51:37 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10283|0 |1 is obsolete| | --- Comment #14 from Marc V?ron --- Created attachment 10343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10343&action=edit [SIGNED-OFF] Bug 7671 : add a real primary key accountlinesid in accountlines Signed-off-by: St?phane Delaune Signed-off-by: Marc Veron NOTE: After applying the patch I got following errors in members/pay.pl: Global symbol "$writeoff_sth" requires explicit package name Global symbol "$add_writeoff_sth" requires explicit package name Added to lines at the begin of members/pay.pl: our $writeoff_sth; our $add_writeoff_sth; Now the patch worked as expected. However I am not quite sure if signing off is OK in this situation. Marc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 06:52:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 04:52:57 +0000 Subject: [Koha-bugs] [Bug 7671] add a real primary key "accountlinesid" in accountlines In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7671 Marc V?ron changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 08:34:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 06:34:26 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Marc Balmer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marc at msys.ch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 08:40:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 06:40:10 +0000 Subject: [Koha-bugs] [Bug 5360] From Zebra to solR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5360 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |magnus at enger.priv.no Resolution|--- |DUPLICATE --- Comment #1 from Magnus Enger --- Guess Bug 8233 makes this one obsolete? *** This bug has been marked as a duplicate of bug 8233 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 08:40:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 06:40:10 +0000 Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr without breaking anything else In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233 Magnus Enger changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #9 from Magnus Enger --- *** Bug 5360 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 09:12:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 07:12:53 +0000 Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy at rijksmuseum.nl QA Contact|koha.sekjal at gmail.com |m.de.rooy at rijksmuseum.nl --- Comment #25 from M. de Rooy --- QA Comment: Some points have received attention. The new dependency should be marked optional. Please add it in a followup. The suggested additional options could be handled similarly. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 09:20:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 07:20:08 +0000 Subject: [Koha-bugs] [Bug 8261] New: Cannot search system preferences from Local Use tab Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Priority: P5 - low Change sponsored?: --- Bug ID: 8261 CC: gmcharlt at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Cannot search system preferences from Local Use tab Severity: blocker Classification: Unclassified OS: All Reporter: dcook at prosentient.com.au Hardware: All Status: NEW Version: master Component: System Administration Product: Koha Searching the system preferences from the Local Use tab generates a Software error as follows: "Template process failed: file error - .../intranet/htdocs/intranet-tmpl/prog/en/modules/admin/preferences/all.pref: not found at .../lib/C4/Templates.pm line 127." I notice that early versions (such as 3.2) produce search results under an "all preferences" heading. However, I don't see an all.pref file in 3.2 either. The "all preferences" result list seems archaic though, since searching "OPAC" or "MARC" from any other tab provides a much more well formatted list where results are grouped by tab and subheading. Any thoughts on this one? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 09:30:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 07:30:22 +0000 Subject: [Koha-bugs] [Bug 8262] New: Could not add or create List in koha 3.8.1 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 Priority: P5 - low Change sponsored?: --- Bug ID: 8262 Assignee: gmcharlt at gmail.com Summary: Could not add or create List in koha 3.8.1 Severity: enhancement Classification: Unclassified OS: Linux Reporter: bondwal.amit at gmail.com Hardware: PC Status: NEW Version: rel_3_8 Component: Architecture, internals, and plumbing Product: Koha Hi Folks, I am new to koha, I installed koha 3.8.1 on centos 6.2 working fine, but when I tried to use List option on administration, It did not create List. When I tried to create a new List, It open popup window and ask for List Name and Select public and private etc., When I saved the List it shows nothing in Lists. Please help me. Thanks and regards Amit Bondwal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 09:34:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 07:34:14 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|adrien.saurat at biblibre.com |jonathan.druart at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 09:36:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 07:36:09 +0000 Subject: [Koha-bugs] [Bug 7411] remove diacritics when automatically generating userid In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7411 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #11 from M. de Rooy --- Please add to C4::Installer::PerlDependencies -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 09:52:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 07:52:19 +0000 Subject: [Koha-bugs] [Bug 4246] Koha support for Itiva Talking Tech phone notification service In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #21 from M. de Rooy --- [Mon Jun 18 09:43:38 2012] updatedatabase.pl: DBD::mysql::db do failed: Cannot add or update a child row: a foreign key constraint fails (`kohatest`.`message_transports`, CONSTRAINT `message_transports_ibfk_1` FOREIGN KEY (`message_attribute_id`) REFERENCES `message_attributes` (`message_attribute_id`) ON DELETE CASCADE ON UPDAT) at /usr/share/koha/testclone/installer/data/mysql/updatedatabase.pl line 5359. I checked and see that I do not have attribute 2 in my atts table? You refer to it in: (2, 'phone', 0, 'circulation', 'PREDUE_PHONE') Line 5362 insert on message_transports. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 10:19:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 08:19:06 +0000 Subject: [Koha-bugs] [Bug 8154] The export today's checked in barcodes generated file is always empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10000|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart --- Created attachment 10344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10344&action=edit Bug 8154: The export today's checked in barcodes generated file is always empty Comparation of date and datetime is always false -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 10:19:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 08:19:23 +0000 Subject: [Koha-bugs] [Bug 8154] The export today's checked in barcodes generated file is always empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 10:20:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 08:20:10 +0000 Subject: [Koha-bugs] [Bug 8262] Could not add or create List in koha 3.8.1 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8262 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #1 from M. de Rooy --- Hi Amit, Could you please describe the exact steps to reproduce your problem. The more details you provide, the better help you may get. Are you using opac or staff client? Are you logged in? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 10:32:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 08:32:03 +0000 Subject: [Koha-bugs] [Bug 7857] database upgrade fails with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7857 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10287|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart --- Created attachment 10345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10345&action=edit Bug 7857 - [SIGNED-OFF] database upgrade fails with plack This patch fixes PERL5LIB path injection to include installer dir which is required Signed-off-by: Jonathan Druart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 10:38:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 08:38:14 +0000 Subject: [Koha-bugs] [Bug 7857] database upgrade fails with plack In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7857 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Jonathan Druart --- Last patch is trivial and makes sense. I passed QA these 3 patchs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 10:39:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 08:39:36 +0000 Subject: [Koha-bugs] [Bug 8263] New: Make OPAC stylesheet preferences more consistent Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 Priority: P5 - low Change sponsored?: --- Bug ID: 8263 Assignee: m.de.rooy at rijksmuseum.nl Summary: Make OPAC stylesheet preferences more consistent Severity: enhancement Classification: Unclassified OS: All Reporter: m.de.rooy at rijksmuseum.nl Hardware: All Status: ASSIGNED Version: master Component: OPAC Product: Koha opaccolorstylesheet should support remotes, but does not work. opaclayoutstylesheet and opacstylesheet could just be one pref (just as opaccolorstylesheet already advertises) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 10:47:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 08:47:30 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10021|0 |1 is obsolete| | Attachment #10162|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart --- Created attachment 10346 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10346&action=edit Bug 8217: Followup: move code to the document.ready function Oups, it's my fault. This one should be correct (First patch marked as obsolete. It's already pushed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 10:47:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 08:47:37 +0000 Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff search) In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 11:59:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 09:59:23 +0000 Subject: [Koha-bugs] [Bug 5342] Serial claiming improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5342 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #34 from Jonathan Druart --- (In reply to comment #33) Hi Katrin, thank for your tests ! > 1,4 and 5) My test seems good. Could you test the following procedure please: 1/ Create a notice with === BEGIN === <> <> <> <> <> (<>) === END === and don't select the checkbox "HTML message". (note the "order" tag could be "whatever") 2/ Claim 2 serials. My result: === BEGIN === firstname joubu_admin my_email at example.org Title1 author1 (1) Title2 author2 (2) === END === 3/ Edit the letter and mark it as "HTML message" with : === BEGIN === <> <> <>
      • <> <> (<>)
      === END === 4/ make claims. My result: === BEGIN === firstname joubu_admin my_email at example.org
      • Title1 author1 (1)
      • Title2 author2 (2)
      === END === It seems works as expected. > 2) The date columns are not sorting correctly - only noting, i think that > can be fixed later when introducing datatables? Yes, later :) > 3) CSV export has supplier, title, issue number and late since. Ideally it > should also show library, status, claim count and claim date. It's not the goal of this patch. It does not modify the export feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 12:32:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 10:32:24 +0000 Subject: [Koha-bugs] [Bug 6939] DefaultClassificationSource not used in 942$2 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6939 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |colin.campbell at ptfs-europe. | |com --- Comment #1 from Colin Campbell --- Created attachment 10347 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10347&action=edit Proposed Patch With this patch applied the value of the syspref should be reflected in the default value for 942 $2 in Add MARC Record (Marc21) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 12:35:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 10:35:48 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10308|0 |1 is obsolete| | --- Comment #3 from Julian Maurice --- Created attachment 10348 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10348&action=edit [SIGNED-OFF] Bug 8251 - Patrons get incorrectly debarred I can confirm the problem, and that the patch fix it. Signed off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 12:35:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 10:35:55 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 12:46:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 10:46:24 +0000 Subject: [Koha-bugs] [Bug 8261] Cannot search system preferences from Local Use tab In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz Severity|blocker |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 13:26:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 11:26:56 +0000 Subject: [Koha-bugs] [Bug 8243] calendar being ignored In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8243 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 8110 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 13:26:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 11:26:56 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 --- Comment #4 from Kyle M Hall --- *** Bug 8243 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 13:28:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 11:28:41 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 --- Comment #5 from Kyle M Hall --- Created attachment 10349 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10349&action=edit Holidays Test Plan - DB Dependent This test file is meant to be used with the sample database with a minimum of the sample libraries and sample holidays installed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 13:30:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 11:30:23 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall at gmail.com --- Comment #6 from Kyle M Hall --- While the non-db-dependent Kalendar.t passes all tests, this new db-dependent test plan fails all tests where it should return 1 ( i.e. yes, this is a holiday ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 13:43:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 11:43:28 +0000 Subject: [Koha-bugs] [Bug 8264] New: local cover images not working in IE8 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8264 Priority: P5 - low Change sponsored?: --- Bug ID: 8264 Assignee: gmcharlt at gmail.com Summary: local cover images not working in IE8 Severity: major Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Tools Product: Koha Created attachment 10350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10350&action=edit local image showing in ff Local cover image thumbnails are not showing in IE8. Same search displays in Firefox. In IE, images only show at bottom of OPAC Details page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 13:43:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 11:43:48 +0000 Subject: [Koha-bugs] [Bug 8264] local cover images not working in IE8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8264 --- Comment #1 from Nicole C. Engard --- Created attachment 10351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10351&action=edit opac detail in ie8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 13:44:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 11:44:06 +0000 Subject: [Koha-bugs] [Bug 8264] local cover images not working in IE8 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8264 --- Comment #2 from Nicole C. Engard --- Created attachment 10352 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10352&action=edit ie8 search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 14:02:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 12:02:26 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 --- Comment #7 from Kyle M Hall --- It appears that *most* of my test fails because the default holidays data has no branchcode. There is no way to set pan-branch holidays within Koha, so I will consider the lack of branchcodes in the test data to be the bug. However, the plan is still failing on some tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 14:10:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 12:10:46 +0000 Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at checkin In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at biblibre.co | |m --- Comment #4 from Jonathan Druart --- QA Comments: This patch looks good and fixes the reported issue. But a followup is required for several reasons: 1/ Il would be great to replace all occurrences of the truncate routine : truncate( to => 'days' ); with truncate( to => 'day' ); (with specifications from doc http://search.cpan.org/~drolsky/DateTime-0.75/lib/DateTime.pm) 2/ I think that the same fix should be made for the routine hours_between. But I am not sure about this :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 14:17:23 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 12:17:23 +0000 Subject: [Koha-bugs] [Bug 6858] Adds staticfines.pl for static fines processing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6858 Viktor Sarge changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge at regionhalland. | |se --- Comment #29 from Viktor Sarge --- This one sounds just like what I will need for migrating a library I have coming up. But is it possible already to separate so that overdue loans get charged right away if there are holds on them - while loans with no holds get charged after say a week? And if that can be done - can I also set separate rules for rental media? I know this question is a bit OT with all the testing discussions going on, but I?d love to know how much can be done with this patch and what we?d have to expand the functionality. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 14:19:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 12:19:41 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 --- Comment #8 from Kyle M Hall --- Created attachment 10353 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10353&action=edit 8110 - Fines accruing on closed days - Fix Day/Month Holidays Bug This patch fixes a bug in which day/month holidays are stored in the Koha::Calendar internal hash not by month/day but incorrectly by day/month. To test: 1) Apply 'Holidays Test Plan - DB Dependent' patch, create MPL holidays for Sunday, New Years Day, and Christmas. 2) Run test plan, only Christmas should fail ( New Years does not because 1-1 means the day and month position do not matter ). 3) Apply this patch 4) Run test plan again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 14:20:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 12:20:02 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 14:36:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 12:36:11 +0000 Subject: [Koha-bugs] [Bug 8263] Make OPAC stylesheet preferences more consistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 --- Comment #1 from M. de Rooy --- Created attachment 10354 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10354&action=edit Patch for 8263 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 14:38:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 12:38:18 +0000 Subject: [Koha-bugs] [Bug 8263] Make OPAC stylesheet preferences more consistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 --- Comment #2 from M. de Rooy --- Created attachment 10355 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10355&action=edit Database revision for 8263 This patch handles the dbrev for this report. It optionally saves the value of the former opacstylesheet pref into opaclayoutstylesheet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 14:48:14 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 12:48:14 +0000 Subject: [Koha-bugs] [Bug 8263] Make OPAC stylesheet preferences more consistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 --- Comment #3 from M. de Rooy --- Test the second (dbrev) patch with: Before applying the patch, put a remote URL in pref opacstylesheet. Apply the patch and run the dbrev (cgi-bin/koha/installer/install.pl?step=3). Check if opaclayoutstylesheet now contains your URL. Test the first (functionality) patch with: 1) Blank opaccolorstylesheet. 2) Put colors.css into opaccolorstylesheet. (By default, this file is empty. But note that it should list now in the opac html page source. Right-click in your browser and find that option in the menu.) 3) Put a full URL (could be your own webserver) starting with http:// into opaccolorstylesheet. Check opac again. 4) Blank opaclayoutstylesheet. Do you have default styles in opac? 5) Put opac.css into opaclayoutstylesheet. No difference? That is expected. 6) Put a full URL into opaclayoutstylesheet. If you have a different stylesheet, put that in with the full http:// prefix. Check your opac. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 14:48:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 12:48:47 +0000 Subject: [Koha-bugs] [Bug 8263] Make OPAC stylesheet preferences more consistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 16:56:52 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 14:56:52 +0000 Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion librairy In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #10 from Paul Poulain --- I agree with Jonathan's comment here : it is as clean as possible with the current code imo. Rewritting it "from scratch" is another thing. Maybe, as we spoke of the Koha:: during the hackfest, that's something that could emerge here. But it's another topic. I propose to Switch back to "signed off" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 17:03:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 15:03:51 +0000 Subject: [Koha-bugs] [Bug 8265] New: Allow a better form of the title to be included in notices Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8265 Priority: P5 - low Change sponsored?: --- Bug ID: 8265 Assignee: koha-bugs at lists.koha-community.org Summary: Allow a better form of the title to be included in notices Severity: enhancement Classification: Unclassified OS: All Reporter: robin at catalyst.net.nz Hardware: All Status: NEW Version: unspecified Component: Notices Product: Koha When you put biblio.title in a notice, it doesn't include the subtitle. Including the subtitle is both good, and trickier than you'd expect as there's no column for it. I plan to make a 'biblioitems.fulltitle' thing that will make a well-formatted title for notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 17:04:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 15:04:03 +0000 Subject: [Koha-bugs] [Bug 8265] Allow a better form of the title to be included in notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8265 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |robin at catalyst.net.nz |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 17:16:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 15:16:55 +0000 Subject: [Koha-bugs] [Bug 5360] From Zebra to solR In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5360 --- Comment #2 from claire.hernandez at biblibre.com --- Yep, thanks Magnus, I did a new rfc and a new bugzilla because "approach" was different (and seems working better). -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 18:37:33 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 16:37:33 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Nicole C. Engard changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|savitra.sirohi at osslabs.biz |kyle.m.hall at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 18:38:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 16:38:26 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10353|0 |1 is obsolete| | --- Comment #9 from Liz Rea --- Created attachment 10356 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10356&action=edit 8110 - Fines accruing on closed days - Fix Day/Month Holidays Bug This patch fixes a bug in which day/month holidays are stored in the Koha::Calendar internal hash not by month/day but incorrectly by day/month. To test: 1) Apply 'Holidays Test Plan - DB Dependent' patch, create MPL holidays for Sunday, New Years Day, and Christmas. 2) Run test plan, only Christmas should fail ( New Years does not because 1-1 means the day and month position do not matter ). 3) Apply this patch 4) Run test plan again Signed-off-by: Liz Rea Test plan works as advertised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 18:42:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 16:42:50 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 18:47:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 16:47:27 +0000 Subject: [Koha-bugs] [Bug 8266] New: remove location from pull down on search Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8266 Priority: P5 - low Change sponsored?: --- Bug ID: 8266 Assignee: gmcharlt at gmail.com Summary: remove location from pull down on search Severity: enhancement Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Searching Product: Koha I'm thinking that now that you can add in a limit on shelving location we should remove it from the pull down options at the top of the advanced search page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 19:54:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 17:54:01 +0000 Subject: [Koha-bugs] [Bug 8267] New: Overdue notices not working Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8267 Priority: P5 - low Change sponsored?: --- Bug ID: 8267 Assignee: koha-bugs at lists.koha-community.org Summary: Overdue notices not working Severity: enhancement Classification: Unclassified OS: All Reporter: kyle.m.hall at gmail.com Hardware: All Status: NEW Version: master Component: Notices Product: Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 19:54:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 17:54:32 +0000 Subject: [Koha-bugs] [Bug 8267] Overdue notices not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8267 --- Comment #1 from Kyle M Hall --- Created attachment 10357 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10357&action=edit Bug 8267 - Overdue notices not working -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 20:01:40 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 18:01:40 +0000 Subject: [Koha-bugs] [Bug 8267] Overdue notices not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8267 --- Comment #2 from Kyle M Hall --- The variable $i was being re-used and overwriting the necessary value that was being passed to a subroutine. Renaming $i to $j fixed it. I also added an extra safety check within parse_letter that would also have prevented this bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 20:20:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 18:20:32 +0000 Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8268 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 20:20:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 18:20:32 +0000 Subject: [Koha-bugs] [Bug 8268] New: Koha should offer way to backup entire db Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268 Priority: P5 - low Change sponsored?: --- Bug ID: 8268 Assignee: gmcharlt at gmail.com Summary: Koha should offer way to backup entire db Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins at cpbibliography.com Hardware: All Status: NEW Version: master Component: Database Depends on: 8202 Product: Koha Right now, if libraries with hosted installations want copies of the database for backup purposes, they have to request that their vendors provide them with a copy. It would be helpful if it were possible for vendors to easily enable their customers to easily download backups of the database via the Export tool. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 23:44:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 21:44:51 +0000 Subject: [Koha-bugs] [Bug 8268] Koha should offer way to backup entire db In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268 --- Comment #1 from Jared Camins-Esakov --- Created attachment 10358 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10358&action=edit Bug 8268: Add database dump to export tool This patch builds on work by Lars Wirzenius for the Koha packages. To date, the only way for a Koha librarian to obtain a complete backup of their system has been to log into the system via SSH (or FTP) to download the mysqldump file. This patch makes it possible for superlibrarians in properly configured systems to download night backups via the staff client's Export tool. Recognizing that this is functionality with potentially very grave security implications, system administrators must manually enable these features in the koha-conf.xml configuration file. The following configuration settings have been added to the koha-conf.xml file: * backupdir => directory where backups should be stored. * backup_db_via_tools => whether to allow superlibrarians to download database backups via the Export tool. The default is disabled, and there is no way -- by design -- to enable this option without manually editing koha-conf.xml. * backup_conf_via_tools => whether to allow superlibrarians to download configuration backups via the Export tool (this may be applicable to packages only). The default is disabled, and there is no way -- by design -- to enable this option without manually editing koha-conf.xml. This commit modifies the following scripts to make use of the new backupdir configuration option: * koha-dump and koha-run-backups in the Debian packages * The sample backup script misc/cronjobs/backup.sh Note that for security reasons, superlibrarians will not be allowed to download files that are not owned by the web server's effective user. This imposes a de facto dependency on ITK (for Apache) or running the web server as the Koha user (as is done with Plack). To test: 1. Apply patch. 2. Go to export page as a superlibrarian. Notice that no additional export options appear because they have not been enabled. 3. Add $KOHADEV/var/spool to the section of your koha-conf.xml (note that you will need to adjust that so that it is pointing at a logical directory). 4. Create the aforementioned directory. 5. Go to export page as a superlibrarian. Notice that no additional export options appear because they have not been enabled. 6. Add 1 to the section of your koha-conf.xml 7. Go to the export page as a superlibrarian. Notice the new tab. 8. Go to the export page as a non-superlibrarian. Notice there is no new tab. 9. Run: mysqldump -u koha -p koha | gzip > $BACKUPDIR/backup.sql.gz (substituting appropriate user, password, and database name) 10. Go to the export page as a superlibrarian, and look at the "Export database" tab. If you are running the web server as your Koha user, and ran the above command as your Koha user, you should now see the file listed as an option for download. 11. If you *did* see the file listed, change the ownership to something else: sudo chown root:root $BACKUPDIR/backup.sql.gz 11a. Confirm that you no longer see the file listed when you look at the "Export database" tab. 12. Change the ownership on the file to your web server (or Koha) user: sudo chown www-data:www-data backup.sql.gz 13. Go to the export page as a superlibrarian, and look at the "Export database" tab. You should now see backup.sql.gz listed. 14. Choose to download backup.sql.gz 15. Confirm that the downloaded file is what you were expecting. If you are interested, you can repeat the above steps but replace with , and instead of creating an sql file, create a tar file. To test packaging: run koha-dump, confirm that it still creates a usable backup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Jun 18 23:45:34 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Jun 2012 21:45:34 +0000 Subject: [Koha-bugs] [Bug 8268] Koha should offer way to backup entire db In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt at gmail.com |jcamins at cpbibliography.com --- Comment #2 from Jared Camins-Esakov --- Note that the patch will not apply without bug 8202. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 05:30:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 03:30:00 +0000 Subject: [Koha-bugs] [Bug 8269] New: kc.org/about/history needs to be updated automatically from the Koha git repo Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8269 Priority: P5 - low Change sponsored?: --- Bug ID: 8269 Assignee: wizzyrea at gmail.com Summary: kc.org/about/history needs to be updated automatically from the Koha git repo Severity: enhancement Classification: Unclassified OS: All Reporter: mtj at kohaaloha.com Hardware: All Status: NEW Version: master Component: Websites, Mailing Lists, etc Product: Koha kc.org's about/history page needs a method to be updated automatically from the Koha git repo it's currently quite out-of-date http://koha-community.org/about/history/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 10:12:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 08:12:26 +0000 Subject: [Koha-bugs] [Bug 8270] New: Software error: Can't call method "subfield" on an undefined value at /usr/share/koha/lib/C4/Biblio.pm line 2919 Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8270 Priority: P5 - low Change sponsored?: --- Bug ID: 8270 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: Software error: Can't call method "subfield" on an undefined value at /usr/share/koha/lib/C4/Biblio.pm line 2919 Severity: enhancement Classification: Unclassified OS: Linux Reporter: therrsonne02 at yahoo.com Hardware: PC Status: NEW Version: rel_3_8 Component: Circulation Product: Koha Created attachment 10359 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10359&action=edit Software error at line 2919 When we are trying to checkout/checkin an item an error prompts like this "Can't call method "subfield" on an undefined value at /usr/share/koha/lib/C4/Biblio.pm line 2919. I have this in my url address: "192...:8080/cgi-bin/koha/reserved/renewscript.pl" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 10:13:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 08:13:24 +0000 Subject: [Koha-bugs] [Bug 8270] Software error: Can't call method "subfield" on an undefined value at /usr/share/koha/lib/C4/Biblio.pm line 2919 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8270 chester barut changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10359|Software error at line 2919 |Software error at Biblio.pm description| |line 2919 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 11:01:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 09:01:05 +0000 Subject: [Koha-bugs] [Bug 8265] Allow a better form of the title to be included in notices In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8265 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW CC| |robin at catalyst.net.nz Assignee|robin at catalyst.net.nz |koha-bugs at lists.koha-commun | |ity.org --- Comment #1 from Robin Sheat --- Unfortunately, my plan has had to change. Leaving this here as a wishlist because I think it's a good idea. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 11:12:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 09:12:11 +0000 Subject: [Koha-bugs] [Bug 8268] Koha should offer way to backup entire db In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268 Robin Sheat changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 11:18:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 09:18:12 +0000 Subject: [Koha-bugs] [Bug 8268] Koha should offer way to backup entire db In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268 Marc Balmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |marc at msys.ch --- Comment #3 from Marc Balmer --- This is incomplete. There should be a way to create a backup in a database independent way. E.g., in the backup.sh script use a switch statement to call whatever dumper is needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 11:21:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 09:21:08 +0000 Subject: [Koha-bugs] [Bug 8268] Koha should offer way to backup entire db In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268 Marc Balmer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 11:28:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 09:28:22 +0000 Subject: [Koha-bugs] [Bug 7684] inventory : datatable fix actions etc. In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684 --- Comment #5 from delaye --- the last test with the sandbox 1 it's work. you can test with the file of barcodes (homebranch : MAURES, location : Livre audio jeunesse ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 11:29:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 09:29:00 +0000 Subject: [Koha-bugs] [Bug 7673] New patron permissions In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673 --- Comment #8 from delaye --- Created attachment 10360 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10360&action=edit liste de cb for test une sandbox one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 11:35:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 09:35:35 +0000 Subject: [Koha-bugs] [Bug 8268] Koha should offer way to backup entire db In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268 --- Comment #4 from Marc Balmer --- (Mit Bezug zu comment 3) > This is incomplete. There should be a way to create a backup in a database > independent way. E.g., in the backup.sh script use a switch statement to > call whatever dumper is needed. My comment does not apply to the patch, but to the script backup.sh (which has more problems...), so please ignore my comment for this particular patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 12:22:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 10:22:21 +0000 Subject: [Koha-bugs] [Bug 8271] New: teach SIPServer to set its own lib path Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8271 Priority: P5 - low Change sponsored?: --- Bug ID: 8271 CC: colin.campbell at ptfs-europe.com Assignee: koha-bugs at lists.koha-community.org Summary: teach SIPServer to set its own lib path Severity: enhancement Classification: Unclassified OS: All Reporter: colin.campbell at ptfs-europe.com Hardware: All Status: NEW Version: master Component: SIP2 Product: Koha The SIPserver uses a libpath different from the rest of Koha its passed in the upscript using -I. having cd'd to the C4/SIP directory. Perl has a perfectly good way to manage this rather than relying on -I being set correctly in a calling script. Using it may remove a barrier to setting up and debugging sip configurations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 12:33:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 10:33:57 +0000 Subject: [Koha-bugs] [Bug 8271] teach SIPServer to set its own lib path In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8271 --- Comment #1 from Colin Campbell --- Created attachment 10361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10361&action=edit Proposed Patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 13:27:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 11:27:00 +0000 Subject: [Koha-bugs] [Bug 8267] Overdue notices not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8267 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 13:48:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 11:48:02 +0000 Subject: [Koha-bugs] [Bug 8181] Replace DynArch calendar widget with jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 13:48:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 11:48:27 +0000 Subject: [Koha-bugs] [Bug 7787] SIP server closes the TCP connection when it receives an invalid message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7787 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10012|0 |1 is obsolete| | --- Comment #10 from Colin Campbell --- Created attachment 10362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10362&action=edit Signed off patch I removed the update to VERSION from the patch as it conflicts with a recently pushed patch which set VERSION to match the Koha Version -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 13:51:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 11:51:53 +0000 Subject: [Koha-bugs] [Bug 7787] SIP server closes the TCP connection when it receives an invalid message In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7787 Colin Campbell changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Colin Campbell --- I've run this against various scenarios with a test client and it does behave in a more standard compliant way. Shutdown is cleaner in most cases and it avoids the 'die mysteriously' behaviour that can cause clients to hang -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 15:37:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 13:37:26 +0000 Subject: [Koha-bugs] [Bug 8272] New: OPAC : date expiration format Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8272 Priority: P5 - low Change sponsored?: --- Bug ID: 8272 Assignee: oleonard at myacpl.org Summary: OPAC : date expiration format Severity: enhancement Classification: Unclassified OS: All Reporter: stephane.delaye at biblibre.com Hardware: All Status: NEW Version: rel_3_8 Component: OPAC Product: Koha In the OPAC the expiration date have this format AAAA/MM/JJ while the preference system is JJ/MM/AAAA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 15:42:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 13:42:06 +0000 Subject: [Koha-bugs] [Bug 8273] New: ADD biblionumber to deleted item on log Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8273 Priority: P5 - low Change sponsored?: --- Bug ID: 8273 Assignee: koha-bugs at lists.koha-community.org Summary: ADD biblionumber to deleted item on log Severity: enhancement Classification: Unclassified OS: All Reporter: pussman at gmail.com Hardware: All Status: NEW Version: unspecified Component: Transaction logs Product: Koha In our Library we want to know the corresponding biblionumber of the deleted item. The log shows: Date Librarian Module Action Object Info 2012-06-18 11:52:14 10429 CATALOGUING DELETE 1337 item It should be: Date Librarian Module Action Object Info 2012-06-18 11:52:14 10429 CATALOGUING DELETE 1337 item FROM biblionumber 34528 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 15:44:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 13:44:35 +0000 Subject: [Koha-bugs] [Bug 8273] ADD biblionumber to deleted item on log In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8273 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- There is also a table deleteditems, that will have the biblionumber for the record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 15:54:51 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 13:54:51 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #10 from Tom?s Cohen Arazi --- I've set a test install with this settings: mysql> SELECT * FROM repeatable_holidays; +----+------------+---------+------+-------+-------+----------------+ | id | branchcode | weekday | day | month | title | description | +----+------------+---------+------+-------+-------+----------------+ | 2 | TEST | 0 | NULL | NULL | | Sundays | | 3 | TEST | NULL | 1 | 1 | | New Year's Day | | 4 | TEST | NULL | 25 | 12 | | Christmas | +----+------------+---------+------+-------+-------+----------------+ 3 rows in set (0.00 sec) And got: tomas at tomas-desktop:~/Work/koha/devel/koha-community-src$ perl t/db_dependent/Holidays.t 1..8 ok 1 - use Koha::Calendar; ok 2 - use C4::Calendar; ok 3 - Koha::Calendar class returned isa Koha::Calendar ok 4 - C4::Calendar class returned isa C4::Calendar not ok 5 - Sunday is a closed day # Failed test 'Sunday is a closed day' # at t/db_dependent/Holidays.t line 42. # got: '0' # expected: '1' ok 6 - Monday is not a closed day not ok 7 - Christmas is a closed day # Failed test 'Christmas is a closed day' # at t/db_dependent/Holidays.t line 44. # got: '0' # expected: '1' not ok 8 - New Years day is a closed day # Failed test 'New Years day is a closed day' # at t/db_dependent/Holidays.t line 45. # got: '0' # expected: '1' # Looks like you failed 3 tests of 8. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 16:30:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 14:30:08 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10356|0 |1 is obsolete| | --- Comment #11 from Tom?s Cohen Arazi --- Created attachment 10363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10363&action=edit 8110 - Fines accruing on closed days - Fix Day/Month Holidays Bug This patch fixes a bug in which day/month holidays are stored in the Koha::Calendar internal hash not by month/day but incorrectly by day/month. To test: 1) Apply 'Holidays Test Plan - DB Dependent' patch, create MPL holidays for Sunday, New Years Day, and Christmas. 2) Run test plan, only Christmas should fail ( New Years does not because 1-1 means the day and month position do not matter ). 3) Apply this patch 4) Run test plan again Signed-off-by: Liz Rea Test plan works as advertised. Signed-off-by: Tomas Cohen Arazi Test runs flawlessly. I originaly missed to set the expected branchcode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 17:17:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 15:17:32 +0000 Subject: [Koha-bugs] [Bug 8154] The export today's checked in barcodes generated file is always empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10344|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi --- Created attachment 10364 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10364&action=edit Bug 8154: The export today's checked in barcodes generated file is always empty Comparation of date and datetime is always false Signed-off-by: Tomas Cohen Arazi Exported file contains the list of checked in items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 17:26:32 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 15:26:32 +0000 Subject: [Koha-bugs] [Bug 8154] The export today's checked in barcodes generated file is always empty In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 17:58:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 15:58:22 +0000 Subject: [Koha-bugs] [Bug 7643] Can't upload and import zipped file of patron images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7643 Albert Oller changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ago at bywatersolutions.com --- Comment #3 from Albert Oller --- For 3.6 I found that unzip hadn't been installed on a site. Once I installed that I got errors. I installed an earlier version of picture-upload.pl and that resolved the problem. http://git.koha-community.org/gitweb/?p=koha.git;a=blob_plain;f=tools/picture-upload.pl;hb=44201a54e15f06d13c2f40d93bd5a76f6493d7d2 I'm seeing a similar problem on 3.8, and am going to test that now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 18:37:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 16:37:10 +0000 Subject: [Koha-bugs] [Bug 8181] Replace DynArch calendar widget with jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10259|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 10365 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10365&action=edit Bug 8181 [REVISED] Replace DynArch calendar widget with jQueryUI version All instances of the old DynArch calendar have been replaced with jQueryUI versions and the old library files have been removed. calendar.inc has been modified to include jQueryUI localization strings and global configuration options. Just add a "datepicker" class to an input field to trigger a datepicker prompt. If you would like two fields in one from to limit each other (one is date from, one is date to), add these classes to each: "datepickerfrom" and "datepickerto." This will prevent an invalid entry, e.g. a date in the latter which falls before the former. jQueryUI is now upgraded to the latest verision, 1.8.21. Edit: Now with proper translatability, date formatting, first day of the week handling, and RTL support. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 18:37:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 16:37:54 +0000 Subject: [Koha-bugs] [Bug 8181] Replace DynArch calendar widget with jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 18:40:17 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 16:40:17 +0000 Subject: [Koha-bugs] [Bug 8181] Replace DynArch calendar widget with jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10365|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 18:41:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 16:41:53 +0000 Subject: [Koha-bugs] [Bug 8181] Replace DynArch calendar widget with jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 --- Comment #5 from Owen Leonard --- Created attachment 10366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10366&action=edit Bug 8181 [REVISED] Replace DynArch calendar widget with jQueryUI version All instances of the old DynArch calendar have been replaced with jQueryUI versions and the old library files have been removed. calendar.inc has been modified to include jQueryUI localization strings and global configuration options. Just add a "datepicker" class to an input field to trigger a datepicker prompt. If you would like two fields in one from to limit each other (one is date from, one is date to), add these classes to each: "datepickerfrom" and "datepickerto." This will prevent an invalid entry, e.g. a date in the latter which falls before the former. jQueryUI is now upgraded to the latest verision, 1.8.21. Edit: Now with proper translatability, date formatting, first day of the week handling, and RTL support. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 18:50:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 16:50:13 +0000 Subject: [Koha-bugs] [Bug 7995] upload patron images permission needed to upload offline circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7995 Albert Oller changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ago at bywatersolutions.com --- Comment #1 from Albert Oller --- Hi, same problem with 3.8 missing unzip fixed with : sudo apt-get install unzip current 3.8 picture-upload.pl gives this error: Patron image failed to upload Unpacking completed 1 directories scanned. 1 directories processed. - Cardnumber: WARNING: This image not imported because the cardnumber and filename is missing. installed the older picture-upload.pl and it now works fine. Here's the diff of the two: (picture-upload.pl.orig = 3.8 version) kohaclone/tools$ diff picture-upload.pl picture-upload.pl.orig 61c61 < picture-upload.p. - Script for handling uploading of both single and bulk patronimages and importing them into the database. --- > picture-upload.pl - Script for handling uploading of both single and bulk patronimages and importing them into the database. 81c81,84 < my $filesuffix = $1 if $uploadfilename =~ m/(\..+)$/i; --- > my $filesuffix; > if ( $uploadfilename =~ m/(\..+)$/i ) { > my $filesuffix = $1; > } 98c101 < unless (system("unzip $tempfile -d $dirname") == 0) { --- > unless (system("unzip", $tempfile, '-d', $dirname) == 0) { 257,258c260,264 < my $dberror = PutPatronImage($cardnumber,$mimetype, $imgfile) if $mimetype; < if ( !$dberror && $mimetype ) { # Errors from here on are fatal only to the import of a particular image, so don't bail, just note the error and keep going --- > my $dberror; > if ($mimetype) { > $dberror = PutPatronImage( $cardnumber, $mimetype, $imgfile ); > } > if ( !$dberror && $mimetype ) { # Errors from here on are fatal only to the import of a particular image, so don't bail, just note the error and keep going 298,299d303 < < =back -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 18:57:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 16:57:37 +0000 Subject: [Koha-bugs] [Bug 7995] upload patron images permission needed to upload offline circ In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7995 --- Comment #2 from Albert Oller --- Hi, Please disregard comment #2, I posted to the wrong bug. sorry about that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 18:58:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 16:58:58 +0000 Subject: [Koha-bugs] [Bug 7643] Can't upload and import zipped file of patron images In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7643 --- Comment #4 from Albert Oller --- Hi, same problem with 3.8 missing unzip fixed with : sudo apt-get install unzip current 3.8 picture-upload.pl gives this error: Patron image failed to upload Unpacking completed 1 directories scanned. 1 directories processed. - Cardnumber: WARNING: This image not imported because the cardnumber and filename is missing. installed the older picture-upload.pl and it now works fine. Here's the diff of the two: (picture-upload.pl.orig = 3.8 version) kohaclone/tools$ diff picture-upload.pl picture-upload.pl.orig 61c61 < picture-upload.p. - Script for handling uploading of both single and bulk patronimages and importing them into the database. --- > picture-upload.pl - Script for handling uploading of both single and bulk patronimages and importing them into the database. 81c81,84 < my $filesuffix = $1 if $uploadfilename =~ m/(\..+)$/i; --- > my $filesuffix; > if ( $uploadfilename =~ m/(\..+)$/i ) { > my $filesuffix = $1; > } 98c101 < unless (system("unzip $tempfile -d $dirname") == 0) { --- > unless (system("unzip", $tempfile, '-d', $dirname) == 0) { 257,258c260,264 < my $dberror = PutPatronImage($cardnumber,$mimetype, $imgfile) if $mimetype; < if ( !$dberror && $mimetype ) { # Errors from here on are fatal only to the import of a particular image, so don't bail, just note the error and keep going --- > my $dberror; > if ($mimetype) { > $dberror = PutPatronImage( $cardnumber, $mimetype, $imgfile ); > } > if ( !$dberror && $mimetype ) { # Errors from here on are fatal only to the import of a particular image, so don't bail, just note the error and keep going 298,299d303 < < =back -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 19:00:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 17:00:12 +0000 Subject: [Koha-bugs] [Bug 8181] Replace DynArch calendar widget with jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 --- Comment #6 from Owen Leonard --- (In reply to comment #3) > 1) In the holidays calendar, the calendar does not display, until I copy a > calendar somewhere. I was able to reproduce this error when first visiting the page after switching to this branch, but not on subsequent page loads. Could it have been a browser cache issue? > 2) In acquisitions late orders the filters do not respect the dateformat > setting. Handling of dateformat and other I18N settings has been fixed. That is to say, added. > 3) The tooltip for the calendar shows up as a black box with '...' in it. It > was a bit irritating for me, perhaps you have an idea? This is a default of the jQueryUI datepicker: The calendar icon has a title attribute added to it, "..." I'm not sure why. It might be possible to revise the default configuration without modifying the jQueryUI library itself. I'll have to investigate. > Today's date is not very clearly marked > there. It's not so easy to spot in the calendar. Perhaps it could stand out > a bit more? I have revised the CSS to make it brighter. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 19:07:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 17:07:18 +0000 Subject: [Koha-bugs] [Bug 8272] OPAC : date expiration format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8272 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |master Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 19:10:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 17:10:09 +0000 Subject: [Koha-bugs] [Bug 8272] OPAC : date expiration format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8272 --- Comment #1 from Owen Leonard --- Created attachment 10367 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10367&action=edit Bug 8272 - OPAC : date expiration format Adding TT date filter to output of expiration date on OPAC user page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 19:10:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 17:10:22 +0000 Subject: [Koha-bugs] [Bug 8272] OPAC : date expiration format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8272 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 19:10:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 17:10:28 +0000 Subject: [Koha-bugs] [Bug 8272] OPAC : date expiration format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8272 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 20:41:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 18:41:48 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 --- Comment #12 from Liz Rea --- Created attachment 10368 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10368&action=edit bug 8110 - add branchcode MPL to sample holidays to facilitate automated testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 21:50:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 19:50:59 +0000 Subject: [Koha-bugs] [Bug 8253] Fine doubling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253 --- Comment #1 from Kyle M Hall --- Created attachment 10369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10369&action=edit Bug 8253 - Fine doubling This issue only occurs when upgrading from pre-3.8 to post 3.8 Koha. The issue is caused by the change from dates to datetimes that was neccesary to implement hourly loans. All pre-3.8 fines have the date in the description. This date is how the fines script know which fine to update. If the fine script does not locate an existing row to update, it creates a new row. The switch from dates to datetimes means the fines script now looks for a format such as 'YYYY-MM-DD 00:00' ( for iso ), but all the previous fines are still in the format 'YYYY-MM-DD' and so it fails to find the matching row, and creates a new row instead. This commit consists of a database update that alters the dates in the accountlines description field to be datetimes instead. This eliminates future fine doubling. It is also safe to run on a system that has been previously upgraded, it will ignore any rows where the date is already of the format 'YYYY-MM-DD 00:00' ( or whichever date format you have chosen ). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 21:51:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 19:51:09 +0000 Subject: [Koha-bugs] [Bug 8253] Fine doubling In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 22:07:31 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 20:07:31 +0000 Subject: [Koha-bugs] [Bug 8274] New: count of suggestions on main page wrong Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8274 Priority: P5 - low Change sponsored?: --- Bug ID: 8274 Assignee: koha-bugs at lists.koha-community.org Summary: count of suggestions on main page wrong Severity: major Classification: Unclassified OS: All Reporter: nengard at gmail.com Hardware: All Status: NEW Version: master Component: Acquisitions Product: Koha When you're on the main staff client page the count of suggestions at the bottom doesn't match what you see when you click the link. This is because of the new filter on the suggestions page to only show your branch. Both displays should show the same number. So the homepage needs to filter on branch or the suggestion page needs to not filter on branch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Jun 19 22:13:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Jun 2012 20:13:12 +0000 Subject: [Koha-bugs] [Bug 8267] Overdue notices not working In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8267 Melia Meggs changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia at bywatersolutions.com Severity|enhancement |blocker --- Comment #3 from Melia Meggs --- I am changing this from "enhancement" to "blocker." It is a pretty important bug. No overdue notices are going out for libraries on 3.8.1 at all (neither email nor print). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 04:24:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 02:24:07 +0000 Subject: [Koha-bugs] [Bug 8272] OPAC : date expiration format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8272 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10367|0 |1 is obsolete| | --- Comment #2 from Chris Cormack --- Created attachment 10370 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10370&action=edit Bug 8272 - OPAC : date expiration format Adding TT date filter to output of expiration date on OPAC user page. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 04:24:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 02:24:50 +0000 Subject: [Koha-bugs] [Bug 8272] OPAC : date expiration format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8272 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris at bigballofwax.co.nz --- Comment #3 from Chris Cormack --- Just adding the dates filter to the template, works fine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 04:31:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 02:31:41 +0000 Subject: [Koha-bugs] [Bug 8181] Replace DynArch calendar widget with jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #7 from Chris Cormack --- This now appears to work fine for me. Well done Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 04:31:48 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 02:31:48 +0000 Subject: [Koha-bugs] [Bug 8181] Replace DynArch calendar widget with jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 04:32:27 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 02:32:27 +0000 Subject: [Koha-bugs] [Bug 8181] Replace DynArch calendar widget with jQueryUI version In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10366|0 |1 is obsolete| | --- Comment #8 from Chris Cormack --- Created attachment 10371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10371&action=edit Bug 8181 [REVISED] Replace DynArch calendar widget with jQueryUI version All instances of the old DynArch calendar have been replaced with jQueryUI versions and the old library files have been removed. calendar.inc has been modified to include jQueryUI localization strings and global configuration options. Just add a "datepicker" class to an input field to trigger a datepicker prompt. If you would like two fields in one from to limit each other (one is date from, one is date to), add these classes to each: "datepickerfrom" and "datepickerto." This will prevent an invalid entry, e.g. a date in the latter which falls before the former. jQueryUI is now upgraded to the latest verision, 1.8.21. Edit: Now with proper translatability, date formatting, first day of the week handling, and RTL support. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 09:17:55 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 07:17:55 +0000 Subject: [Koha-bugs] [Bug 8247] adding basket doesn't save basket name, internal or vendor note In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8247 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 09:24:41 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 07:24:41 +0000 Subject: [Koha-bugs] [Bug 7329] The "undo import into catalog" command deletes items onloan without checking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|rel_3_6 |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 09:38:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 07:38:11 +0000 Subject: [Koha-bugs] [Bug 8272] OPAC : date expiration format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8272 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #4 from Paul Poulain --- Patch tested with a sandbox, by Delaye Stephane -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 09:38:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 07:38:24 +0000 Subject: [Koha-bugs] [Bug 8272] OPAC : date expiration format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8272 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10370|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 09:38:28 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 07:38:28 +0000 Subject: [Koha-bugs] [Bug 8272] OPAC : date expiration format In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8272 --- Comment #5 from Paul Poulain --- Created attachment 10372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10372&action=edit Bug 8272 - OPAC : date expiration format Adding TT date filter to output of expiration date on OPAC user page. Signed-off-by: Chris Cormack Signed-off-by: Delaye Stephane -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 09:38:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 07:38:44 +0000 Subject: [Koha-bugs] [Bug 7318] Filtering Patron Card Creator by Category Code Does Nothing In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7318 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Assignee|gmcharlt at gmail.com |wizzyrea at gmail.com --- Comment #16 from Paul Poulain --- bumping question for anyone = this patch seems to have been applied. Could someone confirm ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 09:39:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 07:39:56 +0000 Subject: [Koha-bugs] [Bug 8136] Changes the expected lenght of 100$a in rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8136 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 09:43:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 07:43:11 +0000 Subject: [Koha-bugs] [Bug 7961] Local cover images should support CSV link files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7961 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 10:08:47 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 08:08:47 +0000 Subject: [Koha-bugs] [Bug 7943] Untranslatable strings in OPAC's authority search In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7943 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 --- Comment #8 from Paul Poulain --- Patch pushed, should not be pushed immediately in 3.8, as it contains some string changes, and we're string freeze for 3.8.2 Also worth having a longer testing period, as it's a large patch that could introduce some hidden side effect -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 10:12:39 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 08:12:39 +0000 Subject: [Koha-bugs] [Bug 7129] actual cost showing too many zeros In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #14 from Paul Poulain --- Patch pushed, but, in the long term, I'd love to see a "currency display" T::T plugin (I would be surprised if it does not exist already, as it's a very common need) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 10:15:19 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 08:15:19 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |paul.poulain at biblibre.com --- Comment #9 from Paul Poulain --- The 1st patch does not apply anymore, the 2nd one is OK, so will push the 2nd one now, please rebase the 1st one -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 10:15:44 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 08:15:44 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10297|0 |1 is obsolete| | --- Comment #10 from Paul Poulain --- Comment on attachment 10297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10297 [SIGNED-OFF] Bug 6720: show authority type in auth details This patch has been pushed -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 10:37:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 08:37:24 +0000 Subject: [Koha-bugs] [Bug 5295] ctype index Zebra configuration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #8 from Paul Poulain --- mmm... greping ctype, I see that there are a lot of references still here: etc/zebradb/ccl.properties:ctype Content-type etc/zebradb/marc_defs/normarc/biblios/record.abs:melm 008 date-entered-on-file:n:range(data,0,5),date-enter ed-on-file:s:range(data,0,5),pubdate:w:range(data,7,4),pubdate:n:range(data,7,4),pubdate:y:range(data,7,4),pubdate :s:range(data,7,4),pl:w:range(data,15,3),ta:w:range(data,22,1),ff8-23:w:range(data,23,1),ff8-29:w:range(data,29,1) ,lf:w:range(data,33,1),bio:w:range(data,34,1),ln:n:range(data,35,3),ctype:w:range(data,24,4),Record-source:w:range (data,39,0) etc/zebradb/marc_defs/marc21/biblios/record.abs:melm 008 date-entered-on-file:n:range(data,0,5),date-entere d-on-file:s:range(data,0,5),pubdate:w:range(data,7,4),pubdate:n:range(data,7,4),pubdate:y:range(data,7,4),pubdate: s:range(data,7,4),pl:w:range(data,15,3),ta:w:range(data,22,1),ff8-23:w:range(data,23,1),ff8-29:w:range(data,29,1), lf:w:range(data,33,1),bio:w:range(data,34,1),ln:w:range(data,35,3),ctype:w:range(data,24,4),Record-source:w:range( data,39,0) COULD SOMEONE USING MARC21 confirm that this patch does not break marc21 ? I've some doubts... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 10:39:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 08:39:06 +0000 Subject: [Koha-bugs] [Bug 8227] Remove compile time warning from C4::Serials In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8227 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|unspecified |rel_3_10 --- Comment #4 from Paul Poulain --- not worth backporting to 3.8 but, chris_c, that's your final decision ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 10:44:59 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 08:44:59 +0000 Subject: [Koha-bugs] [Bug 8226] 'OpacFooter' markup/css improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8226 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 Severity|trivial |normal --- Comment #8 from Paul Poulain --- upgrading severity, it's not a Koha (the software) problem, but an important Koha (the website) one ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 10:46:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 08:46:53 +0000 Subject: [Koha-bugs] [Bug 8222] The zip code field is mandatory by default In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8222 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Component|Patrons |Installation and upgrade | |(web-based installer) Version|unspecified |rel_3_8 Assignee|robin at catalyst.net.nz |koha-bugs at lists.koha-commun | |ity.org --- Comment #5 from Paul Poulain --- (changed the component, it's related to installer module, not patron) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 10:52:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 08:52:25 +0000 Subject: [Koha-bugs] [Bug 8247] adding basket doesn't save basket name, internal or vendor note In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8247 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- No string changes, pushed to 3.8.x will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 10:59:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 08:59:02 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10191|0 |1 is obsolete| | --- Comment #20 from Paul Poulain --- Comment on attachment 10191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10191 Patch for history.txt this patch pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 10:59:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 08:59:09 +0000 Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 11:02:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 09:02:13 +0000 Subject: [Koha-bugs] [Bug 7329] The "undo import into catalog" command deletes items onloan without checking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #15 from Chris Cormack --- No string changes, pushed to 3.8.x will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 11:02:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 09:02:22 +0000 Subject: [Koha-bugs] [Bug 7329] The "undo import into catalog" command deletes items onloan without checking In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7329 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 11:07:08 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 09:07:08 +0000 Subject: [Koha-bugs] [Bug 7367] General OPAC typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10268|0 |1 is obsolete| | --- Comment #14 from Paul Poulain --- Comment on attachment 10268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10268 Patch for opac-suggestions template patch pushed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 11:07:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 09:07:25 +0000 Subject: [Koha-bugs] [Bug 7367] General OPAC typo omnibus In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 11:08:38 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 09:08:38 +0000 Subject: [Koha-bugs] [Bug 8232] Comments in OPAC contain untranslatable javascript messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8232 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 Severity|enhancement |minor --- Comment #4 from Paul Poulain --- worth pushing it on 3.8.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 11:10:50 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 09:10:50 +0000 Subject: [Koha-bugs] [Bug 8229] Tabs in marc subfield structure is not shown correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8229 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_8 Severity|enhancement |major --- Comment #4 from Paul Poulain --- Not really en ENH, but a fix for a major graphical bug ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 11:11:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 09:11:25 +0000 Subject: [Koha-bugs] [Bug 8229] Tabs in marc subfield structure is not shown correctly In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8229 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |matthias.meusburger at biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 11:12:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 09:12:53 +0000 Subject: [Koha-bugs] [Bug 8223] Properly format SQL query in C4::Bookseller::GetBookSeller In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8223 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|master |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 11:16:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 09:16:07 +0000 Subject: [Koha-bugs] [Bug 8216] Enable critic tests on SIP modules In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8216 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain at biblibre.com Version|unspecified |rel_3_10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 11:16:30 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 09:16:30 +0000 Subject: [Koha-bugs] [Bug 8136] Changes the expected lenght of 100$a in rebuild_zebra.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8136 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- No string changes, pushed to 3.8.x, will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 11:23:25 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 09:23:25 +0000 Subject: [Koha-bugs] [Bug 8205] Should be possible to hide unused authorities in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205 Paul Poulain changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #4 from Paul Poulain --- before pushing this patch, I want to say that, imo, a better idea would have been to add an option to dynamically add/remove authorities that have/don't have attached biblio. That would not require a new syspref (remember i'm founder of FAUSP -Fighters Against Useless SysPrefs), let more feedom to users, and could be usefull for staff interface as well. With Datatable I think this should be easy to achieve. Would you be OK to rewrite your patch ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 11:26:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 09:26:18 +0000 Subject: [Koha-bugs] [Bug 7961] Local cover images should support CSV link files In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7961 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris at bigballofwax.co.nz --- Comment #14 from Chris Cormack --- No string changes, pushed to 3.8.x will be in 3.8.2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 11:33:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 09:33:53 +0000 Subject: [Koha-bugs] [Bug 7129] actual cost showing too many zeros In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7129 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #15 from Chris Cormack --- Does not apply for 3.8.x please reformat for 3.8.x -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 11:46:00 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 09:46:00 +0000 Subject: [Koha-bugs] [Bug 8232] Comments in OPAC contain untranslatable javascript messages In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8232 Chris Cormack changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #5 from Chris Cormack --- Contains string changes, holding for 3.8.3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 11:50:26 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 09:50:26 +0000 Subject: [Koha-bugs] [Bug 8205] Should be possible to hide unused authorities in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205 --- Comment #5 from Katrin Fischer --- I think for the staff interface a filter like you suggest would be nice, but for OPAC users authorities without biblios are not really useful. They might be duplicates or accidentally created stubs or just weird authorities from a big imported authority file. So I think for the OPAC a syspref is really a good way to deal with this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 11:56:01 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 09:56:01 +0000 Subject: [Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9896|0 |1 is obsolete| | --- Comment #17 from Julian Maurice --- Created attachment 10373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10373&action=edit Bug 7304: More permissions for budgets Rebased patch Fixed typo at admin/aqbudget_user_search.pl Fixed updatedatabase.pl and kohastructure.pl so that foreign keys have ON DELETE/ON UPDATE clauses Removed Test::MockModule dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 11:56:09 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 09:56:09 +0000 Subject: [Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 12:49:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 10:49:45 +0000 Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 13:17:02 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 11:17:02 +0000 Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 --- Comment #15 from M. de Rooy --- QA Comment: While waiting for more spectacular improvements on dates/datetimes in Koha, this simple fix works: e.g. 2012-06-20 13:00 gt 2012-06-20 in order to get today's issues. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 13:17:12 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 11:17:12 +0000 Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts in circulation.pl In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 13:25:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 11:25:58 +0000 Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10272|0 |1 is obsolete| | --- Comment #4 from Julian Maurice --- Created attachment 10374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10374&action=edit Bug 8244: New script xt/find-undefined-subroutines.pl Added --help option --src-path and --dest-path no longer required. --src-path defaults to: dirname($0)."/..". It is displayed with --help --dest-path defaults to a temporary directory (use File::Temp) Fixed many bugs on pathnames Removed --trap option of prove since it seems that it's not available everywhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 13:26:07 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 11:26:07 +0000 Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 13:35:43 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 11:35:43 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10032|0 |1 is obsolete| | --- Comment #10 from Julian Maurice --- Created attachment 10375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10375&action=edit [SIGNED-OFF] Bug 5349: Order line transfers Rebased on master, conflicts only on updatedatabase, signoff kept. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 13:36:13 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 11:36:13 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10190|0 |1 is obsolete| | --- Comment #11 from Julian Maurice --- Created attachment 10376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10376&action=edit Follow-up: run transferorder.pl in a popup Rebased on master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 13:36:21 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 11:36:21 +0000 Subject: [Koha-bugs] [Bug 5349] Moving an order In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 13:42:29 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 11:42:29 +0000 Subject: [Koha-bugs] [Bug 6090] empty mails in message_queue are sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6090 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10151|0 |1 is obsolete| | --- Comment #12 from Julian Maurice --- Created attachment 10377 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10377&action=edit Bug 6090: Do not enqueue empty messages The last patch was not re-tested as it only add 'if $debug' after a warn. This patch fix the 'kfpackage' thing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 13:42:45 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 11:42:45 +0000 Subject: [Koha-bugs] [Bug 6090] empty mails in message_queue are sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6090 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 13:46:54 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 11:46:54 +0000 Subject: [Koha-bugs] [Bug 6090] empty mails in message_queue are sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6090 Julian Maurice changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10377|0 |1 is obsolete| | --- Comment #13 from Julian Maurice --- Created attachment 10378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10378&action=edit Bug 6090: Do not enqueue empty messages Sorry, it was the wrong patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 13:52:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 11:52:37 +0000 Subject: [Koha-bugs] [Bug 8205] Should be possible to hide unused authorities in OPAC In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205 --- Comment #6 from Jared Camins-Esakov --- (In reply to comment #4) > before pushing this patch, I want to say that, imo, a better idea would have > been to add an option to dynamically add/remove authorities that have/don't > have attached biblio. That would not require a new syspref (remember i'm > founder of FAUSP -Fighters Against Useless SysPrefs), let more feedom to > users, and could be usefull for staff interface as well. > > With Datatable I think this should be easy to achieve. Would you be OK to > rewrite your patch ? I like this idea for the staff interface, but, as Katrin says, I feel like this would just confuse OPAC users, who probably don't understand what an "authority record" is. As for the idea of using Datatables for authority results... that's just inspired. I think I may have to add that to my to-do list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 14:11:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 12:11:37 +0000 Subject: [Koha-bugs] [Bug 8263] Make OPAC stylesheet preferences more consistent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10354|0 |1 is obsolete| | --- Comment #4 from M. de Rooy --- Created attachment 10379 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10379&action=edit Rebased patch for 8263 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 14:13:57 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 12:13:57 +0000 Subject: [Koha-bugs] [Bug 6018] Batch modifitcation of items Enchancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6018 --- Comment #11 from Julian Maurice --- It's an old patch and I don't remember what it does... Is the only need to display all subfields, whatever the hidden value is? In this case I can make another patch much more simple. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 14:33:10 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 12:33:10 +0000 Subject: [Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #18 from M. de Rooy --- The size of this patch and the relative small changes to the code (compared to last version) may justify keeping it in Signed-off state. Several points of QA comment have received attention. No dependency is added. Good to see that you also remove the warning on redefine. Although I still believe that some code improvements could be made here as referred to in my previous comments, they should not block this patch from getting through. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 14:33:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 12:33:20 +0000 Subject: [Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds management by multi librarians In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 14:41:03 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 12:41:03 +0000 Subject: [Koha-bugs] [Bug 5295] ctype index Zebra configuration In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295 --- Comment #9 from Fridolyn SOMERS --- I think indeed MARC21 will be broken because it uses ctype in record.abs. By now, "ctype" works for MARC21 but it's a best pratice to use long names in configuration and short names only in CCL queries, no? Can we replace "ctype" by "Content-type" for all record.abs ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 14:49:37 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 12:49:37 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10294|0 |1 is obsolete| | --- Comment #11 from Jared Camins-Esakov --- Created attachment 10380 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10380&action=edit Bug 6720: Display the authority type in OPAC Due to a peculiarity in the way SearchAuthorities worked, the authority search results on the OPAC always listed the authority type that the user searched for, rather than the authority type of the results. Signed-off-by: Katrin Fischer Works nicely, result list for OPAC search now shows the authority type for each record. Signed-off-by: Jared Camins-Esakov Rebased 20 June 2012. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 14:50:36 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 12:50:36 +0000 Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default' In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720 Jared Camins-Esakov changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #12 from Jared Camins-Esakov --- Another signoff for the first patch now that it's been rebased would be super keen. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 14:51:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 12:51:06 +0000 Subject: [Koha-bugs] [Bug 6090] empty mails in message_queue are sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6090 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10378|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall --- Created attachment 10381 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10381&action=edit [SIGNED-OFF] Bug 6090: Do not enqueue empty messages This patch avoid enqueuing messages that have an empty body. It can happen when letter is empty or becomes empty after being processed by parseletter Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 14:51:20 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 12:51:20 +0000 Subject: [Koha-bugs] [Bug 6090] empty mails in message_queue are sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6090 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 14:59:24 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 12:59:24 +0000 Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #71 from M. de Rooy --- Well, we had this bug a week in discussion with feedback from Jared, Ian, Robin, Chris N and Mason. This makes me draw the following conclusions with reference to my former QA comment: 1) My suggestion to turn dev mode on via a preference was not accepted. So we can leave that as it is (via $ENV{DEBUG}). 2) The distinction between numbered dbrevs and unnumbered ones should be added. Note however that my suggestion to not show them in normal mode can be discarded. 3) Although only Ian is rather hesitant in accepting this solution, his idea of reverting/undoing a dbrev is quite interesting for a future followup. Could you please adjust the patch with these comments on the former QA comment in mind? Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 15:02:18 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 13:02:18 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10368|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall --- Created attachment 10382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10382&action=edit [SIGNED-OFF] bug 8110 - add branchcode MPL to sample holidays to facilitate automated testing. Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 15:02:46 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 13:02:46 +0000 Subject: [Koha-bugs] [Bug 6090] empty mails in message_queue are sent In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6090 M. de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from M. de Rooy --- Marking as Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 15:03:35 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 13:03:35 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 --- Comment #14 from Kyle M Hall --- Created attachment 10383 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10383&action=edit [SIGNED-OFF] 8110 - Fines accruing on closed days - Fix Day/Month Holidays Bug This patch fixes a bug in which day/month holidays are stored in the Koha::Calendar internal hash not by month/day but incorrectly by day/month. To test: 1) Apply 'Holidays Test Plan - DB Dependent' patch, create MPL holidays for Sunday, New Years Day, and Christmas. 2) Run test plan, only Christmas should fail ( New Years does not because 1-1 means the day and month position do not matter ). 3) Apply this patch 4) Run test plan again Signed-off-by: Liz Rea Test plan works as advertised. Signed-off-by: Tomas Cohen Arazi Test runs flawlessly. I originaly missed to set the expected branchcode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 15:03:58 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 13:03:58 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10363|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 15:06:05 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 13:06:05 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 --- Comment #15 from Kyle M Hall --- Liz, Tom?s, would one or both of you consider the "Holidays Test Plan - DB Dependent" patch to be signed off as well, considering it was necessary for testing. I think it should be included in Koha proper. I think we need for more db dependent testing than we have had in the past. That's why this bug exists, after all! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 15:11:56 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 13:11:56 +0000 Subject: [Koha-bugs] [Bug 8270] Software error: Can't call method "subfield" on an undefined value at /usr/share/koha/lib/C4/Biblio.pm line 2919 In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8270 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Kyle M Hall --- This is almost certainly the result of a corrupted MARC record in your database, and not a problem with Koha itself. I'd recommend you pinpoint your problem record and re-catalog it. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 16:05:04 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 14:05:04 +0000 Subject: [Koha-bugs] [Bug 6018] Batch modifitcation of items Enchancements In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6018 --- Comment #12 from Katrin Fischer --- I think it might be good to show all subfields, because you can have items from different frameworks on your list easily. Not sure which framework is used in this case currently? There are also fields like onloan you don't want people to batch edit. I am not sure, what the best solution here is. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 16:07:49 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 14:07:49 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 --- Comment #16 from Mason James --- Created attachment 10384 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10384&action=edit Holidays Test Plan - DB Dependent This test file is meant to be used with the sample database with a minimum of the sample libraries and sample holidays installed. Holidays.t works as stated. signing-off :) mason at xen1:~/g/head$ mysql head < installer/data/mysql/en/optional/sample_holidays.sql mason at xen1:~/g/head$ prove ./t/db_dependent/Holidays.t ./t/db_dependent/Holidays.t .. ok All tests successful. Files=1, Tests=8, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.28 cusr 0.03 csys = 0.34 CPU) Result: PASS !!!!!!!!!!!!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 16:09:53 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 14:09:53 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10349|0 |1 is obsolete| | Attachment #10384|0 |1 is obsolete| | --- Comment #17 from Mason James --- Created attachment 10385 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10385&action=edit [SIGNED-OFF] Holidays Test Plan - DB Dependent mason at xen1:~/g/head$ mysql head < installer/data/mysql/en/optional/sample_holidays.sql mason at xen1:~/g/head$ prove ./t/db_dependent/Holidays.t ./t/db_dependent/Holidays.t .. ok All tests successful. Files=1, Tests=8, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.28 cusr 0.03 csys = 0.34 CPU) Result: PASS Holidays.t works as stated. signing-off :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 16:15:11 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 14:15:11 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 Mason James changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj at kohaaloha.com --- Comment #18 from Mason James --- QA Comment: this patch-set passes all perl-critic and prove tests. --------------------------------------- $ perl ~/bin/git-perlcritic.pl Koha/Calendar.pm: OK t/db_dependent/Holidays.t: OK $ mysql head < installer/data/mysql/en/optional/sample_holidays.sql $ prove ./t/db_dependent/Holidays.t ./t/db_dependent/Holidays.t .. ok All tests successful. Files=1, Tests=8, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.28 cusr 0.03 csys = 0.34 CPU) Result: PASS --------------------------------------- Passed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 16:19:06 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 14:19:06 +0000 Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days In-Reply-To: References: Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110 --- Comment #19 from Katrin Fischer --- Comment on attachment 10382 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10382 [SIGNED-OFF] bug 8110 - add branchcode MPL to sample holidays to facilitate automated testing. This patch only updates the English sample files, it would avoid problems if we could update all sample holiday files for all languages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Jun 20 16:26:22 2012 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Jun 2012 14:26:22 +0000 Subject: [Koha-bugs] [Bug 8275] New: xml parsing error when the webservice GetPatronInfo/show_loans is called Message-ID: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8275 Priority: P5 - low Change sponsored?: --- Bug ID: 8275 CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Assignee: koha-bugs at lists.koha-community.org Summary: xml parsing error when the webservice GetPatronInfo/show_loans is called Severity: normal Classification: Unclassified OS: All Reporter: koha at univ-lyon3.fr Hardware: All Status: NEW Version: rel_3_8 Component: Circulation Product: Koha When called by the webservice GetPatronInfo (C4/ILSDI/Services.pm) with show_loans parameter defined, the GetPendingIssues routine return a hash including Datetime object (since Bug 5549 - Hourly Loans). These Datetime objects seem to have some bad consequences on the display : The final display : Parsing error... 
      A Datetime object can only be compared to another Datetime object
(DateTime=HASH(0xaa1a3000), HASH(0xa960xf0)) at /usr/share/perl5/XML/Simple.xml
line 1406

As a work-around, I added theese lines (wich permit a correct display) in
Services.pm line 421 :

if ( $cgi->param('show_loans') eq "1" ) {
    my $issues = GetPendingIssues($borrowernumber);
+    foreach my $issue ( @$issues ){
+        $issue->{issuedate} =  $issue->{issuedate}->ymd;
+        $issue->{date_due} =  $issue->{date_due}->ymd;
+    }
    $borrower->{'loans'}->{'loan'} = $issues;
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 16:28:07 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 14:28:07 +0000
Subject: [Koha-bugs] [Bug 8267] Overdue notices not working
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8267

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10357|0                           |1
        is obsolete|                            |

--- Comment #4 from Julian Maurice  ---
Created attachment 10386
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10386&action=edit
[SIGNED-OFF] Bug 8267 - Overdue notices not working

Without patch:

Used letter corresponds to the number of issues in notice triggers:
1 issue => First trigger letter
2 issues => Second trigger letter
...
4 issues and more => Error: no more than 3 triggers =)

Patch fix the problem.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 16:28:16 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 14:28:16 +0000
Subject: [Koha-bugs] [Bug 8267] Overdue notices not working
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8267

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 16:29:22 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 14:29:22 +0000
Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

--- Comment #20 from Mason James  ---
Created attachment 10387
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10387&action=edit
bug 8110 - add 'sample_holidays.sql' files for all languages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 16:30:52 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 14:30:52 +0000
Subject: [Koha-bugs] [Bug 8267] Overdue notices not working
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8267

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 16:30:58 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 14:30:58 +0000
Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

--- Comment #21 from Mason James  ---
(In reply to comment #19)
> Comment on attachment 10382 [details]
> [SIGNED-OFF] bug 8110 - add branchcode MPL to sample holidays to facilitate
> automated testing.
> 
> This patch only updates the English sample files, it would avoid problems if
> we could update all sample holiday files for all languages.


oops, good spotting! - i've just added those files now :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 16:32:46 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 14:32:46 +0000
Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #22 from Katrin Fischer  ---
Thx for the patch Mason :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 16:35:38 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 14:35:38 +0000
Subject: [Koha-bugs] [Bug 8267] Overdue notices not working
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8267

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #5 from M. de Rooy  ---
Small fix, explained. Looks good to me. Passed QA

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 16:40:40 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 14:40:40 +0000
Subject: [Koha-bugs] [Bug 4221] defaultSortField & OPACdefaultSortField non
	functioning
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4221

--- Comment #9 from Fridolyn SOMERS  ---
(In reply to comment #8)
> Without applying any patch, I have tried to change the value of thoses
> sysprefs several times and search results seems to be correctly sorted.
> Nicole, could you give more information if it still does not work for you ?

The problem only occurs on a fresh install.
The first modification of the syspref will set a value.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 16:53:11 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 14:53:11 +0000
Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10387|0                           |1
        is obsolete|                            |

--- Comment #23 from Mason James  ---
Created attachment 10388
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10388&action=edit
bug 8110 - add 'sample_holidays.sql' files for all languages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 16:57:13 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 14:57:13 +0000
Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10388|0                           |1
        is obsolete|                            |

--- Comment #24 from Mason James  ---
Created attachment 10389
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10389&action=edit
bug 8110 - add 'sample_holidays.sql' files for all languages

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 17:06:01 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 15:06:01 +0000
Subject: [Koha-bugs] [Bug 8276] New: circ history not sorting right
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8276

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8276
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
          Assignee: koha-bugs at lists.koha-community.org
           Summary: circ history not sorting right
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: nengard at gmail.com
          Hardware: All
            Status: NEW
           Version: master
         Component: Circulation
           Product: Koha

Created attachment 10390
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10390&action=edit
sort error

When you're on the patron's circulation history in the staff client the far
right column is sorting by month/day in descending order, but year is
ascending.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 17:10:45 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 15:10:45 +0000
Subject: [Koha-bugs] [Bug 8277] New: item form not always showing when
	ordering
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8277

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8277
          Assignee: koha-bugs at lists.koha-community.org
           Summary: item form not always showing when ordering
          Severity: critical
    Classification: Unclassified
                OS: All
          Reporter: nengard at gmail.com
          Hardware: All
            Status: NEW
           Version: master
         Component: Acquisitions
           Product: Koha

When ordering in acquisitions the item form isn't always showing (see:
http://screencast.com/t/USJxXyTO9). I have tested on 3 3.8.1 systems and see
this on two of them .. I can't figure out what's going on, or why it works on
one and not the others, but wanted to get the report out here.

Nicole

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 17:11:54 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 15:11:54 +0000
Subject: [Koha-bugs] [Bug 8277] item form not always showing when ordering
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8277

--- Comment #1 from Nicole C. Engard  ---
I should note that AcqCreateItem  is set to 'placing an order' on all installs
I tested.

Nicole

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 17:39:39 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 15:39:39 +0000
Subject: [Koha-bugs] [Bug 8205] Should be possible to hide unused
	authorities in OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205

--- Comment #7 from Paul Poulain  ---
(In reply to comment #5)
> I think for the staff interface a filter like you suggest would be nice, but
> for OPAC users authorities without biblios are not really useful. 
The more I think of it the more I agree with you here.

> They might
> be duplicates or accidentally created stubs or just weird authorities from a
> big imported authority file. So I think for the OPAC a syspref is really a
> good way to deal with this.

The good news for the FAUSP leader: doesn't it mean we don't need the syspref,
we just should display authorities linked ? I can't see a use case where it's
usefull to see unattached authorities...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 17:42:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 15:42:24 +0000
Subject: [Koha-bugs] [Bug 8205] Should be possible to hide unused
	authorities in OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205

--- Comment #8 from Katrin Fischer  ---
I have been pondering this... but feel it's not ok to change existing behaviour
- some libraries might like it. And maybe with hierarchical authorities it
makes sense to see unused authorities too?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 17:44:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 15:44:24 +0000
Subject: [Koha-bugs] [Bug 8205] Should be possible to hide unused
	authorities in OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205

--- Comment #9 from Jared Camins-Esakov  ---
(In reply to comment #8)
> I have been pondering this... but feel it's not ok to change existing
> behaviour - some libraries might like it. And maybe with hierarchical
> authorities it makes sense to see unused authorities too?

This was my reasoning, too. Also, with the integration of semantikoha data into
authorities, one could imagine libraries using the "Browse authors" section as
almost a biographical dictionary. Which would be very cool.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:00:30 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 16:00:30 +0000
Subject: [Koha-bugs] [Bug 8277] item form not always showing when ordering
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8277

Albert Oller  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ago at bywatersolutions.com

--- Comment #2 from Albert Oller  ---
I've tested this on 3 systems, and found the problem with one of the systems.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:41:15 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 16:41:15 +0000
Subject: [Koha-bugs] [Bug 8183] acqui/parcels.pl plack scoping
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8183

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:42:22 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 16:42:22 +0000
Subject: [Koha-bugs] [Bug 8180] cataloguing/additem.pl plack scoping
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8180

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
           Severity|enhancement                 |normal

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:45:11 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 16:45:11 +0000
Subject: [Koha-bugs] [Bug 8152] Clicking cancel on edit suggestion redirect
 to the suggestion detail
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8152

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|unspecified                 |rel_3_8
           Severity|enhancement                 |normal

--- Comment #4 from Paul Poulain  ---
It's a bugfix, not an ENH !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:54:56 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 16:54:56 +0000
Subject: [Koha-bugs] [Bug 8105] DataTables in Acquisision module:
	basketgroup.tt
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8105

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply
                 CC|                            |paul.poulain at biblibre.com

--- Comment #4 from Paul Poulain  ---
The patch does not apply, I tried to solve the conflits, as it looked easy, but
no success.

Please fix & switch back to passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:56:46 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 16:56:46 +0000
Subject: [Koha-bugs] [Bug 8104] DataTables in Acquisision module:
	lateorders.tt
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8104

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|unspecified                 |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 18:59:47 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 16:59:47 +0000
Subject: [Koha-bugs] [Bug 8103] DataTables in Acquisision module: parcels.tt
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8103

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|unspecified                 |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 19:26:32 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 17:26:32 +0000
Subject: [Koha-bugs] [Bug 8102] DataTables in Acquisision module: supplier.tt
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8102

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|unspecified                 |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 19:28:35 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 17:28:35 +0000
Subject: [Koha-bugs] [Bug 8100] DataTables in Acquisision module:
	neworderbiblio.tt
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8100

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|unspecified                 |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 19:31:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 17:31:33 +0000
Subject: [Koha-bugs] [Bug 8099] DataTables in Acquisision module:
	acqui-home.tt
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8099

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|unspecified                 |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 19:35:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 17:35:25 +0000
Subject: [Koha-bugs] [Bug 8098] DataTables in Acquisision module: parcel.tt
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8098

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 19:41:22 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 17:41:22 +0000
Subject: [Koha-bugs] [Bug 8006] Loading offline circulation does not
	anonymize
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8006

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com

--- Comment #4 from Paul Poulain  ---
patch pushed (untested, but very simple patch, trusting signoffer)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 20:42:38 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 18:42:38 +0000
Subject: [Koha-bugs] [Bug 8154] The export today's checked in barcodes
 generated file is always empty
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #8 from Ian Walls  ---
As this patch implements something I suggested, perhaps I'm not the best person
to QA it, but from what I can tell, it does the job of fixing the comparison
types most handily, and using modern Koha modules.  Marking Passed QA.... if
anyone objects to this, please say so.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 20:47:53 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 18:47:53 +0000
Subject: [Koha-bugs] [Bug 3383] Item due reminder digests - cannot display
 title information
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3383

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #9 from Ian Walls  ---
New subroutine is added to advance_notices.pl that makes use of
GetMemberDetails to get the borrower's branchcode.  This is incredibly
inefficient, and should be replaced with GetMember.  See bug 7058.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 20:53:28 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 18:53:28 +0000
Subject: [Koha-bugs] [Bug 8224] aqplan.pl and aqbudgets: authorized values
 doesn't appear in planning list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8224

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |koha.sekjal at gmail.com

--- Comment #3 from Ian Walls  ---
Removes conditional check for "authcat" in order to display auth values list. 
Template only change, handles indentation, marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 20:55:13 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 18:55:13 +0000
Subject: [Koha-bugs] [Bug 8194] Layout problem on subscription add when
 showing manual history
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8194

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |koha.sekjal at gmail.com

--- Comment #5 from Ian Walls  ---
Template only change, moving 
       boundaries around.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 20:56:26 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 18:56:26 +0000
Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at
	checkin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |koha.sekjal at gmail.com

--- Comment #5 from Ian Walls  ---
Correctly reimplements duration as signed instead of absolute value.  Marking
Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 20:59:32 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 18:59:32 +0000
Subject: [Koha-bugs] [Bug 8272] OPAC : date expiration format
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8272

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |koha.sekjal at gmail.com

--- Comment #6 from Ian Walls  ---
Template only change to add date filter.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:10:47 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 19:10:47 +0000
Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_10

--- Comment #26 from Paul Poulain  ---
Patch pushed, and I don't think a follow-up is needed to add the dependency,
because it's unneeded for a standard production server, ppl installing will be
wondering why and if they should install this package

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:17:31 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 19:17:31 +0000
Subject: [Koha-bugs] [Bug 8181] Replace DynArch calendar widget with
	jQueryUI version
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181

--- Comment #9 from Ian Walls  ---
Created attachment 10391
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10391&action=edit
[PASSED QA] Bug 8181 [REVISED] Replace DynArch calendar widget with jQueryUI
version

All instances of the old DynArch calendar have been replaced with
jQueryUI versions and the old library files have been removed.

calendar.inc has been modified to include jQueryUI localization
strings and global configuration options. Just add a "datepicker"
class to an input field to trigger a datepicker prompt.

If you would like two fields in one from to limit each other (one
is date from, one is date to), add these classes to each:
"datepickerfrom" and "datepickerto." This will prevent an invalid
entry, e.g. a date in the latter which falls before the former.

jQueryUI is now upgraded to the latest verision, 1.8.21.

Edit: Now with proper translatability, date formatting, first day
of the week handling, and RTL support.

Signed-off-by: Chris Cormack 
Signed-off-by: Ian Walls 
QA Comment:  rebased on current master; minor merge conflicts with other
patches pushed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:18:03 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 19:18:03 +0000
Subject: [Koha-bugs] [Bug 8181] Replace DynArch calendar widget with
	jQueryUI version
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10371|0                           |1
        is obsolete|                            |

--- Comment #10 from Ian Walls  ---
Comment on attachment 10371
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10371
Bug 8181 [REVISED] Replace DynArch calendar widget with jQueryUI version

Rebased patch to apply on current master (trivial conflicts resolved)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:18:21 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 19:18:21 +0000
Subject: [Koha-bugs] [Bug 8181] Replace DynArch calendar widget with
	jQueryUI version
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |koha.sekjal at gmail.com

--- Comment #11 from Ian Walls  ---
While this is a very large patch, it is entirely template based.  It moves us
from one implementation of the datepicker to a better one, with a little
spacing cleanup along the way for good measure.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:20:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 19:20:04 +0000
Subject: [Koha-bugs] [Bug 8255] Local cover images should be cacheable
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8255

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |koha.sekjal at gmail.com

--- Comment #4 from Ian Walls  ---
Just changes caching rules to make more sense.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:21:54 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 19:21:54 +0000
Subject: [Koha-bugs] [Bug 7905] Multi-line notes are displayed on one line
 in Staff Serials page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7905

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #6 from Ian Walls  ---
Both patches are template only, and add the HTML line break filter to fields
that are known to have line breaks.  Marking Passed QA on both.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:30:36 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 19:30:36 +0000
Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:36:02 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 19:36:02 +0000
Subject: [Koha-bugs] [Bug 7787] SIP server closes the TCP connection when it
 receives an invalid message
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7787

--- Comment #12 from Ian Walls  ---
Removes 3 strikes logic in favour of continuous monitoring of the input.  If
bad input is passed, the RESEND message is returned, rather than the system
hanging.  This seems like a solid way to go, in my opinion, but I don't have
sufficient SIP clients to test against.

Personally, I'm inclined to sign off on this, but I'm not 100% it should pass
QA just on my say so.  Would another member of the QA team please review this
patch as well, preferably running it through some kind of live SIP client? 
This is one of those occasions where having an extra set of QA-eyes will be
very helpful.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:36:08 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 19:36:08 +0000
Subject: [Koha-bugs] [Bug 7787] SIP server closes the TCP connection when it
 receives an invalid message
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7787

--- Comment #13 from Ian Walls  ---
Created attachment 10392
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10392&action=edit
[SIGNED OFF] Bug 7787: Make the SIP server much more robust.

Be liberal in what we accept, but strict in what we send:
Never exit the server process, but send a SC_RESEND message (96)
to the client if we received anything we don't understand.
 This is consistent with SIP server implementations of other ILSs.

Signed-off-by: Colin Campbell 
Signed-off-by: Ian Walls 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:36:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 19:36:24 +0000
Subject: [Koha-bugs] [Bug 5079] Make display of shelving location and call
 number in XSLT results controlled by sysprefs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff
                 CC|                            |kyle.m.hall at gmail.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:36:36 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 19:36:36 +0000
Subject: [Koha-bugs] [Bug 7787] SIP server closes the TCP connection when it
 receives an invalid message
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7787

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10362|0                           |1
        is obsolete|                            |

--- Comment #14 from Ian Walls  ---
Comment on attachment 10362
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10362
Signed off patch

Minor conflict with perl critic fixes... fixed now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:42:34 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 19:42:34 +0000
Subject: [Koha-bugs] [Bug 7857] database upgrade fails with plack
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7857

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:43:34 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 19:43:34 +0000
Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a
 tag in the tag cloud isn't the number of items with that tag
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_8
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:50:41 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 19:50:41 +0000
Subject: [Koha-bugs] [Bug 7447] Allow to specify a date in overdue_notice.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7447

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:53:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 19:53:24 +0000
Subject: [Koha-bugs] [Bug 8278] New: Replace YUI autocomplete in UNIMARC
	210c plugin
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8278

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8278
          Assignee: oleonard at myacpl.org
            Blocks: 7747
           Summary: Replace YUI autocomplete in UNIMARC 210c plugin
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: oleonard at myacpl.org
          Hardware: All
            Status: NEW
           Version: master
         Component: Templates
           Product: Koha

There is a YUI autocomplete instance in a UNIMARC plugin
(unimarc_field_210c_bis.tt) which I couldn't figure out how to test, even on a
sandbox set up with UNIMARC. I could use help with a follow-up to Bug 7747.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:53:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 19:53:24 +0000
Subject: [Koha-bugs] [Bug 7747] Replace YUI autocomplete with jQueryUI
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7747

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |8278

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 21:59:10 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 19:59:10 +0000
Subject: [Koha-bugs] [Bug 7387] Add Template::Toolkit plugin to allow
	caching of includes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7387

--- Comment #7 from Paul Poulain  ---
(In reply to comment #3)
> QA comment: chris, there is no explanation of the positive effect of this.
> What would be the next step if this patch is included ? could we do that
> with all includes ? more explanation welcomed !

Chris, before pushing this patch, i'd like to understand what will be the next
step. Should all templates be switched to:
-[% INCLUDE 'doc-head-open.inc' %]
+[% USE cache = Cache %]
+[% cache.inc(
+    'template' => 'doc-head-open.inc',
+    'keys' => {'dochead' => 'dochead'},
+    'ttl' => 360
+    )
+%]

?
(if that's the case, then I'll add this to my next RM newsletter & send a mail
to koha-devel about that)
Do you already have a list of other .inc we could cache too ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 22:04:22 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 20:04:22 +0000
Subject: [Koha-bugs] [Bug 6774] Display barcode on OPAC detail page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6774

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|PATCH-Sent (DO NOT USE)     |P3
             Status|Passed QA                   |Pushed to Master
            Version|rel_3_6                     |rel_3_10

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 22:12:52 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 20:12:52 +0000
Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |In Discussion
                 CC|                            |koha.sekjal at gmail.com

--- Comment #25 from Ian Walls  ---
The test plan for this patch has drifted from the original problem.  Most
testing seems to be running the new Holidays DB dependent unit test, rather
than testing fines.pl to see if fines are accruing on holidays.

This fix looks good and solid for what it is, but I'm not 100% convinced that
it fixes the actual problem reported.  Please test against fines.pl, and
confirm this patch prevents fines from accruing on closed days.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 22:12:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 20:12:59 +0000
Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 22:19:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 20:19:33 +0000
Subject: [Koha-bugs] [Bug 6634] manager_id not populated when paying fines
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
           Severity|enhancement                 |normal

--- Comment #26 from Paul Poulain  ---
New follow-up pushed

(it's not an ENH, chris_c, I think those patches should to ported to 3.8)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 22:25:23 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 20:25:23 +0000
Subject: [Koha-bugs] [Bug 5910] Authorities : allow users to search on all
	auth types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|PATCH-Sent (DO NOT USE)     |P3
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_10

--- Comment #14 from Paul Poulain  ---
I've pushed the patches because they work as announced but I'd like to
understand why 
> UNIMARC is the only marcflavour that does not already have an option
> for searching all authority types, so check that the marcflavour is
> UNIMARC before displaying the additional "All authority types" option.

if it works under MARC21, why wouldn't we use the same method for UNIMARC ? How
does it work for MARC21 ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 22:25:42 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 20:25:42 +0000
Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

--- Comment #26 from Ian Walls  ---
Further investigation:  the test script tests 'is_holiday', which is what's
used in fines.pl to determine whether or not to charge the fine.  If the tests
pass, then is_holiday works as expected (at least for the 4 tested dates), and
fines.pl shouldn't calculate the fine for today (if today is a holiday).

This should be relatively easy to test:

1.  Mark today as a holiday for a branch
2.  Find an overdue material that should be accruing fines for this branch
3.  Run fines.pl
4.  confirm that the fine is NOT added

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 22:32:02 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 20:32:02 +0000
Subject: [Koha-bugs] [Bug 5910] Authorities : allow users to search on all
	auth types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910

--- Comment #15 from Jared Camins-Esakov  ---
(In reply to comment #14)
> if it works under MARC21, why wouldn't we use the same method for UNIMARC ?
> How does it work for MARC21 ?

Actually, the way it works for MARC21 can only be called... uhhh... weird?
There is actually a blank authority type for MARC21, and since Zebra cannot
search on blank fields, that is de facto the same as all authority types. The
way UNIMARC does it is a lot better.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 22:36:56 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 20:36:56 +0000
Subject: [Koha-bugs] [Bug 5910] Authorities : allow users to search on all
	auth types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910

--- Comment #16 from Paul Poulain  ---
(In reply to comment #15)
> (In reply to comment #14)
> > if it works under MARC21, why wouldn't we use the same method for UNIMARC ?
> > How does it work for MARC21 ?
> 
> Actually, the way it works for MARC21 can only be called... uhhh... weird?
> There is actually a blank authority type for MARC21, and since Zebra cannot
> search on blank fields, that is de facto the same as all authority types.
> The way UNIMARC does it is a lot better.

What about doing a follow-up like :
 * removing blank authority type in an updatedatabase
 * remove the [% if (unimarc) %]
would it do the job ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 22:50:22 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 20:50:22 +0000
Subject: [Koha-bugs] [Bug 8226] 'OpacFooter' markup/css improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8226

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #9 from Chris Cormack  ---
No string changes, no functionality changes, safe to push this close to a
release. Pushed to 3.8.x will be in 3.8.2

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 22:52:26 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 20:52:26 +0000
Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #27 from Chris Cormack  ---
(In reply to comment #26)
> Further investigation:  the test script tests 'is_holiday', which is what's
> used in fines.pl to determine whether or not to charge the fine.  If the
> tests pass, then is_holiday works as expected (at least for the 4 tested
> dates), and fines.pl shouldn't calculate the fine for today (if today is a
> holiday).
> 
> This should be relatively easy to test:
> 
> 1.  Mark today as a holiday for a branch
> 2.  Find an overdue material that should be accruing fines for this branch
> 3.  Run fines.pl
> 4.  confirm that the fine is NOT added

5. Switch dateformat syspref and try again

Chris

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 22:55:17 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 20:55:17 +0000
Subject: [Koha-bugs] [Bug 4255] Add item type to facet list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4255

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |claire.hernandez at biblibre.c
                   |                            |om,
                   |                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_10

--- Comment #7 from Paul Poulain  ---
Patch pushed, a follow-up for UNIMARC would be usefull, will ask claire

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 23:04:29 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 21:04:29 +0000
Subject: [Koha-bugs] [Bug 5910] Authorities : allow users to search on all
	auth types
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5910

--- Comment #17 from Jared Camins-Esakov  ---
(In reply to comment #16)
> What about doing a follow-up like :
>  * removing blank authority type in an updatedatabase
>  * remove the [% if (unimarc) %]
> would it do the job ?

Unfortunately, it seems like old Koha installations are actually dependent on
the "Default" authority type. I hope to reduce the dependency on the Default
authority type with my work in the authority module, but as of right now, I
don't think we can safely remove it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 23:13:19 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 21:13:19 +0000
Subject: [Koha-bugs] [Bug 3708] Add another customizable region to the OPAC:
 right sidebar
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3708

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_10

--- Comment #12 from Paul Poulain  ---
Path pushed,

I really find the
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=1529 useful, i've
sent a mail to nicole to suggest adding it to the documentation

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 23:16:22 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 21:16:22 +0000
Subject: [Koha-bugs] [Bug 8267] Overdue notices not working
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8267

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_8

--- Comment #6 from Paul Poulain  ---
Patch pushed, update the patch description with comment 2

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 23:17:45 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 21:17:45 +0000
Subject: [Koha-bugs] [Bug 8222] The zip code field is mandatory by default
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8222

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #6 from Chris Cormack  ---
No string changes, pushed to 3.8.x will be in 3.8.2

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 23:20:14 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 21:20:14 +0000
Subject: [Koha-bugs] [Bug 8154] The export today's checked in barcodes
 generated file is always empty
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|unspecified                 |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 23:24:43 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 21:24:43 +0000
Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at
	checkin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 23:27:58 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 21:27:58 +0000
Subject: [Koha-bugs] [Bug 7367] General OPAC typo omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #15 from Chris Cormack  ---
String changes, held for 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 23:28:35 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 21:28:35 +0000
Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts
 in circulation.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 20 23:30:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 21:30:33 +0000
Subject: [Koha-bugs] [Bug 8272] OPAC : date expiration format
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8272

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 00:02:51 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 22:02:51 +0000
Subject: [Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #3 from Chris Cormack  ---
Created attachment 10393
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10393&action=edit
Bug 5858 - Updating the marc21_framework_DEFAULT.sql to MARC21 version 14

Based on work in the Koha Kobli fork

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 00:03:30 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 22:03:30 +0000
Subject: [Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 00:03:46 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 22:03:46 +0000
Subject: [Koha-bugs] [Bug 5858] Default frameworks missing many MARC21 tags
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5858

--- Comment #4 from Chris Cormack  ---
This is currently english only.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 00:14:01 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 22:14:01 +0000
Subject: [Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an
 item between branches
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911

--- Comment #28 from Melia Meggs  ---
What is the next step here?  Is the first patch staying as is, or does it
require changes?  Does the patch that stops the perlcritic warnings need to be
signed off now?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 00:25:22 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 22:25:22 +0000
Subject: [Koha-bugs] [Bug 7387] Add Template::Toolkit plugin to allow
	caching of includes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7387

--- Comment #8 from Chris Cormack  ---
(In reply to comment #7)
> (In reply to comment #3)
> > QA comment: chris, there is no explanation of the positive effect of this.
> > What would be the next step if this patch is included ? could we do that
> > with all includes ? more explanation welcomed !
> 
> Chris, before pushing this patch, i'd like to understand what will be the
> next step. Should all templates be switched to:
> -[% INCLUDE 'doc-head-open.inc' %]
> +[% USE cache = Cache %]
> +[% cache.inc(
> +    'template' => 'doc-head-open.inc',
> +    'keys' => {'dochead' => 'dochead'},
> +    'ttl' => 360
> +    )
> +%]
> 
> ?
> (if that's the case, then I'll add this to my next RM newsletter & send a
> mail to koha-devel about that)
> Do you already have a list of other .inc we could cache too ?

Nope d, in fact caching that one won't win us much at all it's fast to render
anyway. But looking into caching things that require computation, would be
good. This patch is just to enable people to cache includes when they find
ones, or even better create includes and cache them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 01:24:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 20 Jun 2012 23:24:04 +0000
Subject: [Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an
 item between branches
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911

--- Comment #29 from Srdjan Jankovic  ---
First one is OK as is, other one needs sign-off and then both need qa together
I suppose.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 02:23:54 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 00:23:54 +0000
Subject: [Koha-bugs] [Bug 7993] saved report with hierarchies
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993

--- Comment #1 from Srdjan Jankovic  ---
Created attachment 10394
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10394&action=edit
bug_7993: Save reports with Group/Subgroup hierarchy

This should make saved reports more manageable.
Group/Subgroup hierarchy is stored in authorised_values,
categories REPORT_GROUP and REPORT_SUBGROUP, connected by
REPORT_SUBGROUP.lib_opac -> REPORT_GROUP.authorised_value

Database changes:
* authorised_values: expanded category to 16 chars
* created default set of REPORT_GROUP authorised values to match
  hardcoded report areas
* reports_dictionary: replaced area int with report_area text, converted
  values
* saved_sql: added report_area, report_group and report_subgroup;
  report_area is not currently used, saved for the record

C4/Reports/Guided.pm:
* Replaced Area numeric values with the mnemonic codes
* get_report_areas(): returns hardcoded areas list
* created get_report_areas(): returns full hierarchy (groups with belonging
  subgroups)
* save_report(): changed iterface, accepts fields hashref as input
* update_sql(): changed iterface, accepts id and fields hashref as input
* get_saved_reports():]
- join to authorised_values to pick group and subgroup name
- accept group and subgroup filter params
* get_saved_report():
- changed iterface, return record hashref
- join to authorised_values to pick group and subgroup name
* build_authorised_value_list(): new sub, moved code from
  reports/guided_reports.pl
* Updated interfaces in:
cronjobs/runreport.pl, svc/report, opac/svc/report: get_saved_report()
reports/dictionary.pl: get_report_areas()
reports/guided_reports.pl

reports/guided_reports_start.tt:
* Reports list:
- added group/subgroup filter
- display area/group/subgroup for the reports
* Create report wizard:
- carry area to the end
- select group and subgroup when saving the report; group defaults to area,
  useful when report groups match areas
* Update report and Create from SQL: added group/subgroup
* Amended reports/guided_reports.pl accordingly

Conflicts:

    C4/Reports/Guided.pm
    admin/authorised_values.pl
    installer/data/mysql/kohastructure.sql
    installer/data/mysql/updatedatabase.pl
    koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tmpl
    koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tmpl
    misc/cronjobs/runreport.pl
    reports/dictionary.pl
    reports/guided_reports.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 07:47:29 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 05:47:29 +0000
Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title
 with borrower's age without using categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10144|0                           |1
        is obsolete|                            |

--- Comment #23 from Marc V?ron  ---
Created attachment 10395
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10395&action=edit
[REBASED] BUG 7621 [ENH] Circulation: Match age restriction of title with
borrower's age without using categories

Signed-off-by: Chris Cormack 

New version implementing Paul's advice.
See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 08:49:56 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 06:49:56 +0000
Subject: [Koha-bugs] [Bug 8263] Make OPAC stylesheet preferences more
	consistent
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10355|0                           |1
        is obsolete|                            |

--- Comment #5 from M. de Rooy  ---
Created attachment 10396
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10396&action=edit
Rebased dbrev for 8263

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 09:42:05 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 07:42:05 +0000
Subject: [Koha-bugs] [Bug 5888] opac-detail subject/author links improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5888

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|PATCH-Sent (DO NOT USE)     |P5 - low
                 CC|                            |m.de.rooy at rijksmuseum.nl
            Version|rel_3_4                     |master

--- Comment #13 from M. de Rooy  ---
Just a *dumb* question: If I click on a subject or author, wouldn't it be
logical to start searching for it directly instead of presenting another menu
where I have to click Search again? I understand that I now have the option to
select multiple subjects, but if I wanted that, wouldn't I have typed them in
the search box already? 

Also note that I would not prefer to let normal view and xslt view deviate in
this regard. Confusing for users?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 09:51:16 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 07:51:16 +0000
Subject: [Koha-bugs] [Bug 5981] OPAC: Add limits to search history
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5981

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|PATCH-Sent (DO NOT USE)     |P5 - low

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 09:52:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 07:52:24 +0000
Subject: [Koha-bugs] [Bug 7430] ModZebra should not be in C4::Biblio
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7430

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|PATCH-Sent (DO NOT USE)     |P3
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 09:57:32 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 07:57:32 +0000
Subject: [Koha-bugs] [Bug 5079] Make display of shelving location and call
 number in XSLT results controlled by sysprefs
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5079

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|PATCH-Sent (DO NOT USE)     |P5 - low

--- Comment #30 from M. de Rooy  ---
Could one of the patch authors sort out which patch should be tested and mark
the others as obsolete? Thanks.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 09:57:47 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 07:57:47 +0000
Subject: [Koha-bugs] [Bug 8105] DataTables in Acquisision module:
	basketgroup.tt
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8105

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10083|0                           |1
        is obsolete|                            |

--- Comment #5 from Jonathan Druart  ---
Created attachment 10397
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10397&action=edit
Bug 8272 - OPAC : date expiration format

Adding TT date filter to output of expiration date
on OPAC user page.

Signed-off-by: Chris Cormack 
Signed-off-by: Delaye Stephane 
Signed-off-by: Paul Poulain 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 10:01:10 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 08:01:10 +0000
Subject: [Koha-bugs] [Bug 8105] DataTables in Acquisision module:
	basketgroup.tt
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8105

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10397|0                           |1
        is obsolete|                            |

--- Comment #6 from Jonathan Druart  ---
Created attachment 10398
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10398&action=edit
Bug 5345: DataTables integration in acquisition module [5]

basketgroup.tt

http://bugs.koha-community.org/show_bug.cgi?id=8105
Signed-off-by: Marijana Glavica 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 10:01:54 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 08:01:54 +0000
Subject: [Koha-bugs] [Bug 8105] DataTables in Acquisision module:
	basketgroup.tt
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8105

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Passed QA

--- Comment #7 from Jonathan Druart  ---
attachment 10397 is a wrong patch for this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 10:29:47 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 08:29:47 +0000
Subject: [Koha-bugs] [Bug 8279] New: CAS Debugging improvements
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8279

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8279
          Assignee: gmcharlt at gmail.com
           Summary: CAS Debugging improvements
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: matthias.meusburger at biblibre.com
          Hardware: All
            Status: NEW
           Version: rel_3_8
         Component: Tools
           Product: Koha

Adds more precise debug informations for easier CAS troubleshootings
resolution.

Before this patch, whenever ticket validation failed, the debug message was
"Invalid ticket". 
But ticket validation may fail for other reasons: CAS server not reachable,
casServerUrl syspref is wrong...

This patch adds the reason for ticket validation failing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 10:30:14 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 08:30:14 +0000
Subject: [Koha-bugs] [Bug 8279] CAS Debugging improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8279

Matthias Meusburger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |5630

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 10:30:14 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 08:30:14 +0000
Subject: [Koha-bugs] [Bug 5630] CAS improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5630

Matthias Meusburger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |8279

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 10:40:47 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 08:40:47 +0000
Subject: [Koha-bugs] [Bug 8279] CAS Debugging improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8279

--- Comment #1 from Matthias Meusburger  ---
Created attachment 10399
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10399&action=edit
Bug 8279: CAS Debugging improvements

Adds more precise debug informations for easier CAS troubleshootings
resolution.

  Before this patch, whenever ticket validation failed, the debug message was
"Invalid ticket".
  But ticket validation may fail for other reasons: CAS server not reachable,
casServerUrl syspref is wrong...

  This patch adds the reason for ticket validation failing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 10:41:15 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 08:41:15 +0000
Subject: [Koha-bugs] [Bug 8279] CAS Debugging improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8279

Matthias Meusburger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |matthias.meusburger at biblibr
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 10:47:54 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 08:47:54 +0000
Subject: [Koha-bugs] [Bug 5335] More granular VAT
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5335

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10148|0                           |1
        is obsolete|                            |

--- Comment #34 from Jonathan Druart  ---
Created attachment 10400
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10400&action=edit
Rebased patch

BZ5335: More granular VAT

signed-off-by: Pierre Angot

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 10:52:23 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 08:52:23 +0000
Subject: [Koha-bugs] [Bug 7901] Add batch delete borrowers script
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7901

delaye  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stephane.delaye at biblibre.co
                   |                            |m

--- Comment #2 from delaye  ---
why i can't load the cardnumber file in koha it will be more easy for the
users...

i have this message

perl batch_delete_borrowers.pl --f file_test -c
DBD::mysql::st execute failed: Column count doesn't match value count at row 1
at /home/koha/src/C4/Members.pm line 1679,  line 1.
DBD::mysql::st execute failed: Column count doesn't match value count at row 1
at /home/koha/src/C4/Members.pm line 1679,  line 2.
DBD::mysql::st execute failed: Column count doesn't match value count at row 1
at /home/koha/src/C4/Members.pm line 1679,  line 3.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 11:05:03 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 09:05:03 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

--- Comment #38 from M. de Rooy  ---
Created attachment 10401
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10401&action=edit
Patch for timeline

Fixes few tabs within date; adds a regex to fix mistakes with spaces.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 11:05:30 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 09:05:30 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P5 - low
             Status|ASSIGNED                    |Needs Signoff
            Version|rel_3_8                     |master
           Severity|enhancement                 |trivial

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 11:34:54 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 09:34:54 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10401|0                           |1
        is obsolete|                            |

--- Comment #39 from Marc V?ron  ---
Created attachment 10402
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10402&action=edit
[SIGNED-OFF] 7143 Followup for timeline

Fixes few tabs within date; adds a regex to fix mistakes with spaces.

Signed-off-by: Marc Veron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 11:35:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 09:35:25 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 11:56:11 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 09:56:11 +0000
Subject: [Koha-bugs] [Bug 6777] Display link to related acquisitions details
 from catalogue record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6777

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |paul.poulain at biblibre.com

--- Comment #3 from Paul Poulain  ---
Patch tested with a sandbox, by Delaye Stephane 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 11:56:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 09:56:24 +0000
Subject: [Koha-bugs] [Bug 6777] Display link to related acquisitions details
 from catalogue record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6777

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9946|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 11:56:29 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 09:56:29 +0000
Subject: [Koha-bugs] [Bug 6777] Display link to related acquisitions details
 from catalogue record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6777

--- Comment #4 from Paul Poulain  ---
Created attachment 10403
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10403&action=edit
Bug 6777 - Display link to related acquisitions details from catalogue record

A new column -Acq info- has been added to the holding tab of the catalog detail
page .The column will contain the link which will redirect to the order details
of that item. The permission settings has been done so that the user who has
the Manage orders & basket permission can see the link.The link is also visible
under Item information in the Items tab.

Signed-off-by: Delaye Stephane 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 12:05:00 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 10:05:00 +0000
Subject: [Koha-bugs] [Bug 6138] Show local help and isbd punctuation
 automatically when we are cataloguing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6138

Juan Romay Sieira  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|rel_3_4                     |master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 12:05:46 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 10:05:46 +0000
Subject: [Koha-bugs] [Bug 6138] Show local help and isbd punctuation
 automatically when we are cataloguing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6138

Juan Romay Sieira  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7536|0                           |1
        is obsolete|                            |

--- Comment #6 from Juan Romay Sieira  ---
Created attachment 10404
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10404&action=edit
Patch to apply in current master

Patch ready to apply in current master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 12:06:14 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 10:06:14 +0000
Subject: [Koha-bugs] [Bug 6138] Show local help and isbd punctuation
 automatically when we are cataloguing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6138

Juan Romay Sieira  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 12:36:46 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 10:36:46 +0000
Subject: [Koha-bugs] [Bug 6777] Display link to related acquisitions details
 from catalogue record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6777

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #5 from Katrin Fischer  ---
There are already a lot of links to the invoice and the basket on the
moredetail screen - I am not sure if this is not something which is already
there?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 12:38:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 10:38:59 +0000
Subject: [Koha-bugs] [Bug 5295] ctype index Zebra configuration
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #10 from M. de Rooy  ---
(In reply to comment #9)
> Can we replace "ctype" by "Content-type" for all record.abs ?
Yes, you should, if you rename it in bib1.att. The patch at this moment will
raise the warning: [warn] Index 'ctype' not found in attset(s). Nothing will be
found anymore with ctype=...

Changing status to reflect need for adjustment.

Furthermore, you remove "t=b" (right and left truncation). I think that is okay
(at least for left truncation). But note that this field is NOT a single
letter. Actually, it contains (in MARC21) four characters. But they should be
taken as four separate letters. That is currently a problem in Zebra; e.g. if I
enter abc in Content-type, I cannot find this record when searching for
ctype=b. In the correct interpretation of this marc field, I would like to find
it when searching for a, b or c. Probably, this problem is outside the scope of
your report.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 12:40:41 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 10:40:41 +0000
Subject: [Koha-bugs] [Bug 5295] ctype index Zebra configuration
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|PC                          |All
            Version|rel_3_2                     |master
         QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |
                 OS|Linux                       |All

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 13:14:23 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 11:14:23 +0000
Subject: [Koha-bugs] [Bug 7379] copynumber is displayed 'as is' when linked
 to autorised values
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7379

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
            Version|rel_3_6                     |master

--- Comment #24 from M. de Rooy  ---
The adjusted patch lost the signoff in the commit message, but did not really
change. A previous QA comment has been applied.
Looks good to me.
Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 13:44:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 11:44:33 +0000
Subject: [Koha-bugs] [Bug 7986] Export issues
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |8202

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 13:44:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 11:44:33 +0000
Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
         Depends on|                            |7986

--- Comment #3 from Jonathan Druart  ---
Arf, A patch for Bug 7986 introduces a lot of modifications for the same file
tools/export.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 13:48:57 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 11:48:57 +0000
Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202

--- Comment #4 from Katrin Fischer  ---
Hi Jonathan, I know it's annoying, but as this patch is already signed off, I
don't think the other should block it. This way 2 patches will have to be
reworked.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 13:51:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 11:51:59 +0000
Subject: [Koha-bugs] [Bug 7986] Export issues
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|8202                        |
         Depends on|                            |8202

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 13:51:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 11:51:59 +0000
Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |7986
         Depends on|7986                        |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 13:55:02 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 11:55:02 +0000
Subject: [Koha-bugs] [Bug 8253] Fine doubling
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10369|0                           |1
        is obsolete|                            |

--- Comment #2 from Kyle M Hall  ---
Created attachment 10405
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10405&action=edit
Bug 8253 - Fine doubling

This issue only occurs when upgrading from pre-3.8 to post 3.8 Koha.

The issue is caused by the change from dates to datetimes that was
neccesary to implement hourly loans. All pre-3.8 fines have the date
in the description. This date is how the fines script know which fine
to update. If the fine script does not locate an existing row to update,
it creates a new row.

The switch from dates to datetimes means the fines script now looks
for a format such as 'YYYY-MM-DD 00:00' ( for iso ), but all the previous
fines are still in the format 'YYYY-MM-DD' and so it fails to find
the matching row, and creates a new row instead.

This commit consists of a database update that alters the dates
in the accountlines description field to be datetimes instead. This
eliminates future fine doubling. It is also safe to run on a system
that has been previously upgraded, it will ignore any rows where
the date is already of the format 'YYYY-MM-DD 00:00' ( or whichever
date format you have chosen ).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 13:56:44 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 11:56:44 +0000
Subject: [Koha-bugs] [Bug 8253] Fine doubling
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 14:03:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 12:03:12 +0000
Subject: [Koha-bugs] [Bug 8280] New: SRU should be filterable by Koha Item
	Type
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8280
                CC: m.de.rooy at rijksmuseum.nl
          Assignee: gmcharlt at gmail.com
           Summary: SRU should be filterable by Koha Item Type
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: martin.renvoize at ptfs-europe.com
          Hardware: All
            Status: NEW
           Version: rel_3_8
         Component: Z39.50 / SRU / OpenSearch Servers
           Product: Koha

It would be very useful to be able to query the SRU server by the current
index's in Koha, including the Item Type Index.

My understanding is the standard CQL queries should work, so:

:9998/biblios?version=1.1&operation=searchRetrieve&query=itype=XXX

should yeild results conatining all records of itype (952$y in Marc21 Koha)
XXX, but I have not been able to get this to work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 14:20:11 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 12:20:11 +0000
Subject: [Koha-bugs] [Bug 7991] Display in a holding summary tab
 informations about serial record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7991

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9400|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart  ---
Created attachment 10406
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10406&action=edit
Bug 7991: Add itemcallnumber into the serial collection tab

This patch adds a new column containing the itemcallnumber value into
the serial collection tab (opac detail).
  930$a for UNIMARC
  852$h for others

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 14:20:29 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 12:20:29 +0000
Subject: [Koha-bugs] [Bug 7991] Display in a holding summary tab
 informations about serial record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7991

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|In Discussion               |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 14:24:56 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 12:24:56 +0000
Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280

--- Comment #1 from M. de Rooy  ---
You are probably right that there is no itype reference in pqf.properties.
Can you still search on itemtype=... ? It could just be referring to 8031
itype..
Note that we have 8031 and 9006 for itype and itemtype in attset.
If itype and itemtype are also in your record.abs, it may just be a matter of
defining it too in pqf.properties.

Test it please, and submit a patch!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 14:29:43 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 12:29:43 +0000
Subject: [Koha-bugs] [Bug 7913] Automatically receive serial issues
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7913

delaye  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stephane.delaye at biblibre.co
                   |                            |m

--- Comment #4 from delaye  ---
the use of this function is limited to subscriptions without items records.And
the bulk reception start always from the last issue expected then it would be
better to choose which serial number you want to begin receiving and not always
from the last number expected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 14:38:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 12:38:59 +0000
Subject: [Koha-bugs] [Bug 5295] ctype index Zebra configuration
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5295

--- Comment #11 from Fridolyn SOMERS  ---
> M. de Rooy : Furthermore, you remove "t=b" (right and left truncation)
I agree with you.

But I think truncation should not be implicit.
You can add truncation in query search.
Or create a second index CCL that contains truncation.
ie : Content-type-truncated 1=1034 t=b

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 14:43:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 12:43:59 +0000
Subject: [Koha-bugs] [Bug 7913] Automatically receive serial issues
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7913

--- Comment #5 from Savitra Sirohi  ---
When we created this bug, our intention was to create a way to automatically
receive issues, no manual intervention. 

We will soon be submitting a patch which has a script that runs in the cron.
Issues in expected status will be automatically changed to arrived.

Maybe this change and our change can co-exist.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 14:50:43 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 12:50:43 +0000
Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280

--- Comment #2 from Martin Renvoize  ---
(In reply to comment #1)
> You are probably right that there is no itype reference in pqf.properties.
> Can you still search on itemtype=... ? It could just be referring to 8031
> itype..
> Note that we have 8031 and 9006 for itype and itemtype in attset.
> If itype and itemtype are also in your record.abs, it may just be a matter
> of defining it too in pqf.properties.
> 
> Test it please, and submit a patch!

Magnus over in the IRC channel just took the time to explain how the zebra
config all fits together and has solved the problem for me. 

I'll submit the patch once I've worked out where it fits for the installer (as
obviously the config files being sued arn't git aware.

Cheers

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 14:58:44 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 12:58:44 +0000
Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955

--- Comment #14 from Owen Leonard  ---
Created attachment 10407
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10407&action=edit
Statistics table after checkouts and checkins

After two checkouts and three or four checkins this is what the new statistics
page looks like. Are those numbers wrong or am I missing something? Why do the
location, itype, and ccode columns say "location," "itype," and "ccode?"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 14:59:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 12:59:04 +0000
Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280

Magnus Enger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |magnus at enger.priv.no

--- Comment #3 from Magnus Enger  ---
Here is a quick writeup of what we figured out on IRC: 
http://wiki.koha-community.org/wiki/Making_more_index_searchable_with_Zebra_SRU

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:00:42 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 13:00:42 +0000
Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280

--- Comment #4 from M. de Rooy  ---
(In reply to comment #3)
> Here is a quick writeup of what we figured out on IRC: 
> http://wiki.koha-community.org/wiki/
> Making_more_index_searchable_with_Zebra_SRU

Great. You also add it in pqf.properties. Mind the typo. I would not put in
dublin core context either..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:03:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 13:03:25 +0000
Subject: [Koha-bugs] [Bug 8281] New: Remove unused YUI files
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8281

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8281
          Assignee: oleonard at myacpl.org
           Summary: Remove unused YUI files
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: oleonard at myacpl.org
          Hardware: All
            Status: ASSIGNED
           Version: master
         Component: Templates
           Product: Koha

We include many many YUI assets which have never been used and will now never
be used since we're transitioning away from YUI. These can be safely removed
without requiring any template changes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:11:47 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 13:11:47 +0000
Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280

--- Comment #5 from Magnus Enger  ---
By all means, please feel free to improve the wiki page!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:32:40 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 13:32:40 +0000
Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |julian.maurice at biblibre.com

--- Comment #28 from Julian Maurice  ---
This is not working but this is not related to the patch.
Subroutine Koha::Calendar::days_between "truncate to days" both start date and
end date. So if my item is due since 2012-05-21 and I want to calculate fine at
2012-06-21, $duration will be 0 instead of 30. So this ends in days_between
returning -4 (because of 4 sundays defined in calendar as holidays).
Why truncating date here?

I mark this bug as Failed QA because fines.pl still don't work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:39:37 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 13:39:37 +0000
Subject: [Koha-bugs] [Bug 8282] New: Bug in modules list in about.pl
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8282

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8282
          Assignee: nengard at gmail.com
           Summary: Bug in modules list in about.pl
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: matthias.meusburger at biblibre.com
          Hardware: All
            Status: NEW
           Version: rel_3_8
         Component: About
           Product: Koha

Last modules were not displayed if the number of modules did not match the
number of rows of the table (when $number_of_modules % 4 != 0)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:42:52 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 13:42:52 +0000
Subject: [Koha-bugs] [Bug 8282] Bug in modules list in about.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8282

--- Comment #1 from Matthias Meusburger  ---
Created attachment 10408
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10408&action=edit
Bug 8282: Bug in modules list in about.pl

Last modules were not displayed if the number of modules did not match the
number of rows of the table (when $number_of_modules % 4 != 0)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:44:01 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 13:44:01 +0000
Subject: [Koha-bugs] [Bug 8282] Bug in modules list in about.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8282

Matthias Meusburger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|nengard at gmail.com           |matthias.meusburger at biblibr
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:45:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 13:45:24 +0000
Subject: [Koha-bugs] [Bug 8282] Bug in modules list in about.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8282

--- Comment #2 from Matthias Meusburger  ---
Please note that the last remaining cells of the table will have an empty
module name, with the "Not installed" label after it, but I find this much
better than having missing modules.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:50:58 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 13:50:58 +0000
Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280

--- Comment #6 from Martin Renvoize  ---
(In reply to comment #4)
> (In reply to comment #3)
> > Here is a quick writeup of what we figured out on IRC: 
> > http://wiki.koha-community.org/wiki/
> > Making_more_index_searchable_with_Zebra_SRU
> 
> Great. You also add it in pqf.properties. Mind the typo. I would not put in
> dublin core context either..

So, what exactly are the contexts and how do they work?

I just tried adding a "local" context by adding the line:

set.local   = info:srw/cql-context-set/1/cql-v1.1

or even

set.local   = info:srw/cql-context-set/1/cql-v1.2

These don't work as expected, but that's not surprising as it was a stab in the
dark.  Can you point to any documentation on contexts Marcel?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:52:03 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 13:52:03 +0000
Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280

--- Comment #7 from Martin Renvoize  ---
(In reply to comment #6)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > Here is a quick writeup of what we figured out on IRC: 
> > > http://wiki.koha-community.org/wiki/
> > > Making_more_index_searchable_with_Zebra_SRU
> > 
> > Great. You also add it in pqf.properties. Mind the typo. I would not put in
> > dublin core context either..
> 
> So, what exactly are the contexts and how do they work?
> 
> I just tried adding a "local" context by adding the line:
> 
> set.local   = info:srw/cql-context-set/1/cql-v1.1
> 
> or even
> 
> set.local   = info:srw/cql-context-set/1/cql-v1.2
> 
> These don't work as expected, but that's not surprising as it was a stab in
> the dark.  Can you point to any documentation on contexts Marcel?

Not sure Marcel came form there...  ?  M. de Roy was what I meant to say...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:52:10 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 13:52:10 +0000
Subject: [Koha-bugs] [Bug 8283] New: Replace usage of YUI Cookie utility
 with jQuery Cookie plugin
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8283
          Assignee: oleonard at myacpl.org
           Summary: Replace usage of YUI Cookie utility with jQuery Cookie
                    plugin
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: oleonard at myacpl.org
          Hardware: All
            Status: NEW
           Version: master
         Component: Templates
           Product: Koha

Since we're eliminating usage of YUI, we should convert JavaScript which uses
the YUI Cookie utility for reading and setting cookies. We already use a jQuery
Cookie plugin elsewhere in Koha (although it is independent of jQueryUI), so it
seems logical to unify cookie management under it.

The only affected script is js/pages/batchMod.js

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 15:53:37 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 13:53:37 +0000
Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

--- Comment #21 from Marc V?ron  ---

intranet-tmpl/prog/en/modules/help/admin/auth_subfields_structure.tt:18
To edit the subfields, click 'Edit Subfields.'
->... Edit Subfields'.

intranet-tmpl/prog/en/modules/help/acqui/basketheader.tt:9
When finished, click 'Save.'
->...'Save'.

intranet-tmpl/prog/en/modules/help/admin/aqbudgets.tt:26
li>Planning categories are used for statistical purposes. To learn more about
planning categories, check out the Planning Category FAQ.
->Error with 
    3. ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:03:03 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 14:03:03 +0000
Subject: [Koha-bugs] [Bug 8282] Bug in modules list in about.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8282

Matthias Meusburger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|rel_3_8                     |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:03:14 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 14:03:14 +0000
Subject: [Koha-bugs] [Bug 8279] CAS Debugging improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8279

Matthias Meusburger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|rel_3_8                     |master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:09:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 14:09:25 +0000
Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:11:45 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 14:11:45 +0000
Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10223|0                           |1
        is obsolete|                            |

--- Comment #15 from Jonathan Druart  ---
Created attachment 10409
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10409&action=edit
Bug 7955: Followup: Fix badly use of dbh->quote

Oups, could you test with this followup please ?

dbh->quote returns undef

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:11:52 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 14:11:52 +0000
Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:18:19 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 14:18:19 +0000
Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10409|0                           |1
        is obsolete|                            |

--- Comment #16 from Jonathan Druart  ---
Created attachment 10410
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10410&action=edit
Bug 7955: Followup: Fix badly use of dbh->quote

Ok, so... slowly :)
$dbh->quote returns the escaped string but with quote around.
We can't these quotes.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:41:03 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 14:41:03 +0000
Subject: [Koha-bugs] [Bug 8195] The selected link in include menus must be
	bold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8195

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:41:58 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 14:41:58 +0000
Subject: [Koha-bugs] [Bug 6132] System preferences are case sensitive
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6132

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|jonathan.druart at biblibre.co |julian.maurice at biblibre.com
                   |m                           |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:42:34 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 14:42:34 +0000
Subject: [Koha-bugs] [Bug 5180] Autocomplete broken on overdues report
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5180

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:42:35 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 14:42:35 +0000
Subject: [Koha-bugs] [Bug 5014] Layout problem in overdues report
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5014

Bug 5014 depends on bug 5180, which changed state.

Bug 5180 Summary: Autocomplete broken on overdues report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5180

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:48:17 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 14:48:17 +0000
Subject: [Koha-bugs] [Bug 8284] New: AcqCreateItem: Disable item creation
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8284

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8284
          Assignee: koha-bugs at lists.koha-community.org
           Summary: AcqCreateItem: Disable item creation
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: epietrocupo.hlhl at ssss.gouv.qc.ca
          Hardware: All
            Status: NEW
           Version: rel_3_6
         Component: Acquisitions
           Product: Koha

Can it be possible to add an option in AcqCreateItem so that no Item gets
created during the whole acquisition process.

Our problem is that we are ordering books for other department. Since we do not
keep track of the items for their department, it means that we would have to
destroy the item everytime we place an order.

And there are things that we orders that are disposable. For example we order
test many times which are disposed after use.

I think a solution easy to implement would be to add an option to remove
automatic item creation.

Then later, if you can make this option library location specific, it could be
even better. We made another library for all document orders which does not
belong to us. So if we could configure each library separately, our books will
create items, and other department books won't.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:49:28 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 14:49:28 +0000
Subject: [Koha-bugs] [Bug 8110] Fines accruing on closed days
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8110

--- Comment #29 from Julian Maurice  ---
In fact, truncation is not the problem. It's how DateTime::Duration is handled.
In C4::Overdues::_get_chargeable_units, only days part of duration is used.
months and years are ignored.
The problem is a DateTime::Duration object with months and years cannot be used
to calculate the total number of days because we don't know if years are leap
years, or if months contains 28 or 31 days.
I think the solution is to modify days_between so that it returns a number of
days instead of a DateTime::Duration object (same for hours_between I think: it
should return a number of hours)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:50:31 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 14:50:31 +0000
Subject: [Koha-bugs] [Bug 8284] AcqCreateItem: Disable item creation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8284

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
I think if you choose "in cataloging" no items will be created in acquisitions.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:51:37 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 14:51:37 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8536|0                           |1
        is obsolete|                            |

--- Comment #34 from Jonathan Druart  ---
Created attachment 10411
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10411&action=edit
Bug 4045 - No check for maximum number of allowed holds

Please signed off the right patch (this one !)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:51:49 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 14:51:49 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:53:52 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 14:53:52 +0000
Subject: [Koha-bugs] [Bug 8285] New: Show OPAC suppress field (942n) for new
	basket items
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8285

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8285
          Assignee: koha-bugs at lists.koha-community.org
           Summary: Show OPAC suppress field (942n) for new basket items
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: epietrocupo.hlhl at ssss.gouv.qc.ca
          Hardware: All
            Status: NEW
           Version: rel_3_6
         Component: Acquisitions
           Product: Koha

Would it be possible to show the OPAC suppress field when adding new catalog
entry for ordering documents.

The problem is that we order books, for other departments, and we do not want
these entries to apprear in the catalog. So if we could simply block their
display with a check box right at the entry creation, that would prevent having
to search and edit each new catalog entry.

You could enhance this by using a different configuration for each library.
Like if you orer for library A, OPAC suppress is disabled by default, but if
you order for library B, OPAC suppress is enabled by default.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 16:55:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 14:55:24 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045

--- Comment #35 from Jonathan Druart  ---
Created attachment 10412
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10412&action=edit
Bug 4045 - Followup: No check for maximum number of allowed holds.

Adds the systempreference in .pref file

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 17:21:38 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 15:21:38 +0000
Subject: [Koha-bugs] [Bug 7684] inventory :  datatable fix actions etc.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684

--- Comment #6 from Matthias Meusburger  ---
Created attachment 10413
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10413&action=edit
[FOLLOW-UP] Bug 7684: multiple fixes for inventory

- Adds not found barcodes list into csv report

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 17:52:00 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 15:52:00 +0000
Subject: [Koha-bugs] [Bug 8284] AcqCreateItem: Disable item creation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8284

Eric P626  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Eric P626  ---
True. My Error, Probably I made the test in an older version because I remember
seeing the item fields below the catalog entry fields. Now I made the test with
every method possible and it does not create the item.

Thanks for the info.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 17:55:37 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 15:55:37 +0000
Subject: [Koha-bugs] [Bug 6939] DefaultClassificationSource not used in 942$2
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6939

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10347|0                           |1
        is obsolete|                            |

--- Comment #2 from Nicole C. Engard  ---
Created attachment 10414
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10414&action=edit
[SIGNED-OFF] Bug 6939 DefaultClassificationSource should be default in 942

A logic bug in the original code adding DefaultClassificationSource
caused the default not to be used (the last used value was used instead)
The bug was fixed in additem by bug 2398 but addbiblio's use
of the code was not fixed.

Signed-off-by: Nicole C. Engard 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 17:55:57 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 15:55:57 +0000
Subject: [Koha-bugs] [Bug 6939] DefaultClassificationSource not used in 942$2
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6939

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 17:57:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 15:57:33 +0000
Subject: [Koha-bugs] [Bug 8281] Remove unused YUI files
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8281

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #1 from Owen Leonard  ---
The patch for this is too large to send to the patches list or to attach here.
I've pushed it to my public git repo (http://gitorious.org/koha-dev/koha-dev)
in a branch called ps-bug-8194-subscription-add-columns-2012-06-15

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 18:01:48 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 16:01:48 +0000
Subject: [Koha-bugs] [Bug 8286] New: Enhancing tax and shipping calculation
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8286

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8286
          Assignee: koha-bugs at lists.koha-community.org
           Summary: Enhancing tax and shipping calculation
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: epietrocupo.hlhl at ssss.gouv.qc.ca
          Hardware: All
            Status: NEW
           Version: rel_3_6
         Component: Acquisitions
           Product: Koha

Created attachment 10415
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10415&action=edit
Location where the tax and shipping field should be placed

The way koha currently manage tax caculation is wrong. You cannot use an global
tax rate because not all items are taxed the same way. When using multiple
taxes, sometimes taxes are applied differently according to the type of items.
Shipping fees cannot be predicted in advance because it changes from a suplier
to another.

My suggestion is to add tax and shipping fields into the shipment reception
page (see screenshot attached). The fields could be:

Tax 1
Tax 2
Shipping fee
Other Fee

The idea is that when you receive a new shipment, the first thing to do would
be to write down the taxes and the shipping fees.

Then you can check the items you have received, and the total amount for
shipping and taxes will simply be added at the end of the invoice.

This way you are sure that the final price will match the total on the invoice.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 18:10:02 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 16:10:02 +0000
Subject: [Koha-bugs] [Bug 8281] Remove unused YUI files
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8281

--- Comment #2 from Owen Leonard  ---
Sorry, obviously that's the wrong branch name. Here's the right one:

ps-bug-8281-remove-yui-files-2012-06-21

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 18:15:56 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 16:15:56 +0000
Subject: [Koha-bugs] [Bug 8253] Fine doubling
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253

--- Comment #3 from Kyle M Hall  ---
Created attachment 10416
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10416&action=edit
Bug 8253 - Fine doubling - Remove Previous Duplicates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 18:40:17 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 16:40:17 +0000
Subject: [Koha-bugs] [Bug 6566] Checking if DB records are properly indexed
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566

Christophe Croullebois  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #5 from Christophe Croullebois  ---
Hi,
thx for your comments.
1) copyright added Robin Sheat
2) tryed to rewrite the help text
3) right M. de Rooy ;oD very silent, maybe too, now whe have it
4) due to Jonathan Druart's comment I have added a stealth option to optimise
what you print
5) no need to "-t" Jonathan ;o) just do not use -z, some dross... fixed
6) -s was only for avoiding the warn every 1000 biblios so I have added
stealth, you have the choice, so your suggest Jonathan was bad placed and I
think we must avoid "or" in this case, also you inverted "..not $silent" ;o)
so I hope it's ok.
thx for testing

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 18:42:48 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 16:42:48 +0000
Subject: [Koha-bugs] [Bug 6566] Checking if DB records are properly indexed
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566

--- Comment #6 from Christophe Croullebois  ---
Created attachment 10417
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10417&action=edit
the last patch I hope

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 19:57:46 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 17:57:46 +0000
Subject: [Koha-bugs] [Bug 8287] New: remove filter on checked out from
	overdues
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8287

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8287
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
          Assignee: koha-bugs at lists.koha-community.org
           Summary: remove filter on checked out from overdues
          Severity: minor
    Classification: Unclassified
                OS: All
          Reporter: nengard at gmail.com
               URL: /cgi-bin/koha/circ/overdue.pl
          Hardware: All
            Status: NEW
           Version: master
         Component: Circulation
           Product: Koha

On the Overdues report there is a filter for "Show any items currently checked
out:" ... but everything that is overdue should be checked out - so what does
this do? If it does nothing then it should be removed. If it does something
please tell me and I'll update the manual and we can close this.


Chat:

[13:45]   question about overdue report
[13:45]   can anyone tell me on this page:
/cgi-bin/koha/circ/overdue.pl what does "Show any items currently checked out:"
do?
[13:45]   it's one of the filters on the left
[13:47]   not sure actually :(
[13:47]   shouldn't they all be checked out?
[13:47]   right
[13:47]   hence my confusion
[13:52]   no idea
[13:54]   HA
[13:54]   anyone else? should we remove it if it doesn't do anything?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 20:19:38 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 18:19:38 +0000
Subject: [Koha-bugs] [Bug 8287] remove filter on checked out from overdues
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8287

--- Comment #1 from Owen Leonard  ---
Here's the SQL for what is run without the box checked:

SELECT date_due, borrowers.title as borrowertitle, borrowers.surname,
borrowers.firstname, borrowers.streetnumber, borrowers.streettype,
borrowers.address, borrowers.address2, borrowers.city, borrowers.zipcode,
borrowers.country, borrowers.phone, borrowers.email, issues.itemnumber,
issues.issuedate, items.barcode, biblio.title, biblio.author,
borrowers.borrowernumber, biblio.biblionumber, borrowers.branchcode,
items.itemcallnumber, items.replacementprice, items.enumchron FROM issues LEFT
JOIN borrowers ON (issues.borrowernumber=borrowers.borrowernumber ) LEFT JOIN
items ON (issues.itemnumber=items.itemnumber) LEFT JOIN biblioitems ON
(biblioitems.biblioitemnumber=items.biblioitemnumber) LEFT JOIN biblio ON
(biblio.biblionumber=items.biblionumber ) WHERE 1=1 AND date_due < '2012-06-21
14:16' ORDER BY date_due, surname, firstname 

Here's the SQL with the box checked:

SELECT date_due, borrowers.title as borrowertitle, borrowers.surname,
borrowers.firstname, borrowers.streetnumber, borrowers.streettype,
borrowers.address, borrowers.address2, borrowers.city, borrowers.zipcode,
borrowers.country, borrowers.phone, borrowers.email, issues.itemnumber,
issues.issuedate, items.barcode, biblio.title, biblio.author,
borrowers.borrowernumber, biblio.biblionumber, borrowers.branchcode,
items.itemcallnumber, items.replacementprice, items.enumchron FROM issues LEFT
JOIN borrowers ON (issues.borrowernumber=borrowers.borrowernumber ) LEFT JOIN
items ON (issues.itemnumber=items.itemnumber) LEFT JOIN biblioitems ON
(biblioitems.biblioitemnumber=items.biblioitemnumber) LEFT JOIN biblio ON
(biblio.biblionumber=items.biblionumber ) WHERE 1=1 ORDER BY date_due, surname,
firstname

Checking the box removes the limit on date_due.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 20:26:21 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 18:26:21 +0000
Subject: [Koha-bugs] [Bug 8191] New value for 8 position in coded data field
 100 in unimarc
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8191

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |koha.sekjal at gmail.com

--- Comment #4 from Ian Walls  ---
Template only change to add new option for 100$k subfield in UNIMARC.  Marking
Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 20:28:27 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 18:28:27 +0000
Subject: [Koha-bugs] [Bug 8241] Remove stray references to YUI autocomplete
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8241

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |koha.sekjal at gmail.com

--- Comment #4 from Ian Walls  ---
Template only changes updating markup to be more specific with IDs, clean up
unnecessary text and otherwise do HTML goodness.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 20:43:26 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 18:43:26 +0000
Subject: [Koha-bugs] [Bug 5979] OPAC : using OPACISBD systempreference to
	display link
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5979

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |koha.sekjal at gmail.com

--- Comment #9 from Ian Walls  ---
OPACISBD exists in ru-RU and uk-UA language sysprefs only... very odd.  In that
context, it's a text area, rather than a boolean.  It looks like this
perference was added back around 3.00.05.001, but is not longer part of the
default installation.

The first patch is fine; it changes the logic to use OPACISBD in the opac.  But
getting that preference properly installed where it may not already be is
something else.  If OPACISBD syspref is not present in newer installs, we
should create one that is congruent with the original intent.  A YesNo type is
not appropriate in this context

Failed QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 20:47:01 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 18:47:01 +0000
Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at
	checkin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251

--- Comment #6 from Tom?s Cohen Arazi  ---
Created attachment 10418
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10418&action=edit
Bug 8251 - Follow up, use 'day' instead of 'day' for Datetime::truncate

As noted in comment #4 by Jonathan Druart, this should be fixed in every call
to DateTie::truncate function. This patch does exactly that.

julian_m tested that truncate( to => 'days' ) didn't actually do anything, so
it is understandable that this 'fix' might introduce new bugs as we might have
'fixed' at a higher libs level this issue.

'minutes' is used in truncate function too, so fixing.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 20:57:43 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 18:57:43 +0000
Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr
 without breaking anything else
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha.sekjal at gmail.com

--- Comment #10 from Ian Walls  ---
Display of Solr configuration page in Admin is unconditional; will show if
Zebra is the search engine... not sure if that's a bad thing or not.

opac/opac-search.pl makes use of "highly experimental" Perl syntax: given and
when.  http://perldoc.perl.org/perlsyn.html#Switch-Statements.  While this
should be compatible with Koha's minimum Perl version (5.10), it's still listed
as experimental in 5.16, which makes me nervous.  I'm all for switch
statements, but they're not as fundamental in Perl as they are in other
languages, and for an either/or situation like this, doing it another way would
be safer.

Reintroduces Test::MockModule

Given the above, I'm not ready to pass this through QA, but I'm not entirely
convinced it should fail, either.  Replacing "given" with "for", and adding a
'default' case should clear up the issue.

Otherwise, all the code is new and in it's own area, making it delightfully
low-impact on folks who aren't ready to experiment with Solr support.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 21:25:17 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 19:25:17 +0000
Subject: [Koha-bugs] [Bug 8288] New: showmarc.tt should not include full
 doc-head-close.inc
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8288
          Assignee: oleonard at myacpl.org
           Summary: showmarc.tt should not include full doc-head-close.inc
          Severity: minor
    Classification: Unclassified
                OS: All
          Reporter: oleonard at myacpl.org
          Hardware: All
            Status: NEW
           Version: master
         Component: Templates
           Product: Koha

showmarc.tt is only called by modal dialogs for previewing MARC records or card
views in acquisitions and cataloging. Since it is a minimal page loaded within
a page it doesn't need to load all the CSS and JS a full page does.

It also creates the possibility of unintended consequences if you have
intranetuserjs triggering something on document load: the event will be
triggered again when the dialog loads.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 21:32:21 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 19:32:21 +0000
Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #14 from Ian Walls  ---
Further rebasing has been required...

This all looks very good, except I'm not terribly thrilled about the hardcoded
MAX_FILE_SIZE value in the upload.  It seems to me that that value should be
controllable by the sysadmin, rather than locked in at 2000000.

I think a followup fix would be appropriate here, rather than a complete
resubmission.   Rebased version is Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 21:32:29 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 19:32:29 +0000
Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130

--- Comment #15 from Ian Walls  ---
Created attachment 10419
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10419&action=edit
[PASSED QA] Bug 8130 - attach PDF files to a patron record

Adds the ability to attach unlimited arbitrary files to
a borrower record.

Test Plan:
1) Enable system preference EnableBorrowerFiles
2) Look up borrower record, click 'Files' tab on left
3) Upload a file, download the file, delete the file.

Signed-off-by: Liz Rea 
rebased for current master.

Signed-off-by: Ian Walls 
rebased again; some indentation issues in include menus.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 21 21:32:49 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 21 Jun 2012 19:32:49 +0000
Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10312|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 03:56:18 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 01:56:18 +0000
Subject: [Koha-bugs] [Bug 7943] Untranslatable strings in OPAC's authority
	search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7943

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #9 from Chris Cormack  ---
Patch does not apply for 3.8.x 

Here are the offending files

#    both modified:      authorities/ysearch.pl
#    both modified:      koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
#    both modified:      koha-tmpl/opac-tmpl/prog/en/css/opac.css

Please fix and resubmit for inclusion into 3.8.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 04:07:18 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 02:07:18 +0000
Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #13 from Chris Cormack  ---
Jared, is 
http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=authorities/detail.pl;h=a7d7d8f21882b7bcace75c5eb862eaebad8dfdeb;hp=d4f2c6730c76f19fb0aeefebdfd7fe5558066eff;hb=f809e47fd1644314bbd63542f3021382eece642f;hpb=f2ca89b30e8d48b987782ff3f9f7c8e8240b87a4

Safe to cherry-pick now, or best to wait until the second patch is pushed to
master also?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 04:10:15 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 02:10:15 +0000
Subject: [Koha-bugs] [Bug 7367] General OPAC typo omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7367

--- Comment #16 from Chris Cormack  ---
Pushed to 3.8.x will be in 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 04:13:30 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 02:13:30 +0000
Subject: [Koha-bugs] [Bug 8232] Comments in OPAC contain untranslatable
 javascript messages
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8232

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #6 from Chris Cormack  ---
Pushed to 3.8.x will be in 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 04:15:00 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 02:15:00 +0000
Subject: [Koha-bugs] [Bug 8229] Tabs in marc subfield structure is not shown
	correctly
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8229

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #5 from Chris Cormack  ---
Pushed to 3.8.x will be in 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 04:18:36 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 02:18:36 +0000
Subject: [Koha-bugs] [Bug 8223] Properly format SQL query in
 C4::Bookseller::GetBookSeller
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8223

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #4 from Chris Cormack  ---
Pushed to 3.8.x will be in 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 04:18:50 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 02:18:50 +0000
Subject: [Koha-bugs] [Bug 8223] Properly format SQL query in
 C4::Bookseller::GetBookSeller
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8223

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|rel_3_10                    |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 04:19:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 02:19:12 +0000
Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

--- Comment #14 from Jared Camins-Esakov  ---
(In reply to comment #13)
> Jared, is 
> http://git.koha-community.org/gitweb/?p=koha.git;a=blobdiff;f=authorities/
> detail.pl;h=a7d7d8f21882b7bcace75c5eb862eaebad8dfdeb;
> hp=d4f2c6730c76f19fb0aeefebdfd7fe5558066eff;
> hb=f809e47fd1644314bbd63542f3021382eece642f;
> hpb=f2ca89b30e8d48b987782ff3f9f7c8e8240b87a4
> 
> Safe to cherry-pick now, or best to wait until the second patch is pushed to
> master also?

You can cherry-pick that patch, and cherry-pick the next once it's been pushed
to master.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 04:22:58 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 02:22:58 +0000
Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

--- Comment #15 from Chris Cormack  ---
Done, thanks for the quick reply

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 04:52:16 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 02:52:16 +0000
Subject: [Koha-bugs] [Bug 7943] Untranslatable strings in OPAC's authority
	search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7943

--- Comment #10 from Jared Camins-Esakov  ---
Created attachment 10420
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10420&action=edit
[3.8.x] Bug 7943: Authority search results are untranslatable

The HTML for authority search results was previously generated in
C4::AuthoritiesMarc::BuildSummary, which meant that it couldn't be
translated. This patch moves the HTML generation into the templates
by introducing a new authorities-search-results.inc include file for
both the OPAC and the Intranet which contains a Template::Toolkit BLOCK
for rendering the authority results. Fixes the authority autocomplete
by removing the untranslatable strings, and returning only data from
the database.

To test:
1. Apply patch.
2. Test authority searching in the authority module in the staff client
3. Test authority searching in the authority control plugin in the
   cataloguing module (and the plugin for UNIMARC field 210$c, if you
   can figure out how)
4. Test authority searching in the OPAC

Signed-off-by: Katrin Fischer 
Tested with MARC21 data.

1) Applies cleanly on current HEAD.

2) Authority search in staff

Patch works wonderfully, only some small notes found while testing that have
not been changed by this patch:

ENH note: Search terms show up nowhere. So if I want to change the sorting, I
have to
repeat typing in my search term. Even if the form does not keep the term, it
should be visible somewhere on the screen what I searched for.

ENH note: The pagination on top and at the bottom of the result list are
formatted
differently. Maybe some missing CSS?

ENH note: Also the authority type is not shown at all in the result list.

3) Cataloguing and authority plugins

The autocomplete function works nicely.

ENH note: There is only one small enhancement
I could imagine. If I start my search from 100 it will limit the search to
'persons' but the autocomplete will also suggest other authorities. It would
be a bit cleaner, if the autocomplete could limit by the appropriate authority
type too. Very nice feature.

Plugins overall work nicely. Created links include the authority numbers and
work
correctly.

4) Authority search in OPAC

Works nicely. Display is consistent, but translatability greatly improved.

ENH note: In staff we use 'Details' in OPAC we use 'View full heading' - I
wonder
if maybe 'details' would be better understandable for users?

Note: Code reveals a system preference 'AuthDisplayHierarchy' that is
not available in the system preference editor. I talked to Jared and he
will work on this feature later on. For now it's no regression, as the
preference has never been visible.

Signed-off-by: Jared Camins-Esakov 
Rebased for 3.8.x on 21 June 2012.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 05:00:31 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 03:00:31 +0000
Subject: [Koha-bugs] [Bug 7943] Untranslatable strings in OPAC's authority
	search
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7943

--- Comment #11 from Jared Camins-Esakov  ---
Created attachment 10421
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10421&action=edit
[3.8.x] Bug 7943 follow-up: Fix template filename

In preparation for some later work on authorities, the filename for the
OPAC authority viewer changed.

Signed-off-by: Katrin Fischer 
Signed-off-by: Paul Poulain 
Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 05:04:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 03:04:33 +0000
Subject: [Koha-bugs] [Bug 3462] Link see alsos in authorities
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462

--- Comment #1 from Jared Camins-Esakov  ---
Created attachment 10422
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10422&action=edit
Bug 3462: Links in authorities should be hyperlinks

Make see also links in both the OPAC and authority module search results
into hyperlinks and not just textual strings.

To test:
1. Do a search for an authority that will bring up a heading with a
   see also reference in the staff client and the OPAC.
2. Confirm that the see also references listed in the search results
   are now hyperlinks, which work.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 05:05:37 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 03:05:37 +0000
Subject: [Koha-bugs] [Bug 3462] Link see alsos in authorities
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3462

Jared Camins-Esakov  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 05:53:47 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 03:53:47 +0000
Subject: [Koha-bugs] [Bug 7475] Option to overlay authorities
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7475

--- Comment #5 from Jared Camins-Esakov  ---
Created attachment 10423
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10423&action=edit
Bug 7475: Enable authority overlay

This patch does the following:
* Completes authority support within Koha's import batch code
* Completes authority support in Koha's matching rule code
* Exposes the ability to stage and commit batches of authorities using
  the renamed scripts misc/stage_file.pl and misc/commit_file.pl

To test (note that these instructions assume you have a MARC21
installation and are using the provided sample file):
1. Find a file of authorities (a sample file with MARC21 authorities
   is attached to bug 7475) and download it to your server
2. Stage the file using the following command (replace  with
   the name of the file you saved in step 1):
   > misc/stage_file.pl --file  --authorities
3. Note the batch number the script assigns to your batch
4. Commit the records using the following command (replace 
   with the batch number you made note of in step 3):
   > misc/commit_file.pl --batch-number 
5. Index the authorities Zebraqueue (or wait)
6. Confirm that the new authorities appear.
7. Create a matching rule with the following settings:
   Code: AUTHTEST
   Description: Personal name main entry
   Match threshold: 999
   Record type: Authority record
   Search index: Heading-main
   Score: 1000
   Tag: 100
   Subfields: a
   Offset: 0
   Length: 0
   (note the ID of this matching rule)
8. Stage the authority file again, this time using the following
   command:
   > misc/stage_file.pl --file  --authorities \
     --match 
7. Revert the import with the following command:
   > misc/commit_file.pl --batch-number  --revert
8. Index the authorities Zebraqueue (or wait)
9. Confirm that the records have been removed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 05:54:29 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 03:54:29 +0000
Subject: [Koha-bugs] [Bug 7475] Option to overlay authorities
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7475

Jared Camins-Esakov  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #6 from Jared Camins-Esakov  ---
The commit message and functionality in this version of the patch should
actually line up.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 07:55:17 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 05:55:17 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |mtj at kohaaloha.com

--- Comment #40 from Mason James  ---
(In reply to comment #39)
> Created attachment 10402 [details]
> [SIGNED-OFF] 7143 Followup for timeline
> 
> Fixes few tabs within date; adds a regex to fix mistakes with spaces.
> 
> Signed-off-by: Marc Veron 

QA COMMENT
trivial patch. tested fine

passed QA :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 08:00:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 06:00:25 +0000
Subject: [Koha-bugs] [Bug 6777] Display link to related acquisitions details
 from catalogue record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6777

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtj at kohaaloha.com

--- Comment #6 from Mason James  ---
(In reply to comment #0)
> Display a link to the related Acquistions record from the catagloue detail
> page (staff interface), so users can refer to acq details such as vendor,
> price etc.

a screenshot for this, please?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 08:31:07 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 06:31:07 +0000
Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280

--- Comment #8 from M. de Rooy  ---
(In reply to comment #7)
> Not sure Marcel came form there...  ?  M. de Roy was what I meant to say...
M=Marcel; Roy->Rooy

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 08:38:13 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 06:38:13 +0000
Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280

--- Comment #9 from M. de Rooy  ---
(In reply to comment #6)
> So, what exactly are the contexts and how do they work?
> 
> I just tried adding a "local" context by adding the line:
> 
> set.local   = info:srw/cql-context-set/1/cql-v1.1
> 
> or even
> 
> set.local   = info:srw/cql-context-set/1/cql-v1.2
> 
> These don't work as expected, but that's not surprising as it was a stab in
> the dark.  Can you point to any documentation on contexts Marcel?

Please see: http://www.indexdata.com/yaz/doc/tools.html
Personally, I would not define a context set named local. (But maybe that's
just being too cautious about colliding with reserved words etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 09:40:37 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 07:40:37 +0000
Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at
	checkin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |ASSIGNED

--- Comment #7 from Julian Maurice  ---
Changing status to needs signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 09:40:44 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 07:40:44 +0000
Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at
	checkin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 09:55:54 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 07:55:54 +0000
Subject: [Koha-bugs] [Bug 7993] saved report with hierarchies
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7993

delaye  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 10:14:00 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 08:14:00 +0000
Subject: [Koha-bugs] [Bug 8216] Enable critic tests on SIP modules
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8216

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #4 from Chris Cormack  ---
Enabling more tests = win, pushed to 3.8.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 10:24:41 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 08:24:41 +0000
Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion
	librairy
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919

delaye  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 10:25:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 08:25:12 +0000
Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion
	librairy
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919

--- Comment #11 from Paul Poulain  ---
Patch tested with a sandbox, by Delaye Stephane 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 10:25:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 08:25:25 +0000
Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion
	librairy
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9984|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 10:25:32 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 08:25:32 +0000
Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion
	librairy
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919

--- Comment #12 from Paul Poulain  ---
Created attachment 10424
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10424&action=edit
Bug 8272 - OPAC : date expiration format

Adding TT date filter to output of expiration date
on OPAC user page.

Signed-off-by: Chris Cormack 
Signed-off-by: Delaye Stephane 
Signed-off-by: Paul Poulain 
Signed-off-by: Delaye Stephane 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 10:58:56 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 08:58:56 +0000
Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr
 without breaking anything else
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233

--- Comment #11 from Jonathan Druart  ---
Hi Ian, 
Thanks for your review.

About Switch vs given statements, Switch is buggy and deprecated : "Switch is
buggy and should be avoided. You may find Perl's new given /when feature a
suitable replacement."

http://perldoc.perl.org/perl5120delta.html#Deprecations

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 11:00:02 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 09:00:02 +0000
Subject: [Koha-bugs] [Bug 7684] inventory :  datatable fix actions etc.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7684

--- Comment #7 from delaye  ---
the last patch have broken the previous fix actions
the field "Show" must be hidden becasue it's dont work , instead put a paging
under the report

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 11:00:13 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 09:00:13 +0000
Subject: [Koha-bugs] [Bug 7673] New patron permissions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7673

delaye  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 11:08:51 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 09:08:51 +0000
Subject: [Koha-bugs] [Bug 8289] New: Upgrading from 2.2 does not work anymore
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8289

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8289
          Assignee: paul.poulain at biblibre.com
           Summary: Upgrading from 2.2 does not work anymore
          Severity: critical
    Classification: Unclassified
                OS: All
          Reporter: paul.poulain at biblibre.com
          Hardware: All
            Status: ASSIGNED
           Version: master
         Component: Installation and upgrade (command-line installer)
           Product: Koha

The updatedatabase22to30.pl script update the engine from MyISAM to InnoDB for
most tables.

However, the TYPE=InnoDB was deprecated, and is not removed.
The correct syntax is now ENGINE=InnoDB

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 11:10:39 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 09:10:39 +0000
Subject: [Koha-bugs] [Bug 8289] Upgrading from 2.2 does not work anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8289

--- Comment #1 from Paul Poulain  ---
Created attachment 10425
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10425&action=edit
Bug 8289 Upgrading from 2.2 does not work anymore

The updatedatabase22to30.pl script update the engine from MyISAM to InnoDB for
most tables.

However, the TYPE=InnoDB was deprecated, and is not removed.
The correct syntax is now ENGINE=InnoDB

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 11:10:52 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 09:10:52 +0000
Subject: [Koha-bugs] [Bug 8289] Upgrading from 2.2 does not work anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8289

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 11:11:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 09:11:04 +0000
Subject: [Koha-bugs] [Bug 7298] export late orders,
	with # of claims and claim dates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7809|0                           |1
        is obsolete|                            |
   Attachment #7946|0                           |1
        is obsolete|                            |

--- Comment #15 from Jonathan Druart  ---
Created attachment 10426
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10426&action=edit
Bug 7298 Export late orders as csv

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 11:12:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 09:12:24 +0000
Subject: [Koha-bugs] [Bug 7298] export late orders,
	with # of claims and claim dates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7298

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:00:55 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 10:00:55 +0000
Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #5 from Jonathan Druart  ---
QA comments:

Hi Jared,

Your modifications seem good and they are close to mine (for export.pl).
About your patch, I think you can repropose it modifying the indentation of
export.tt (ex. 
+        
      1. 

+        
      

+[% ELSE %]

+
      
+
        
)

I agree with you, I quibble...

However, more important, I found a bug in this script while testing.
I can't exclude from export some fields, as 500$3 for example. The regexp to
split field and subfield is /^(\d*)(\w)?$/;
This is not what we want.

And, the subfield's deletion:
if( $subfield ) {
     $record->field($field)->delete_subfields($subfield);
}
only delete in the first field.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:05:27 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 10:05:27 +0000
Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Signed Off

--- Comment #6 from Jonathan Druart  ---
Sorry, you didn't introduce these bugs.

And I can't failed QA only for indentation, I switch back to signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:11:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 10:11:04 +0000
Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn
 jsPrintSetup and new staff client preference
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10104|0                           |1
        is obsolete|                            |

--- Comment #19 from Marc V?ron  ---
Created attachment 10427
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10427&action=edit
[REBASED] Bug 8272 - OPAC : date expiration format

Adding TT date filter to output of expiration date
on OPAC user page.

Signed-off-by: Chris Cormack 
Signed-off-by: Delaye Stephane 
Signed-off-by: Paul Poulain 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:20:43 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 10:20:43 +0000
Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn
 jsPrintSetup and new staff client preference
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10427|1                           |0
           is patch|                            |
  Attachment #10427|0                           |1
        is obsolete|                            |

--- Comment #20 from Marc V?ron  ---
Comment on attachment 10427
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10427
[REBASED] Bug 8272 - OPAC : date expiration format

Something went wrong with teh attachment...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:21:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 10:21:33 +0000
Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn
 jsPrintSetup and new staff client preference
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10104|1                           |0
        is obsolete|                            |

--- Comment #21 from Marc V?ron  ---
Comment on attachment 10104
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10104
Bug 7563 [ENH] - Silent print slips using Firefox PlugIn jsPrintSetup and new
staff client preference

REstoring previous attachment...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 12:37:11 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 10:37:11 +0000
Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn
 jsPrintSetup and new staff client preference
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10104|0                           |1
        is obsolete|                            |

--- Comment #22 from Marc V?ron  ---
Created attachment 10428
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10428&action=edit
[REBASED] Bug 7563 [ENH] - Silent print slips using Firefox PlugIn jsPrintSetup
and new staff client preference

Configure slip printers to print slips (silently) to a special printer using
the Firefox PlugIn jsPrintSetUp.
All other print actions are not affected. See http://jsprintsetup.mozdev.org/
for all the possibilities
(e.g. change header/footer, get a list of printers, set printer etc.).

The overall concept is to have a new staff client preference
(IntranetSlipPrinterJS) where one can enter the necessary JavaScript.

If the preference is empty, Koha falls back to te default behaviour. An example
of JavaScript can be found on:
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563

Signed-off-by: Chris Cormack 

http://bugs.koha-community.org/show_bug.cgi?id=7653

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 13:27:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 11:27:24 +0000
Subject: [Koha-bugs] [Bug 8202] Add authorities to export tool
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8202

--- Comment #7 from Jared Camins-Esakov  ---
(In reply to comment #5)
> QA comments:
> 
> Hi Jared,
> 
> Your modifications seem good and they are close to mine (for export.pl).
> About your patch, I think you can repropose it modifying the indentation of
> export.tt (ex. 
> +        
        1. 
> 
> +        
        
> 
> +[% ELSE %]
> 
> +
        
> +
          
> )
> 
> I agree with you, I quibble...

I would be happy to submit a follow-up fixing indentation. I was very tempted
to reindent export.tt, actually, but section 1.3 in the coding guidelines says
don't refactor needlessly, and don't spend time changing someone else's style
to yours. :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 13:35:56 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 11:35:56 +0000
Subject: [Koha-bugs] [Bug 7986] Export issues
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7986

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 13:50:16 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 11:50:16 +0000
Subject: [Koha-bugs] [Bug 8290] New: Replace Greybox library with jQueryUI
	Dialog
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8290
          Assignee: oleonard at myacpl.org
           Summary: Replace Greybox library with jQueryUI Dialog
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: oleonard at myacpl.org
          Hardware: All
            Status: NEW
           Version: master
         Component: Templates
           Product: Koha

jQueryUI includes a Dialog widget which can replace the Greybox library. Doing
so will make the UI of dialogs in Koha consistent with other jQueryUI
components and offer a tool which can be expanded into a wider array of usages.

http://jqueryui.com/demos/dialog/

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 13:54:44 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 11:54:44 +0000
Subject: [Koha-bugs] [Bug 8291] New: patron import should show error names
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8291

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8291
          Assignee: gmcharlt at gmail.com
           Summary: patron import should show error names
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: nengard at gmail.com
          Hardware: All
            Status: NEW
           Version: master
         Component: Tools
           Product: Koha

We just imported a batch of new patrons, choosing to match on barcode and
ignore any where the barcode was already in use.

This is the result:
24 imported records (last was Brackett / 2361)
0 overwritten
6 not imported because already in borrowers table and overwrite disabled (last
was Zoe / 2330)
0 not imported because they are not in the expected format
30 records parsed


This would be a lot more helpful if it showed you the 6 that were not imported
so you know exactly which ones were errors.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 14:08:52 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 12:08:52 +0000
Subject: [Koha-bugs] [Bug 8253] Fine doubling
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10416|0                           |1
        is obsolete|                            |

--- Comment #4 from Kyle M Hall  ---
Created attachment 10429
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10429&action=edit
Bug 8253 - Fine doubling - Remove Previous Duplicates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 14:16:08 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 12:16:08 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045

--- Comment #36 from Marc V?ron  ---
Created attachment 10430
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10430&action=edit
System preference maxreserves appears twice

With the second patch, the system preference maxreserve appears twice.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 14:19:51 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 12:19:51 +0000
Subject: [Koha-bugs] [Bug 6976] User hold limit can be avoided by users in
	OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6976

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 14:21:32 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 12:21:32 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 14:28:05 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 12:28:05 +0000
Subject: [Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an
 item between branches
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10241|0                           |1
        is obsolete|                            |

--- Comment #30 from Kyle M Hall  ---
Created attachment 10431
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10431&action=edit
[SIGNED-OFF] Bug 5911: Followup - make perlcdritic happy, shut up warnings

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 14:28:22 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 12:28:22 +0000
Subject: [Koha-bugs] [Bug 5911] Transport Cost Matrix of transporting an
 item between branches
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5911

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:33:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 13:33:12 +0000
Subject: [Koha-bugs] [Bug 8292] New: clicking ignore on hold cancels transfer
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8292
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
          Assignee: koha-bugs at lists.koha-community.org
           Summary: clicking ignore on hold cancels transfer
          Severity: major
    Classification: Unclassified
                OS: All
          Reporter: nengard at gmail.com
          Hardware: All
            Status: NEW
           Version: master
         Component: Circulation
           Product: Koha

If a title has some holds on it and I check it in at the borrowing library, I
got a message telling me about a hold.  I clicked "Ignore" on that message. 
The barcode was not transferred back to the owning library at this point even
though it should have been.  The barcode still shows as having a Current
Location.

Notes from Ian on the code inspection:

The portion of code that triggers the automatic return home is not called if a
hold is found; this makes sense in the case where you're filling the hold,
since you'd be transferring to that library instead of the home library.

But when you 'ignore', nothing additional happens.  The ignore button just
makes the confirmation box disappear; not further actions are taken.  So the
code to do the transfer is never performed, and the item sits at the
holdingbranch library.

Obviously this is not what people expect.  If you're ignoring the hold, you
want the checkin to proceed as if the hold had never popped up in the first
place, and that means doing a return home if appropriate.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:35:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 13:35:12 +0000
Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr
 without breaking anything else
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233

--- Comment #12 from Ian Walls  ---
Right, I wasn't advocating for Switch itself, so much as supporting the
syntactic structure of switch that can be found in many programming languages. 
Looks like Perl does this most stably (right now) with this structure:

for ($var) {
  when (/^abc/) { $abc = 1 }
  when (/^def/) { $def = 1 }
  when (/^xyz/) { $xyz = 1 }
  default { $nothing = 1 }
}

and, "highly experimentally", with

given ($var) {
  when (/^abc/) { $abc = 1 }
  when (/^def/) { $def = 1 }
  when (/^xyz/) { $xyz = 1 }
  default { $nothing = 1 }
}

While I'm sure using given would in most cases be safe, it could very well
introduce a difficult-to-trace problem for a non-typical install (where a
different Perl version could have snuck in).  I'm probably being overly
paranoid, but that's what a QAM is for!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:39:10 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 13:39:10 +0000
Subject: [Koha-bugs] [Bug 8293] New: Software error when clicking on first
 or last result of each page on OPAC
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8293

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8293
          Assignee: oleonard at myacpl.org
           Summary: Software error when clicking on first or last result
                    of each page on OPAC
          Severity: critical
    Classification: Unclassified
                OS: All
          Reporter: koha at univ-lyon3.fr
          Hardware: All
            Status: NEW
           Version: rel_3_8
         Component: OPAC
           Product: Koha

When you click on the last result of first page or first/last result of
following pages of results you get this :

Unsupported UNIMARC character encoding [] for XML output for UNIMARC; 100$a -> 
at /usr/share/perl5/MARC/File/XML.pm line 505.


This happens because of the following patch  :
"bug_6488 followup - fixes issue with bibs with no items and serials being
suppressed".

+    if ($items_count > 0) {
         next if $is_opac       && $hideatopac_count >= $items_count;
         next if $hidelostitems && $itemlost_count   >= $items_count;
-
+    }

When commented the 2 conditions lines that have been added, the records display
correctly again.
Strangely, this patch seems not to have been validated (cf comments thread in
Bug 6488). But may be, I missed something...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:39:38 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 13:39:38 +0000
Subject: [Koha-bugs] [Bug 8293] Software error when clicking on first or
 last result of each page on OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8293

Koha Team Lyon 3  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P1 - high

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:52:39 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 13:52:39 +0000
Subject: [Koha-bugs] [Bug 8294] New: enumeration should show in copy
	specific hold menu
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8294

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8294
                CC: gmcharlt at gmail.com
          Assignee: koha-bugs at lists.koha-community.org
           Summary: enumeration should show in copy specific hold menu
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: nengard at gmail.com
          Hardware: All
            Status: NEW
           Version: master
         Component: Hold requests
           Product: Koha

Created attachment 10432
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10432&action=edit
serial without enumeration - all issues look the same

When placing a hold on a specific copy we need to show the enumeration or else
when it's a serial you're placing a hold on you can't tell which issue you want
to place the hold on ...

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:52:49 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 13:52:49 +0000
Subject: [Koha-bugs] [Bug 8294] enumeration should show in copy specific
	hold menu
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8294

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=2523

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 15:52:49 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 13:52:49 +0000
Subject: [Koha-bugs] [Bug 2523] holds queue report needs additional fields
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2523

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=8294

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:06:06 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 14:06:06 +0000
Subject: [Koha-bugs] [Bug 8295] New: patron duplicate message not checking
 required fields
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8295

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8295
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
          Assignee: koha-bugs at lists.koha-community.org
           Summary: patron duplicate message not checking required fields
          Severity: major
    Classification: Unclassified
                OS: All
          Reporter: nengard at gmail.com
          Hardware: All
            Status: NEW
           Version: master
         Component: Patrons
           Product: Koha

I have firstname and surname as required fields when creating patron records. I
also have 22 patron records where one or both of those fields are empty.

If I create a new record and leave the firstname and surname fields empty I get
a message that this could be a duplicate and either I can edit the duplicate or
save the new record. If I click save it saves it without first or surname. If I
click edit the duplicate it brings up a record which appears to be the first
one in the database with neither a first nor surname.

Shouldn't the first check on saving a new record be a look at the two required
fields and an error message if they are empty? Instead, it's just matching on a
record where these are empty and allowing the record to be created.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:15:42 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 14:15:42 +0000
Subject: [Koha-bugs] [Bug 5357] Subscription search and displays
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357

--- Comment #1 from Jonathan Druart  ---
Created attachment 10433
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10433&action=edit
Bug 5357: Adds a new page for searching subscriptions

Test plan:
- go on the serial module
- click on the 'Advanced search' link (right of subscriptions search in
the header)
- Search subscriptions (by ISSN, title, EAN, Publisher, Supplier and/or
  Branch)
- Check results are correct

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:16:19 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 14:16:19 +0000
Subject: [Koha-bugs] [Bug 5357] Subscription search and displays
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5357

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 16:37:58 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 14:37:58 +0000
Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr
 without breaking anything else
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233

--- Comment #13 from Jonathan Druart  ---
Created attachment 10434
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10434&action=edit
Bug 8233: Replace the given statement with for

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 17:24:23 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 15:24:23 +0000
Subject: [Koha-bugs] [Bug 8296] New: Add descriptive (text) published date
 field for serials
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8296
                CC: colin.campbell at ptfs-europe.com
          Assignee: julian.maurice at biblibre.com
           Summary: Add descriptive (text) published date field for
                    serials
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: julian.maurice at biblibre.com
          Hardware: All
            Status: ASSIGNED
           Version: master
         Component: Serials
           Product: Koha

This development add a new text field for serials which allow librarians to
enter a published date in the format he wants (displayed in full subscription
history at OPAC, and in each page displaying published date at staff interface)

Example: for a monthly subscription, we can enter "January 2012", "February
2012" instead of having "01/20/2012", "02/20/2012".

If not filled, displayed text is the published date.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 17:28:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 15:28:12 +0000
Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field
	for serials
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #1 from Julian Maurice  ---
Created attachment 10435
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10435&action=edit
Bug 8296: Add descriptive (text) published date field for serials

Add a new field serial.publisheddatetext for displaying published date
in another format that dateformat syspref permit.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 17:28:22 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 15:28:22 +0000
Subject: [Koha-bugs] [Bug 8296] Add descriptive (text) published date field
	for serials
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 17:30:23 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 15:30:23 +0000
Subject: [Koha-bugs] [Bug 8253] Fine doubling
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8253

Kyle M Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10429|0                           |1
        is obsolete|                            |

--- Comment #5 from Kyle M Hall  ---
Created attachment 10436
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10436&action=edit
Bug 8253 - Fine doubling - Remove Previous Duplicates

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 17:41:38 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 15:41:38 +0000
Subject: [Koha-bugs] [Bug 8297] New: Cannot check in or renew an item on hold
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8297

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8297
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
          Assignee: koha-bugs at lists.koha-community.org
           Summary: Cannot check in or renew an item on hold
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: epietrocupo.hlhl at ssss.gouv.qc.ca
          Hardware: All
            Status: NEW
           Version: rel_3_6
         Component: Circulation
           Product: Koha

Created attachment 10437
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10437&action=edit
Check-in and Renewwal disabled when an item is on hold

When an item is on hold, I do not get the option to check in the document in
the user account. See corresponding screenshot.

The only way to return a document is by entering the barcode in the return box.

I also do not get the option to renew a document on hold even if
"AllowHoldPolicyOverride" is set to "allow". This is the case for the current
screen shot.

So if I want to renew a document on hold because the client need a few more
days to return it. I need to place another hold for that client. Move is hold
at the top of the list, return the book, accept the hold and loan the book
again. This is very annoying.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 17:49:41 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 15:49:41 +0000
Subject: [Koha-bugs] [Bug 8293] Software error when clicking on first or
 last result of each page on OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8293

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|rel_3_8                     |master
           Assignee|oleonard at myacpl.org         |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 18:02:43 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 16:02:43 +0000
Subject: [Koha-bugs] [Bug 3514] Returning items through patron Details tab
 doesn't activate all circulation functions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3514

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|PATCH-Sent (DO NOT USE)     |P3
             Status|In Discussion               |ASSIGNED
            Version|rel_3_4                     |master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 18:03:00 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 16:03:00 +0000
Subject: [Koha-bugs] [Bug 3514] Returning items through patron Details tab
 doesn't activate all circulation functions
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3514

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |NEW
           Assignee|kyle.m.hall at gmail.com       |koha-bugs at lists.koha-commun
                   |                            |ity.org

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 19:31:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 17:31:33 +0000
Subject: [Koha-bugs] [Bug 8297] Cannot check in or renew an item on hold
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8297

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #1 from Owen Leonard  ---
The reason you can't check in on-hold items from the circulation or patron
details screen is that holds will not be properly handled. See Bug 3514.

Regarding AllowHoldPolicyOverride: The preference is designed to allow staff
members to override hold policies when placing holds, not during other
circulation operations.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 19:33:07 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 17:33:07 +0000
Subject: [Koha-bugs] [Bug 8288] showmarc.tt should not include full
	doc-head-close.inc
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288

--- Comment #1 from Owen Leonard  ---
Created attachment 10438
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10438&action=edit
Bug 8288 - showmarc.tt should not include full doc-head-close.inc

showmarc.tt and opac-showmarc.tt are used to load a plain view
of a MARC record and thus do not need the full set of page assets
loaded with other pages (CSS and JavaScript). Removing the
standard doc-head-close include will reduce the load time of
these pages.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 19:37:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 17:37:24 +0000
Subject: [Koha-bugs] [Bug 8288] showmarc.tt should not include full
	doc-head-close.inc
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 19:37:32 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 17:37:32 +0000
Subject: [Koha-bugs] [Bug 8288] showmarc.tt should not include full
	doc-head-close.inc
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 20:05:51 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 18:05:51 +0000
Subject: [Koha-bugs] [Bug 8213] "Cancel All" button on holds over tab
 cancels both holds over and holds waiting
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213

Albert Oller  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ago at bywatersolutions.com

--- Comment #2 from Albert Oller  ---
I'm not sure if this needs a separate bug entry, but can there also be a
confirmation pop-up?  

"Are you sure you want to do this?"

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 20:18:58 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 18:18:58 +0000
Subject: [Koha-bugs] [Bug 8213] "Cancel All" button on holds over tab
 cancels both holds over and holds waiting
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8213

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #3 from Katrin Fischer  ---
Hm, I can't think of a situation a library wants to delete all holds (maybe not
inventive enough today). I think normally you only want to cancel the expired
holds - so it would make sense to me for the button to do that. Maybe the
description could be more clear?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 20:19:06 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 18:19:06 +0000
Subject: [Koha-bugs] [Bug 8283] Replace usage of YUI Cookie utility with
 jQuery Cookie plugin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 20:19:09 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 18:19:09 +0000
Subject: [Koha-bugs] [Bug 8283] Replace usage of YUI Cookie utility with
 jQuery Cookie plugin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283

--- Comment #1 from Owen Leonard  ---
Created attachment 10439
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10439&action=edit
Bug 8283 - Replace usage of YUI Cookie utility with jQuery Cookie plugin

Switching from YUI Cookie utility to jQuery Cookie plugin. The
jQuery Cookie plugin is already used elsewhere in Koha, so no new
dependencies are added. The YUI Cookie files are removed.

To test, go to batch item deletion and/or batch item modification
and submit a set of barcodes. On the confirmation screen select
or deselect columns to show. Start over and submit your barcodes
again. The confirmation screen should remember which columns you
previously selected.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 20:19:22 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 18:19:22 +0000
Subject: [Koha-bugs] [Bug 8283] Replace usage of YUI Cookie utility with
 jQuery Cookie plugin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8283

Owen Leonard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 22:03:39 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 20:03:39 +0000
Subject: [Koha-bugs] [Bug 8282] Bug in modules list in about.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8282

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10408|0                           |1
        is obsolete|                            |

--- Comment #3 from Marc V?ron  ---
Created attachment 10440
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10440&action=edit
[SIGNED OFF] Bug 8282: Bug in modules list in about.pl

Last modules were not displayed if the number of modules did not match the
number of rows of the table (when $number_of_modules % 4 != 0)

Signed-off-by: Marc Veron 

Added some code to about.tt to have empty the last remaining cells, not sure if
an other signoff is needed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 22 22:04:28 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 20:04:28 +0000
Subject: [Koha-bugs] [Bug 8282] Bug in modules list in about.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8282

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 00:03:53 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 22 Jun 2012 22:03:53 +0000
Subject: [Koha-bugs] [Bug 5349] Moving an order
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349

--- Comment #12 from Marc V?ron  ---
Created attachment 10441
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10441&action=edit
Screenshots of processing a transfer, resulting in an empty window

After a click on "Transfer", I would expect a pop up like in like in
Patrons->Guarantor information->Set to> patron

However, transferorder.pl opens in the same browser window. If I follow the
steps, I get an empty page as a final result.

The PDF file shows screenshots of the steps I did.

Marc

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 05:37:06 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 03:37:06 +0000
Subject: [Koha-bugs] [Bug 7475] Option to overlay authorities
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7475

Jared Camins-Esakov  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #7 from Jared Camins-Esakov  ---
I am preparing the patch for bug 2060, and the test plan is pretty much exactly
the same, so I would suggest holding off on signing off on this one, and I will
submit one combined patch (or a series of combined patches) which can then be
signed off with exactly as much work as either one was going to be
individually.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 09:03:11 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 07:03:11 +0000
Subject: [Koha-bugs] [Bug 8152] Clicking cancel on edit suggestion redirect
 to the suggestion detail
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8152

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #5 from Chris Cormack  ---
Pushed to 3.8.x will be in 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 09:06:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 07:06:59 +0000
Subject: [Koha-bugs] [Bug 8006] Loading offline circulation does not
	anonymize
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8006

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz
            Version|rel_3_6                     |rel_3_8
           Severity|enhancement                 |minor

--- Comment #5 from Chris Cormack  ---
Pushed to 3.8.x, will be in 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 09:15:51 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 07:15:51 +0000
Subject: [Koha-bugs] [Bug 7994] Syntax error in yaml (syspref) files
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7994

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
            Version|rel_3_10                    |rel_3_8
           Severity|enhancement                 |trivial

--- Comment #27 from Chris Cormack  ---
Pushed to 3.8.x, virtual flowers to Claire for not only fixing the error but
writing a test script so errors won't creep back in.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 09:22:11 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 07:22:11 +0000
Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a
 tag in the tag cloud isn't the number of items with that tag
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #16 from Chris Cormack  ---
Pushed to 3.8.x, will be in 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 09:36:36 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 07:36:36 +0000
Subject: [Koha-bugs] [Bug 6350] Bug for tracking updates to the history file
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6350

--- Comment #11 from Chris Cormack  ---
Created attachment 10442
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10442&action=edit
Bug 6350 : Updating history

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 09:37:07 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 07:37:07 +0000
Subject: [Koha-bugs] [Bug 6350] Bug for tracking updates to the history file
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6350

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |ASSIGNED

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 09:37:30 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 07:37:30 +0000
Subject: [Koha-bugs] [Bug 6350] Bug for tracking updates to the history file
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6350

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
            Version|rel_3_6                     |master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 10:12:13 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 08:12:13 +0000
Subject: [Koha-bugs] [Bug 8298] New: Can't call method "subfield" on an
 undefined value at Biblio.pm (sub _AddBiblioNoZebra)
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8298

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8298
                CC: m.de.rooy at rijksmuseum.nl
          Assignee: gmcharlt at gmail.com
           Summary: Can't call method "subfield" on an undefined value at
                    Biblio.pm (sub _AddBiblioNoZebra)
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: veron at veron.ch
          Hardware: All
            Status: NEW
           Version: master
         Component: Cataloging
           Product: Koha

Koha version: 3.09.00.017

Error message:
Can't call method "subfield" on an undefined value at
 /usr/share/koha/lib/C4/Biblio.____pm line 2965.

Reported on koha at lists.katipo.co.nz , 23.June 2012

Occurs in sub _AddBiblioNoZebra

called by sub ModZebra. Line 2730  ((if preference "NoZebra" is set))

Line 2730: 
 %result = _AddBiblioNoZebra( $biblionumber, $newRecord, $server, %result );

It seems, that $newRecord is not defined, leading to error message above.

See comment on line 2700: " $newRecord is the MARC::Record containing the new
record. It is usefull only when NoZebra=1, (...) "

Workaround: 
----------
Set system preference "NoZebra" to "Use"

Questions: 
--------
- Should Preference "NoZebra" be removed (since it is depracated and seems to
be broken)
or
- Should the bug be tracked down ($newRecord not defined)?

Marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 10:16:18 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 08:16:18 +0000
Subject: [Koha-bugs] [Bug 8298] Can't call method "subfield" on an undefined
 value at Biblio.pm (sub _AddBiblioNoZebra)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8298

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #1 from Chris Cormack  ---
Yes, the preference should be removed. It has been deprecated for a while, the
only reason it hasn't been removed is that if someone has it set in the db,
once you remove it, they can't easily switch it back to zebra. (Unless they
know to use the localuse tab)

But it should definitely be removed, and no time should be invested in making
nozebra work again.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 10:20:43 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 08:20:43 +0000
Subject: [Koha-bugs] [Bug 6634] manager_id not populated when paying fines
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6634

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
            Version|rel_3_6                     |rel_3_8

--- Comment #27 from Chris Cormack  ---
Pushed to 3.8.x, will be in 3.8.3

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 10:29:48 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 08:29:48 +0000
Subject: [Koha-bugs] [Bug 8267] Overdue notices not working
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8267

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #7 from Chris Cormack  ---
This bug is also a cogent reminder to have use warnings; and check logs.

Since this would have been warning all over the place about $i being redefined. 
Pushed to 3.8.x will be in 3.8.3

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 10:33:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 08:33:24 +0000
Subject: [Koha-bugs] [Bug 8154] The export today's checked in barcodes
 generated file is always empty
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8154

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #9 from Chris Cormack  ---
Pushed to 3.8.x, will be in 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 10:59:17 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 08:59:17 +0000
Subject: [Koha-bugs] [Bug 8298] Can't call method "subfield" on an undefined
 value at Biblio.pm (sub _AddBiblioNoZebra)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8298

--- Comment #2 from Marc V?ron  ---
What about a warning section e.g. on the page "About Koha" similar to "Server
Information", where such things could be indicated?

It would test for configuration glitches and show messages like:

Warning: "Deprecated System preference 'NoZebra' set.

I can imagine that there are other things that could be addressed this way as
well.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 13:48:58 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 11:48:58 +0000
Subject: [Koha-bugs] [Bug 8299] New: overdue_notice.pl shows error messages
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8299

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8299
          Assignee: koha-bugs at lists.koha-community.org
           Summary: overdue_notice.pl shows error messages
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: nikhilvr0 at gmail.com
          Hardware: All
            Status: NEW
           Version: rel_3_8
         Component: Notices
           Product: Koha

I am installed koha 3.8.2 in Ubuntu lucid OS.When I run overdue_notices.pl with
some overdue items got this error message.


Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 659.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 659.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 659.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 659.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 659.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 659.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 659.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 659.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 659.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 659.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 659.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 659.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 659.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
Use of uninitialized value in pattern match (m//) at
/usr/share/koha/bin/cronjobs/overdue_notices.pl
line 670.
No letter_code at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 686.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 21:02:57 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 19:02:57 +0000
Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff
	search)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217

--- Comment #13 from Mirko Tietgen <5p4m at gmx.de> ---
Created attachment 10443
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10443&action=edit
Bug 8217: Followup: move code to the document.ready function

Signed-off-by: Mirko Tietgen <5p4m at gmx.de>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 21:03:34 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 19:03:34 +0000
Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff
	search)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217

Mirko Tietgen <5p4m at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |5p4m at gmx.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 21:17:52 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 19:17:52 +0000
Subject: [Koha-bugs] [Bug 8251] Patrons are systematically debarred at
	checkin
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8251

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #8 from Chris Cormack  ---
Holding off on pushing this to 3.8.x until the followup is signed off, passed
qa, and pushed to master also

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 21:19:15 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 19:19:15 +0000
Subject: [Koha-bugs] [Bug 8043] today's checkouts are in Previous checkouts
 in circulation.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8043

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #16 from Chris Cormack  ---
Pushed to 3.8.x, will be in 3.8.3.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 21:22:13 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 19:22:13 +0000
Subject: [Koha-bugs] [Bug 8272] OPAC : date expiration format
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8272

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #7 from Chris Cormack  ---
Pushed to 3.8.x will be in 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 21:31:00 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 19:31:00 +0000
Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

--- Comment #16 from Mirko Tietgen <5p4m at gmx.de> ---
Created attachment 10444
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10444&action=edit
Bug 6720: Display the authority type in OPAC

Due to a peculiarity in the way SearchAuthorities worked, the authority
search results on the OPAC always listed the authority type that the
user searched for, rather than the authority type of the results.

Signed-off-by: Katrin Fischer 
Works nicely, result list for OPAC search now shows the authority type
for each record.

Signed-off-by: Jared Camins-Esakov 
Rebased 20 June 2012.

Signed-off-by: Mirko Tietgen <5p4m at gmx.de>
Works as expected.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 21:33:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 19:33:12 +0000
Subject: [Koha-bugs] [Bug 6720] Saved authorities always show as 'Default'
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6720

Mirko Tietgen <5p4m at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |5p4m at gmx.de

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 22:41:14 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 20:41:14 +0000
Subject: [Koha-bugs] [Bug 8300] New: Koha should have mechanized testing
	suite
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8300
          Assignee: gmcharlt at gmail.com
           Summary: Koha should have mechanized testing suite
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: jcamins at cpbibliography.com
          Hardware: All
            Status: NEW
           Version: master
         Component: Test Suite
           Product: Koha

There should be a set of tests that use Test::WWW::Mechanize to automatically
test the functionality of Koha.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 23 22:54:26 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 23 Jun 2012 20:54:26 +0000
Subject: [Koha-bugs] [Bug 8300] Koha should have mechanized testing suite
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300

--- Comment #1 from Jared Camins-Esakov  ---
Created attachment 10445
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10445&action=edit
Bug 8300: Add mechanized unit test for batch import

This new unit test confirms that importing records via the Stage
MARC import tool still works by connecting to a Koha instance and
importing a record then reverting the import, checking at each step
of the way that everything is as it should be.

To test:
1. Install Test::WWW::Mechanize
> sudo apt-get install libtest-www-mechanize-perl
2. Set environment variables to reflect your Koha instance:
> export KOHA_USER=kohaadmin
> export KOHA_PASS=katikoan
> export KOHA_INTRANET_URL=http://localhost:8080
> export KOHA_OPAC_URL=http://localhost
3. Run the test:
> prove t/db_dependent/www/batch.t

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 09:04:03 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 07:04:03 +0000
Subject: [Koha-bugs] [Bug 7619] 3M self checkout don't work in France
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #13 from Chris Cormack  ---
We have a SIPConfig.xml file, could we put the terminator in there? If no one
can sees a floor in that plan, I'll go ahead and do it now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 09:05:50 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 07:05:50 +0000
Subject: [Koha-bugs] [Bug 8289] Upgrading from 2.2 does not work anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8289

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10425|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack  ---
Created attachment 10446
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10446&action=edit
Bug 8289 Upgrading from 2.2 does not work anymore

The updatedatabase22to30.pl script update the engine from MyISAM to InnoDB for
most tables.

However, the TYPE=InnoDB was deprecated, and is not removed.
The correct syntax is now ENGINE=InnoDB

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 09:06:08 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 07:06:08 +0000
Subject: [Koha-bugs] [Bug 8289] Upgrading from 2.2 does not work anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8289

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 09:09:15 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 07:09:15 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 09:11:52 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 07:11:52 +0000
Subject: [Koha-bugs] [Bug 7299] ILSDI HoldItem service does't set the
 itemnumber in reserves table
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7299

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|PATCH-Sent (DO NOT USE)     |P3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 09:15:18 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 07:15:18 +0000
Subject: [Koha-bugs] [Bug 7299] ILSDI HoldItem service does't set the
 itemnumber in reserves table
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7299

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10005|0                           |1
        is obsolete|                            |

--- Comment #5 from Chris Cormack  ---
Created attachment 10447
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10447&action=edit
Bug 7299 pass itemnumber in ILSDI holditem service

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 09:17:29 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 07:17:29 +0000
Subject: [Koha-bugs] [Bug 6932] Javascript errors in irregular pattern check
	update
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6932

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion
                 CC|                            |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 09:18:32 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 07:18:32 +0000
Subject: [Koha-bugs] [Bug 5409] Call number is not show on Opac search
	result page.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10288|0                           |1
           is patch|                            |
  Attachment #10288|application/octet-stream    |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 09:21:07 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 07:21:07 +0000
Subject: [Koha-bugs] [Bug 5409] Call number is not show on Opac search
	result page.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #7 from Chris Cormack  ---
I think both these patches are needed, unobsoleting one

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 09:21:38 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 07:21:38 +0000
Subject: [Koha-bugs] [Bug 5409] Call number is not show on Opac search
	result page.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5409

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #2754|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 09:23:21 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 07:23:21 +0000
Subject: [Koha-bugs] [Bug 4226] bulkmarcimport.pl doesn't replace 001 when
 keepids is not specified
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4226

--- Comment #5 from Chris Cormack  ---
Attached script looks good but needs the copyright headers fixed. Also should
we change the description of this bug?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 09:34:00 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 07:34:00 +0000
Subject: [Koha-bugs] [Bug 8288] showmarc.tt should not include full
	doc-head-close.inc
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10438|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack  ---
Created attachment 10448
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10448&action=edit
Bug 8288 - showmarc.tt should not include full doc-head-close.inc

showmarc.tt and opac-showmarc.tt are used to load a plain view
of a MARC record and thus do not need the full set of page assets
loaded with other pages (CSS and JavaScript). Removing the
standard doc-head-close include will reduce the load time of
these pages.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 09:35:02 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 07:35:02 +0000
Subject: [Koha-bugs] [Bug 8288] showmarc.tt should not include full
	doc-head-close.inc
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 09:40:03 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 07:40:03 +0000
Subject: [Koha-bugs] [Bug 8260] Routing List Ranking Needs Re-order After
	Patron Delete
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #3 from Chris Cormack  ---
This works well, and mimics the behaviour that happens with the reserves that
are set if you have system preference set to create reserves for routing lists.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 09:45:43 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 07:45:43 +0000
Subject: [Koha-bugs] [Bug 8260] Routing List Ranking Needs Re-order After
	Patron Delete
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |In Discussion

--- Comment #4 from Chris Cormack  ---
The only problem is that it is called unconditionally on every load of the
page, even if we just reranked the list by deleting a member, or changing the
rank. 

For that reason i'm hesitant to sign off, does anyone else have a better idea
on how to solve this? I'm thinking fixing the borrower delete to not delete
borrowers who are in a routing list might be better.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 10:02:34 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 08:02:34 +0000
Subject: [Koha-bugs] [Bug 8279] CAS Debugging improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8279

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10399|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack  ---
Created attachment 10449
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10449&action=edit
Bug 8279: CAS Debugging improvements

Adds more precise debug informations for easier CAS troubleshootings
resolution.

  Before this patch, whenever ticket validation failed, the debug message was
"Invalid ticket".
  But ticket validation may fail for other reasons: CAS server not reachable,
casServerUrl syspref is wrong...

  This patch adds the reason for ticket validation failing.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 10:03:14 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 08:03:14 +0000
Subject: [Koha-bugs] [Bug 8279] CAS Debugging improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8279

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 10:05:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 08:05:12 +0000
Subject: [Koha-bugs] [Bug 8268] Koha should offer way to backup entire db
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #5 from Chris Cormack  ---
Applying: Bug 8268: Add database dump to export tool
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 8268: Add database dump to export tool

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 13:31:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 11:31:25 +0000
Subject: [Koha-bugs] [Bug 8268] Koha should offer way to backup entire db
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268

--- Comment #6 from Jared Camins-Esakov  ---
(In reply to comment #5)
> Applying: Bug 8268: Add database dump to export tool
> fatal: sha1 information is lacking or useless
> (koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt).
> Repository lacks necessary blobs to fall back on 3-way merge.
> Cannot fall back to three-way merge.
> Patch failed at 0001 Bug 8268: Add database dump to export tool

Did you apply this on top of the patch for bug 8202?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 18:42:22 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 16:42:22 +0000
Subject: [Koha-bugs] [Bug 8215] Add Course Reserves
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8215

Fr?d?ric Demians  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply
                 CC|                            |frederic at tamil.fr

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 20:24:05 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 18:24:05 +0000
Subject: [Koha-bugs] [Bug 7522] When you search preferences,
 instead of getting a result Koha reports software error
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7522

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |veron at veron.ch
         Resolution|---                         |DUPLICATE

--- Comment #1 from Marc V?ron  ---


*** This bug has been marked as a duplicate of bug 8261 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 20:24:05 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 18:24:05 +0000
Subject: [Koha-bugs] [Bug 8261] Cannot search system preferences from Local
	Use tab
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bmugambi at gmail.com

--- Comment #1 from Marc V?ron  ---
*** Bug 7522 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 20:27:17 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 18:27:17 +0000
Subject: [Koha-bugs] [Bug 8261] Cannot search system preferences from Local
	Use tab
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8261

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #2 from Marc V?ron  ---
This bug was already reported by Bug 7522. I marked 7522 as duplicate.

I can confirm the bug (Version     3.09.00.017 )

Marc

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 20:55:46 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 18:55:46 +0000
Subject: [Koha-bugs] [Bug 8301] New: Display additional system information
 (preferences) on About page to minimize support cases
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8301

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8301
          Assignee: nengard at gmail.com
           Summary: Display additional system information (preferences) on
                    About page to minimize support cases
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: veron at veron.ch
          Hardware: All
            Status: NEW
           Version: master
         Component: About
           Product: Koha

Created attachment 10450
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10450&action=edit
Screenshot with warnings regarding preferences on About page

To minimize support questions regarding common mistakes, the About page should
have an additional tab that displays warnings if depractated and/or mutual
excluding system preferences are used.

Example: Bug 8298 Can't call method "subfield" on an undefined value at
Biblio.pm (sub _AddBiblioNoZebra)

See screenshot attached.

Marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 20:56:53 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 18:56:53 +0000
Subject: [Koha-bugs] [Bug 8298] Can't call method "subfield" on an undefined
 value at Biblio.pm (sub _AddBiblioNoZebra)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8298

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=8301

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 20:56:53 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 18:56:53 +0000
Subject: [Koha-bugs] [Bug 8301] Display additional system information
 (preferences) on About page to minimize support cases
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8301

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=8298

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 21:35:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 19:35:24 +0000
Subject: [Koha-bugs] [Bug 8301] Display additional system information
 (preferences) on About page to minimize support cases
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8301

--- Comment #1 from Marc V?ron  ---
Created attachment 10451
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10451&action=edit
Bug 8301 - Display additional system information (preferences) on About page to
minimize support cases

To minimize support questions regarding common mistakes, the About
page should have an additional tab that displays warnings if depractated
and/or mutual excluding system preferences are used.

To test patch use values as displayed on screenshot attached.

Sugestions for other values to add are welcome.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sun Jun 24 21:37:44 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sun, 24 Jun 2012 19:37:44 +0000
Subject: [Koha-bugs] [Bug 8301] Display additional system information
 (preferences) on About page to minimize support cases
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8301

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
           Assignee|nengard at gmail.com           |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 04:04:52 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 02:04:52 +0000
Subject: [Koha-bugs] [Bug 8260] Routing List Ranking Needs Re-order After
	Patron Delete
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8260

--- Comment #5 from David Cook  ---
(In reply to comment #4)
> The only problem is that it is called unconditionally on every load of the
> page, even if we just reranked the list by deleting a member, or changing
> the rank. 
> 
> For that reason i'm hesitant to sign off, does anyone else have a better
> idea on how to solve this? I'm thinking fixing the borrower delete to not
> delete borrowers who are in a routing list might be better.

I agree with the problem, but I think it's still a good idea to be able to
delete borrowers who are in routing lists. I think it would be a bit too
finicky to have to go into each routing list and remove them before doing a
complete delete.

Why don't we call the new reorder function on patron delete? I see that there
is already a function for handling patron deletes in regards to
Lists/VirtualShelves.  That probably makes the most sense.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 07:19:03 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 05:19:03 +0000
Subject: [Koha-bugs] [Bug 8302] New: Add accesssion number to the drop down
 list in OPAC Search.
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8302
          Assignee: oleonard at myacpl.org
           Summary: Add accesssion number to the drop down list in OPAC
                    Search.
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: meenakshi.r at osslabs.biz
          Hardware: All
            Status: NEW
           Version: master
         Component: OPAC
           Product: Koha

Created attachment 10452
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10452&action=edit
Attaching patch

Add Accession no to OPAC Search drop down list.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 07:45:53 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 05:45:53 +0000
Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |mtj at kohaaloha.com

--- Comment #56 from Mason James  ---
QA comments

1) parcel.tt and parcels.tt appear to have existing code globally reformatted
with pretty-formatting/auto-indentation

2) patch does not apply to current master
'19d30206df473ff6d801f15063f6837225b004bf' with some big conflicts 
(nor does it apply to master at the date of the last rebased patch?
'2012-06-10')

please resubmit patch without applying global pretty-formatting to existing
template code

failing QA on issue 1

otherwise? it looks good. both 'prove xt' and 'perlcritic' pass ok

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 07:48:43 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 05:48:43 +0000
Subject: [Koha-bugs] [Bug 8302] Add accesssion number to the drop down list
 in OPAC Search.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302

Meenakshi  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|oleonard at myacpl.org         |meenakshi.r at osslabs.biz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 07:53:15 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 05:53:15 +0000
Subject: [Koha-bugs] [Bug 8303] New: Hide login box in OPAC with system
	preference.
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8303

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8303
          Assignee: oleonard at myacpl.org
           Summary: Hide login box in OPAC with system preference.
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: meenakshi.r at osslabs.biz
          Hardware: All
            Status: NEW
           Version: master
         Component: OPAC
           Product: Koha

Hide login box in OPAC with system preference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 08:24:56 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 06:24:56 +0000
Subject: [Koha-bugs] [Bug 8303] Hide login box in OPAC with system
	preference.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8303

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
Hi, there is already a systempreference to do that: opacuserlogin.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 08:36:08 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 06:36:08 +0000
Subject: [Koha-bugs] [Bug 8289] Upgrading from 2.2 does not work anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8289

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #3 from M. de Rooy  ---
Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 08:54:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 06:54:04 +0000
Subject: [Koha-bugs] [Bug 8282] Bug in modules list in about.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8282

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|                            |m.de.rooy at rijksmuseum.nl

--- Comment #4 from M. de Rooy  ---
Looks good to me.
Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:12:57 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 07:12:57 +0000
Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

--- Comment #22 from M. de Rooy  ---
(In reply to comment #21)
> intranet-tmpl/prog/en/modules/help/admin/auth_subfields_structure.tt:18
> To edit the subfields, click 'Edit Subfields.'
> ->... Edit Subfields'.
> 
> intranet-tmpl/prog/en/modules/help/acqui/basketheader.tt:9
> When finished, click 'Save.'
> ->...'Save'.
> 
> intranet-tmpl/prog/en/modules/help/admin/aqbudgets.tt:26
> li>Planning categories are used for statistical purposes. To learn more
> about planning categories, check out the Planning Category FAQ.
> ->Error with 
        • ?

Marc,
Please send a patch for comment9 and the above typos.
You can click take over on the assignee, if you do so.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:20:14 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 07:20:14 +0000
Subject: [Koha-bugs] [Bug 8304] New: composed authorities Rameau management
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8304
          Assignee: gmcharlt at gmail.com
           Summary: composed authorities Rameau management
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: matthias.meusburger at biblibre.com
          Hardware: All
            Status: NEW
           Version: master
         Component: MARC Authority data support
           Product: Koha

This patch is designed to manage the composed authorities the Way Rameau is
coping with them in France.
This enables libraries to merge composed authorities and only change the
heading field.
It supposes that the previous data is sent to merge function so that process
deletes previous heading entries.

Say you have in a biblio record :
   - 606
       $9 1214
       $3 123
       $a Europe
       $9 1215
       $3 456
       $y France
       $9 1210
       $3 199
       $x Politiciens
       $9 1216
       $3 789
       $z 1801-1860
And you change authority 1210
    -250
        $a Politiciens
into
    -250
        $a Politique

You should get :
   - 606
       $9 1214
       $3 123
       $a Europe
       $9 1215
       $3 456
       $y France
       $9 1210
       $3 199
       $x Politique
       $9 1216
       $3 789
       $z 1801-1860

In an other record :
   - 606
       $9 1210
       $3 199
       $a Politiciens
You should get :
   - 606
       $9 1210
       $3 199
       $a Politique

This patch changes the merge function.
And adds three internal functions.
merge function  has been prettyfied
And documentation from GuessAuthTypeCode has been updated (had not been)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:21:01 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 07:21:01 +0000
Subject: [Koha-bugs] [Bug 5349] Moving an order
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349

--- Comment #13 from Julian Maurice  ---
1/ Did you apply the follow-up patch?

2/ Do you have any extensions or custom settings that could lead to popup
window opening in current tab? (I know Firefox extension Tab Mix Plus can do
this)

3/ Javascript enabled?

If answers are 1/ yes 2/ no 3/ yes, please change status to failed qa and I
will take a look at it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:22:13 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 07:22:13 +0000
Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304

--- Comment #1 from Matthias Meusburger  ---
Created attachment 10453
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10453&action=edit
Bug 8304 : composed authorities Rameau management

Bug 5635: bulkmarcimport new parameters & features

This patch is designed to manage the composed authorities the Way Rameau is
coping with them in France.
This enables libraries to merge composed authorities and only change the
heading field.
It supposes that the previous data is sent to merge function so that process
deletes previous heading entries.

Say you have in a biblio record :
   - 606
       $9 1214
       $3 123
       $a Europe
       $9 1215
       $3 456
       $y France
       $9 1210
       $3 199
       $x Politiciens
       $9 1216
       $3 789
       $z 1801-1860
And you change authority 1210
    -250
        $a Politiciens
into
    -250
        $a Politique

You should get :
   - 606
       $9 1214
       $3 123
       $a Europe
       $9 1215
       $3 456
       $y France
       $9 1210
       $3 199
       $x Politique
       $9 1216
       $3 789
       $z 1801-1860

In an other record :
   - 606
       $9 1210
       $3 199
       $a Politiciens
You should get :
   - 606
       $9 1210
       $3 199
       $a Politique

This patch changes the merge function.
And adds three internal functions.
merge function  has been prettyfied
And documentation from GuessAuthTypeCode has been updated (had not been)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:22:31 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 07:22:31 +0000
Subject: [Koha-bugs] [Bug 8304] composed authorities Rameau management
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8304

Matthias Meusburger  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|gmcharlt at gmail.com          |matthias.meusburger at biblibr
                   |                            |e.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:28:53 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 07:28:53 +0000
Subject: [Koha-bugs] [Bug 8301] Display additional system information
 (preferences) on About page to minimize support cases
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8301

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10451|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron  ---
Created attachment 10454
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10454&action=edit
Bug 8301 - Display additional system information (preferences) on About page to
minimize support cases

To minimize support questions regarding common mistakes, the About
page should have an additional tab that displays warnings if depractated
and/or mutual excluding system preferences are used.

To test patch use values as displayed on screenshot attached.

New: Shows error message in Tab Server Information if Zebra server is not
started

Suggestions for other values to add are welcome.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:33:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 07:33:59 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

--- Comment #37 from Jonathan Druart  ---
I mark it as obsolete

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:34:22 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 07:34:22 +0000
Subject: [Koha-bugs] [Bug 8301] Display additional system information
 (preferences) on About page to minimize support cases
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8301

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10454|0                           |1
        is obsolete|                            |

--- Comment #3 from Marc V?ron  ---
Created attachment 10455
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10455&action=edit
Bug 8301 - Display additional system information (preferences) on About page to
minimize support cases

To minimize support questions regarding common mistakes, the About
page should have an additional tab that displays warnings if depractated
and/or mutual excluding system preferences are used.

To test patch use values as displayed on screenshot attached.

New: Shows error message in Tab Server Information if Zebra server is not
started
(...and changes added...)

Suggestions for other values to add are welcome.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:34:28 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 07:34:28 +0000
Subject: [Koha-bugs] [Bug 4045] No check for maximum number of allowed holds.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4045

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10412|0                           |1
        is obsolete|                            |

--- Comment #38 from Jonathan Druart  ---
Comment on attachment 10412
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10412
Bug 4045 - Followup: No check for maximum number of allowed holds.

>From a9fa989ebc8a95508309d9b77d1ac9a392bec06c Mon Sep 17 00:00:00 2001
>From: Jonathan Druart 
>Date: Thu, 21 Jun 2012 16:55:41 +0200
>Subject: [PATCH] Bug 4045 - Followup: No check for maximum number of allowed
> holds.
>
>Adds the systempreference in .pref file
>---
> .../en/modules/admin/preferences/circulation.pref  |    4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>index a54e3c5..2341133 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
>@@ -370,6 +370,10 @@ Circulation:
>                   yes: Allow
>                   no: "Don't allow"
>             - holds to be suspended from the OPAC.
>+        -
>+            - pref: maxreserves
>+              class: integer
>+            - System-wide maximum number of holds a patron can place
>     Fines Policy:
>         -
>             - Calculate fines based on days overdue
>-- 
>1.7.7.3

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:38:39 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 07:38:39 +0000
Subject: [Koha-bugs] [Bug 7619] 3M self checkout don't work in France
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619

--- Comment #14 from Paul Poulain  ---
(In reply to comment #13)
> We have a SIPConfig.xml file, could we put the terminator in there? If no
> one can sees a floor in that plan, I'll go ahead and do it now.

+1, that's the easiest & best option (even if, as the file is in gitted, it
will require a patch, but that's not a big deal)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:42:31 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 07:42:31 +0000
Subject: [Koha-bugs] [Bug 8074] Holds to pull
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8074

Adrien SAURAT  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |adrien.saurat at biblibre.com
           Assignee|kyle.m.hall at gmail.com       |adrien.saurat at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:42:46 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 07:42:46 +0000
Subject: [Koha-bugs] [Bug 7619] 3M self checkout don't work in France
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10031|0                           |1
        is obsolete|                            |

--- Comment #15 from Chris Cormack  ---
Created attachment 10456
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10456&action=edit
Bug 7619 Use CRLF as default terminator

Most units require or tolerate CRLF as the terminator
Using only \r causes many including 3M units to signal errors
due to delay this resets CRLF to be default but adds a single
constant variable and explanation so that if you have a
"strictly conforming" unit (the 'Baby' is the only I have encountered
you know where to make the change

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:44:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 07:44:04 +0000
Subject: [Koha-bugs] [Bug 7619] 3M self checkout don't work in France
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |ASSIGNED

--- Comment #16 from Chris Cormack  ---
Have signed off the first patch, since this works and fixes the immediate
problem.
Working on a follow up to shift setting the line end character out of the .pm
into the config file.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:44:17 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 07:44:17 +0000
Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|m.de.rooy at rijksmuseum.nl    |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:51:39 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 07:51:39 +0000
Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

--- Comment #23 from Marc V?ron  ---
Created attachment 10457
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10457&action=edit
Corrects 2 typos see comment  #9

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 09:53:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 07:53:25 +0000
Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10457|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 10:01:05 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 08:01:05 +0000
Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

--- Comment #24 from Marc V?ron  ---
Created attachment 10458
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10458&action=edit
Bug 7368 - General staff client typo omnibus

Corrects 2 typos, see comment #9

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 10:02:02 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 08:02:02 +0000
Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 10:06:48 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 08:06:48 +0000
Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr
 without breaking anything else
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233

--- Comment #14 from Jonathan Druart  ---
Created attachment 10459
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10459&action=edit
Bug 8233: Hide the search engine configuration link for Zebra

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 10:18:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 08:18:04 +0000
Subject: [Koha-bugs] [Bug 5349] Moving an order
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349

--- Comment #14 from Marc V?ron  ---
Sorry, I get the following error:

Applying: Bug 5349: Order line transfers
/usr/share/kohaclone/.git/rebase-apply/patch:109: new blank line at EOF.
+
error: patch failed: installer/data/mysql/updatedatabase.pl:5369
error: installer/data/mysql/updatedatabase.pl: patch does not apply
Patch failed at 0001 Bug 5349: Order line transfers


I tried to resolve it, maybe it did not work out correctly leading to behaviour
described in comment #12

Marc

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 10:38:13 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 08:38:13 +0000
Subject: [Koha-bugs] [Bug 8301] Display additional system information
 (preferences) on About page to minimize support cases
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8301

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P3
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 10:41:51 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 08:41:51 +0000
Subject: [Koha-bugs] [Bug 7619] 3M self checkout don't work in France
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 10:45:13 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 08:45:13 +0000
Subject: [Koha-bugs] [Bug 7619] 3M self checkout don't work in France
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7619

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #17 from Chris Cormack  ---
Actually, the config object is not passed through to the write_msg sub, so it
would take quite a bit of a rewrite. 

So for now, people will need to change the variable in the C4/SIP/Sip.pm. This
works well enough, so I think it should move on to QA. The followup would still
be nice, but I don't think we should hold up pushing this fix until then.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 10:57:55 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 08:57:55 +0000
Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #25 from M. de Rooy  ---
Attachment 10458: Passed QA. Very trivial typo fix.
Marc: In this kind of case you could have attached your own sign-off. See
comment1.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 10:58:03 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 08:58:03 +0000
Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 10:59:58 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 08:59:58 +0000
Subject: [Koha-bugs] [Bug 8300] Koha should have mechanized testing suite
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8300

claire.hernandez at biblibre.com  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |claire.hernandez at biblibre.c
                   |                            |om

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:00:57 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 09:00:57 +0000
Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339

--- Comment #57 from Julian Maurice  ---
Created attachment 10460
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10460&action=edit
Bug 5339: Invoices management improvement

Rebased my patches on current master (and squashed into one patch).

Elliot, I didn't succeed to apply your patch so please submit a follow-up and
mark previous patch as obsolete.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:01:06 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 09:01:06 +0000
Subject: [Koha-bugs] [Bug 5339] Parcel closing in acq
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5339

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:01:30 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 09:01:30 +0000
Subject: [Koha-bugs] [Bug 7189] preference to control if returning lost
 items gives refund
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7189

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA
                 CC|                            |veron at veron.ch

--- Comment #5 from Marc V?ron  ---
I tested the path, but no preference 'RefundLostItemFeeOnReturn' shows up if I
do a search on the preferences. 

I do not find any modified .pref file in the patch.

Marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:05:30 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 09:05:30 +0000
Subject: [Koha-bugs] [Bug 8301] Display additional system information
 (preferences) on About page to minimize support cases
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8301

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10455|0                           |1
        is obsolete|                            |

--- Comment #4 from Chris Cormack  ---
Created attachment 10461
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10461&action=edit
Bug 8301 - Display additional system information (preferences) on About page to
minimize support cases

To minimize support questions regarding common mistakes, the About
page should have an additional tab that displays warnings if depractated
and/or mutual excluding system preferences are used.

To test patch use values as displayed on screenshot attached.

New: Shows error message in Tab Server Information if Zebra server is not
started
(...and changes added...)

Suggestions for other values to add are welcome.

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:05:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 09:05:33 +0000
Subject: [Koha-bugs] [Bug 5349] Moving an order
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10375|0                           |1
        is obsolete|                            |

--- Comment #15 from Julian Maurice  ---
Created attachment 10462
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10462&action=edit
[SIGNED-OFF] Bug 5349: Order line transfers

Rebased on master, conflicts on updatedatabase.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:06:13 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 09:06:13 +0000
Subject: [Koha-bugs] [Bug 5349] Moving an order
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10376|0                           |1
        is obsolete|                            |

--- Comment #16 from Julian Maurice  ---
Created attachment 10463
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10463&action=edit
Follow-up: run transferorder.pl in a popup

Rebased on master

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:06:26 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 09:06:26 +0000
Subject: [Koha-bugs] [Bug 8301] Display additional system information
 (preferences) on About page to minimize support cases
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8301

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #5 from Chris Cormack  ---
Works well, could perhaps get a bit more styling, but is a great start.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:08:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 09:08:12 +0000
Subject: [Koha-bugs] [Bug 5349] Moving an order
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349

--- Comment #17 from Julian Maurice  ---
Tested right now, the transferorder.pl page is opened in a popup and doesn't
end on a blank screen.
Please attach any relevant logs if you reproduce the problem.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:09:37 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 09:09:37 +0000
Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr
 without breaking anything else
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10334|0                           |1
        is obsolete|                            |

--- Comment #15 from Chris Cormack  ---
Created attachment 10464
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10464&action=edit
Bug 8233 : SearchEngine: Add a Koha::SearchEngine module

First draft introducing solr into Koha :-)

List of files :
  $ tree t/searchengine/
  t/searchengine
  |-- 000_conn
  |   `-- conn.t
  |-- 001_search
  |   `-- search_base.t
  |-- 002_index
  |   `-- index_base.t
  |-- 003_query
  |   `-- buildquery.t
  |-- 004_config
  |   `-- load_config.t
  `-- indexes.yaml
  just do `prove -r t/searchengine/**/*.t`

  t/lib
  |-- Mocks
  |   `-- Context.pm
  `-- Mocks.pm
  provide a mock to SearchEngine syspref (set_zebra and set_solr).

  $ tree Koha/SearchEngine
  Koha/SearchEngine
  |-- Config.pm
  |-- ConfigRole.pm
  |-- FacetsBuilder.pm
  |-- FacetsBuilderRole.pm
  |-- Index.pm
  |-- IndexRole.pm
  |-- QueryBuilder.pm
  |-- QueryBuilderRole.pm
  |-- Search.pm
  |-- SearchRole.pm
  |-- Solr
  |   |-- Config.pm
  |   |-- FacetsBuilder.pm
  |   |-- Index.pm
  |   |-- QueryBuilder.pm
  |   `-- Search.pm
  |-- Solr.pm
  |-- Zebra
  |   |-- QueryBuilder.pm
  |   `-- Search.pm
  `-- Zebra.pm

How to install and configure Solr ?
  See the wiki page: http://wiki.koha-community.org/wiki/SearchEngine_Layer_RFC

http://bugs.koha-community.org/show_bug.cgi?id=8233
Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:10:52 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 09:10:52 +0000
Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr
 without breaking anything else
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10335|0                           |1
        is obsolete|                            |

--- Comment #16 from Chris Cormack  ---
Created attachment 10465
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10465&action=edit
Bug 8233 fixing the number in updatedatabase.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:12:03 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 09:12:03 +0000
Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr
 without breaking anything else
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10434|0                           |1
        is obsolete|                            |

--- Comment #17 from Chris Cormack  ---
Created attachment 10466
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10466&action=edit
Bug 8233: Replace the given statement with for

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:12:49 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 09:12:49 +0000
Subject: [Koha-bugs] [Bug 6132] System preferences are case sensitive
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6132

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |RESOLVED
         Resolution|---                         |FIXED

--- Comment #16 from Julian Maurice  ---
Ok in master, 3.8.x and 3.6.x branches

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:14:19 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 09:14:19 +0000
Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr
 without breaking anything else
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10459|0                           |1
        is obsolete|                            |

--- Comment #18 from Chris Cormack  ---
Created attachment 10467
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10467&action=edit
Bug 8233: Hide the search engine configuration link for Zebra

Signed-off-by: Chris Cormack 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:15:06 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 09:15:06 +0000
Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr
 without breaking anything else
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233

--- Comment #19 from Chris Cormack  ---
For replacing the when, and hiding the configuration both work well. Back to
signed off

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:18:37 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 09:18:37 +0000
Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and
	frequencies
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10145|0                           |1
        is obsolete|                            |

--- Comment #9 from Julian Maurice  ---
Created attachment 10468
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10468&action=edit
Database files

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:20:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 09:20:12 +0000
Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and
	frequencies
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10468|0                           |1
        is obsolete|                            |

--- Comment #10 from Julian Maurice  ---
Created attachment 10469
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10469&action=edit
Database files

Bad manipulation, this one is the rebased patch.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 11:21:02 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 09:21:02 +0000
Subject: [Koha-bugs] [Bug 7688] Change subscriptions numbering pattern and
	frequencies
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7688

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10146|0                           |1
        is obsolete|                            |

--- Comment #11 from Julian Maurice  ---
Created attachment 10470
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10470&action=edit
Change subscription numbering pattern and frequencies

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 12:16:09 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 10:16:09 +0000
Subject: [Koha-bugs] [Bug 8268] Koha should offer way to backup entire db
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268

--- Comment #7 from Robin Sheat  ---
It applies for me:

robin at momomoto:~/catalyst/koha$ git bz apply 8202
Bug 8202 - Add authorities to export tool

[SIGNED-OFF] Bug 8202: Add authority export to tools/export.pl
Apply? [yn] y

Applying: Bug 8202: Add authority export to tools/export.pl
robin at momomoto:~/catalyst/koha$ git bz apply 8268
Bug 8268 - Koha should offer way to backup entire db

Bug 8268: Add database dump to export tool
Apply? [yn] y

Applying: Bug 8268: Add database dump to export tool
/home/robin/catalyst/koha/.git/rebase-apply/patch:117: trailing whitespace.
    ls "$backupdir/" | 
/home/robin/catalyst/koha/.git/rebase-apply/patch:307: trailing whitespace.
    print $query->header(   -type => $mimetype, 
warning: 2 lines add whitespace errors.
robin at momomoto:~/catalyst/koha$

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 13:10:09 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 11:10:09 +0000
Subject: [Koha-bugs] [Bug 8268] Koha should offer way to backup entire db
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268

--- Comment #8 from Robin Sheat  ---
Created attachment 10471
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10471&action=edit
Bug 8268: Add database dump to export tool

This patch builds on work by Lars Wirzenius for the Koha packages.

To date, the only way for a Koha librarian to obtain a complete backup
of their system has been to log into the system via SSH (or FTP) to
download the mysqldump file. This patch makes it possible for
superlibrarians in properly configured systems to download night backups
via the staff client's Export tool.

Recognizing that this is functionality with potentially very grave
security implications, system administrators must manually enable these
features in the koha-conf.xml configuration file.

The following configuration settings have been added to the koha-conf.xml
file:
* backupdir => directory where backups should be stored.
* backup_db_via_tools => whether to allow superlibrarians to download
  database backups via the Export tool. The default is disabled, and
  there is no way -- by design -- to enable this option without manually
  editing koha-conf.xml.
* backup_conf_via_tools => whether to allow superlibrarians to download
  configuration backups via the Export tool (this may be applicable to
  packages only). The default is disabled, and there is no way -- by
  design -- to enable this option without manually editing koha-conf.xml.

This commit modifies the following scripts to make use of the new
backupdir configuration option:
* koha-dump and koha-run-backups in the Debian packages
* The sample backup script misc/cronjobs/backup.sh

Note that for security reasons, superlibrarians will not be allowed
to download files that are not owned by the web server's effective user.
This imposes a de facto dependency on ITK (for Apache) or running the
web server as the Koha user (as is done with Plack).

To test:
1. Apply patch.
2. Go to export page as a superlibrarian. Notice that no additional
   export options appear because they have not been enabled.
3. Add $KOHADEV/var/spool to the  section
   of your koha-conf.xml (note that you will need to adjust that so that
   it is pointing at a logical directory).
4. Create the aforementioned directory.
5. Go to export page as a superlibrarian. Notice that no additional
   export options appear because they have not been enabled.
6. Add 1 to the 
   section of your koha-conf.xml
7. Go to the export page as a superlibrarian. Notice the new tab.
8. Go to the export page as a non-superlibrarian. Notice there is no
   new tab.
9. Run: mysqldump -u koha -p koha | gzip > $BACKUPDIR/backup.sql.gz
   (substituting appropriate user, password, and database name)
10. Go to the export page as a superlibrarian, and look at the "Export
    database" tab. If you are running the web server as your Koha user,
    and ran the above command as your Koha user, you should now see the
    file listed as an option for download.
11. If you *did* see the file listed, change the ownership to something
    else: sudo chown root:root $BACKUPDIR/backup.sql.gz
11a. Confirm that you no longer see the file listed when you look at the
     "Export database" tab.
12. Change the ownership on the file to your web server (or Koha) user:
    sudo chown www-data:www-data backup.sql.gz
13. Go to the export page as a superlibrarian, and look at the "Export
    database" tab. You should now see backup.sql.gz listed.
14. Choose to download backup.sql.gz
15. Confirm that the downloaded file is what you were expecting.

If you are interested, you can repeat the above steps but replace
 with , and instead of
creating an sql file, create a tar file.

To test packaging: run koha-dump, confirm that it still creates a
usable backup.

------

This signoff contains two changes:

10-1. If no backup/conf files were present, then the message telling you
so doesn't appear and the download button does. Made them behave
correctly.
10-2. The test for a file existing required it to be owned by the
webserver UID. This change makes it so it only has to be readable.

Signed-off-by: Robin Sheat 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 13:10:49 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 11:10:49 +0000
Subject: [Koha-bugs] [Bug 8268] Koha should offer way to backup entire db
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8268

Robin Sheat  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--- Comment #9 from Robin Sheat  ---
Things noted:

10-1. If you forgot to run the backup command, then there is nothing to choose
from but the download button is still there. Not a big issue, just slightly
cosmetic. Also, the "no downloads exist" message is missing, I think due to
different semantics between T::T and perl about whether an empty array is
considered "true."

10-2. This doesn't work with the packages, as it's testing -o (do I own this
file) not -r (can I read this file.) Dumps provided by the packages are owned
by root, but readable by the webserver due to group permissions. This needs to
be fixed in getbackupfilelist and download_backup.

My signed off patch fixes these.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 13:22:15 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 11:22:15 +0000
Subject: [Koha-bugs] [Bug 8305] New: Use apple-touch-icon for pretty
	bookmark icons
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8305

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8305
          Assignee: oleonard at myacpl.org
           Summary: Use apple-touch-icon for pretty bookmark icons
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: magnus at enger.priv.no
          Hardware: All
            Status: NEW
           Version: master
         Component: OPAC
           Product: Koha

Currently if you bookmark the Koha OPAC on a device like the iPad by adding it
to your "home" screen, you get an icon that is a tiny screenshot of the page
you bookmarked - not very pretty. 

Specifying a pretty icon is as simple as this: 


And of course we have to add the actual icon. 

Despite the name, this is supposed to work for e.g. Android-based devices, not
just Apple devices. 

It might be a good idea to have one icon for the OPAC and one for the intranet,
like we do with the favicons. 

Docs: 

-
http://developer.apple.com/library/ios/#DOCUMENTATION/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html

- http://mathiasbynens.be/notes/touch-icons

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 13:51:06 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 11:51:06 +0000
Subject: [Koha-bugs] [Bug 8306] New: Patron stats,
 patron activity : no active doesn't ork
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8306

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8306
          Assignee: adrien.saurat at biblibre.com
           Summary: Patron stats, patron activity : no active doesn't ork
          Severity: minor
    Classification: Unclassified
                OS: All
          Reporter: adrien.saurat at biblibre.com
          Hardware: All
            Status: ASSIGNED
           Version: master
         Component: Reports
           Product: Koha

MT9357

In "Home ? Reports ? Patrons statistics", for the Patron activity, the "no
active" choice doesn't work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 14:07:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 12:07:12 +0000
Subject: [Koha-bugs] [Bug 8307] New: Set a value for items when receiving
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8307
          Assignee: koha-bugs at lists.koha-community.org
           Summary: Set a value for items when receiving
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: jonathan.druart at biblibre.com
          Hardware: All
            Status: NEW
           Version: unspecified
         Component: Acquisitions
           Product: Koha

If the system preference AcqCreateItem is "Create an item when ordering", we
would like to set a value for items.
For example you could define status for the field items.notforloan (995$o for
UNIMARC) with 4 = On order, 5: On treatment.
Then, it would be great to fill the item field 995$o with "5".

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 14:07:27 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 12:07:27 +0000
Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|koha-bugs at lists.koha-commun |jonathan.druart at biblibre.co
                   |ity.org                     |m

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 14:35:10 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 12:35:10 +0000
Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307

--- Comment #1 from Jonathan Druart  ---
Created attachment 10472
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10472&action=edit
Bug 8307: Set a value for items when ordering


    If items are created when ordering, this patch allows to add a value for
    a field.

    Test plan:
    Define status for items.notforloan (mapping 995$o in unimarc), for
    example 4:On order, 5:On treatment

    Set the Syspref AcqCreateItem on "ordering".

    ACQ framework : set default value = 4 for 995$o (in unimarc)

    Syspref AcqItemStatusWhenReceived : set "995$o=5"

    When ordering the item, default status will be 4 ; when receiving the
    item, status will be changed from 4 to 5

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 14:35:18 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 12:35:18 +0000
Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 14:37:53 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 12:37:53 +0000
Subject: [Koha-bugs] [Bug 8308] New: can't print transfer slip twice
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8308

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8308
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
          Assignee: koha-bugs at lists.koha-community.org
           Summary: can't print transfer slip twice
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: nengard at gmail.com
          Hardware: All
            Status: NEW
           Version: master
         Component: Circulation
           Product: Koha

We have discovered that we can't print a route/transfer slip for an item if
we've triggered it twice already.  This is a problem.  It should give us the
option to print the slip again, no matter how many times we've checked it in.

Is there a reason it stops giving us the option after 2 scans?

We discovered this because we were triggering holds, but slips were not
printing.  It wasn't until after the second attempt we discovered someone
rerouted printing to a regular printer.  When we set printing back to the
regular receipt printer, we couldn't trigger the hold again and print a slip. 
Instead it just looks like a regular discharge and says not checked out.

See: http://screencast.com/t/kMBcHKq8F7EZ

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 15:04:18 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 13:04:18 +0000
Subject: [Koha-bugs] [Bug 8309] New: Koha namespace organisation,
	first implementation
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8309

          Priority: P1 - high
 Change sponsored?: ---
            Bug ID: 8309
          Assignee: paul.poulain at biblibre.com
           Summary: Koha namespace organisation, first implementation
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: paul.poulain at biblibre.com
          Hardware: All
            Status: ASSIGNED
           Version: master
         Component: Architecture, internals, and plumbing
           Product: Koha

During KohaCon12 hackfest, some of us had a discussion about Koha namespace
organisation and content. The result was a wiki page:
http://wiki.koha-community.org/wiki/Koha_Namespace_RFC

I've investigated this organisation by writing some DBIx::Class & Moose
packages. The results are great, a lot of code can be removed, and the code is
safer. Note that the patches attached here are just a first draft, not
requesting sign-off, just comments !

My feedback of this first try:
 * defining the schema has been easy, thanks to DBIx::Class documentation.
Error messages are very clear and easy to understand for a newbie like me !
 * investigating a little bit more, there are many tools/tricks that will make
us save a lot of time/lines. Like caching (with DBIx::Class::Cursor::Cached),
paging (see
http://search.cpan.org/~arodland/DBIx-Class-0.08196/lib/DBIx/Class/Manual/Cookbook.pod#Paged_results,
not used in this 1st POC), doing JOIN or finding relations between datas, or
returning array of hashrefs (DBIx::Class::ResultClass::HashRefInflator)
 * cleaning categories.pl resulted in a code that is *much* smaller and
readable than the previous one (something like 100 lines removed)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 15:04:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 13:04:59 +0000
Subject: [Koha-bugs] [Bug 8309] Koha namespace organisation,
	first implementation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8309

--- Comment #1 from Paul Poulain  ---
Created attachment 10473
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10473&action=edit
DBIx::Class 1st step: the schema

This DBIx::Class schema has been generated using
perl -MDBIx::Class::Schema::Loader=make_schema_at,dump_to_dir:.Koha -e
'make_schema_at("temp::Schema", { debug => 1 }, [
"dbi:mysql:dbname=Koha","LOGIN", "PASSWORD" ])'

After my 1st tests, I encountered the following problem
DBIx::Class::Carp::__ANON__(): "might_have/has_one" must not be on columns with
is_nullable set to true (temp::Schema::Result::Borrower/cardnumber). This might
indicate an incorrect use of those relationship helpers instead of belongs_to.
at /usr/share/perl5/DBIx/Class/Relationship/HasOne.pm line 96
by setting cardnumber to non-nullable

I've switched the cardnumber to non-nullable in Borrower.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 15:05:40 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 13:05:40 +0000
Subject: [Koha-bugs] [Bug 8309] Koha namespace organisation,
	first implementation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8309

--- Comment #2 from Paul Poulain  ---
Created attachment 10474
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10474&action=edit
Branches table management

it's called Branch2.pm because I tried another organisation, then switched to
this one, which is better I think

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 15:05:42 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 13:05:42 +0000
Subject: [Koha-bugs] [Bug 8309] Koha namespace organisation,
	first implementation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8309

--- Comment #3 from Paul Poulain  ---
Created attachment 10475
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10475&action=edit
Borrowers table management

first draft, the interesting part is the testrelation.pl script that shows how
to search a patron and access other informations from here

What is important is the "prefetch" option in read. With it you'll LEFT join
the prefetched table, thus improving performances

You can also notice the cache duration of 2 seconds in borrower search. The
idea is that, if this sub is called more than once on a given page, there will
be only one SQL query.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 15:05:43 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 13:05:43 +0000
Subject: [Koha-bugs] [Bug 8309] Koha namespace organisation,
	first implementation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8309

--- Comment #4 from Paul Poulain  ---
Created attachment 10476
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10476&action=edit
Branchrelation package, 1st draft

unused in my tests I think, commiting it just in case

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 15:05:45 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 13:05:45 +0000
Subject: [Koha-bugs] [Bug 8309] Koha namespace organisation,
	first implementation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8309

--- Comment #5 from Paul Poulain  ---
Created attachment 10477
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10477&action=edit
Categories management

This package is a POC to manage the Categories table. It contains :
* Category.pm (DB, DataObject and BusinessLogic levels)
* the Category.t test
* categorie.pl DBIx::Classed
  * updating copyright
  * removing a lot of useless files
  * tabs replaced by 4 spaces, result in some minor changes
  * use [% IF condition %] in templates, to avoid some pl level hacks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 15:06:17 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 13:06:17 +0000
Subject: [Koha-bugs] [Bug 8309] Koha namespace organisation,
	first implementation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8309

--- Comment #6 from Paul Poulain  ---
Created attachment 10478
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10478&action=edit
DBIx::Class Branch.pm, first try

This package, and the test implement CRUD for Branches table.
Very basic, but proves we can do many things in a few lines !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 15:11:20 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 13:11:20 +0000
Subject: [Koha-bugs] [Bug 8309] Koha namespace organisation,
	first implementation
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8309

--- Comment #7 from Paul Poulain  ---
mmm... patches not in the historical order, sorry.
I made patch 6 (Branch.pm first try) first, then Branches table management
(Branch2.pm).
To explain : I made some experiments on Branch.pm, then tried something else I
called Branch2.pm
Branch2.pm seems better, so if we decide to go this way, the original Branch.pm
will be dropped and Branch2.pm renamed. As it's just a POC, that's not a big
deal I think.

In fact, the most important part is the testrelation.pl attached in "Borrowers
table management" and Categories management, that include admin/categorie.pl
rewritten

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 15:14:46 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 13:14:46 +0000
Subject: [Koha-bugs] [Bug 8240] There is dead code in orderreceive.tt
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8240

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #3 from M. de Rooy  ---
CONFLICT (content): Merge conflict in acqui/orderreceive.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 15:16:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 13:16:25 +0000
Subject: [Koha-bugs] [Bug 7161] Open Library - Larger image, Read,
 borrow and checked-out status
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|rel_3_10                    |master
         QA Contact|koha.sekjal at gmail.com       |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 15:35:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 13:35:04 +0000
Subject: [Koha-bugs] [Bug 7161] Open Library - Larger image, Read,
 borrow and checked-out status
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161

--- Comment #9 from M. de Rooy  ---
(In reply to comment #8)
> Marcel, you already made a 1st QA, so I let this one for you. Looking at the
> code I don't see anything wrong

Will be looking at this shortly..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 15:46:54 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 13:46:54 +0000
Subject: [Koha-bugs] [Bug 8240] There is dead code in orderreceive.tt
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8240

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10329|0                           |1
        is obsolete|                            |

--- Comment #4 from Jonathan Druart  ---
Created attachment 10479
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10479&action=edit
[SIGNED-OFF] Bug 8240: Remove dead code from orderreceive

rebased patch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 15:57:57 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 13:57:57 +0000
Subject: [Koha-bugs] [Bug 8310] New: All parts an instance should be under
	one path
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8310

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8310
                CC: robin at catalyst.net.nz
          Assignee: koha-bugs at lists.koha-community.org
           Summary: All parts an instance should be under one path
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: ddean at njstatelib.org
          Hardware: All
            Status: NEW
           Version: unspecified
         Component: Packaging
           Product: Koha

For mobility and to potentially enable chroot down the line, the directories
now created under /etc/koha/sites and /var/(spool|lib|lock|run|log)/koha should
be created under a common directory.

I'd be happy to contribute a patch if a good common path can be found.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:04:00 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 14:04:00 +0000
Subject: [Koha-bugs] [Bug 8310] All parts an instance should be under one
	path
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8310

--- Comment #1 from Robin Sheat  ---
I'm not convinced that debian would let us get away with that. Also, /etc and
/var are the appropriate places for what goes into them. 

This said, it wouldn't be the end of the world to symlink them together, so
they still appear like they are now, but everything is really under
/var/lib/koha.

Additionally, it would only really need to be /var/lib/koha, all the rest are
transient data.

Not completely sold on the need for it vs. the additional complexity though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:16:05 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 14:16:05 +0000
Subject: [Koha-bugs] [Bug 8289] Upgrading from 2.2 does not work anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8289

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:16:31 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 14:16:31 +0000
Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr
 without breaking anything else
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233

--- Comment #20 from Ian Walls  ---
QA comments have been addressed in followup patches, thank you!

One additional issue not caught by earlier scans:  the new modules introduce
dependencies on Moose (and sub-modules), Test::MockModule and Data::Pagination,
none of which are found on my default install.  These dependencies will need to
be added to koha_perl_deps.pl and the Debian packages lists (assuming they are
indeed packaged).

Please provide this additional followup, and then we should safe to push this
to master, and debug further from there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:17:56 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 14:17:56 +0000
Subject: [Koha-bugs] [Bug 6513] Library and Category filters when searching
 for a borrower to add to a routing list don't work correctly.
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6513

--- Comment #7 from Robin Sheat  ---
It would make the most sense for this to be modified to use existing patron
search stuff, if it's possible for that to have filters too (or, we could apply
the filters post-hoc I guess.)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:21:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 14:21:33 +0000
Subject: [Koha-bugs] [Bug 8282] Bug in modules list in about.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8282

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:23:20 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 14:23:20 +0000
Subject: [Koha-bugs] [Bug 8241] Remove stray references to YUI autocomplete
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8241

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_10

--- Comment #5 from Paul Poulain  ---
Proably worth for 3.10 only, but would not object backporting to 3.8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:32:43 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 14:32:43 +0000
Subject: [Koha-bugs] [Bug 8224] aqplan.pl and aqbudgets: authorized values
 doesn't appear in planning list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8224

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:35:52 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 14:35:52 +0000
Subject: [Koha-bugs] [Bug 5349] Moving an order
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349

--- Comment #18 from Marc V?ron  ---
Both patches applied.

I get the same result as the screenshots show in the PDF attachment:
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10441

At the end of koha-error_log I get a couple of following lines:

(...)[Mon Jun 25 16:20:59 2012] transferorder.pl: Use of uninitialized value in
pattern match (m//) at /usr/share/kohaclone/C4/SQLHelper.pm line 407.

Additional info:

I tried with Firefox, Firefox  with all plugins disabled and with Chrome.

Could it be a database issue (corrupted data in order tables)? I'm afraid I
have no time to puzzle this out right now, that's why I propose that somebody
else does a test as well.

Marc

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:40:05 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 14:40:05 +0000
Subject: [Koha-bugs] [Bug 7379] copynumber is displayed 'as is' when linked
 to autorised values
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7379

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_8

--- Comment #25 from Paul Poulain  ---
Patch pushed, signoff from Gaetan reintroduced

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 16:56:21 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 14:56:21 +0000
Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr
 without breaking anything else
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233

--- Comment #21 from Jonathan Druart  ---
Hi Ian, 

I don't know if we want to add all solr's dependencies for koha currently.

If I add Data::Pagination, I would have to add all of dependencies listed on
http://wiki.koha-community.org/wiki/SearchEngine_Layer_RFC#Install_perl_libs.

And I think it is not what we want for Zebra's installations, isn't it ?

Maybe we want a test in C4::Installer::PerlDependencies to distinguish the
search engine ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:00:13 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 15:00:13 +0000
Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr
 without breaking anything else
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233

--- Comment #22 from Ian Walls  ---
The dependencies can be marked as optional and for what purpose, so if folks
don't want to install them, they don't need to.

A more complex set up of looking install options and picking dependencies based
on that would be nice, but probably more work than we need right now, with our
level of available customization.  But, say when Koha is RDBMS-agnostic, then
we may find it handy to have different dependency paths in the scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:19:20 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 15:19:20 +0000
Subject: [Koha-bugs] [Bug 8233] New search engine layer - introduce solr
 without breaking anything else
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8233

--- Comment #23 from Jonathan Druart  ---
Created attachment 10480
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10480&action=edit
Bug 8233: Followup: Search engine layer: Add dependencies.

(In reply to comment #22)
> The dependencies can be marked as optional and for what purpose, so if folks
> don't want to install them, they don't need to.

Yes, you are right :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:53:11 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 15:53:11 +0000
Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557

--- Comment #24 from Paul Poulain  ---
I can't decide myself to push this patch. Let me share my comments:
 * it add a syspref to decide wether we should update this field through a cron
or in real time. The FAUSP (Fighters Against Useless SysPrefs) commitee has
some concern: if it's long to do, who will set this syspref to 1 ? Small
libraries have a low-grade hardware, large libraries circulate a lot. My
conclusion is that noone will set the syspref to 1. So the syspref could/should
be removed.
 * OTOH, the UpdateTotalIssues sub uses ModBiblio. It appears that it's because
the popularity sorting is based on 942$0 field. that's why it's so long & I
can't see another method to populate this field. 
 * In UNIMARC default setup, the totalissue field is attached to 942$0 like in
MARC21. Quite surprising according to me, but not wrong afaik
 * The install documentation should be updated to reflect the
misc/cronjobs/update_totalissues.pl (can be done later. Having crontab.example
updated is a good 1st step)

Please comment my point 1 (2, 3 and 4 are just here as a reminder, even if 4
will require a follow-up or another bugzilla entry)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:54:50 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 15:54:50 +0000
Subject: [Koha-bugs] [Bug 8194] Layout problem on subscription add when
 showing manual history
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8194

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:58:10 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 15:58:10 +0000
Subject: [Koha-bugs] [Bug 6090] empty mails in message_queue are sent
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6090

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 17:59:43 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 15:59:43 +0000
Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10458|0                           |1
        is obsolete|                            |

--- Comment #26 from Paul Poulain  ---
Comment on attachment 10458
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10458
Bug 7368 - General staff client typo omnibus

This patch has been pushed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 18:00:03 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 16:00:03 +0000
Subject: [Koha-bugs] [Bug 7368] General staff client typo omnibus
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7368

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |ASSIGNED

--- Comment #27 from Paul Poulain  ---
all patches pushed, back to assigned

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 18:01:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 16:01:33 +0000
Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557

--- Comment #25 from Jared Camins-Esakov  ---
Paul,

(In reply to comment #24)
> I can't decide myself to push this patch. Let me share my comments:
>  * it add a syspref to decide wether we should update this field through a
> cron or in real time. The FAUSP (Fighters Against Useless SysPrefs) commitee
> has some concern: if it's long to do, who will set this syspref to 1 ? Small
> libraries have a low-grade hardware, large libraries circulate a lot. My
> conclusion is that noone will set the syspref to 1. So the syspref
> could/should be removed.

I think it is worth having the syspref and the option for realtime update for
two reasons:
1. in the future performance may improve, and this is definitely a feature that
people might want. By including the syspref now, we forestall the requests that
it be added.
2. For very small libraries, setting up a cron job can be a significant
hardship, and if you're circulating one item per minute on average, the
performance hit from realtime updating doesn't really matter.
3. (I'm like the Spanish inquisition, with fear, surprise, and ruthless
efficiency... can I start over?) Although I consider the performance hit to be
significant, the fact is we're not looking at an operation any more inefficient
than checking out any item was in 3.2.

>  * OTOH, the UpdateTotalIssues sub uses ModBiblio. It appears that it's
> because the popularity sorting is based on 942$0 field. that's why it's so
> long & I can't see another method to populate this field. 
>  * In UNIMARC default setup, the totalissue field is attached to 942$0 like
> in MARC21. Quite surprising according to me, but not wrong afaik

I noticed that. And was baffled by it. But I figure, if it ain't broke...

>  * The install documentation should be updated to reflect the
> misc/cronjobs/update_totalissues.pl (can be done later. Having
> crontab.example updated is a good 1st step)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 18:01:50 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 16:01:50 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10402|0                           |1
        is obsolete|                            |

--- Comment #41 from Paul Poulain  ---
Comment on attachment 10402
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10402
[SIGNED-OFF] 7143 Followup for timeline

this patch has been pushed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 18:04:47 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 16:04:47 +0000
Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244

--- Comment #5 from Jared Camins-Esakov  ---
It looks good, except for one thing. When I run `prove xt` it does not get
caught since the extension is .pl unstead of .t. Perhaps it would be better to
call it find-undefined-subroutines.t?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 18:06:23 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 16:06:23 +0000
Subject: [Koha-bugs] [Bug 8311] New: Mis-scoped function call in C4::Auth
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8311

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8311
          Assignee: jcamins at cpbibliography.com
           Summary: Mis-scoped function call in C4::Auth
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: jcamins at cpbibliography.com
          Hardware: All
            Status: NEW
           Version: master
         Component: Architecture, internals, and plumbing
           Product: Koha

There is a mis-scoped function call in C4::Auth, on line 154, where GetMembers
is called without explicit scoping and before 'require C4::Members;'. This does
not actually have any functional ramifications as far as I can tell, but it
would be a good idea to fix it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 18:09:34 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 16:09:34 +0000
Subject: [Koha-bugs] [Bug 8311] Mis-scoped function call in C4::Auth
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8311

--- Comment #1 from Jared Camins-Esakov  ---
Created attachment 10481
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10481&action=edit
Bug 8311: Fix scoping error in C4::Auth

There is a mis-scoped function call in C4::Auth, on line 154, where
GetMembers is called without explicit scoping and before
'require C4::Members;'. This does not actually have any functional
ramifications as far as I can tell, but it would be a good idea to fix
it.

This patch also corrects a bit of indenting in that area, because it was
an unnecessary challenge to understand the code with the mis-indenting.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 18:09:46 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 16:09:46 +0000
Subject: [Koha-bugs] [Bug 8311] Mis-scoped function call in C4::Auth
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8311

Jared Camins-Esakov  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 18:11:08 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 16:11:08 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 18:12:16 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 16:12:16 +0000
Subject: [Koha-bugs] [Bug 8255] Local cover images should be cacheable
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8255

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_8
           Severity|enhancement                 |normal

--- Comment #5 from Paul Poulain  ---
This can be considered as a bugfix imo (chris_c, your final cut, as usual)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 18:18:14 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 16:18:14 +0000
Subject: [Koha-bugs] [Bug 8288] showmarc.tt should not include full
	doc-head-close.inc
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |koha.sekjal at gmail.com

--- Comment #3 from Ian Walls  ---
Template only change to remove unnecessary code loading in the showmarc.tt
context.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 18:19:30 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 16:19:30 +0000
Subject: [Koha-bugs] [Bug 8279] CAS Debugging improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8279

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |koha.sekjal at gmail.com

--- Comment #3 from Ian Walls  ---
Just adds more verbose debugging output in the case of a CAS failure.  No other
impact on the system.  Marking Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 18:22:49 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 16:22:49 +0000
Subject: [Koha-bugs] [Bug 8205] Should be possible to hide unused
	authorities in OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205

--- Comment #10 from Paul Poulain  ---
(In reply to comment #8)
> I have been pondering this... but feel it's not ok to change existing
> behaviour - some libraries might like it. And maybe with hierarchical
> authorities it makes sense to see unused authorities too?

Well, I can't imagine a use-case where a OPAC-use might like it ! Even with
hierarchical authorities, because the links are built on authid, and if no
biblio use this authid, there won't be any results for someone that clic on the
link. 

The more I think of it, the more I think it's a bug...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 18:23:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 16:23:59 +0000
Subject: [Koha-bugs] [Bug 8191] New value for 8 position in coded data field
 100 in unimarc
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8191

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|unspecified                 |rel_3_10

--- Comment #5 from Paul Poulain  ---
could be backported to 3.8 I think

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 18:29:03 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 16:29:03 +0000
Subject: [Koha-bugs] [Bug 8181] Replace DynArch calendar widget with
	jQueryUI version
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8181

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_10

--- Comment #12 from Paul Poulain  ---
Could not confirm that every page work fine, but could not find anything wrong
either. Patch pushed, i'll advertise this change in my next monthly RM
newsletter

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 18:30:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 16:30:12 +0000
Subject: [Koha-bugs] [Bug 8205] Should be possible to hide unused
	authorities in OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205

--- Comment #11 from Ian Walls  ---
Lots of other information and links to other places on the web could be put
into an Authority record, even if no biblios are connected to it.  It'd be much
like a biblio with no attached items, but a valid URL (856 in MARC21) or
Analytic entry.

I recommend keeping a system preference to let the library pick whether to hide
unlinked authorities or not.  While many libraries may choose to hide unused
authorities, I don't think we should assume that none would like to show them.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:13:55 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 17:13:55 +0000
Subject: [Koha-bugs] [Bug 8312] New: Bug 1633 causes an error when upgrading
	the database
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8312

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8312
          Assignee: oleonard at myacpl.org
           Summary: Bug 1633 causes an error when upgrading the database
          Severity: major
    Classification: Unclassified
                OS: All
          Reporter: robin at catalyst.net.nz
          Hardware: All
            Status: NEW
           Version: rel_3_8
         Component: OPAC
           Product: Koha

This causes an error on upgrade:

[Tue Jun 26 04:58:51 2012] updatedatabase.pl: DBD::mysql::db do failed: Can't
create table 'koha_central.biblioimages' (errno: 150) at
/home/robin/kohaclones/ca/installer/data/mysql/updatedatabase.pl line 4634.

This SQL:

       CREATE TABLE `biblioimages` (
          `imagenumber` int(11) NOT NULL AUTO_INCREMENT,
          `biblionumber` int(11) NOT NULL,
          `mimetype` varchar(15) NOT NULL,      
          `imagefile` mediumblob NOT NULL, 
          `thumbnail` mediumblob NOT NULL,
          PRIMARY KEY (`imagenumber`),
          CONSTRAINT `bibliocoverimage_fk1` FOREIGN KEY (`biblionumber`)
REFERENCES `biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE CASCADE
          ) ENGINE=InnoDB DEFAULT CHARSET=utf8

doesn't work unless everything after 'ENGINE' is ommitted.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:14:21 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 17:14:21 +0000
Subject: [Koha-bugs] [Bug 8312] Bug 1633 causes an error when upgrading the
	database
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8312

Robin Sheat  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |1633

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:14:21 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 17:14:21 +0000
Subject: [Koha-bugs] [Bug 1633] Add ability to take book cover images from
	local img db
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633

Robin Sheat  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |8312

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:14:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 17:14:33 +0000
Subject: [Koha-bugs] [Bug 8313] New: add ASHS to 'Koha team' page,
 for sponsorship of the 'star-ratings' feature
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8313

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8313
          Assignee: nengard at gmail.com
           Summary: add ASHS to 'Koha team' page, for sponsorship of the
                    'star-ratings' feature
          Severity: trivial
    Classification: Unclassified
                OS: All
          Reporter: mtj at kohaaloha.com
          Hardware: All
            Status: NEW
           Version: master
         Component: About
           Product: Koha

add ASHS to 'Koha team' page, for sponsorship of the 'star-ratings' feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:18:09 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 17:18:09 +0000
Subject: [Koha-bugs] [Bug 8313] add ASHS to 'Koha team' page,
 for sponsorship of the 'star-ratings' feature
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8313

--- Comment #1 from Mason James  ---
Created attachment 10482
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10482&action=edit
Bug 8313 - add ASHS to 'Koha team' page, for sponsorship of the 'star-ratings'
feature

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:18:30 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 17:18:30 +0000
Subject: [Koha-bugs] [Bug 8313] add ASHS to 'Koha team' page,
 for sponsorship of the 'star-ratings' feature
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8313

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:20:27 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 17:20:27 +0000
Subject: [Koha-bugs] [Bug 8312] Bug 1633 causes an error when upgrading the
	database
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8312

--- Comment #1 from Robin Sheat  ---
This seems to be because the biblio table on my database is MyISAM, and so
forcing it to InnoDB causes breakage.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:36:43 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 17:36:43 +0000
Subject: [Koha-bugs] [Bug 8312] Bug 1633 causes an error when upgrading the
	database
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8312

Robin Sheat  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Robin Sheat  ---
This appears to be a problem at my end, rather than with koha. Cancelling.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 19:57:01 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 17:57:01 +0000
Subject: [Koha-bugs] [Bug 6939] DefaultClassificationSource not used in 942$2
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6939

Ian Walls  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #3 from Ian Walls  ---
Simple fix to logic, easy to read, marking Passed QA.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 22:59:07 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 20:59:07 +0000
Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of
 bibliographic records
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #36 from Chris Cormack  ---
I'm going to pull this back into 3.8.x now, it is a no risk change, that does
nothing unless you specifically enable it. 

It's bordering on more of a bug fix than an enhancement as it fixes some fairly
serious bugs in searching. So I want to let libraries take advantage of it if
they wish.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 23:23:06 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 21:23:06 +0000
Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of
 bibliographic records
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
            Version|rel_3_10                    |rel_3_8

--- Comment #37 from Chris Cormack  ---
Pushed to 3.8.x, contains no database changes and makes no changes to anything
on upgrade. But allows new libraries to use DOM indexing for biblios, or
existing libraries to choose to upgrade to it.

Searching works well, indexing is fast. Will be in 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 23:35:13 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 21:35:13 +0000
Subject: [Koha-bugs] [Bug 8289] Upgrading from 2.2 does not work anymore
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8289

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #4 from Chris Cormack  ---
Simple but useful change, pushing to 3.8.x will be in 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Mon Jun 25 23:38:39 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 21:38:39 +0000
Subject: [Koha-bugs] [Bug 8282] Bug in modules list in about.pl
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8282

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #5 from Chris Cormack  ---
Pushed to 3.8.x, will be in 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 00:00:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 22:00:33 +0000
Subject: [Koha-bugs] [Bug 8224] aqplan.pl and aqbudgets: authorized values
 doesn't appear in planning list
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8224

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #4 from Chris Cormack  ---
Bugfix, pushed to 3.8.x, will be in 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 01:44:13 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Mon, 25 Jun 2012 23:44:13 +0000
Subject: [Koha-bugs] [Bug 8194] Layout problem on subscription add when
 showing manual history
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8194

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #6 from Chris Cormack  ---
Pushed to 3.8.x will be in 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 03:30:03 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 01:30:03 +0000
Subject: [Koha-bugs] [Bug 8312] Bug 1633 causes an error when upgrading the
	database
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8312

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #3 from Chris Cormack  ---
Also in older mysql, it was TYPE=InnoDB, and in later ENGINE=InnoDB

Just in case that was the issue

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 03:32:37 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 01:32:37 +0000
Subject: [Koha-bugs] [Bug 8313] add ASHS to 'Koha team' page,
 for sponsorship of the 'star-ratings' feature
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8313

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=7143
         Depends on|                            |7143

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 03:32:37 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 01:32:37 +0000
Subject: [Koha-bugs] [Bug 7143] Bug for tracking changes to the about page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |8313
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=8313

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 03:38:02 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 01:38:02 +0000
Subject: [Koha-bugs] [Bug 8255] Local cover images should be cacheable
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8255

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #6 from Chris Cormack  ---
Pushed to 3.8.x, will be in 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 03:41:16 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 01:41:16 +0000
Subject: [Koha-bugs] [Bug 8191] New value for 8 position in coded data field
 100 in unimarc
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8191

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz
            Version|rel_3_10                    |rel_3_8
           Severity|enhancement                 |minor

--- Comment #6 from Chris Cormack  ---
Switching to bugfix, since after July without this, we would be creating
invalid unimarc records.

So it will go out in 3.8.3 (July 22)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 03:55:10 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 01:55:10 +0000
Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of
 bibliographic records
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818

--- Comment #38 from Chris Cormack  ---
We now need a patch to fix the packaging.

dh_install: etc/koha/zebradb/zebra-biblios-dom.cfg exists in debian/tmp but is
not installed to anywhere

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 05:02:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 03:02:25 +0000
Subject: [Koha-bugs] [Bug 8314] New: Missing MARCISBNS param in
	opac-detail.pl
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8314

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8314
          Assignee: oleonard at myacpl.org
           Summary: Missing MARCISBNS param in opac-detail.pl
          Severity: minor
    Classification: Unclassified
                OS: All
          Reporter: dcook at prosentient.com.au
          Hardware: All
            Status: NEW
           Version: master
         Component: OPAC
           Product: Koha

The function is executed in opac-detail.pl from Biblio.pm, but the param never
gets passed to opac-detail.tt, which asks for MARCISBNS before normalized_isbn.

The lack of this parameter means that only the 1st ISBN is ever shown. The
other ISBNs are suppressed. 

Just need to add "MARCISBNS => $marcisbnsarray," to opac-detail.pl around line
588.

I would do this, but I'm embroiled in trying to get our first fully functional
local version of 3.8 up and running.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 05:46:18 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 03:46:18 +0000
Subject: [Koha-bugs] [Bug 8315] New: fix 'C4::Output 3.02' errors in Koha
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8315
          Assignee: gmcharlt at gmail.com
           Summary: fix 'C4::Output 3.02' errors in Koha
          Severity: major
    Classification: Unclassified
                OS: All
          Reporter: mtj at kohaaloha.com
          Hardware: All
            Status: NEW
           Version: master
         Component: Architecture, internals, and plumbing
           Product: Koha

some lines in Koha have a hardcode version, like this...

use C4::Output 3.02

which cause a version-mismatch error, like this...

C4::Output version 3.02 required--this is only version 3.07.00.049 at review.pl
line 33

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 06:00:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 04:00:12 +0000
Subject: [Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315

--- Comment #1 from Mason James  ---
Created attachment 10483
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10483&action=edit
Bug 8315 - fix 'C4::Output 3.02' errors in Koha

modified:   opac/opac-ratings-ajax.pl
    modified:   opac/opac-tags.pl
    modified:   tags/review.pl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 06:00:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 04:00:33 +0000
Subject: [Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 06:03:50 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 04:03:50 +0000
Subject: [Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315

--- Comment #2 from Mason James  ---
(In reply to comment #1)
> Created attachment 10483 [details]
> Bug 8315 - fix 'C4::Output 3.02' errors in Koha


i've sent a patch that removes the unneeded '3.02' part

only 3 lines are changed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 06:08:01 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 04:08:01 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #87 from Mason James  ---
Created attachment 10484
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10484&action=edit
Bug 6679 - fixing 23 '"return" statement with explicit "undef"' violations in
C4/Tags.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 06:08:28 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 04:08:28 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

Mason James  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 06:16:19 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 04:16:19 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #88 from Mason James  ---
Created attachment 10485
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10485&action=edit
Bug 6679 - fix 19 perlcritic violations from C4::Letters.pm

"return" statement with explicit "undef" at line 979, column 28.  See page 199
of PBP.  (Severity: 5)

Subroutine prototypes used at line 997, column 1.  See page 194 of PBP. 
(Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 06:40:30 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 04:40:30 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #89 from Mason James  ---
Created attachment 10486
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10486&action=edit
fix 15 perlcritic violations in C4/ImportExportFramework.pm

Bareword file handle opened at line 558, column 17.  See pages 202,204 of PBP. 
(Severity: 5)

Two-argument "open" used at line 558, column 17.  See page 207 of PBP. 
(Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 14:08:45 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 12:08:45 +0000
Subject: [Koha-bugs] [Bug 5349] Moving an order
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349

--- Comment #19 from Marc V?ron  ---
I spent some time to find out what happens.

It seems that the popup functionality is implemented with the JavaScript
function transfer_order_popup() in 
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt

but it is *not* implemented in

koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
(this is the place where I tested, see the first page in my screenshots 
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10441 )

Marc

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 14:36:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 12:36:33 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #90 from Mason James  ---
Created attachment 10487
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10487&action=edit
Bug 6679 - fix 12 perlcritic violations in C4/Context.pm

"return" statement with explicit "undef" at line 486, column 5.  See page 199
of PBP.  (Severity: 5)

Subroutine prototypes used at line 548, column 1.  See page 194 of PBP. 
(Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 14:40:01 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 12:40:01 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #91 from Mason James  ---
Created attachment 10488
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10488&action=edit
Bug 6679 - fix 12 perlcritic violations in C4/Auth_with_ldap.pm

Subroutine prototypes used at line 73, column 1.  See page 194 of PBP. 
(Severity: 5)

"return" statement with explicit "undef" at line 74, column 24.  See page 199
of PBP.  (Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 14:44:11 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 12:44:11 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #92 from Mason James  ---
Created attachment 10489
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10489&action=edit
Bug 6679 - fix 12 perlcritic violations in C4/External/BakerTaylor.pm

Subroutine prototypes used at line 82, column 1.  See page 194 of PBP. 
(Severity: 5)

"return" statement with explicit "undef" at line 83, column 22.  See page 199
of PBP.  (Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:03:10 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:03:10 +0000
Subject: [Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315

--- Comment #3 from Robin Sheat  ---
Created attachment 10490
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10490&action=edit
Bug 8315 - fix 'C4::Output 3.02' errors in Koha

modified:   opac/opac-ratings-ajax.pl
    modified:   opac/opac-tags.pl
    modified:   tags/review.pl

Signed-off-by: Robin Sheat 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:04:08 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:04:08 +0000
Subject: [Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315

Robin Sheat  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |robin at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:07:30 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:07:30 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #93 from Mason James  ---
Created attachment 10491
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10491&action=edit
Bug 6679 - fix 11 perlcritic violations in C4/Dates.pm

- Subroutine prototypes used at line 82, column 1.  See page 194 of PBP. 
(Severity: 5)

- "return" statement with explicit "undef" at line 102, column 28.  See page
199 of PBP.  (Severity: 5)

- Expression form of "eval" at line 108, column 20.  See page 161 of PBP. 
(Severity: 5)

- Variable declared in conditional statement at line 126, column 5.  Declare
variables outside of the condition.  (Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:08:07 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:08:07 +0000
Subject: [Koha-bugs] [Bug 5349] Moving an order
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5349

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Failed QA

--- Comment #20 from Julian Maurice  ---
Ok, I mark it as 'failed QA' and will resubmit a patch soon ;)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:09:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:09:24 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #94 from Mason James  ---
Created attachment 10492
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10492&action=edit
Bug 6679 - fix 9 perlcritic violations in C4/TmplTokenType.pm

- Subroutine prototypes used at line 86, column 1.  See page 194 of PBP. 
(Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:12:45 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:12:45 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #95 from Mason James  ---
Created attachment 10493
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10493&action=edit
Bug 6679 - fix 9 perlcritic violations in C4/Koha.pm

- Subroutine prototypes used at line 115, column 1.  See page 194 of PBP. 
(Severity: 5)

- "return" statement with explicit "undef" at line 1112, column 4.  See page
199 of PBP.  (Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:13:20 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:13:20 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10489|0                           |1
        is obsolete|                            |

--- Comment #96 from Jonathan Druart  ---
Created attachment 10494
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10494&action=edit
Bug 6679 - fix 12 perlcritic violations in C4/External/BakerTaylor.pm

Subroutine prototypes used at line 82, column 1.  See page 194 of PBP. 
(Severity: 5)

"return" statement with explicit "undef" at line 83, column 22.  See page 199
of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:14:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:14:12 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10488|0                           |1
        is obsolete|                            |

--- Comment #97 from Jonathan Druart  ---
Created attachment 10495
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10495&action=edit
Bug 6679 - [SIGNED-OFF] fix 12 perlcritic violations in C4/Auth_with_ldap.pm

Subroutine prototypes used at line 73, column 1.  See page 194 of PBP. 
(Severity: 5)

"return" statement with explicit "undef" at line 74, column 24.  See page 199
of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:14:55 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:14:55 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10487|0                           |1
        is obsolete|                            |

--- Comment #98 from Jonathan Druart  ---
Created attachment 10496
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10496&action=edit
Bug 6679 -[SIGNED-OFF] fix 12 perlcritic violations in C4/Context.pm

"return" statement with explicit "undef" at line 486, column 5.  See page 199
of PBP.  (Severity: 5)

Subroutine prototypes used at line 548, column 1.  See page 194 of PBP. 
(Severity: 5)

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:15:42 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:15:42 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10484|0                           |1
        is obsolete|                            |

--- Comment #99 from Jonathan Druart  ---
Created attachment 10497
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10497&action=edit
Bug 6679 - [SIGNED-OFF]fixing 23 '"return" statement with explicit "undef"'
violations in C4/Tags.pm

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:15:50 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:15:50 +0000
Subject: [Koha-bugs] [Bug 8316] New: authority add form still has + and -
	and ...
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8316

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8316
          Assignee: oleonard at myacpl.org
           Summary: authority add form still has + and - and ...
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: nengard at gmail.com
               URL: cgi-bin/koha/authorities/authorities.pl?authtypecode=P
                    ERSO_NAME
          Hardware: All
            Status: NEW
           Version: master
         Component: Templates
           Product: Koha

Created attachment 10498
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10498&action=edit
authority add form

The authority add form still has the old syntax for duplicating (+),
subtracting (-) and plugins (...).  This form should probably match the
cataloging interface in terms of icons for these actions.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:16:05 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:16:05 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10494|Bug 6679 - fix 12           |Bug 6679 - [SIGNED-OFF]fix
        description|perlcritic violations in    |12 perlcritic violations in
                   |C4/External/BakerTaylor.pm  |C4/External/BakerTaylor.pm

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:19:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:19:12 +0000
Subject: [Koha-bugs] [Bug 8062] Cart email broken for non english templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062

Robin Sheat  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |robin at catalyst.net.nz

--- Comment #21 from Robin Sheat  ---
I think this patch introduces a bug:

+use HTML::FormatText;

this isn't mentioned in the dependency list, and doesn't appear to be used in
the code. Thus, opac-sendbasket.pl breaks unless you happen to have that module
installed. Can someone confirm that this is the case?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:19:29 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:19:29 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #100 from Jonathan Druart  ---
(In reply to comment #88)
> Created attachment 10485 [details]
> Bug 6679 - fix 19 perlcritic violations from C4::Letters.pm


FAILED QA for this patch, I think the following lines don't have to be
modified:
-    return unless exists $params->{'letter'};
-    return unless exists $params->{'borrowernumber'};
-    return unless exists $params->{'message_transport_type'};
+    return exists $params->{'letter'};
+    return exists $params->{'borrowernumber'};
+    return exists $params->{'message_transport_type'};

It's unless, not undef :-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:21:32 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:21:32 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #101 from Mason James  ---
Created attachment 10499
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10499&action=edit
Bug 6679 - fix 8 perlcritic violations in C4/Circulation.pm

- "return" statement with explicit "undef" at line 994, column 39.  See page
199 of PBP.  (Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:26:28 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:26:28 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #102 from Mason James  ---
Created attachment 10500
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10500&action=edit
Bug 6679 - fix 8 perlcritic violations in C4/Barcodes.pm

- "return" statement with explicit "undef" at line 57, column 2.  See page 199
of PBP.  (Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:43:49 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:43:49 +0000
Subject: [Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to
 pay fines screen if borrower has outstanding fines
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #6 from Marc V?ron  ---
Chris and Jared,

I was asked to add an additional functionality after printing: Automaticalle
clear the screen. This would be in conflict with Chris' solution.

So I think we could implement both using a more flexible approach.

I propose to drop the preference 'circpayfinesredirect'

Instead, expand the choices of 'CircAutoPrintQuickSlip' with two more options:

"open a print quick slip window and clear the screen" 
(that's what I need to have)

"open a print quick slip window and redirect to outstanding fines (if any)"
(that's what Chris needs to have)

The values then can be evaluated in circulation.tt (near the comment '// listen
submit to trigger qslip on empty checkout'). 

This can be expanded for any needs.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:44:40 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:44:40 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #103 from Mason James  ---
Created attachment 10501
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10501&action=edit
Bug 6679 - fix 7 perlcritic violations in C4/Biblio.pm

- Expression form of "eval" at line 492, column 12.  See page 161 of PBP. 
(Severity: 5)

- "return" statement with explicit "undef" at line 891, column 5.  See page 199
of PBP.  (Severity: 5)

- Subroutine prototypes used at line 1148, column 1.  See page 194 of PBP. 
(Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:51:48 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:51:48 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #104 from Mason James  ---
Created attachment 10502
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10502&action=edit
Bug 6679 - fix 6 perlcritic violations in C4/Reports/Guided.pm

- Subroutine prototypes used at line 376, column 1.  See page 194 of PBP. 
(Severity: 5)

- Bareword file handle opened at line 757, column 2.  See pages 202,204 of PBP.
 (Severity: 5)

- Two-argument "open" used at line 757, column 2.  See page 207 of PBP. 
(Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:51:55 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:51:55 +0000
Subject: [Koha-bugs] [Bug 8062] Cart email broken for non english templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062

--- Comment #22 from Robin Sheat  ---
OK, it is a dependency of Template::Plugin::HtmlToText, however that doesn't
declare it as a dependency in the META.yml, so the packages don't either, and
so it never gets installed. Guess I'll have to redo the packages some time soon
to account for that.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:52:45 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:52:45 +0000
Subject: [Koha-bugs] [Bug 3686] Hold slips sometimes don't print barcode
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3686

Albert Oller  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |ago at bywatersolutions.com
         Resolution|---                         |DUPLICATE

--- Comment #1 from Albert Oller  ---
This looks like a dupe of
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7255

*** This bug has been marked as a duplicate of bug 7255 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:52:45 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:52:45 +0000
Subject: [Koha-bugs] [Bug 7255] Information on Holds Transfer Slips is
	Inconsistent
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7255

Albert Oller  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jwagner at ptfs.com

--- Comment #7 from Albert Oller  ---
*** Bug 3686 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:54:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:54:33 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #105 from Mason James  ---
Created attachment 10503
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10503&action=edit
Bug 6679 - fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm

- Subroutine prototypes used at line 45, column 1.  See page 194 of PBP. 
(Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 15:59:53 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 13:59:53 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #106 from Mason James  ---
Created attachment 10504
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10504&action=edit
Bug 6679 - fix 5 perlcritic violations in C4/VirtualShelves.pm, and comment-out
obselete sub()

- Subroutine prototypes used at line 224, column 1.  See page 194 of PBP. 
(Severity: 5)

- "return" statement with explicit "undef" at line 354, column 22.  See page
199 of PBP.  (Severity: 5)

- Don't modify $_ in list functions at line 664, column 5.  See page 114 of
PBP.  (Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:03:35 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:03:35 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #107 from Mason James  ---
Created attachment 10505
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10505&action=edit
Bug 6679 - fix 5 perlcritic violations in C4/Serials.pm

- Subroutine prototypes used at line 161, column 1.  See page 194 of PBP. 
(Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:11:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:11:12 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #108 from Mason James  ---
Created attachment 10506
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10506&action=edit
Bug 6679 - fix 4 perlcritic violations in C4/ShelfBrowser.pm

- Variable declared in conditional statement at line 183, column 5.  Declare 
variables outside of the condition.  (Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:23:10 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:23:10 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #109 from Mason James  ---
Created attachment 10507
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10507&action=edit
Bug 6679 - fix 4 perlcritic violations in C4/Installer.pm

- Bareword file handle opened at line 157, column 13.  See pages 202,204 of
PBP.  (Severity: 5)

- I/O layer ":utf8" used at line 157, column 13.  Use ":encoding(UTF-8)" to get
strict validation.  (Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:28:42 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:28:42 +0000
Subject: [Koha-bugs] [Bug 8317] New: Cursor appears again not in Search box
	of catalogue
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8317

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8317
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
          Assignee: koha-bugs at lists.koha-community.org
           Summary: Cursor appears again not in Search box of catalogue
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: programming at tyndale.cam.ac.uk
          Hardware: All
            Status: NEW
           Version: rel_3_8
         Component: Circulation
           Product: Koha

While two bugs (3189, 5125) in the past dealt with this issue and were
resolved, now again the cursor is not in the right place. Thus when a patron in
firefox enters the catalogue, it is not directly in the only search-box on the
screen. (Tested in firefox and IE.) 

Entered for the Tyndale House library.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:29:52 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:29:52 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #110 from Mason James  ---
Created attachment 10508
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10508&action=edit
Bug 6679 - fix 4 perlcritic violations in C4/Creators/PDF.pm

- "return" statement with explicit "undef" at line 171, column 8.  See page 199
of PBP.  (Severity: 5)

- "return" statement with explicit "undef" at line 201, column 8.  See page 199
of PBP.  (Severity: 5)

- Bareword file handle opened at line 212, column 11.  See pages 202,204 of
PBP.  (Severity: 5)

- Two-argument "open" used at line 212, column 11.  See page 207 of PBP. 
(Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:31:44 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:31:44 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #111 from Mason James  ---
Created attachment 10509
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10509&action=edit
Bug 6679 - fix 4 perlcritic violations in C4/Branch.pm

Subroutine prototypes used at line 157, column 1.  See page 194 of PBP. 
(Severity: 5)
Subroutine prototypes used at line 375, column 1.  See page 194 of PBP. 
(Severity: 5)
Subroutine prototypes used at line 385, column 1.  See page 194 of PBP. 
(Severity: 5)
Subroutine prototypes used at line 418, column 1.  See page 194 of PBP. 
(Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:38:06 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:38:06 +0000
Subject: [Koha-bugs] [Bug 8318] New: update StatisticsFields description
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8318
          Assignee: nengard at gmail.com
           Summary: update StatisticsFields description
          Severity: minor
    Classification: Unclassified
                OS: All
          Reporter: nengard at gmail.com
          Hardware: All
            Status: ASSIGNED
           Version: master
         Component: Templates
        Depends on: 7955
           Product: Koha

StatisticsFields says "___ Define Fields (from the items table) used for
statistics members (separate fields with |, for
example:"location|itype|ccode")."


Originally I thought this was related to the statistical member type - so I
recommend the following language change for this preference:


"Show the following fields from the items database table as columns on the
statistics tab on the patron record:  ___ (separate fields with |)"


Patch to follow.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:38:06 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:38:06 +0000
Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |8318

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:39:53 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:39:53 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #112 from Mason James  ---
Created attachment 10510
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10510&action=edit
Bug 6679 - fix 3 perlcritic violations in C4/SQLHelper.pm

Subroutine prototypes used at line 251, column 1.  See page 194 of PBP. 
(Severity: 5)
Subroutine prototypes used at line 287, column 1.  See page 194 of PBP. 
(Severity: 5)
Subroutine prototypes used at line 317, column 1.  See page 194 of PBP. 
(Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:40:14 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:40:14 +0000
Subject: [Koha-bugs] [Bug 8318] update StatisticsFields description
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318

--- Comment #1 from Nicole C. Engard  ---
Created attachment 10511
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10511&action=edit
Bug 8318: Update StatisticsFields preference language

This patch changes around the wording of the StatisticsFields
preference to make it clearer where these values will show.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:40:41 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:40:41 +0000
Subject: [Koha-bugs] [Bug 8318] update StatisticsFields description
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:42:32 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:42:32 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #113 from Mason James  ---
Created attachment 10512
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10512&action=edit
Bug 6679 - fix 3 perlcritic violations in C4/Record.pm

Expression form of "eval" at line 358, column 5.  See page 161 of PBP. 
(Severity: 5)
Expression form of "eval" at line 367, column 5.  See page 161 of PBP. 
(Severity: 5)
Expression form of "eval" at line 510, column 3.  See page 161 of PBP. 
(Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:45:26 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:45:26 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #114 from Mason James  ---
Created attachment 10513
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10513&action=edit
Bug 6679 - fix 3 perlcritic violations in C4/Output.pm

"return" statement with explicit "undef" at line 128, column 74.  See page 199
of PBP.  (Severity: 5)
Subroutine prototypes used at line 270, column 1.  See page 194 of PBP. 
(Severity: 5)
Subroutine prototypes used at line 308, column 1.  See page 194 of PBP. 
(Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:48:37 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:48:37 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #115 from Mason James  ---
Created attachment 10514
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10514&action=edit
Bug 6679 - fix 3 perlcritic violations in C4/Message.pm

"return" statement with explicit "undef" at line 109, column 9.  See page 199
of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 145, column 9.  See page 199
of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 319, column 9.  See page 199
of PBP.  (Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:52:06 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:52:06 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #116 from Mason James  ---
Created attachment 10515
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10515&action=edit
Bug 6679 - fix 3 perlcritic violations in C4/Items.pm

"return" statement with explicit "undef" at line 508, column 44.  See page 199
of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 2267, column 5.  See page 199
of PBP.  (Severity: 5)
Variable declared in conditional statement at line 2642, column 21.  Declare
variables outside of the condition.  (Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:52:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:52:59 +0000
Subject: [Koha-bugs] [Bug 8319] New: headings on statistics tab are confusing
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8319

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8319
          Assignee: nengard at gmail.com
           Summary: headings on statistics tab are confusing
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: nengard at gmail.com
               URL: cgi-bin/koha/members/statistics.pl?borrowernumber=51
          Hardware: All
            Status: ASSIGNED
           Version: master
         Component: Templates
        Depends on: 7955
           Product: Koha

On the statistics tab on the patron record the table headings are confusing to
the average library staff member.  I propose changing the language to something
a bit clearer.

Patch to come

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:52:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:52:59 +0000
Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |8319

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:54:10 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:54:10 +0000
Subject: [Koha-bugs] [Bug 8319] headings on statistics tab are confusing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8319

--- Comment #1 from Nicole C. Engard  ---
Created attachment 10516
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10516&action=edit
Bug 8319: Update headings on Patron Statistics tab

The patron statistics tab had had headings that were too
hard to understand for the average library user. This patch
changes the language to something less technical.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:54:20 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:54:20 +0000
Subject: [Koha-bugs] [Bug 8319] headings on statistics tab are confusing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8319

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:56:10 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:56:10 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #117 from Mason James  ---
Created attachment 10517
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10517&action=edit
Bug 6679 - fix 3 perlcritic violations in C4/ClassSortRoutine.pm

Expression form of "eval" at line 55, column 9.  See page 161 of PBP. 
(Severity: 5)
Expression form of "eval" at line 57, column 9.  See page 161 of PBP. 
(Severity: 5)
Expression form of "eval" at line 58, column 13.  See page 161 of PBP. 
(Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:57:23 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:57:23 +0000
Subject: [Koha-bugs] [Bug 8320] New: Expand choices of
 'CircAutoPrintQuickSlip' with more options
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8320

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8320
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
          Assignee: koha-bugs at lists.koha-community.org
           Summary: Expand choices of 'CircAutoPrintQuickSlip' with more
                    options
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: veron at veron.ch
          Hardware: All
            Status: NEW
           Version: master
         Component: Circulation
           Product: Koha

This enhancement is to replace "Bug 8058 - Circulation empty barcode field
redirect to pay fines screen if borrower has outstanding fines" by Chris Hall
with a more flexible solution.

Instead of having a preference 'circpayfinesredirect' (as proposed in Bug 8058)
I plan to expand the choices of 'CircAutoPrintQuickSlip' with two more options:

"open a print quick slip window and clear the screen" 
(that's what I need to have)

"open a print quick slip window and redirect to outstanding fines (if any)"
(that's what Chris needs to have)

The values can be evaluated in circulation.tt (near the comment '// listen
submit to trigger qslip on empty checkout'). 

This can be expanded for any needs.

Marc

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:58:30 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:58:30 +0000
Subject: [Koha-bugs] [Bug 8320] Expand choices of 'CircAutoPrintQuickSlip'
 with more options
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8320

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=8058
           Assignee|koha-bugs at lists.koha-commun |veron at veron.ch
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 16:58:30 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 14:58:30 +0000
Subject: [Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to
 pay fines screen if borrower has outstanding fines
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=8320

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:00:37 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 15:00:37 +0000
Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955

--- Comment #17 from Nicole C. Engard  ---
Created attachment 10518
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10518&action=edit
item type, collections,locations not showing

I'm on master as of this morning and my stats look like the attached. It
doesn't show item types, locations or collection - instead it just repeats the
headings again ...

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:00:46 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 15:00:46 +0000
Subject: [Koha-bugs] [Bug 8320] Expand choices of 'CircAutoPrintQuickSlip'
 with more options
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8320

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chrish at catalyst.net.nz,
                   |                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:01:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 15:01:04 +0000
Subject: [Koha-bugs] [Bug 8320] Expand choices of 'CircAutoPrintQuickSlip'
 with more options
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8320

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jcamins at cpbibliography.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:02:31 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 15:02:31 +0000
Subject: [Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to
 pay fines screen if borrower has outstanding fines
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058

--- Comment #7 from Marc V?ron  ---
Opened Bug 8320 as replacement

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:04:57 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 15:04:57 +0000
Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955

--- Comment #18 from Jonathan Druart  ---
Hi Nicole,
I proposed a followup to fix this issue.
See attachment 10410

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:24:45 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 15:24:45 +0000
Subject: [Koha-bugs] [Bug 8321] New: fix OPACShowBarcode description
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8321

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8321
          Assignee: nengard at gmail.com
           Summary: fix OPACShowBarcode description
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: nengard at gmail.com
          Hardware: All
            Status: ASSIGNED
           Version: master
         Component: Templates
           Product: Koha

OPACShowBarcode has a description of: Show/Don't show Show items barcode in
holding tab. 

It's repeating the "show" bit.  

Patch coming fixing this and the grammar on this preference.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:25:51 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 15:25:51 +0000
Subject: [Koha-bugs] [Bug 8321] fix OPACShowBarcode description
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8321

--- Comment #1 from Nicole C. Engard  ---
Created attachment 10519
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10519&action=edit
Bug 8321: Fix OPACShowBarcode description

This preference had a few grammar errors and repeated the
word 'show.' This patch resolves those issues.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:26:02 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 15:26:02 +0000
Subject: [Koha-bugs] [Bug 8321] fix OPACShowBarcode description
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8321

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:29:11 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 15:29:11 +0000
Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10410|0                           |1
        is obsolete|                            |

--- Comment #19 from Nicole C. Engard  ---
Created attachment 10520
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10520&action=edit
[SIGNED-OFF] Bug 7955: Followup: Fix badly use of dbh->quote

Signed-off-by: Nicole C. Engard 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:29:41 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 15:29:41 +0000
Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955

Nicole C. Engard  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #20 from Nicole C. Engard  ---
Why yes you did! Somehow I missed that.  Signed off!!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 17:59:39 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 15:59:39 +0000
Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com

--- Comment #16 from Paul Poulain  ---
Hi Melia,

Could you explain the use case for this feature ? I can't see why it's
something we would need in an ILS.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 18:22:47 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 16:22:47 +0000
Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #17 from Katrin Fischer  ---
Hi Paul,
the use case that comes to my mind are signed registration forms or other forms
that need a signature from the patron.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 18:33:52 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 16:33:52 +0000
Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130

--- Comment #18 from Melia Meggs  ---
Yes, that's exactly it, Katrin.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 22:19:34 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 20:19:34 +0000
Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of
 bibliographic records
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |robin at catalyst.net.nz

--- Comment #39 from Chris Cormack  ---
git/catalyst-koha/debian% ls templates 
apache-shared.conf         apache-site.conf.in       
zebra-authorities-site.cfg.in
apache-shared-disable.conf   koha-conf-site.xml.in       
zebra-biblios-site.cfg.in
apache-shared-intranet.conf  SIPconfig.xml            zebra.passwd.in
apache-shared-opac.conf      zebra-authorities-dom-site.cfg.in

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 22:37:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 20:37:25 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #118 from Mason James  ---
Created attachment 10521
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10521&action=edit
Bug 6679 - fix 3 perlcritic violations in C4/Auth.pm, and enabled warnings

Subroutine prototypes used at line 561, column 1.  See page 194 of PBP. 
(Severity: 5)

Bareword file handle opened at line 606, column 5.  See pages 202,204 of PBP. 
(Severity: 5)

Two-argument "open" used at line 606, column 5.  See page 207 of PBP. 
(Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 22:37:54 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 20:37:54 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #119 from Mason James  ---
Created attachment 10522
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10522&action=edit
Bug 6679 - fix 2 perlcritic violations in C4/Utils.pm

Subroutine prototypes used at line 38, column 1.  See page 194 of PBP. 
(Severity: 5)

Subroutine prototypes used at line 43, column 1.  See page 194 of PBP. 
(Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 22:38:06 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 20:38:06 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #120 from Mason James  ---
Created attachment 10523
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10523&action=edit
Bug 6679 - fix 2 perlcritic violations in C4/Print.pm

Bareword file handle opened at line 80, column 9.  See pages 202,204 of PBP. 
(Severity: 5)

Two-argument "open" used at line 80, column 9.  See page 207 of PBP. 
(Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 22:38:18 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 20:38:18 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #121 from Mason James  ---
Created attachment 10524
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10524&action=edit
Bug 6679 - fix 2 perlcritic violations in C4/ItemCirculationAlertPreference.pm

"return" statement with explicit "undef" at line 170, column 13.  See page 199
of PBP.  (Severity: 5)

"return" statement with explicit "undef" at line 407, column 9.  See page 199
of PBP.  (Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 22:38:31 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 20:38:31 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #122 from Mason James  ---
Created attachment 10525
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10525&action=edit
Bug 6679 - fix 2 perlcritic violations in C4/Installer/PerlModules.pm

Expression form of "eval" at line 71, column 9.  See page 161 of PBP. 
(Severity: 5)

Expression form of "eval" at line 85, column 13.  See page 161 of PBP. 
(Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 22:38:46 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 20:38:46 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #123 from Mason James  ---
Created attachment 10526
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10526&action=edit
Bug 6679 - fix 2 perlcritic violations in C4/BackgroundJob.pm

"return" statement with explicit "undef" at line 234, column 5.  See page 199
of PBP.  (Severity: 5)

"return" statement with explicit "undef" at line 256, column 9.  See page 199
of PBP.  (Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 22:38:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 20:38:59 +0000
Subject: [Koha-bugs] [Bug 6679] Fixing code so it passes basic Perl::Critic
	tests
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679

--- Comment #124 from Mason James  ---
Created attachment 10527
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10527&action=edit
Bug 6679 - fix 2 perlcritic violations in C4/AuthoritiesMarc.pm

"return" statement with explicit "undef" at line 853, column 5.  See page 199
of PBP.  (Severity: 5)

"return" statement with explicit "undef" at line 1191, column 3.  See page 199
of PBP.  (Severity: 5)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 23:49:14 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 21:49:14 +0000
Subject: [Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to
 pay fines screen if borrower has outstanding fines
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058

--- Comment #8 from Chris Hall  ---
I quite like your suggestion Marc Veron, I think having all the related options
immediately visible in the same syspref is an improvement.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Tue Jun 26 23:52:51 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 21:52:51 +0000
Subject: [Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to
 pay fines screen if borrower has outstanding fines
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #9 from Chris Cormack  ---
Just need to make sure the pref works with printing without the windows too. IE
printing direct to a printqueue. And then that would be fine

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 01:21:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 26 Jun 2012 23:21:59 +0000
Subject: [Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to
 pay fines screen if borrower has outstanding fines
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058

--- Comment #10 from Chris Hall  ---
I have done some more work since my last patch, I will upload it shortly.

In order to get this to work with print spooling I have moved the
CircPayFinesRedirect code from the javascript and in to perl.

In order to make this work with correctly CircAutoPrintQuickSlip I may also
have move the relevant code in to perl (so any redirects happen after the code
dealing with print spooling).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 03:21:58 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 01:21:58 +0000
Subject: [Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to
 pay fines screen if borrower has outstanding fines
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058

Chris Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9574|0                           |1
        is obsolete|                            |

--- Comment #11 from Chris Hall  ---
Created attachment 10528
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10528&action=edit
Allows pay fines redirect to work with print spooling.

Scratch that last comment, by removing the return statement from the javascript
for quickslip and moving the code for CircPayFinesRedirect in to the perl code
I am able to get the functionality you desired Marc Veron :)

Attached is my work so far, there are 4 combinations.
CircPayFinesRedirect: do nothing, CircAutoPrintQuickSlip: clear the screen ->
clears the screen
CircPayFinesRedirect: redirect and CircAutoPrintQuickSlip: clear the screen ->
redirects if borrower has fines, otherwise clears the screen
CircPayFinesRedirect: do nothing and CircAutoPrintQuickSlip: open quickslip
window -> opens quick print slip and then clears the screen
CircPayFinesRedirect: redirect and CircAutoPrintQuickSlip: open quickslip
window -> opens quick print slip and then redirects if the borrower has fines,
otherwise clears the screen (after opening print slip window).

It may be wise to combine these in to a single syspref or change the wording to
explain the options better.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 03:31:02 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 01:31:02 +0000
Subject: [Koha-bugs] [Bug 8322] New: Removing space between end of marc data
 and fullstops
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8322

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8322
          Assignee: oleonard at myacpl.org
           Summary: Removing space between end of marc data and fullstops
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: chrish at catalyst.net.nz
          Hardware: All
            Status: NEW
           Version: unspecified
         Component: OPAC
           Product: Koha

On both opac-detail and catalogue/detail there are some unneeded spaces between
the end of information and fullstops on various marc fields.

Patch to fix coming soon (have to submit to get bug number first).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 03:31:58 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 01:31:58 +0000
Subject: [Koha-bugs] [Bug 8322] Removing space between end of marc data and
	fullstops
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8322

Chris Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|oleonard at myacpl.org         |chrish at catalyst.net.nz

--- Comment #1 from Chris Hall  ---
Created attachment 10529
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10529&action=edit
Removes space between end of data and fullstop.

Attached patch removes these unneeded spaces.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 03:32:05 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 01:32:05 +0000
Subject: [Koha-bugs] [Bug 8322] Removing space between end of marc data and
	fullstops
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8322

Chris Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chrish at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 03:37:09 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 01:37:09 +0000
Subject: [Koha-bugs] [Bug 8323] New: User created lists not sorting properly
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8323
          Assignee: oleonard at myacpl.org
           Summary: User created lists not sorting properly
          Severity: trivial
    Classification: Unclassified
                OS: All
          Reporter: chrish at catalyst.net.nz
          Hardware: All
            Status: NEW
           Version: unspecified
         Component: OPAC
           Product: Koha

Sorting by year in opac lists doesn't work due to trying to use
biblioitems.publicationyear which is not mapped in the default MARC21 mapping.

My patch passes through the sorting field and will change 'year' to
'copyrightdate' to instead sort by biblio.copyrightdate (marc 260$c).

Patch incoming (have to get bug number first).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 03:38:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 01:38:33 +0000
Subject: [Koha-bugs] [Bug 8323] User created lists not sorting properly
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323

Chris Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|oleonard at myacpl.org         |chrish at catalyst.net.nz

--- Comment #1 from Chris Hall  ---
Created attachment 10530
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10530&action=edit
Fixing year sorting of OPAC lists

Patch attached to fix, will pass sort field through the the SQL and will change
'year' to 'copyrightdate'.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 03:39:36 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 01:39:36 +0000
Subject: [Koha-bugs] [Bug 6402] Lists sorted by year appear to be empty
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6402

Chris Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chrish at catalyst.net.nz

--- Comment #5 from Chris Hall  ---
I have uploaded a possible fix for Owen's bug to bug8323

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 03:40:18 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 01:40:18 +0000
Subject: [Koha-bugs] [Bug 8323] User created lists not sorting properly
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323

Chris Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chrish at catalyst.net.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 03:45:57 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 01:45:57 +0000
Subject: [Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to
 pay fines screen if borrower has outstanding fines
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058

Chris Hall  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10528|0                           |1
        is obsolete|                            |

--- Comment #12 from Chris Hall  ---
Created attachment 10531
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10531&action=edit
Allows pay fines redirect to work with print spooling.

Attached proper patch, somehow the old patch got attached rather than the new
one.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 07:12:47 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 05:12:47 +0000
Subject: [Koha-bugs] [Bug 8058] Circulation empty barcode field redirect to
 pay fines screen if borrower has outstanding fines
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8058

--- Comment #13 from Marc V?ron  ---
Chris,

Thanks for taking care of the additional functionality I need, see 3) below.

I tried out the patch and found the following:

--------------

- If a patron has a credit (instead of fines), the redirect is done as well.
This should not be.

--------------

- CircAutoPrintQuickSlip should have 3 possibilities:
1) Clear the screen  
   (EXISTS)
2) Open a print quick slip window [...and do not change the screen]
   (EXISTS, behaviour until now, we should not change it)
3) Open a print quick slip window and clear the screen 
   (NEW and needs to be an explicit choice)

- CircPayFinesRedirect (if set and if there are fines) should override the
options above and redirect to pay fines screen. If patron has no fines or if
patron has a credit, it should leave the options above as set.

Marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 08:30:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 06:30:24 +0000
Subject: [Koha-bugs] [Bug 8311] Mis-scoped function call in C4::Auth
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8311

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10481|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron  ---
Created attachment 10532
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10532&action=edit
[SIGNED-OFF] Bug 8311: Fix scoping error in C4::Auth

There is a mis-scoped function call in C4::Auth, on line 154, where
GetMembers is called without explicit scoping and before
'require C4::Members;'. This does not actually have any functional
ramifications as far as I can tell, but it would be a good idea to fix
it.

This patch also corrects a bit of indenting in that area, because it was
an unnecessary challenge to understand the code with the mis-indenting.

Signed-off-by: Marc Veron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 08:31:26 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 06:31:26 +0000
Subject: [Koha-bugs] [Bug 8311] Mis-scoped function call in C4::Auth
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8311

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 08:42:53 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 06:42:53 +0000
Subject: [Koha-bugs] [Bug 8313] add ASHS to 'Koha team' page,
 for sponsorship of the 'star-ratings' feature
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8313

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10482|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron  ---
Created attachment 10533
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10533&action=edit
[SIGNED-OFF] Bug 8313 - add ASHS to 'Koha team' page, for sponsorship of the
'star-ratings' feature

Signed-off-by: Marc Veron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 08:43:13 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 06:43:13 +0000
Subject: [Koha-bugs] [Bug 8313] add ASHS to 'Koha team' page,
 for sponsorship of the 'star-ratings' feature
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8313

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 08:50:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 06:50:25 +0000
Subject: [Koha-bugs] [Bug 8318] update StatisticsFields description
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10511|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron  ---
Created attachment 10534
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10534&action=edit
[SIGNED-OFF] Bug 8318: Update StatisticsFields preference language

This patch changes around the wording of the StatisticsFields
preference to make it clearer where these values will show.

Signed-off-by: Marc Veron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 08:50:45 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 06:50:45 +0000
Subject: [Koha-bugs] [Bug 8318] update StatisticsFields description
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 09:40:50 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 07:40:50 +0000
Subject: [Koha-bugs] [Bug 8307] Set a value for items when receiving
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8307

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 10:03:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 08:03:25 +0000
Subject: [Koha-bugs] [Bug 6566] Checking if DB records are properly indexed
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566

Christophe Croullebois  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #4597|0                           |1
        is obsolete|                            |
  Attachment #10417|0                           |1
        is obsolete|                            |

--- Comment #7 from Christophe Croullebois  ---
Created attachment 10535
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10535&action=edit
last patch

just because I have forgotten to obsolete

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 10:30:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 08:30:25 +0000
Subject: [Koha-bugs] [Bug 8318] update StatisticsFields description
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #3 from Jonathan Druart  ---
Changes the description for the syspref StatisticsFields

Marking as Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 10:39:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 08:39:24 +0000
Subject: [Koha-bugs] [Bug 8319] headings on statistics tab are confusing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8319

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10516|0                           |1
        is obsolete|                            |

--- Comment #2 from Julian Maurice  ---
Created attachment 10536
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10536&action=edit
[SIGNED-OFF] Bug 8319: Update headings on Patron Statistics tab

Simple template change. Make things clearer.
Signed off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 10:39:34 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 08:39:34 +0000
Subject: [Koha-bugs] [Bug 8319] headings on statistics tab are confusing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8319

Julian Maurice  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |julian.maurice at biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 10:44:51 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 08:44:51 +0000
Subject: [Koha-bugs] [Bug 8319] headings on statistics tab are confusing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8319

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #3 from Jonathan Druart  ---
Changes headings for the patron statistics table.

Marking as Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 10:59:31 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 08:59:31 +0000
Subject: [Koha-bugs] [Bug 6566] Checking if DB records are properly indexed
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566

--- Comment #8 from Robin Sheat  ---
Just saying that the changes applied look good to me, I'm adding it to my list
to sign off on, unless someone beats me to it (it's a pretty long list.)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 11:41:16 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 09:41:16 +0000
Subject: [Koha-bugs] [Bug 8323] User created lists not sorting properly
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10530|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron  ---
Created attachment 10537
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10537&action=edit
[SIGNED-OFF] bug 8323 fixing year sorting of a list

Signed-off-by: Marc Veron 

Works as expected.

Caveat: If you edit the list in Opac, change the sort and then klick 'Save',
the List always is displayed in title order. This is du to the fact that
save calls opac-shelves.pl?viewshelf=4 without the sort parameter (defaults
to 'title').
If you go back to lists, choose the list from List name, the param is
correct and the list displays in expected order.

It took quite a time to track  that down, I first thought that opac-shelves.pl
was broken.

However, current bug 8323 is not affected, signing off.

Marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 11:41:58 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 09:41:58 +0000
Subject: [Koha-bugs] [Bug 8323] User created lists not sorting properly
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 11:56:38 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 09:56:38 +0000
Subject: [Koha-bugs] [Bug 8324] New: User created lists sort by title just
 after editing sort order (call by opac-shelves.pl without sort parameter)
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8324
          Assignee: oleonard at myacpl.org
           Summary: User created lists sort by title just after editing
                    sort order (call by opac-shelves.pl without sort
                    parameter)
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: veron at veron.ch
          Hardware: All
            Status: NEW
           Version: master
         Component: OPAC
           Product: Koha

If you edit a user defined list in Opac, change the sort and then klick 'Save',
the list always is displayed in title order (and not in the selected order).

This is due to the fact that save calls opac-shelves.pl?viewshelf=4 without the
sort parameter (defaults to 'title').

If you go back to lists, choose in the table the list from List name, the param
is
correct and the list displays in expected order.

Should be fixed because end users will think that changing the sort order is
broken.

Marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 11:58:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 09:58:25 +0000
Subject: [Koha-bugs] [Bug 8323] User created lists not sorting properly
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323

--- Comment #3 from Marc V?ron  ---
Opend a bug for wrong sort order just after editing (8324).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:00:17 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 10:00:17 +0000
Subject: [Koha-bugs] [Bug 8324] User created lists sort by title just after
 editing sort order (call by opac-shelves.pl without sort parameter)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8324

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch
           Severity|enhancement                 |minor

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:02:28 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 10:02:28 +0000
Subject: [Koha-bugs] [Bug 8313] add ASHS to 'Koha team' page,
 for sponsorship of the 'star-ratings' feature
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8313

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #3 from Jonathan Druart  ---
Add a line in about.tt
simple patch, Marking as Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:10:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 10:10:04 +0000
Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244

--- Comment #6 from Julian Maurice  ---
This script takes much time. I don't think we want to launch it every time with
`prove xt`. Although, there is already scripts in xt/ that are not ".t"
(yaml_valid.pl for example).

Moreover, this script is not a test script as it does not use Test::More, but
build test scripts and run prove on them. Running prove on this script will
fail.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:15:02 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 10:15:02 +0000
Subject: [Koha-bugs] [Bug 8311] Mis-scoped function call in C4::Auth
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8311

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #3 from Jonathan Druart  ---
I don't know how we can reproduce the error. But the patch fixes a mis-scoped
function.

Marking as Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:21:38 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 10:21:38 +0000
Subject: [Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |7941

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:21:38 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 10:21:38 +0000
Subject: [Koha-bugs] [Bug 7941] Fix version numbers in modules and set up a
 system to keep them up to date
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7941

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m
             Blocks|                            |8315

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:28:39 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 10:28:39 +0000
Subject: [Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #4 from Jonathan Druart  ---

    Bug 7941 introduces issues in some pages.

    3 are list in this bug, but others exist.

    At least:
    tags/list.pl:use C4::Tags 0.03 qw(get_tags remove_tag get_tag_rows);
    tags/review.pl:use C4::Tags 0.03 qw(get_tags get_approval_rows
approval_counts whitelist blacklist is_approved);


    Marking as Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 12:32:15 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 10:32:15 +0000
Subject: [Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315

Chris Cormack  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #5 from Chris Cormack  ---
Interesting those use lines have been there since 2008, it's only now we
actually have accurate version numbers on our modules that they are causing a
breakage. 

Still they definitely shouldn't be there.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 13:04:09 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 11:04:09 +0000
Subject: [Koha-bugs] [Bug 5327] Unit tests required for all C4 modules
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5327

Robin Sheat  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff
                 CC|                            |robin at catalyst.net.nz

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 13:24:34 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 11:24:34 +0000
Subject: [Koha-bugs] [Bug 8325] New: autofill tags in the opac
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8325

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8325
          Assignee: gmcharlt at gmail.com
           Summary: autofill tags in the opac
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: nengard at gmail.com
          Hardware: All
            Status: NEW
           Version: master
         Component: Tools
           Product: Koha

It would be super if there was an autofill options for the tagging in the OPAC.
That way, if someone is trying to tag a lot of books the same way and they are
not cut/paste savvy, the existing tags would suggest the existing tag for them,
cutting down on typos.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 13:40:56 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 11:40:56 +0000
Subject: [Koha-bugs] [Bug 8321] fix OPACShowBarcode description
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8321

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10519|0                           |1
        is obsolete|                            |

--- Comment #2 from Marc V?ron  ---
Created attachment 10538
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10538&action=edit
[SIGNED-OFF] Bug 8321: Fix OPACShowBarcode description

This preference had a few grammar errors and repeated the
word 'show.' This patch resolves those issues.

Signed-off-by: Marc Veron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 13:41:27 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 11:41:27 +0000
Subject: [Koha-bugs] [Bug 8321] fix OPACShowBarcode description
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8321

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 14:03:08 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 12:03:08 +0000
Subject: [Koha-bugs] [Bug 8321] fix OPACShowBarcode description
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8321

Jonathan Druart  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |jonathan.druart at biblibre.co
                   |                            |m

--- Comment #3 from Jonathan Druart  ---
Update a syspref description.
Simple patch

Marking as Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 14:21:50 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 12:21:50 +0000
Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion
	librairy
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919

delaye  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10424|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 14:22:29 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 12:22:29 +0000
Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion
	librairy
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919

delaye  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9984|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 14:25:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 12:25:04 +0000
Subject: [Koha-bugs] [Bug 7919] Display of values depending on the connexion
	librairy
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7919

delaye  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9973|1                           |0
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 14:43:42 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 12:43:42 +0000
Subject: [Koha-bugs] [Bug 7161] Open Library - Larger image, Read,
 borrow and checked-out status
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161

--- Comment #10 from M. de Rooy  ---
Created attachment 10539
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10539&action=edit
Patch for 7161

Signed-off-by: Marcel de Rooy 
June 27, 2012: Removing unused function keys from openlibrary.js.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 14:44:08 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 12:44:08 +0000
Subject: [Koha-bugs] [Bug 7161] Open Library - Larger image, Read,
 borrow and checked-out status
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9873|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 14:45:54 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 12:45:54 +0000
Subject: [Koha-bugs] [Bug 7161] Open Library - Larger image, Read,
 borrow and checked-out status
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161

--- Comment #11 from M. de Rooy  ---
Created attachment 10540
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10540&action=edit
Followup for 7161

Only whitespace changes to fix indentation after tab removal.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 14:48:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 12:48:33 +0000
Subject: [Koha-bugs] [Bug 7161] Open Library - Larger image, Read,
 borrow and checked-out status
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #12 from M. de Rooy  ---
Earlier comments have been implemented. Did some minor corrections myself on
unused function and whitespace.
Marking as Passed QA now.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 14:53:44 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 12:53:44 +0000
Subject: [Koha-bugs] [Bug 8240] There is dead code in orderreceive.tt
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8240

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |master
         QA Contact|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:11:29 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 13:11:29 +0000
Subject: [Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315

--- Comment #6 from Robin Sheat  ---
On 3.8.2, I see the following things that use versioning:

$ grep -rPe '^\s*use\s+[^\s]+\s+\d' *
C4/Creators/Template.pm:use C4::Creators::Profile 1.000000;
C4/Creators/Template.pm:use C4::Creators::Lib 1.000000 qw(get_unit_values);
C4/Creators/Profile.pm:use C4::Creators::Lib 1.000000 qw(get_unit_values);
C4/Patroncards.pm:    use C4::Patroncards::Batch 1.000000;
C4/Patroncards.pm:    use C4::Patroncards::Layout 1.000000;
C4/Patroncards.pm:    use C4::Patroncards::Lib 1.000000;
C4/Patroncards.pm:    use C4::Patroncards::Patroncard 1.000000;
C4/Patroncards.pm:    use C4::Patroncards::Profile 1.000000;
C4/Patroncards.pm:    use C4::Patroncards::Template 1.000000;
C4/Labels.pm:    use C4::Labels::Batch 1.000000;
C4/Labels.pm:    use C4::Labels::Label 1.000000;
C4/Labels.pm:    use C4::Labels::Layout 1.000000;
C4/Labels.pm:    use C4::Labels::Profile 1.000000;
C4/Labels.pm:    use C4::Labels::Template 1.000000;
C4/Creators.pm:    use C4::Creators::Lib 1.000000;
C4/Creators.pm:    use C4::Creators::PDF 1.000000;
C4/Installer.pm:use C4::Installer::PerlModules 1.000000;
C4/Patroncards/Patroncard.pm:use C4::Creators::Lib 1.000000 qw(get_font_types);
C4/Patroncards/Patroncard.pm:use C4::Creators::PDF 1.000000 qw(StrWidth);
C4/Patroncards/Patroncard.pm:use C4::Patroncards::Lib 1.000000 qw(unpack_UTF8
text_alignment leading box get_borrower_attributes);
labels/label-manage.pl:use C4::Creators 1.000000;
labels/label-manage.pl:use C4::Labels 1.000000;
labels/label-create-csv.pl:use C4::Creators 1.000000;
labels/label-create-csv.pl:use C4::Labels 1.000000;
labels/label-create-xml.pl:use C4::Creators 1.000000;
labels/label-create-xml.pl:use C4::Labels 1.000000;
labels/label-print.pl:use C4::Creators::Lib 1.000000 qw(get_all_templates
get_all_layouts get_output_formats);
labels/label-print.pl:use C4::Labels::Batch 1.000000;
labels/label-create-pdf.pl:use C4::Creators 1.000000;
labels/label-create-pdf.pl:use C4::Labels 1.000000;
labels/label-edit-batch.pl:use C4::Creators 1.000000;
labels/label-edit-batch.pl:use C4::Labels 1.000000;
labels/label-edit-profile.pl:use C4::Creators 1.000000;
labels/label-edit-profile.pl:use C4::Labels 1.000000;
labels/label-edit-layout.pl:use C4::Creators 1.000000;
labels/label-edit-layout.pl:use C4::Labels 1.000000;
labels/label-edit-template.pl:use C4::Creators 1.000000;
labels/label-edit-template.pl:use C4::Labels 1.000000;
misc/cronjobs/overdue_notices.pl:use Locale::Currency::Format 1.28;
opac/opac-ratings-ajax.pl:use C4::Output 3.02 qw(:html :ajax pagination_bar);
opac/opac-tags.pl:use C4::Output 3.02 qw(:html :ajax pagination_bar);
patroncards/image-manage.pl:use C4::Creators 1.000000;
patroncards/image-manage.pl:use C4::Patroncards 1.000000;
patroncards/create-pdf.pl:use C4::Creators 1.000000;
patroncards/create-pdf.pl:use C4::Patroncards 1.000000;
patroncards/manage.pl:use C4::Creators 1.000000;
patroncards/manage.pl:use C4::Patroncards 1.000000;
patroncards/manage.pl:use C4::Labels 1.000000;
patroncards/edit-template.pl:use C4::Creators 1.000000;
patroncards/edit-template.pl:use C4::Patroncards 1.000000;
patroncards/edit-layout.pl:use C4::Creators 1.000000;
patroncards/edit-layout.pl:use C4::Patroncards 1.000000;
patroncards/card-print.pl:use C4::Creators 1.000000;
patroncards/card-print.pl:use C4::Labels 1.000000;
patroncards/edit-batch.pl:use C4::Creators 1.000000;
patroncards/edit-batch.pl:use C4::Patroncards 1.000000;
patroncards/print.pl:use C4::Creators 1.000000;
patroncards/print.pl:use C4::Patroncards 1.000000;
patroncards/edit-profile.pl:use C4::Creators::Lib 1.000000 qw(get_all_templates
get_unit_values);
patroncards/edit-profile.pl:use C4::Patroncards::Profile 1.000000;
tags/list.pl:use C4::Tags 0.03 qw(get_tags remove_tag get_tag_rows);
tags/review.pl:use C4::Output 3.02 qw(:html :ajax pagination_bar);
tags/review.pl:use C4::Tags 0.03 qw(get_tags get_approval_rows approval_counts
whitelist blacklist is_approved);
tools/manage-marc-import.pl:use C4::Labels::Batch 1.000000;

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:25:36 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 13:25:36 +0000
Subject: [Koha-bugs] [Bug 8326] New: allow attributes to be made repeatable
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8326

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8326
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
          Assignee: koha-bugs at lists.koha-community.org
           Summary: allow attributes to be made repeatable
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: nengard at gmail.com
               URL: cgi-bin/koha/admin/patron-attr-types.pl?op=edit_attrib
                    ute_type&code=DL
          Hardware: All
            Status: NEW
           Version: master
         Component: Patrons
           Product: Koha

I understand not letting people edit attribute codes or the fact that it's a
unique identifier after it has been saved, but I see no reason why an attribute
can't be made repeatable retroactively. I think this value should be editable -
at least from 'not repeatable' to 'repeatable' since it might cause problems
going from 'repeatable' to 'not repeatable'.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:28:01 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 13:28:01 +0000
Subject: [Koha-bugs] [Bug 8105] DataTables in Acquisision module:
	basketgroup.tt
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8105

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|unspecified                 |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:30:13 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 13:30:13 +0000
Subject: [Koha-bugs] [Bug 7905] Multi-line notes are displayed on one line
 in Staff Serials page
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7905

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:42:27 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 13:42:27 +0000
Subject: [Koha-bugs] [Bug 7387] Add Template::Toolkit plugin to allow
	caching of includes
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7387

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Failed QA

--- Comment #9 from Paul Poulain  ---
(In reply to comment #8)
> Nope d, in fact caching that one won't win us much at all it's fast to
> render anyway. But looking into caching things that require computation,
> would be good. This patch is just to enable people to cache includes when
> they find ones, or even better create includes and cache them.

mmm... I'm not sure this patch should be pushed as is : if it's a good idea,
the 
-[% INCLUDE 'doc-head-open.inc' %]
+[% USE cache = Cache %]
+[% cache.inc(
+    'template' => 'doc-head-open.inc',
+    'keys' => {'dochead' => 'dochead'},
+    'ttl' => 360
+    )
+%]
is useless, so should be removed, and a more useful example used ?

QA comment: isn't 
{'cache_servers' => C4::Context->config('memcached_servers') }

as memcache is the default server for Koha::Cache ?

marking failed QA for now

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:48:29 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 13:48:29 +0000
Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244

--- Comment #7 from Jared Camins-Esakov  ---
(In reply to comment #6)
> This script takes much time. I don't think we want to launch it every time
> with `prove xt`. Although, there is already scripts in xt/ that are not ".t"
> (yaml_valid.pl for example).
> 
> Moreover, this script is not a test script as it does not use Test::More,
> but build test scripts and run prove on them. Running prove on this script
> will fail.

Fair enough. Sign off to follow. I will also provide a follow-up to add an
argument so that we can tell the script to ignore certain files.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:49:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 13:49:04 +0000
Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title
 with borrower's age without using categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

delaye  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |stephane.delaye at biblibre.co
                   |                            |m

--- Comment #24 from delaye  ---
i test with a sandbox and an UNIMARC database; i use the tag 333$a where i
enter the valeur FSK 16

but it didn't work : the young can checkout the issue.
I must update biblioitems.agerestriction ? i must enter un flag in this new
column ?...

thank you for more information

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:53:08 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 13:53:08 +0000
Subject: [Koha-bugs] [Bug 6566] Checking if DB records are properly indexed
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566

--- Comment #9 from Robin Sheat  ---
Created attachment 10541
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10541&action=edit
Bug 6566 Checking if DB's records are properly indexed

Small script that checks if each bibliorecord in the DB is properly indexed
use -h to learn more
(MT #6389)

Signed-off-by: Robin Sheat 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:53:49 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 13:53:49 +0000
Subject: [Koha-bugs] [Bug 6566] Checking if DB records are properly indexed
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566

Robin Sheat  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10535|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:55:22 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 13:55:22 +0000
Subject: [Koha-bugs] [Bug 6566] Checking if DB records are properly indexed
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6566

Robin Sheat  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #10 from Robin Sheat  ---
My only real comment on it is that it probably doesn't need to be in
migration_tools, as it's not really a migration tool. But there's all sorts of
stuff in there as it is.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 15:56:40 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 13:56:40 +0000
Subject: [Koha-bugs] [Bug 8240] There is dead code in orderreceive.tt
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8240

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #5 from M. de Rooy  ---
Jonathan,
You are probably right about this code in practice. But theoretically, if
ordernumber is empty, you may have more than one result.
In one of the templates below the ordernumber comes from parsing some text.
What if this fails somehow?
And how about a user removing the ordernumber from the URL in the browser?

Was the original idea of this script: If we have one, receive it rightaway. If
we have more, let the user choose (one more click to receive)? And just
thinking: why not receive more items at once if the date is the same and the
quantity is most often 1 ? Also keep in mind that not everybody creates the
items at the same time (AcqCreateItem pref).

koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt

If we follow your approach here, I think we must add some check around
ordernumber and results, and change a few lines of documentation in the code
conveying the original idea of multiple results.

Changing status for need of clarification.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:00:18 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 14:00:18 +0000
Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title
 with borrower's age without using categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

--- Comment #25 from Marc V?ron  ---
Hi Stephane,

Thank you for testing!

I se that teh wiki link is broken, it should be:
http://wiki.koha-community.org/wiki/Age_restriction

Did you follow the steps there?

Marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:05:38 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 14:05:38 +0000
Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title
 with borrower's age without using categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

--- Comment #26 from Marc V?ron  ---
Ah I see you are testing in a sandbox. Maybe the prolbem is that you cann not
update the database:

--Snip Wiki -------
If you use the patch, make sure that you have a column 'agerestriction' in
table biblioitems. This will be handled by updatedatabase.pl. If you want to
insert the column using mysql, you can do:

ALTER TABLE biblioitems ADD COLUMN 'agerestriction' VARCHAR(255) DEFAULT NULL
AFTER 'cn_sort' 
--End Snip Wiki -------

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:07:16 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 14:07:16 +0000
Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title
 with borrower's age without using categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

--- Comment #27 from delaye  ---
after apply the patch i can't update the system preference AgeRestrictionMarker
and AgeRestrictionOverride 

i see the system preference in koha but une the table sql  systempreferences i
don't see them

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:11:10 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 14:11:10 +0000
Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557

--- Comment #26 from M. de Rooy  ---
(In reply to comment #24)
> The FAUSP (Fighters Against Useless SysPrefs) commitee
I recently saw this patch removing a pref :-)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263

(In reply to comment #25)
> Although I consider the performance hit to be significant
Could you make this more concrete? Did you test the difference in performance?
Instead of just mentioning some milliseconds on a specific server, could we
come to a reasonably accurate percentage or so? 
If the performance increase would be below say 10%, we may not need two ways.
But we probably do if we reach 50%?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:16:49 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 14:16:49 +0000
Subject: [Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315

Dobrica Pavlinusic  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpavlin at rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:19:05 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 14:19:05 +0000
Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557

--- Comment #27 from Jared Camins-Esakov  ---
(In reply to comment #26)
> (In reply to comment #24)
> > The FAUSP (Fighters Against Useless SysPrefs) commitee
> I recently saw this patch removing a pref :-)
> http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8263
> 
> (In reply to comment #25)
> > Although I consider the performance hit to be significant
> Could you make this more concrete? Did you test the difference in
> performance? Instead of just mentioning some milliseconds on a specific
> server, could we come to a reasonably accurate percentage or so? 
> If the performance increase would be below say 10%, we may not need two
> ways. But we probably do if we reach 50%?

As I recall, the performance hit was around 30%. Reducing the performance hit
at the cost of clean code separation is -- as I discussed with Ian -- not a
good idea, because it would make maintenance a nightmare, and move us one step
closer to C4::Search levels of mess. I would say that the syspref would be a
candidate for future removal, once DOM has entirely replaced GRS-1 (can we hope
this will be true for 3.14? Well, maybe 3.16), but I am not comfortable with
adding a feature that legacy libraries will be unable to take advantage of
(instant popularity updates).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:20:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 14:20:24 +0000
Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title
 with borrower's age without using categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

--- Comment #28 from Marc V?ron  ---
If the field 'agerestriction'is not in the table, you should run:

installer/data/mysql/updatedatabase.pl

or as alternative you can do the update directly using the following MySQL
statement:

ALTER TABLE biblioitems ADD COLUMN 'agerestriction' VARCHAR(255) DEFAULT NULL
AFTER 'cn_sort' ;

Can you do that in the sandbox?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:22:54 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 14:22:54 +0000
Subject: [Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315

--- Comment #7 from Dobrica Pavlinusic  ---
I would love for this to land in master ASAP because it breaks our production,
but I would be also happy with patch with removes all versions as Robin pointed
out in comment #6... Should I submit one?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:25:21 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 14:25:21 +0000
Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557

--- Comment #28 from M. de Rooy  ---
30% would justify the pref IMO.
Speaking about committees, is there already a committee to fight against Yet
Another Cron Job ? ;)
Some day we need a layer on top of prefs and cronjobs. One intelligent cronjob
that does everything based on settings and yes a few more prefs ..

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:28:14 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 14:28:14 +0000
Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557

--- Comment #29 from Jared Camins-Esakov  ---
(In reply to comment #28)
> 30% would justify the pref IMO.
> Speaking about committees, is there already a committee to fight against Yet
> Another Cron Job ? ;)
> Some day we need a layer on top of prefs and cronjobs. One intelligent
> cronjob that does everything based on settings and yes a few more prefs ..

That would be very nice. I'd like to kill both the instant updating and the
cron job (making it into a script that only needs to be run on special
occasions or if you want something weird for popularity) for 3.16, but as I
said, I'm just not comfortable with doing it now because of the ramifications
this would have for libraries with legacy data.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:48:29 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 14:48:29 +0000
Subject: [Koha-bugs] [Bug 7571] Maintain exchange rate history
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10271|0                           |1
           is patch|                            |
  Attachment #10271|application/octet-stream    |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:52:26 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 14:52:26 +0000
Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title
 with borrower's age without using categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

--- Comment #29 from delaye  ---
mysql> desc biblioitems;
+-----------------------+--------------+------+-----+-------------------+-----------------------------+
| Field                 | Type         | Null | Key | Default           | Extra
                      |
+-----------------------+--------------+------+-----+-------------------+-----------------------------+
| biblioitemnumber      | int(11)      | NO   | PRI | NULL              |
auto_increment              |
| biblionumber          | int(11)      | NO   | MUL | 0                 |      
                      |
| volume                | mediumtext   | YES  |     | NULL              |      
                      |
| number                | mediumtext   | YES  |     | NULL              |      
                      |
| itemtype              | varchar(10)  | YES  |     | NULL              |      
                      |
| isbn                  | varchar(30)  | YES  | MUL | NULL              |      
                      |
| issn                  | varchar(9)   | YES  | MUL | NULL              |      
                      |
| ean                   | varchar(13)  | YES  | MUL | NULL              |      
                      |
| publicationyear       | text         | YES  |     | NULL              |      
                      |
| publishercode         | varchar(255) | YES  | MUL | NULL              |      
                      |
| volumedate            | date         | YES  |     | NULL              |      
                      |
| volumedesc            | text         | YES  |     | NULL              |      
                      |
| collectiontitle       | mediumtext   | YES  |     | NULL              |      
                      |
| collectionissn        | text         | YES  |     | NULL              |      
                      |
| collectionvolume      | mediumtext   | YES  |     | NULL              |      
                      |
| editionstatement      | text         | YES  |     | NULL              |      
                      |
| editionresponsibility | text         | YES  |     | NULL              |      
                      |
| timestamp             | timestamp    | NO   |     | CURRENT_TIMESTAMP | on
update CURRENT_TIMESTAMP |
| illus                 | varchar(255) | YES  |     | NULL              |      
                      |
| pages                 | varchar(255) | YES  |     | NULL              |      
                      |
| notes                 | mediumtext   | YES  |     | NULL              |      
                      |
| size                  | varchar(255) | YES  |     | NULL              |      
                      |
| place                 | varchar(255) | YES  |     | NULL              |      
                      |
| lccn                  | varchar(25)  | YES  |     | NULL              |      
                      |
| marc                  | longblob     | YES  |     | NULL              |      
                      |
| url                   | varchar(255) | YES  |     | NULL              |      
                      |
| cn_source             | varchar(10)  | YES  |     | NULL              |      
                      |
| cn_class              | varchar(30)  | YES  |     | NULL              |      
                      |
| cn_item               | varchar(10)  | YES  |     | NULL              |      
                      |
| cn_suffix             | varchar(10)  | YES  |     | NULL              |      
                      |
| cn_sort               | varchar(30)  | YES  |     | NULL              |      
                      |
| agerestriction        | varchar(250) | YES  |     | NULL              |      
                      |
| totalissues           | int(10)      | YES  |     | NULL              |      
                      |
| marcxml               | longtext     | NO   |     | NULL              |      
                      |
+-----------------------+--------------+------+-----+-------------------+----------------

INSERT INTO systempreferences (variable,value,explanation,options,type)
VALUES('AgeRestrictionMarker','','Markers for age restriction indication, e.g.
FSK|PEGI|Age|. See:
http://wiki.koha-community.org/wiki/Age_restriction',NULL,'free');

INSERT INTO systempreferences (variable,value,explanation,options,type)
VALUES('AgeRestrictionOverride',0,'Allow staff to check out an item with age
restriction.',NULL,'YesNo');

select * from biblioitems where biblionumber=1979\G
*************************** 1. row ***************************
     biblioitemnumber: 1979
         biblionumber: 1979
               volume: NULL
               number: NULL
             itemtype: LIVR
                 isbn: 2869672020
                 issn: NULL
                  ean: NULL
      publicationyear: 1993
        publishercode: Vents d'ouest
           volumedate: NULL
           volumedesc: NULL
      collectiontitle: Grand large.
       collectionissn: NULL
     collectionvolume: NULL
     editionstatement: NULL
editionresponsibility: NULL
            timestamp: 2012-06-27 16:41:24
                illus: NULL
                pages: 46 p.
                notes: NULL
                 size: 30 cm
                place: NULL
                 lccn: NULL
                 marc: 00516     2200193  
4500001000500000010002100005090000900026100004100035200007300076210002400149215003400173225002300207101000800230615001200238676000700250333001100257700002600268701002800294
1979

 a2869672020d6.10
  a1979
  a20020311              frey50        
1 aLe
vol des urubus : La fi?vre de l'ordtome 2fEric GutierrezbLIVR
 1cVents
d'ouestd1993
 1a46 p.cBande dessin?ed30 cm
1 aGrand large.vN?2
  afre
 
aFiction
 1aBD
  aFSK 16
 192508aGutierrezbEric

192509aMigeatbFran?ois


                  url: NULL
            cn_source: NULL
             cn_class: NULL
              cn_item: NULL
            cn_suffix: NULL
              cn_sort: 
       agerestriction: FSK 16
          totalissues: NULL


BUT the user  who have 14 years can chekout the biblionumber 1979

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 16:54:21 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 14:54:21 +0000
Subject: [Koha-bugs] [Bug 7304] Working on funds ergonomic display and funds
 management by multi librarians
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7304

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_10

--- Comment #19 from Paul Poulain  ---
Nice feature ! patch pushed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:06:32 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 15:06:32 +0000
Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title
 with borrower's age without using categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

--- Comment #30 from Marc V?ron  ---
What is in the Preferences 
AgeRestrictionMarker
and 
AgeRestrictionOverride ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:11:00 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 15:11:00 +0000
Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244

Jared Camins-Esakov  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10374|0                           |1
        is obsolete|                            |

--- Comment #8 from Jared Camins-Esakov  ---
Created attachment 10542
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10542&action=edit
Bug 8244: New script xt/find-undefined-subroutines.pl

This script tends to detect if Koha scripts use subroutines that are not
correctly exported by modules. This can happen when we have circular
dependencies between modules.
This script does mainly two things:
 - It rebuilds the hierarchy of Koha Perl modules and replace all the code
   within subroutines by tests (using Test::More). For each subroutine called
   in a subroutine, a test is done on if the called subroutine is defined.
   If it's defined, then it's called (Tested subroutines are only those
   available in Koha Perl modules, not external modules subroutines).
   It does almost the same work with Koha Perl scripts, replacing all the
   code by tests and calling the subroutines if defined.
 - Launch prove on all created Perl scripts.
This results in a summary where failed tests are subroutines that are not
exported, but called without the module name prepended.

Signed-off-by: Jared Camins-Esakov 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:11:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 15:11:25 +0000
Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244

--- Comment #9 from Jared Camins-Esakov  ---
Created attachment 10543
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10543&action=edit
Bug 8244 follow-up: improvements to find-undefined-subroutines

* Adds a repeatable --ignore option so that the user can choose to
  ignore certain files.
* Exit with the same success or failure code that the prove command
  returns

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:13:07 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 15:13:07 +0000
Subject: [Koha-bugs] [Bug 8244] Script to find exporter problems
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8244

--- Comment #10 from Jared Camins-Esakov  ---
The first patch has been signed off, but my follow-up still requires a
sign-off.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:14:56 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 15:14:56 +0000
Subject: [Koha-bugs] [Bug 7571] Maintain exchange rate history
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10271|0                           |1
        is obsolete|                            |

--- Comment #5 from Marc V?ron  ---
Created attachment 10544
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10544&action=edit
[SIGNED-OFF] Bug 7571 Maintain exchange rate history

Keep track of changes to exchange rates for accounting purposes.
History is displayed with each currency.

Behaviour is as expected.

Signed-off-by: Marc Veron 

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:15:21 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 15:15:21 +0000
Subject: [Koha-bugs] [Bug 7571] Maintain exchange rate history
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7571

Marc V?ron  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |veron at veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:27:20 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 15:27:20 +0000
Subject: [Koha-bugs] [Bug 7351] ability to edit a range of holidays
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7351

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply

--- Comment #34 from Paul Poulain  ---
Sorry Christophe, but this patch make me crazy. Now it does not apply anymore.


Could you please rebase and squash the 3 patches ?

git rebase master
git rebase -i HEAD~3
replace on line 2 and 3 "pick" by "squash"
(ask me if needed)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 17:30:15 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 15:30:15 +0000
Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title
 with borrower's age without using categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

--- Comment #31 from delaye  ---
FSK|PEGI|Age

and

0

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 18:04:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 16:04:12 +0000
Subject: [Koha-bugs] [Bug 8288] showmarc.tt should not include full
	doc-head-close.inc
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_8

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 18:05:16 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 16:05:16 +0000
Subject: [Koha-bugs] [Bug 8279] CAS Debugging improvements
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8279

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 18:07:26 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 16:07:26 +0000
Subject: [Koha-bugs] [Bug 8205] Should be possible to hide unused
	authorities in OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205

--- Comment #12 from Paul Poulain  ---
(In reply to comment #11)
> Lots of other information and links to other places on the web could be put
> into an Authority record, even if no biblios are connected to it.  It'd be
> much like a biblio with no attached items, but a valid URL (856 in MARC21)
> or Analytic entry.
OK, it's a valid argument, will push this patch with the syspref then.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 18:56:31 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 16:56:31 +0000
Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch?
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

Robin Sheat  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |robin at catalyst.net.nz

--- Comment #12 from Robin Sheat  ---
You should be using xsl:choose / xsl:when for those kinds of conditionals I
think. xsl:if tends to be used for doing things like assigning a value based on
a choice. I guess they're semantically different (I expect that xsl:if
shortcuts, but I haven't finished reading the book on XSLT.)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 18:58:54 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 16:58:54 +0000
Subject: [Koha-bugs] [Bug 7475] Option to overlay authorities
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7475

Jared Camins-Esakov  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10423|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 18:59:36 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 16:59:36 +0000
Subject: [Koha-bugs] [Bug 7475] Option to overlay authorities
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7475

Jared Camins-Esakov  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #8 from Jared Camins-Esakov  ---
Patches are available in the bug_2060 branch in my repository:
https://github.com/jcamins/koha.git

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 18:59:50 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 16:59:50 +0000
Subject: [Koha-bugs] [Bug 2060] Ability to import Authorities from Staff
	Client
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2060

Jared Camins-Esakov  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #1 from Jared Camins-Esakov  ---
Patches are available in the bug_2060 branch in my repository:
https://github.com/jcamins/koha.git

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 19:03:00 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 17:03:00 +0000
Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch?
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #13 from Katrin Fischer  ---

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 19:07:58 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 17:07:58 +0000
Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch?
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #14 from Robin Sheat  ---
Yeah, ignore what I said, it's not right :)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 19:11:20 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 17:11:20 +0000
Subject: [Koha-bugs] [Bug 7441] search results showing wrong branch?
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441

--- Comment #15 from Jared Camins-Esakov  ---
I recommend using "items:$OPACResultsByBranchXSLT" in your key (eliminating the
if). Also, don't forget to declare your variables, and note that you will need
to declare the variable prior to its use. Also, remember to use 
instead of if when choosing between multiple options (in the "Copies available
for loan" stanza).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 20:09:57 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 18:09:57 +0000
Subject: [Koha-bugs] [Bug 8325] autofill tags in the opac
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8325

Helen Linda  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |helen.linda at goddard.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 20:21:55 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 18:21:55 +0000
Subject: [Koha-bugs] [Bug 8325] autofill tags in the opac
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8325

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 20:50:58 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 18:50:58 +0000
Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly,
 and mostly useless
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204

--- Comment #1 from Jared Camins-Esakov  ---
Created attachment 10545
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10545&action=edit
Bug 8204: Add user friendly authority view to OPAC

Up until now, the only authority view in the OPAC was a
rather-unfriendly expanded MARC view. This patch adds a user-friendly
view similar to the biblio details view.

Specific features to be aware of:
* Right-to-left text in the MARC21 880 field will show up in the
  appropriate location with the appropriate alignment and wrapping
* There is very little CSS styling. Any suggestions for how to make
  the display more attractive would be gratefully received.

To test:
1) Do a search for an authority in the OPAC.
2) Choose an authority record to view.
3) Observe that the view is more user-friendly and polished.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 20:52:19 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 18:52:19 +0000
Subject: [Koha-bugs] [Bug 8204] Authority viewer in OPAC ugly, unfriendly,
 and mostly useless
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8204

Jared Camins-Esakov  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 21:44:15 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 19:44:15 +0000
Subject: [Koha-bugs] [Bug 8327] New: group item types together
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8327

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8327
                CC: m.de.rooy at rijksmuseum.nl
          Assignee: gmcharlt at gmail.com
           Summary: group item types together
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: nengard at gmail.com
          Hardware: All
            Status: NEW
           Version: master
         Component: Cataloging
           Product: Koha

I would love to see the ability to add another layer to item types, maybe
called item group. So, say you have DVD, CD, Music, etc, these things could
live under the umbrella of an Item Group called maybe Audiovisual. This would
enable us to put circulation rules on a group that would affect all items in
the group, which would be more congruous with the kinds of policies that
libraries tend to have.

For instance, our policy on A/V materials is that a patron may only have 5 at a
time. However, in the Circ & Fine rules, the only way we could address this was
by give all of our A/V types a limit of 5 and then we have to be paying
attention to each account to be sure that someone isn't taking out 5 DVD's and
then 5 CD's. If there were an additional layer that could group them together,
it could serve as a way to apply a limit on the whole group of item types.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 21:46:30 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 19:46:30 +0000
Subject: [Koha-bugs] [Bug 8328] New: max checkouts per time period
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8328

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8328
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
          Assignee: koha-bugs at lists.koha-community.org
           Summary: max checkouts per time period
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: nengard at gmail.com
          Hardware: All
            Status: NEW
           Version: master
         Component: Circulation
           Product: Koha

We are puzzling over the possibility of limiting the number of certain items
that a student may check out over the course of their whole semester. So,
currently we have a limit of 10 ILL items at a time, but they could return
those 10 and get 10 more. What if we wanted to create limits on item types that
affect a time period. So, effectively, the limit would be 10 ILL items at a
time AND 20 ILL items over the course of a semester.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 21:49:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 19:49:25 +0000
Subject: [Koha-bugs] [Bug 8327] group item types together
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8327

Helen Linda  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |helen.linda at goddard.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 21:52:18 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 19:52:18 +0000
Subject: [Koha-bugs] [Bug 8328] max checkouts per time period
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8328

Helen Linda  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |helen.linda at goddard.edu

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Wed Jun 27 22:02:48 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 27 Jun 2012 20:02:48 +0000
Subject: [Koha-bugs] [Bug 8327] group item types together
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8327

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #1 from Katrin Fischer  ---
I am not sure adding another level of complexity to the circulation rules would
work out very well - we already have to fix lots of stuff in there :)

I think maybe the itemtypes could be used differently? If you make the
"itemtype" what determines your circulation rule, in your example "Audiovisual"
and maybe use the collection code to differentiate between different types of
audiovisuals?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 08:08:18 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 06:08:18 +0000
Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title
 with borrower's age without using categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

--- Comment #32 from Marc V?ron  ---
Hmm, maybe a calculation issue with the birth date. What is the birthdate of
the patron you tested with?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 09:20:43 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 07:20:43 +0000
Subject: [Koha-bugs] [Bug 6350] Bug for tracking updates to the history file
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6350

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 09:21:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 07:21:25 +0000
Subject: [Koha-bugs] [Bug 8205] Should be possible to hide unused
	authorities in OPAC
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8205

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 09:21:48 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 07:21:48 +0000
Subject: [Koha-bugs] [Bug 6350] Bug for tracking updates to the history file
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6350

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10442|0                           |1
        is obsolete|                            |

--- Comment #12 from M. de Rooy  ---
Created attachment 10546
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10546&action=edit
Signed patch for 6350

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 09:22:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 07:22:12 +0000
Subject: [Koha-bugs] [Bug 6350] Bug for tracking updates to the history file
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6350

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #13 from M. de Rooy  ---
Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 09:30:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 07:30:04 +0000
Subject: [Koha-bugs] [Bug 6939] DefaultClassificationSource not used in 942$2
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6939

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_8

--- Comment #4 from Paul Poulain  ---
(I haven't tested this patch, as I don't have classificationSource field /
MARC21 in my test setup)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 09:34:47 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 07:34:47 +0000
Subject: [Koha-bugs] [Bug 8062] Cart email broken for non english templates
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8062

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #23 from M. de Rooy  ---
(In reply to comment #21)
> I think this patch introduces a bug:
> 
> +use HTML::FormatText;
> 
> this isn't mentioned in the dependency list, and doesn't appear to be used
> in the code. Thus, opac-sendbasket.pl breaks unless you happen to have that
> module installed. Can someone confirm that this is the case?

Confirmed: Can't locate HTML/FormatText.pm in @INC

Paul: When you passed this through QA, you mentioned the new dependency. But
nothing was done in a followup for dependency list, etc. ?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 09:51:21 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 07:51:21 +0000
Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl

--- Comment #5 from M. de Rooy  ---
Kyle,
Your patch now removes the feature of an anonymous user putting books into the
cart and mailing them. Would it not be enough to check if the cart is not empty
instead of forcing login now? 
Should we discuss restricting all email functionality in Koha to authenticated
users? Or add yet another pref :-)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 09:56:31 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 07:56:31 +0000
Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

Katrin Fischer  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #6 from Katrin Fischer  ---
Hi Marcel, not sure that was Kyle - there is bug 4274 for the problem. It used
to be possible for not logged in users to mail the cart (I know it was in
3.2.x). Then it got changed some time after that. Now it requires you to log in
before you can send items from the cart.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:06:19 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 08:06:19 +0000
Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

--- Comment #7 from M. de Rooy  ---
(In reply to comment #6)
> Hi Marcel, not sure that was Kyle - there is bug 4274 for the problem. It
> used to be possible for not logged in users to mail the cart (I know it was
> in 3.2.x). Then it got changed some time after that. Now it requires you to
> log in before you can send items from the cart.

It is still possible in master. I just did ??

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:09:41 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 08:09:41 +0000
Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

--- Comment #8 from Katrin Fischer  ---
Perhaps it changed again? :( I tested on 3.6.3.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:19:08 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 08:19:08 +0000
Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

--- Comment #9 from M. de Rooy  ---
(In reply to comment #8)
> Perhaps it changed again? :( I tested on 3.6.3.

No, it is not possible. Somehow I cannot reproduce anymore what I did before..

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:24:07 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 08:24:07 +0000
Subject: [Koha-bugs] [Bug 4274] Cart now requires login before emailing
	contents
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4274

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=3280

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:24:07 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 08:24:07 +0000
Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=4274

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:38:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 08:38:33 +0000
Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

--- Comment #10 from M. de Rooy  ---
OK. The patch came from Frere Sebastien Marie. And current master does not
allow anynomous users here (anymore).

One question remains: It works for me. But if you change the From address to
the patron's address, could we have Relay Access Denied errors or similar? A
mail server could reject outgoing mail if not sent from designated domains?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 10:46:52 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 08:46:52 +0000
Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

--- Comment #11 from Fr?re S?bastien Marie  ---
(En r?ponse au commentaire 10)
> One question remains: It works for me. But if you change the From address to
> the patron's address, could we have Relay Access Denied errors or similar? A
> mail server could reject outgoing mail if not sent from designated domains?

Yes, it is possible that mail will be reported as spam, if the patron address
use SPF (spam prevention system based on whitelist of smtp authorised to send
email for particuliar domain).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 11:06:31 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 09:06:31 +0000
Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

--- Comment #12 from Fr?re S?bastien Marie  ---
(En r?ponse au commentaire 11)
> (En r?ponse au commentaire 10)
> > One question remains: It works for me. But if you change the From address to
> > the patron's address, could we have Relay Access Denied errors or similar? A
> > mail server could reject outgoing mail if not sent from designated domains?
> 
> Yes, it is possible that mail will be reported as spam, if the patron
> address use SPF (spam prevention system based on whitelist of smtp
> authorised to send email for particuliar domain).

So it is possible to remove using GetFirstValidEmailAddress($borrowernumber) as

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 11:27:39 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 09:27:39 +0000
Subject: [Koha-bugs] [Bug 8329] New: GetLostItems in C4::Items.pm has a
	SELECT *
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8329

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8329
          Assignee: gmcharlt at gmail.com
           Summary: GetLostItems in C4::Items.pm has a SELECT *
          Severity: major
    Classification: Unclassified
                OS: All
          Reporter: mtompset at hotmail.com
          Hardware: All
            Status: NEW
           Version: unspecified
         Component: Reports
           Product: Koha

my $query   = "
        SELECT *
        FROM   items
            LEFT JOIN biblio ON (items.biblionumber = biblio.biblionumber)
            LEFT JOIN biblioitems ON (items.biblionumber =
biblioitems.biblionumber)
            LEFT JOIN authorised_values ON (items.itemlost =
authorised_values.authorised_value)
        WHERE
                authorised_values.category = 'LOST'
                AND itemlost IS NOT NULL
                AND itemlost <> 0
    ";

We're using 3.6.3, and I comfirmed this is in 3.6.6. This problem would only be
obvious if there are many lost items. It is a hellish query as we have 39,000+
"lost" items. We're in the midst of doing data entry/cleanup on a new system.

    my $query   = "
        SELECT title, author, lib, itemlost, authorised_value, barcode,
datelastseen, price, replacementprice, homebranch,
               itype, itemtype, holdingbranch, location, itemnotes,
items.biblionumber as biblionumber
        FROM   items
            LEFT JOIN biblio ON (items.biblionumber = biblio.biblionumber)
            LEFT JOIN biblioitems ON (items.biblionumber =
biblioitems.biblionumber)
            LEFT JOIN authorised_values ON (items.itemlost =
authorised_values.authorised_value)
        WHERE
                authorised_values.category = 'LOST'
                AND itemlost IS NOT NULL
                AND itemlost <> 0
";

This is functional, though it can probably be trimmed. The SELECT * includes
XML and MARC fields which are sizable and eat system memory!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 11:29:37 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 09:29:37 +0000
Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

Fr?re S?bastien Marie  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10027|0                           |1
        is obsolete|                            |

--- Comment #13 from Fr?re S?bastien Marie  ---
Created attachment 10547
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10547&action=edit
Bug 3280 Restrict Send basket feature

I was add a Reply-To field to email sended. So user receiving basket known who
send it.

The From field keep 'KohaAdminEmailAddress'. So it should not have spam problem
(if KohaAdminEmailAddress is configured appropriately) as noted by M. de Rooy.

Thanks from (past and future) comments.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 11:42:30 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 09:42:30 +0000
Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10547|0                           |1
        is obsolete|                            |

--- Comment #14 from M. de Rooy  ---
Created attachment 10548
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10548&action=edit
Signed patch for 3280

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 11:42:51 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 09:42:51 +0000
Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
         QA Contact|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
                   |ity.org                     |

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 11:46:13 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 09:46:13 +0000
Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #15 from M. de Rooy  ---
QA Comment:
Small patch. Code looks good to me. Idea of Reply-to address seems to me a good
approach as compared to changing the From address.
Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 11:54:34 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 09:54:34 +0000
Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

--- Comment #16 from M. de Rooy  ---
(In reply to comment #3)
> Does opac/opac-sendshelf.pl should be have a separated bug report ?
> As there have same features (send email to someone), corrections (or
> enhancements) should be consistent.

Sebastien: You could also adjust the title of this report, take over the
assignee field (you wrote the patch, not Galen) and submit another patch for
send-shelf. That would be great!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 12:06:46 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 10:06:46 +0000
Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff
	search)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10346|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 12:07:08 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 10:07:08 +0000
Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff
	search)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217

--- Comment #14 from M. de Rooy  ---
Followup: Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 12:07:16 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 10:07:16 +0000
Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff
	search)
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217

M. de Rooy  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA
                 CC|                            |m.de.rooy at rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 12:35:08 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 10:35:08 +0000
Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title
 with borrower's age without using categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

--- Comment #33 from delaye  ---
birthdate of the borrower : 19/05/2001

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 12:56:15 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 10:56:15 +0000
Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title
 with borrower's age without using categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

--- Comment #34 from Marc V?ron  ---
Thanks again for testing.

I have to rebase to the current master, will try to get it done this evening.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 13:50:00 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 11:50:00 +0000
Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title
 with borrower's age without using categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

--- Comment #35 from delaye  ---
it's work!!!...
thank you!!

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 14:01:01 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 12:01:01 +0000
Subject: [Koha-bugs] [Bug 8130] attach PDF files to a patron record
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8130

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_10

--- Comment #19 from Paul Poulain  ---
Patch pushed, but I think it would be usefull to have the list of attached
files available on the moremembers.pl page (and maybe also on the check-out
page)
The use case that has been given make interesting for a librarian to see
quickly if there are files attached to ask for missing ones.

Exemple: I'm supposed to give a proof of address every year. On the check-out
page, when my card is entered, Koha display "Patron Paul Poulain, currently 0
issues, 1 file attached (10/01/2010) => I haven't updated my proof of address

(that's just an example)

However : the moremember.pl page is really crapy now and would not deserve a
large update. But that's another topic !

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 14:02:50 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 12:02:50 +0000
Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title
 with borrower's age without using categories
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

--- Comment #36 from Marc V?ron  ---
Merveilleux, un grand merci!
Marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 14:08:20 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 12:08:20 +0000
Subject: [Koha-bugs] [Bug 8318] update StatisticsFields description
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Patch doesn't apply
                 CC|                            |paul.poulain at biblibre.com

--- Comment #4 from Paul Poulain  ---
mmm... the patch does not apply, probably because I fixed the yaml syntax
recently. Could you rebase & resubmit, I don't want to do a mistake (directly
passed QA status)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 14:09:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 12:09:33 +0000
Subject: [Koha-bugs] [Bug 8319] headings on statistics tab are confusing
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8319

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 14:10:27 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 12:10:27 +0000
Subject: [Koha-bugs] [Bug 8313] add ASHS to 'Koha team' page,
 for sponsorship of the 'star-ratings' feature
In-Reply-To: 
References: 
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8313

Paul Poulain  changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 14:44:07 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 12:44:07 +0000
Subject: [Koha-bugs] [Bug 8330] New: Overdue mail link contains
	untranslatable strings
Message-ID: 

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8330

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8330
                CC: frederic at tamil.fr
          Assignee: koha-bugs at lists.koha-community.org
           Summary: Overdue mail link contains untranslatable strings
          Severity: minor
    Classification: Unclassified
                OS: All
          Reporter: katrin.fischer at bsz-bw.de
          Hardware: All
            Status: NEW
           Version: master
         Component: I18N/L10N
           Product: Koha

The overdue with fines report contains email links with a subject line:
Overdue: 

The "Overdue" is not translatable.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 15:30:54 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 13:30:54 +0000
Subject: [Koha-bugs] [Bug 7412] Pre-filling items in cataloguing
In-Reply-To: <bug-7412-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7412-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7412-70-xPbOnKhlyi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7412

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |m.de.rooy at rijksmuseum.nl
         QA Contact|koha.sekjal at gmail.com       |m.de.rooy at rijksmuseum.nl

--- Comment #24 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
Just some questions before starting QA on this one:
Why do you need two new prefs?
At first glance through code, I see a lot of testing on barcode and read about
tricky cookie handling: Could you please explain? If you do not want to copy
barcode, you should just not put it in the prefill? How exactly do you use this
new cookie?
Is the commit message outdated?
Since we also have default values in framework, we have Add & Duplicate, what
exacly make this feature so needed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 15:55:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 13:55:25 +0000
Subject: [Koha-bugs] [Bug 8302] Add accesssion number to the drop down list
 in OPAC Search.
In-Reply-To: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8302-70-zeeuBpW7Az@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |colin.campbell at ptfs-europe.
                   |                            |com

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Actually the patch adds a barcode search. That is not necessarily what a given
library calls its accession number

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 15:59:10 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 13:59:10 +0000
Subject: [Koha-bugs] [Bug 8302] Add accesssion number to the drop down list
 in OPAC Search.
In-Reply-To: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8302-70-JFX50sgcHE@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10452|0                           |1
           is patch|                            |
  Attachment #10452|application/octet-stream    |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 16:01:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 14:01:25 +0000
Subject: [Koha-bugs] [Bug 8302] Add accesssion number to the drop down list
 in OPAC Search.
In-Reply-To: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8302-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8302-70-tw60msNA23@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8302

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Meenakshi, please remember to tick the "patch" checkbox when uploading a
patch or use "git bz". This way the patch can be viewed corrrectly in Bugzilla.
I think the description should probably be changed to barcode, because that's
what Koha's term for that field. Also we already have a barcode search option
in the staff search.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 16:27:19 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 14:27:19 +0000
Subject: [Koha-bugs] [Bug 8250] can't leave barcode blank when adding serial
	items
In-Reply-To: <bug-8250-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8250-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8250-70-lt2uaR56Cv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8250

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Looks like you can leave it blank once and it can add a barcode of '' whereas
it should assume that '' means barcode not defined.
Logic change to validate that the barcode input is barcode input should be
simple enough.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 16:30:15 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 14:30:15 +0000
Subject: [Koha-bugs] [Bug 8318] update StatisticsFields description
In-Reply-To: <bug-8318-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8318-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8318-70-EnlCzPkYun@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Patch doesn't apply         |Signed Off

--- Comment #5 from Nicole C. Engard <nengard at gmail.com> ---
Paul,

I just did a fetch from master and applied the patch just fine ...

nengard at kohavm:~/kohaclone$ git bz apply 8318
Bug 8318 - update StatisticsFields description

[SIGNED-OFF] Bug 8318: Update StatisticsFields preference language
Apply? [yn] y

Applying: Bug 8318: Update StatisticsFields preference language
nengard at kohavm:~/kohaclone$

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 16:42:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 14:42:24 +0000
Subject: [Koha-bugs] [Bug 5725] Batch modifications for Biblios
In-Reply-To: <bug-5725-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5725-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5725-70-gbT59DxavG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5725

Gaetan Boisson <gaetan.boisson at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Patch doesn't apply
                 CC|                            |gaetan.boisson at biblibre.com

--- Comment #57 from Gaetan Boisson <gaetan.boisson at biblibre.com> ---
I wanted to give it a try in order to see what can be done on the documentation
side so that this patch passe QA but it doesn't apply :

Applying: Suggested change to Bug 5725 - Batch modifications for Biblios
error: patch failed: koha-tmpl/intranet-tmpl/prog/en/js/basket.js:434
error: koha-tmpl/intranet-tmpl/prog/en/js/basket.js: patch does not apply
error: patch failed:
koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt:86
error: koha-tmpl/intranet-tmpl/prog/en/modules/basket/basket.tt: patch does not
apply

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 17:37:13 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 15:37:13 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To: <bug-7167-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7167-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7167-70-yF30ZxA4Wi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9859|0                           |1
        is obsolete|                            |
   Attachment #9860|0                           |1
        is obsolete|                            |
  Attachment #10033|0                           |1
        is obsolete|                            |
  Attachment #10034|0                           |1
        is obsolete|                            |

--- Comment #72 from Jonathan Druart <jonathan.druart at biblibre.com> ---
Created attachment 10549
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10549&action=edit
New version for updatedatabase

At last, I come back ! :)

(In reply to comment #70)
> QA comment:


> For simplicity, I recommend to remove the YAML file and associated code.

Done

> Skeleton: I see it in a regex as well as some code inserting into foo.
> Assume that it was used in testing. Please remove it.

Done

> Mainpage: Some code was removed from Auth.pm. The version check is now in
> mainpage.pl itself. I would rather have that check in an appropriate module.
> It was in Auth.pm. You could leave it there? I think we should let the
> version check stay within the scope of the checkauth call included in the
> get_user_and_template call. (See also comment on Auth.pm below).

New routine C4::Update::Database::is_uptodate() called on mainpage.pl
The idea is to update the source code AND see the admin page
(admin/updatedatabase.pl) to check if the database is up to date.

> Note that there is some problem in current code, that forces me to login
> twice when there is an update available. (It redirects to
> admin/updatedatabase, but I must relogin again.)

I can't reproduce this error, then I can't fix it. Can you give me more details
please ?

> Upgrading: When coming from an older version (before 3.9.0.x), you should
> run the old updatedatabase and after that you should run the new dbrevs in
> the dbrev directories. This is currently done in two passes. First it runs
> the old update. You think that it is ready. When you login, you are prompted
> to the new update form. It should not be too difficult to merge this into
> one pass (less confusing). Please adjust install.pl for that: You should
> check if it is still needed to call the old update before running the new
> one (for numbered dbrevs only).

I don't know how I can do this simply and properly. if someone feels
motivated...

> File structure: As mentioned above, make directories for a Koha release.
> Getting all updates means fetching the updates from a few directories. This
> makes the feature more future-proof.

I create all of .sql and .pl until version 3.09.00.018 (current master)

> Stable version: The md5 test will be of good use here! If we backport this
> to 3.8.X, we could already check what updates we already have run from 3.9
> folder with the md5 checksum. When upgrading from 3.8 to 3.10, some dbrevs
> are new, others will be incorporated already. So this remark only serves the
> purpose of discussing "Should we also get this into stable already (within
> reasonable time)?".

Now, we can "mark as ok" versions which are already executed. (Else, we had to
delete manually the corresponding file)

> admin/updatedatabase.pl: Line 33 adds a fixme to new code: Add a new flag?
Finally I use the "parameters" flag. I don't know if we want a special
permission.

> Commit message: please make it up-to-date. E.g. section on installdir.
Done

+ Errors are now translatable

This patch squashes the 3 others.

I switch back to needs signed-off (A quick signed off is needed)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 17:37:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 15:37:25 +0000
Subject: [Koha-bugs] [Bug 7167] updatedatabase improvements
In-Reply-To: <bug-7167-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7167-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7167-70-S9sAUeG4xk@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7167

Jonathan Druart <jonathan.druart at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 17:48:08 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 15:48:08 +0000
Subject: [Koha-bugs] [Bug 8331] New: hidden field does not work accurately
Message-ID: <bug-8331-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8331

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8331
          Assignee: gmcharlt at gmail.com
           Summary: hidden field does not work accurately
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: epietrocupo.hlhl at ssss.gouv.qc.ca
          Hardware: All
            Status: NEW
           Version: rel_3_6
         Component: MARC Bibliographic data support
           Product: Koha

There is this bug that seem similar

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1756

But it does not seem to solve my problem. The hidden field does not hide what
it should hide. The first problem is the documentation which is simply
illogical if it's a simple bitfield:

---------------------------------------
9 => Future use
-8 => Flag
-7 => OPAC !Intranet !Editor Collapsed
-6 => OPAC Intranet !Editor !Collapsed
-5 => OPAC Intranet !Editor Collapsed
-4 => OPAC !Intranet !Editor !Collapsed
-3 => OPAC !Intranet Editor Collapsed
-2 => OPAC !Intranet Editor !Collapsed
-1 => OPAC Intranet Editor Collapsed
0 => OPAC Intranet Editor !Collapsed
1 => !OPAC Intranet Editor Collapsed
2 => !OPAC !Intranet Editor !Collapsed
3 => !OPAC !Intranet Editor Collapsed
4 => !OPAC Intranet Editor !Collapsed
5 => !OPAC !Intranet !Editor Collapsed
6 => !OPAC Intranet !Editor !Collapsed
7 => !OPAC Intranet !Editor Collapsed
8 => !OPAC !Intranet !Editor !Collapsed
9 => Future use
---------------------------------------

If you try to find the binary pattern in this you will not be able to do it.
For example, I found that the 3rd bit ( value 4 ) trigers the display in the
editor. According to the table above, 4 does not trigger it, but 5 does. But 5
is a combination of 4 and 1, so if 5 does, than 4 should block it too since 1
since used for collapsing.

According to my tests:

Bit 1 (value 1): Trigger the collapsing
Bit 2 (value 2): does nothing
Bit 3 (value 4): Hide the field from the editor
Bit 4 (value 8): does nothing
Sign Bit (+/-): does nothing

Which leave the following options not working:
Hide in OPAC
Hide in Intranet

I tried it with field 590 and field 300 which both are shown in OPAC and
intranet.

I was wondering if there could be something else that could override the the
hidden field.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 21:19:43 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 19:19:43 +0000
Subject: [Koha-bugs] [Bug 8003] Tag "" is not a valid tag. at
 /usr/share/koha/lib/C4/Biblio.pm line 2045
In-Reply-To: <bug-8003-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8003-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8003-70-slz6mjn2Xc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8003

Damon Posey <damonp at ibethel.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |damonp at ibethel.org

--- Comment #2 from Damon Posey <damonp at ibethel.org> ---
Koha Version 3.05.00.008
Perl Version 5.010001
mysql Ver 14.14 Distrib 5.1.63, for debian-linux-gnu (x86_64) using readline
6.1
Server version: Apache/2.2.16 (Debian)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 22:52:16 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 20:52:16 +0000
Subject: [Koha-bugs] [Bug 7621] Circulation: Match age restriction of title
 with borrower's age without using categories
In-Reply-To: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7621-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7621-70-jOAn8yTNCs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7621

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10395|0                           |1
        is obsolete|                            |

--- Comment #37 from Marc V?ron <veron at veron.ch> ---
Created attachment 10550
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10550&action=edit
BUG 7621 [ENH] Circulation: Match age restriction of title with borrower's age
without using categories

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

New version implementing Paul's advice.
See Wiki http://wiki.koha-community.org/wiki/Age_restrictiotion

Rebased version. (Koha version: 3.09.00.018)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Thu Jun 28 23:23:00 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 21:23:00 +0000
Subject: [Koha-bugs] [Bug 6138] Show local help and isbd punctuation
 automatically when we are cataloguing
In-Reply-To: <bug-6138-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6138-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6138-70-k0ezSNj9oO@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6138

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |veron at veron.ch

--- Comment #7 from Marc V?ron <veron at veron.ch> ---
Wanted to sign off, but it does not apply, sorry.

Marc

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 00:28:26 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 22:28:26 +0000
Subject: [Koha-bugs] [Bug 8332] New: Add relationships to auth_finder for
	authority links
Message-ID: <bug-8332-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8332

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8332
          Assignee: jcamins at cpbibliography.com
           Summary: Add relationships to auth_finder for authority links
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: jcamins at cpbibliography.com
          Hardware: All
            Status: NEW
           Version: master
         Component: MARC Authority data support
           Product: Koha

In addition to the work in bug 8207 that enables auth_finder use, it would be
very useful when creating authorities to have the auth_finder plugin
automatically fill out the relationship information in $w (in MARC21).

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 00:55:52 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 22:55:52 +0000
Subject: [Koha-bugs] [Bug 8207] Modify authority type frameworks to allow
 see also fields to link to thesauri
In-Reply-To: <bug-8207-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8207-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8207-70-zA7dk61fep@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8207

--- Comment #1 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
Created attachment 10551
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10551&action=edit
Bug 8207: Allow see also fields in auths to link to thesauri

Right now if you were to link a field in an authority to a thesaurus, it
would not work properly. The authority type frameworks require some
adjustments to allow see also headings to be linked to thesauri (such as
adding subfield $9).

This patch adds subfield $9 and thesaurus links to existing installs
for those 5xx fields (under MARC21 and NORMARC only) which do not yet
have any subfield $9 or thesauri configured, as well as adding that to
new English language installs. There will be a follow-up patch adding
the subfields to new non-English language install files later, once
it is clear that the changes proposed and demonstrated in the English
files are accepable to the community.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 00:56:11 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 22:56:11 +0000
Subject: [Koha-bugs] [Bug 8332] Add relationships to auth_finder for
	authority links
In-Reply-To: <bug-8332-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8332-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8332-70-OHOAMWJ0fW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8332

--- Comment #1 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
Created attachment 10552
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10552&action=edit
Bug 8332: Add relationships to auth_finder for authority links

In addition to the work in bug 8207 that enables auth_finder use, it
would be very useful when creating authorities to have the auth_finder
plugin automatically fill out the relationship information in $w (in
MARC21).

To test (note that you must either apply the patch for bug 8207 or
manually add a thesaurus to a 5xx linking field in one of the authority
type frameworks):
1. Create a new authority record.
2. Go to the 5xx tab.
3. Click the authority control plugin ellipsis.
4. Do a search for an authority.
5. Select a relationship type.
6. Note that after you choose an authority, that the $w control field
   is automatically populated with the relationship type.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 00:56:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 22:56:24 +0000
Subject: [Koha-bugs] [Bug 8207] Modify authority type frameworks to allow
 see also fields to link to thesauri
In-Reply-To: <bug-8207-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8207-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8207-70-onIz72Sl6b@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8207

Jared Camins-Esakov <jcamins at cpbibliography.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |8332

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 00:56:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 22:56:24 +0000
Subject: [Koha-bugs] [Bug 8332] Add relationships to auth_finder for
	authority links
In-Reply-To: <bug-8332-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8332-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8332-70-bzBdAMjGtw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8332

Jared Camins-Esakov <jcamins at cpbibliography.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |8207

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 00:56:37 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 22:56:37 +0000
Subject: [Koha-bugs] [Bug 8207] Modify authority type frameworks to allow
 see also fields to link to thesauri
In-Reply-To: <bug-8207-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8207-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8207-70-MxUEY3HScC@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8207

Jared Camins-Esakov <jcamins at cpbibliography.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 00:56:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 22:56:59 +0000
Subject: [Koha-bugs] [Bug 8332] Add relationships to auth_finder for
	authority links
In-Reply-To: <bug-8332-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8332-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8332-70-51ztJGs2Ye@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8332

Jared Camins-Esakov <jcamins at cpbibliography.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
             Blocks|                            |8212
  Change sponsored?|---                         |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 00:56:59 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Jun 2012 22:56:59 +0000
Subject: [Koha-bugs] [Bug 8212] Omnibus bug report for C & P authority
	developments
In-Reply-To: <bug-8212-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8212-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8212-70-A0jdFPGuZ9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8212

Jared Camins-Esakov <jcamins at cpbibliography.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |8332

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 04:01:52 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 02:01:52 +0000
Subject: [Koha-bugs] [Bug 8333] New: Syntax error in misc/check-url.pl
Message-ID: <bug-8333-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8333

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8333
          Assignee: jcamins at cpbibliography.com
           Summary: Syntax error in misc/check-url.pl
          Severity: major
    Classification: Unclassified
                OS: All
          Reporter: jcamins at cpbibliography.com
          Hardware: All
            Status: ASSIGNED
           Version: master
         Component: Command-line Utilities
           Product: Koha

There is a syntax error in misc/check-url.pl, a semi-colon instead of a comma,
which means that the script does not work.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 04:03:03 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 02:03:03 +0000
Subject: [Koha-bugs] [Bug 8333] Syntax error in misc/check-url.pl
In-Reply-To: <bug-8333-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8333-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8333-70-g7McrdK8Kv@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8333

--- Comment #1 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
That's misc/cronjobs/check-url.pl, excuse me.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 04:05:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 02:05:04 +0000
Subject: [Koha-bugs] [Bug 8333] Syntax error in misc/check-url.pl
In-Reply-To: <bug-8333-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8333-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8333-70-PMmqrPH3r6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8333

Jared Camins-Esakov <jcamins at cpbibliography.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
Never mind. It's been fixed, but git doesn't seem to know.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 05:14:21 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 03:14:21 +0000
Subject: [Koha-bugs] [Bug 6138] Show local help and isbd punctuation
 automatically when we are cataloguing
In-Reply-To: <bug-6138-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6138-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6138-70-4k30PHzEqJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6138

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Patch doesn't apply

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 06:17:05 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 04:17:05 +0000
Subject: [Koha-bugs] [Bug 7839] Enhancement: Show routing lists attached to
 patron in Patron record
In-Reply-To: <bug-7839-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7839-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7839-70-ORvstsOPG0@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7839

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #9559|0                           |1
        is obsolete|                            |

--- Comment #13 from David Cook <dcook at prosentient.com.au> ---
Created attachment 10553
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10553&action=edit
Updated function name and SQL

I'm still getting accustomed to using the git, but hopefully this will do the
trick.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 06:17:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 04:17:33 +0000
Subject: [Koha-bugs] [Bug 7839] Enhancement: Show routing lists attached to
 patron in Patron record
In-Reply-To: <bug-7839-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7839-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7839-70-mBYuFgrROp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7839

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Failed QA                   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 06:19:49 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 04:19:49 +0000
Subject: [Koha-bugs] [Bug 7839] Enhancement: Show routing lists attached to
 patron in Patron record
In-Reply-To: <bug-7839-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7839-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7839-70-eVnqHQjKwd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7839

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10553|0                           |1
        is obsolete|                            |

--- Comment #14 from David Cook <dcook at prosentient.com.au> ---
Created attachment 10554
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10554&action=edit
Bug 7839 ENH: Show subscription routing lists attached to borrower in Patron
record.

Updated function name and SQL.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 08:39:47 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 06:39:47 +0000
Subject: [Koha-bugs] [Bug 4906] Problem with grace period calculation and
 fine intervals >1
In-Reply-To: <bug-4906-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4906-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4906-70-IAchnLMKpu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4906

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|kyle.m.hall at gmail.com       |katrin.fischer at bsz-bw.de

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 08:58:48 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 06:58:48 +0000
Subject: [Koha-bugs] [Bug 8314] Missing MARCISBNS param in opac-detail.pl
In-Reply-To: <bug-8314-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8314-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8314-70-HvhHY8SnR5@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8314

David Cook <dcook at prosentient.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|oleonard at myacpl.org         |dcook at prosentient.com.au

--- Comment #1 from David Cook <dcook at prosentient.com.au> ---
Created attachment 10555
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10555&action=edit
Bug 8314: Add MARCISBNs parameter to opac-detail.pl to show multiple isbns in
OPAC

Opac-detail.pl already runs GetMarcISBNs and stores them in an array where they
sit doing nothing. It looks like the template parameter was just missed.

It's a tough one to notice, since normalize_isbn will pick up the first isbn
and show it while quietly suppressing the rest.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 09:52:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 07:52:04 +0000
Subject: [Koha-bugs] [Bug 8314] Missing MARCISBNS param in opac-detail.pl
In-Reply-To: <bug-8314-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8314-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8314-70-Zn0o0JWgax@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8314

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10555|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 10556
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10556&action=edit
Bug 8314 Add MARCISBNs parameter to opac-detail.pl to show multiple isbns in
OPAC

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 09:53:01 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 07:53:01 +0000
Subject: [Koha-bugs] [Bug 8314] Missing MARCISBNS param in opac-detail.pl
In-Reply-To: <bug-8314-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8314-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8314-70-eFOfxJhutJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8314

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 09:56:06 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 07:56:06 +0000
Subject: [Koha-bugs] [Bug 7839] Enhancement: Show routing lists attached to
 patron in Patron record
In-Reply-To: <bug-7839-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7839-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7839-70-OTnIRmYzbl@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7839

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10554|0                           |1
           is patch|                            |
  Attachment #10554|application/octet-stream    |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 09:59:26 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 07:59:26 +0000
Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn
 jsPrintSetup and new staff client preference
In-Reply-To: <bug-7563-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7563-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7563-70-uNPIIbBQk6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10428|0                           |1
        is obsolete|                            |

--- Comment #23 from Marc V?ron <veron at veron.ch> ---
Created attachment 10557
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10557&action=edit
[REBASED] Bug 7563 [ENH] - Silent print slips using Firefox PlugIn jsPrintSetup
and new staff client preference

(Rebased to Koha version: 3.09.00.018)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 10:02:37 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 08:02:37 +0000
Subject: [Koha-bugs] [Bug 7839] Enhancement: Show routing lists attached to
 patron in Patron record
In-Reply-To: <bug-7839-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7839-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7839-70-oLJ0Ajd8r3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7839

--- Comment #15 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 10558
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10558&action=edit
Bug 7839 : Follow up, fixing copyright

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 10:50:45 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 08:50:45 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-fXFQwQB7GS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #7089|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 10559
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10559&action=edit
Bug 7421 Add UNIMARC DOM Filter

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 10:52:10 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 08:52:10 +0000
Subject: [Koha-bugs] [Bug 7421] UNIMARC authorities DOM indexing mode
In-Reply-To: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7421-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7421-70-b4ozIoFSEq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7421

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|PATCH-Sent (DO NOT USE)     |P4
             Status|Needs Signoff               |Signed Off
                 CC|                            |chris at bigballofwax.co.nz
  Change sponsored?|Seeking cosponsors          |---

--- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> ---
Applies cleanly, didn't break zebra, I can't vouch it works right for UNIMARC
but it doesn't break anything else.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 10:53:18 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 08:53:18 +0000
Subject: [Koha-bugs] [Bug 7869] Correct bad link to item in patron
	modification log
In-Reply-To: <bug-7869-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7869-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7869-70-OER8oNHCco@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7869

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> ---
Repeating Liz's question, is this still needed?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 11:07:40 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 09:07:40 +0000
Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a
 tag in the tag cloud isn't the number of items with that tag
In-Reply-To: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7642-70-MFdqNFKaW9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642

Robin Sheat <robin at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Stable            |ASSIGNED

--- Comment #17 from Robin Sheat <robin at catalyst.net.nz> ---
I've found this causes a regression: the tags no longer display in their
correct size, they all appear the same, as the value in the 'title' field was
used by javascript to calculate the font-size attribute.

I'm hoping to get this fixed in not too long.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 11:08:18 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 09:08:18 +0000
Subject: [Koha-bugs] [Bug 7642] The number that appears when hovering over a
 tag in the tag cloud isn't the number of items with that tag
In-Reply-To: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7642-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7642-70-exL5fcVoYH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7642

--- Comment #18 from Robin Sheat <robin at catalyst.net.nz> ---
Also, the size calculation logic should probably get moved to template toolkit
rather than javascript.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 11:23:47 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 09:23:47 +0000
Subject: [Koha-bugs] [Bug 8311] Mis-scoped function call in C4::Auth
In-Reply-To: <bug-8311-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8311-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8311-70-9lVrFms88T@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8311

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com

--- Comment #4 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment:

Why did you put the line 
        require C4::Members;
outside from
        if (!defined($borrowernumber) && defined($user)) {
?

The way you made it, C4::Members will be loaded on everypage, that will impact
performances !

Written:
    if (!defined($borrowernumber) && defined($user)) {
        require C4::Members;
        my $borrower = C4::Members::GetMember(borrowernumber => $user);
will load the C4::Members only if the getborrowernumber does not return the
user (which should never happen)

waiting for your feedback, not pushing not marking failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 11:26:12 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 09:26:12 +0000
Subject: [Koha-bugs] [Bug 8321] fix OPACShowBarcode description
In-Reply-To: <bug-8321-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8321-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8321-70-W5qxwcB3Jz@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8321

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 11:38:00 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 09:38:00 +0000
Subject: [Koha-bugs] [Bug 7161] Open Library - Larger image, Read,
 borrow and checked-out status
In-Reply-To: <bug-7161-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7161-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7161-70-FShz8LyedJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7161

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 11:39:06 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 09:39:06 +0000
Subject: [Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
In-Reply-To: <bug-8315-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8315-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8315-70-z8jSyd6CCN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10483|0                           |1
        is obsolete|                            |

--- Comment #8 from Paul Poulain <paul.poulain at biblibre.com> ---
Comment on attachment 10483
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10483
Bug 8315 - fix 'C4::Output 3.02' errors in Koha

Robin, seems you forgot to obsolete the original patch when you uploaded the
signed-off one

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 11:42:26 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 09:42:26 +0000
Subject: [Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
In-Reply-To: <bug-8315-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8315-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8315-70-umwaBELtac@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315

--- Comment #9 from Chris Cormack <chris at bigballofwax.co.nz> ---
This still needs a follow up for all the other version numbers Robin listed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 12:00:15 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 10:00:15 +0000
Subject: [Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
In-Reply-To: <bug-8315-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8315-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8315-70-pP11ze5VJh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10490|0                           |1
        is obsolete|                            |

--- Comment #10 from Paul Poulain <paul.poulain at biblibre.com> ---
Comment on attachment 10490
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10490
Bug 8315 - fix 'C4::Output 3.02' errors in Koha

This patch has been pushed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 12:01:22 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 10:01:22 +0000
Subject: [Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
In-Reply-To: <bug-8315-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8315-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8315-70-K2oHabVLxe@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |ASSIGNED
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_8
           Assignee|gmcharlt at gmail.com          |dpavlin at rot13.org

--- Comment #11 from Paul Poulain <paul.poulain at biblibre.com> ---
Switching back to "assigned", the patch provided has been pushed, other patches
welcomed !

Assigning to Dobrica, as you seem to be motivated by this topic ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 12:06:48 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 10:06:48 +0000
Subject: [Koha-bugs] [Bug 8311] Mis-scoped function call in C4::Auth
In-Reply-To: <bug-8311-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8311-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8311-70-dVzUCjDpGr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8311

--- Comment #5 from Jared Camins-Esakov <jcamins at cpbibliography.com> ---
(In reply to comment #4)
> QA comment:
> 
> Why did you put the line 
>         require C4::Members;
> outside from
>         if (!defined($borrowernumber) && defined($user)) {
> ?
> 
> The way you made it, C4::Members will be loaded on everypage, that will
> impact performances !

C4::Members was always loaded whenever $user was set. I just moved the require
up so that it was before *both* calls to routines in C4::Members (if you scroll
down about a page, you'll see a call to GetMemberDetails.

> Written:
>     if (!defined($borrowernumber) && defined($user)) {
>         require C4::Members;
>         my $borrower = C4::Members::GetMember(borrowernumber => $user);
> will load the C4::Members only if the getborrowernumber does not return the
> user (which should never happen)
> 
> waiting for your feedback, not pushing not marking failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 12:25:47 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 10:25:47 +0000
Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of
 bibliographic records
In-Reply-To: <bug-7818-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7818-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7818-70-SUtaPO57rG@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Attachment #8965|0                           |1
        is obsolete|                            |
   Attachment #8966|0                           |1
        is obsolete|                            |
   Attachment #8967|0                           |1
        is obsolete|                            |
   Attachment #8968|0                           |1
        is obsolete|                            |
   Attachment #8969|0                           |1
        is obsolete|                            |
   Attachment #8970|0                           |1
        is obsolete|                            |
   Attachment #8971|0                           |1
        is obsolete|                            |
   Attachment #8972|0                           |1
        is obsolete|                            |
   Attachment #8973|0                           |1
        is obsolete|                            |
   Attachment #8974|0                           |1
        is obsolete|                            |
   Attachment #9798|0                           |1
        is obsolete|                            |
   Attachment #9968|0                           |1
        is obsolete|                            |

--- Comment #40 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 10560
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10560&action=edit
Bug 7818 : Following, fixing so the packages build Still need to update
koha-create to make use of the new file

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 12:26:17 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 10:26:17 +0000
Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of
 bibliographic records
In-Reply-To: <bug-7818-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7818-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7818-70-OaqSsxq3WX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5 - low                    |P1 - high
             Status|Pushed to Stable            |ASSIGNED
           Severity|enhancement                 |critical

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 12:27:06 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 10:27:06 +0000
Subject: [Koha-bugs] [Bug 7818] support DOM mode for Zebra indexing of
 bibliographic records
In-Reply-To: <bug-7818-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7818-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7818-70-hlBtRIRDOa@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7818

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #41 from Chris Cormack <chris at bigballofwax.co.nz> ---
Patch to allow the packages to build. 

Still needs another followup to make use of the dom config, but at least now
the packages can build

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 12:57:20 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 10:57:20 +0000
Subject: [Koha-bugs] [Bug 8288] showmarc.tt should not include full
	doc-head-close.inc
In-Reply-To: <bug-8288-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8288-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8288-70-5j2fzvXfWg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8288

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable

--- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> ---
Bugfix pushed to 3.8.x, will be in 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 13:05:16 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 11:05:16 +0000
Subject: [Koha-bugs] [Bug 6939] DefaultClassificationSource not used in 942$2
In-Reply-To: <bug-6939-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6939-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6939-70-LfsHN3Se35@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6939

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 13:06:57 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 11:06:57 +0000
Subject: [Koha-bugs] [Bug 8313] add ASHS to 'Koha team' page,
 for sponsorship of the 'star-ratings' feature
In-Reply-To: <bug-8313-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8313-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8313-70-ky6tJ8G24Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8313

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
            Version|rel_3_10                    |rel_3_8

--- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> ---
Star ratings are in 3.8.x so pushing to there

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 14:24:52 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 12:24:52 +0000
Subject: [Koha-bugs] [Bug 8318] update StatisticsFields description
In-Reply-To: <bug-8318-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8318-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8318-70-UEZcSFiISW@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:24:57 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 13:24:57 +0000
Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused
In-Reply-To: <bug-6557-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6557-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6557-70-XbBxHMpDKx@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557

--- Comment #30 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 10561
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10561&action=edit
Bug 6557 follow-up UNIMARC 924$0 in default french frameworks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:25:28 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 13:25:28 +0000
Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused
In-Reply-To: <bug-6557-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6557-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6557-70-NB2FGxS8Ok@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10561|0                           |1
        is obsolete|                            |

--- Comment #31 from Paul Poulain <paul.poulain at biblibre.com> ---
Created attachment 10562
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10562&action=edit
Bug 6557 follow-up UNIMARC 942$0 in default french frameworks

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 15:58:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 13:58:25 +0000
Subject: [Koha-bugs] [Bug 6557] biblioitems.totalissues unused
In-Reply-To: <bug-6557-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6557-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6557-70-Eh6FWffEkh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_10

--- Comment #32 from Paul Poulain <paul.poulain at biblibre.com> ---
Patch pushed but NOTE :
* i've provided a follow-up for french UNIMARC frameworks, that had no 942$0 at
all, making the script badly fail:
$ misc/cronjobs/update_totalissues.pl --use-items
Tag "0" is not a valid tag. at /home/paul/koha.dev/koha-community//C4/Biblio.pm
line 3870

A follow-up could be written to add a more clear error message: if
biblioitems.totalissues isn't linked to a MARC field, issue a message before
dying.

* I'll also send a mail to koha-devel & koha-translate to warn ppl in case
there is another language framework that has this problem

* I'll advertise this patch in my RM newsletter

* chris_c = in my opinion, it's a bugfix, but a very long standing one, and, if
you want to backport it to 3.8, you'll have to write very clearly how to deal
with it in the release note ! (I think it [c|sh]ould wait for 3.10)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:13:07 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 14:13:07 +0000
Subject: [Koha-bugs] [Bug 7630] Warning on moremember.pl about param without
	key
In-Reply-To: <bug-7630-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7630-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7630-70-hOJRynPOfp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7630

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 10563
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10563&action=edit
Proposed Patch to the BUG

After getting a DEV install set up, I tweaked moremember.pl as described.
To trigger the error:
- Staff Client
- Login
- Patrons
- Search for a patron somehow and then look at their details.
- When moremember.pl is called, because there is no $error, it will trigger:
[Fri Jun 29 21:37:32 2012] [error] [client 192.168.69.34] [Fri Jun 29 21:37:32
2012] moremember.pl: Problem = a value of 1 has been passed to param without
key at /home/koha/kohaclone/C4/Templates.pm line 187., referer:
http://192.168.69.37:8080/

By moving the "$error => 1" to a conditional $template->param(), the error log
no longer gets spammed.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:16:53 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 14:16:53 +0000
Subject: [Koha-bugs] [Bug 7352] moremember.pl generates error in Template.pm
 related to missing $key value
In-Reply-To: <bug-7352-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7352-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7352-70-winCq09jAN@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7352

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
I believe the patch I just submitted to Bug 7630 will make this bug report
obsolete.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:17:31 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 14:17:31 +0000
Subject: [Koha-bugs] [Bug 8311] Mis-scoped function call in C4::Auth
In-Reply-To: <bug-8311-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8311-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8311-70-rFEPkB1zFn@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8311

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_8

--- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> ---
OK, got it. Patch pushed

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:22:05 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 14:22:05 +0000
Subject: [Koha-bugs] [Bug 8334] New: Authority UNIMARC 100 field plugin
Message-ID: <bug-8334-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8334

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8334
          Assignee: gmcharlt at gmail.com
           Summary: Authority UNIMARC 100 field plugin
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: vfernandes at keep.pt
          Hardware: All
            Status: NEW
           Version: unspecified
         Component: MARC Authority data support
           Product: Koha

There is no 100 authority field plugin. It would be nice to have it.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:27:38 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 14:27:38 +0000
Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
In-Reply-To: <bug-3280-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3280-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3280-70-CC09GXyVwo@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_8
           Assignee|gmcharlt at gmail.com          |semarie-koha at latrappe.fr

--- Comment #17 from Paul Poulain <paul.poulain at biblibre.com> ---
(assignee changed, to reflect who sent the patch)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:30:53 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 14:30:53 +0000
Subject: [Koha-bugs] [Bug 8172] Missing dereference marker for buildQuery
 parameter in addbooks.pl
In-Reply-To: <bug-8172-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8172-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8172-70-AmjoDUqUCU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172

--- Comment #2 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 10564
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10564&action=edit
Added a missing dereference marker for an array parameter.

As our library has been adding and editing lots of items, I have yet to see the
bug resurface. I think the patch is self-evident.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:47:55 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 14:47:55 +0000
Subject: [Koha-bugs] [Bug 8318] update StatisticsFields description
In-Reply-To: <bug-8318-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8318-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8318-70-xRQyNcLp3x@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8318

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_10

--- Comment #6 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to comment #5)
> Paul,
> 
> I just did a fetch from master and applied the patch just fine ...
??? That's strange, I get the following conflict:
134 <<<<<<< HEAD
135          - Define Fields (from the items table) used for statistics members
(separate fields with |, for example    :"location|itype|ccode").
136      -
137          - pref: EnableBorrowerFiles
138            choices:
139                yes: Do
140                no: "Don't"
141          - enable the ability to upload and attach arbitrary files to a
borrower record.
142 =======
143          - (separate fields with |)
144 >>>>>>> Bug 8318: Update StatisticsFields preference language


I've rewritten you patch, and pushed, this will remain a mistery

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:50:03 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 14:50:03 +0000
Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff
	search)
In-Reply-To: <bug-8217-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8217-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8217-70-pIEcsl0rLi@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
            Version|master                      |rel_3_8

--- Comment #15 from Paul Poulain <paul.poulain at biblibre.com> ---
Follow-up pushed on master branch directly, does not apply on new/bug_8217

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:52:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 14:52:04 +0000
Subject: [Koha-bugs] [Bug 8329] GetLostItems in C4::Items.pm has a SELECT *
In-Reply-To: <bug-8329-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8329-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8329-70-mauhN339eY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8329

--- Comment #1 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 10565
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10565&action=edit
Reduced memory requirements of a massive select statement

SELECT * joining items, bibioitems, and biblio is bad. The MARC and XML fields
will eat memory very quickly. Our server has ridiculously low memory and lots
of items marked as lost. We were getting Error 500 pages as output as a result.

Since the GetLostItems function is only used by the Items Lost report, I looked
at the template in reports/itemslost.tt to get an idea of what might better be
suited in the SELECT statement.

It was horribly slow, but finally worked. I need to get more than 512MB for our
server.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:53:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 14:53:24 +0000
Subject: [Koha-bugs] [Bug 6350] Bug for tracking updates to the history file
In-Reply-To: <bug-6350-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6350-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6350-70-5LXYql1xKs@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6350

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master

--- Comment #14 from Paul Poulain <paul.poulain at biblibre.com> ---
new patch pushed (on master branch, not new/bug_6350)

follow-up made because decmember is not a month afaik ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 16:58:16 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 14:58:16 +0000
Subject: [Koha-bugs] [Bug 6840] error in Template.pm in logs
In-Reply-To: <bug-6840-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-6840-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-6840-70-520jLbNFRY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6840

--- Comment #10 from M. Tompsett <mtompset at hotmail.com> ---
I have posted a patch on bug 7630 which should address Fred P's issues. This
patch is still live. I like it. It's a friendly warning, rather than an error
to track down.

Thanks to jcamins for helping me get my DEV setup done. :)

Can someone close this bug? It's not an issue, in my opinion.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:01:32 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 15:01:32 +0000
Subject: [Koha-bugs] [Bug 8329] GetLostItems in C4::Items.pm has a SELECT *
In-Reply-To: <bug-8329-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8329-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8329-70-04vsAlAYDr@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8329

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:01:56 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 15:01:56 +0000
Subject: [Koha-bugs] [Bug 8172] Missing dereference marker for buildQuery
 parameter in addbooks.pl
In-Reply-To: <bug-8172-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8172-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8172-70-DwNiR4DwZA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8172

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:04:19 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 15:04:19 +0000
Subject: [Koha-bugs] [Bug 7352] moremember.pl generates error in Template.pm
 related to missing $key value
In-Reply-To: <bug-7352-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7352-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7352-70-nQAM9wvJk6@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7352

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |DUPLICATE

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---


*** This bug has been marked as a duplicate of bug 7630 ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:04:19 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 15:04:19 +0000
Subject: [Koha-bugs] [Bug 7630] Warning on moremember.pl about param without
	key
In-Reply-To: <bug-7630-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7630-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7630-70-JW1HoE5rYy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7630

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fred.pierre at smfpl.org

--- Comment #4 from M. Tompsett <mtompset at hotmail.com> ---
*** Bug 7352 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:05:37 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 15:05:37 +0000
Subject: [Koha-bugs] [Bug 7630] Warning on moremember.pl about param without
	key
In-Reply-To: <bug-7630-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7630-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7630-70-kigQe2jytu@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7630

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:18:40 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 15:18:40 +0000
Subject: [Koha-bugs] [Bug 8175] Missing defined check in catalogue/details.pl
In-Reply-To: <bug-8175-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8175-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8175-70-jvs2Pk3S9X@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175

--- Comment #3 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 10566
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10566&action=edit
Undefined $items->{'materials'} fails a string check, so drop it.

Dropping the "ne ''" was more elegant.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:19:10 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 15:19:10 +0000
Subject: [Koha-bugs] [Bug 7444] Use T::T date plugin to display dates omnibus
In-Reply-To: <bug-7444-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7444-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7444-70-La9D33LPRB@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7444

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|gmcharlt at gmail.com          |koha.sekjal at gmail.com

--- Comment #18 from Paul Poulain <paul.poulain at biblibre.com> ---
(In reply to comment #17)
> Reverted from 3.8.x, so needs to be fixed before the 3.10.0 release

Patch also reverted from master. Switching status to failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:24:39 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 15:24:39 +0000
Subject: [Koha-bugs] [Bug 8175] Missing defined check in catalogue/details.pl
In-Reply-To: <bug-8175-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8175-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8175-70-BbxZzstm45@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8175

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 17:59:10 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 15:59:10 +0000
Subject: [Koha-bugs] [Bug 7955] Statistics tab in patron module
In-Reply-To: <bug-7955-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7955-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7955-70-zeG5NuQmf8@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7955

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA

--- Comment #21 from Nicole C. Engard <nengard at gmail.com> ---
Actually I think this is adding another Notices tab to the patron record. I see
Notices, Statistics, Notices on the left hand side.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 19:25:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 17:25:25 +0000
Subject: [Koha-bugs] [Bug 8335] New: Missing Icon PR.png or typo in
 MARC21slim2OPACDetail.xsl
Message-ID: <bug-8335-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8335

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8335
          Assignee: oleonard at myacpl.org
           Summary: Missing Icon PR.png or typo in
                    MARC21slim2OPACDetail.xsl
          Severity: minor
    Classification: Unclassified
                OS: All
          Reporter: veron at veron.ch
          Hardware: All
            Status: NEW
           Version: master
         Component: OPAC
           Product: Koha

koha-error_log complains the following:

File does not exist:
/usr/share/kohaclone/koha-tmpl/intranet-tmpl/prog/img/famfamfam/PR.png,
referer: http://(------)/cgi-bin/koha/catalogue/detail.pl?biblionumber=9

It seems that this is triggered by:
koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl

in follwoing lines:
<xsl:variable name="materialTypeCode">
(...)
<xsl:when test="$leader6='c' or $leader6='d'">PR</xsl:when>

Two possibilities:
- Icon PR.png is really missing
- Typo in MARC21slim2OPACDetail.xsl

Marc

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 19:36:41 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 17:36:41 +0000
Subject: [Koha-bugs] [Bug 8336] New: SIP Server does not process renewal
 transaction correctly
Message-ID: <bug-8336-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8336
                CC: colin.campbell at ptfs-europe.com
          Assignee: koha-bugs at lists.koha-community.org
           Summary: SIP Server does not process renewal transaction
                    correctly
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: colin.campbell at ptfs-europe.com
          Hardware: All
            Status: NEW
           Version: unspecified
         Component: SIP2
           Product: Koha

Sip renewal transactions are rejected by bogus error messages. If we suppress
that it is not setting some data correctly e.g. the new duedate. Most people
will not notice this as selfcheck units use the checkout transaction to do
renewal, however if you want to use Itiva/Talking Tech telephone renewals you
need to support this transaction.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:08:50 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 18:08:50 +0000
Subject: [Koha-bugs] [Bug 8336] SIP Server does not process renewal
	transaction correctly
In-Reply-To: <bug-8336-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8336-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8336-70-Dr358YZBlp@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
           Assignee|koha-bugs at lists.koha-commun |colin.campbell at ptfs-europe.
                   |ity.org                     |com

--- Comment #1 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Created attachment 10567
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10567&action=edit
Proposed Patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:24:05 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 18:24:05 +0000
Subject: [Koha-bugs] [Bug 8335] Missing Icon PR.png or typo in
	MARC21slim2OPACDetail.xsl
In-Reply-To: <bug-8335-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8335-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8335-70-6tH4JDhZRy@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8335

--- Comment #1 from Marc V?ron <veron at veron.ch> ---
Created attachment 10568
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10568&action=edit
Bug 8335 - Missing Icon PR.png or typo in MARC21slim2OPACDetail.xsl

Add PR.png (renamed file music.png from http://famfamfam.com/lab/icons/ )

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:25:49 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 18:25:49 +0000
Subject: [Koha-bugs] [Bug 8335] Missing Icon PR.png or typo in
	MARC21slim2OPACDetail.xsl
In-Reply-To: <bug-8335-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8335-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8335-70-7UiiFUGs60@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8335

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:26:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 18:26:04 +0000
Subject: [Koha-bugs] [Bug 8087] Calendar not working in dropbox mode
In-Reply-To: <bug-8087-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8087-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8087-70-Yr0OQmpJPg@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8087

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=5644

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:26:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 18:26:04 +0000
Subject: [Koha-bugs] [Bug 5644] fines not cleared with dropbox mode
In-Reply-To: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5644-70-e8VtmOd0SH@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644

Nicole C. Engard <nengard at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.koha-community.
                   |                            |org/bugzilla3/show_bug.cgi?
                   |                            |id=8087

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:28:38 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 18:28:38 +0000
Subject: [Koha-bugs] [Bug 8271] teach SIPServer to set its own lib path
In-Reply-To: <bug-8271-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8271-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8271-70-gZ9RpZF5vY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8271

Colin Campbell <colin.campbell at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

--- Comment #2 from Colin Campbell <colin.campbell at ptfs-europe.com> ---
Corrected status of this

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 20:33:41 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 18:33:41 +0000
Subject: [Koha-bugs] [Bug 5644] fines not cleared with dropbox mode
In-Reply-To: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5644-70-26Cey8gAKS@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644

Melia Meggs <melia at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |melia at bywatersolutions.com
           Severity|major                       |critical

--- Comment #5 from Melia Meggs <melia at bywatersolutions.com> ---
This bug is kind of a big deal.  Libraries need to be able to use dropbox mode
to prevent the fine calculation from happening in the morning when they are
checking in books that were put in the dropbox the night before.  Right now in
3.8, they are not able to backdate the checkin date, so fines are being
incorrectly charged on all books that come in from the dropbox.  That's a lot
of extra fines to remove manually every single day!  Can we fix just the
checkin date part of this without waiting on the entire Accountlines Rewrite?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 21:12:13 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 19:12:13 +0000
Subject: [Koha-bugs] [Bug 8337] New: System preferences for longoverdue cron
Message-ID: <bug-8337-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8337
          Assignee: gmcharlt at gmail.com
           Summary: System preferences for longoverdue cron
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: pelletiermaxime at gmail.com
          Hardware: All
            Status: NEW
           Version: rel_3_8
         Component: Command-line Utilities
           Product: Koha

Patch to follow that adds 3 new system preferences to control the parameters
for the longoverdue script.
New prefs are DefaultLongOverdueChargeValue, DefaultLongOverdueLostValue and
DefaultLongOverdueDays.
These preferences are used when you call the longoverdue.pl script without
their parameters.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 21:13:56 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 19:13:56 +0000
Subject: [Koha-bugs] [Bug 8337] System preferences for longoverdue cron
In-Reply-To: <bug-8337-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8337-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8337-70-Jt297BsTrq@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

Maxime Pelletier <pelletiermaxime at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Change sponsored?|---                         |Sponsored

--- Comment #1 from Maxime Pelletier <pelletiermaxime at gmail.com> ---
Sponsored by the koha-CCSR community.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 21:27:18 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 19:27:18 +0000
Subject: [Koha-bugs] [Bug 8337] System preferences for longoverdue cron
In-Reply-To: <bug-8337-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8337-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8337-70-OULHty9qns@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8337

--- Comment #2 from Maxime Pelletier <pelletiermaxime at gmail.com> ---
Created attachment 10569
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10569&action=edit
patch to add longoverdue syspref

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 21:34:36 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 19:34:36 +0000
Subject: [Koha-bugs] [Bug 7563] Silent print slips using Firefox PlugIn
 jsPrintSetup and new staff client preference
In-Reply-To: <bug-7563-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-7563-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-7563-70-WRfsGiQdt9@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7563

Marc V?ron <veron at veron.ch> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10557|0                           |1
        is obsolete|                            |

--- Comment #24 from Marc V?ron <veron at veron.ch> ---
Created attachment 10570
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10570&action=edit
[REBASED] Bug 7563 - Silent print slips using Firefox PlugIn jsPrintSetup and
new staff client preference

...to version 3.09.00.021

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:06:47 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 20:06:47 +0000
Subject: [Koha-bugs] [Bug 5644] fines not cleared with dropbox mode
In-Reply-To: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5644-70-L6KS273JrZ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644

--- Comment #6 from Chris Cormack <chris at bigballofwax.co.nz> ---
Hmm there are 2 different things here Melia.

Backdating the  checkin date, and wiping fines.

Backdating the checkin date always used to work, and was working with this bug
was logged. What wasn't working was that if the fines had already run things
were not wiped.

If you are saying now that you can't even backdate the checkin date that is a
different problem and something broken recently.

Is that the case? IF so, fixing the backdating will still not remove the fines,
but if the books are checked in before the fines script runs they will not get
fines added to them.

So .. is setting the backdate broken now too? Or can you still do that and is
the problem that you still don't wipe fines?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:31:40 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 20:31:40 +0000
Subject: [Koha-bugs] [Bug 5644] fines not cleared with dropbox mode
In-Reply-To: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5644-70-iKgML9mrEj@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644

--- Comment #7 from Melia Meggs <melia at bywatersolutions.com> ---
Ah ok. Thanks for the explanation.

I'm saying that backdating the checkin date is not working. (Maybe this needs a
new bug report?)  

The library runs the fines script at noon.  Before they upgraded to 3.8, they
used to checkin the books from the dropbox in the morning and backdate the
checkin date, so no fines were added for that day when the fines script ran at
noon.  Now they cannot backdate the checkin date, so fines get charged on those
books.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:36:32 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 20:36:32 +0000
Subject: [Koha-bugs] [Bug 5644] fines not cleared with dropbox mode
In-Reply-To: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5644-70-aby6GygFKf@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644

--- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> ---
Right that is a separate issue from the one nicole reported, which was an
ehancement request to wipe fines already charged.

Two choices, rename the description of this to be, dropbox mode doesnt set the
correct date and leave it critical, and make a new one for the wiping fines, an
ehancement, that is blocked by this. Or vice versa.

I'm looking into the dropbox not setting the date issue now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:41:37 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 20:41:37 +0000
Subject: [Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date
In-Reply-To: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5644-70-VPAx94mrqm@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644

Melia Meggs <melia at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|fines not cleared with      |dropbox mode doesn't set
                   |dropbox mode                |the correct date

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:46:25 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 20:46:25 +0000
Subject: [Koha-bugs] [Bug 8338] New: fines not cleared with dropbox mode
Message-ID: <bug-8338-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8338
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
          Assignee: koha-bugs at lists.koha-community.org
           Summary: fines not cleared with dropbox mode
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: melia at bywatersolutions.com
          Hardware: All
            Status: NEW
           Version: rel_3_8
         Component: Circulation
           Product: Koha


From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:46:56 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 20:46:56 +0000
Subject: [Koha-bugs] [Bug 8338] fines not cleared with dropbox mode
In-Reply-To: <bug-8338-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8338-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8338-70-U5LzFUjPkX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338

Melia Meggs <melia at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Depends on|                            |5644

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:46:56 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 20:46:56 +0000
Subject: [Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date
In-Reply-To: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5644-70-kN5m0NiVCh@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644

Melia Meggs <melia at bywatersolutions.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |8338

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:47:57 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 20:47:57 +0000
Subject: [Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date
In-Reply-To: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5644-70-qNh1LKoIUd@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644

--- Comment #9 from Melia Meggs <melia at bywatersolutions.com> ---
Thank you, Chris!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 22:59:48 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 20:59:48 +0000
Subject: [Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date
In-Reply-To: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5644-70-0ec1zEFHlY@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #10 from Chris Cormack <chris at bigballofwax.co.nz> ---
The problem is in Koha::Calendar


if ( $add_duration->is_negative() ){
  $day_dur->inverse();
}

This does not do what we expect, namely it does not invert the value.

Working on a fix now

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:06:55 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 21:06:55 +0000
Subject: [Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date
In-Reply-To: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5644-70-YY0J50SI6Q@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644

--- Comment #11 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 10571
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10571&action=edit
Bug 5644 : Fixing dropbox mode calculation

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:11:53 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 21:11:53 +0000
Subject: [Koha-bugs] [Bug 5644] dropbox mode doesn't set the correct date
In-Reply-To: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-5644-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-5644-70-uQ2KNhpLMU@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5644

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |Needs Signoff

--- Comment #12 from Chris Cormack <chris at bigballofwax.co.nz> ---
+----------------+------------+---------------------+------------+---------------+---------------------+-----------------+--------+----------+---------------------+---------------------+
| borrowernumber | itemnumber | date_due            | branchcode |
issuingbranch | returndate          | lastreneweddate | return | renewals |
timestamp           | issuedate           |
+----------------+------------+---------------------+------------+---------------+---------------------+-----------------+--------+----------+---------------------+---------------------+
|          15861 |      23035 | 2012-07-21 23:59:00 | ME         | NULL        
 | 2012-06-29 09:10:00 | NULL            | NULL   |     NULL | 2012-06-30
09:10:43 | 2012-06-30 09:09:00 |
+----------------+------------+---------------------+------------+---------------+---------------------+-----------------+--------+----------+---------------------+---------------------+


Looks to be working now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:22:40 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 21:22:40 +0000
Subject: [Koha-bugs] [Bug 8087] Calendar not working in dropbox mode
In-Reply-To: <bug-8087-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8087-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8087-70-nj1VCc4Pn2@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8087

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #4 from Chris Cormack <chris at bigballofwax.co.nz> ---
Albert that issue sounds totally unrelated to the dropbox, So either we should
change this bug description. Or make it resolved duplicate of bug 5644 (which
is to do with the calendar and dropbox)

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:30:33 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 21:30:33 +0000
Subject: [Koha-bugs] [Bug 8315] fix 'C4::Output 3.02' errors in Koha
In-Reply-To: <bug-8315-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8315-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8315-70-4ENujJWdBc@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8315

--- Comment #12 from Chris Cormack <chris at bigballofwax.co.nz> ---
First patch pushed to 3.8.x

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Fri Jun 29 23:48:32 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 21:48:32 +0000
Subject: [Koha-bugs] [Bug 8311] Mis-scoped function call in C4::Auth
In-Reply-To: <bug-8311-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8311-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8311-70-RBYiyKPGPF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8311

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Pushed to Master            |Pushed to Stable
                 CC|                            |chris at bigballofwax.co.nz

--- Comment #7 from Chris Cormack <chris at bigballofwax.co.nz> ---
Pushed to 3.8.x, will be in 3.8.3

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 30 00:02:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 22:02:04 +0000
Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
In-Reply-To: <bug-3280-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3280-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3280-70-z8Ng1GOuqF@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|rel_3_8                     |rel_3_10

--- Comment #18 from Chris Cormack <chris at bigballofwax.co.nz> ---
Because this now makes it impossible to send a cart without being logged in
(which is probably a valid change) it is a big behaviour change which I dont
want to spring on people mid cycle. Holding for 3.10

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 30 00:16:57 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 29 Jun 2012 22:16:57 +0000
Subject: [Koha-bugs] [Bug 8217] Focus on search box in Detail page (staff
	search)
In-Reply-To: <bug-8217-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8217-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8217-70-mVD06N8eKX@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217

--- Comment #16 from Chris Cormack <chris at bigballofwax.co.nz> ---
Follow up does not apply to 3.8.x

<<<<<<< HEAD                      
        $('#bibliodetails > ul').tabs(); 
=======                                                                         
        $('#bibliodetails').tabs();  
        $('#search-form').focus();    
>>>>>>> a4d2a99... Bug 8217: Followup: move code to the document.ready function   

Please

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 30 07:52:40 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jun 2012 05:52:40 +0000
Subject: [Koha-bugs] [Bug 4064] Uninitialized variable errors in
	opac-search.pl
In-Reply-To: <bug-4064-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4064-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4064-70-hk7JcyWaze@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4064

--- Comment #1 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 10572
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10572&action=edit
Optimized two if statements, but otherwise fixed already in master.

I was hunting through opac-search.pl and only found two references to
$params->{'offset'} other than the initialization line that oleonard pointed
out.

616:                if (($params->{'offset'}||'') eq '') {
594:                if (($params->{'offset'}||'') eq '') {

If the parameter is undefined, the two lines above will be true.
If the parameter is an empty string,  the two lines above will be true.
If the parameter is 0 or "0", the two lines above will be true.
If the parameter is a non-zero value or an otherwise non-empty string, the two
lines above will be false.

It would seem to me that the above code on lines 594 and 616 in master is
sufficient.

Additionally, oleonard mentioned $borrowernumber.
592:            if (!$borrowernumber || $borrowernumber eq '') {
This is the only line that resembles what oleonard referred to.

It would seem to me that the above code on line 592 in master is sufficient.

The initialization of $offset is now on line 400 in master:
my $offset = $params->{'offset'} || 0;
This implies that the parameter is expected to be numeric, not a string.

I think oleonard's observation that there is a $offset variable is useful to
note as everywhere else in opac-search.pl uses the $offset variable.

Based on the initialization line above:
If the parameter is undefined, $offset is 0.
If the parameter is an empty string,  $offset is 0.
If the parameter is 0 or "0", $offset is 0.
If the parameter is a non-zero value or an otherwise non-empty string, $offset
is that value or string.
This means that lines 616 and 594 could be optimized to:
616:                if (!$offset) {
594:                if (!$offset) {

Lines 592 and 594 correspond to the two lines oleonard mentions. This means I
believe the bug is fixed already. I am changing the status to Needs Signoff, as
this is not NEW. I'm attaching a patch accordingly, but feel free to reject it
and just close this.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 30 07:52:58 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jun 2012 05:52:58 +0000
Subject: [Koha-bugs] [Bug 4064] Uninitialized variable errors in
	opac-search.pl
In-Reply-To: <bug-4064-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-4064-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-4064-70-kr6jX4oJrA@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4064

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff
                 CC|                            |mtompset at hotmail.com

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 30 09:16:03 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jun 2012 07:16:03 +0000
Subject: [Koha-bugs] [Bug 3280] opac/opac-sendbasket.pl security leaky
In-Reply-To: <bug-3280-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-3280-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-3280-70-kONzbuhY5E@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280

--- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Hi Chris, but this is already the case in 3.6?

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 30 09:56:26 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jun 2012 07:56:26 +0000
Subject: [Koha-bugs] [Bug 8271] teach SIPServer to set its own lib path
In-Reply-To: <bug-8271-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8271-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8271-70-lEwwg6Rwy3@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8271

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10361|0                           |1
        is obsolete|                            |

--- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 10573
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10573&action=edit
Bug 8271 teach SIPServer.pm to set its own lib path

SIPServer.pm requires that C4/SIP is added to its lib
path This has been done by passing this directory
to it via -I. By using FindBin it can set the path
for itself correctly. This will also work if the C4/SIP
directory tree is moved to a non-standard location
Removed the now redundant -I. from sip_run.sh

Added a variable to sip_run.sh for the koha tree to
highlight a problem with the script if you have multiple
directories in the PERL5LIB environment variable

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 30 09:57:40 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jun 2012 07:57:40 +0000
Subject: [Koha-bugs] [Bug 8271] teach SIPServer to set its own lib path
In-Reply-To: <bug-8271-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8271-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8271-70-D3fSk28zSQ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8271

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 30 10:00:04 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jun 2012 08:00:04 +0000
Subject: [Koha-bugs] [Bug 8335] Missing Icon PR.png or typo in
	MARC21slim2OPACDetail.xsl
In-Reply-To: <bug-8335-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8335-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8335-70-BoTfB0HUDM@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8335

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10568|0                           |1
        is obsolete|                            |

--- Comment #2 from Chris Cormack <chris at bigballofwax.co.nz> ---
Created attachment 10574
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10574&action=edit
Bug 8335 - Missing Icon PR.png or typo in MARC21slim2OPACDetail.xsl

Add PR.png (renamed file music.png from http://famfamfam.com/lab/icons/ )

Signed-off-by: Chris Cormack <chris at bigballofwax.co.nz>

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 30 10:00:24 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jun 2012 08:00:24 +0000
Subject: [Koha-bugs] [Bug 8335] Missing Icon PR.png or typo in
	MARC21slim2OPACDetail.xsl
In-Reply-To: <bug-8335-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8335-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8335-70-y7iOqG88ML@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8335

Chris Cormack <chris at bigballofwax.co.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off
                 CC|                            |chris at bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 30 10:19:53 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jun 2012 08:19:53 +0000
Subject: [Koha-bugs] [Bug 8339] New: div id="login" should be
 id="login_controls" in header.inc
Message-ID: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339

          Priority: P5 - low
 Change sponsored?: ---
            Bug ID: 8339
          Assignee: oleonard at myacpl.org
           Summary: div id="login" should be id="login_controls" in
                    header.inc
          Severity: enhancement
    Classification: Unclassified
                OS: All
          Reporter: mtompset at hotmail.com
          Hardware: All
            Status: NEW
           Version: unspecified
         Component: Templates
           Product: Koha

If one wishes to customize the login screen of the staff client, CSS changes to
div#login also affect the control set in the top menu bar. The top menu bar
needs a different id name.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 30 16:00:53 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jun 2012 14:00:53 +0000
Subject: [Koha-bugs] [Bug 8339] div id="login" should be id="login_controls"
 in header.inc
In-Reply-To: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8339-70-WFeQ7GzCrJ@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339

--- Comment #1 from M. Tompsett <mtompset at hotmail.com> ---
Created attachment 10575
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10575&action=edit
changed from login to login_controls in header.inc and staff-global.css

I was wondering how this might affect other languages, as I was only testing
English. Similar changes would need to be made for them, as header.inc and
staff-global.css are in language dependent subdirectories. This would patch
English. Perhaps login_controls isn't a good enough name? I'm open to something
else, as long as it isn't login. Thank you.

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 30 16:01:31 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jun 2012 14:01:31 +0000
Subject: [Koha-bugs] [Bug 8339] div id="login" should be id="login_controls"
 in header.inc
In-Reply-To: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8339-70-Qv3OpQeg4N@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.

From bugzilla-daemon at bugs.koha-community.org  Sat Jun 30 21:56:46 2012
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 30 Jun 2012 19:56:46 +0000
Subject: [Koha-bugs] [Bug 8339] div id="login" should be id="login_controls"
 in header.inc
In-Reply-To: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/>
References: <bug-8339-70@http.bugs.koha-community.org/bugzilla3/>
Message-ID: <bug-8339-70-L38GqrRmIw@http.bugs.koha-community.org/bugzilla3/>

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8339

Katrin Fischer <katrin.fischer at bsz-bw.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katrin.fischer at bsz-bw.de

--- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
You only have to correct the English files, all other languages are created
from those files and the translations in the po files.

-- 
You are receiving this mail because:
You are watching all bug changes.