[Koha-bugs] [Bug 6840] error in Template.pm in logs

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6840

M. Tompsett <mtompset at hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtompset at hotmail.com

--- Comment #7 from M. Tompsett <mtompset at hotmail.com> ---
This patch is fine, in my opinion. The comment made by Fred P 2011-12-13
16:52:38 UTC is a different problem, in my reading. I proposed a solution to
his bug in bug 7630 (see also bug 7352).

The problem is not all modules call with the 'error' parameter set. And Fred
P's suggestion of:
#addition to test error parameter status
if ( $error ) {
    $template -> param (
        $error => 1,
        error => 1,
    );
}
is overkill compared to simply splitting up the large $template->param() call,
and having
$template->param($error => 1) if $error;
separately from the long list.

No, I didn't do any testing. I just don't want a good patch wasted. :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.