[Koha-bugs] [Bug 3638] Status of hold not changed when item checked in via SIP2 Interface

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3638

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Pushed to Master
                 CC|                            |paul.poulain at biblibre.com
            Version|master                      |rel_3_8

--- Comment #18 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment: I couldn't test the patch with a true selfcheck machine, but patch
pushed.

Colin, before the patch there was some perlcritic problems, they are still here
after the patch.

If you can submit a follow-up to fix them, that would be nice. Should be very
easy (removal or "return undef" in favour of "return" and removing prototyping
of subs)

16:11 ~/koha.dev/koha-community (new/bug_3638 $%)$ perlcritic
C4/SIP/ILS/Item.pm C4/SIP/ILS/Transaction/Checkin.pm C4/SIP/Sip/MsgType.pm
C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 89, column
3.  See page 199 of PBP.  (Severity: 5)
C4/SIP/ILS/Item.pm: Subroutine prototypes used at line 350, column 1.  See page
194 of PBP.  (Severity: 5)
C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 352,
column 26.  See page 199 of PBP.  (Severity: 5)
C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 353,
column 51.  See page 199 of PBP.  (Severity: 5)
C4/SIP/ILS/Item.pm: Subroutine prototypes used at line 356, column 1.  See page
194 of PBP.  (Severity: 5)
C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 359,
column 28.  See page 199 of PBP.  (Severity: 5)
C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 360,
column 28.  See page 199 of PBP.  (Severity: 5)
C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 361,
column 61.  See page 199 of PBP.  (Severity: 5)
C4/SIP/ILS/Item.pm: Subroutine prototypes used at line 364, column 1.  See page
194 of PBP.  (Severity: 5)
C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 366,
column 25.  See page 199 of PBP.  (Severity: 5)
C4/SIP/ILS/Item.pm: "return" statement with explicit "undef" at line 368,
column 24.  See page 199 of PBP.  (Severity: 5)
C4/SIP/ILS/Transaction/Checkin.pm source OK
C4/SIP/Sip/MsgType.pm: "return" statement with explicit "undef" at line 408,
column 3.  See page 199 of PBP.  (Severity: 5)
C4/SIP/Sip/MsgType.pm: Subroutine prototypes used at line 797, column 1.  See
page 194 of PBP.  (Severity: 5)
C4/SIP/Sip/MsgType.pm: "return" statement with explicit "undef" at line 798,
column 24.  See page 199 of PBP.  (Severity: 5)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.