[Koha-bugs] [Bug 6557] biblioitems.totalissues unused

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557

Ian Walls <koha.sekjal at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |koha.sekjal at gmail.com

--- Comment #18 from Ian Walls <koha.sekjal at gmail.com> ---
UpdateTotalIssues() has an avoidable inefficiency:  it calls both
GetBiblioData, and GetMarcBiblio.  GetBiblioData returns all columns from
biblio, biblioitems and itemtypes.  We only need biblio.frameworkcode,
biblioitems.totalissues and the $record (which can be obtained from
biblioitems.marcxml).

Additionally, the call from C4/Circulation to UpdateTotalIssues() occurs in
AddIssue, which already has a copy of the biblio pulled in from a call to
GetBiblioFromItemnumber (biblioitems.marc and biblioitems.marcxml).

So we already have all the data we need in AddIssues to do the update; it would
just be a matter of creating the MARC::Record object and doing a ModBiblio to
update the right field.

Modifying the cronjob to also return the MARC record and frameworkcode would
let both means interface with the subroutine, so the library can still decide
whether to take the slightened performance hit (or build from stats the first
time).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.