[Koha-bugs] [Bug 6557] biblioitems.totalissues unused

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6557

M. de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Passed QA

--- Comment #21 from M. de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment
Nice feature. Well documented incl. test plan. Code looks good.

Just a thought on UpdateTotalIssues:
BTW Note the comment from Ian earlier.
Also: something simple: checking if biblionumber makes sense? Record exists?
(Strange things happen..)
Could be handled in the same followup suggested for Ians remarks.

Will your use of commit trigger commit-ineffective-warnings in most cases
(autocommit will be on by default) ?
You do not have begin_work / rollback stuff.
Since you offer a commit parameter, I wonder if you promise too much? Normally,
the update is written directly to the database.
If you actually would use a transaction with begin_work, you should check if it
is possible etc. too.
No blocker for me.

process_stats could have used a few comments on the various queries used.
See now what it does, but should not need that deduction ;)

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.