[Koha-bugs] [Bug 5337] acq EAN search

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5337

--- Comment #31 from Matthias Meusburger <matthias.meusburger at biblibre.com> ---
(En réponse au commentaire 30)

>  Note that it was signed-off by jean-manuel.broust at univ-lyon2.fr. The patch commit does not show that however. Please fix that too.

Done


> The atomicupdate file could be removed (adding the field is done in
> updatedatabase)?

Ok, removed.

The version number there should be filled with XXX instead of 005.

Fixed

> Why do you need a index in deletedbiblioitems on ean? Please clarify.

You're right, indeed. Nothing really justify the use of and index on this
field. Removed.

> 
> The commit reads: However, if you already have records with ean, you will
> have to run misc/batchRebuildBiblioTables.pl to populate biblioitems.ean.
> Should this be published too in the update print statement or anywhere else
> too? 

I've added the message in the updatedatabase (in case the marcflavor is
unimarc, otherwise the mapping is not automatically added, and there's no need
for rebuilding biblio tables).
Do you think of another place where this message should be added?

> 
> Routine GetSubscriptions: You add line:
> $sqlwhere .= ( $sqlwhere ? " AND " : " WHERE " ) . "(" . join( ") OR (",
> @sqlstrings ) . ")";
> Please add an additional ( and ) around this construct, just as is done a
> few lines above it. This prevents wrong interpretation of the whole
> expression.

Done

> 
> Since you are adding parameters to existing routines: Did you check if you
> did not miss any function call for the two routines changed? You should grep
> on the name only. Do not assume that the name always is immediately followed
> by parenthesis. Could be whitespace also. Note that I find instances of test
> scripts referring to the function that you do not change (e.g.
> t/db_dependent/Serials.t). Please verify. BLOCKER too.

I've done the grep with only the function name and it seems that every call in
the source code has been changed. But yes, the tests should have been changed
too. Now it's done. I added ean test to t/db_dependent/Serials.t. I added ean
(and isbn, which was missing) test to
t/db_dependent/lib/KohaTest/Acquisition/GetHistory.pm.

> 
> Please clarify: Why a span if biblionumber passed and otherwise a label in
> neworderempty.tt change?

The neworderempty page allows to add catalogue informations (title, author,
ean...) to an order while creating a new order. However, those informations
cannot be directly modified when editing an existing order (there's a link for
editing the record). This is why it's only a label when there is a
biblionumber.

-- 
You are receiving this mail because:
You are watching all bug changes.