[Koha-bugs] [Bug 8034] Enable server print queue selection

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8034

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Signed Off                  |Failed QA
                 CC|                            |paul.poulain at biblibre.com

--- Comment #5 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comments:

 * I don't understand the need/use of 
+    my $userenv_branch = $userenv ? $userenv->{"branch"} : undef;
 why don't you use $userenv->{"branch"} ?
 * the sub 
+ =head2 get_user_printer
 must not be in C4/Auth.pm, but in C4/Print.pm (not a perfect option) or in
Koha:: namespace (in the hackfest currently running, I've proposed a time to
discuss of naming convention/organisation for Koha:: namespace)
 * same comment for sub GetPrinterDetails {, should not be in C4/Koha.pm

Other than this, the code looks OK (haven't tested it yet)

-- 
You are receiving this mail because:
You are watching all bug changes.