[Koha-bugs] [Bug 8004] Items on Hold Lose Transfer After Being Scanned Twice

[bugzilla-daemon at bugs.koha-community.org]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8004

Paul Poulain <paul.poulain at biblibre.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |paul.poulain at biblibre.com

--- Comment #3 from Paul Poulain <paul.poulain at biblibre.com> ---
QA comment:

 * Kyle, what is fun is the answer to your question:
> This is because at some point, someone replaced the template
> variable WrongTransfer, which had previously contained the branchcode for
> the library to transfer to, with the full name of the library instead ( I
> assume to make a look nicer ).
git blame circ/returns.pl, says:
74f6e35c (Kyle M Hall          2010-04-01 15:45:25 +0000 340)    
$messages->{'WrongTransfer'} = GetBranchName( $messa...

:D :D (and, incenditally, it's 2 years old !)

However, this is a tiny patch, that adds a new plugin. After the presentation
chris made today about T::T plugins/views/..., i'm wondering if creating a
plugin for that is the best option we have. Shouldn't it be a view ?

Plus, if I push this patch, it means we should get rid of any branchname
display everywhere, remove LEFT JOIN branches USING(branchname) in many SQL
queries, cache GetBranchName to avoid useless SQL queries (branches are not
updated frequently, they are a good candidate for caching).
I'm not against this idea (in fact, I like it quite a lot), but we must
advertise it as much as possible, and if you can promize you'll take care of
patches cleaning branchname dependancies, that would be a good + ;-)

I won't push the patch immediately, I suggest we speak of it tomorrow with
other hackers, and chris_c first, as he is experienced on T::T

-- 
You are receiving this mail because:
You are watching all bug changes.